Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit b3139bbc52762268769e7af842aade0e64372433

Authored by Julia Lawall
Committed by James Morris
1 parent 9e4b50e937
Exists in master and in 7 other branches imx_3.0.35_4.1.0, imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-l5.0.0_1.0.0-ga

security/selinux/ss: Use kstrdup 

Use kstrdup when the goal of an allocation is copy a string into the
allocated region.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression from,to;
expression flag,E1,E2;
statement S;
@@

-  to = kmalloc(strlen(from) + 1,flag);
+  to = kstrdup(from, flag);
   ... when != \(from = E1 \| to = E1 \)
   if (to==NULL || ...) S
   ... when != \(from = E2 \| to = E2 \)
-  strcpy(to, from);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Eric Paris <eparis@redhat.com>
Signed-off-by: James Morris <jmorris@namei.org>

Showing 1 changed file with 1 additions and 2 deletions Side-by-side Diff

security/selinux/ss/policydb.c
Diff comments   View file @ b3139bb
... ... @@ -156,12 +156,11 @@
156 156 rc = -EINVAL;
157 157 goto out_free_role;
158 158 }
159   - key = kmalloc(strlen(OBJECT_R) + 1, GFP_KERNEL);
  159 + key = kstrdup(OBJECT_R, GFP_KERNEL);
160 160 if (!key) {
161 161 rc = -ENOMEM;
162 162 goto out_free_role;
163 163 }
164   - strcpy(key, OBJECT_R);
165 164 rc = hashtab_insert(p->p_roles.table, key, role);
166 165 if (rc)
167 166 goto out_free_key;