Commit b9047599695ae835252ba3d6a19eada98c19dc89

Authored by Zhang Rui
Committed by Len Brown
1 parent 32d47eeff0

ACPI thermal: remove two unused functions

When CONFIG_CPU_FREQ=n ...

drivers/acpi/processor_thermal.c:159:12: warning: ‘acpi_thermal_cpufreq_increase’ defined but not used
drivers/acpi/processor_thermal.c:163:12: warning: ‘acpi_thermal_cpufreq_decrease’ defined but not used

Remove unused declaration of ‘acpi_thermal_cpufreq_increase’ and
‘acpi_thermal_cpufreq_decrease’

Signed-off-by: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>

Showing 1 changed file with 0 additions and 9 deletions Inline Diff

drivers/acpi/processor_thermal.c
1 /* 1 /*
2 * processor_thermal.c - Passive cooling submodule of the ACPI processor driver 2 * processor_thermal.c - Passive cooling submodule of the ACPI processor driver
3 * 3 *
4 * Copyright (C) 2001, 2002 Andy Grover <andrew.grover@intel.com> 4 * Copyright (C) 2001, 2002 Andy Grover <andrew.grover@intel.com>
5 * Copyright (C) 2001, 2002 Paul Diefenbaugh <paul.s.diefenbaugh@intel.com> 5 * Copyright (C) 2001, 2002 Paul Diefenbaugh <paul.s.diefenbaugh@intel.com>
6 * Copyright (C) 2004 Dominik Brodowski <linux@brodo.de> 6 * Copyright (C) 2004 Dominik Brodowski <linux@brodo.de>
7 * Copyright (C) 2004 Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> 7 * Copyright (C) 2004 Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
8 * - Added processor hotplug support 8 * - Added processor hotplug support
9 * 9 *
10 * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 10 * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
11 * 11 *
12 * This program is free software; you can redistribute it and/or modify 12 * This program is free software; you can redistribute it and/or modify
13 * it under the terms of the GNU General Public License as published by 13 * it under the terms of the GNU General Public License as published by
14 * the Free Software Foundation; either version 2 of the License, or (at 14 * the Free Software Foundation; either version 2 of the License, or (at
15 * your option) any later version. 15 * your option) any later version.
16 * 16 *
17 * This program is distributed in the hope that it will be useful, but 17 * This program is distributed in the hope that it will be useful, but
18 * WITHOUT ANY WARRANTY; without even the implied warranty of 18 * WITHOUT ANY WARRANTY; without even the implied warranty of
19 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 19 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
20 * General Public License for more details. 20 * General Public License for more details.
21 * 21 *
22 * You should have received a copy of the GNU General Public License along 22 * You should have received a copy of the GNU General Public License along
23 * with this program; if not, write to the Free Software Foundation, Inc., 23 * with this program; if not, write to the Free Software Foundation, Inc.,
24 * 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA. 24 * 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA.
25 * 25 *
26 * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 26 * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
27 */ 27 */
28 28
29 #include <linux/kernel.h> 29 #include <linux/kernel.h>
30 #include <linux/module.h> 30 #include <linux/module.h>
31 #include <linux/init.h> 31 #include <linux/init.h>
32 #include <linux/cpufreq.h> 32 #include <linux/cpufreq.h>
33 #include <linux/sysdev.h> 33 #include <linux/sysdev.h>
34 34
35 #include <asm/uaccess.h> 35 #include <asm/uaccess.h>
36 36
37 #include <acpi/acpi_bus.h> 37 #include <acpi/acpi_bus.h>
38 #include <acpi/processor.h> 38 #include <acpi/processor.h>
39 #include <acpi/acpi_drivers.h> 39 #include <acpi/acpi_drivers.h>
40 40
41 #define PREFIX "ACPI: " 41 #define PREFIX "ACPI: "
42 42
43 #define ACPI_PROCESSOR_CLASS "processor" 43 #define ACPI_PROCESSOR_CLASS "processor"
44 #define _COMPONENT ACPI_PROCESSOR_COMPONENT 44 #define _COMPONENT ACPI_PROCESSOR_COMPONENT
45 ACPI_MODULE_NAME("processor_thermal"); 45 ACPI_MODULE_NAME("processor_thermal");
46 46
47 #ifdef CONFIG_CPU_FREQ 47 #ifdef CONFIG_CPU_FREQ
48 48
49 /* If a passive cooling situation is detected, primarily CPUfreq is used, as it 49 /* If a passive cooling situation is detected, primarily CPUfreq is used, as it
50 * offers (in most cases) voltage scaling in addition to frequency scaling, and 50 * offers (in most cases) voltage scaling in addition to frequency scaling, and
51 * thus a cubic (instead of linear) reduction of energy. Also, we allow for 51 * thus a cubic (instead of linear) reduction of energy. Also, we allow for
52 * _any_ cpufreq driver and not only the acpi-cpufreq driver. 52 * _any_ cpufreq driver and not only the acpi-cpufreq driver.
53 */ 53 */
54 54
55 #define CPUFREQ_THERMAL_MIN_STEP 0 55 #define CPUFREQ_THERMAL_MIN_STEP 0
56 #define CPUFREQ_THERMAL_MAX_STEP 3 56 #define CPUFREQ_THERMAL_MAX_STEP 3
57 57
58 static DEFINE_PER_CPU(unsigned int, cpufreq_thermal_reduction_pctg); 58 static DEFINE_PER_CPU(unsigned int, cpufreq_thermal_reduction_pctg);
59 static unsigned int acpi_thermal_cpufreq_is_init = 0; 59 static unsigned int acpi_thermal_cpufreq_is_init = 0;
60 60
61 static int cpu_has_cpufreq(unsigned int cpu) 61 static int cpu_has_cpufreq(unsigned int cpu)
62 { 62 {
63 struct cpufreq_policy policy; 63 struct cpufreq_policy policy;
64 if (!acpi_thermal_cpufreq_is_init || cpufreq_get_policy(&policy, cpu)) 64 if (!acpi_thermal_cpufreq_is_init || cpufreq_get_policy(&policy, cpu))
65 return 0; 65 return 0;
66 return 1; 66 return 1;
67 } 67 }
68 68
69 static int acpi_thermal_cpufreq_notifier(struct notifier_block *nb, 69 static int acpi_thermal_cpufreq_notifier(struct notifier_block *nb,
70 unsigned long event, void *data) 70 unsigned long event, void *data)
71 { 71 {
72 struct cpufreq_policy *policy = data; 72 struct cpufreq_policy *policy = data;
73 unsigned long max_freq = 0; 73 unsigned long max_freq = 0;
74 74
75 if (event != CPUFREQ_ADJUST) 75 if (event != CPUFREQ_ADJUST)
76 goto out; 76 goto out;
77 77
78 max_freq = ( 78 max_freq = (
79 policy->cpuinfo.max_freq * 79 policy->cpuinfo.max_freq *
80 (100 - per_cpu(cpufreq_thermal_reduction_pctg, policy->cpu) * 20) 80 (100 - per_cpu(cpufreq_thermal_reduction_pctg, policy->cpu) * 20)
81 ) / 100; 81 ) / 100;
82 82
83 cpufreq_verify_within_limits(policy, 0, max_freq); 83 cpufreq_verify_within_limits(policy, 0, max_freq);
84 84
85 out: 85 out:
86 return 0; 86 return 0;
87 } 87 }
88 88
89 static struct notifier_block acpi_thermal_cpufreq_notifier_block = { 89 static struct notifier_block acpi_thermal_cpufreq_notifier_block = {
90 .notifier_call = acpi_thermal_cpufreq_notifier, 90 .notifier_call = acpi_thermal_cpufreq_notifier,
91 }; 91 };
92 92
93 static int cpufreq_get_max_state(unsigned int cpu) 93 static int cpufreq_get_max_state(unsigned int cpu)
94 { 94 {
95 if (!cpu_has_cpufreq(cpu)) 95 if (!cpu_has_cpufreq(cpu))
96 return 0; 96 return 0;
97 97
98 return CPUFREQ_THERMAL_MAX_STEP; 98 return CPUFREQ_THERMAL_MAX_STEP;
99 } 99 }
100 100
101 static int cpufreq_get_cur_state(unsigned int cpu) 101 static int cpufreq_get_cur_state(unsigned int cpu)
102 { 102 {
103 if (!cpu_has_cpufreq(cpu)) 103 if (!cpu_has_cpufreq(cpu))
104 return 0; 104 return 0;
105 105
106 return per_cpu(cpufreq_thermal_reduction_pctg, cpu); 106 return per_cpu(cpufreq_thermal_reduction_pctg, cpu);
107 } 107 }
108 108
109 static int cpufreq_set_cur_state(unsigned int cpu, int state) 109 static int cpufreq_set_cur_state(unsigned int cpu, int state)
110 { 110 {
111 if (!cpu_has_cpufreq(cpu)) 111 if (!cpu_has_cpufreq(cpu))
112 return 0; 112 return 0;
113 113
114 per_cpu(cpufreq_thermal_reduction_pctg, cpu) = state; 114 per_cpu(cpufreq_thermal_reduction_pctg, cpu) = state;
115 cpufreq_update_policy(cpu); 115 cpufreq_update_policy(cpu);
116 return 0; 116 return 0;
117 } 117 }
118 118
119 void acpi_thermal_cpufreq_init(void) 119 void acpi_thermal_cpufreq_init(void)
120 { 120 {
121 int i; 121 int i;
122 122
123 for (i = 0; i < nr_cpu_ids; i++) 123 for (i = 0; i < nr_cpu_ids; i++)
124 if (cpu_present(i)) 124 if (cpu_present(i))
125 per_cpu(cpufreq_thermal_reduction_pctg, i) = 0; 125 per_cpu(cpufreq_thermal_reduction_pctg, i) = 0;
126 126
127 i = cpufreq_register_notifier(&acpi_thermal_cpufreq_notifier_block, 127 i = cpufreq_register_notifier(&acpi_thermal_cpufreq_notifier_block,
128 CPUFREQ_POLICY_NOTIFIER); 128 CPUFREQ_POLICY_NOTIFIER);
129 if (!i) 129 if (!i)
130 acpi_thermal_cpufreq_is_init = 1; 130 acpi_thermal_cpufreq_is_init = 1;
131 } 131 }
132 132
133 void acpi_thermal_cpufreq_exit(void) 133 void acpi_thermal_cpufreq_exit(void)
134 { 134 {
135 if (acpi_thermal_cpufreq_is_init) 135 if (acpi_thermal_cpufreq_is_init)
136 cpufreq_unregister_notifier 136 cpufreq_unregister_notifier
137 (&acpi_thermal_cpufreq_notifier_block, 137 (&acpi_thermal_cpufreq_notifier_block,
138 CPUFREQ_POLICY_NOTIFIER); 138 CPUFREQ_POLICY_NOTIFIER);
139 139
140 acpi_thermal_cpufreq_is_init = 0; 140 acpi_thermal_cpufreq_is_init = 0;
141 } 141 }
142 142
143 #else /* ! CONFIG_CPU_FREQ */ 143 #else /* ! CONFIG_CPU_FREQ */
144 static int cpufreq_get_max_state(unsigned int cpu) 144 static int cpufreq_get_max_state(unsigned int cpu)
145 { 145 {
146 return 0; 146 return 0;
147 } 147 }
148 148
149 static int cpufreq_get_cur_state(unsigned int cpu) 149 static int cpufreq_get_cur_state(unsigned int cpu)
150 { 150 {
151 return 0; 151 return 0;
152 } 152 }
153 153
154 static int cpufreq_set_cur_state(unsigned int cpu, int state) 154 static int cpufreq_set_cur_state(unsigned int cpu, int state)
155 { 155 {
156 return 0; 156 return 0;
157 } 157 }
158 158
159 static int acpi_thermal_cpufreq_increase(unsigned int cpu)
160 {
161 return -ENODEV;
162 }
163 static int acpi_thermal_cpufreq_decrease(unsigned int cpu)
164 {
165 return -ENODEV;
166 }
167
168 #endif 159 #endif
169 160
170 int acpi_processor_get_limit_info(struct acpi_processor *pr) 161 int acpi_processor_get_limit_info(struct acpi_processor *pr)
171 { 162 {
172 163
173 if (!pr) 164 if (!pr)
174 return -EINVAL; 165 return -EINVAL;
175 166
176 if (pr->flags.throttling) 167 if (pr->flags.throttling)
177 pr->flags.limit = 1; 168 pr->flags.limit = 1;
178 169
179 return 0; 170 return 0;
180 } 171 }
181 172
182 /* thermal coolign device callbacks */ 173 /* thermal coolign device callbacks */
183 static int acpi_processor_max_state(struct acpi_processor *pr) 174 static int acpi_processor_max_state(struct acpi_processor *pr)
184 { 175 {
185 int max_state = 0; 176 int max_state = 0;
186 177
187 /* 178 /*
188 * There exists four states according to 179 * There exists four states according to
189 * cpufreq_thermal_reduction_ptg. 0, 1, 2, 3 180 * cpufreq_thermal_reduction_ptg. 0, 1, 2, 3
190 */ 181 */
191 max_state += cpufreq_get_max_state(pr->id); 182 max_state += cpufreq_get_max_state(pr->id);
192 if (pr->flags.throttling) 183 if (pr->flags.throttling)
193 max_state += (pr->throttling.state_count -1); 184 max_state += (pr->throttling.state_count -1);
194 185
195 return max_state; 186 return max_state;
196 } 187 }
197 static int 188 static int
198 processor_get_max_state(struct thermal_cooling_device *cdev, 189 processor_get_max_state(struct thermal_cooling_device *cdev,
199 unsigned long *state) 190 unsigned long *state)
200 { 191 {
201 struct acpi_device *device = cdev->devdata; 192 struct acpi_device *device = cdev->devdata;
202 struct acpi_processor *pr = acpi_driver_data(device); 193 struct acpi_processor *pr = acpi_driver_data(device);
203 194
204 if (!device || !pr) 195 if (!device || !pr)
205 return -EINVAL; 196 return -EINVAL;
206 197
207 *state = acpi_processor_max_state(pr); 198 *state = acpi_processor_max_state(pr);
208 return 0; 199 return 0;
209 } 200 }
210 201
211 static int 202 static int
212 processor_get_cur_state(struct thermal_cooling_device *cdev, 203 processor_get_cur_state(struct thermal_cooling_device *cdev,
213 unsigned long *cur_state) 204 unsigned long *cur_state)
214 { 205 {
215 struct acpi_device *device = cdev->devdata; 206 struct acpi_device *device = cdev->devdata;
216 struct acpi_processor *pr = acpi_driver_data(device); 207 struct acpi_processor *pr = acpi_driver_data(device);
217 208
218 if (!device || !pr) 209 if (!device || !pr)
219 return -EINVAL; 210 return -EINVAL;
220 211
221 *cur_state = cpufreq_get_cur_state(pr->id); 212 *cur_state = cpufreq_get_cur_state(pr->id);
222 if (pr->flags.throttling) 213 if (pr->flags.throttling)
223 *cur_state += pr->throttling.state; 214 *cur_state += pr->throttling.state;
224 return 0; 215 return 0;
225 } 216 }
226 217
227 static int 218 static int
228 processor_set_cur_state(struct thermal_cooling_device *cdev, 219 processor_set_cur_state(struct thermal_cooling_device *cdev,
229 unsigned long state) 220 unsigned long state)
230 { 221 {
231 struct acpi_device *device = cdev->devdata; 222 struct acpi_device *device = cdev->devdata;
232 struct acpi_processor *pr = acpi_driver_data(device); 223 struct acpi_processor *pr = acpi_driver_data(device);
233 int result = 0; 224 int result = 0;
234 int max_pstate; 225 int max_pstate;
235 226
236 if (!device || !pr) 227 if (!device || !pr)
237 return -EINVAL; 228 return -EINVAL;
238 229
239 max_pstate = cpufreq_get_max_state(pr->id); 230 max_pstate = cpufreq_get_max_state(pr->id);
240 231
241 if (state > acpi_processor_max_state(pr)) 232 if (state > acpi_processor_max_state(pr))
242 return -EINVAL; 233 return -EINVAL;
243 234
244 if (state <= max_pstate) { 235 if (state <= max_pstate) {
245 if (pr->flags.throttling && pr->throttling.state) 236 if (pr->flags.throttling && pr->throttling.state)
246 result = acpi_processor_set_throttling(pr, 0, false); 237 result = acpi_processor_set_throttling(pr, 0, false);
247 cpufreq_set_cur_state(pr->id, state); 238 cpufreq_set_cur_state(pr->id, state);
248 } else { 239 } else {
249 cpufreq_set_cur_state(pr->id, max_pstate); 240 cpufreq_set_cur_state(pr->id, max_pstate);
250 result = acpi_processor_set_throttling(pr, 241 result = acpi_processor_set_throttling(pr,
251 state - max_pstate, false); 242 state - max_pstate, false);
252 } 243 }
253 return result; 244 return result;
254 } 245 }
255 246
256 struct thermal_cooling_device_ops processor_cooling_ops = { 247 struct thermal_cooling_device_ops processor_cooling_ops = {
257 .get_max_state = processor_get_max_state, 248 .get_max_state = processor_get_max_state,
258 .get_cur_state = processor_get_cur_state, 249 .get_cur_state = processor_get_cur_state,
259 .set_cur_state = processor_set_cur_state, 250 .set_cur_state = processor_set_cur_state,
260 }; 251 };
261 252