Commit c984123c7a888731b7e971e1c878b6f2b716b292

Authored by Marcin Slusarz
Committed by Jeff Garzik
1 parent 78d5ae39af

pata_rz1000: use printk_once

Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

Showing 1 changed file with 1 additions and 3 deletions Inline Diff

drivers/ata/pata_rz1000.c
1 /* 1 /*
2 * RZ1000/1001 driver based upon 2 * RZ1000/1001 driver based upon
3 * 3 *
4 * linux/drivers/ide/pci/rz1000.c Version 0.06 January 12, 2003 4 * linux/drivers/ide/pci/rz1000.c Version 0.06 January 12, 2003
5 * Copyright (C) 1995-1998 Linus Torvalds & author (see below) 5 * Copyright (C) 1995-1998 Linus Torvalds & author (see below)
6 * Principal Author: mlord@pobox.com (Mark Lord) 6 * Principal Author: mlord@pobox.com (Mark Lord)
7 * 7 *
8 * See linux/MAINTAINERS for address of current maintainer. 8 * See linux/MAINTAINERS for address of current maintainer.
9 * 9 *
10 * This file provides support for disabling the buggy read-ahead 10 * This file provides support for disabling the buggy read-ahead
11 * mode of the RZ1000 IDE chipset, commonly used on Intel motherboards. 11 * mode of the RZ1000 IDE chipset, commonly used on Intel motherboards.
12 */ 12 */
13 13
14 #include <linux/kernel.h> 14 #include <linux/kernel.h>
15 #include <linux/module.h> 15 #include <linux/module.h>
16 #include <linux/pci.h> 16 #include <linux/pci.h>
17 #include <linux/init.h> 17 #include <linux/init.h>
18 #include <linux/blkdev.h> 18 #include <linux/blkdev.h>
19 #include <linux/delay.h> 19 #include <linux/delay.h>
20 #include <scsi/scsi_host.h> 20 #include <scsi/scsi_host.h>
21 #include <linux/libata.h> 21 #include <linux/libata.h>
22 22
23 #define DRV_NAME "pata_rz1000" 23 #define DRV_NAME "pata_rz1000"
24 #define DRV_VERSION "0.2.4" 24 #define DRV_VERSION "0.2.4"
25 25
26 26
27 /** 27 /**
28 * rz1000_set_mode - mode setting function 28 * rz1000_set_mode - mode setting function
29 * @link: ATA link 29 * @link: ATA link
30 * @unused: returned device on set_mode failure 30 * @unused: returned device on set_mode failure
31 * 31 *
32 * Use a non standard set_mode function. We don't want to be tuned. We 32 * Use a non standard set_mode function. We don't want to be tuned. We
33 * would prefer to be BIOS generic but for the fact our hardware is 33 * would prefer to be BIOS generic but for the fact our hardware is
34 * whacked out. 34 * whacked out.
35 */ 35 */
36 36
37 static int rz1000_set_mode(struct ata_link *link, struct ata_device **unused) 37 static int rz1000_set_mode(struct ata_link *link, struct ata_device **unused)
38 { 38 {
39 struct ata_device *dev; 39 struct ata_device *dev;
40 40
41 ata_for_each_dev(dev, link, ENABLED) { 41 ata_for_each_dev(dev, link, ENABLED) {
42 /* We don't really care */ 42 /* We don't really care */
43 dev->pio_mode = XFER_PIO_0; 43 dev->pio_mode = XFER_PIO_0;
44 dev->xfer_mode = XFER_PIO_0; 44 dev->xfer_mode = XFER_PIO_0;
45 dev->xfer_shift = ATA_SHIFT_PIO; 45 dev->xfer_shift = ATA_SHIFT_PIO;
46 dev->flags |= ATA_DFLAG_PIO; 46 dev->flags |= ATA_DFLAG_PIO;
47 ata_dev_printk(dev, KERN_INFO, "configured for PIO\n"); 47 ata_dev_printk(dev, KERN_INFO, "configured for PIO\n");
48 } 48 }
49 return 0; 49 return 0;
50 } 50 }
51 51
52 52
53 static struct scsi_host_template rz1000_sht = { 53 static struct scsi_host_template rz1000_sht = {
54 ATA_PIO_SHT(DRV_NAME), 54 ATA_PIO_SHT(DRV_NAME),
55 }; 55 };
56 56
57 static struct ata_port_operations rz1000_port_ops = { 57 static struct ata_port_operations rz1000_port_ops = {
58 .inherits = &ata_sff_port_ops, 58 .inherits = &ata_sff_port_ops,
59 .cable_detect = ata_cable_40wire, 59 .cable_detect = ata_cable_40wire,
60 .set_mode = rz1000_set_mode, 60 .set_mode = rz1000_set_mode,
61 }; 61 };
62 62
63 static int rz1000_fifo_disable(struct pci_dev *pdev) 63 static int rz1000_fifo_disable(struct pci_dev *pdev)
64 { 64 {
65 u16 reg; 65 u16 reg;
66 /* Be exceptionally paranoid as we must be sure to apply the fix */ 66 /* Be exceptionally paranoid as we must be sure to apply the fix */
67 if (pci_read_config_word(pdev, 0x40, &reg) != 0) 67 if (pci_read_config_word(pdev, 0x40, &reg) != 0)
68 return -1; 68 return -1;
69 reg &= 0xDFFF; 69 reg &= 0xDFFF;
70 if (pci_write_config_word(pdev, 0x40, reg) != 0) 70 if (pci_write_config_word(pdev, 0x40, reg) != 0)
71 return -1; 71 return -1;
72 printk(KERN_INFO DRV_NAME ": disabled chipset readahead.\n"); 72 printk(KERN_INFO DRV_NAME ": disabled chipset readahead.\n");
73 return 0; 73 return 0;
74 } 74 }
75 75
76 /** 76 /**
77 * rz1000_init_one - Register RZ1000 ATA PCI device with kernel services 77 * rz1000_init_one - Register RZ1000 ATA PCI device with kernel services
78 * @pdev: PCI device to register 78 * @pdev: PCI device to register
79 * @ent: Entry in rz1000_pci_tbl matching with @pdev 79 * @ent: Entry in rz1000_pci_tbl matching with @pdev
80 * 80 *
81 * Configure an RZ1000 interface. This doesn't require much special 81 * Configure an RZ1000 interface. This doesn't require much special
82 * handling except that we *MUST* kill the chipset readahead or the 82 * handling except that we *MUST* kill the chipset readahead or the
83 * user may experience data corruption. 83 * user may experience data corruption.
84 */ 84 */
85 85
86 static int rz1000_init_one (struct pci_dev *pdev, const struct pci_device_id *ent) 86 static int rz1000_init_one (struct pci_dev *pdev, const struct pci_device_id *ent)
87 { 87 {
88 static int printed_version;
89 static const struct ata_port_info info = { 88 static const struct ata_port_info info = {
90 .flags = ATA_FLAG_SLAVE_POSS, 89 .flags = ATA_FLAG_SLAVE_POSS,
91 .pio_mask = ATA_PIO4, 90 .pio_mask = ATA_PIO4,
92 .port_ops = &rz1000_port_ops 91 .port_ops = &rz1000_port_ops
93 }; 92 };
94 const struct ata_port_info *ppi[] = { &info, NULL }; 93 const struct ata_port_info *ppi[] = { &info, NULL };
95 94
96 if (!printed_version++) 95 printk_once(KERN_DEBUG DRV_NAME " version " DRV_VERSION "\n");
97 printk(KERN_DEBUG DRV_NAME " version " DRV_VERSION "\n");
98 96
99 if (rz1000_fifo_disable(pdev) == 0) 97 if (rz1000_fifo_disable(pdev) == 0)
100 return ata_pci_sff_init_one(pdev, ppi, &rz1000_sht, NULL); 98 return ata_pci_sff_init_one(pdev, ppi, &rz1000_sht, NULL);
101 99
102 printk(KERN_ERR DRV_NAME ": failed to disable read-ahead on chipset..\n"); 100 printk(KERN_ERR DRV_NAME ": failed to disable read-ahead on chipset..\n");
103 /* Not safe to use so skip */ 101 /* Not safe to use so skip */
104 return -ENODEV; 102 return -ENODEV;
105 } 103 }
106 104
107 #ifdef CONFIG_PM 105 #ifdef CONFIG_PM
108 static int rz1000_reinit_one(struct pci_dev *pdev) 106 static int rz1000_reinit_one(struct pci_dev *pdev)
109 { 107 {
110 /* If this fails on resume (which is a "cant happen" case), we 108 /* If this fails on resume (which is a "cant happen" case), we
111 must stop as any progress risks data loss */ 109 must stop as any progress risks data loss */
112 if (rz1000_fifo_disable(pdev)) 110 if (rz1000_fifo_disable(pdev))
113 panic("rz1000 fifo"); 111 panic("rz1000 fifo");
114 return ata_pci_device_resume(pdev); 112 return ata_pci_device_resume(pdev);
115 } 113 }
116 #endif 114 #endif
117 115
118 static const struct pci_device_id pata_rz1000[] = { 116 static const struct pci_device_id pata_rz1000[] = {
119 { PCI_VDEVICE(PCTECH, PCI_DEVICE_ID_PCTECH_RZ1000), }, 117 { PCI_VDEVICE(PCTECH, PCI_DEVICE_ID_PCTECH_RZ1000), },
120 { PCI_VDEVICE(PCTECH, PCI_DEVICE_ID_PCTECH_RZ1001), }, 118 { PCI_VDEVICE(PCTECH, PCI_DEVICE_ID_PCTECH_RZ1001), },
121 119
122 { }, 120 { },
123 }; 121 };
124 122
125 static struct pci_driver rz1000_pci_driver = { 123 static struct pci_driver rz1000_pci_driver = {
126 .name = DRV_NAME, 124 .name = DRV_NAME,
127 .id_table = pata_rz1000, 125 .id_table = pata_rz1000,
128 .probe = rz1000_init_one, 126 .probe = rz1000_init_one,
129 .remove = ata_pci_remove_one, 127 .remove = ata_pci_remove_one,
130 #ifdef CONFIG_PM 128 #ifdef CONFIG_PM
131 .suspend = ata_pci_device_suspend, 129 .suspend = ata_pci_device_suspend,
132 .resume = rz1000_reinit_one, 130 .resume = rz1000_reinit_one,
133 #endif 131 #endif
134 }; 132 };
135 133
136 static int __init rz1000_init(void) 134 static int __init rz1000_init(void)
137 { 135 {
138 return pci_register_driver(&rz1000_pci_driver); 136 return pci_register_driver(&rz1000_pci_driver);
139 } 137 }
140 138
141 static void __exit rz1000_exit(void) 139 static void __exit rz1000_exit(void)
142 { 140 {
143 pci_unregister_driver(&rz1000_pci_driver); 141 pci_unregister_driver(&rz1000_pci_driver);
144 } 142 }
145 143
146 MODULE_AUTHOR("Alan Cox"); 144 MODULE_AUTHOR("Alan Cox");
147 MODULE_DESCRIPTION("low-level driver for RZ1000 PCI ATA"); 145 MODULE_DESCRIPTION("low-level driver for RZ1000 PCI ATA");
148 MODULE_LICENSE("GPL"); 146 MODULE_LICENSE("GPL");
149 MODULE_DEVICE_TABLE(pci, pata_rz1000); 147 MODULE_DEVICE_TABLE(pci, pata_rz1000);
150 MODULE_VERSION(DRV_VERSION); 148 MODULE_VERSION(DRV_VERSION);
151 149
152 module_init(rz1000_init); 150 module_init(rz1000_init);
153 module_exit(rz1000_exit); 151 module_exit(rz1000_exit);
154 152
155 153