Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit e98062ed6dc46ed3270350e1040e19d44150d1d1

Authored by Sedat Dilek
Committed by Matthew Garrett
1 parent c1f73658ed
Exists in master and in 7 other branches imx_3.0.35_4.1.0, imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-l5.0.0_1.0.0-ga

platform/x86: Kconfig: Replace select by depends on ACPI_WMI 

With 'make oldnoconfig' I see these warnings in linux-next (next-20101208):

drivers/platform/x86/Kconfig:422:error: recursive dependency detected!
drivers/platform/x86/Kconfig:422:       symbol EEEPC_WMI depends on ACPI_WMI
drivers/platform/x86/Kconfig:438:       symbol ACPI_WMI is selected by ACER_WMI
drivers/platform/x86/Kconfig:18:        symbol ACER_WMI depends on LEDS_CLASS
drivers/leds/Kconfig:10:        symbol LEDS_CLASS is selected by EEEPC_WMI

This patch replaces all "select on ACPI_WMI" by "depends on ACPI_WMI".

Quote from David Woodhouse:
"A better policy is: "NEVER USE SELECT"."

Reported-and-tested-by: Sedat Dilek <sedat.dilek@gmail.com>
Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>

Showing 1 changed file with 2 additions and 2 deletions Side-by-side Diff

drivers/platform/x86/Kconfig
Diff comments   View file @ e98062e
... ... @@ -23,7 +23,7 @@
23 23 depends on BACKLIGHT_CLASS_DEVICE
24 24 depends on SERIO_I8042
25 25 depends on RFKILL || RFKILL = n
26   - select ACPI_WMI
  26 + depends on ACPI_WMI
27 27 ---help---
28 28 This is a driver for newer Acer (and Wistron) laptops. It adds
29 29 wireless radio and bluetooth control, and on some laptops,
... ... @@ -131,7 +131,7 @@
131 131 depends on !X86_64
132 132 depends on EXPERIMENTAL
133 133 depends on ACPI
134   - select ACPI_WMI
  134 + depends on ACPI_WMI
135 135 ---help---
136 136 This is a driver for the WMI extensions (wireless and bluetooth power
137 137 control) of the HP Compaq TC1100 tablet.