Eric Lee / linux-smarc-t335x-v3.2

Download as
Browse Code ยป

Commit 71d41aed9468a1239cff1b2d928954885b09de6c

Authored by Himanshu Chauhan
Committed by Michal Marek
1 parent d4987bd7ae
Exists in master and in 4 other branches v3.2_AM335xPSP_04.06.00.11, v3.2_NEWT335xPSP_04.06.00.11, v3.2_SBC_SMARTMEN, v3.2_SMARCT335xPSP_04.06.00.11

scripts/kallsyms: suppress build warning 

Suppress a warn_unused_result warning.

fgets is called as a part of error handling.  It is called just to drop a
line and return immediately.  read_map is reading the file in a loop and
read_symbol reads line by line.  So I think there is no point in using
return value for useful checking.  Other checks like 3 items were returned
or !EOF have already been done.

Signed-off-by: Himanshu Chauhan <hschauhan@nulltrace.org>
Cc: WANG Cong <xiyou.wangcong@gmail.com>
Cc: Michal Marek <mmarek@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Michal Marek <mmarek@suse.cz>

Showing 1 changed file with 4 additions and 2 deletions Side-by-side Diff

... ... @@ -108,8 +108,10 @@
108 108 rc = fscanf(in, "%llx %c %499s\n", &s->addr, &stype, str);
109 109 if (rc != 3) {
110 110 if (rc != EOF) {
111   - /* skip line */
112   - fgets(str, 500, in);
  111 + /* skip line. sym is used as dummy to
  112 + * shut of "warn_unused_result" warning.
  113 + */
  114 + sym = fgets(str, 500, in);
113 115 }
114 116 return -1;
115 117 }