[NETFILTER]: nf_conntrack_netbios_ns: fix uninitialized member in expectation

->helper is uninitialized in the expectation registered by the netbios_ns helper and it later copied to the expected connection, which causes invalid memory dereferences when trying to call the helper. Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net>

[NETFILTER]: nf_conntrack_netbios_ns: fix uninitialized member in expectation
->helper is uninitialized in the expectation registered by the netbios_ns helper and it later copied to the expected connection, which causes invalid memory dereferences when trying to call the helper. Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net>
Patrick McHardy · David S. Miller
1 parent c1d2a1965a
Showing 1 changed file with 1 additions and 0 deletions Side-by-side Diff
net/netfilter/nf_conntrack_netbios_ns.c
@@ -89,6 +89,7 @@
  
 	exp->expectfn             = NULL;
 	exp->flags                = NF_CT_EXPECT_PERMANENT;
+	exp->helper               = NULL;
  
 	nf_conntrack_expect_related(exp);
 	nf_conntrack_expect_put(exp);
...	...	@@ -89,6 +89,7 @@
89	89
90	90	exp->expectfn = NULL;
91	91	exp->flags = NF_CT_EXPECT_PERMANENT;
	92	+ exp->helper = NULL;
92	93
93	94	nf_conntrack_expect_related(exp);
94	95	nf_conntrack_expect_put(exp);