Eric Lee / smarc-fsl-linux-kernel

Blame view

scripts/coccinelle/api/kstrdup.cocci 2.4 KB
edit raw normal view history
998f55232   Nicolas Palix   Coccinelle: Add a... 
1
2
3
 
  /// Use kstrdup rather than duplicating its implementation
  ///
  // Confidence: High
29a36d4de   Julia Lawall   scripts/coccinell... 
4
5
6
 
  // Copyright: (C) 2010-2012 Nicolas Palix.  GPLv2.
  // Copyright: (C) 2010-2012 Julia Lawall, INRIA/LIP6.  GPLv2.
  // Copyright: (C) 2010-2012 Gilles Muller, INRIA/LiP6.  GPLv2.
998f55232   Nicolas Palix   Coccinelle: Add a... 
7
8
9
10
11
 
  // URL: http://coccinelle.lip6.fr/
  // Comments:
  // Options: -no_includes -include_headers
  
  virtual patch
29a36d4de   Julia Lawall   scripts/coccinell... 
12
13
14
 
  virtual context
  virtual org
  virtual report
998f55232   Nicolas Palix   Coccinelle: Add a... 
15
 








29a36d4de
 
 Julia Lawall
 
scripts/coccinell...




16




  @depends on patch@









998f55232
 
 Nicolas Palix
 
Coccinelle: Add a...




17
18
19
20
21
22
23
24
25
26
27




  expression from,to;
  expression flag,E1,E2;
  statement S;
  @@
  
  -  to = kmalloc(strlen(from) + 1,flag);
  +  to = kstrdup(from, flag);
     ... when != \(from = E1 \| to = E1 \)
     if (to==NULL || ...) S
     ... when != \(from = E2 \| to = E2 \)
  -  strcpy(to, from);









29a36d4de
 
 Julia Lawall
 
scripts/coccinell...




28




  @depends on patch@









998f55232
 
 Nicolas Palix
 
Coccinelle: Add a...




29
30
31
32
33
34
35
36
37
38
39
40
41




  expression x,from,to;
  expression flag,E1,E2,E3;
  statement S;
  @@
  
  -   x = strlen(from) + 1;
      ... when != \( x = E1 \| from = E1 \)
  -   to = \(kmalloc\|kzalloc\)(x,flag);
  +   to = kstrdup(from, flag);
      ... when != \(x = E2 \| from = E2 \| to = E2 \)
      if (to==NULL || ...) S
      ... when != \(x = E3 \| from = E3 \| to = E3 \)
  -   memcpy(to, from, x);









29a36d4de
 
 Julia Lawall
 
scripts/coccinell...




42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103




  
  // ---------------------------------------------------------------------
  
  @r1 depends on !patch exists@
  expression from,to;
  expression flag,E1,E2;
  statement S;
  position p1,p2;
  @@
  
  *  to = kmalloc@p1(strlen(from) + 1,flag);
     ... when != \(from = E1 \| to = E1 \)
     if (to==NULL || ...) S
     ... when != \(from = E2 \| to = E2 \)
  *  strcpy@p2(to, from);
  
  @r2 depends on !patch exists@
  expression x,from,to;
  expression flag,E1,E2,E3;
  statement S;
  position p1,p2;
  @@
  
  *   x = strlen(from) + 1;
      ... when != \( x = E1 \| from = E1 \)
  *   to = \(kmalloc@p1\|kzalloc@p2\)(x,flag);
      ... when != \(x = E2 \| from = E2 \| to = E2 \)
      if (to==NULL || ...) S
      ... when != \(x = E3 \| from = E3 \| to = E3 \)
  *   memcpy@p2(to, from, x);
  
  @script:python depends on org@
  p1 << r1.p1;
  p2 << r1.p2;
  @@
  
  cocci.print_main("WARNING opportunity for kstrdep",p1)
  cocci.print_secs("strcpy",p2)
  
  @script:python depends on org@
  p1 << r2.p1;
  p2 << r2.p2;
  @@
  
  cocci.print_main("WARNING opportunity for kstrdep",p1)
  cocci.print_secs("memcpy",p2)
  
  @script:python depends on report@
  p1 << r1.p1;
  p2 << r1.p2;
  @@
  
  msg = "WARNING opportunity for kstrdep (strcpy on line %s)" % (p2[0].line)
  coccilib.report.print_report(p1[0], msg)
  
  @script:python depends on report@
  p1 << r2.p1;
  p2 << r2.p2;
  @@
  
  msg = "WARNING opportunity for kstrdep (memcpy on line %s)" % (p2[0].line)
  coccilib.report.print_report(p1[0], msg)