Blame view

scripts/coccinelle/api/memdup.cocci 1.35 KB
0426a97c4   Nicolas Palix   Coccinelle: Add a...
1
2
3
  /// Use kmemdup rather than duplicating its implementation
  ///
  // Confidence: High
29a36d4de   Julia Lawall   scripts/coccinell...
4
5
6
  // Copyright: (C) 2010-2012 Nicolas Palix.  GPLv2.
  // Copyright: (C) 2010-2012 Julia Lawall, INRIA/LIP6.  GPLv2.
  // Copyright: (C) 2010-2012 Gilles Muller, INRIA/LiP6.  GPLv2.
0426a97c4   Nicolas Palix   Coccinelle: Add a...
7
8
9
10
11
  // URL: http://coccinelle.lip6.fr/
  // Comments:
  // Options: -no_includes -include_headers
  
  virtual patch
29a36d4de   Julia Lawall   scripts/coccinell...
12
13
14
  virtual context
  virtual org
  virtual report
0426a97c4   Nicolas Palix   Coccinelle: Add a...
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
  
  @r1@
  expression from,to;
  expression flag;
  position p;
  @@
  
     to = \(kmalloc@p\|kzalloc@p\)(strlen(from) + 1,flag);
  
  @r2@
  expression x,from,to;
  expression flag,E1;
  position p;
  @@
  
      x = strlen(from) + 1;
      ... when != \( x = E1 \| from = E1 \)
      to = \(kmalloc@p\|kzalloc@p\)(x,flag);
29a36d4de   Julia Lawall   scripts/coccinell...
33
  @depends on patch@
0426a97c4   Nicolas Palix   Coccinelle: Add a...
34
35
36
37
38
39
40
41
42
  expression from,to,size,flag;
  position p != {r1.p,r2.p};
  statement S;
  @@
  
  -  to = \(kmalloc@p\|kzalloc@p\)(size,flag);
  +  to = kmemdup(from,size,flag);
     if (to==NULL || ...) S
  -  memcpy(to, from, size);
29a36d4de   Julia Lawall   scripts/coccinell...
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
  
  @r depends on !patch@
  expression from,to,size,flag;
  position p != {r1.p,r2.p};
  statement S;
  @@
  
  *  to = \(kmalloc@p\|kzalloc@p\)(size,flag);
     to = kmemdup(from,size,flag);
     if (to==NULL || ...) S
  *  memcpy(to, from, size);
  
  @script:python depends on org@
  p << r.p;
  @@
  
  coccilib.org.print_todo(p[0], "WARNING opportunity for kmemdep")
  
  @script:python depends on report@
  p << r.p;
  @@
  
  coccilib.report.print_report(p[0], "WARNING opportunity for kmemdep")