Blame view

scripts/coccinelle/api/memdup_user.cocci 1.27 KB
29a36d4de   Julia Lawall   scripts/coccinell...
1
  /// Use memdup_user rather than duplicating its implementation
034174598   Nicolas Palix   Coccinelle: Add a...
2
3
4
  /// This is a little bit restricted to reduce false positives
  ///
  // Confidence: High
29a36d4de   Julia Lawall   scripts/coccinell...
5
6
7
  // Copyright: (C) 2010-2012 Nicolas Palix.  GPLv2.
  // Copyright: (C) 2010-2012 Julia Lawall, INRIA/LIP6.  GPLv2.
  // Copyright: (C) 2010-2012 Gilles Muller, INRIA/LiP6.  GPLv2.
034174598   Nicolas Palix   Coccinelle: Add a...
8
9
10
11
12
  // URL: http://coccinelle.lip6.fr/
  // Comments:
  // Options: -no_includes -include_headers
  
  virtual patch
29a36d4de   Julia Lawall   scripts/coccinell...
13
14
15
  virtual context
  virtual org
  virtual report
034174598   Nicolas Palix   Coccinelle: Add a...
16

29a36d4de   Julia Lawall   scripts/coccinell...
17
  @depends on patch@
034174598   Nicolas Palix   Coccinelle: Add a...
18
  expression from,to,size,flag;
034174598   Nicolas Palix   Coccinelle: Add a...
19
20
  identifier l1,l2;
  @@
29a36d4de   Julia Lawall   scripts/coccinell...
21
  -  to = \(kmalloc\|kzalloc\)(size,flag);
034174598   Nicolas Palix   Coccinelle: Add a...
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
  +  to = memdup_user(from,size);
     if (
  -      to==NULL
  +      IS_ERR(to)
                   || ...) {
     <+... when != goto l1;
  -  -ENOMEM
  +  PTR_ERR(to)
     ...+>
     }
  -  if (copy_from_user(to, from, size) != 0) {
  -    <+... when != goto l2;
  -    -EFAULT
  -    ...+>
  -  }
29a36d4de   Julia Lawall   scripts/coccinell...
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
  
  @r depends on !patch@
  expression from,to,size,flag;
  position p;
  statement S1,S2;
  @@
  
  *  to = \(kmalloc@p\|kzalloc@p\)(size,flag);
     if (to==NULL || ...) S1
     if (copy_from_user(to, from, size) != 0)
     S2
  
  @script:python depends on org@
  p << r.p;
  @@
  
  coccilib.org.print_todo(p[0], "WARNING opportunity for memdep_user")
  
  @script:python depends on report@
  p << r.p;
  @@
  
  coccilib.report.print_report(p[0], "WARNING opportunity for memdep_user")