Blame view

fs/ext4/acl.c 9.78 KB
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
1
  /*
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
2
   * linux/fs/ext4/acl.c
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
3
4
5
6
7
8
9
10
11
   *
   * Copyright (C) 2001-2003 Andreas Gruenbacher, <agruen@suse.de>
   */
  
  #include <linux/init.h>
  #include <linux/sched.h>
  #include <linux/slab.h>
  #include <linux/capability.h>
  #include <linux/fs.h>
3dcf54515   Christoph Hellwig   ext4: move header...
12
13
  #include "ext4_jbd2.h"
  #include "ext4.h"
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
14
15
16
17
18
19
20
  #include "xattr.h"
  #include "acl.h"
  
  /*
   * Convert from filesystem to in-memory representation.
   */
  static struct posix_acl *
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
21
  ext4_acl_from_disk(const void *value, size_t size)
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
22
23
24
25
26
27
28
  {
  	const char *end = (char *)value + size;
  	int n, count;
  	struct posix_acl *acl;
  
  	if (!value)
  		return NULL;
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
29
  	if (size < sizeof(ext4_acl_header))
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
30
  		 return ERR_PTR(-EINVAL);
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
31
32
  	if (((ext4_acl_header *)value)->a_version !=
  	    cpu_to_le32(EXT4_ACL_VERSION))
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
33
  		return ERR_PTR(-EINVAL);
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
34
35
  	value = (char *)value + sizeof(ext4_acl_header);
  	count = ext4_acl_count(size);
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
36
37
38
39
  	if (count < 0)
  		return ERR_PTR(-EINVAL);
  	if (count == 0)
  		return NULL;
216553c4b   Josef Bacik   ext4: fix wrong g...
40
  	acl = posix_acl_alloc(count, GFP_NOFS);
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
41
42
  	if (!acl)
  		return ERR_PTR(-ENOMEM);
2b2d6d019   Theodore Ts'o   ext4: Cleanup whi...
43
  	for (n = 0; n < count; n++) {
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
44
45
46
  		ext4_acl_entry *entry =
  			(ext4_acl_entry *)value;
  		if ((char *)value + sizeof(ext4_acl_entry_short) > end)
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
47
48
49
  			goto fail;
  		acl->a_entries[n].e_tag  = le16_to_cpu(entry->e_tag);
  		acl->a_entries[n].e_perm = le16_to_cpu(entry->e_perm);
2b2d6d019   Theodore Ts'o   ext4: Cleanup whi...
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
  
  		switch (acl->a_entries[n].e_tag) {
  		case ACL_USER_OBJ:
  		case ACL_GROUP_OBJ:
  		case ACL_MASK:
  		case ACL_OTHER:
  			value = (char *)value +
  				sizeof(ext4_acl_entry_short);
  			acl->a_entries[n].e_id = ACL_UNDEFINED_ID;
  			break;
  
  		case ACL_USER:
  		case ACL_GROUP:
  			value = (char *)value + sizeof(ext4_acl_entry);
  			if ((char *)value > end)
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
65
  				goto fail;
2b2d6d019   Theodore Ts'o   ext4: Cleanup whi...
66
67
68
69
70
71
  			acl->a_entries[n].e_id =
  				le32_to_cpu(entry->e_id);
  			break;
  
  		default:
  			goto fail;
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
  		}
  	}
  	if (value != end)
  		goto fail;
  	return acl;
  
  fail:
  	posix_acl_release(acl);
  	return ERR_PTR(-EINVAL);
  }
  
  /*
   * Convert from in-memory to filesystem representation.
   */
  static void *
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
87
  ext4_acl_to_disk(const struct posix_acl *acl, size_t *size)
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
88
  {
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
89
  	ext4_acl_header *ext_acl;
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
90
91
  	char *e;
  	size_t n;
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
92
93
  	*size = ext4_acl_size(acl->a_count);
  	ext_acl = kmalloc(sizeof(ext4_acl_header) + acl->a_count *
216553c4b   Josef Bacik   ext4: fix wrong g...
94
  			sizeof(ext4_acl_entry), GFP_NOFS);
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
95
96
  	if (!ext_acl)
  		return ERR_PTR(-ENOMEM);
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
97
98
  	ext_acl->a_version = cpu_to_le32(EXT4_ACL_VERSION);
  	e = (char *)ext_acl + sizeof(ext4_acl_header);
2b2d6d019   Theodore Ts'o   ext4: Cleanup whi...
99
  	for (n = 0; n < acl->a_count; n++) {
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
100
  		ext4_acl_entry *entry = (ext4_acl_entry *)e;
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
101
102
  		entry->e_tag  = cpu_to_le16(acl->a_entries[n].e_tag);
  		entry->e_perm = cpu_to_le16(acl->a_entries[n].e_perm);
2b2d6d019   Theodore Ts'o   ext4: Cleanup whi...
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
  		switch (acl->a_entries[n].e_tag) {
  		case ACL_USER:
  		case ACL_GROUP:
  			entry->e_id = cpu_to_le32(acl->a_entries[n].e_id);
  			e += sizeof(ext4_acl_entry);
  			break;
  
  		case ACL_USER_OBJ:
  		case ACL_GROUP_OBJ:
  		case ACL_MASK:
  		case ACL_OTHER:
  			e += sizeof(ext4_acl_entry_short);
  			break;
  
  		default:
  			goto fail;
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
119
120
121
122
123
124
125
126
  		}
  	}
  	return (char *)ext_acl;
  
  fail:
  	kfree(ext_acl);
  	return ERR_PTR(-EINVAL);
  }
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
127
128
129
130
131
  /*
   * Inode operation get_posix_acl().
   *
   * inode->i_mutex: don't care
   */
4e34e719e   Christoph Hellwig   fs: take the ACL ...
132
  struct posix_acl *
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
133
  ext4_get_acl(struct inode *inode, int type)
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
134
  {
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
135
136
137
138
139
140
141
  	int name_index;
  	char *value = NULL;
  	struct posix_acl *acl;
  	int retval;
  
  	if (!test_opt(inode->i_sb, POSIX_ACL))
  		return NULL;
073aaa1b1   Al Viro   helpers for acl c...
142
143
144
  	acl = get_cached_acl(inode, type);
  	if (acl != ACL_NOT_CACHED)
  		return acl;
2b2d6d019   Theodore Ts'o   ext4: Cleanup whi...
145
146
  	switch (type) {
  	case ACL_TYPE_ACCESS:
2b2d6d019   Theodore Ts'o   ext4: Cleanup whi...
147
148
  		name_index = EXT4_XATTR_INDEX_POSIX_ACL_ACCESS;
  		break;
2b2d6d019   Theodore Ts'o   ext4: Cleanup whi...
149
  	case ACL_TYPE_DEFAULT:
2b2d6d019   Theodore Ts'o   ext4: Cleanup whi...
150
151
  		name_index = EXT4_XATTR_INDEX_POSIX_ACL_DEFAULT;
  		break;
2b2d6d019   Theodore Ts'o   ext4: Cleanup whi...
152
  	default:
073aaa1b1   Al Viro   helpers for acl c...
153
  		BUG();
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
154
  	}
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
155
  	retval = ext4_xattr_get(inode, name_index, "", NULL, 0);
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
156
  	if (retval > 0) {
216553c4b   Josef Bacik   ext4: fix wrong g...
157
  		value = kmalloc(retval, GFP_NOFS);
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
158
159
  		if (!value)
  			return ERR_PTR(-ENOMEM);
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
160
  		retval = ext4_xattr_get(inode, name_index, "", value, retval);
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
161
162
  	}
  	if (retval > 0)
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
163
  		acl = ext4_acl_from_disk(value, retval);
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
164
165
166
167
168
  	else if (retval == -ENODATA || retval == -ENOSYS)
  		acl = NULL;
  	else
  		acl = ERR_PTR(retval);
  	kfree(value);
073aaa1b1   Al Viro   helpers for acl c...
169
170
  	if (!IS_ERR(acl))
  		set_cached_acl(inode, type, acl);
2b2d6d019   Theodore Ts'o   ext4: Cleanup whi...
171

ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
172
173
174
175
176
177
  	return acl;
  }
  
  /*
   * Set the access or default ACL of an inode.
   *
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
178
   * inode->i_mutex: down unless called from ext4_new_inode
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
179
180
   */
  static int
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
181
  ext4_set_acl(handle_t *handle, struct inode *inode, int type,
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
182
183
  	     struct posix_acl *acl)
  {
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
184
185
186
187
188
189
190
  	int name_index;
  	void *value = NULL;
  	size_t size = 0;
  	int error;
  
  	if (S_ISLNK(inode->i_mode))
  		return -EOPNOTSUPP;
2b2d6d019   Theodore Ts'o   ext4: Cleanup whi...
191
192
193
194
  	switch (type) {
  	case ACL_TYPE_ACCESS:
  		name_index = EXT4_XATTR_INDEX_POSIX_ACL_ACCESS;
  		if (acl) {
d6952123b   Al Viro   switch posix_acl_...
195
  			error = posix_acl_equiv_mode(acl, &inode->i_mode);
2b2d6d019   Theodore Ts'o   ext4: Cleanup whi...
196
197
198
  			if (error < 0)
  				return error;
  			else {
c6ac12a61   Jan Kara   ext4: update ctim...
199
  				inode->i_ctime = ext4_current_time(inode);
2b2d6d019   Theodore Ts'o   ext4: Cleanup whi...
200
201
202
  				ext4_mark_inode_dirty(handle, inode);
  				if (error == 0)
  					acl = NULL;
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
203
  			}
2b2d6d019   Theodore Ts'o   ext4: Cleanup whi...
204
205
  		}
  		break;
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
206

2b2d6d019   Theodore Ts'o   ext4: Cleanup whi...
207
208
209
210
211
  	case ACL_TYPE_DEFAULT:
  		name_index = EXT4_XATTR_INDEX_POSIX_ACL_DEFAULT;
  		if (!S_ISDIR(inode->i_mode))
  			return acl ? -EACCES : 0;
  		break;
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
212

2b2d6d019   Theodore Ts'o   ext4: Cleanup whi...
213
214
  	default:
  		return -EINVAL;
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
215
216
  	}
  	if (acl) {
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
217
  		value = ext4_acl_to_disk(acl, &size);
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
218
219
220
  		if (IS_ERR(value))
  			return (int)PTR_ERR(value);
  	}
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
221
  	error = ext4_xattr_set_handle(handle, inode, name_index, "",
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
222
223
224
  				      value, size, 0);
  
  	kfree(value);
073aaa1b1   Al Viro   helpers for acl c...
225
226
  	if (!error)
  		set_cached_acl(inode, type, acl);
2b2d6d019   Theodore Ts'o   ext4: Cleanup whi...
227

ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
228
229
  	return error;
  }
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
230
  /*
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
231
   * Initialize the ACLs of a new inode. Called from ext4_new_inode.
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
232
233
234
235
236
   *
   * dir->i_mutex: down
   * inode->i_mutex: up (access to inode is still exclusive)
   */
  int
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
237
  ext4_init_acl(handle_t *handle, struct inode *inode, struct inode *dir)
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
238
239
240
241
242
243
  {
  	struct posix_acl *acl = NULL;
  	int error = 0;
  
  	if (!S_ISLNK(inode->i_mode)) {
  		if (test_opt(dir->i_sb, POSIX_ACL)) {
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
244
  			acl = ext4_get_acl(dir, ACL_TYPE_DEFAULT);
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
245
246
247
248
  			if (IS_ERR(acl))
  				return PTR_ERR(acl);
  		}
  		if (!acl)
ce3b0f8d5   Al Viro   New helper - curr...
249
  			inode->i_mode &= ~current_umask();
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
250
251
  	}
  	if (test_opt(inode->i_sb, POSIX_ACL) && acl) {
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
252
  		if (S_ISDIR(inode->i_mode)) {
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
253
  			error = ext4_set_acl(handle, inode,
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
254
255
256
257
  					     ACL_TYPE_DEFAULT, acl);
  			if (error)
  				goto cleanup;
  		}
d3fb61207   Al Viro   switch posix_acl_...
258
  		error = posix_acl_create(&acl, GFP_NOFS, &inode->i_mode);
826cae2f2   Al Viro   kill boilerplates...
259
260
  		if (error < 0)
  			return error;
826cae2f2   Al Viro   kill boilerplates...
261
262
263
  		if (error > 0) {
  			/* This is an extended ACL */
  			error = ext4_set_acl(handle, inode, ACL_TYPE_ACCESS, acl);
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
264
  		}
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
  	}
  cleanup:
  	posix_acl_release(acl);
  	return error;
  }
  
  /*
   * Does chmod for an inode that may have an Access Control List. The
   * inode->i_mode field must be updated to the desired value by the caller
   * before calling this function.
   * Returns 0 on success, or a negative error number.
   *
   * We change the ACL rather than storing some ACL entries in the file
   * mode permission bits (which would be more efficient), because that
   * would break once additional permissions (like  ACL_APPEND, ACL_DELETE
   * for directories) are added. There are no more bits available in the
   * file mode.
   *
   * inode->i_mutex: down
   */
  int
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
286
  ext4_acl_chmod(struct inode *inode)
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
287
  {
bc26ab5f6   Al Viro   kill boilerplate ...
288
289
290
  	struct posix_acl *acl;
  	handle_t *handle;
  	int retries = 0;
63f579335   Andrew Morton   [PATCH] ext4 whit...
291
  	int error;
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
292

bc26ab5f6   Al Viro   kill boilerplate ...
293

ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
294
295
296
297
  	if (S_ISLNK(inode->i_mode))
  		return -EOPNOTSUPP;
  	if (!test_opt(inode->i_sb, POSIX_ACL))
  		return 0;
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
298
  	acl = ext4_get_acl(inode, ACL_TYPE_ACCESS);
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
299
300
  	if (IS_ERR(acl) || !acl)
  		return PTR_ERR(acl);
bc26ab5f6   Al Viro   kill boilerplate ...
301
302
303
304
305
306
307
308
309
310
  	error = posix_acl_chmod(&acl, GFP_KERNEL, inode->i_mode);
  	if (error)
  		return error;
  retry:
  	handle = ext4_journal_start(inode,
  			EXT4_DATA_TRANS_BLOCKS(inode->i_sb));
  	if (IS_ERR(handle)) {
  		error = PTR_ERR(handle);
  		ext4_std_error(inode->i_sb, error);
  		goto out;
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
311
  	}
bc26ab5f6   Al Viro   kill boilerplate ...
312
313
314
315
316
  	error = ext4_set_acl(handle, inode, ACL_TYPE_ACCESS, acl);
  	ext4_journal_stop(handle);
  	if (error == -ENOSPC &&
  	    ext4_should_retry_alloc(inode->i_sb, &retries))
  		goto retry;
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
317
  out:
bc26ab5f6   Al Viro   kill boilerplate ...
318
  	posix_acl_release(acl);
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
319
320
321
322
323
324
325
  	return error;
  }
  
  /*
   * Extended attribute handlers
   */
  static size_t
431547b3c   Christoph Hellwig   sanitize xattr ha...
326
327
  ext4_xattr_list_acl_access(struct dentry *dentry, char *list, size_t list_len,
  			   const char *name, size_t name_len, int type)
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
328
329
  {
  	const size_t size = sizeof(POSIX_ACL_XATTR_ACCESS);
431547b3c   Christoph Hellwig   sanitize xattr ha...
330
  	if (!test_opt(dentry->d_sb, POSIX_ACL))
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
331
332
333
334
335
336
337
  		return 0;
  	if (list && size <= list_len)
  		memcpy(list, POSIX_ACL_XATTR_ACCESS, size);
  	return size;
  }
  
  static size_t
431547b3c   Christoph Hellwig   sanitize xattr ha...
338
339
  ext4_xattr_list_acl_default(struct dentry *dentry, char *list, size_t list_len,
  			    const char *name, size_t name_len, int type)
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
340
341
  {
  	const size_t size = sizeof(POSIX_ACL_XATTR_DEFAULT);
431547b3c   Christoph Hellwig   sanitize xattr ha...
342
  	if (!test_opt(dentry->d_sb, POSIX_ACL))
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
343
344
345
346
347
348
349
  		return 0;
  	if (list && size <= list_len)
  		memcpy(list, POSIX_ACL_XATTR_DEFAULT, size);
  	return size;
  }
  
  static int
431547b3c   Christoph Hellwig   sanitize xattr ha...
350
351
  ext4_xattr_get_acl(struct dentry *dentry, const char *name, void *buffer,
  		   size_t size, int type)
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
352
353
354
  {
  	struct posix_acl *acl;
  	int error;
431547b3c   Christoph Hellwig   sanitize xattr ha...
355
356
357
  	if (strcmp(name, "") != 0)
  		return -EINVAL;
  	if (!test_opt(dentry->d_sb, POSIX_ACL))
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
358
  		return -EOPNOTSUPP;
431547b3c   Christoph Hellwig   sanitize xattr ha...
359
  	acl = ext4_get_acl(dentry->d_inode, type);
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
360
361
362
363
364
365
366
367
368
369
370
  	if (IS_ERR(acl))
  		return PTR_ERR(acl);
  	if (acl == NULL)
  		return -ENODATA;
  	error = posix_acl_to_xattr(acl, buffer, size);
  	posix_acl_release(acl);
  
  	return error;
  }
  
  static int
431547b3c   Christoph Hellwig   sanitize xattr ha...
371
372
  ext4_xattr_set_acl(struct dentry *dentry, const char *name, const void *value,
  		   size_t size, int flags, int type)
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
373
  {
431547b3c   Christoph Hellwig   sanitize xattr ha...
374
  	struct inode *inode = dentry->d_inode;
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
375
376
377
  	handle_t *handle;
  	struct posix_acl *acl;
  	int error, retries = 0;
431547b3c   Christoph Hellwig   sanitize xattr ha...
378
379
  	if (strcmp(name, "") != 0)
  		return -EINVAL;
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
380
381
  	if (!test_opt(inode->i_sb, POSIX_ACL))
  		return -EOPNOTSUPP;
2e1496707   Serge E. Hallyn   userns: rename is...
382
  	if (!inode_owner_or_capable(inode))
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
  		return -EPERM;
  
  	if (value) {
  		acl = posix_acl_from_xattr(value, size);
  		if (IS_ERR(acl))
  			return PTR_ERR(acl);
  		else if (acl) {
  			error = posix_acl_valid(acl);
  			if (error)
  				goto release_and_out;
  		}
  	} else
  		acl = NULL;
  
  retry:
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
398
  	handle = ext4_journal_start(inode, EXT4_DATA_TRANS_BLOCKS(inode->i_sb));
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
399
400
  	if (IS_ERR(handle))
  		return PTR_ERR(handle);
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
401
402
403
  	error = ext4_set_acl(handle, inode, type, acl);
  	ext4_journal_stop(handle);
  	if (error == -ENOSPC && ext4_should_retry_alloc(inode->i_sb, &retries))
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
404
405
406
407
408
409
  		goto retry;
  
  release_and_out:
  	posix_acl_release(acl);
  	return error;
  }
11e275280   Stephen Hemminger   ext4: constify xa...
410
  const struct xattr_handler ext4_xattr_acl_access_handler = {
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
411
  	.prefix	= POSIX_ACL_XATTR_ACCESS,
431547b3c   Christoph Hellwig   sanitize xattr ha...
412
  	.flags	= ACL_TYPE_ACCESS,
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
413
  	.list	= ext4_xattr_list_acl_access,
431547b3c   Christoph Hellwig   sanitize xattr ha...
414
415
  	.get	= ext4_xattr_get_acl,
  	.set	= ext4_xattr_set_acl,
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
416
  };
11e275280   Stephen Hemminger   ext4: constify xa...
417
  const struct xattr_handler ext4_xattr_acl_default_handler = {
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
418
  	.prefix	= POSIX_ACL_XATTR_DEFAULT,
431547b3c   Christoph Hellwig   sanitize xattr ha...
419
  	.flags	= ACL_TYPE_DEFAULT,
617ba13b3   Mingming Cao   [PATCH] ext4: ren...
420
  	.list	= ext4_xattr_list_acl_default,
431547b3c   Christoph Hellwig   sanitize xattr ha...
421
422
  	.get	= ext4_xattr_get_acl,
  	.set	= ext4_xattr_set_acl,
ac27a0ec1   Dave Kleikamp   [PATCH] ext4: ini...
423
  };