Blame view

fs/posix_acl.c 21.5 KB
457c89965   Thomas Gleixner   treewide: Add SPD...
1
  // SPDX-License-Identifier: GPL-2.0-only
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
2
  /*
5c8ebd57b   Christoph Hellwig   fs: merge xattr_a...
3
   * Copyright (C) 2002,2003 by Andreas Gruenbacher <a.gruenbacher@computer.org>
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
4
   *
5c8ebd57b   Christoph Hellwig   fs: merge xattr_a...
5
6
   * Fixes from William Schumacher incorporated on 15 March 2001.
   *    (Reported by Charles Bertsch, <CBertsch@microtest.com>).
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
7
8
9
10
11
12
13
14
15
   */
  
  /*
   *  This file contains generic functions for manipulating
   *  POSIX 1003.1e draft standard 17 ACLs.
   */
  
  #include <linux/kernel.h>
  #include <linux/slab.h>
60063497a   Arun Sharma   atomic: use <linu...
16
  #include <linux/atomic.h>
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
17
18
  #include <linux/fs.h>
  #include <linux/sched.h>
5b825c3af   Ingo Molnar   sched/headers: Pr...
19
  #include <linux/cred.h>
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
20
  #include <linux/posix_acl.h>
5c8ebd57b   Christoph Hellwig   fs: merge xattr_a...
21
  #include <linux/posix_acl_xattr.h>
2aeccbe95   Christoph Hellwig   fs: add generic x...
22
  #include <linux/xattr.h>
630d9c472   Paul Gortmaker   fs: reduce the us...
23
  #include <linux/export.h>
5c8ebd57b   Christoph Hellwig   fs: merge xattr_a...
24
  #include <linux/user_namespace.h>
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
25

04c57f450   Andreas Gruenbacher   posix_acl: Unexpo...
26
  static struct posix_acl **acl_by_type(struct inode *inode, int type)
0afaa1204   Andrew Morton   posix_acl: uninli...
27
28
29
30
31
32
33
34
35
36
  {
  	switch (type) {
  	case ACL_TYPE_ACCESS:
  		return &inode->i_acl;
  	case ACL_TYPE_DEFAULT:
  		return &inode->i_default_acl;
  	default:
  		BUG();
  	}
  }
0afaa1204   Andrew Morton   posix_acl: uninli...
37
38
39
40
  
  struct posix_acl *get_cached_acl(struct inode *inode, int type)
  {
  	struct posix_acl **p = acl_by_type(inode, type);
b8a7a3a66   Andreas Gruenbacher   posix_acl: Inode ...
41
42
43
44
45
46
  	struct posix_acl *acl;
  
  	for (;;) {
  		rcu_read_lock();
  		acl = rcu_dereference(*p);
  		if (!acl || is_uncached_acl(acl) ||
667172605   Elena Reshetova   posix_acl: conver...
47
  		    refcount_inc_not_zero(&acl->a_refcount))
b8a7a3a66   Andreas Gruenbacher   posix_acl: Inode ...
48
49
50
  			break;
  		rcu_read_unlock();
  		cpu_relax();
0afaa1204   Andrew Morton   posix_acl: uninli...
51
  	}
b8a7a3a66   Andreas Gruenbacher   posix_acl: Inode ...
52
  	rcu_read_unlock();
0afaa1204   Andrew Morton   posix_acl: uninli...
53
54
55
56
57
58
59
60
61
62
63
64
65
66
  	return acl;
  }
  EXPORT_SYMBOL(get_cached_acl);
  
  struct posix_acl *get_cached_acl_rcu(struct inode *inode, int type)
  {
  	return rcu_dereference(*acl_by_type(inode, type));
  }
  EXPORT_SYMBOL(get_cached_acl_rcu);
  
  void set_cached_acl(struct inode *inode, int type, struct posix_acl *acl)
  {
  	struct posix_acl **p = acl_by_type(inode, type);
  	struct posix_acl *old;
b8a7a3a66   Andreas Gruenbacher   posix_acl: Inode ...
67
68
69
  
  	old = xchg(p, posix_acl_dup(acl));
  	if (!is_uncached_acl(old))
0afaa1204   Andrew Morton   posix_acl: uninli...
70
71
72
  		posix_acl_release(old);
  }
  EXPORT_SYMBOL(set_cached_acl);
b8a7a3a66   Andreas Gruenbacher   posix_acl: Inode ...
73
  static void __forget_cached_acl(struct posix_acl **p)
0afaa1204   Andrew Morton   posix_acl: uninli...
74
  {
0afaa1204   Andrew Morton   posix_acl: uninli...
75
  	struct posix_acl *old;
b8a7a3a66   Andreas Gruenbacher   posix_acl: Inode ...
76
77
78
  
  	old = xchg(p, ACL_NOT_CACHED);
  	if (!is_uncached_acl(old))
0afaa1204   Andrew Morton   posix_acl: uninli...
79
80
  		posix_acl_release(old);
  }
b8a7a3a66   Andreas Gruenbacher   posix_acl: Inode ...
81
82
83
84
85
  
  void forget_cached_acl(struct inode *inode, int type)
  {
  	__forget_cached_acl(acl_by_type(inode, type));
  }
0afaa1204   Andrew Morton   posix_acl: uninli...
86
87
88
89
  EXPORT_SYMBOL(forget_cached_acl);
  
  void forget_all_cached_acls(struct inode *inode)
  {
b8a7a3a66   Andreas Gruenbacher   posix_acl: Inode ...
90
91
  	__forget_cached_acl(&inode->i_acl);
  	__forget_cached_acl(&inode->i_default_acl);
0afaa1204   Andrew Morton   posix_acl: uninli...
92
93
  }
  EXPORT_SYMBOL(forget_all_cached_acls);
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
94

2982baa2a   Christoph Hellwig   fs: add get_acl h...
95
96
  struct posix_acl *get_acl(struct inode *inode, int type)
  {
b8a7a3a66   Andreas Gruenbacher   posix_acl: Inode ...
97
98
  	void *sentinel;
  	struct posix_acl **p;
2982baa2a   Christoph Hellwig   fs: add get_acl h...
99
  	struct posix_acl *acl;
b8a7a3a66   Andreas Gruenbacher   posix_acl: Inode ...
100
101
102
103
104
  	/*
  	 * The sentinel is used to detect when another operation like
  	 * set_cached_acl() or forget_cached_acl() races with get_acl().
  	 * It is guaranteed that is_uncached_acl(sentinel) is true.
  	 */
2982baa2a   Christoph Hellwig   fs: add get_acl h...
105
  	acl = get_cached_acl(inode, type);
b8a7a3a66   Andreas Gruenbacher   posix_acl: Inode ...
106
  	if (!is_uncached_acl(acl))
2982baa2a   Christoph Hellwig   fs: add get_acl h...
107
108
109
110
  		return acl;
  
  	if (!IS_POSIXACL(inode))
  		return NULL;
b8a7a3a66   Andreas Gruenbacher   posix_acl: Inode ...
111
112
113
114
115
116
117
118
119
120
121
122
123
  	sentinel = uncached_acl_sentinel(current);
  	p = acl_by_type(inode, type);
  
  	/*
  	 * If the ACL isn't being read yet, set our sentinel.  Otherwise, the
  	 * current value of the ACL will not be ACL_NOT_CACHED and so our own
  	 * sentinel will not be set; another task will update the cache.  We
  	 * could wait for that other task to complete its job, but it's easier
  	 * to just call ->get_acl to fetch the ACL ourself.  (This is going to
  	 * be an unlikely race.)
  	 */
  	if (cmpxchg(p, ACL_NOT_CACHED, sentinel) != ACL_NOT_CACHED)
  		/* fall through */ ;
2982baa2a   Christoph Hellwig   fs: add get_acl h...
124
  	/*
b8a7a3a66   Andreas Gruenbacher   posix_acl: Inode ...
125
126
127
  	 * Normally, the ACL returned by ->get_acl will be cached.
  	 * A filesystem can prevent that by calling
  	 * forget_cached_acl(inode, type) in ->get_acl.
2982baa2a   Christoph Hellwig   fs: add get_acl h...
128
129
130
131
132
133
134
135
  	 *
  	 * If the filesystem doesn't have a get_acl() function at all, we'll
  	 * just create the negative cache entry.
  	 */
  	if (!inode->i_op->get_acl) {
  		set_cached_acl(inode, type, NULL);
  		return NULL;
  	}
b8a7a3a66   Andreas Gruenbacher   posix_acl: Inode ...
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
  	acl = inode->i_op->get_acl(inode, type);
  
  	if (IS_ERR(acl)) {
  		/*
  		 * Remove our sentinel so that we don't block future attempts
  		 * to cache the ACL.
  		 */
  		cmpxchg(p, sentinel, ACL_NOT_CACHED);
  		return acl;
  	}
  
  	/*
  	 * Cache the result, but only if our sentinel is still in place.
  	 */
  	posix_acl_dup(acl);
  	if (unlikely(cmpxchg(p, sentinel, acl) != sentinel))
  		posix_acl_release(acl);
  	return acl;
2982baa2a   Christoph Hellwig   fs: add get_acl h...
154
155
  }
  EXPORT_SYMBOL(get_acl);
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
156
  /*
f61f6da0d   Chuck Lever   NFS: Prevent memo...
157
158
159
160
161
   * Init a fresh posix_acl
   */
  void
  posix_acl_init(struct posix_acl *acl, int count)
  {
667172605   Elena Reshetova   posix_acl: conver...
162
  	refcount_set(&acl->a_refcount, 1);
f61f6da0d   Chuck Lever   NFS: Prevent memo...
163
164
  	acl->a_count = count;
  }
0afaa1204   Andrew Morton   posix_acl: uninli...
165
  EXPORT_SYMBOL(posix_acl_init);
f61f6da0d   Chuck Lever   NFS: Prevent memo...
166
167
  
  /*
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
168
169
170
   * Allocate a new ACL with the specified number of entries.
   */
  struct posix_acl *
dd0fc66fb   Al Viro   [PATCH] gfp flags...
171
  posix_acl_alloc(int count, gfp_t flags)
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
172
173
174
175
  {
  	const size_t size = sizeof(struct posix_acl) +
  	                    count * sizeof(struct posix_acl_entry);
  	struct posix_acl *acl = kmalloc(size, flags);
f61f6da0d   Chuck Lever   NFS: Prevent memo...
176
177
  	if (acl)
  		posix_acl_init(acl, count);
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
178
179
  	return acl;
  }
0afaa1204   Andrew Morton   posix_acl: uninli...
180
  EXPORT_SYMBOL(posix_acl_alloc);
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
181
182
183
184
  
  /*
   * Clone an ACL.
   */
edde854e8   Al Viro   bury posix_acl_.....
185
  static struct posix_acl *
dd0fc66fb   Al Viro   [PATCH] gfp flags...
186
  posix_acl_clone(const struct posix_acl *acl, gfp_t flags)
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
187
188
189
190
191
192
  {
  	struct posix_acl *clone = NULL;
  
  	if (acl) {
  		int size = sizeof(struct posix_acl) + acl->a_count *
  		           sizeof(struct posix_acl_entry);
52978be63   Alexey Dobriyan   [PATCH] kmemdup: ...
193
194
  		clone = kmemdup(acl, size, flags);
  		if (clone)
667172605   Elena Reshetova   posix_acl: conver...
195
  			refcount_set(&clone->a_refcount, 1);
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
196
197
198
199
200
201
202
203
  	}
  	return clone;
  }
  
  /*
   * Check if an acl is valid. Returns 0 if it is, or -E... otherwise.
   */
  int
0d4d717f2   Eric W. Biederman   vfs: Verify acls ...
204
  posix_acl_valid(struct user_namespace *user_ns, const struct posix_acl *acl)
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
205
206
207
  {
  	const struct posix_acl_entry *pa, *pe;
  	int state = ACL_USER_OBJ;
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
208
209
210
211
212
213
214
215
  	int needs_mask = 0;
  
  	FOREACH_ACL_ENTRY(pa, acl, pe) {
  		if (pa->e_perm & ~(ACL_READ|ACL_WRITE|ACL_EXECUTE))
  			return -EINVAL;
  		switch (pa->e_tag) {
  			case ACL_USER_OBJ:
  				if (state == ACL_USER_OBJ) {
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
216
217
218
219
220
221
222
223
  					state = ACL_USER;
  					break;
  				}
  				return -EINVAL;
  
  			case ACL_USER:
  				if (state != ACL_USER)
  					return -EINVAL;
0d4d717f2   Eric W. Biederman   vfs: Verify acls ...
224
  				if (!kuid_has_mapping(user_ns, pa->e_uid))
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
225
  					return -EINVAL;
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
226
227
228
229
230
  				needs_mask = 1;
  				break;
  
  			case ACL_GROUP_OBJ:
  				if (state == ACL_USER) {
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
231
232
233
234
235
236
237
238
  					state = ACL_GROUP;
  					break;
  				}
  				return -EINVAL;
  
  			case ACL_GROUP:
  				if (state != ACL_GROUP)
  					return -EINVAL;
0d4d717f2   Eric W. Biederman   vfs: Verify acls ...
239
  				if (!kgid_has_mapping(user_ns, pa->e_gid))
2f6f0654a   Eric W. Biederman   userns: Convert v...
240
  					return -EINVAL;
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
  				needs_mask = 1;
  				break;
  
  			case ACL_MASK:
  				if (state != ACL_GROUP)
  					return -EINVAL;
  				state = ACL_OTHER;
  				break;
  
  			case ACL_OTHER:
  				if (state == ACL_OTHER ||
  				    (state == ACL_GROUP && !needs_mask)) {
  					state = 0;
  					break;
  				}
  				return -EINVAL;
  
  			default:
  				return -EINVAL;
  		}
  	}
  	if (state == 0)
  		return 0;
  	return -EINVAL;
  }
0afaa1204   Andrew Morton   posix_acl: uninli...
266
  EXPORT_SYMBOL(posix_acl_valid);
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
267
268
269
270
271
272
  
  /*
   * Returns 0 if the acl can be exactly represented in the traditional
   * file mode permission bits, or else 1. Returns -E... on error.
   */
  int
d6952123b   Al Viro   switch posix_acl_...
273
  posix_acl_equiv_mode(const struct posix_acl *acl, umode_t *mode_p)
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
274
275
  {
  	const struct posix_acl_entry *pa, *pe;
d6952123b   Al Viro   switch posix_acl_...
276
  	umode_t mode = 0;
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
277
  	int not_equiv = 0;
50c6e282b   Christoph Hellwig   posix_acl: handle...
278
279
280
281
282
  	/*
  	 * A null ACL can always be presented as mode bits.
  	 */
  	if (!acl)
  		return 0;
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
  	FOREACH_ACL_ENTRY(pa, acl, pe) {
  		switch (pa->e_tag) {
  			case ACL_USER_OBJ:
  				mode |= (pa->e_perm & S_IRWXO) << 6;
  				break;
  			case ACL_GROUP_OBJ:
  				mode |= (pa->e_perm & S_IRWXO) << 3;
  				break;
  			case ACL_OTHER:
  				mode |= pa->e_perm & S_IRWXO;
  				break;
  			case ACL_MASK:
  				mode = (mode & ~S_IRWXG) |
  				       ((pa->e_perm & S_IRWXO) << 3);
  				not_equiv = 1;
  				break;
  			case ACL_USER:
  			case ACL_GROUP:
  				not_equiv = 1;
  				break;
  			default:
  				return -EINVAL;
  		}
  	}
          if (mode_p)
                  *mode_p = (*mode_p & ~S_IRWXUGO) | mode;
          return not_equiv;
  }
0afaa1204   Andrew Morton   posix_acl: uninli...
311
  EXPORT_SYMBOL(posix_acl_equiv_mode);
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
312
313
314
315
316
  
  /*
   * Create an ACL representing the file mode permission bits of an inode.
   */
  struct posix_acl *
3a5fba19b   Al Viro   switch posix_acl_...
317
  posix_acl_from_mode(umode_t mode, gfp_t flags)
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
318
319
320
321
322
323
  {
  	struct posix_acl *acl = posix_acl_alloc(3, flags);
  	if (!acl)
  		return ERR_PTR(-ENOMEM);
  
  	acl->a_entries[0].e_tag  = ACL_USER_OBJ;
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
324
325
326
  	acl->a_entries[0].e_perm = (mode & S_IRWXU) >> 6;
  
  	acl->a_entries[1].e_tag  = ACL_GROUP_OBJ;
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
327
328
329
  	acl->a_entries[1].e_perm = (mode & S_IRWXG) >> 3;
  
  	acl->a_entries[2].e_tag  = ACL_OTHER;
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
330
331
332
  	acl->a_entries[2].e_perm = (mode & S_IRWXO);
  	return acl;
  }
0afaa1204   Andrew Morton   posix_acl: uninli...
333
  EXPORT_SYMBOL(posix_acl_from_mode);
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
334
335
336
337
338
339
340
341
342
343
  
  /*
   * Return 0 if current is granted want access to the inode
   * by the acl. Returns -E... otherwise.
   */
  int
  posix_acl_permission(struct inode *inode, const struct posix_acl *acl, int want)
  {
  	const struct posix_acl_entry *pa, *pe, *mask_obj;
  	int found = 0;
63d72b93f   Linus Torvalds   vfs: clean up pos...
344
  	want &= MAY_READ | MAY_WRITE | MAY_EXEC;
d124b60a8   Andreas Gruenbacher   vfs: pass all mas...
345

1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
346
347
348
349
  	FOREACH_ACL_ENTRY(pa, acl, pe) {
                  switch(pa->e_tag) {
                          case ACL_USER_OBJ:
  				/* (May have been checked already) */
2f6f0654a   Eric W. Biederman   userns: Convert v...
350
  				if (uid_eq(inode->i_uid, current_fsuid()))
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
351
352
353
                                          goto check_perm;
                                  break;
                          case ACL_USER:
2f6f0654a   Eric W. Biederman   userns: Convert v...
354
  				if (uid_eq(pa->e_uid, current_fsuid()))
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
355
356
357
358
359
360
361
362
363
364
                                          goto mask;
  				break;
                          case ACL_GROUP_OBJ:
                                  if (in_group_p(inode->i_gid)) {
  					found = 1;
  					if ((pa->e_perm & want) == want)
  						goto mask;
                                  }
  				break;
                          case ACL_GROUP:
2f6f0654a   Eric W. Biederman   userns: Convert v...
365
  				if (in_group_p(pa->e_gid)) {
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
  					found = 1;
  					if ((pa->e_perm & want) == want)
  						goto mask;
                                  }
                                  break;
                          case ACL_MASK:
                                  break;
                          case ACL_OTHER:
  				if (found)
  					return -EACCES;
  				else
  					goto check_perm;
  			default:
  				return -EIO;
                  }
          }
  	return -EIO;
  
  mask:
  	for (mask_obj = pa+1; mask_obj != pe; mask_obj++) {
  		if (mask_obj->e_tag == ACL_MASK) {
  			if ((pa->e_perm & mask_obj->e_perm & want) == want)
  				return 0;
  			return -EACCES;
  		}
  	}
  
  check_perm:
  	if ((pa->e_perm & want) == want)
  		return 0;
  	return -EACCES;
  }
  
  /*
   * Modify acl when creating a new inode. The caller must ensure the acl is
   * only referenced once.
   *
   * mode_p initially must contain the mode parameter to the open() / creat()
   * system calls. All permissions that are not granted by the acl are removed.
   * The permissions in the acl are changed to reflect the mode_p parameter.
   */
d3fb61207   Al Viro   switch posix_acl_...
407
  static int posix_acl_create_masq(struct posix_acl *acl, umode_t *mode_p)
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
408
409
410
  {
  	struct posix_acl_entry *pa, *pe;
  	struct posix_acl_entry *group_obj = NULL, *mask_obj = NULL;
d3fb61207   Al Viro   switch posix_acl_...
411
  	umode_t mode = *mode_p;
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
  	int not_equiv = 0;
  
  	/* assert(atomic_read(acl->a_refcount) == 1); */
  
  	FOREACH_ACL_ENTRY(pa, acl, pe) {
                  switch(pa->e_tag) {
                          case ACL_USER_OBJ:
  				pa->e_perm &= (mode >> 6) | ~S_IRWXO;
  				mode &= (pa->e_perm << 6) | ~S_IRWXU;
  				break;
  
  			case ACL_USER:
  			case ACL_GROUP:
  				not_equiv = 1;
  				break;
  
                          case ACL_GROUP_OBJ:
  				group_obj = pa;
                                  break;
  
                          case ACL_OTHER:
  				pa->e_perm &= mode | ~S_IRWXO;
  				mode &= pa->e_perm | ~S_IRWXO;
                                  break;
  
                          case ACL_MASK:
  				mask_obj = pa;
  				not_equiv = 1;
                                  break;
  
  			default:
  				return -EIO;
                  }
          }
  
  	if (mask_obj) {
  		mask_obj->e_perm &= (mode >> 3) | ~S_IRWXO;
  		mode &= (mask_obj->e_perm << 3) | ~S_IRWXG;
  	} else {
  		if (!group_obj)
  			return -EIO;
  		group_obj->e_perm &= (mode >> 3) | ~S_IRWXO;
  		mode &= (group_obj->e_perm << 3) | ~S_IRWXG;
  	}
  
  	*mode_p = (*mode_p & ~S_IRWXUGO) | mode;
          return not_equiv;
  }
  
  /*
   * Modify the ACL for the chmod syscall.
   */
5bf3258fd   Christoph Hellwig   fs: make posix_ac...
464
  static int __posix_acl_chmod_masq(struct posix_acl *acl, umode_t mode)
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
  {
  	struct posix_acl_entry *group_obj = NULL, *mask_obj = NULL;
  	struct posix_acl_entry *pa, *pe;
  
  	/* assert(atomic_read(acl->a_refcount) == 1); */
  
  	FOREACH_ACL_ENTRY(pa, acl, pe) {
  		switch(pa->e_tag) {
  			case ACL_USER_OBJ:
  				pa->e_perm = (mode & S_IRWXU) >> 6;
  				break;
  
  			case ACL_USER:
  			case ACL_GROUP:
  				break;
  
  			case ACL_GROUP_OBJ:
  				group_obj = pa;
  				break;
  
  			case ACL_MASK:
  				mask_obj = pa;
  				break;
  
  			case ACL_OTHER:
  				pa->e_perm = (mode & S_IRWXO);
  				break;
  
  			default:
  				return -EIO;
  		}
  	}
  
  	if (mask_obj) {
  		mask_obj->e_perm = (mode & S_IRWXG) >> 3;
  	} else {
  		if (!group_obj)
  			return -EIO;
  		group_obj->e_perm = (mode & S_IRWXG) >> 3;
  	}
  
  	return 0;
  }
bc26ab5f6   Al Viro   kill boilerplate ...
508
509
  
  int
37bc15392   Christoph Hellwig   fs: make posix_ac...
510
  __posix_acl_create(struct posix_acl **acl, gfp_t gfp, umode_t *mode_p)
826cae2f2   Al Viro   kill boilerplates...
511
512
513
514
515
516
517
518
519
520
521
522
523
524
  {
  	struct posix_acl *clone = posix_acl_clone(*acl, gfp);
  	int err = -ENOMEM;
  	if (clone) {
  		err = posix_acl_create_masq(clone, mode_p);
  		if (err < 0) {
  			posix_acl_release(clone);
  			clone = NULL;
  		}
  	}
  	posix_acl_release(*acl);
  	*acl = clone;
  	return err;
  }
37bc15392   Christoph Hellwig   fs: make posix_ac...
525
  EXPORT_SYMBOL(__posix_acl_create);
826cae2f2   Al Viro   kill boilerplates...
526
527
  
  int
5bf3258fd   Christoph Hellwig   fs: make posix_ac...
528
  __posix_acl_chmod(struct posix_acl **acl, gfp_t gfp, umode_t mode)
bc26ab5f6   Al Viro   kill boilerplate ...
529
530
531
532
  {
  	struct posix_acl *clone = posix_acl_clone(*acl, gfp);
  	int err = -ENOMEM;
  	if (clone) {
5bf3258fd   Christoph Hellwig   fs: make posix_ac...
533
  		err = __posix_acl_chmod_masq(clone, mode);
bc26ab5f6   Al Viro   kill boilerplate ...
534
535
536
537
538
539
540
541
542
  		if (err) {
  			posix_acl_release(clone);
  			clone = NULL;
  		}
  	}
  	posix_acl_release(*acl);
  	*acl = clone;
  	return err;
  }
5bf3258fd   Christoph Hellwig   fs: make posix_ac...
543
544
545
  EXPORT_SYMBOL(__posix_acl_chmod);
  
  int
37bc15392   Christoph Hellwig   fs: make posix_ac...
546
  posix_acl_chmod(struct inode *inode, umode_t mode)
5bf3258fd   Christoph Hellwig   fs: make posix_ac...
547
548
549
550
551
552
553
554
555
556
  {
  	struct posix_acl *acl;
  	int ret = 0;
  
  	if (!IS_POSIXACL(inode))
  		return 0;
  	if (!inode->i_op->set_acl)
  		return -EOPNOTSUPP;
  
  	acl = get_acl(inode, ACL_TYPE_ACCESS);
789b663ae   Trond Myklebust   fs: get_acl() mus...
557
558
559
  	if (IS_ERR_OR_NULL(acl)) {
  		if (acl == ERR_PTR(-EOPNOTSUPP))
  			return 0;
5bf3258fd   Christoph Hellwig   fs: make posix_ac...
560
  		return PTR_ERR(acl);
789b663ae   Trond Myklebust   fs: get_acl() mus...
561
  	}
5bf3258fd   Christoph Hellwig   fs: make posix_ac...
562

37bc15392   Christoph Hellwig   fs: make posix_ac...
563
  	ret = __posix_acl_chmod(&acl, GFP_KERNEL, mode);
5bf3258fd   Christoph Hellwig   fs: make posix_ac...
564
565
566
567
568
569
  	if (ret)
  		return ret;
  	ret = inode->i_op->set_acl(inode, acl, ACL_TYPE_ACCESS);
  	posix_acl_release(acl);
  	return ret;
  }
bc26ab5f6   Al Viro   kill boilerplate ...
570
  EXPORT_SYMBOL(posix_acl_chmod);
5c8ebd57b   Christoph Hellwig   fs: merge xattr_a...
571

37bc15392   Christoph Hellwig   fs: make posix_ac...
572
573
574
575
576
  int
  posix_acl_create(struct inode *dir, umode_t *mode,
  		struct posix_acl **default_acl, struct posix_acl **acl)
  {
  	struct posix_acl *p;
c0c3a718e   Dan Carpenter   fs/posix_acl.c: m...
577
  	struct posix_acl *clone;
37bc15392   Christoph Hellwig   fs: make posix_ac...
578
  	int ret;
c0c3a718e   Dan Carpenter   fs/posix_acl.c: m...
579
580
  	*acl = NULL;
  	*default_acl = NULL;
37bc15392   Christoph Hellwig   fs: make posix_ac...
581
  	if (S_ISLNK(*mode) || !IS_POSIXACL(dir))
c0c3a718e   Dan Carpenter   fs/posix_acl.c: m...
582
  		return 0;
37bc15392   Christoph Hellwig   fs: make posix_ac...
583
584
  
  	p = get_acl(dir, ACL_TYPE_DEFAULT);
c0c3a718e   Dan Carpenter   fs/posix_acl.c: m...
585
586
587
  	if (!p || p == ERR_PTR(-EOPNOTSUPP)) {
  		*mode &= ~current_umask();
  		return 0;
37bc15392   Christoph Hellwig   fs: make posix_ac...
588
  	}
c0c3a718e   Dan Carpenter   fs/posix_acl.c: m...
589
590
  	if (IS_ERR(p))
  		return PTR_ERR(p);
37bc15392   Christoph Hellwig   fs: make posix_ac...
591

beaf226b8   Miklos Szeredi   posix_acl: don't ...
592
  	ret = -ENOMEM;
c0c3a718e   Dan Carpenter   fs/posix_acl.c: m...
593
594
  	clone = posix_acl_clone(p, GFP_NOFS);
  	if (!clone)
beaf226b8   Miklos Szeredi   posix_acl: don't ...
595
  		goto err_release;
37bc15392   Christoph Hellwig   fs: make posix_ac...
596

c0c3a718e   Dan Carpenter   fs/posix_acl.c: m...
597
  	ret = posix_acl_create_masq(clone, mode);
fed0b588b   Omar Sandoval   posix_acl: fix re...
598
  	if (ret < 0)
beaf226b8   Miklos Szeredi   posix_acl: don't ...
599
  		goto err_release_clone;
37bc15392   Christoph Hellwig   fs: make posix_ac...
600

c0c3a718e   Dan Carpenter   fs/posix_acl.c: m...
601
602
603
604
  	if (ret == 0)
  		posix_acl_release(clone);
  	else
  		*acl = clone;
37bc15392   Christoph Hellwig   fs: make posix_ac...
605

c0c3a718e   Dan Carpenter   fs/posix_acl.c: m...
606
  	if (!S_ISDIR(*mode))
37bc15392   Christoph Hellwig   fs: make posix_ac...
607
  		posix_acl_release(p);
c0c3a718e   Dan Carpenter   fs/posix_acl.c: m...
608
  	else
37bc15392   Christoph Hellwig   fs: make posix_ac...
609
  		*default_acl = p;
37bc15392   Christoph Hellwig   fs: make posix_ac...
610

37bc15392   Christoph Hellwig   fs: make posix_ac...
611
  	return 0;
fed0b588b   Omar Sandoval   posix_acl: fix re...
612

beaf226b8   Miklos Szeredi   posix_acl: don't ...
613
  err_release_clone:
c0c3a718e   Dan Carpenter   fs/posix_acl.c: m...
614
  	posix_acl_release(clone);
beaf226b8   Miklos Szeredi   posix_acl: don't ...
615
  err_release:
fed0b588b   Omar Sandoval   posix_acl: fix re...
616
  	posix_acl_release(p);
beaf226b8   Miklos Szeredi   posix_acl: don't ...
617
  	return ret;
37bc15392   Christoph Hellwig   fs: make posix_ac...
618
619
  }
  EXPORT_SYMBOL_GPL(posix_acl_create);
073931017   Jan Kara   posix_acl: Clear ...
620
621
  /**
   * posix_acl_update_mode  -  update mode in set_acl
e39e773ad   Randy Dunlap   fs/posix_acl.c: f...
622
623
624
   * @inode: target inode
   * @mode_p: mode (pointer) for update
   * @acl: acl pointer
073931017   Jan Kara   posix_acl: Clear ...
625
626
627
   *
   * Update the file mode when setting an ACL: compute the new file permission
   * bits based on the ACL.  In addition, if the ACL is equivalent to the new
e39e773ad   Randy Dunlap   fs/posix_acl.c: f...
628
   * file mode, set *@acl to NULL to indicate that no ACL should be set.
073931017   Jan Kara   posix_acl: Clear ...
629
   *
e39e773ad   Randy Dunlap   fs/posix_acl.c: f...
630
   * As with chmod, clear the setgid bit if the caller is not in the owning group
073931017   Jan Kara   posix_acl: Clear ...
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
   * or capable of CAP_FSETID (see inode_change_ok).
   *
   * Called from set_acl inode operations.
   */
  int posix_acl_update_mode(struct inode *inode, umode_t *mode_p,
  			  struct posix_acl **acl)
  {
  	umode_t mode = inode->i_mode;
  	int error;
  
  	error = posix_acl_equiv_mode(*acl, &mode);
  	if (error < 0)
  		return error;
  	if (error == 0)
  		*acl = NULL;
  	if (!in_group_p(inode->i_gid) &&
  	    !capable_wrt_inode_uidgid(inode, CAP_FSETID))
  		mode &= ~S_ISGID;
  	*mode_p = mode;
  	return 0;
  }
  EXPORT_SYMBOL(posix_acl_update_mode);
5c8ebd57b   Christoph Hellwig   fs: merge xattr_a...
653
654
655
656
657
658
659
  /*
   * Fix up the uids and gids in posix acl extended attributes in place.
   */
  static void posix_acl_fix_xattr_userns(
  	struct user_namespace *to, struct user_namespace *from,
  	void *value, size_t size)
  {
2211d5ba5   Andreas Gruenbacher   posix_acl: xattr ...
660
661
  	struct posix_acl_xattr_header *header = value;
  	struct posix_acl_xattr_entry *entry = (void *)(header + 1), *end;
5c8ebd57b   Christoph Hellwig   fs: merge xattr_a...
662
663
664
665
666
667
  	int count;
  	kuid_t uid;
  	kgid_t gid;
  
  	if (!value)
  		return;
2211d5ba5   Andreas Gruenbacher   posix_acl: xattr ...
668
  	if (size < sizeof(struct posix_acl_xattr_header))
5c8ebd57b   Christoph Hellwig   fs: merge xattr_a...
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
  		return;
  	if (header->a_version != cpu_to_le32(POSIX_ACL_XATTR_VERSION))
  		return;
  
  	count = posix_acl_xattr_count(size);
  	if (count < 0)
  		return;
  	if (count == 0)
  		return;
  
  	for (end = entry + count; entry != end; entry++) {
  		switch(le16_to_cpu(entry->e_tag)) {
  		case ACL_USER:
  			uid = make_kuid(from, le32_to_cpu(entry->e_id));
  			entry->e_id = cpu_to_le32(from_kuid(to, uid));
  			break;
  		case ACL_GROUP:
  			gid = make_kgid(from, le32_to_cpu(entry->e_id));
  			entry->e_id = cpu_to_le32(from_kgid(to, gid));
  			break;
  		default:
  			break;
  		}
  	}
  }
  
  void posix_acl_fix_xattr_from_user(void *value, size_t size)
  {
  	struct user_namespace *user_ns = current_user_ns();
  	if (user_ns == &init_user_ns)
  		return;
  	posix_acl_fix_xattr_userns(&init_user_ns, user_ns, value, size);
  }
  
  void posix_acl_fix_xattr_to_user(void *value, size_t size)
  {
  	struct user_namespace *user_ns = current_user_ns();
  	if (user_ns == &init_user_ns)
  		return;
  	posix_acl_fix_xattr_userns(user_ns, &init_user_ns, value, size);
  }
  
  /*
   * Convert from extended attribute to in-memory representation.
   */
  struct posix_acl *
  posix_acl_from_xattr(struct user_namespace *user_ns,
  		     const void *value, size_t size)
  {
2211d5ba5   Andreas Gruenbacher   posix_acl: xattr ...
718
719
  	const struct posix_acl_xattr_header *header = value;
  	const struct posix_acl_xattr_entry *entry = (const void *)(header + 1), *end;
5c8ebd57b   Christoph Hellwig   fs: merge xattr_a...
720
721
722
723
724
725
  	int count;
  	struct posix_acl *acl;
  	struct posix_acl_entry *acl_e;
  
  	if (!value)
  		return NULL;
2211d5ba5   Andreas Gruenbacher   posix_acl: xattr ...
726
  	if (size < sizeof(struct posix_acl_xattr_header))
5c8ebd57b   Christoph Hellwig   fs: merge xattr_a...
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
  		 return ERR_PTR(-EINVAL);
  	if (header->a_version != cpu_to_le32(POSIX_ACL_XATTR_VERSION))
  		return ERR_PTR(-EOPNOTSUPP);
  
  	count = posix_acl_xattr_count(size);
  	if (count < 0)
  		return ERR_PTR(-EINVAL);
  	if (count == 0)
  		return NULL;
  	
  	acl = posix_acl_alloc(count, GFP_NOFS);
  	if (!acl)
  		return ERR_PTR(-ENOMEM);
  	acl_e = acl->a_entries;
  	
  	for (end = entry + count; entry != end; acl_e++, entry++) {
  		acl_e->e_tag  = le16_to_cpu(entry->e_tag);
  		acl_e->e_perm = le16_to_cpu(entry->e_perm);
  
  		switch(acl_e->e_tag) {
  			case ACL_USER_OBJ:
  			case ACL_GROUP_OBJ:
  			case ACL_MASK:
  			case ACL_OTHER:
  				break;
  
  			case ACL_USER:
  				acl_e->e_uid =
  					make_kuid(user_ns,
  						  le32_to_cpu(entry->e_id));
  				if (!uid_valid(acl_e->e_uid))
  					goto fail;
  				break;
  			case ACL_GROUP:
  				acl_e->e_gid =
  					make_kgid(user_ns,
  						  le32_to_cpu(entry->e_id));
  				if (!gid_valid(acl_e->e_gid))
  					goto fail;
  				break;
  
  			default:
  				goto fail;
  		}
  	}
  	return acl;
  
  fail:
  	posix_acl_release(acl);
  	return ERR_PTR(-EINVAL);
  }
  EXPORT_SYMBOL (posix_acl_from_xattr);
  
  /*
   * Convert from in-memory to extended attribute representation.
   */
  int
  posix_acl_to_xattr(struct user_namespace *user_ns, const struct posix_acl *acl,
  		   void *buffer, size_t size)
  {
2211d5ba5   Andreas Gruenbacher   posix_acl: xattr ...
787
788
  	struct posix_acl_xattr_header *ext_acl = buffer;
  	struct posix_acl_xattr_entry *ext_entry;
5c8ebd57b   Christoph Hellwig   fs: merge xattr_a...
789
790
791
792
793
794
795
  	int real_size, n;
  
  	real_size = posix_acl_xattr_size(acl->a_count);
  	if (!buffer)
  		return real_size;
  	if (real_size > size)
  		return -ERANGE;
47ba97344   Dan Carpenter   fs: NULL derefere...
796

2211d5ba5   Andreas Gruenbacher   posix_acl: xattr ...
797
  	ext_entry = (void *)(ext_acl + 1);
5c8ebd57b   Christoph Hellwig   fs: merge xattr_a...
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
  	ext_acl->a_version = cpu_to_le32(POSIX_ACL_XATTR_VERSION);
  
  	for (n=0; n < acl->a_count; n++, ext_entry++) {
  		const struct posix_acl_entry *acl_e = &acl->a_entries[n];
  		ext_entry->e_tag  = cpu_to_le16(acl_e->e_tag);
  		ext_entry->e_perm = cpu_to_le16(acl_e->e_perm);
  		switch(acl_e->e_tag) {
  		case ACL_USER:
  			ext_entry->e_id =
  				cpu_to_le32(from_kuid(user_ns, acl_e->e_uid));
  			break;
  		case ACL_GROUP:
  			ext_entry->e_id =
  				cpu_to_le32(from_kgid(user_ns, acl_e->e_gid));
  			break;
  		default:
  			ext_entry->e_id = cpu_to_le32(ACL_UNDEFINED_ID);
  			break;
  		}
  	}
  	return real_size;
  }
  EXPORT_SYMBOL (posix_acl_to_xattr);
2aeccbe95   Christoph Hellwig   fs: add generic x...
821
822
  
  static int
d9a82a040   Andreas Gruenbacher   xattr handlers: P...
823
  posix_acl_xattr_get(const struct xattr_handler *handler,
b296821a7   Al Viro   xattr_handler: pa...
824
  		    struct dentry *unused, struct inode *inode,
3484eba91   Mark Salyzyn   FROMLIST: Add fla...
825
  		    const char *name, void *value, size_t size, int flags)
2aeccbe95   Christoph Hellwig   fs: add generic x...
826
827
828
  {
  	struct posix_acl *acl;
  	int error;
b296821a7   Al Viro   xattr_handler: pa...
829
  	if (!IS_POSIXACL(inode))
2aeccbe95   Christoph Hellwig   fs: add generic x...
830
  		return -EOPNOTSUPP;
b296821a7   Al Viro   xattr_handler: pa...
831
  	if (S_ISLNK(inode->i_mode))
2aeccbe95   Christoph Hellwig   fs: add generic x...
832
  		return -EOPNOTSUPP;
b296821a7   Al Viro   xattr_handler: pa...
833
  	acl = get_acl(inode, handler->flags);
2aeccbe95   Christoph Hellwig   fs: add generic x...
834
835
836
837
838
839
840
841
842
843
  	if (IS_ERR(acl))
  		return PTR_ERR(acl);
  	if (acl == NULL)
  		return -ENODATA;
  
  	error = posix_acl_to_xattr(&init_user_ns, acl, value, size);
  	posix_acl_release(acl);
  
  	return error;
  }
485e71e8f   Andreas Gruenbacher   posix_acl: Add se...
844
845
  int
  set_posix_acl(struct inode *inode, int type, struct posix_acl *acl)
2aeccbe95   Christoph Hellwig   fs: add generic x...
846
  {
2aeccbe95   Christoph Hellwig   fs: add generic x...
847
848
849
850
  	if (!IS_POSIXACL(inode))
  		return -EOPNOTSUPP;
  	if (!inode->i_op->set_acl)
  		return -EOPNOTSUPP;
485e71e8f   Andreas Gruenbacher   posix_acl: Add se...
851
852
  	if (type == ACL_TYPE_DEFAULT && !S_ISDIR(inode->i_mode))
  		return acl ? -EACCES : 0;
2aeccbe95   Christoph Hellwig   fs: add generic x...
853
854
  	if (!inode_owner_or_capable(inode))
  		return -EPERM;
485e71e8f   Andreas Gruenbacher   posix_acl: Add se...
855
  	if (acl) {
a867d7349   Linus Torvalds   Merge branch 'for...
856
  		int ret = posix_acl_valid(inode->i_sb->s_user_ns, acl);
485e71e8f   Andreas Gruenbacher   posix_acl: Add se...
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
  		if (ret)
  			return ret;
  	}
  	return inode->i_op->set_acl(inode, acl, type);
  }
  EXPORT_SYMBOL(set_posix_acl);
  
  static int
  posix_acl_xattr_set(const struct xattr_handler *handler,
  		    struct dentry *unused, struct inode *inode,
  		    const char *name, const void *value,
  		    size_t size, int flags)
  {
  	struct posix_acl *acl = NULL;
  	int ret;
2aeccbe95   Christoph Hellwig   fs: add generic x...
872
873
874
875
  	if (value) {
  		acl = posix_acl_from_xattr(&init_user_ns, value, size);
  		if (IS_ERR(acl))
  			return PTR_ERR(acl);
2aeccbe95   Christoph Hellwig   fs: add generic x...
876
  	}
485e71e8f   Andreas Gruenbacher   posix_acl: Add se...
877
  	ret = set_posix_acl(inode, handler->flags, acl);
2aeccbe95   Christoph Hellwig   fs: add generic x...
878
879
880
  	posix_acl_release(acl);
  	return ret;
  }
764a5c6b1   Andreas Gruenbacher   xattr handlers: S...
881
882
  static bool
  posix_acl_xattr_list(struct dentry *dentry)
2aeccbe95   Christoph Hellwig   fs: add generic x...
883
  {
764a5c6b1   Andreas Gruenbacher   xattr handlers: S...
884
  	return IS_POSIXACL(d_backing_inode(dentry));
2aeccbe95   Christoph Hellwig   fs: add generic x...
885
886
887
  }
  
  const struct xattr_handler posix_acl_access_xattr_handler = {
98e9cb571   Andreas Gruenbacher   vfs: Distinguish ...
888
  	.name = XATTR_NAME_POSIX_ACL_ACCESS,
2aeccbe95   Christoph Hellwig   fs: add generic x...
889
890
891
892
893
894
895
896
  	.flags = ACL_TYPE_ACCESS,
  	.list = posix_acl_xattr_list,
  	.get = posix_acl_xattr_get,
  	.set = posix_acl_xattr_set,
  };
  EXPORT_SYMBOL_GPL(posix_acl_access_xattr_handler);
  
  const struct xattr_handler posix_acl_default_xattr_handler = {
98e9cb571   Andreas Gruenbacher   vfs: Distinguish ...
897
  	.name = XATTR_NAME_POSIX_ACL_DEFAULT,
2aeccbe95   Christoph Hellwig   fs: add generic x...
898
899
900
901
902
903
  	.flags = ACL_TYPE_DEFAULT,
  	.list = posix_acl_xattr_list,
  	.get = posix_acl_xattr_get,
  	.set = posix_acl_xattr_set,
  };
  EXPORT_SYMBOL_GPL(posix_acl_default_xattr_handler);
feda821e7   Christoph Hellwig   fs: remove generi...
904
905
906
907
908
909
  
  int simple_set_acl(struct inode *inode, struct posix_acl *acl, int type)
  {
  	int error;
  
  	if (type == ACL_TYPE_ACCESS) {
497de07d8   Gu Zheng   tmpfs: clear S_IS...
910
911
912
913
  		error = posix_acl_update_mode(inode,
  				&inode->i_mode, &acl);
  		if (error)
  			return error;
feda821e7   Christoph Hellwig   fs: remove generi...
914
  	}
078cd8279   Deepa Dinamani   fs: Replace CURRE...
915
  	inode->i_ctime = current_time(inode);
feda821e7   Christoph Hellwig   fs: remove generi...
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
  	set_cached_acl(inode, type, acl);
  	return 0;
  }
  
  int simple_acl_create(struct inode *dir, struct inode *inode)
  {
  	struct posix_acl *default_acl, *acl;
  	int error;
  
  	error = posix_acl_create(dir, &inode->i_mode, &default_acl, &acl);
  	if (error)
  		return error;
  
  	set_cached_acl(inode, ACL_TYPE_DEFAULT, default_acl);
  	set_cached_acl(inode, ACL_TYPE_ACCESS, acl);
  
  	if (default_acl)
  		posix_acl_release(default_acl);
  	if (acl)
  		posix_acl_release(acl);
  	return 0;
  }