Blame view

drivers/hwmon/lm83.c 12.7 KB
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
1
2
3
  /*
   * lm83.c - Part of lm_sensors, Linux kernel modules for hardware
   *          monitoring
b57dc3940   Jean Delvare   hwmon: (lm83) Cle...
4
   * Copyright (C) 2003-2009  Jean Delvare <khali@linux-fr.org>
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
5
6
7
8
9
10
11
12
13
14
   *
   * Heavily inspired from the lm78, lm75 and adm1021 drivers. The LM83 is
   * a sensor chip made by National Semiconductor. It reports up to four
   * temperatures (its own plus up to three external ones) with a 1 deg
   * resolution and a 3-4 deg accuracy. Complete datasheet can be obtained
   * from National's website at:
   *   http://www.national.com/pf/LM/LM83.html
   * Since the datasheet omits to give the chip stepping code, I give it
   * here: 0x03 (at register 0xff).
   *
43cb7ebee   Jordan Crouse   [PATCH] lm83: Add...
15
16
17
18
   * Also supports the LM82 temp sensor, which is basically a stripped down
   * model of the LM83.  Datasheet is here:
   * http://www.national.com/pf/LM/LM82.html
   *
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
19
20
21
22
23
24
25
26
27
28
29
30
31
32
   * This program is free software; you can redistribute it and/or modify
   * it under the terms of the GNU General Public License as published by
   * the Free Software Foundation; either version 2 of the License, or
   * (at your option) any later version.
   *
   * This program is distributed in the hope that it will be useful,
   * but WITHOUT ANY WARRANTY; without even the implied warranty of
   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
   * GNU General Public License for more details.
   *
   * You should have received a copy of the GNU General Public License
   * along with this program; if not, write to the Free Software
   * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
   */
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
33
34
35
36
37
  #include <linux/module.h>
  #include <linux/init.h>
  #include <linux/slab.h>
  #include <linux/jiffies.h>
  #include <linux/i2c.h>
10c08f810   Jean Delvare   [PATCH] I2C: rena...
38
  #include <linux/hwmon-sysfs.h>
943b0830c   Mark M. Hoffman   [PATCH] I2C hwmon...
39
40
  #include <linux/hwmon.h>
  #include <linux/err.h>
9a61bf630   Ingo Molnar   [PATCH] hwmon: Se...
41
  #include <linux/mutex.h>
0e39e01c9   Jean Delvare   hwmon: Fix unchec...
42
  #include <linux/sysfs.h>
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
43
44
45
46
47
48
  
  /*
   * Addresses to scan
   * Address is selected using 2 three-level pins, resulting in 9 possible
   * addresses.
   */
25e9c86d5   Mark M. Hoffman   hwmon: normal_i2c...
49
50
  static const unsigned short normal_i2c[] = {
  	0x18, 0x19, 0x1a, 0x29, 0x2a, 0x2b, 0x4c, 0x4d, 0x4e, I2C_CLIENT_END };
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
51

e5e9f44c2   Jean Delvare   i2c: Drop I2C_CLI...
52
  enum chips { lm83, lm82 };
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
  
  /*
   * The LM83 registers
   * Manufacturer ID is 0x01 for National Semiconductor.
   */
  
  #define LM83_REG_R_MAN_ID		0xFE
  #define LM83_REG_R_CHIP_ID		0xFF
  #define LM83_REG_R_CONFIG		0x03
  #define LM83_REG_W_CONFIG		0x09
  #define LM83_REG_R_STATUS1		0x02
  #define LM83_REG_R_STATUS2		0x35
  #define LM83_REG_R_LOCAL_TEMP		0x00
  #define LM83_REG_R_LOCAL_HIGH		0x05
  #define LM83_REG_W_LOCAL_HIGH		0x0B
  #define LM83_REG_R_REMOTE1_TEMP		0x30
  #define LM83_REG_R_REMOTE1_HIGH		0x38
  #define LM83_REG_W_REMOTE1_HIGH		0x50
  #define LM83_REG_R_REMOTE2_TEMP		0x01
  #define LM83_REG_R_REMOTE2_HIGH		0x07
  #define LM83_REG_W_REMOTE2_HIGH		0x0D
  #define LM83_REG_R_REMOTE3_TEMP		0x31
  #define LM83_REG_R_REMOTE3_HIGH		0x3A
  #define LM83_REG_W_REMOTE3_HIGH		0x52
  #define LM83_REG_R_TCRIT		0x42
  #define LM83_REG_W_TCRIT		0x5A
  
  /*
   * Conversions and various macros
44bbe87e9   Steven Cole   [PATCH] Spelling ...
82
   * The LM83 uses signed 8-bit values with LSB = 1 degree Celsius.
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
83
84
85
86
87
88
89
90
91
92
93
94
   */
  
  #define TEMP_FROM_REG(val)	((val) * 1000)
  #define TEMP_TO_REG(val)	((val) <= -128000 ? -128 : \
  				 (val) >= 127000 ? 127 : \
  				 (val) < 0 ? ((val) - 500) / 1000 : \
  				 ((val) + 500) / 1000)
  
  static const u8 LM83_REG_R_TEMP[] = {
  	LM83_REG_R_LOCAL_TEMP,
  	LM83_REG_R_REMOTE1_TEMP,
  	LM83_REG_R_REMOTE2_TEMP,
1a86c0512   Jean Delvare   [PATCH] I2C: lm83...
95
  	LM83_REG_R_REMOTE3_TEMP,
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
96
97
98
  	LM83_REG_R_LOCAL_HIGH,
  	LM83_REG_R_REMOTE1_HIGH,
  	LM83_REG_R_REMOTE2_HIGH,
1a86c0512   Jean Delvare   [PATCH] I2C: lm83...
99
100
  	LM83_REG_R_REMOTE3_HIGH,
  	LM83_REG_R_TCRIT,
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
101
102
103
104
105
106
  };
  
  static const u8 LM83_REG_W_HIGH[] = {
  	LM83_REG_W_LOCAL_HIGH,
  	LM83_REG_W_REMOTE1_HIGH,
  	LM83_REG_W_REMOTE2_HIGH,
1a86c0512   Jean Delvare   [PATCH] I2C: lm83...
107
108
  	LM83_REG_W_REMOTE3_HIGH,
  	LM83_REG_W_TCRIT,
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
109
110
111
112
113
  };
  
  /*
   * Functions declaration
   */
310ec7921   Jean Delvare   i2c: Drop the kin...
114
  static int lm83_detect(struct i2c_client *new_client,
b6aacdcef   Jean Delvare   hwmon: (lm83) Con...
115
116
117
118
  		       struct i2c_board_info *info);
  static int lm83_probe(struct i2c_client *client,
  		      const struct i2c_device_id *id);
  static int lm83_remove(struct i2c_client *client);
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
119
120
121
122
123
124
  static struct lm83_data *lm83_update_device(struct device *dev);
  
  /*
   * Driver data (common to all clients)
   */
   
b6aacdcef   Jean Delvare   hwmon: (lm83) Con...
125
126
127
128
129
130
  static const struct i2c_device_id lm83_id[] = {
  	{ "lm83", lm83 },
  	{ "lm82", lm82 },
  	{ }
  };
  MODULE_DEVICE_TABLE(i2c, lm83_id);
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
131
  static struct i2c_driver lm83_driver = {
b6aacdcef   Jean Delvare   hwmon: (lm83) Con...
132
  	.class		= I2C_CLASS_HWMON,
cdaf79349   Laurent Riffard   [PATCH] i2c: Drop...
133
  	.driver = {
cdaf79349   Laurent Riffard   [PATCH] i2c: Drop...
134
135
  		.name	= "lm83",
  	},
b6aacdcef   Jean Delvare   hwmon: (lm83) Con...
136
137
138
139
  	.probe		= lm83_probe,
  	.remove		= lm83_remove,
  	.id_table	= lm83_id,
  	.detect		= lm83_detect,
c3813d6af   Jean Delvare   i2c: Get rid of s...
140
  	.address_list	= normal_i2c,
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
141
142
143
144
145
146
147
  };
  
  /*
   * Client data (each client gets its own)
   */
  
  struct lm83_data {
1beeffe43   Tony Jones   hwmon: Convert fr...
148
  	struct device *hwmon_dev;
9a61bf630   Ingo Molnar   [PATCH] hwmon: Se...
149
  	struct mutex update_lock;
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
150
151
152
153
  	char valid; /* zero until following fields are valid */
  	unsigned long last_updated; /* in jiffies */
  
  	/* registers values */
1a86c0512   Jean Delvare   [PATCH] I2C: lm83...
154
155
156
  	s8 temp[9];	/* 0..3: input 1-4,
  			   4..7: high limit 1-4,
  			   8   : critical limit */
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
157
158
159
160
161
162
  	u16 alarms; /* bitvector, combined */
  };
  
  /*
   * Sysfs stuff
   */
1a86c0512   Jean Delvare   [PATCH] I2C: lm83...
163
164
165
166
167
168
169
  static ssize_t show_temp(struct device *dev, struct device_attribute *devattr,
  			 char *buf)
  {
  	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
  	struct lm83_data *data = lm83_update_device(dev);
  	return sprintf(buf, "%d
  ", TEMP_FROM_REG(data->temp[attr->index]));
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
170
  }
1a86c0512   Jean Delvare   [PATCH] I2C: lm83...
171
172
173
174
175
176
177
178
179
  
  static ssize_t set_temp(struct device *dev, struct device_attribute *devattr,
  			const char *buf, size_t count)
  {
  	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
  	struct i2c_client *client = to_i2c_client(dev);
  	struct lm83_data *data = i2c_get_clientdata(client);
  	long val = simple_strtol(buf, NULL, 10);
  	int nr = attr->index;
9a61bf630   Ingo Molnar   [PATCH] hwmon: Se...
180
  	mutex_lock(&data->update_lock);
1a86c0512   Jean Delvare   [PATCH] I2C: lm83...
181
182
183
  	data->temp[nr] = TEMP_TO_REG(val);
  	i2c_smbus_write_byte_data(client, LM83_REG_W_HIGH[nr - 4],
  				  data->temp[nr]);
9a61bf630   Ingo Molnar   [PATCH] hwmon: Se...
184
  	mutex_unlock(&data->update_lock);
1a86c0512   Jean Delvare   [PATCH] I2C: lm83...
185
  	return count;
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
186
  }
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
187

1a86c0512   Jean Delvare   [PATCH] I2C: lm83...
188
189
  static ssize_t show_alarms(struct device *dev, struct device_attribute *dummy,
  			   char *buf)
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
190
191
192
193
194
  {
  	struct lm83_data *data = lm83_update_device(dev);
  	return sprintf(buf, "%d
  ", data->alarms);
  }
2d45771e6   Jean Delvare   hwmon: Add indivi...
195
196
197
198
199
200
201
202
203
204
  static ssize_t show_alarm(struct device *dev, struct device_attribute
  			  *devattr, char *buf)
  {
  	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
  	struct lm83_data *data = lm83_update_device(dev);
  	int bitnr = attr->index;
  
  	return sprintf(buf, "%d
  ", (data->alarms >> bitnr) & 1);
  }
1a86c0512   Jean Delvare   [PATCH] I2C: lm83...
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
  static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, show_temp, NULL, 0);
  static SENSOR_DEVICE_ATTR(temp2_input, S_IRUGO, show_temp, NULL, 1);
  static SENSOR_DEVICE_ATTR(temp3_input, S_IRUGO, show_temp, NULL, 2);
  static SENSOR_DEVICE_ATTR(temp4_input, S_IRUGO, show_temp, NULL, 3);
  static SENSOR_DEVICE_ATTR(temp1_max, S_IWUSR | S_IRUGO, show_temp,
  	set_temp, 4);
  static SENSOR_DEVICE_ATTR(temp2_max, S_IWUSR | S_IRUGO, show_temp,
  	set_temp, 5);
  static SENSOR_DEVICE_ATTR(temp3_max, S_IWUSR | S_IRUGO, show_temp,
  	set_temp, 6);
  static SENSOR_DEVICE_ATTR(temp4_max, S_IWUSR | S_IRUGO, show_temp,
  	set_temp, 7);
  static SENSOR_DEVICE_ATTR(temp1_crit, S_IRUGO, show_temp, NULL, 8);
  static SENSOR_DEVICE_ATTR(temp2_crit, S_IRUGO, show_temp, NULL, 8);
  static SENSOR_DEVICE_ATTR(temp3_crit, S_IWUSR | S_IRUGO, show_temp,
  	set_temp, 8);
  static SENSOR_DEVICE_ATTR(temp4_crit, S_IRUGO, show_temp, NULL, 8);
2d45771e6   Jean Delvare   hwmon: Add indivi...
222
223
224
225
  
  /* Individual alarm files */
  static SENSOR_DEVICE_ATTR(temp1_crit_alarm, S_IRUGO, show_alarm, NULL, 0);
  static SENSOR_DEVICE_ATTR(temp3_crit_alarm, S_IRUGO, show_alarm, NULL, 1);
7817a39e6   Jean Delvare   hwmon: Fault file...
226
  static SENSOR_DEVICE_ATTR(temp3_fault, S_IRUGO, show_alarm, NULL, 2);
2d45771e6   Jean Delvare   hwmon: Add indivi...
227
228
229
230
  static SENSOR_DEVICE_ATTR(temp3_max_alarm, S_IRUGO, show_alarm, NULL, 4);
  static SENSOR_DEVICE_ATTR(temp1_max_alarm, S_IRUGO, show_alarm, NULL, 6);
  static SENSOR_DEVICE_ATTR(temp2_crit_alarm, S_IRUGO, show_alarm, NULL, 8);
  static SENSOR_DEVICE_ATTR(temp4_crit_alarm, S_IRUGO, show_alarm, NULL, 9);
7817a39e6   Jean Delvare   hwmon: Fault file...
231
  static SENSOR_DEVICE_ATTR(temp4_fault, S_IRUGO, show_alarm, NULL, 10);
2d45771e6   Jean Delvare   hwmon: Add indivi...
232
  static SENSOR_DEVICE_ATTR(temp4_max_alarm, S_IRUGO, show_alarm, NULL, 12);
7817a39e6   Jean Delvare   hwmon: Fault file...
233
  static SENSOR_DEVICE_ATTR(temp2_fault, S_IRUGO, show_alarm, NULL, 13);
2d45771e6   Jean Delvare   hwmon: Add indivi...
234
235
  static SENSOR_DEVICE_ATTR(temp2_max_alarm, S_IRUGO, show_alarm, NULL, 15);
  /* Raw alarm file for compatibility */
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
236
  static DEVICE_ATTR(alarms, S_IRUGO, show_alarms, NULL);
0e39e01c9   Jean Delvare   hwmon: Fix unchec...
237
238
239
240
241
242
243
244
245
246
  static struct attribute *lm83_attributes[] = {
  	&sensor_dev_attr_temp1_input.dev_attr.attr,
  	&sensor_dev_attr_temp3_input.dev_attr.attr,
  	&sensor_dev_attr_temp1_max.dev_attr.attr,
  	&sensor_dev_attr_temp3_max.dev_attr.attr,
  	&sensor_dev_attr_temp1_crit.dev_attr.attr,
  	&sensor_dev_attr_temp3_crit.dev_attr.attr,
  
  	&sensor_dev_attr_temp1_crit_alarm.dev_attr.attr,
  	&sensor_dev_attr_temp3_crit_alarm.dev_attr.attr,
7817a39e6   Jean Delvare   hwmon: Fault file...
247
  	&sensor_dev_attr_temp3_fault.dev_attr.attr,
0e39e01c9   Jean Delvare   hwmon: Fix unchec...
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
  	&sensor_dev_attr_temp3_max_alarm.dev_attr.attr,
  	&sensor_dev_attr_temp1_max_alarm.dev_attr.attr,
  	&dev_attr_alarms.attr,
  	NULL
  };
  
  static const struct attribute_group lm83_group = {
  	.attrs = lm83_attributes,
  };
  
  static struct attribute *lm83_attributes_opt[] = {
  	&sensor_dev_attr_temp2_input.dev_attr.attr,
  	&sensor_dev_attr_temp4_input.dev_attr.attr,
  	&sensor_dev_attr_temp2_max.dev_attr.attr,
  	&sensor_dev_attr_temp4_max.dev_attr.attr,
  	&sensor_dev_attr_temp2_crit.dev_attr.attr,
  	&sensor_dev_attr_temp4_crit.dev_attr.attr,
  
  	&sensor_dev_attr_temp2_crit_alarm.dev_attr.attr,
  	&sensor_dev_attr_temp4_crit_alarm.dev_attr.attr,
7817a39e6   Jean Delvare   hwmon: Fault file...
268
  	&sensor_dev_attr_temp4_fault.dev_attr.attr,
0e39e01c9   Jean Delvare   hwmon: Fix unchec...
269
  	&sensor_dev_attr_temp4_max_alarm.dev_attr.attr,
7817a39e6   Jean Delvare   hwmon: Fault file...
270
  	&sensor_dev_attr_temp2_fault.dev_attr.attr,
0e39e01c9   Jean Delvare   hwmon: Fix unchec...
271
272
273
274
275
276
277
  	&sensor_dev_attr_temp2_max_alarm.dev_attr.attr,
  	NULL
  };
  
  static const struct attribute_group lm83_group_opt = {
  	.attrs = lm83_attributes_opt,
  };
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
278
279
280
  /*
   * Real code
   */
b6aacdcef   Jean Delvare   hwmon: (lm83) Con...
281
  /* Return 0 if detection is successful, -ENODEV otherwise */
310ec7921   Jean Delvare   i2c: Drop the kin...
282
  static int lm83_detect(struct i2c_client *new_client,
b6aacdcef   Jean Delvare   hwmon: (lm83) Con...
283
  		       struct i2c_board_info *info)
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
284
  {
b6aacdcef   Jean Delvare   hwmon: (lm83) Con...
285
  	struct i2c_adapter *adapter = new_client->adapter;
b57dc3940   Jean Delvare   hwmon: (lm83) Cle...
286
287
  	const char *name;
  	u8 man_id, chip_id;
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
288
289
  
  	if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
b6aacdcef   Jean Delvare   hwmon: (lm83) Con...
290
  		return -ENODEV;
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
291

b57dc3940   Jean Delvare   hwmon: (lm83) Cle...
292
293
294
295
296
297
298
299
  	/* Detection */
  	if ((i2c_smbus_read_byte_data(new_client, LM83_REG_R_STATUS1) & 0xA8) ||
  	    (i2c_smbus_read_byte_data(new_client, LM83_REG_R_STATUS2) & 0x48) ||
  	    (i2c_smbus_read_byte_data(new_client, LM83_REG_R_CONFIG) & 0x41)) {
  		dev_dbg(&adapter->dev, "LM83 detection failed at 0x%02x
  ",
  			new_client->addr);
  		return -ENODEV;
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
300
  	}
b57dc3940   Jean Delvare   hwmon: (lm83) Cle...
301
302
303
304
  	/* Identification */
  	man_id = i2c_smbus_read_byte_data(new_client, LM83_REG_R_MAN_ID);
  	if (man_id != 0x01)	/* National Semiconductor */
  		return -ENODEV;
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
305

b57dc3940   Jean Delvare   hwmon: (lm83) Cle...
306
307
308
  	chip_id = i2c_smbus_read_byte_data(new_client, LM83_REG_R_CHIP_ID);
  	switch (chip_id) {
  	case 0x03:
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
309
  		name = "lm83";
b57dc3940   Jean Delvare   hwmon: (lm83) Cle...
310
311
  		break;
  	case 0x01:
43cb7ebee   Jordan Crouse   [PATCH] lm83: Add...
312
  		name = "lm82";
b57dc3940   Jean Delvare   hwmon: (lm83) Cle...
313
314
315
316
317
318
319
320
  		break;
  	default:
  		/* identification failed */
  		dev_info(&adapter->dev,
  			 "Unsupported chip (man_id=0x%02X, chip_id=0x%02X)
  ",
  			 man_id, chip_id);
  		return -ENODEV;
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
321
  	}
b6aacdcef   Jean Delvare   hwmon: (lm83) Con...
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
  	strlcpy(info->type, name, I2C_NAME_SIZE);
  
  	return 0;
  }
  
  static int lm83_probe(struct i2c_client *new_client,
  		      const struct i2c_device_id *id)
  {
  	struct lm83_data *data;
  	int err;
  
  	data = kzalloc(sizeof(struct lm83_data), GFP_KERNEL);
  	if (!data) {
  		err = -ENOMEM;
  		goto exit;
  	}
  
  	i2c_set_clientdata(new_client, data);
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
340
  	data->valid = 0;
9a61bf630   Ingo Molnar   [PATCH] hwmon: Se...
341
  	mutex_init(&data->update_lock);
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
342

1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
343
  	/*
0e39e01c9   Jean Delvare   hwmon: Fix unchec...
344
  	 * Register sysfs hooks
43cb7ebee   Jordan Crouse   [PATCH] lm83: Add...
345
346
347
348
  	 * The LM82 can only monitor one external diode which is
  	 * at the same register as the LM83 temp3 entry - so we
  	 * declare 1 and 3 common, and then 2 and 4 only for the LM83.
  	 */
0e39e01c9   Jean Delvare   hwmon: Fix unchec...
349
  	if ((err = sysfs_create_group(&new_client->dev.kobj, &lm83_group)))
b6aacdcef   Jean Delvare   hwmon: (lm83) Con...
350
  		goto exit_free;
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
351

b6aacdcef   Jean Delvare   hwmon: (lm83) Con...
352
  	if (id->driver_data == lm83) {
0e39e01c9   Jean Delvare   hwmon: Fix unchec...
353
354
355
356
  		if ((err = sysfs_create_group(&new_client->dev.kobj,
  					      &lm83_group_opt)))
  			goto exit_remove_files;
  	}
1beeffe43   Tony Jones   hwmon: Convert fr...
357
358
359
  	data->hwmon_dev = hwmon_device_register(&new_client->dev);
  	if (IS_ERR(data->hwmon_dev)) {
  		err = PTR_ERR(data->hwmon_dev);
0e39e01c9   Jean Delvare   hwmon: Fix unchec...
360
  		goto exit_remove_files;
43cb7ebee   Jordan Crouse   [PATCH] lm83: Add...
361
  	}
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
362
  	return 0;
0e39e01c9   Jean Delvare   hwmon: Fix unchec...
363
364
365
  exit_remove_files:
  	sysfs_remove_group(&new_client->dev.kobj, &lm83_group);
  	sysfs_remove_group(&new_client->dev.kobj, &lm83_group_opt);
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
366
367
368
369
370
  exit_free:
  	kfree(data);
  exit:
  	return err;
  }
b6aacdcef   Jean Delvare   hwmon: (lm83) Con...
371
  static int lm83_remove(struct i2c_client *client)
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
372
  {
943b0830c   Mark M. Hoffman   [PATCH] I2C hwmon...
373
  	struct lm83_data *data = i2c_get_clientdata(client);
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
374

1beeffe43   Tony Jones   hwmon: Convert fr...
375
  	hwmon_device_unregister(data->hwmon_dev);
0e39e01c9   Jean Delvare   hwmon: Fix unchec...
376
377
  	sysfs_remove_group(&client->dev.kobj, &lm83_group);
  	sysfs_remove_group(&client->dev.kobj, &lm83_group_opt);
943b0830c   Mark M. Hoffman   [PATCH] I2C hwmon...
378

943b0830c   Mark M. Hoffman   [PATCH] I2C hwmon...
379
  	kfree(data);
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
380
381
382
383
384
385
386
  	return 0;
  }
  
  static struct lm83_data *lm83_update_device(struct device *dev)
  {
  	struct i2c_client *client = to_i2c_client(dev);
  	struct lm83_data *data = i2c_get_clientdata(client);
9a61bf630   Ingo Molnar   [PATCH] hwmon: Se...
387
  	mutex_lock(&data->update_lock);
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
388
389
390
391
392
393
  
  	if (time_after(jiffies, data->last_updated + HZ * 2) || !data->valid) {
  		int nr;
  
  		dev_dbg(&client->dev, "Updating lm83 data.
  ");
1a86c0512   Jean Delvare   [PATCH] I2C: lm83...
394
395
  		for (nr = 0; nr < 9; nr++) {
  			data->temp[nr] =
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
396
397
  			    i2c_smbus_read_byte_data(client,
  			    LM83_REG_R_TEMP[nr]);
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
398
  		}
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
399
400
401
402
403
404
405
406
  		data->alarms =
  		    i2c_smbus_read_byte_data(client, LM83_REG_R_STATUS1)
  		    + (i2c_smbus_read_byte_data(client, LM83_REG_R_STATUS2)
  		    << 8);
  
  		data->last_updated = jiffies;
  		data->valid = 1;
  	}
9a61bf630   Ingo Molnar   [PATCH] hwmon: Se...
407
  	mutex_unlock(&data->update_lock);
1da177e4c   Linus Torvalds   Linux-2.6.12-rc2
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
  
  	return data;
  }
  
  static int __init sensors_lm83_init(void)
  {
  	return i2c_add_driver(&lm83_driver);
  }
  
  static void __exit sensors_lm83_exit(void)
  {
  	i2c_del_driver(&lm83_driver);
  }
  
  MODULE_AUTHOR("Jean Delvare <khali@linux-fr.org>");
  MODULE_DESCRIPTION("LM83 driver");
  MODULE_LICENSE("GPL");
  
  module_init(sensors_lm83_init);
  module_exit(sensors_lm83_exit);