Blame view

scripts/checkpatch.pl 182 KB
0a920b5b6   Andy Whitcroft   add a trivial pat...
1
  #!/usr/bin/perl -w
dbf004d78   Dave Jones   remove my email a...
2
  # (c) 2001, Dave Jones. (the file handling bit)
00df344fd   Andy Whitcroft   update checkpatch...
3
  # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
2a5a2c252   Andy Whitcroft   checkpatch: updat...
4
  # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite)
015830be9   Andy Whitcroft   checkpatch: updat...
5
  # (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
0a920b5b6   Andy Whitcroft   add a trivial pat...
6
7
8
  # Licensed under the terms of the GNU GPL License version 2
  
  use strict;
c707a81de   Joe Perches   checkpatch: make ...
9
  use POSIX;
36061e380   Joe Perches   checkpatch: fix u...
10
11
  use File::Basename;
  use Cwd 'abs_path';
572302971   Joe Perches   checkpatch: color...
12
  use Term::ANSIColor qw(:constants);
0a920b5b6   Andy Whitcroft   add a trivial pat...
13
14
  
  my $P = $0;
36061e380   Joe Perches   checkpatch: fix u...
15
  my $D = dirname(abs_path($P));
0a920b5b6   Andy Whitcroft   add a trivial pat...
16

000d1cc18   Joe Perches   checkpatch.pl: ad...
17
  my $V = '0.32';
0a920b5b6   Andy Whitcroft   add a trivial pat...
18
19
20
21
22
23
24
  
  use Getopt::Long qw(:config no_auto_abbrev);
  
  my $quiet = 0;
  my $tree = 1;
  my $chk_signoff = 1;
  my $chk_patch = 1;
773647a09   Andy Whitcroft   update checkpatch...
25
  my $tst_only;
6c72ffaab   Andy Whitcroft   update checkpatch...
26
  my $emacs = 0;
8905a67c6   Andy Whitcroft   update checkpatch...
27
  my $terse = 0;
34d8815f9   Joe Perches   checkpatch: add -...
28
  my $showfile = 0;
6c72ffaab   Andy Whitcroft   update checkpatch...
29
  my $file = 0;
4a593c344   Du, Changbin   checkpatch: add s...
30
  my $git = 0;
0dea9f1ee   Joe Perches   checkpatch: reduc...
31
  my %git_commits = ();
6c72ffaab   Andy Whitcroft   update checkpatch...
32
  my $check = 0;
2ac73b4f6   Joe Perches   checkpatch: make ...
33
  my $check_orig = 0;
8905a67c6   Andy Whitcroft   update checkpatch...
34
35
  my $summary = 1;
  my $mailback = 0;
13214adf7   Andy Whitcroft   update checkpatch...
36
  my $summary_file = 0;
000d1cc18   Joe Perches   checkpatch.pl: ad...
37
  my $show_types = 0;
3beb42ece   Joe Perches   checkpatch: add -...
38
  my $list_types = 0;
3705ce5bc   Joe Perches   checkpatch: creat...
39
  my $fix = 0;
9624b8d65   Joe Perches   checkpatch: add a...
40
  my $fix_inplace = 0;
6c72ffaab   Andy Whitcroft   update checkpatch...
41
  my $root;
c2fdda0df   Andy Whitcroft   update checkpatch...
42
  my %debug;
3445686af   Joe Perches   checkpatch: ignor...
43
  my %camelcase = ();
91bfe4843   Joe Perches   checkpatch: add -...
44
45
46
  my %use_type = ();
  my @use = ();
  my %ignore_type = ();
000d1cc18   Joe Perches   checkpatch.pl: ad...
47
  my @ignore = ();
77f5b10a8   Hannes Eder   checkpatch: make ...
48
  my $help = 0;
000d1cc18   Joe Perches   checkpatch.pl: ad...
49
  my $configuration_file = ".checkpatch.conf";
6cd7f3869   Joe Perches   checkpatch: allow...
50
  my $max_line_length = 80;
d62a201f2   Dave Hansen   checkpatch: enfor...
51
52
  my $ignore_perl_version = 0;
  my $minimum_perl_version = 5.10.0;
56193274e   Vadim Bendebury   checkpatch: allow...
53
  my $min_conf_desc_length = 4;
66b47b4a9   Kees Cook   checkpatch: look ...
54
  my $spelling_file = "$D/spelling.txt";
ebfd7d623   Joe Perches   checkpatch: add o...
55
  my $codespell = 0;
f1a636785   Maxim Uvarov   checkpatch: remov...
56
  my $codespellfile = "/usr/share/codespell/dictionary.txt";
bf1fa1dae   Joe Perches   checkpatch: exter...
57
  my $conststructsfile = "$D/const_structs.checkpatch";
572302971   Joe Perches   checkpatch: color...
58
  my $color = 1;
dadf680de   Joe Perches   checkpatch: allow...
59
  my $allow_c99_comments = 1;
77f5b10a8   Hannes Eder   checkpatch: make ...
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
  
  sub help {
  	my ($exitcode) = @_;
  
  	print << "EOM";
  Usage: $P [OPTION]... [FILE]...
  Version: $V
  
  Options:
    -q, --quiet                quiet
    --no-tree                  run without a kernel tree
    --no-signoff               do not check for 'Signed-off-by' line
    --patch                    treat FILE as patchfile (default)
    --emacs                    emacs compile window format
    --terse                    one line per report
34d8815f9   Joe Perches   checkpatch: add -...
75
    --showfile                 emit diffed file position, not input file position
4a593c344   Du, Changbin   checkpatch: add s...
76
77
78
79
80
81
82
83
84
85
    -g, --git                  treat FILE as a single commit or git revision range
                               single git commit with:
                                 <rev>
                                 <rev>^
                                 <rev>~n
                               multiple git commits with:
                                 <rev1>..<rev2>
                                 <rev1>...<rev2>
                                 <rev>-<count>
                               git merges are ignored
77f5b10a8   Hannes Eder   checkpatch: make ...
86
87
    -f, --file                 treat FILE as regular source file
    --subjective, --strict     enable more subjective tests
3beb42ece   Joe Perches   checkpatch: add -...
88
    --list-types               list the possible message types
91bfe4843   Joe Perches   checkpatch: add -...
89
    --types TYPE(,TYPE2...)    show only these comma separated message types
000d1cc18   Joe Perches   checkpatch.pl: ad...
90
    --ignore TYPE(,TYPE2...)   ignore various comma separated message types
3beb42ece   Joe Perches   checkpatch: add -...
91
    --show-types               show the specific message type in the output
6cd7f3869   Joe Perches   checkpatch: allow...
92
    --max-line-length=n        set the maximum line length, if exceeded, warn
56193274e   Vadim Bendebury   checkpatch: allow...
93
    --min-conf-desc-length=n   set the min description length, if shorter, warn
77f5b10a8   Hannes Eder   checkpatch: make ...
94
95
96
97
98
99
100
101
102
    --root=PATH                PATH to the kernel tree root
    --no-summary               suppress the per-file summary
    --mailback                 only produce a report in case of warnings/errors
    --summary-file             include the filename in summary
    --debug KEY=[0|1]          turn on/off debugging of KEY, where KEY is one of
                               'values', 'possible', 'type', and 'attr' (default
                               is all off)
    --test-only=WORD           report only warnings/errors containing WORD
                               literally
3705ce5bc   Joe Perches   checkpatch: creat...
103
104
105
106
107
    --fix                      EXPERIMENTAL - may create horrible results
                               If correctable single-line errors exist, create
                               "<inputfile>.EXPERIMENTAL-checkpatch-fixes"
                               with potential errors corrected to the preferred
                               checkpatch style
9624b8d65   Joe Perches   checkpatch: add a...
108
109
110
    --fix-inplace              EXPERIMENTAL - may create horrible results
                               Is the same as --fix, but overwrites the input
                               file.  It's your fault if there's no backup or git
d62a201f2   Dave Hansen   checkpatch: enfor...
111
112
    --ignore-perl-version      override checking of perl version.  expect
                               runtime errors.
ebfd7d623   Joe Perches   checkpatch: add o...
113
    --codespell                Use the codespell dictionary for spelling/typos
f1a636785   Maxim Uvarov   checkpatch: remov...
114
                               (default:/usr/share/codespell/dictionary.txt)
ebfd7d623   Joe Perches   checkpatch: add o...
115
    --codespellfile            Use this codespell dictionary
572302971   Joe Perches   checkpatch: color...
116
    --color                    Use colors when output is STDOUT (default: on)
77f5b10a8   Hannes Eder   checkpatch: make ...
117
118
119
120
121
122
123
    -h, --help, --version      display this help and exit
  
  When FILE is - read standard input.
  EOM
  
  	exit($exitcode);
  }
3beb42ece   Joe Perches   checkpatch: add -...
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
  sub uniq {
  	my %seen;
  	return grep { !$seen{$_}++ } @_;
  }
  
  sub list_types {
  	my ($exitcode) = @_;
  
  	my $count = 0;
  
  	local $/ = undef;
  
  	open(my $script, '<', abs_path($P)) or
  	    die "$P: Can't read '$P' $!
  ";
  
  	my $text = <$script>;
  	close($script);
  
  	my @types = ();
  	for ($text =~ /\b(?:(?:CHK|WARN|ERROR)\s*\(\s*"([^"]+)")/g) {
  		push (@types, $_);
  	}
  	@types = sort(uniq(@types));
  	print("#\tMessage type
  
  ");
  	foreach my $type (@types) {
  		print(++$count . "\t" . $type . "
  ");
  	}
  
  	exit($exitcode);
  }
000d1cc18   Joe Perches   checkpatch.pl: ad...
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
  my $conf = which_conf($configuration_file);
  if (-f $conf) {
  	my @conf_args;
  	open(my $conffile, '<', "$conf")
  	    or warn "$P: Can't find a readable $configuration_file file $!
  ";
  
  	while (<$conffile>) {
  		my $line = $_;
  
  		$line =~ s/\s*
  ?$//g;
  		$line =~ s/^\s*//g;
  		$line =~ s/\s+/ /g;
  
  		next if ($line =~ m/^\s*#/);
  		next if ($line =~ m/^\s*$/);
  
  		my @words = split(" ", $line);
  		foreach my $word (@words) {
  			last if ($word =~ m/^#/);
  			push (@conf_args, $word);
  		}
  	}
  	close($conffile);
  	unshift(@ARGV, @conf_args) if @conf_args;
  }
0a920b5b6   Andy Whitcroft   add a trivial pat...
185
  GetOptions(
6c72ffaab   Andy Whitcroft   update checkpatch...
186
  	'q|quiet+'	=> \$quiet,
0a920b5b6   Andy Whitcroft   add a trivial pat...
187
188
189
  	'tree!'		=> \$tree,
  	'signoff!'	=> \$chk_signoff,
  	'patch!'	=> \$chk_patch,
6c72ffaab   Andy Whitcroft   update checkpatch...
190
  	'emacs!'	=> \$emacs,
8905a67c6   Andy Whitcroft   update checkpatch...
191
  	'terse!'	=> \$terse,
34d8815f9   Joe Perches   checkpatch: add -...
192
  	'showfile!'	=> \$showfile,
77f5b10a8   Hannes Eder   checkpatch: make ...
193
  	'f|file!'	=> \$file,
4a593c344   Du, Changbin   checkpatch: add s...
194
  	'g|git!'	=> \$git,
6c72ffaab   Andy Whitcroft   update checkpatch...
195
196
  	'subjective!'	=> \$check,
  	'strict!'	=> \$check,
000d1cc18   Joe Perches   checkpatch.pl: ad...
197
  	'ignore=s'	=> \@ignore,
91bfe4843   Joe Perches   checkpatch: add -...
198
  	'types=s'	=> \@use,
000d1cc18   Joe Perches   checkpatch.pl: ad...
199
  	'show-types!'	=> \$show_types,
3beb42ece   Joe Perches   checkpatch: add -...
200
  	'list-types!'	=> \$list_types,
6cd7f3869   Joe Perches   checkpatch: allow...
201
  	'max-line-length=i' => \$max_line_length,
56193274e   Vadim Bendebury   checkpatch: allow...
202
  	'min-conf-desc-length=i' => \$min_conf_desc_length,
6c72ffaab   Andy Whitcroft   update checkpatch...
203
  	'root=s'	=> \$root,
8905a67c6   Andy Whitcroft   update checkpatch...
204
205
  	'summary!'	=> \$summary,
  	'mailback!'	=> \$mailback,
13214adf7   Andy Whitcroft   update checkpatch...
206
  	'summary-file!'	=> \$summary_file,
3705ce5bc   Joe Perches   checkpatch: creat...
207
  	'fix!'		=> \$fix,
9624b8d65   Joe Perches   checkpatch: add a...
208
  	'fix-inplace!'	=> \$fix_inplace,
d62a201f2   Dave Hansen   checkpatch: enfor...
209
  	'ignore-perl-version!' => \$ignore_perl_version,
c2fdda0df   Andy Whitcroft   update checkpatch...
210
  	'debug=s'	=> \%debug,
773647a09   Andy Whitcroft   update checkpatch...
211
  	'test-only=s'	=> \$tst_only,
ebfd7d623   Joe Perches   checkpatch: add o...
212
213
  	'codespell!'	=> \$codespell,
  	'codespellfile=s'	=> \$codespellfile,
572302971   Joe Perches   checkpatch: color...
214
  	'color!'	=> \$color,
77f5b10a8   Hannes Eder   checkpatch: make ...
215
216
217
218
219
  	'h|help'	=> \$help,
  	'version'	=> \$help
  ) or help(1);
  
  help(0) if ($help);
0a920b5b6   Andy Whitcroft   add a trivial pat...
220

3beb42ece   Joe Perches   checkpatch: add -...
221
  list_types(0) if ($list_types);
9624b8d65   Joe Perches   checkpatch: add a...
222
  $fix = 1 if ($fix_inplace);
2ac73b4f6   Joe Perches   checkpatch: make ...
223
  $check_orig = $check;
9624b8d65   Joe Perches   checkpatch: add a...
224

0a920b5b6   Andy Whitcroft   add a trivial pat...
225
  my $exit = 0;
d62a201f2   Dave Hansen   checkpatch: enfor...
226
227
228
229
230
231
232
  if ($^V && $^V lt $minimum_perl_version) {
  	printf "$P: requires at least perl version %vd
  ", $minimum_perl_version;
  	if (!$ignore_perl_version) {
  		exit(1);
  	}
  }
45107ff6d   Allen Hubbe   checkpatch: if no...
233
  #if no filenames are given, push '-' to read patch from stdin
0a920b5b6   Andy Whitcroft   add a trivial pat...
234
  if ($#ARGV < 0) {
45107ff6d   Allen Hubbe   checkpatch: if no...
235
  	push(@ARGV, '-');
0a920b5b6   Andy Whitcroft   add a trivial pat...
236
  }
91bfe4843   Joe Perches   checkpatch: add -...
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
  sub hash_save_array_words {
  	my ($hashRef, $arrayRef) = @_;
  
  	my @array = split(/,/, join(',', @$arrayRef));
  	foreach my $word (@array) {
  		$word =~ s/\s*
  ?$//g;
  		$word =~ s/^\s*//g;
  		$word =~ s/\s+/ /g;
  		$word =~ tr/[a-z]/[A-Z]/;
  
  		next if ($word =~ m/^\s*#/);
  		next if ($word =~ m/^\s*$/);
  
  		$hashRef->{$word}++;
  	}
  }
000d1cc18   Joe Perches   checkpatch.pl: ad...
254

91bfe4843   Joe Perches   checkpatch: add -...
255
256
  sub hash_show_words {
  	my ($hashRef, $prefix) = @_;
000d1cc18   Joe Perches   checkpatch.pl: ad...
257

3c816e490   Joe Perches   checkpatch: emit ...
258
  	if (keys %$hashRef) {
d8469f162   Joe Perches   checkpatch: impro...
259
260
  		print "
  NOTE: $prefix message types:";
58cb3cf66   Joe Perches   checkpatch: fix p...
261
  		foreach my $word (sort keys %$hashRef) {
91bfe4843   Joe Perches   checkpatch: add -...
262
263
  			print " $word";
  		}
d8469f162   Joe Perches   checkpatch: impro...
264
265
  		print "
  ";
91bfe4843   Joe Perches   checkpatch: add -...
266
  	}
000d1cc18   Joe Perches   checkpatch.pl: ad...
267
  }
91bfe4843   Joe Perches   checkpatch: add -...
268
269
  hash_save_array_words(\%ignore_type, \@ignore);
  hash_save_array_words(\%use_type, \@use);
c2fdda0df   Andy Whitcroft   update checkpatch...
270
271
  my $dbg_values = 0;
  my $dbg_possible = 0;
7429c6903   Andy Whitcroft   checkpatch: impro...
272
  my $dbg_type = 0;
a1ef277e2   Andy Whitcroft   checkpatch: add t...
273
  my $dbg_attr = 0;
c2fdda0df   Andy Whitcroft   update checkpatch...
274
  for my $key (keys %debug) {
21caa13c0   Andy Whitcroft   checkpatch: fix t...
275
276
277
  	## no critic
  	eval "\${dbg_$key} = '$debug{$key}';";
  	die "$@" if ($@);
c2fdda0df   Andy Whitcroft   update checkpatch...
278
  }
d2c0a2351   Andy Whitcroft   checkpatch: sugge...
279
  my $rpt_cleaners = 0;
8905a67c6   Andy Whitcroft   update checkpatch...
280
281
282
283
  if ($terse) {
  	$emacs = 1;
  	$quiet++;
  }
6c72ffaab   Andy Whitcroft   update checkpatch...
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
  if ($tree) {
  	if (defined $root) {
  		if (!top_of_kernel_tree($root)) {
  			die "$P: $root: --root does not point at a valid tree
  ";
  		}
  	} else {
  		if (top_of_kernel_tree('.')) {
  			$root = '.';
  		} elsif ($0 =~ m@(.*)/scripts/[^/]*$@ &&
  						top_of_kernel_tree($1)) {
  			$root = $1;
  		}
  	}
  
  	if (!defined $root) {
  		print "Must be run from the top-level dir. of a kernel tree
  ";
  		exit(2);
  	}
0a920b5b6   Andy Whitcroft   add a trivial pat...
304
  }
6c72ffaab   Andy Whitcroft   update checkpatch...
305
  my $emitted_corrupt = 0;
2ceb532b0   Andy Whitcroft   checkpatch: fix f...
306
307
308
309
  our $Ident	= qr{
  			[A-Za-z_][A-Za-z\d_]*
  			(?:\s*\#\#\s*[A-Za-z_][A-Za-z\d_]*)*
  		}x;
6c72ffaab   Andy Whitcroft   update checkpatch...
310
311
312
313
314
315
316
317
  our $Storage	= qr{extern|static|asmlinkage};
  our $Sparse	= qr{
  			__user|
  			__kernel|
  			__force|
  			__iomem|
  			__must_check|
  			__init_refok|
417495eda   Andy Whitcroft   checkpatch: add _...
318
  			__kprobes|
165e72a6c   Sven Eckelmann   checkpatch: add _...
319
  			__ref|
ad315455d   Boqun Feng   sparse: Add __pri...
320
321
  			__rcu|
  			__private
6c72ffaab   Andy Whitcroft   update checkpatch...
322
  		}x;
e970b8846   Joe Perches   checkpatch: add r...
323
324
325
326
327
  our $InitAttributePrefix = qr{__(?:mem|cpu|dev|net_|)};
  our $InitAttributeData = qr{$InitAttributePrefix(?:initdata\b)};
  our $InitAttributeConst = qr{$InitAttributePrefix(?:initconst\b)};
  our $InitAttributeInit = qr{$InitAttributePrefix(?:init\b)};
  our $InitAttribute = qr{$InitAttributeData|$InitAttributeConst|$InitAttributeInit};
8716de383   Joe Perches   checkpatch: add t...
328

52131292c   Wolfram Sang   checkpatch: fix f...
329
330
  # Notes to $Attribute:
  # We need \b after 'init' otherwise 'initconst' will cause a false positive in a check
6c72ffaab   Andy Whitcroft   update checkpatch...
331
332
  our $Attribute	= qr{
  			const|
03f1df7da   Joe Perches   checkpatch: Add a...
333
334
335
336
337
338
339
340
341
342
343
344
  			__percpu|
  			__nocast|
  			__safe|
  			__bitwise__|
  			__packed__|
  			__packed2__|
  			__naked|
  			__maybe_unused|
  			__always_unused|
  			__noreturn|
  			__used|
  			__cold|
e23ef1f33   Joe Perches   checkpatch: ignor...
345
  			__pure|
03f1df7da   Joe Perches   checkpatch: Add a...
346
347
  			__noclone|
  			__deprecated|
6c72ffaab   Andy Whitcroft   update checkpatch...
348
349
  			__read_mostly|
  			__kprobes|
8716de383   Joe Perches   checkpatch: add t...
350
  			$InitAttribute|
24e1d81ac   Andy Whitcroft   checkpatch: ____c...
351
352
  			____cacheline_aligned|
  			____cacheline_aligned_in_smp|
5fe3af119   Andy Whitcroft   checkpatch: __wea...
353
354
  			____cacheline_internodealigned_in_smp|
  			__weak
6c72ffaab   Andy Whitcroft   update checkpatch...
355
  		  }x;
c45dcabd2   Andy Whitcroft   update checkpatch...
356
  our $Modifier;
91cb5195f   Joe Perches   checkpatch: expan...
357
  our $Inline	= qr{inline|__always_inline|noinline|__inline|__inline__};
6c72ffaab   Andy Whitcroft   update checkpatch...
358
359
  our $Member	= qr{->$Ident|\.$Ident|\[[^]]*\]};
  our $Lval	= qr{$Ident(?:$Member)*};
95e2c6023   Joe Perches   checkpatch: warn ...
360
361
362
363
  our $Int_type	= qr{(?i)llu|ull|ll|lu|ul|l|u};
  our $Binary	= qr{(?i)0b[01]+$Int_type?};
  our $Hex	= qr{(?i)0x[0-9a-f]+$Int_type?};
  our $Int	= qr{[0-9]+$Int_type?};
2435880fe   Joe Perches   checkpatch: add c...
364
  our $Octal	= qr{0[0-7]+$Int_type?};
c0a5c8985   Joe Perches   checkpatch: impro...
365
  our $String	= qr{"[X\t]*"};
326b1ffc1   Joe Perches   checkpatch: fix $...
366
367
368
  our $Float_hex	= qr{(?i)0x[0-9a-f]+p-?[0-9]+[fl]?};
  our $Float_dec	= qr{(?i)(?:[0-9]+\.[0-9]*|[0-9]*\.[0-9]+)(?:e-?[0-9]+)?[fl]?};
  our $Float_int	= qr{(?i)[0-9]+e-?[0-9]+[fl]?};
74349bcce   Joe Perches   checkpatch: add s...
369
  our $Float	= qr{$Float_hex|$Float_dec|$Float_int};
2435880fe   Joe Perches   checkpatch: add c...
370
  our $Constant	= qr{$Float|$Binary|$Octal|$Hex|$Int};
326b1ffc1   Joe Perches   checkpatch: fix $...
371
  our $Assignment	= qr{\*\=|/=|%=|\+=|-=|<<=|>>=|&=|\^=|\|=|=};
447432f32   Joe Perches   checkpatch: fix j...
372
  our $Compare    = qr{<=|>=|==|!=|<|(?<!-)>};
23f780c90   Joe Perches   checkpatch: impro...
373
  our $Arithmetic = qr{\+|-|\*|\/|%};
6c72ffaab   Andy Whitcroft   update checkpatch...
374
375
376
  our $Operators	= qr{
  			<=|>=|==|!=|
  			=>|->|<<|>>|<|>|!|~|
23f780c90   Joe Perches   checkpatch: impro...
377
  			&&|\|\||,|\^|\+\+|--|&|\||$Arithmetic
6c72ffaab   Andy Whitcroft   update checkpatch...
378
  		  }x;
91cb5195f   Joe Perches   checkpatch: expan...
379
  our $c90_Keywords = qr{do|for|while|if|else|return|goto|continue|switch|default|case|break}x;
ab7e23f34   Joe Perches   checkpatch: add t...
380
  our $BasicType;
8905a67c6   Andy Whitcroft   update checkpatch...
381
  our $NonptrType;
1813087db   Joe Perches   checkpatch: add t...
382
  our $NonptrTypeMisordered;
8716de383   Joe Perches   checkpatch: add t...
383
  our $NonptrTypeWithAttr;
8905a67c6   Andy Whitcroft   update checkpatch...
384
  our $Type;
1813087db   Joe Perches   checkpatch: add t...
385
  our $TypeMisordered;
8905a67c6   Andy Whitcroft   update checkpatch...
386
  our $Declare;
1813087db   Joe Perches   checkpatch: add t...
387
  our $DeclareMisordered;
8905a67c6   Andy Whitcroft   update checkpatch...
388

15662b3e8   Joe Perches   checkpatch: add a...
389
390
  our $NON_ASCII_UTF8	= qr{
  	[\xC2-\xDF][\x80-\xBF]               # non-overlong 2-byte
171ae1a49   Andy Whitcroft   update checkpatch...
391
392
393
394
395
396
397
  	|  \xE0[\xA0-\xBF][\x80-\xBF]        # excluding overlongs
  	| [\xE1-\xEC\xEE\xEF][\x80-\xBF]{2}  # straight 3-byte
  	|  \xED[\x80-\x9F][\x80-\xBF]        # excluding surrogates
  	|  \xF0[\x90-\xBF][\x80-\xBF]{2}     # planes 1-3
  	| [\xF1-\xF3][\x80-\xBF]{3}          # planes 4-15
  	|  \xF4[\x80-\x8F][\x80-\xBF]{2}     # plane 16
  }x;
15662b3e8   Joe Perches   checkpatch: add a...
398
399
400
401
  our $UTF8	= qr{
  	[\x09\x0A\x0D\x20-\x7E]              # ASCII
  	| $NON_ASCII_UTF8
  }x;
e6176fa47   Joe Perches   checkpatch: add -...
402
  our $typeC99Typedefs = qr{(?:__)?(?:[us]_?)?int_?(?:8|16|32|64)_t};
021158b4c   Joe Perches   checkpatch: add t...
403
404
405
406
  our $typeOtherOSTypedefs = qr{(?x:
  	u_(?:char|short|int|long) |          # bsd
  	u(?:nchar|short|int|long)            # sysv
  )};
e6176fa47   Joe Perches   checkpatch: add -...
407
  our $typeKernelTypedefs = qr{(?x:
fb9e9096b   Andy Whitcroft   checkpatch: limit...
408
  	(?:__)?(?:u|s|be|le)(?:8|16|32|64)|
8ed22cad9   Andy Whitcroft   checkpatch: pull ...
409
410
  	atomic_t
  )};
e6176fa47   Joe Perches   checkpatch: add -...
411
412
413
414
415
  our $typeTypedefs = qr{(?x:
  	$typeC99Typedefs\b|
  	$typeOtherOSTypedefs\b|
  	$typeKernelTypedefs\b
  )};
8ed22cad9   Andy Whitcroft   checkpatch: pull ...
416

6d32f7a39   Joe Perches   checkpatch: impro...
417
  our $zero_initializer = qr{(?:(?:0[xX])?0+$Int_type?|NULL|false)\b};
691e669ba   Joe Perches   checkpatch.pl: al...
418
  our $logFunctions = qr{(?x:
6e60c02e9   Joe Perches   checkpatch.pl: up...
419
  	printk(?:_ratelimited|_once|)|
7d0b6594e   Jacob Keller   checkpatch: allow...
420
  	(?:[a-z0-9]+_){1,2}(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|)|
6e60c02e9   Joe Perches   checkpatch.pl: up...
421
  	WARN(?:_RATELIMIT|_ONCE|)|
b05317221   Joe Perches   checkpatch: add <...
422
  	panic|
066687279   Joe Perches   checkpatch: updat...
423
424
  	MODULE_[A-Z_]+|
  	seq_vprintf|seq_printf|seq_puts
691e669ba   Joe Perches   checkpatch.pl: al...
425
  )};
201124755   Joe Perches   checkpatch: valid...
426
427
428
429
430
431
  our $signature_tags = qr{(?xi:
  	Signed-off-by:|
  	Acked-by:|
  	Tested-by:|
  	Reviewed-by:|
  	Reported-by:|
8543ae129   Mugunthan V N   checkpatch: add S...
432
  	Suggested-by:|
201124755   Joe Perches   checkpatch: valid...
433
434
435
  	To:|
  	Cc:
  )};
1813087db   Joe Perches   checkpatch: add t...
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
  our @typeListMisordered = (
  	qr{char\s+(?:un)?signed},
  	qr{int\s+(?:(?:un)?signed\s+)?short\s},
  	qr{int\s+short(?:\s+(?:un)?signed)},
  	qr{short\s+int(?:\s+(?:un)?signed)},
  	qr{(?:un)?signed\s+int\s+short},
  	qr{short\s+(?:un)?signed},
  	qr{long\s+int\s+(?:un)?signed},
  	qr{int\s+long\s+(?:un)?signed},
  	qr{long\s+(?:un)?signed\s+int},
  	qr{int\s+(?:un)?signed\s+long},
  	qr{int\s+(?:un)?signed},
  	qr{int\s+long\s+long\s+(?:un)?signed},
  	qr{long\s+long\s+int\s+(?:un)?signed},
  	qr{long\s+long\s+(?:un)?signed\s+int},
  	qr{long\s+long\s+(?:un)?signed},
  	qr{long\s+(?:un)?signed},
  );
8905a67c6   Andy Whitcroft   update checkpatch...
454
455
  our @typeList = (
  	qr{void},
0c773d9d6   Joe Perches   checkpatch: add s...
456
457
458
459
460
461
462
463
464
  	qr{(?:(?:un)?signed\s+)?char},
  	qr{(?:(?:un)?signed\s+)?short\s+int},
  	qr{(?:(?:un)?signed\s+)?short},
  	qr{(?:(?:un)?signed\s+)?int},
  	qr{(?:(?:un)?signed\s+)?long\s+int},
  	qr{(?:(?:un)?signed\s+)?long\s+long\s+int},
  	qr{(?:(?:un)?signed\s+)?long\s+long},
  	qr{(?:(?:un)?signed\s+)?long},
  	qr{(?:un)?signed},
8905a67c6   Andy Whitcroft   update checkpatch...
465
466
467
  	qr{float},
  	qr{double},
  	qr{bool},
8905a67c6   Andy Whitcroft   update checkpatch...
468
469
470
471
472
473
  	qr{struct\s+$Ident},
  	qr{union\s+$Ident},
  	qr{enum\s+$Ident},
  	qr{${Ident}_t},
  	qr{${Ident}_handler},
  	qr{${Ident}_handler_fn},
1813087db   Joe Perches   checkpatch: add t...
474
  	@typeListMisordered,
8905a67c6   Andy Whitcroft   update checkpatch...
475
  );
938224b5e   Joe Perches   checkpatch: warn ...
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
  
  our $C90_int_types = qr{(?x:
  	long\s+long\s+int\s+(?:un)?signed|
  	long\s+long\s+(?:un)?signed\s+int|
  	long\s+long\s+(?:un)?signed|
  	(?:(?:un)?signed\s+)?long\s+long\s+int|
  	(?:(?:un)?signed\s+)?long\s+long|
  	int\s+long\s+long\s+(?:un)?signed|
  	int\s+(?:(?:un)?signed\s+)?long\s+long|
  
  	long\s+int\s+(?:un)?signed|
  	long\s+(?:un)?signed\s+int|
  	long\s+(?:un)?signed|
  	(?:(?:un)?signed\s+)?long\s+int|
  	(?:(?:un)?signed\s+)?long|
  	int\s+long\s+(?:un)?signed|
  	int\s+(?:(?:un)?signed\s+)?long|
  
  	int\s+(?:un)?signed|
  	(?:(?:un)?signed\s+)?int
  )};
485ff23ed   Alex Dowad   checkpatch: make ...
497
  our @typeListFile = ();
8716de383   Joe Perches   checkpatch: add t...
498
499
500
501
502
  our @typeListWithAttr = (
  	@typeList,
  	qr{struct\s+$InitAttribute\s+$Ident},
  	qr{union\s+$InitAttribute\s+$Ident},
  );
c45dcabd2   Andy Whitcroft   update checkpatch...
503
504
505
  our @modifierList = (
  	qr{fastcall},
  );
485ff23ed   Alex Dowad   checkpatch: make ...
506
  our @modifierListFile = ();
8905a67c6   Andy Whitcroft   update checkpatch...
507

2435880fe   Joe Perches   checkpatch: add c...
508
509
510
511
512
513
  our @mode_permission_funcs = (
  	["module_param", 3],
  	["module_param_(?:array|named|string)", 4],
  	["module_param_array_named", 5],
  	["debugfs_create_(?:file|u8|u16|u32|u64|x8|x16|x32|x64|size_t|atomic_t|bool|blob|regset32|u32_array)", 2],
  	["proc_create(?:_data|)", 2],
459cf0ae5   Joe Perches   checkpatch: impro...
514
515
516
517
518
  	["(?:CLASS|DEVICE|SENSOR|SENSOR_DEVICE|IIO_DEVICE)_ATTR", 2],
  	["IIO_DEV_ATTR_[A-Z_]+", 1],
  	["SENSOR_(?:DEVICE_|)ATTR_2", 2],
  	["SENSOR_TEMPLATE(?:_2|)", 3],
  	["__ATTR", 2],
2435880fe   Joe Perches   checkpatch: add c...
519
  );
515a235ef   Joe Perches   checkpatch: impro...
520
521
522
523
524
525
  #Create a search pattern for all these functions to speed up a loop below
  our $mode_perms_search = "";
  foreach my $entry (@mode_permission_funcs) {
  	$mode_perms_search .= '|' if ($mode_perms_search ne "");
  	$mode_perms_search .= $entry->[0];
  }
b392c64f5   Joe Perches   checkpatch: match...
526
527
528
529
530
531
532
  our $mode_perms_world_writable = qr{
  	S_IWUGO		|
  	S_IWOTH		|
  	S_IRWXUGO	|
  	S_IALLUGO	|
  	0[0-7][0-7][2367]
  }x;
f90774e1f   Joe Perches   checkpatch: look ...
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
  our %mode_permission_string_types = (
  	"S_IRWXU" => 0700,
  	"S_IRUSR" => 0400,
  	"S_IWUSR" => 0200,
  	"S_IXUSR" => 0100,
  	"S_IRWXG" => 0070,
  	"S_IRGRP" => 0040,
  	"S_IWGRP" => 0020,
  	"S_IXGRP" => 0010,
  	"S_IRWXO" => 0007,
  	"S_IROTH" => 0004,
  	"S_IWOTH" => 0002,
  	"S_IXOTH" => 0001,
  	"S_IRWXUGO" => 0777,
  	"S_IRUGO" => 0444,
  	"S_IWUGO" => 0222,
  	"S_IXUGO" => 0111,
  );
  
  #Create a search pattern for all these strings to speed up a loop below
  our $mode_perms_string_search = "";
  foreach my $entry (keys %mode_permission_string_types) {
  	$mode_perms_string_search .= '|' if ($mode_perms_string_search ne "");
  	$mode_perms_string_search .= $entry;
  }
7840a94cd   Wolfram Sang   checkpatch: refac...
558
559
  our $allowed_asm_includes = qr{(?x:
  	irq|
cdcee686e   Sergey Ryazanov   checkpatch: updat...
560
561
562
  	memory|
  	time|
  	reboot
7840a94cd   Wolfram Sang   checkpatch: refac...
563
564
  )};
  # memory.h: ARM has a custom one
66b47b4a9   Kees Cook   checkpatch: look ...
565
566
  # Load common spelling mistakes and build regular expression list.
  my $misspellings;
66b47b4a9   Kees Cook   checkpatch: look ...
567
  my %spelling_fix;
66b47b4a9   Kees Cook   checkpatch: look ...
568

36061e380   Joe Perches   checkpatch: fix u...
569
  if (open(my $spelling, '<', $spelling_file)) {
36061e380   Joe Perches   checkpatch: fix u...
570
571
  	while (<$spelling>) {
  		my $line = $_;
66b47b4a9   Kees Cook   checkpatch: look ...
572

36061e380   Joe Perches   checkpatch: fix u...
573
574
575
  		$line =~ s/\s*
  ?$//g;
  		$line =~ s/^\s*//g;
66b47b4a9   Kees Cook   checkpatch: look ...
576

36061e380   Joe Perches   checkpatch: fix u...
577
578
579
580
  		next if ($line =~ m/^\s*#/);
  		next if ($line =~ m/^\s*$/);
  
  		my ($suspect, $fix) = split(/\|\|/, $line);
66b47b4a9   Kees Cook   checkpatch: look ...
581

36061e380   Joe Perches   checkpatch: fix u...
582
583
584
  		$spelling_fix{$suspect} = $fix;
  	}
  	close($spelling);
36061e380   Joe Perches   checkpatch: fix u...
585
586
587
  } else {
  	warn "No typos will be found - file '$spelling_file': $!
  ";
66b47b4a9   Kees Cook   checkpatch: look ...
588
  }
66b47b4a9   Kees Cook   checkpatch: look ...
589

ebfd7d623   Joe Perches   checkpatch: add o...
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
  if ($codespell) {
  	if (open(my $spelling, '<', $codespellfile)) {
  		while (<$spelling>) {
  			my $line = $_;
  
  			$line =~ s/\s*
  ?$//g;
  			$line =~ s/^\s*//g;
  
  			next if ($line =~ m/^\s*#/);
  			next if ($line =~ m/^\s*$/);
  			next if ($line =~ m/, disabled/i);
  
  			$line =~ s/,.*$//;
  
  			my ($suspect, $fix) = split(/->/, $line);
  
  			$spelling_fix{$suspect} = $fix;
  		}
  		close($spelling);
  	} else {
  		warn "No codespell typos will be found - file '$codespellfile': $!
  ";
  	}
  }
  
  $misspellings = join("|", sort keys %spelling_fix) if keys %spelling_fix;
bf1fa1dae   Joe Perches   checkpatch: exter...
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
  my $const_structs = "";
  if (open(my $conststructs, '<', $conststructsfile)) {
  	while (<$conststructs>) {
  		my $line = $_;
  
  		$line =~ s/\s*
  ?$//g;
  		$line =~ s/^\s*//g;
  
  		next if ($line =~ m/^\s*#/);
  		next if ($line =~ m/^\s*$/);
  		if ($line =~ /\s/) {
  			print("$conststructsfile: '$line' invalid - ignored
  ");
  			next;
  		}
  
  		$const_structs .= '|' if ($const_structs ne "");
  		$const_structs .= $line;
  	}
  	close($conststructsfile);
  } else {
  	warn "No structs that should be const will be found - file '$conststructsfile': $!
  ";
  }
8905a67c6   Andy Whitcroft   update checkpatch...
642
  sub build_types {
485ff23ed   Alex Dowad   checkpatch: make ...
643
644
645
646
647
648
649
650
  	my $mods = "(?x:  
  " . join("|
    ", (@modifierList, @modifierListFile)) . "
  )";
  	my $all = "(?x:  
  " . join("|
    ", (@typeList, @typeListFile)) . "
  )";
1813087db   Joe Perches   checkpatch: add t...
651
652
653
654
  	my $Misordered = "(?x:  
  " . join("|
    ", @typeListMisordered) . "
  )";
8716de383   Joe Perches   checkpatch: add t...
655
656
657
658
  	my $allWithAttr = "(?x:  
  " . join("|
    ", @typeListWithAttr) . "
  )";
c8cb2ca37   Andy Whitcroft   checkpatch: types...
659
  	$Modifier	= qr{(?:$Attribute|$Sparse|$mods)};
ab7e23f34   Joe Perches   checkpatch: add t...
660
  	$BasicType	= qr{
ab7e23f34   Joe Perches   checkpatch: add t...
661
662
663
  				(?:$typeTypedefs\b)|
  				(?:${all}\b)
  		}x;
8905a67c6   Andy Whitcroft   update checkpatch...
664
  	$NonptrType	= qr{
d2172eb5b   Andy Whitcroft   checkpatch: possi...
665
  			(?:$Modifier\s+|const\s+)*
cf655043d   Andy Whitcroft   update checkpatch...
666
  			(?:
6b48db24e   Andy Whitcroft   checkpatch: typeo...
667
  				(?:typeof|__typeof__)\s*\([^\)]*\)|
8ed22cad9   Andy Whitcroft   checkpatch: pull ...
668
  				(?:$typeTypedefs\b)|
c45dcabd2   Andy Whitcroft   update checkpatch...
669
  				(?:${all}\b)
cf655043d   Andy Whitcroft   update checkpatch...
670
  			)
c8cb2ca37   Andy Whitcroft   checkpatch: types...
671
  			(?:\s+$Modifier|\s+const)*
8905a67c6   Andy Whitcroft   update checkpatch...
672
  		  }x;
1813087db   Joe Perches   checkpatch: add t...
673
674
675
676
677
678
679
  	$NonptrTypeMisordered	= qr{
  			(?:$Modifier\s+|const\s+)*
  			(?:
  				(?:${Misordered}\b)
  			)
  			(?:\s+$Modifier|\s+const)*
  		  }x;
8716de383   Joe Perches   checkpatch: add t...
680
681
682
683
684
685
686
687
688
  	$NonptrTypeWithAttr	= qr{
  			(?:$Modifier\s+|const\s+)*
  			(?:
  				(?:typeof|__typeof__)\s*\([^\)]*\)|
  				(?:$typeTypedefs\b)|
  				(?:${allWithAttr}\b)
  			)
  			(?:\s+$Modifier|\s+const)*
  		  }x;
8905a67c6   Andy Whitcroft   update checkpatch...
689
  	$Type	= qr{
c45dcabd2   Andy Whitcroft   update checkpatch...
690
  			$NonptrType
1574a29f8   Joe Perches   checkpatch: allow...
691
  			(?:(?:\s|\*|\[\])+\s*const|(?:\s|\*\s*(?:const\s*)?|\[\])+|(?:\s*\[\s*\])+)?
c8cb2ca37   Andy Whitcroft   checkpatch: types...
692
  			(?:\s+$Inline|\s+$Modifier)*
8905a67c6   Andy Whitcroft   update checkpatch...
693
  		  }x;
1813087db   Joe Perches   checkpatch: add t...
694
695
696
697
698
  	$TypeMisordered	= qr{
  			$NonptrTypeMisordered
  			(?:(?:\s|\*|\[\])+\s*const|(?:\s|\*\s*(?:const\s*)?|\[\])+|(?:\s*\[\s*\])+)?
  			(?:\s+$Inline|\s+$Modifier)*
  		  }x;
91cb5195f   Joe Perches   checkpatch: expan...
699
  	$Declare	= qr{(?:$Storage\s+(?:$Inline\s+)?)?$Type};
1813087db   Joe Perches   checkpatch: add t...
700
  	$DeclareMisordered	= qr{(?:$Storage\s+(?:$Inline\s+)?)?$TypeMisordered};
8905a67c6   Andy Whitcroft   update checkpatch...
701
702
  }
  build_types();
6c72ffaab   Andy Whitcroft   update checkpatch...
703

7d2367af0   Joe Perches   checkpatch: sugge...
704
  our $Typecast	= qr{\s*(\(\s*$NonptrType\s*\)){0,1}\s*};
d1fe9c099   Joe Perches   checkpatch: add s...
705
706
707
708
709
710
  
  # Using $balanced_parens, $LvalOrFunc, or $FuncArg
  # requires at least perl version v5.10.0
  # Any use must be runtime checked with $^V
  
  our $balanced_parens = qr/(\((?:[^\(\)]++|(?-1))*\))/;
2435880fe   Joe Perches   checkpatch: add c...
711
  our $LvalOrFunc	= qr{((?:[\&\*]\s*)?$Lval)\s*($balanced_parens{0,1})\s*};
c0a5c8985   Joe Perches   checkpatch: impro...
712
  our $FuncArg = qr{$Typecast{0,1}($LvalOrFunc|$Constant|$String)};
7d2367af0   Joe Perches   checkpatch: sugge...
713

f84223087   Joe Perches   checkpatch: updat...
714
  our $declaration_macros = qr{(?x:
3e838b6c4   Joe Perches   checkpatch: Allow...
715
  	(?:$Storage\s+)?(?:[A-Z_][A-Z0-9]*_){0,2}(?:DEFINE|DECLARE)(?:_[A-Z0-9]+){1,6}\s*\(|
f84223087   Joe Perches   checkpatch: updat...
716
717
718
  	(?:$Storage\s+)?LIST_HEAD\s*\(|
  	(?:$Storage\s+)?${Type}\s+uninitialized_var\s*\(
  )};
7d2367af0   Joe Perches   checkpatch: sugge...
719
720
721
  sub deparenthesize {
  	my ($string) = @_;
  	return "" if (!defined($string));
5b9553abf   Joe Perches   checkpatch: make ...
722
723
724
725
726
  
  	while ($string =~ /^\s*\(.*\)\s*$/) {
  		$string =~ s@^\s*\(\s*@@;
  		$string =~ s@\s*\)\s*$@@;
  	}
7d2367af0   Joe Perches   checkpatch: sugge...
727
  	$string =~ s@\s+@ @g;
5b9553abf   Joe Perches   checkpatch: make ...
728

7d2367af0   Joe Perches   checkpatch: sugge...
729
730
  	return $string;
  }
3445686af   Joe Perches   checkpatch: ignor...
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
  sub seed_camelcase_file {
  	my ($file) = @_;
  
  	return if (!(-f $file));
  
  	local $/;
  
  	open(my $include_file, '<', "$file")
  	    or warn "$P: Can't read '$file' $!
  ";
  	my $text = <$include_file>;
  	close($include_file);
  
  	my @lines = split('
  ', $text);
  
  	foreach my $line (@lines) {
  		next if ($line !~ /(?:[A-Z][a-z]|[a-z][A-Z])/);
  		if ($line =~ /^[ \t]*(?:#[ \t]*define|typedef\s+$Type)\s+(\w*(?:[A-Z][a-z]|[a-z][A-Z])\w*)/) {
  			$camelcase{$1} = 1;
11ea516a6   Joe Perches   checkpatch: find ...
751
752
753
  		} elsif ($line =~ /^\s*$Declare\s+(\w*(?:[A-Z][a-z]|[a-z][A-Z])\w*)\s*[\(\[,;]/) {
  			$camelcase{$1} = 1;
  		} elsif ($line =~ /^\s*(?:union|struct|enum)\s+(\w*(?:[A-Z][a-z]|[a-z][A-Z])\w*)\s*[;\{]/) {
3445686af   Joe Perches   checkpatch: ignor...
754
755
756
757
  			$camelcase{$1} = 1;
  		}
  	}
  }
85b0ee18b   Joe Perches   checkpatch: see i...
758
759
760
761
  sub is_maintained_obsolete {
  	my ($filename) = @_;
  
  	return 0 if (!(-e "$root/scripts/get_maintainer.pl"));
0616efa45   Joe Perches   checkpatch: speed...
762
  	my $status = `perl $root/scripts/get_maintainer.pl --status --nom --nol --nogit --nogit-fallback -f $filename 2>&1`;
85b0ee18b   Joe Perches   checkpatch: see i...
763
764
765
  
  	return $status =~ /obsolete/i;
  }
3445686af   Joe Perches   checkpatch: ignor...
766
767
768
769
770
  my $camelcase_seeded = 0;
  sub seed_camelcase_includes {
  	return if ($camelcase_seeded);
  
  	my $files;
c707a81de   Joe Perches   checkpatch: make ...
771
772
773
774
  	my $camelcase_cache = "";
  	my @include_files = ();
  
  	$camelcase_seeded = 1;
351b2a1fe   Joe Perches   checkpatch: cache...
775

3645e3283   Richard Genoud   checkpatch: fix d...
776
  	if (-e ".git") {
351b2a1fe   Joe Perches   checkpatch: cache...
777
778
  		my $git_last_include_commit = `git log --no-merges --pretty=format:"%h%n" -1 -- include`;
  		chomp $git_last_include_commit;
c707a81de   Joe Perches   checkpatch: make ...
779
  		$camelcase_cache = ".checkpatch-camelcase.git.$git_last_include_commit";
3445686af   Joe Perches   checkpatch: ignor...
780
  	} else {
c707a81de   Joe Perches   checkpatch: make ...
781
  		my $last_mod_date = 0;
3445686af   Joe Perches   checkpatch: ignor...
782
  		$files = `find $root/include -name "*.h"`;
c707a81de   Joe Perches   checkpatch: make ...
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
  		@include_files = split('
  ', $files);
  		foreach my $file (@include_files) {
  			my $date = POSIX::strftime("%Y%m%d%H%M",
  						   localtime((stat $file)[9]));
  			$last_mod_date = $date if ($last_mod_date < $date);
  		}
  		$camelcase_cache = ".checkpatch-camelcase.date.$last_mod_date";
  	}
  
  	if ($camelcase_cache ne "" && -f $camelcase_cache) {
  		open(my $camelcase_file, '<', "$camelcase_cache")
  		    or warn "$P: Can't read '$camelcase_cache' $!
  ";
  		while (<$camelcase_file>) {
  			chomp;
  			$camelcase{$_} = 1;
  		}
  		close($camelcase_file);
  
  		return;
3445686af   Joe Perches   checkpatch: ignor...
804
  	}
c707a81de   Joe Perches   checkpatch: make ...
805

3645e3283   Richard Genoud   checkpatch: fix d...
806
  	if (-e ".git") {
c707a81de   Joe Perches   checkpatch: make ...
807
808
809
810
  		$files = `git ls-files "include/*.h"`;
  		@include_files = split('
  ', $files);
  	}
3445686af   Joe Perches   checkpatch: ignor...
811
812
813
  	foreach my $file (@include_files) {
  		seed_camelcase_file($file);
  	}
351b2a1fe   Joe Perches   checkpatch: cache...
814

c707a81de   Joe Perches   checkpatch: make ...
815
  	if ($camelcase_cache ne "") {
351b2a1fe   Joe Perches   checkpatch: cache...
816
  		unlink glob ".checkpatch-camelcase.*";
c707a81de   Joe Perches   checkpatch: make ...
817
818
819
  		open(my $camelcase_file, '>', "$camelcase_cache")
  		    or warn "$P: Can't write '$camelcase_cache' $!
  ";
351b2a1fe   Joe Perches   checkpatch: cache...
820
821
822
823
824
825
  		foreach (sort { lc($a) cmp lc($b) } keys(%camelcase)) {
  			print $camelcase_file ("$_
  ");
  		}
  		close($camelcase_file);
  	}
3445686af   Joe Perches   checkpatch: ignor...
826
  }
d311cd445   Joe Perches   checkpatch: add t...
827
828
829
830
831
832
833
834
835
  sub git_commit_info {
  	my ($commit, $id, $desc) = @_;
  
  	return ($id, $desc) if ((which("git") eq "") || !(-e ".git"));
  
  	my $output = `git log --no-color --format='%H %s' -1 $commit 2>&1`;
  	$output =~ s/^\s*//gm;
  	my @lines = split("
  ", $output);
0d7835fca   Joe Perches   checkpatch: updat...
836
  	return ($id, $desc) if ($#lines < 0);
d311cd445   Joe Perches   checkpatch: add t...
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
  	if ($lines[0] =~ /^error: short SHA1 $commit is ambiguous\./) {
  # Maybe one day convert this block of bash into something that returns
  # all matching commit ids, but it's very slow...
  #
  #		echo "checking commits $1..."
  #		git rev-list --remotes | grep -i "^$1" |
  #		while read line ; do
  #		    git log --format='%H %s' -1 $line |
  #		    echo "commit $(cut -c 1-12,41-)"
  #		done
  	} elsif ($lines[0] =~ /^fatal: ambiguous argument '$commit': unknown revision or path not in the working tree\./) {
  	} else {
  		$id = substr($lines[0], 0, 12);
  		$desc = substr($lines[0], 41);
  	}
  
  	return ($id, $desc);
  }
6c72ffaab   Andy Whitcroft   update checkpatch...
855
  $chk_signoff = 0 if ($file);
00df344fd   Andy Whitcroft   update checkpatch...
856
  my @rawlines = ();
c2fdda0df   Andy Whitcroft   update checkpatch...
857
  my @lines = ();
3705ce5bc   Joe Perches   checkpatch: creat...
858
  my @fixed = ();
d752fcc88   Joe Perches   checkpatch: add a...
859
860
  my @fixed_inserted = ();
  my @fixed_deleted = ();
194f66fc9   Joe Perches   checkpatch: add a...
861
  my $fixlinenr = -1;
4a593c344   Du, Changbin   checkpatch: add s...
862
863
864
865
866
867
868
  # If input is git commits, extract all commits from the commit expressions.
  # For example, HEAD-3 means we need check 'HEAD, HEAD~1, HEAD~2'.
  die "$P: No git repository found
  " if ($git && !-e ".git");
  
  if ($git) {
  	my @commits = ();
0dea9f1ee   Joe Perches   checkpatch: reduc...
869
  	foreach my $commit_expr (@ARGV) {
4a593c344   Du, Changbin   checkpatch: add s...
870
  		my $git_range;
28898fd1a   Joe Perches   checkpatch: impro...
871
872
  		if ($commit_expr =~ m/^(.*)-(\d+)$/) {
  			$git_range = "-$2 $1";
4a593c344   Du, Changbin   checkpatch: add s...
873
874
  		} elsif ($commit_expr =~ m/\.\./) {
  			$git_range = "$commit_expr";
4a593c344   Du, Changbin   checkpatch: add s...
875
  		} else {
0dea9f1ee   Joe Perches   checkpatch: reduc...
876
877
878
879
880
  			$git_range = "-1 $commit_expr";
  		}
  		my $lines = `git log --no-color --no-merges --pretty=format:'%H %s' $git_range`;
  		foreach my $line (split(/
  /, $lines)) {
28898fd1a   Joe Perches   checkpatch: impro...
881
882
  			$line =~ /^([0-9a-fA-F]{40,40}) (.*)$/;
  			next if (!defined($1) || !defined($2));
0dea9f1ee   Joe Perches   checkpatch: reduc...
883
884
885
886
  			my $sha1 = $1;
  			my $subject = $2;
  			unshift(@commits, $sha1);
  			$git_commits{$sha1} = $subject;
4a593c344   Du, Changbin   checkpatch: add s...
887
888
889
890
891
892
  		}
  	}
  	die "$P: no git commits after extraction!
  " if (@commits == 0);
  	@ARGV = @commits;
  }
c2fdda0df   Andy Whitcroft   update checkpatch...
893
  my $vname;
6c72ffaab   Andy Whitcroft   update checkpatch...
894
  for my $filename (@ARGV) {
21caa13c0   Andy Whitcroft   checkpatch: fix t...
895
  	my $FILE;
4a593c344   Du, Changbin   checkpatch: add s...
896
897
898
899
900
  	if ($git) {
  		open($FILE, '-|', "git format-patch -M --stdout -1 $filename") ||
  			die "$P: $filename: git format-patch failed - $!
  ";
  	} elsif ($file) {
21caa13c0   Andy Whitcroft   checkpatch: fix t...
901
  		open($FILE, '-|', "diff -u /dev/null $filename") ||
6c72ffaab   Andy Whitcroft   update checkpatch...
902
903
  			die "$P: $filename: diff failed - $!
  ";
21caa13c0   Andy Whitcroft   checkpatch: fix t...
904
905
  	} elsif ($filename eq '-') {
  		open($FILE, '<&STDIN');
6c72ffaab   Andy Whitcroft   update checkpatch...
906
  	} else {
21caa13c0   Andy Whitcroft   checkpatch: fix t...
907
  		open($FILE, '<', "$filename") ||
6c72ffaab   Andy Whitcroft   update checkpatch...
908
909
  			die "$P: $filename: open failed - $!
  ";
0a920b5b6   Andy Whitcroft   add a trivial pat...
910
  	}
c2fdda0df   Andy Whitcroft   update checkpatch...
911
912
  	if ($filename eq '-') {
  		$vname = 'Your patch';
4a593c344   Du, Changbin   checkpatch: add s...
913
  	} elsif ($git) {
0dea9f1ee   Joe Perches   checkpatch: reduc...
914
  		$vname = "Commit " . substr($filename, 0, 12) . ' ("' . $git_commits{$filename} . '")';
c2fdda0df   Andy Whitcroft   update checkpatch...
915
916
917
  	} else {
  		$vname = $filename;
  	}
21caa13c0   Andy Whitcroft   checkpatch: fix t...
918
  	while (<$FILE>) {
6c72ffaab   Andy Whitcroft   update checkpatch...
919
920
921
  		chomp;
  		push(@rawlines, $_);
  	}
21caa13c0   Andy Whitcroft   checkpatch: fix t...
922
  	close($FILE);
d8469f162   Joe Perches   checkpatch: impro...
923
924
925
926
927
928
929
930
931
  
  	if ($#ARGV > 0 && $quiet == 0) {
  		print '-' x length($vname) . "
  ";
  		print "$vname
  ";
  		print '-' x length($vname) . "
  ";
  	}
c2fdda0df   Andy Whitcroft   update checkpatch...
932
  	if (!process($filename)) {
6c72ffaab   Andy Whitcroft   update checkpatch...
933
934
935
  		$exit = 1;
  	}
  	@rawlines = ();
13214adf7   Andy Whitcroft   update checkpatch...
936
  	@lines = ();
3705ce5bc   Joe Perches   checkpatch: creat...
937
  	@fixed = ();
d752fcc88   Joe Perches   checkpatch: add a...
938
939
  	@fixed_inserted = ();
  	@fixed_deleted = ();
194f66fc9   Joe Perches   checkpatch: add a...
940
  	$fixlinenr = -1;
485ff23ed   Alex Dowad   checkpatch: make ...
941
942
943
  	@modifierListFile = ();
  	@typeListFile = ();
  	build_types();
0a920b5b6   Andy Whitcroft   add a trivial pat...
944
  }
d8469f162   Joe Perches   checkpatch: impro...
945
  if (!$quiet) {
3c816e490   Joe Perches   checkpatch: emit ...
946
947
  	hash_show_words(\%use_type, "Used");
  	hash_show_words(\%ignore_type, "Ignored");
d8469f162   Joe Perches   checkpatch: impro...
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
  	if ($^V lt 5.10.0) {
  		print << "EOM"
  
  NOTE: perl $^V is not modern enough to detect all possible issues.
        An upgrade to at least perl v5.10.0 is suggested.
  EOM
  	}
  	if ($exit) {
  		print << "EOM"
  
  NOTE: If any of the errors are false positives, please report
        them to the maintainer, see CHECKPATCH in MAINTAINERS.
  EOM
  	}
  }
0a920b5b6   Andy Whitcroft   add a trivial pat...
963
964
965
  exit($exit);
  
  sub top_of_kernel_tree {
6c72ffaab   Andy Whitcroft   update checkpatch...
966
967
968
969
970
971
972
973
974
975
976
977
  	my ($root) = @_;
  
  	my @tree_check = (
  		"COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
  		"README", "Documentation", "arch", "include", "drivers",
  		"fs", "init", "ipc", "kernel", "lib", "scripts",
  	);
  
  	foreach my $check (@tree_check) {
  		if (! -e $root . '/' . $check) {
  			return 0;
  		}
0a920b5b6   Andy Whitcroft   add a trivial pat...
978
  	}
6c72ffaab   Andy Whitcroft   update checkpatch...
979
  	return 1;
8f26b8376   Joe Perches   checkpatch: updat...
980
  }
0a920b5b6   Andy Whitcroft   add a trivial pat...
981

201124755   Joe Perches   checkpatch: valid...
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
  sub parse_email {
  	my ($formatted_email) = @_;
  
  	my $name = "";
  	my $address = "";
  	my $comment = "";
  
  	if ($formatted_email =~ /^(.*)<(\S+\@\S+)>(.*)$/) {
  		$name = $1;
  		$address = $2;
  		$comment = $3 if defined $3;
  	} elsif ($formatted_email =~ /^\s*<(\S+\@\S+)>(.*)$/) {
  		$address = $1;
  		$comment = $2 if defined $2;
  	} elsif ($formatted_email =~ /(\S+\@\S+)(.*)$/) {
  		$address = $1;
  		$comment = $2 if defined $2;
  		$formatted_email =~ s/$address.*$//;
  		$name = $formatted_email;
3705ce5bc   Joe Perches   checkpatch: creat...
1001
  		$name = trim($name);
201124755   Joe Perches   checkpatch: valid...
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
  		$name =~ s/^\"|\"$//g;
  		# If there's a name left after stripping spaces and
  		# leading quotes, and the address doesn't have both
  		# leading and trailing angle brackets, the address
  		# is invalid. ie:
  		#   "joe smith joe@smith.com" bad
  		#   "joe smith <joe@smith.com" bad
  		if ($name ne "" && $address !~ /^<[^>]+>$/) {
  			$name = "";
  			$address = "";
  			$comment = "";
  		}
  	}
3705ce5bc   Joe Perches   checkpatch: creat...
1015
  	$name = trim($name);
201124755   Joe Perches   checkpatch: valid...
1016
  	$name =~ s/^\"|\"$//g;
3705ce5bc   Joe Perches   checkpatch: creat...
1017
  	$address = trim($address);
201124755   Joe Perches   checkpatch: valid...
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
  	$address =~ s/^\<|\>$//g;
  
  	if ($name =~ /[^\w \-]/i) { ##has "must quote" chars
  		$name =~ s/(?<!\\)"/\\"/g; ##escape quotes
  		$name = "\"$name\"";
  	}
  
  	return ($name, $address, $comment);
  }
  
  sub format_email {
  	my ($name, $address) = @_;
  
  	my $formatted_email;
3705ce5bc   Joe Perches   checkpatch: creat...
1032
  	$name = trim($name);
201124755   Joe Perches   checkpatch: valid...
1033
  	$name =~ s/^\"|\"$//g;
3705ce5bc   Joe Perches   checkpatch: creat...
1034
  	$address = trim($address);
201124755   Joe Perches   checkpatch: valid...
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
  
  	if ($name =~ /[^\w \-]/i) { ##has "must quote" chars
  		$name =~ s/(?<!\\)"/\\"/g; ##escape quotes
  		$name = "\"$name\"";
  	}
  
  	if ("$name" eq "") {
  		$formatted_email = "$address";
  	} else {
  		$formatted_email = "$name <$address>";
  	}
  
  	return $formatted_email;
  }
d311cd445   Joe Perches   checkpatch: add t...
1049
  sub which {
bd474ca07   Joe Perches   checkpatch: use t...
1050
  	my ($bin) = @_;
d311cd445   Joe Perches   checkpatch: add t...
1051

bd474ca07   Joe Perches   checkpatch: use t...
1052
1053
1054
1055
  	foreach my $path (split(/:/, $ENV{PATH})) {
  		if (-e "$path/$bin") {
  			return "$path/$bin";
  		}
d311cd445   Joe Perches   checkpatch: add t...
1056
  	}
d311cd445   Joe Perches   checkpatch: add t...
1057

bd474ca07   Joe Perches   checkpatch: use t...
1058
  	return "";
d311cd445   Joe Perches   checkpatch: add t...
1059
  }
000d1cc18   Joe Perches   checkpatch.pl: ad...
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
  sub which_conf {
  	my ($conf) = @_;
  
  	foreach my $path (split(/:/, ".:$ENV{HOME}:.scripts")) {
  		if (-e "$path/$conf") {
  			return "$path/$conf";
  		}
  	}
  
  	return "";
  }
0a920b5b6   Andy Whitcroft   add a trivial pat...
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
  sub expand_tabs {
  	my ($str) = @_;
  
  	my $res = '';
  	my $n = 0;
  	for my $c (split(//, $str)) {
  		if ($c eq "\t") {
  			$res .= ' ';
  			$n++;
  			for (; ($n % 8) != 0; $n++) {
  				$res .= ' ';
  			}
  			next;
  		}
  		$res .= $c;
  		$n++;
  	}
  
  	return $res;
  }
6c72ffaab   Andy Whitcroft   update checkpatch...
1091
  sub copy_spacing {
773647a09   Andy Whitcroft   update checkpatch...
1092
  	(my $res = shift) =~ tr/\t/ /c;
6c72ffaab   Andy Whitcroft   update checkpatch...
1093
1094
  	return $res;
  }
0a920b5b6   Andy Whitcroft   add a trivial pat...
1095

4a0df2ef4   Andy Whitcroft   update checkpatch...
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
  sub line_stats {
  	my ($line) = @_;
  
  	# Drop the diff line leader and expand tabs
  	$line =~ s/^.//;
  	$line = expand_tabs($line);
  
  	# Pick the indent from the front of the line.
  	my ($white) = ($line =~ /^(\s*)/);
  
  	return (length($line), length($white));
  }
773647a09   Andy Whitcroft   update checkpatch...
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
  my $sanitise_quote = '';
  
  sub sanitise_line_reset {
  	my ($in_comment) = @_;
  
  	if ($in_comment) {
  		$sanitise_quote = '*/';
  	} else {
  		$sanitise_quote = '';
  	}
  }
00df344fd   Andy Whitcroft   update checkpatch...
1119
1120
1121
1122
1123
  sub sanitise_line {
  	my ($line) = @_;
  
  	my $res = '';
  	my $l = '';
c2fdda0df   Andy Whitcroft   update checkpatch...
1124
  	my $qlen = 0;
773647a09   Andy Whitcroft   update checkpatch...
1125
1126
  	my $off = 0;
  	my $c;
00df344fd   Andy Whitcroft   update checkpatch...
1127

773647a09   Andy Whitcroft   update checkpatch...
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
  	# Always copy over the diff marker.
  	$res = substr($line, 0, 1);
  
  	for ($off = 1; $off < length($line); $off++) {
  		$c = substr($line, $off, 1);
  
  		# Comments we are wacking completly including the begin
  		# and end, all to $;.
  		if ($sanitise_quote eq '' && substr($line, $off, 2) eq '/*') {
  			$sanitise_quote = '*/';
  
  			substr($res, $off, 2, "$;$;");
  			$off++;
  			next;
00df344fd   Andy Whitcroft   update checkpatch...
1142
  		}
81bc0e020   Andy Whitcroft   checkpatch: handl...
1143
  		if ($sanitise_quote eq '*/' && substr($line, $off, 2) eq '*/') {
773647a09   Andy Whitcroft   update checkpatch...
1144
1145
1146
1147
  			$sanitise_quote = '';
  			substr($res, $off, 2, "$;$;");
  			$off++;
  			next;
c2fdda0df   Andy Whitcroft   update checkpatch...
1148
  		}
113f04a83   Daniel Walker   checkpatch: handl...
1149
1150
1151
1152
1153
1154
1155
  		if ($sanitise_quote eq '' && substr($line, $off, 2) eq '//') {
  			$sanitise_quote = '//';
  
  			substr($res, $off, 2, $sanitise_quote);
  			$off++;
  			next;
  		}
773647a09   Andy Whitcroft   update checkpatch...
1156
1157
1158
1159
1160
1161
1162
  
  		# A \ in a string means ignore the next character.
  		if (($sanitise_quote eq "'" || $sanitise_quote eq '"') &&
  		    $c eq "\\") {
  			substr($res, $off, 2, 'XX');
  			$off++;
  			next;
00df344fd   Andy Whitcroft   update checkpatch...
1163
  		}
773647a09   Andy Whitcroft   update checkpatch...
1164
1165
1166
1167
  		# Regular quotes.
  		if ($c eq "'" || $c eq '"') {
  			if ($sanitise_quote eq '') {
  				$sanitise_quote = $c;
00df344fd   Andy Whitcroft   update checkpatch...
1168

773647a09   Andy Whitcroft   update checkpatch...
1169
1170
1171
1172
1173
1174
  				substr($res, $off, 1, $c);
  				next;
  			} elsif ($sanitise_quote eq $c) {
  				$sanitise_quote = '';
  			}
  		}
00df344fd   Andy Whitcroft   update checkpatch...
1175

fae17daed   Andy Whitcroft   checkpatch: comme...
1176
1177
  		#print "c<$c> SQ<$sanitise_quote>
  ";
773647a09   Andy Whitcroft   update checkpatch...
1178
1179
  		if ($off != 0 && $sanitise_quote eq '*/' && $c ne "\t") {
  			substr($res, $off, 1, $;);
113f04a83   Daniel Walker   checkpatch: handl...
1180
1181
  		} elsif ($off != 0 && $sanitise_quote eq '//' && $c ne "\t") {
  			substr($res, $off, 1, $;);
773647a09   Andy Whitcroft   update checkpatch...
1182
1183
1184
1185
1186
  		} elsif ($off != 0 && $sanitise_quote && $c ne "\t") {
  			substr($res, $off, 1, 'X');
  		} else {
  			substr($res, $off, 1, $c);
  		}
c2fdda0df   Andy Whitcroft   update checkpatch...
1187
  	}
113f04a83   Daniel Walker   checkpatch: handl...
1188
1189
1190
  	if ($sanitise_quote eq '//') {
  		$sanitise_quote = '';
  	}
c2fdda0df   Andy Whitcroft   update checkpatch...
1191
  	# The pathname on a #include may be surrounded by '<' and '>'.
c45dcabd2   Andy Whitcroft   update checkpatch...
1192
  	if ($res =~ /^.\s*\#\s*include\s+\<(.*)\>/) {
c2fdda0df   Andy Whitcroft   update checkpatch...
1193
1194
1195
1196
  		my $clean = 'X' x length($1);
  		$res =~ s@\<.*\>@<$clean>@;
  
  	# The whole of a #error is a string.
c45dcabd2   Andy Whitcroft   update checkpatch...
1197
  	} elsif ($res =~ /^.\s*\#\s*(?:error|warning)\s+(.*)\b/) {
c2fdda0df   Andy Whitcroft   update checkpatch...
1198
  		my $clean = 'X' x length($1);
c45dcabd2   Andy Whitcroft   update checkpatch...
1199
  		$res =~ s@(\#\s*(?:error|warning)\s+).*@$1$clean@;
c2fdda0df   Andy Whitcroft   update checkpatch...
1200
  	}
dadf680de   Joe Perches   checkpatch: allow...
1201
1202
1203
1204
  	if ($allow_c99_comments && $res =~ m@(//.*$)@) {
  		my $match = $1;
  		$res =~ s/\Q$match\E/"$;" x length($match)/e;
  	}
00df344fd   Andy Whitcroft   update checkpatch...
1205
1206
  	return $res;
  }
a6962d727   Joe Perches   checkpatch: Prefe...
1207
1208
  sub get_quoted_string {
  	my ($line, $rawline) = @_;
33acb54a4   Joe Perches   checkpatch: use $...
1209
  	return "" if ($line !~ m/($String)/g);
a6962d727   Joe Perches   checkpatch: Prefe...
1210
1211
  	return substr($rawline, $-[0], $+[0] - $-[0]);
  }
8905a67c6   Andy Whitcroft   update checkpatch...
1212
1213
1214
1215
1216
1217
  sub ctx_statement_block {
  	my ($linenr, $remain, $off) = @_;
  	my $line = $linenr - 1;
  	my $blk = '';
  	my $soff = $off;
  	my $coff = $off - 1;
773647a09   Andy Whitcroft   update checkpatch...
1218
  	my $coff_set = 0;
8905a67c6   Andy Whitcroft   update checkpatch...
1219

13214adf7   Andy Whitcroft   update checkpatch...
1220
  	my $loff = 0;
8905a67c6   Andy Whitcroft   update checkpatch...
1221
1222
  	my $type = '';
  	my $level = 0;
a27506459   Andy Whitcroft   checkpatch: handl...
1223
  	my @stack = ();
cf655043d   Andy Whitcroft   update checkpatch...
1224
  	my $p;
8905a67c6   Andy Whitcroft   update checkpatch...
1225
1226
  	my $c;
  	my $len = 0;
13214adf7   Andy Whitcroft   update checkpatch...
1227
1228
  
  	my $remainder;
8905a67c6   Andy Whitcroft   update checkpatch...
1229
  	while (1) {
a27506459   Andy Whitcroft   checkpatch: handl...
1230
  		@stack = (['', 0]) if ($#stack == -1);
773647a09   Andy Whitcroft   update checkpatch...
1231
1232
  		#warn "CSB: blk<$blk> remain<$remain>
  ";
8905a67c6   Andy Whitcroft   update checkpatch...
1233
1234
1235
1236
  		# If we are about to drop off the end, pull in more
  		# context.
  		if ($off >= $len) {
  			for (; $remain > 0; $line++) {
dea33496d   Andy Whitcroft   checkpatch: suppr...
1237
  				last if (!defined $lines[$line]);
c2fdda0df   Andy Whitcroft   update checkpatch...
1238
  				next if ($lines[$line] =~ /^-/);
8905a67c6   Andy Whitcroft   update checkpatch...
1239
  				$remain--;
13214adf7   Andy Whitcroft   update checkpatch...
1240
  				$loff = $len;
c2fdda0df   Andy Whitcroft   update checkpatch...
1241
1242
  				$blk .= $lines[$line] . "
  ";
8905a67c6   Andy Whitcroft   update checkpatch...
1243
1244
1245
1246
1247
1248
1249
  				$len = length($blk);
  				$line++;
  				last;
  			}
  			# Bail if there is no further context.
  			#warn "CSB: blk<$blk> off<$off> len<$len>
  ";
13214adf7   Andy Whitcroft   update checkpatch...
1250
  			if ($off >= $len) {
8905a67c6   Andy Whitcroft   update checkpatch...
1251
1252
  				last;
  			}
f74bd1942   Andy Whitcroft   checkpatch: corre...
1253
1254
1255
1256
  			if ($level == 0 && substr($blk, $off) =~ /^.\s*#\s*define/) {
  				$level++;
  				$type = '#';
  			}
8905a67c6   Andy Whitcroft   update checkpatch...
1257
  		}
cf655043d   Andy Whitcroft   update checkpatch...
1258
  		$p = $c;
8905a67c6   Andy Whitcroft   update checkpatch...
1259
  		$c = substr($blk, $off, 1);
13214adf7   Andy Whitcroft   update checkpatch...
1260
  		$remainder = substr($blk, $off);
8905a67c6   Andy Whitcroft   update checkpatch...
1261

773647a09   Andy Whitcroft   update checkpatch...
1262
1263
  		#warn "CSB: c<$c> type<$type> level<$level> remainder<$remainder> coff_set<$coff_set>
  ";
4635f4fba   Andy Whitcroft   checkpatch: track...
1264
1265
1266
1267
1268
1269
1270
1271
1272
  
  		# Handle nested #if/#else.
  		if ($remainder =~ /^#\s*(?:ifndef|ifdef|if)\s/) {
  			push(@stack, [ $type, $level ]);
  		} elsif ($remainder =~ /^#\s*(?:else|elif)\b/) {
  			($type, $level) = @{$stack[$#stack - 1]};
  		} elsif ($remainder =~ /^#\s*endif\b/) {
  			($type, $level) = @{pop(@stack)};
  		}
8905a67c6   Andy Whitcroft   update checkpatch...
1273
1274
1275
1276
1277
  		# Statement ends at the ';' or a close '}' at the
  		# outermost level.
  		if ($level == 0 && $c eq ';') {
  			last;
  		}
13214adf7   Andy Whitcroft   update checkpatch...
1278
  		# An else is really a conditional as long as its not else if
773647a09   Andy Whitcroft   update checkpatch...
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
  		if ($level == 0 && $coff_set == 0 &&
  				(!defined($p) || $p =~ /(?:\s|\}|\+)/) &&
  				$remainder =~ /^(else)(?:\s|{)/ &&
  				$remainder !~ /^else\s+if\b/) {
  			$coff = $off + length($1) - 1;
  			$coff_set = 1;
  			#warn "CSB: mark coff<$coff> soff<$soff> 1<$1>
  ";
  			#warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]
  ";
13214adf7   Andy Whitcroft   update checkpatch...
1289
  		}
8905a67c6   Andy Whitcroft   update checkpatch...
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
  		if (($type eq '' || $type eq '(') && $c eq '(') {
  			$level++;
  			$type = '(';
  		}
  		if ($type eq '(' && $c eq ')') {
  			$level--;
  			$type = ($level != 0)? '(' : '';
  
  			if ($level == 0 && $coff < $soff) {
  				$coff = $off;
773647a09   Andy Whitcroft   update checkpatch...
1300
1301
1302
  				$coff_set = 1;
  				#warn "CSB: mark coff<$coff>
  ";
8905a67c6   Andy Whitcroft   update checkpatch...
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
  			}
  		}
  		if (($type eq '' || $type eq '{') && $c eq '{') {
  			$level++;
  			$type = '{';
  		}
  		if ($type eq '{' && $c eq '}') {
  			$level--;
  			$type = ($level != 0)? '{' : '';
  
  			if ($level == 0) {
b998e001e   Patrick Pannuto   checkpatch: fix e...
1314
1315
1316
  				if (substr($blk, $off + 1, 1) eq ';') {
  					$off++;
  				}
8905a67c6   Andy Whitcroft   update checkpatch...
1317
1318
1319
  				last;
  			}
  		}
f74bd1942   Andy Whitcroft   checkpatch: corre...
1320
1321
1322
1323
1324
1325
1326
1327
  		# Preprocessor commands end at the newline unless escaped.
  		if ($type eq '#' && $c eq "
  " && $p ne "\\") {
  			$level--;
  			$type = '';
  			$off++;
  			last;
  		}
8905a67c6   Andy Whitcroft   update checkpatch...
1328
1329
  		$off++;
  	}
a3bb97a7a   Andy Whitcroft   checkpatch: macro...
1330
  	# We are truly at the end, so shuffle to the next line.
13214adf7   Andy Whitcroft   update checkpatch...
1331
  	if ($off == $len) {
a3bb97a7a   Andy Whitcroft   checkpatch: macro...
1332
  		$loff = $len + 1;
13214adf7   Andy Whitcroft   update checkpatch...
1333
1334
1335
  		$line++;
  		$remain--;
  	}
8905a67c6   Andy Whitcroft   update checkpatch...
1336
1337
1338
1339
1340
1341
1342
1343
  
  	my $statement = substr($blk, $soff, $off - $soff + 1);
  	my $condition = substr($blk, $soff, $coff - $soff + 1);
  
  	#warn "STATEMENT<$statement>
  ";
  	#warn "CONDITION<$condition>
  ";
773647a09   Andy Whitcroft   update checkpatch...
1344
1345
  	#print "coff<$coff> soff<$off> loff<$loff>
  ";
13214adf7   Andy Whitcroft   update checkpatch...
1346
1347
1348
1349
  
  	return ($statement, $condition,
  			$line, $remain + 1, $off - $loff + 1, $level);
  }
cf655043d   Andy Whitcroft   update checkpatch...
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
  sub statement_lines {
  	my ($stmt) = @_;
  
  	# Strip the diff line prefixes and rip blank lines at start and end.
  	$stmt =~ s/(^|
  )./$1/g;
  	$stmt =~ s/^\s*//;
  	$stmt =~ s/\s*$//;
  
  	my @stmt_lines = ($stmt =~ /
  /g);
  
  	return $#stmt_lines + 2;
  }
  
  sub statement_rawlines {
  	my ($stmt) = @_;
  
  	my @stmt_lines = ($stmt =~ /
  /g);
  
  	return $#stmt_lines + 2;
  }
  
  sub statement_block_size {
  	my ($stmt) = @_;
  
  	$stmt =~ s/(^|
  )./$1/g;
  	$stmt =~ s/^\s*{//;
  	$stmt =~ s/}\s*$//;
  	$stmt =~ s/^\s*//;
  	$stmt =~ s/\s*$//;
  
  	my @stmt_lines = ($stmt =~ /
  /g);
  	my @stmt_statements = ($stmt =~ /;/g);
  
  	my $stmt_lines = $#stmt_lines + 2;
  	my $stmt_statements = $#stmt_statements + 1;
  
  	if ($stmt_lines > $stmt_statements) {
  		return $stmt_lines;
  	} else {
  		return $stmt_statements;
  	}
  }
13214adf7   Andy Whitcroft   update checkpatch...
1397
1398
1399
1400
1401
  sub ctx_statement_full {
  	my ($linenr, $remain, $off) = @_;
  	my ($statement, $condition, $level);
  
  	my (@chunks);
cf655043d   Andy Whitcroft   update checkpatch...
1402
  	# Grab the first conditional/block pair.
13214adf7   Andy Whitcroft   update checkpatch...
1403
1404
  	($statement, $condition, $linenr, $remain, $off, $level) =
  				ctx_statement_block($linenr, $remain, $off);
773647a09   Andy Whitcroft   update checkpatch...
1405
1406
  	#print "F: c<$condition> s<$statement> remain<$remain>
  ";
cf655043d   Andy Whitcroft   update checkpatch...
1407
1408
1409
1410
1411
1412
1413
1414
  	push(@chunks, [ $condition, $statement ]);
  	if (!($remain > 0 && $condition =~ /^\s*(?:
  [+-])?\s*(?:if|else|do)\b/s)) {
  		return ($level, $linenr, @chunks);
  	}
  
  	# Pull in the following conditional/block pairs and see if they
  	# could continue the statement.
13214adf7   Andy Whitcroft   update checkpatch...
1415
  	for (;;) {
13214adf7   Andy Whitcroft   update checkpatch...
1416
1417
  		($statement, $condition, $linenr, $remain, $off, $level) =
  				ctx_statement_block($linenr, $remain, $off);
cf655043d   Andy Whitcroft   update checkpatch...
1418
1419
  		#print "C: c<$condition> s<$statement> remain<$remain>
  ";
773647a09   Andy Whitcroft   update checkpatch...
1420
1421
  		last if (!($remain > 0 && $condition =~ /^(?:\s*
  [+-])*\s*(?:else|do)\b/s));
cf655043d   Andy Whitcroft   update checkpatch...
1422
1423
1424
  		#print "C: push
  ";
  		push(@chunks, [ $condition, $statement ]);
13214adf7   Andy Whitcroft   update checkpatch...
1425
1426
1427
  	}
  
  	return ($level, $linenr, @chunks);
8905a67c6   Andy Whitcroft   update checkpatch...
1428
  }
4a0df2ef4   Andy Whitcroft   update checkpatch...
1429
  sub ctx_block_get {
f0a594c1c   Andy Whitcroft   update checkpatch...
1430
  	my ($linenr, $remain, $outer, $open, $close, $off) = @_;
4a0df2ef4   Andy Whitcroft   update checkpatch...
1431
1432
  	my $line;
  	my $start = $linenr - 1;
4a0df2ef4   Andy Whitcroft   update checkpatch...
1433
1434
1435
1436
  	my $blk = '';
  	my @o;
  	my @c;
  	my @res = ();
f0a594c1c   Andy Whitcroft   update checkpatch...
1437
  	my $level = 0;
4635f4fba   Andy Whitcroft   checkpatch: track...
1438
  	my @stack = ($level);
00df344fd   Andy Whitcroft   update checkpatch...
1439
1440
1441
1442
1443
  	for ($line = $start; $remain > 0; $line++) {
  		next if ($rawlines[$line] =~ /^-/);
  		$remain--;
  
  		$blk .= $rawlines[$line];
4635f4fba   Andy Whitcroft   checkpatch: track...
1444
1445
  
  		# Handle nested #if/#else.
01464f30a   Andy Whitcroft   checkpatch: state...
1446
  		if ($lines[$line] =~ /^.\s*#\s*(?:ifndef|ifdef|if)\s/) {
4635f4fba   Andy Whitcroft   checkpatch: track...
1447
  			push(@stack, $level);
01464f30a   Andy Whitcroft   checkpatch: state...
1448
  		} elsif ($lines[$line] =~ /^.\s*#\s*(?:else|elif)\b/) {
4635f4fba   Andy Whitcroft   checkpatch: track...
1449
  			$level = $stack[$#stack - 1];
01464f30a   Andy Whitcroft   checkpatch: state...
1450
  		} elsif ($lines[$line] =~ /^.\s*#\s*endif\b/) {
4635f4fba   Andy Whitcroft   checkpatch: track...
1451
1452
  			$level = pop(@stack);
  		}
01464f30a   Andy Whitcroft   checkpatch: state...
1453
  		foreach my $c (split(//, $lines[$line])) {
f0a594c1c   Andy Whitcroft   update checkpatch...
1454
1455
1456
1457
1458
1459
  			##print "C<$c>L<$level><$open$close>O<$off>
  ";
  			if ($off > 0) {
  				$off--;
  				next;
  			}
4a0df2ef4   Andy Whitcroft   update checkpatch...
1460

f0a594c1c   Andy Whitcroft   update checkpatch...
1461
1462
1463
1464
1465
1466
1467
  			if ($c eq $close && $level > 0) {
  				$level--;
  				last if ($level == 0);
  			} elsif ($c eq $open) {
  				$level++;
  			}
  		}
4a0df2ef4   Andy Whitcroft   update checkpatch...
1468

f0a594c1c   Andy Whitcroft   update checkpatch...
1469
  		if (!$outer || $level <= 1) {
00df344fd   Andy Whitcroft   update checkpatch...
1470
  			push(@res, $rawlines[$line]);
4a0df2ef4   Andy Whitcroft   update checkpatch...
1471
  		}
f0a594c1c   Andy Whitcroft   update checkpatch...
1472
  		last if ($level == 0);
4a0df2ef4   Andy Whitcroft   update checkpatch...
1473
  	}
f0a594c1c   Andy Whitcroft   update checkpatch...
1474
  	return ($level, @res);
4a0df2ef4   Andy Whitcroft   update checkpatch...
1475
1476
1477
  }
  sub ctx_block_outer {
  	my ($linenr, $remain) = @_;
f0a594c1c   Andy Whitcroft   update checkpatch...
1478
1479
  	my ($level, @r) = ctx_block_get($linenr, $remain, 1, '{', '}', 0);
  	return @r;
4a0df2ef4   Andy Whitcroft   update checkpatch...
1480
1481
1482
  }
  sub ctx_block {
  	my ($linenr, $remain) = @_;
f0a594c1c   Andy Whitcroft   update checkpatch...
1483
1484
  	my ($level, @r) = ctx_block_get($linenr, $remain, 0, '{', '}', 0);
  	return @r;
653d4876b   Andy Whitcroft   update checkpatch...
1485
1486
  }
  sub ctx_statement {
f0a594c1c   Andy Whitcroft   update checkpatch...
1487
1488
1489
1490
1491
1492
  	my ($linenr, $remain, $off) = @_;
  
  	my ($level, @r) = ctx_block_get($linenr, $remain, 0, '(', ')', $off);
  	return @r;
  }
  sub ctx_block_level {
653d4876b   Andy Whitcroft   update checkpatch...
1493
  	my ($linenr, $remain) = @_;
f0a594c1c   Andy Whitcroft   update checkpatch...
1494
  	return ctx_block_get($linenr, $remain, 0, '{', '}', 0);
4a0df2ef4   Andy Whitcroft   update checkpatch...
1495
  }
9c0ca6f9a   Andy Whitcroft   update checkpatch...
1496
1497
1498
1499
1500
  sub ctx_statement_level {
  	my ($linenr, $remain, $off) = @_;
  
  	return ctx_block_get($linenr, $remain, 0, '(', ')', $off);
  }
4a0df2ef4   Andy Whitcroft   update checkpatch...
1501
1502
1503
1504
1505
  
  sub ctx_locate_comment {
  	my ($first_line, $end_line) = @_;
  
  	# Catch a comment on the end of the line itself.
beae63324   Andy Whitcroft   checkpatch: comme...
1506
  	my ($current_comment) = ($rawlines[$end_line - 1] =~ m@.*(/\*.*\*/)\s*(?:\\\s*)?$@);
4a0df2ef4   Andy Whitcroft   update checkpatch...
1507
1508
1509
1510
1511
1512
1513
  	return $current_comment if (defined $current_comment);
  
  	# Look through the context and try and figure out if there is a
  	# comment.
  	my $in_comment = 0;
  	$current_comment = '';
  	for (my $linenr = $first_line; $linenr < $end_line; $linenr++) {
00df344fd   Andy Whitcroft   update checkpatch...
1514
1515
1516
  		my $line = $rawlines[$linenr - 1];
  		#warn "           $line
  ";
4a0df2ef4   Andy Whitcroft   update checkpatch...
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
  		if ($linenr == $first_line and $line =~ m@^.\s*\*@) {
  			$in_comment = 1;
  		}
  		if ($line =~ m@/\*@) {
  			$in_comment = 1;
  		}
  		if (!$in_comment && $current_comment ne '') {
  			$current_comment = '';
  		}
  		$current_comment .= $line . "
  " if ($in_comment);
  		if ($line =~ m@\*/@) {
  			$in_comment = 0;
  		}
  	}
  
  	chomp($current_comment);
  	return($current_comment);
  }
  sub ctx_has_comment {
  	my ($first_line, $end_line) = @_;
  	my $cmt = ctx_locate_comment($first_line, $end_line);
00df344fd   Andy Whitcroft   update checkpatch...
1539
1540
  	##print "LINE: $rawlines[$end_line - 1 ]
  ";
4a0df2ef4   Andy Whitcroft   update checkpatch...
1541
1542
1543
1544
1545
  	##print "CMMT: $cmt
  ";
  
  	return ($cmt ne '');
  }
4d001e4d8   Andy Whitcroft   checkpatch: repor...
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
  sub raw_line {
  	my ($linenr, $cnt) = @_;
  
  	my $offset = $linenr - 1;
  	$cnt++;
  
  	my $line;
  	while ($cnt) {
  		$line = $rawlines[$offset++];
  		next if (defined($line) && $line =~ /^-/);
  		$cnt--;
  	}
  
  	return $line;
  }
6c72ffaab   Andy Whitcroft   update checkpatch...
1561
1562
1563
  sub cat_vet {
  	my ($vet) = @_;
  	my ($res, $coded);
9c0ca6f9a   Andy Whitcroft   update checkpatch...
1564

6c72ffaab   Andy Whitcroft   update checkpatch...
1565
1566
1567
1568
1569
1570
  	$res = '';
  	while ($vet =~ /([^[:cntrl:]]*)([[:cntrl:]]|$)/g) {
  		$res .= $1;
  		if ($2 ne '') {
  			$coded = sprintf("^%c", unpack('C', $2) + 64);
  			$res .= $coded;
9c0ca6f9a   Andy Whitcroft   update checkpatch...
1571
1572
  		}
  	}
6c72ffaab   Andy Whitcroft   update checkpatch...
1573
  	$res =~ s/$/\$/;
9c0ca6f9a   Andy Whitcroft   update checkpatch...
1574

6c72ffaab   Andy Whitcroft   update checkpatch...
1575
  	return $res;
9c0ca6f9a   Andy Whitcroft   update checkpatch...
1576
  }
c2fdda0df   Andy Whitcroft   update checkpatch...
1577
  my $av_preprocessor = 0;
cf655043d   Andy Whitcroft   update checkpatch...
1578
  my $av_pending;
c2fdda0df   Andy Whitcroft   update checkpatch...
1579
  my @av_paren_type;
1f65f947a   Andy Whitcroft   checkpatch: add c...
1580
  my $av_pend_colon;
c2fdda0df   Andy Whitcroft   update checkpatch...
1581
1582
1583
  
  sub annotate_reset {
  	$av_preprocessor = 0;
cf655043d   Andy Whitcroft   update checkpatch...
1584
1585
  	$av_pending = '_';
  	@av_paren_type = ('E');
1f65f947a   Andy Whitcroft   checkpatch: add c...
1586
  	$av_pend_colon = 'O';
c2fdda0df   Andy Whitcroft   update checkpatch...
1587
  }
6c72ffaab   Andy Whitcroft   update checkpatch...
1588
1589
  sub annotate_values {
  	my ($stream, $type) = @_;
0a920b5b6   Andy Whitcroft   add a trivial pat...
1590

6c72ffaab   Andy Whitcroft   update checkpatch...
1591
  	my $res;
1f65f947a   Andy Whitcroft   checkpatch: add c...
1592
  	my $var = '_' x length($stream);
6c72ffaab   Andy Whitcroft   update checkpatch...
1593
  	my $cur = $stream;
c2fdda0df   Andy Whitcroft   update checkpatch...
1594
1595
  	print "$stream
  " if ($dbg_values > 1);
6c72ffaab   Andy Whitcroft   update checkpatch...
1596

6c72ffaab   Andy Whitcroft   update checkpatch...
1597
  	while (length($cur)) {
773647a09   Andy Whitcroft   update checkpatch...
1598
  		@av_paren_type = ('E') if ($#av_paren_type < 0);
cf655043d   Andy Whitcroft   update checkpatch...
1599
  		print " <" . join('', @av_paren_type) .
171ae1a49   Andy Whitcroft   update checkpatch...
1600
  				"> <$type> <$av_pending>" if ($dbg_values > 1);
6c72ffaab   Andy Whitcroft   update checkpatch...
1601
  		if ($cur =~ /^(\s+)/o) {
c2fdda0df   Andy Whitcroft   update checkpatch...
1602
1603
1604
1605
  			print "WS($1)
  " if ($dbg_values > 1);
  			if ($1 =~ /
  / && $av_preprocessor) {
cf655043d   Andy Whitcroft   update checkpatch...
1606
  				$type = pop(@av_paren_type);
c2fdda0df   Andy Whitcroft   update checkpatch...
1607
  				$av_preprocessor = 0;
6c72ffaab   Andy Whitcroft   update checkpatch...
1608
  			}
c023e4734   Florian Mickler   checkpatch.pl: fi...
1609
  		} elsif ($cur =~ /^(\(\s*$Type\s*)\)/ && $av_pending eq '_') {
9446ef569   Andy Whitcroft   checkpatch: handl...
1610
1611
1612
  			print "CAST($1)
  " if ($dbg_values > 1);
  			push(@av_paren_type, $type);
addcdcea9   Andy Whitcroft   checkpatch: ensur...
1613
  			$type = 'c';
9446ef569   Andy Whitcroft   checkpatch: handl...
1614

e91b6e263   Andy Whitcroft   checkpatch: types...
1615
  		} elsif ($cur =~ /^($Type)\s*(?:$Ident|,|\)|\(|\s*$)/) {
c2fdda0df   Andy Whitcroft   update checkpatch...
1616
1617
  			print "DECLARE($1)
  " if ($dbg_values > 1);
6c72ffaab   Andy Whitcroft   update checkpatch...
1618
  			$type = 'T';
389a2fe57   Andy Whitcroft   checkpatch: allow...
1619
1620
1621
1622
  		} elsif ($cur =~ /^($Modifier)\s*/) {
  			print "MODIFIER($1)
  " if ($dbg_values > 1);
  			$type = 'T';
c45dcabd2   Andy Whitcroft   update checkpatch...
1623
  		} elsif ($cur =~ /^(\#\s*define\s*$Ident)(\(?)/o) {
171ae1a49   Andy Whitcroft   update checkpatch...
1624
1625
  			print "DEFINE($1,$2)
  " if ($dbg_values > 1);
c2fdda0df   Andy Whitcroft   update checkpatch...
1626
  			$av_preprocessor = 1;
171ae1a49   Andy Whitcroft   update checkpatch...
1627
1628
1629
1630
1631
  			push(@av_paren_type, $type);
  			if ($2 ne '') {
  				$av_pending = 'N';
  			}
  			$type = 'E';
c45dcabd2   Andy Whitcroft   update checkpatch...
1632
  		} elsif ($cur =~ /^(\#\s*(?:undef\s*$Ident|include\b))/o) {
171ae1a49   Andy Whitcroft   update checkpatch...
1633
1634
1635
1636
  			print "UNDEF($1)
  " if ($dbg_values > 1);
  			$av_preprocessor = 1;
  			push(@av_paren_type, $type);
6c72ffaab   Andy Whitcroft   update checkpatch...
1637

c45dcabd2   Andy Whitcroft   update checkpatch...
1638
  		} elsif ($cur =~ /^(\#\s*(?:ifdef|ifndef|if))/o) {
cf655043d   Andy Whitcroft   update checkpatch...
1639
1640
  			print "PRE_START($1)
  " if ($dbg_values > 1);
c2fdda0df   Andy Whitcroft   update checkpatch...
1641
  			$av_preprocessor = 1;
cf655043d   Andy Whitcroft   update checkpatch...
1642
1643
1644
  
  			push(@av_paren_type, $type);
  			push(@av_paren_type, $type);
171ae1a49   Andy Whitcroft   update checkpatch...
1645
  			$type = 'E';
cf655043d   Andy Whitcroft   update checkpatch...
1646

c45dcabd2   Andy Whitcroft   update checkpatch...
1647
  		} elsif ($cur =~ /^(\#\s*(?:else|elif))/o) {
cf655043d   Andy Whitcroft   update checkpatch...
1648
1649
1650
1651
1652
  			print "PRE_RESTART($1)
  " if ($dbg_values > 1);
  			$av_preprocessor = 1;
  
  			push(@av_paren_type, $av_paren_type[$#av_paren_type]);
171ae1a49   Andy Whitcroft   update checkpatch...
1653
  			$type = 'E';
cf655043d   Andy Whitcroft   update checkpatch...
1654

c45dcabd2   Andy Whitcroft   update checkpatch...
1655
  		} elsif ($cur =~ /^(\#\s*(?:endif))/o) {
cf655043d   Andy Whitcroft   update checkpatch...
1656
1657
1658
1659
1660
1661
1662
1663
1664
  			print "PRE_END($1)
  " if ($dbg_values > 1);
  
  			$av_preprocessor = 1;
  
  			# Assume all arms of the conditional end as this
  			# one does, and continue as if the #endif was not here.
  			pop(@av_paren_type);
  			push(@av_paren_type, $type);
171ae1a49   Andy Whitcroft   update checkpatch...
1665
  			$type = 'E';
6c72ffaab   Andy Whitcroft   update checkpatch...
1666
1667
1668
  
  		} elsif ($cur =~ /^(\\
  )/o) {
c2fdda0df   Andy Whitcroft   update checkpatch...
1669
1670
  			print "PRECONT($1)
  " if ($dbg_values > 1);
6c72ffaab   Andy Whitcroft   update checkpatch...
1671

171ae1a49   Andy Whitcroft   update checkpatch...
1672
1673
1674
1675
1676
  		} elsif ($cur =~ /^(__attribute__)\s*\(?/o) {
  			print "ATTR($1)
  " if ($dbg_values > 1);
  			$av_pending = $type;
  			$type = 'N';
6c72ffaab   Andy Whitcroft   update checkpatch...
1677
  		} elsif ($cur =~ /^(sizeof)\s*(\()?/o) {
c2fdda0df   Andy Whitcroft   update checkpatch...
1678
1679
  			print "SIZEOF($1)
  " if ($dbg_values > 1);
6c72ffaab   Andy Whitcroft   update checkpatch...
1680
  			if (defined $2) {
cf655043d   Andy Whitcroft   update checkpatch...
1681
  				$av_pending = 'V';
6c72ffaab   Andy Whitcroft   update checkpatch...
1682
1683
  			}
  			$type = 'N';
14b111c15   Andy Whitcroft   checkpatch: condi...
1684
  		} elsif ($cur =~ /^(if|while|for)\b/o) {
c2fdda0df   Andy Whitcroft   update checkpatch...
1685
1686
  			print "COND($1)
  " if ($dbg_values > 1);
14b111c15   Andy Whitcroft   checkpatch: condi...
1687
  			$av_pending = 'E';
6c72ffaab   Andy Whitcroft   update checkpatch...
1688
  			$type = 'N';
1f65f947a   Andy Whitcroft   checkpatch: add c...
1689
1690
1691
1692
1693
  		} elsif ($cur =~/^(case)/o) {
  			print "CASE($1)
  " if ($dbg_values > 1);
  			$av_pend_colon = 'C';
  			$type = 'N';
14b111c15   Andy Whitcroft   checkpatch: condi...
1694
  		} elsif ($cur =~/^(return|else|goto|typeof|__typeof__)\b/o) {
c2fdda0df   Andy Whitcroft   update checkpatch...
1695
1696
  			print "KEYWORD($1)
  " if ($dbg_values > 1);
6c72ffaab   Andy Whitcroft   update checkpatch...
1697
1698
1699
  			$type = 'N';
  
  		} elsif ($cur =~ /^(\()/o) {
c2fdda0df   Andy Whitcroft   update checkpatch...
1700
1701
  			print "PAREN('$1')
  " if ($dbg_values > 1);
cf655043d   Andy Whitcroft   update checkpatch...
1702
1703
  			push(@av_paren_type, $av_pending);
  			$av_pending = '_';
6c72ffaab   Andy Whitcroft   update checkpatch...
1704
1705
1706
  			$type = 'N';
  
  		} elsif ($cur =~ /^(\))/o) {
cf655043d   Andy Whitcroft   update checkpatch...
1707
1708
1709
  			my $new_type = pop(@av_paren_type);
  			if ($new_type ne '_') {
  				$type = $new_type;
c2fdda0df   Andy Whitcroft   update checkpatch...
1710
1711
1712
  				print "PAREN('$1') -> $type
  "
  							if ($dbg_values > 1);
6c72ffaab   Andy Whitcroft   update checkpatch...
1713
  			} else {
c2fdda0df   Andy Whitcroft   update checkpatch...
1714
1715
  				print "PAREN('$1')
  " if ($dbg_values > 1);
6c72ffaab   Andy Whitcroft   update checkpatch...
1716
  			}
c8cb2ca37   Andy Whitcroft   checkpatch: types...
1717
  		} elsif ($cur =~ /^($Ident)\s*\(/o) {
c2fdda0df   Andy Whitcroft   update checkpatch...
1718
1719
  			print "FUNC($1)
  " if ($dbg_values > 1);
c8cb2ca37   Andy Whitcroft   checkpatch: types...
1720
  			$type = 'V';
cf655043d   Andy Whitcroft   update checkpatch...
1721
  			$av_pending = 'V';
6c72ffaab   Andy Whitcroft   update checkpatch...
1722

8e761b04a   Andy Whitcroft   checkpatch: detec...
1723
1724
  		} elsif ($cur =~ /^($Ident\s*):(?:\s*\d+\s*(,|=|;))?/) {
  			if (defined $2 && $type eq 'C' || $type eq 'T') {
1f65f947a   Andy Whitcroft   checkpatch: add c...
1725
  				$av_pend_colon = 'B';
8e761b04a   Andy Whitcroft   checkpatch: detec...
1726
1727
  			} elsif ($type eq 'E') {
  				$av_pend_colon = 'L';
1f65f947a   Andy Whitcroft   checkpatch: add c...
1728
1729
1730
1731
  			}
  			print "IDENT_COLON($1,$type>$av_pend_colon)
  " if ($dbg_values > 1);
  			$type = 'V';
6c72ffaab   Andy Whitcroft   update checkpatch...
1732
  		} elsif ($cur =~ /^($Ident|$Constant)/o) {
c2fdda0df   Andy Whitcroft   update checkpatch...
1733
1734
  			print "IDENT($1)
  " if ($dbg_values > 1);
6c72ffaab   Andy Whitcroft   update checkpatch...
1735
1736
1737
  			$type = 'V';
  
  		} elsif ($cur =~ /^($Assignment)/o) {
c2fdda0df   Andy Whitcroft   update checkpatch...
1738
1739
  			print "ASSIGN($1)
  " if ($dbg_values > 1);
6c72ffaab   Andy Whitcroft   update checkpatch...
1740
  			$type = 'N';
cf655043d   Andy Whitcroft   update checkpatch...
1741
  		} elsif ($cur =~/^(;|{|})/) {
c2fdda0df   Andy Whitcroft   update checkpatch...
1742
1743
  			print "END($1)
  " if ($dbg_values > 1);
13214adf7   Andy Whitcroft   update checkpatch...
1744
  			$type = 'E';
1f65f947a   Andy Whitcroft   checkpatch: add c...
1745
  			$av_pend_colon = 'O';
8e761b04a   Andy Whitcroft   checkpatch: detec...
1746
1747
1748
1749
  		} elsif ($cur =~/^(,)/) {
  			print "COMMA($1)
  " if ($dbg_values > 1);
  			$type = 'C';
1f65f947a   Andy Whitcroft   checkpatch: add c...
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
  		} elsif ($cur =~ /^(\?)/o) {
  			print "QUESTION($1)
  " if ($dbg_values > 1);
  			$type = 'N';
  
  		} elsif ($cur =~ /^(:)/o) {
  			print "COLON($1,$av_pend_colon)
  " if ($dbg_values > 1);
  
  			substr($var, length($res), 1, $av_pend_colon);
  			if ($av_pend_colon eq 'C' || $av_pend_colon eq 'L') {
  				$type = 'E';
  			} else {
  				$type = 'N';
  			}
  			$av_pend_colon = 'O';
13214adf7   Andy Whitcroft   update checkpatch...
1766

8e761b04a   Andy Whitcroft   checkpatch: detec...
1767
  		} elsif ($cur =~ /^(\[)/o) {
13214adf7   Andy Whitcroft   update checkpatch...
1768
1769
  			print "CLOSE($1)
  " if ($dbg_values > 1);
6c72ffaab   Andy Whitcroft   update checkpatch...
1770
  			$type = 'N';
0d413866c   Andy Whitcroft   checkpatch: value...
1771
  		} elsif ($cur =~ /^(-(?![->])|\+(?!\+)|\*|\&\&|\&)/o) {
74048ed81   Andy Whitcroft   checkpatch: varia...
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
  			my $variant;
  
  			print "OPV($1)
  " if ($dbg_values > 1);
  			if ($type eq 'V') {
  				$variant = 'B';
  			} else {
  				$variant = 'U';
  			}
  
  			substr($var, length($res), 1, $variant);
  			$type = 'N';
6c72ffaab   Andy Whitcroft   update checkpatch...
1784
  		} elsif ($cur =~ /^($Operators)/o) {
c2fdda0df   Andy Whitcroft   update checkpatch...
1785
1786
  			print "OP($1)
  " if ($dbg_values > 1);
6c72ffaab   Andy Whitcroft   update checkpatch...
1787
1788
1789
1790
1791
  			if ($1 ne '++' && $1 ne '--') {
  				$type = 'N';
  			}
  
  		} elsif ($cur =~ /(^.)/o) {
c2fdda0df   Andy Whitcroft   update checkpatch...
1792
1793
  			print "C($1)
  " if ($dbg_values > 1);
6c72ffaab   Andy Whitcroft   update checkpatch...
1794
1795
1796
1797
1798
  		}
  		if (defined $1) {
  			$cur = substr($cur, length($1));
  			$res .= $type x length($1);
  		}
9c0ca6f9a   Andy Whitcroft   update checkpatch...
1799
  	}
0a920b5b6   Andy Whitcroft   add a trivial pat...
1800

1f65f947a   Andy Whitcroft   checkpatch: add c...
1801
  	return ($res, $var);
0a920b5b6   Andy Whitcroft   add a trivial pat...
1802
  }
8905a67c6   Andy Whitcroft   update checkpatch...
1803
  sub possible {
13214adf7   Andy Whitcroft   update checkpatch...
1804
  	my ($possible, $line) = @_;
9a974fdbe   Andy Whitcroft   checkpatch: possi...
1805
  	my $notPermitted = qr{(?:
0776e5946   Andy Whitcroft   checkpatch: do is...
1806
1807
1808
1809
  		^(?:
  			$Modifier|
  			$Storage|
  			$Type|
9a974fdbe   Andy Whitcroft   checkpatch: possi...
1810
1811
1812
  			DEFINE_\S+
  		)$|
  		^(?:
0776e5946   Andy Whitcroft   checkpatch: do is...
1813
1814
1815
1816
1817
  			goto|
  			return|
  			case|
  			else|
  			asm|__asm__|
89a883530   Andy Whitcroft   checkpatch: ## is...
1818
1819
1820
  			do|
  			\#|
  			\#\#|
9a974fdbe   Andy Whitcroft   checkpatch: possi...
1821
  		)(?:\s|$)|
0776e5946   Andy Whitcroft   checkpatch: do is...
1822
  		^(?:typedef|struct|enum)\b
9a974fdbe   Andy Whitcroft   checkpatch: possi...
1823
1824
1825
1826
  	    )}x;
  	warn "CHECK<$possible> ($line)
  " if ($dbg_possible > 2);
  	if ($possible !~ $notPermitted) {
c45dcabd2   Andy Whitcroft   update checkpatch...
1827
1828
1829
1830
1831
1832
1833
  		# Check for modifiers.
  		$possible =~ s/\s*$Storage\s*//g;
  		$possible =~ s/\s*$Sparse\s*//g;
  		if ($possible =~ /^\s*$/) {
  
  		} elsif ($possible =~ /\s/) {
  			$possible =~ s/\s*$Type\s*//g;
d25065865   Andy Whitcroft   checkpatch: possi...
1834
  			for my $modifier (split(' ', $possible)) {
9a974fdbe   Andy Whitcroft   checkpatch: possi...
1835
1836
1837
  				if ($modifier !~ $notPermitted) {
  					warn "MODIFIER: $modifier ($possible) ($line)
  " if ($dbg_possible);
485ff23ed   Alex Dowad   checkpatch: make ...
1838
  					push(@modifierListFile, $modifier);
9a974fdbe   Andy Whitcroft   checkpatch: possi...
1839
  				}
d25065865   Andy Whitcroft   checkpatch: possi...
1840
  			}
c45dcabd2   Andy Whitcroft   update checkpatch...
1841
1842
1843
1844
  
  		} else {
  			warn "POSSIBLE: $possible ($line)
  " if ($dbg_possible);
485ff23ed   Alex Dowad   checkpatch: make ...
1845
  			push(@typeListFile, $possible);
c45dcabd2   Andy Whitcroft   update checkpatch...
1846
  		}
8905a67c6   Andy Whitcroft   update checkpatch...
1847
  		build_types();
0776e5946   Andy Whitcroft   checkpatch: do is...
1848
1849
1850
  	} else {
  		warn "NOTPOSS: $possible ($line)
  " if ($dbg_possible > 1);
8905a67c6   Andy Whitcroft   update checkpatch...
1851
1852
  	}
  }
6c72ffaab   Andy Whitcroft   update checkpatch...
1853
  my $prefix = '';
000d1cc18   Joe Perches   checkpatch.pl: ad...
1854
  sub show_type {
cbec18afc   Joe Perches   checkpatch: use a...
1855
  	my ($type) = @_;
91bfe4843   Joe Perches   checkpatch: add -...
1856

cbec18afc   Joe Perches   checkpatch: use a...
1857
1858
1859
  	return defined $use_type{$type} if (scalar keys %use_type > 0);
  
  	return !defined $ignore_type{$type};
000d1cc18   Joe Perches   checkpatch.pl: ad...
1860
  }
f0a594c1c   Andy Whitcroft   update checkpatch...
1861
  sub report {
cbec18afc   Joe Perches   checkpatch: use a...
1862
1863
1864
1865
  	my ($level, $type, $msg) = @_;
  
  	if (!show_type($type) ||
  	    (defined $tst_only && $msg !~ /\Q$tst_only\E/)) {
773647a09   Andy Whitcroft   update checkpatch...
1866
1867
  		return 0;
  	}
572302971   Joe Perches   checkpatch: color...
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
  	my $output = '';
  	if (-t STDOUT && $color) {
  		if ($level eq 'ERROR') {
  			$output .= RED;
  		} elsif ($level eq 'WARNING') {
  			$output .= YELLOW;
  		} else {
  			$output .= GREEN;
  		}
  	}
  	$output .= $prefix . $level . ':';
000d1cc18   Joe Perches   checkpatch.pl: ad...
1879
  	if ($show_types) {
572302971   Joe Perches   checkpatch: color...
1880
1881
  		$output .= BLUE if (-t STDOUT && $color);
  		$output .= "$type:";
000d1cc18   Joe Perches   checkpatch.pl: ad...
1882
  	}
572302971   Joe Perches   checkpatch: color...
1883
1884
1885
  	$output .= RESET if (-t STDOUT && $color);
  	$output .= ' ' . $msg . "
  ";
34d8815f9   Joe Perches   checkpatch: add -...
1886
1887
1888
1889
1890
1891
1892
1893
  
  	if ($showfile) {
  		my @lines = split("
  ", $output, -1);
  		splice(@lines, 1, 1);
  		$output = join("
  ", @lines);
  	}
572302971   Joe Perches   checkpatch: color...
1894
1895
1896
  	$output = (split('
  ', $output))[0] . "
  " if ($terse);
8905a67c6   Andy Whitcroft   update checkpatch...
1897

572302971   Joe Perches   checkpatch: color...
1898
  	push(our @report, $output);
773647a09   Andy Whitcroft   update checkpatch...
1899
1900
  
  	return 1;
f0a594c1c   Andy Whitcroft   update checkpatch...
1901
  }
cbec18afc   Joe Perches   checkpatch: use a...
1902

f0a594c1c   Andy Whitcroft   update checkpatch...
1903
  sub report_dump {
13214adf7   Andy Whitcroft   update checkpatch...
1904
  	our @report;
f0a594c1c   Andy Whitcroft   update checkpatch...
1905
  }
000d1cc18   Joe Perches   checkpatch.pl: ad...
1906

d752fcc88   Joe Perches   checkpatch: add a...
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
  sub fixup_current_range {
  	my ($lineRef, $offset, $length) = @_;
  
  	if ($$lineRef =~ /^\@\@ -\d+,\d+ \+(\d+),(\d+) \@\@/) {
  		my $o = $1;
  		my $l = $2;
  		my $no = $o + $offset;
  		my $nl = $l + $length;
  		$$lineRef =~ s/\+$o,$l \@\@/\+$no,$nl \@\@/;
  	}
  }
  
  sub fix_inserted_deleted_lines {
  	my ($linesRef, $insertedRef, $deletedRef) = @_;
  
  	my $range_last_linenr = 0;
  	my $delta_offset = 0;
  
  	my $old_linenr = 0;
  	my $new_linenr = 0;
  
  	my $next_insert = 0;
  	my $next_delete = 0;
  
  	my @lines = ();
  
  	my $inserted = @{$insertedRef}[$next_insert++];
  	my $deleted = @{$deletedRef}[$next_delete++];
  
  	foreach my $old_line (@{$linesRef}) {
  		my $save_line = 1;
  		my $line = $old_line;	#don't modify the array
323b267fa   Joe Perches   checkpatch: fix -...
1939
  		if ($line =~ /^(?:\+\+\+|\-\-\-)\s+\S+/) {	#new filename
d752fcc88   Joe Perches   checkpatch: add a...
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
  			$delta_offset = 0;
  		} elsif ($line =~ /^\@\@ -\d+,\d+ \+\d+,\d+ \@\@/) {	#new hunk
  			$range_last_linenr = $new_linenr;
  			fixup_current_range(\$line, $delta_offset, 0);
  		}
  
  		while (defined($deleted) && ${$deleted}{'LINENR'} == $old_linenr) {
  			$deleted = @{$deletedRef}[$next_delete++];
  			$save_line = 0;
  			fixup_current_range(\$lines[$range_last_linenr], $delta_offset--, -1);
  		}
  
  		while (defined($inserted) && ${$inserted}{'LINENR'} == $old_linenr) {
  			push(@lines, ${$inserted}{'LINE'});
  			$inserted = @{$insertedRef}[$next_insert++];
  			$new_linenr++;
  			fixup_current_range(\$lines[$range_last_linenr], $delta_offset++, 1);
  		}
  
  		if ($save_line) {
  			push(@lines, $line);
  			$new_linenr++;
  		}
  
  		$old_linenr++;
  	}
  
  	return @lines;
  }
f2d7e4d43   Joe Perches   checkpatch: add f...
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
  sub fix_insert_line {
  	my ($linenr, $line) = @_;
  
  	my $inserted = {
  		LINENR => $linenr,
  		LINE => $line,
  	};
  	push(@fixed_inserted, $inserted);
  }
  
  sub fix_delete_line {
  	my ($linenr, $line) = @_;
  
  	my $deleted = {
  		LINENR => $linenr,
  		LINE => $line,
  	};
  
  	push(@fixed_deleted, $deleted);
  }
de7d4f0e1   Andy Whitcroft   update checkpatch...
1989
  sub ERROR {
cbec18afc   Joe Perches   checkpatch: use a...
1990
1991
1992
  	my ($type, $msg) = @_;
  
  	if (report("ERROR", $type, $msg)) {
773647a09   Andy Whitcroft   update checkpatch...
1993
1994
  		our $clean = 0;
  		our $cnt_error++;
3705ce5bc   Joe Perches   checkpatch: creat...
1995
  		return 1;
773647a09   Andy Whitcroft   update checkpatch...
1996
  	}
3705ce5bc   Joe Perches   checkpatch: creat...
1997
  	return 0;
de7d4f0e1   Andy Whitcroft   update checkpatch...
1998
1999
  }
  sub WARN {
cbec18afc   Joe Perches   checkpatch: use a...
2000
2001
2002
  	my ($type, $msg) = @_;
  
  	if (report("WARNING", $type, $msg)) {
773647a09   Andy Whitcroft   update checkpatch...
2003
2004
  		our $clean = 0;
  		our $cnt_warn++;
3705ce5bc   Joe Perches   checkpatch: creat...
2005
  		return 1;
773647a09   Andy Whitcroft   update checkpatch...
2006
  	}
3705ce5bc   Joe Perches   checkpatch: creat...
2007
  	return 0;
de7d4f0e1   Andy Whitcroft   update checkpatch...
2008
2009
  }
  sub CHK {
cbec18afc   Joe Perches   checkpatch: use a...
2010
2011
2012
  	my ($type, $msg) = @_;
  
  	if ($check && report("CHECK", $type, $msg)) {
6c72ffaab   Andy Whitcroft   update checkpatch...
2013
2014
  		our $clean = 0;
  		our $cnt_chk++;
3705ce5bc   Joe Perches   checkpatch: creat...
2015
  		return 1;
6c72ffaab   Andy Whitcroft   update checkpatch...
2016
  	}
3705ce5bc   Joe Perches   checkpatch: creat...
2017
  	return 0;
de7d4f0e1   Andy Whitcroft   update checkpatch...
2018
  }
6ecd96744   Andy Whitcroft   checkpatch: repor...
2019
2020
2021
2022
2023
2024
2025
2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
  sub check_absolute_file {
  	my ($absolute, $herecurr) = @_;
  	my $file = $absolute;
  
  	##print "absolute<$absolute>
  ";
  
  	# See if any suffix of this path is a path within the tree.
  	while ($file =~ s@^[^/]*/@@) {
  		if (-f "$root/$file") {
  			##print "file<$file>
  ";
  			last;
  		}
  	}
  	if (! -f _)  {
  		return 0;
  	}
  
  	# It is, so see if the prefix is acceptable.
  	my $prefix = $absolute;
  	substr($prefix, -length($file)) = '';
  
  	##print "prefix<$prefix>
  ";
  	if ($prefix ne ".../") {
000d1cc18   Joe Perches   checkpatch.pl: ad...
2045
2046
2047
  		WARN("USE_RELATIVE_PATH",
  		     "use relative pathname instead of absolute in changelog text
  " . $herecurr);
6ecd96744   Andy Whitcroft   checkpatch: repor...
2048
2049
  	}
  }
3705ce5bc   Joe Perches   checkpatch: creat...
2050
2051
  sub trim {
  	my ($string) = @_;
b34c648bb   Joe Perches   checkpatch: bette...
2052
2053
2054
2055
2056
2057
2058
2059
2060
2061
2062
2063
2064
2065
2066
2067
2068
  	$string =~ s/^\s+|\s+$//g;
  
  	return $string;
  }
  
  sub ltrim {
  	my ($string) = @_;
  
  	$string =~ s/^\s+//;
  
  	return $string;
  }
  
  sub rtrim {
  	my ($string) = @_;
  
  	$string =~ s/\s+$//;
3705ce5bc   Joe Perches   checkpatch: creat...
2069
2070
2071
  
  	return $string;
  }
52ea85061   Joe Perches   checkpatch: add t...
2072
2073
2074
2075
2076
2077
2078
  sub string_find_replace {
  	my ($string, $find, $replace) = @_;
  
  	$string =~ s/$find/$replace/g;
  
  	return $string;
  }
3705ce5bc   Joe Perches   checkpatch: creat...
2079
2080
2081
2082
2083
2084
2085
2086
2087
2088
2089
2090
2091
2092
  sub tabify {
  	my ($leading) = @_;
  
  	my $source_indent = 8;
  	my $max_spaces_before_tab = $source_indent - 1;
  	my $spaces_to_tab = " " x $source_indent;
  
  	#convert leading spaces to tabs
  	1 while $leading =~ s@^([\t]*)$spaces_to_tab@$1\t@g;
  	#Remove spaces before a tab
  	1 while $leading =~ s@^([\t]*)( {1,$max_spaces_before_tab})\t@$1\t@g;
  
  	return "$leading";
  }
d1fe9c099   Joe Perches   checkpatch: add s...
2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2112
2113
2114
2115
2116
2117
2118
  sub pos_last_openparen {
  	my ($line) = @_;
  
  	my $pos = 0;
  
  	my $opens = $line =~ tr/\(/\(/;
  	my $closes = $line =~ tr/\)/\)/;
  
  	my $last_openparen = 0;
  
  	if (($opens == 0) || ($closes >= $opens)) {
  		return -1;
  	}
  
  	my $len = length($line);
  
  	for ($pos = 0; $pos < $len; $pos++) {
  		my $string = substr($line, $pos);
  		if ($string =~ /^($FuncArg|$balanced_parens)/) {
  			$pos += length($1) - 1;
  		} elsif (substr($line, $pos, 1) eq '(') {
  			$last_openparen = $pos;
  		} elsif (index($string, '(') == -1) {
  			last;
  		}
  	}
91cb5195f   Joe Perches   checkpatch: expan...
2119
  	return length(expand_tabs(substr($line, 0, $last_openparen))) + 1;
d1fe9c099   Joe Perches   checkpatch: add s...
2120
  }
0a920b5b6   Andy Whitcroft   add a trivial pat...
2121
2122
  sub process {
  	my $filename = shift;
0a920b5b6   Andy Whitcroft   add a trivial pat...
2123
2124
2125
  
  	my $linenr=0;
  	my $prevline="";
c2fdda0df   Andy Whitcroft   update checkpatch...
2126
  	my $prevrawline="";
0a920b5b6   Andy Whitcroft   add a trivial pat...
2127
  	my $stashline="";
c2fdda0df   Andy Whitcroft   update checkpatch...
2128
  	my $stashrawline="";
0a920b5b6   Andy Whitcroft   add a trivial pat...
2129

4a0df2ef4   Andy Whitcroft   update checkpatch...
2130
  	my $length;
0a920b5b6   Andy Whitcroft   add a trivial pat...
2131
2132
2133
  	my $indent;
  	my $previndent=0;
  	my $stashindent=0;
de7d4f0e1   Andy Whitcroft   update checkpatch...
2134
  	our $clean = 1;
0a920b5b6   Andy Whitcroft   add a trivial pat...
2135
2136
  	my $signoff = 0;
  	my $is_patch = 0;
29ee1b0c6   Joe Perches   checkpatch: ignor...
2137
  	my $in_header_lines = $file ? 0 : 1;
15662b3e8   Joe Perches   checkpatch: add a...
2138
  	my $in_commit_log = 0;		#Scanning lines before patch
ed43c4e58   Allen Hubbe   checkpatch: check...
2139
  	my $has_commit_log = 0;		#Encountered lines before patch
bf4daf12a   Joe Perches   checkpatch: avoid...
2140
         my $commit_log_possible_stack_dump = 0;
2a076f40d   Joe Perches   checkpatch, Submi...
2141
  	my $commit_log_long_line = 0;
e518e9a59   Joe Perches   checkpatch: emit ...
2142
  	my $commit_log_has_diff = 0;
13f1937ef   Joe Perches   checkpatch: emit ...
2143
  	my $reported_maintainer_file = 0;
fa64205df   Pasi Savanainen   checkpatch: check...
2144
  	my $non_utf8_charset = 0;
365dd4eaa   Joe Perches   checkpatch: add a...
2145
  	my $last_blank_line = 0;
5e4f6ba5e   Joe Perches   checkpatch: add a...
2146
  	my $last_coalesced_string_linenr = -1;
365dd4eaa   Joe Perches   checkpatch: add a...
2147

13214adf7   Andy Whitcroft   update checkpatch...
2148
  	our @report = ();
6c72ffaab   Andy Whitcroft   update checkpatch...
2149
2150
2151
2152
  	our $cnt_lines = 0;
  	our $cnt_error = 0;
  	our $cnt_warn = 0;
  	our $cnt_chk = 0;
0a920b5b6   Andy Whitcroft   add a trivial pat...
2153
2154
2155
2156
2157
2158
  	# Trace the real file/line as we go.
  	my $realfile = '';
  	my $realline = 0;
  	my $realcnt = 0;
  	my $here = '';
  	my $in_comment = 0;
c2fdda0df   Andy Whitcroft   update checkpatch...
2159
  	my $comment_edge = 0;
0a920b5b6   Andy Whitcroft   add a trivial pat...
2160
  	my $first_line = 0;
1e8557269   Wolfram Sang   checkpatch: Add w...
2161
  	my $p1_prefix = '';
0a920b5b6   Andy Whitcroft   add a trivial pat...
2162

13214adf7   Andy Whitcroft   update checkpatch...
2163
2164
2165
  	my $prev_values = 'E';
  
  	# suppression flags
773647a09   Andy Whitcroft   update checkpatch...
2166
  	my %suppress_ifbraces;
170d3a226   Andy Whitcroft   checkpatch: handl...
2167
  	my %suppress_whiletrailers;
2b474a1a5   Andy Whitcroft   checkpatch: fix f...
2168
  	my %suppress_export;
3e469cdc0   Andy Whitcroft   checkpatch: optim...
2169
  	my $suppress_statement = 0;
653d4876b   Andy Whitcroft   update checkpatch...
2170

7e51f1979   Joe Perches   checkpatch: check...
2171
  	my %signatures = ();
323c1260b   Joe Perches   checkpatch: warn ...
2172

c2fdda0df   Andy Whitcroft   update checkpatch...
2173
  	# Pre-scan the patch sanitizing the lines.
de7d4f0e1   Andy Whitcroft   update checkpatch...
2174
  	# Pre-scan the patch looking for any __setup documentation.
c2fdda0df   Andy Whitcroft   update checkpatch...
2175
  	#
de7d4f0e1   Andy Whitcroft   update checkpatch...
2176
2177
  	my @setup_docs = ();
  	my $setup_docs = 0;
773647a09   Andy Whitcroft   update checkpatch...
2178

d8b077101   Joe Perches   checkpatch: exten...
2179
  	my $camelcase_file_seeded = 0;
773647a09   Andy Whitcroft   update checkpatch...
2180
  	sanitise_line_reset();
c2fdda0df   Andy Whitcroft   update checkpatch...
2181
2182
  	my $line;
  	foreach my $rawline (@rawlines) {
773647a09   Andy Whitcroft   update checkpatch...
2183
2184
  		$linenr++;
  		$line = $rawline;
c2fdda0df   Andy Whitcroft   update checkpatch...
2185

3705ce5bc   Joe Perches   checkpatch: creat...
2186
  		push(@fixed, $rawline) if ($fix);
773647a09   Andy Whitcroft   update checkpatch...
2187
  		if ($rawline=~/^\+\+\+\s+(\S+)/) {
de7d4f0e1   Andy Whitcroft   update checkpatch...
2188
2189
2190
2191
  			$setup_docs = 0;
  			if ($1 =~ m@Documentation/kernel-parameters.txt$@) {
  				$setup_docs = 1;
  			}
773647a09   Andy Whitcroft   update checkpatch...
2192
2193
2194
2195
2196
2197
2198
2199
2200
  			#next;
  		}
  		if ($rawline=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
  			$realline=$1-1;
  			if (defined $2) {
  				$realcnt=$3+1;
  			} else {
  				$realcnt=1+1;
  			}
c45dcabd2   Andy Whitcroft   update checkpatch...
2201
  			$in_comment = 0;
773647a09   Andy Whitcroft   update checkpatch...
2202
2203
2204
2205
2206
2207
  
  			# Guestimate if this is a continuing comment.  Run
  			# the context looking for a comment "edge".  If this
  			# edge is a close comment then we must be in a comment
  			# at context start.
  			my $edge;
01fa91471   Andy Whitcroft   checkpatch: fix u...
2208
2209
2210
2211
2212
2213
2214
  			my $cnt = $realcnt;
  			for (my $ln = $linenr + 1; $cnt > 0; $ln++) {
  				next if (defined $rawlines[$ln - 1] &&
  					 $rawlines[$ln - 1] =~ /^-/);
  				$cnt--;
  				#print "RAW<$rawlines[$ln - 1]>
  ";
721c1cb60   Andy Whitcroft   checkpatch: comme...
2215
  				last if (!defined $rawlines[$ln - 1]);
fae17daed   Andy Whitcroft   checkpatch: comme...
2216
2217
2218
2219
2220
  				if ($rawlines[$ln - 1] =~ m@(/\*|\*/)@ &&
  				    $rawlines[$ln - 1] !~ m@"[^"]*(?:/\*|\*/)[^"]*"@) {
  					($edge) = $1;
  					last;
  				}
773647a09   Andy Whitcroft   update checkpatch...
2221
2222
2223
2224
2225
2226
2227
2228
2229
  			}
  			if (defined $edge && $edge eq '*/') {
  				$in_comment = 1;
  			}
  
  			# Guestimate if this is a continuing comment.  If this
  			# is the start of a diff block and this line starts
  			# ' *' then it is very likely a comment.
  			if (!defined $edge &&
83242e0c2   Andy Whitcroft   checkpatch: widen...
2230
  			    $rawlines[$linenr] =~ m@^.\s*(?:\*\*+| \*)(?:\s|$)@)
773647a09   Andy Whitcroft   update checkpatch...
2231
2232
2233
2234
2235
2236
2237
  			{
  				$in_comment = 1;
  			}
  
  			##print "COMMENT:$in_comment edge<$edge> $rawline
  ";
  			sanitise_line_reset($in_comment);
171ae1a49   Andy Whitcroft   update checkpatch...
2238
  		} elsif ($realcnt && $rawline =~ /^(?:\+| |$)/) {
773647a09   Andy Whitcroft   update checkpatch...
2239
  			# Standardise the strings and chars within the input to
171ae1a49   Andy Whitcroft   update checkpatch...
2240
  			# simplify matching -- only bother with positive lines.
773647a09   Andy Whitcroft   update checkpatch...
2241
  			$line = sanitise_line($rawline);
de7d4f0e1   Andy Whitcroft   update checkpatch...
2242
  		}
773647a09   Andy Whitcroft   update checkpatch...
2243
2244
2245
2246
2247
2248
2249
2250
2251
2252
2253
2254
  		push(@lines, $line);
  
  		if ($realcnt > 1) {
  			$realcnt-- if ($line =~ /^(?:\+| |$)/);
  		} else {
  			$realcnt = 0;
  		}
  
  		#print "==>$rawline
  ";
  		#print "-->$line
  ";
de7d4f0e1   Andy Whitcroft   update checkpatch...
2255
2256
2257
2258
2259
  
  		if ($setup_docs && $line =~ /^\+/) {
  			push(@setup_docs, $line);
  		}
  	}
6c72ffaab   Andy Whitcroft   update checkpatch...
2260
  	$prefix = '';
773647a09   Andy Whitcroft   update checkpatch...
2261
2262
  	$realcnt = 0;
  	$linenr = 0;
194f66fc9   Joe Perches   checkpatch: add a...
2263
  	$fixlinenr = -1;
0a920b5b6   Andy Whitcroft   add a trivial pat...
2264
2265
  	foreach my $line (@lines) {
  		$linenr++;
194f66fc9   Joe Perches   checkpatch: add a...
2266
  		$fixlinenr++;
1b5539b1f   Joe Perches   checkpatch: reduc...
2267
2268
  		my $sline = $line;	#copy of $line
  		$sline =~ s/$;/ /g;	#with comments as spaces
0a920b5b6   Andy Whitcroft   add a trivial pat...
2269

c2fdda0df   Andy Whitcroft   update checkpatch...
2270
  		my $rawline = $rawlines[$linenr - 1];
6c72ffaab   Andy Whitcroft   update checkpatch...
2271

0a920b5b6   Andy Whitcroft   add a trivial pat...
2272
  #extract the line range in the file after the patch is applied
e518e9a59   Joe Perches   checkpatch: emit ...
2273
2274
  		if (!$in_commit_log &&
  		    $line =~ /^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
0a920b5b6   Andy Whitcroft   add a trivial pat...
2275
  			$is_patch = 1;
4a0df2ef4   Andy Whitcroft   update checkpatch...
2276
  			$first_line = $linenr + 1;
0a920b5b6   Andy Whitcroft   add a trivial pat...
2277
2278
2279
2280
2281
2282
  			$realline=$1-1;
  			if (defined $2) {
  				$realcnt=$3+1;
  			} else {
  				$realcnt=1+1;
  			}
c2fdda0df   Andy Whitcroft   update checkpatch...
2283
  			annotate_reset();
13214adf7   Andy Whitcroft   update checkpatch...
2284
  			$prev_values = 'E';
773647a09   Andy Whitcroft   update checkpatch...
2285
  			%suppress_ifbraces = ();
170d3a226   Andy Whitcroft   checkpatch: handl...
2286
  			%suppress_whiletrailers = ();
2b474a1a5   Andy Whitcroft   checkpatch: fix f...
2287
  			%suppress_export = ();
3e469cdc0   Andy Whitcroft   checkpatch: optim...
2288
  			$suppress_statement = 0;
0a920b5b6   Andy Whitcroft   add a trivial pat...
2289
  			next;
0a920b5b6   Andy Whitcroft   add a trivial pat...
2290

4a0df2ef4   Andy Whitcroft   update checkpatch...
2291
2292
2293
  # track the line number as we move through the hunk, note that
  # new versions of GNU diff omit the leading space on completely
  # blank context lines so we need to count that too.
773647a09   Andy Whitcroft   update checkpatch...
2294
  		} elsif ($line =~ /^( |\+|$)/) {
0a920b5b6   Andy Whitcroft   add a trivial pat...
2295
  			$realline++;
d8aaf1214   Andy Whitcroft   update checkpatch...
2296
  			$realcnt-- if ($realcnt != 0);
0a920b5b6   Andy Whitcroft   add a trivial pat...
2297

4a0df2ef4   Andy Whitcroft   update checkpatch...
2298
  			# Measure the line length and indent.
c2fdda0df   Andy Whitcroft   update checkpatch...
2299
  			($length, $indent) = line_stats($rawline);
0a920b5b6   Andy Whitcroft   add a trivial pat...
2300
2301
2302
2303
  
  			# Track the previous line.
  			($prevline, $stashline) = ($stashline, $line);
  			($previndent, $stashindent) = ($stashindent, $indent);
c2fdda0df   Andy Whitcroft   update checkpatch...
2304
  			($prevrawline, $stashrawline) = ($stashrawline, $rawline);
773647a09   Andy Whitcroft   update checkpatch...
2305
2306
  			#warn "line<$line>
  ";
6c72ffaab   Andy Whitcroft   update checkpatch...
2307

d8aaf1214   Andy Whitcroft   update checkpatch...
2308
2309
  		} elsif ($realcnt == 1) {
  			$realcnt--;
0a920b5b6   Andy Whitcroft   add a trivial pat...
2310
  		}
cc77cdca5   Andy Whitcroft   checkpatch: corre...
2311
  		my $hunk_line = ($realcnt != 0);
6c72ffaab   Andy Whitcroft   update checkpatch...
2312
2313
  		$here = "#$linenr: " if (!$file);
  		$here = "#$realline: " if ($file);
773647a09   Andy Whitcroft   update checkpatch...
2314

2ac73b4f6   Joe Perches   checkpatch: make ...
2315
  		my $found_file = 0;
773647a09   Andy Whitcroft   update checkpatch...
2316
  		# extract the filename as it passes
3bf9a009f   Rabin Vincent   checkpatch: check...
2317
2318
  		if ($line =~ /^diff --git.*?(\S+)$/) {
  			$realfile = $1;
2b7ab4539   Joe Perches   checkpatch: don't...
2319
  			$realfile =~ s@^([^/]*)/@@ if (!$file);
270c49a08   Joe Perches   checkpatch: updat...
2320
  			$in_commit_log = 0;
2ac73b4f6   Joe Perches   checkpatch: make ...
2321
  			$found_file = 1;
3bf9a009f   Rabin Vincent   checkpatch: check...
2322
  		} elsif ($line =~ /^\+\+\+\s+(\S+)/) {
773647a09   Andy Whitcroft   update checkpatch...
2323
  			$realfile = $1;
2b7ab4539   Joe Perches   checkpatch: don't...
2324
  			$realfile =~ s@^([^/]*)/@@ if (!$file);
270c49a08   Joe Perches   checkpatch: updat...
2325
  			$in_commit_log = 0;
1e8557269   Wolfram Sang   checkpatch: Add w...
2326
2327
  
  			$p1_prefix = $1;
e2f7aa4b8   Andy Whitcroft   checkpatch: do no...
2328
2329
  			if (!$file && $tree && $p1_prefix ne '' &&
  			    -e "$root/$p1_prefix") {
000d1cc18   Joe Perches   checkpatch.pl: ad...
2330
2331
2332
  				WARN("PATCH_PREFIX",
  				     "patch prefix '$p1_prefix' exists, appears to be a -p0 patch
  ");
1e8557269   Wolfram Sang   checkpatch: Add w...
2333
  			}
773647a09   Andy Whitcroft   update checkpatch...
2334

c1ab33269   Andy Whitcroft   checkpatch: inclu...
2335
  			if ($realfile =~ m@^include/asm/@) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
2336
2337
2338
2339
  				ERROR("MODIFIED_INCLUDE_ASM",
  				      "do not modify files in include/asm, change architecture specific files in include/asm-<architecture>
  " . "$here$rawline
  ");
773647a09   Andy Whitcroft   update checkpatch...
2340
  			}
2ac73b4f6   Joe Perches   checkpatch: make ...
2341
2342
  			$found_file = 1;
  		}
34d8815f9   Joe Perches   checkpatch: add -...
2343
2344
2345
2346
  #make up the handle for any error we report on this line
  		if ($showfile) {
  			$prefix = "$realfile:$realline: "
  		} elsif ($emacs) {
7d3a9f673   Joe Perches   checkpatch: repor...
2347
2348
2349
2350
2351
  			if ($file) {
  				$prefix = "$filename:$realline: ";
  			} else {
  				$prefix = "$filename:$linenr: ";
  			}
34d8815f9   Joe Perches   checkpatch: add -...
2352
  		}
2ac73b4f6   Joe Perches   checkpatch: make ...
2353
  		if ($found_file) {
85b0ee18b   Joe Perches   checkpatch: see i...
2354
2355
2356
2357
2358
  			if (is_maintained_obsolete($realfile)) {
  				WARN("OBSOLETE",
  				     "$realfile is marked as 'obsolete' in the MAINTAINERS hierarchy.  No unnecessary modifications please.
  ");
  			}
7bd7e483c   Joe Perches   checkpatch: make ...
2359
  			if ($realfile =~ m@^(?:drivers/net/|net/|drivers/staging/)@) {
2ac73b4f6   Joe Perches   checkpatch: make ...
2360
2361
2362
2363
  				$check = 1;
  			} else {
  				$check = $check_orig;
  			}
773647a09   Andy Whitcroft   update checkpatch...
2364
2365
  			next;
  		}
389834b68   Randy Dunlap   checkpatch: produ...
2366
  		$here .= "FILE: $realfile:$realline:" if ($realcnt != 0);
0a920b5b6   Andy Whitcroft   add a trivial pat...
2367

c2fdda0df   Andy Whitcroft   update checkpatch...
2368
2369
2370
2371
2372
2373
2374
2375
2376
2377
  		my $hereline = "$here
  $rawline
  ";
  		my $herecurr = "$here
  $rawline
  ";
  		my $hereprev = "$here
  $prevrawline
  $rawline
  ";
0a920b5b6   Andy Whitcroft   add a trivial pat...
2378

6c72ffaab   Andy Whitcroft   update checkpatch...
2379
  		$cnt_lines++ if ($realcnt != 0);
e518e9a59   Joe Perches   checkpatch: emit ...
2380
2381
2382
2383
2384
2385
2386
2387
2388
2389
2390
  # Check if the commit log has what seems like a diff which can confuse patch
  		if ($in_commit_log && !$commit_log_has_diff &&
  		    (($line =~ m@^\s+diff\b.*a/[\w/]+@ &&
  		      $line =~ m@^\s+diff\b.*a/([\w/]+)\s+b/$1\b@) ||
  		     $line =~ m@^\s*(?:\-\-\-\s+a/|\+\+\+\s+b/)@ ||
  		     $line =~ m/^\s*\@\@ \-\d+,\d+ \+\d+,\d+ \@\@/)) {
  			ERROR("DIFF_IN_COMMIT_MSG",
  			      "Avoid using diff content in the commit message - patch(1) might not work
  " . $herecurr);
  			$commit_log_has_diff = 1;
  		}
3bf9a009f   Rabin Vincent   checkpatch: check...
2391
2392
2393
2394
  # Check for incorrect file permissions
  		if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) {
  			my $permhere = $here . "FILE: $realfile
  ";
04db4d25d   Joe Perches   checkpatch: compl...
2395
2396
  			if ($realfile !~ m@scripts/@ &&
  			    $realfile !~ /\.(py|pl|awk|sh)$/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
2397
2398
2399
  				ERROR("EXECUTE_PERMISSIONS",
  				      "do not set execute permissions for source files
  " . $permhere);
3bf9a009f   Rabin Vincent   checkpatch: check...
2400
2401
  			}
  		}
201124755   Joe Perches   checkpatch: valid...
2402
  # Check the patch for a signoff:
d8aaf1214   Andy Whitcroft   update checkpatch...
2403
  		if ($line =~ /^\s*signed-off-by:/i) {
4a0df2ef4   Andy Whitcroft   update checkpatch...
2404
  			$signoff++;
15662b3e8   Joe Perches   checkpatch: add a...
2405
  			$in_commit_log = 0;
201124755   Joe Perches   checkpatch: valid...
2406
  		}
e0d975b1b   Joe Perches   checkpatch: reduc...
2407
2408
2409
2410
2411
  # Check if MAINTAINERS is being updated.  If so, there's probably no need to
  # emit the "does MAINTAINERS need updating?" message on file add/move/delete
  		if ($line =~ /^\s*MAINTAINERS\s*\|/) {
  			$reported_maintainer_file = 1;
  		}
201124755   Joe Perches   checkpatch: valid...
2412
  # Check signature styles
270c49a08   Joe Perches   checkpatch: updat...
2413
  		if (!$in_header_lines &&
ce0338df3   Joe Perches   checkpatch: test ...
2414
  		    $line =~ /^(\s*)([a-z0-9_-]+by:|$signature_tags)(\s*)(.*)/i) {
201124755   Joe Perches   checkpatch: valid...
2415
2416
2417
2418
2419
  			my $space_before = $1;
  			my $sign_off = $2;
  			my $space_after = $3;
  			my $email = $4;
  			my $ucfirst_sign_off = ucfirst(lc($sign_off));
ce0338df3   Joe Perches   checkpatch: test ...
2420
2421
2422
2423
2424
  			if ($sign_off !~ /$signature_tags/) {
  				WARN("BAD_SIGN_OFF",
  				     "Non-standard signature: $sign_off
  " . $herecurr);
  			}
201124755   Joe Perches   checkpatch: valid...
2425
  			if (defined $space_before && $space_before ne "") {
3705ce5bc   Joe Perches   checkpatch: creat...
2426
2427
2428
2429
  				if (WARN("BAD_SIGN_OFF",
  					 "Do not use whitespace before $ucfirst_sign_off
  " . $herecurr) &&
  				    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
2430
  					$fixed[$fixlinenr] =
3705ce5bc   Joe Perches   checkpatch: creat...
2431
2432
  					    "$ucfirst_sign_off $email";
  				}
201124755   Joe Perches   checkpatch: valid...
2433
2434
  			}
  			if ($sign_off =~ /-by:$/i && $sign_off ne $ucfirst_sign_off) {
3705ce5bc   Joe Perches   checkpatch: creat...
2435
2436
2437
2438
  				if (WARN("BAD_SIGN_OFF",
  					 "'$ucfirst_sign_off' is the preferred signature form
  " . $herecurr) &&
  				    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
2439
  					$fixed[$fixlinenr] =
3705ce5bc   Joe Perches   checkpatch: creat...
2440
2441
  					    "$ucfirst_sign_off $email";
  				}
201124755   Joe Perches   checkpatch: valid...
2442
2443
  			}
  			if (!defined $space_after || $space_after ne " ") {
3705ce5bc   Joe Perches   checkpatch: creat...
2444
2445
2446
2447
  				if (WARN("BAD_SIGN_OFF",
  					 "Use a single space after $ucfirst_sign_off
  " . $herecurr) &&
  				    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
2448
  					$fixed[$fixlinenr] =
3705ce5bc   Joe Perches   checkpatch: creat...
2449
2450
  					    "$ucfirst_sign_off $email";
  				}
0a920b5b6   Andy Whitcroft   add a trivial pat...
2451
  			}
201124755   Joe Perches   checkpatch: valid...
2452
2453
2454
2455
  
  			my ($email_name, $email_address, $comment) = parse_email($email);
  			my $suggested_email = format_email(($email_name, $email_address));
  			if ($suggested_email eq "") {
000d1cc18   Joe Perches   checkpatch.pl: ad...
2456
2457
2458
  				ERROR("BAD_SIGN_OFF",
  				      "Unrecognized email address: '$email'
  " . $herecurr);
201124755   Joe Perches   checkpatch: valid...
2459
2460
2461
2462
2463
2464
2465
2466
2467
  			} else {
  				my $dequoted = $suggested_email;
  				$dequoted =~ s/^"//;
  				$dequoted =~ s/" </ </;
  				# Don't force email to have quotes
  				# Allow just an angle bracketed address
  				if ("$dequoted$comment" ne $email &&
  				    "<$email_address>$comment" ne $email &&
  				    "$suggested_email$comment" ne $email) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
2468
2469
2470
  					WARN("BAD_SIGN_OFF",
  					     "email address '$email' might be better as '$suggested_email$comment'
  " . $herecurr);
201124755   Joe Perches   checkpatch: valid...
2471
  				}
0a920b5b6   Andy Whitcroft   add a trivial pat...
2472
  			}
7e51f1979   Joe Perches   checkpatch: check...
2473
2474
2475
2476
2477
2478
2479
2480
2481
2482
2483
2484
  
  # Check for duplicate signatures
  			my $sig_nospace = $line;
  			$sig_nospace =~ s/\s//g;
  			$sig_nospace = lc($sig_nospace);
  			if (defined $signatures{$sig_nospace}) {
  				WARN("BAD_SIGN_OFF",
  				     "Duplicate signature
  " . $herecurr);
  			} else {
  				$signatures{$sig_nospace} = 1;
  			}
0a920b5b6   Andy Whitcroft   add a trivial pat...
2485
  		}
a2fe16b9d   Joe Perches   checkpatch: try t...
2486
2487
2488
2489
2490
2491
2492
  # Check email subject for common tools that don't need to be mentioned
  		if ($in_header_lines &&
  		    $line =~ /^Subject:.*\b(?:checkpatch|sparse|smatch)\b[^:]/i) {
  			WARN("EMAIL_SUBJECT",
  			     "A patch subject line should describe the change not the tool that found it
  " . $herecurr);
  		}
9b3189eb4   Joe Perches   checkpatch: check...
2493
2494
2495
2496
2497
2498
  # Check for old stable address
  		if ($line =~ /^\s*cc:\s*.*<?\bstable\@kernel\.org\b>?.*$/i) {
  			ERROR("STABLE_ADDRESS",
  			      "The 'stable' address should be 'stable\@vger.kernel.org'
  " . $herecurr);
  		}
7ebd05ef1   Christopher Covington   checkpatch.pl: ad...
2499
2500
2501
2502
2503
2504
  # Check for unwanted Gerrit info
  		if ($in_commit_log && $line =~ /^\s*change-id:/i) {
  			ERROR("GERRIT_CHANGE_ID",
  			      "Remove Gerrit Change-Id's before submitting upstream.
  " . $herecurr);
  		}
369c8dd39   Joe Perches   checkpatch: impro...
2505
2506
2507
2508
2509
2510
2511
2512
2513
  # Check if the commit log is in a possible stack dump
  		if ($in_commit_log && !$commit_log_possible_stack_dump &&
  		    ($line =~ /^\s*(?:WARNING:|BUG:)/ ||
  		     $line =~ /^\s*\[\s*\d+\.\d{6,6}\s*\]/ ||
  					# timestamp
  		     $line =~ /^\s*\[\<[0-9a-fA-F]{8,}\>\]/)) {
  					# stack dump address
  			$commit_log_possible_stack_dump = 1;
  		}
2a076f40d   Joe Perches   checkpatch, Submi...
2514
2515
  # Check for line lengths > 75 in commit log, warn once
  		if ($in_commit_log && !$commit_log_long_line &&
369c8dd39   Joe Perches   checkpatch: impro...
2516
2517
2518
2519
2520
2521
2522
2523
  		    length($line) > 75 &&
  		    !($line =~ /^\s*[a-zA-Z0-9_\/\.]+\s+\|\s+\d+/ ||
  					# file delta changes
  		      $line =~ /^\s*(?:[\w\.\-]+\/)++[\w\.\-]+:/ ||
  					# filename then :
  		      $line =~ /^\s*(?:Fixes:|Link:)/i ||
  					# A Fixes: or Link: line
  		      $commit_log_possible_stack_dump)) {
2a076f40d   Joe Perches   checkpatch, Submi...
2524
2525
2526
2527
2528
  			WARN("COMMIT_LOG_LONG_LINE",
  			     "Possible unwrapped commit description (prefer a maximum 75 chars per line)
  " . $herecurr);
  			$commit_log_long_line = 1;
  		}
bf4daf12a   Joe Perches   checkpatch: avoid...
2529
  # Reset possible stack dump if a blank line is found
369c8dd39   Joe Perches   checkpatch: impro...
2530
2531
2532
2533
  		if ($in_commit_log && $commit_log_possible_stack_dump &&
  		    $line =~ /^\s*$/) {
  			$commit_log_possible_stack_dump = 0;
  		}
bf4daf12a   Joe Perches   checkpatch: avoid...
2534

0d7835fca   Joe Perches   checkpatch: updat...
2535
  # Check for git id commit length and improperly formed commit descriptions
369c8dd39   Joe Perches   checkpatch: impro...
2536
  		if ($in_commit_log && !$commit_log_possible_stack_dump &&
aab38f516   Joe Perches   checkpatch: yet a...
2537
  		    $line !~ /^\s*(?:Link|Patchwork|http|https|BugLink):/i &&
fe043ea12   Joe Perches   checkpatch: warn ...
2538
  		    ($line =~ /\bcommit\s+[0-9a-f]{5,}\b/i ||
aab38f516   Joe Perches   checkpatch: yet a...
2539
  		     ($line =~ /(?:\s|^)[0-9a-f]{12,40}(?:[\s"'\(\[]|$)/i &&
369c8dd39   Joe Perches   checkpatch: impro...
2540
2541
  		      $line !~ /[\<\[][0-9a-f]{12,40}[\>\]]/i &&
  		      $line !~ /\bfixes:\s*[0-9a-f]{12,40}/i))) {
fe043ea12   Joe Perches   checkpatch: warn ...
2542
2543
  			my $init_char = "c";
  			my $orig_commit = "";
0d7835fca   Joe Perches   checkpatch: updat...
2544
2545
2546
2547
2548
  			my $short = 1;
  			my $long = 0;
  			my $case = 1;
  			my $space = 1;
  			my $hasdesc = 0;
19c146a64   Joe Perches   checkpatch: make ...
2549
  			my $hasparens = 0;
0d7835fca   Joe Perches   checkpatch: updat...
2550
2551
2552
  			my $id = '0123456789ab';
  			my $orig_desc = "commit description";
  			my $description = "";
fe043ea12   Joe Perches   checkpatch: warn ...
2553
2554
2555
2556
2557
2558
  			if ($line =~ /\b(c)ommit\s+([0-9a-f]{5,})\b/i) {
  				$init_char = $1;
  				$orig_commit = lc($2);
  			} elsif ($line =~ /\b([0-9a-f]{12,40})\b/i) {
  				$orig_commit = lc($1);
  			}
0d7835fca   Joe Perches   checkpatch: updat...
2559
2560
2561
2562
2563
2564
  			$short = 0 if ($line =~ /\bcommit\s+[0-9a-f]{12,40}/i);
  			$long = 1 if ($line =~ /\bcommit\s+[0-9a-f]{41,}/i);
  			$space = 0 if ($line =~ /\bcommit [0-9a-f]/i);
  			$case = 0 if ($line =~ /\b[Cc]ommit\s+[0-9a-f]{5,40}[^A-F]/);
  			if ($line =~ /\bcommit\s+[0-9a-f]{5,}\s+\("([^"]+)"\)/i) {
  				$orig_desc = $1;
19c146a64   Joe Perches   checkpatch: make ...
2565
  				$hasparens = 1;
0d7835fca   Joe Perches   checkpatch: updat...
2566
2567
2568
2569
  			} elsif ($line =~ /\bcommit\s+[0-9a-f]{5,}\s*$/i &&
  				 defined $rawlines[$linenr] &&
  				 $rawlines[$linenr] =~ /^\s*\("([^"]+)"\)/) {
  				$orig_desc = $1;
19c146a64   Joe Perches   checkpatch: make ...
2570
  				$hasparens = 1;
b671fde05   Joe Perches   checkpatch: add a...
2571
2572
2573
2574
2575
2576
2577
  			} elsif ($line =~ /\bcommit\s+[0-9a-f]{5,}\s+\("[^"]+$/i &&
  				 defined $rawlines[$linenr] &&
  				 $rawlines[$linenr] =~ /^\s*[^"]+"\)/) {
  				$line =~ /\bcommit\s+[0-9a-f]{5,}\s+\("([^"]+)$/i;
  				$orig_desc = $1;
  				$rawlines[$linenr] =~ /^\s*([^"]+)"\)/;
  				$orig_desc .= " " . $1;
19c146a64   Joe Perches   checkpatch: make ...
2578
  				$hasparens = 1;
0d7835fca   Joe Perches   checkpatch: updat...
2579
2580
2581
2582
  			}
  
  			($id, $description) = git_commit_info($orig_commit,
  							      $id, $orig_desc);
19c146a64   Joe Perches   checkpatch: make ...
2583
  			if ($short || $long || $space || $case || ($orig_desc ne $description) || !$hasparens) {
0d7835fca   Joe Perches   checkpatch: updat...
2584
2585
2586
2587
  				ERROR("GIT_COMMIT_ID",
  				      "Please use git commit description style 'commit <12+ chars of sha1> (\"<title line>\")' - ie: '${init_char}ommit $id (\"$description\")'
  " . $herecurr);
  			}
d311cd445   Joe Perches   checkpatch: add t...
2588
  		}
13f1937ef   Joe Perches   checkpatch: emit ...
2589
2590
2591
2592
2593
2594
2595
2596
2597
2598
2599
  # Check for added, moved or deleted files
  		if (!$reported_maintainer_file && !$in_commit_log &&
  		    ($line =~ /^(?:new|deleted) file mode\s*\d+\s*$/ ||
  		     $line =~ /^rename (?:from|to) [\w\/\.\-]+\s*$/ ||
  		     ($line =~ /\{\s*([\w\/\.\-]*)\s*\=\>\s*([\w\/\.\-]*)\s*\}/ &&
  		      (defined($1) || defined($2))))) {
  			$reported_maintainer_file = 1;
  			WARN("FILE_PATH_CHANGES",
  			     "added, moved or deleted file(s), does MAINTAINERS need updating?
  " . $herecurr);
  		}
00df344fd   Andy Whitcroft   update checkpatch...
2600
  # Check for wrappage within a valid hunk of the file
8905a67c6   Andy Whitcroft   update checkpatch...
2601
  		if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
2602
2603
2604
  			ERROR("CORRUPTED_PATCH",
  			      "patch seems to be corrupt (line wrapped?)
  " .
6c72ffaab   Andy Whitcroft   update checkpatch...
2605
  				$herecurr) if (!$emitted_corrupt++);
de7d4f0e1   Andy Whitcroft   update checkpatch...
2606
  		}
6ecd96744   Andy Whitcroft   checkpatch: repor...
2607
2608
2609
2610
2611
2612
2613
2614
2615
2616
2617
2618
2619
  # Check for absolute kernel paths.
  		if ($tree) {
  			while ($line =~ m{(?:^|\s)(/\S*)}g) {
  				my $file = $1;
  
  				if ($file =~ m{^(.*?)(?::\d+)+:?$} &&
  				    check_absolute_file($1, $herecurr)) {
  					#
  				} else {
  					check_absolute_file($file, $herecurr);
  				}
  			}
  		}
de7d4f0e1   Andy Whitcroft   update checkpatch...
2620
2621
  # UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php
  		if (($realfile =~ /^$/ || $line =~ /^\+/) &&
171ae1a49   Andy Whitcroft   update checkpatch...
2622
2623
2624
2625
2626
2627
2628
  		    $rawline !~ m/^$UTF8*$/) {
  			my ($utf8_prefix) = ($rawline =~ /^($UTF8*)/);
  
  			my $blank = copy_spacing($rawline);
  			my $ptr = substr($blank, 0, length($utf8_prefix)) . "^";
  			my $hereptr = "$hereline$ptr
  ";
34d992197   Joe Perches   checkpatch: make ...
2629
2630
2631
  			CHK("INVALID_UTF8",
  			    "Invalid UTF-8, patch and commit message should be encoded in UTF-8
  " . $hereptr);
00df344fd   Andy Whitcroft   update checkpatch...
2632
  		}
15662b3e8   Joe Perches   checkpatch: add a...
2633
2634
2635
  # Check if it's the start of a commit log
  # (not a header line and we haven't seen the patch filename)
  		if ($in_header_lines && $realfile =~ /^$/ &&
29ee1b0c6   Joe Perches   checkpatch: ignor...
2636
2637
  		    !($rawline =~ /^\s+\S/ ||
  		      $rawline =~ /^(commit\b|from\b|[\w-]+:).*$/i)) {
15662b3e8   Joe Perches   checkpatch: add a...
2638
2639
  			$in_header_lines = 0;
  			$in_commit_log = 1;
ed43c4e58   Allen Hubbe   checkpatch: check...
2640
  			$has_commit_log = 1;
15662b3e8   Joe Perches   checkpatch: add a...
2641
  		}
fa64205df   Pasi Savanainen   checkpatch: check...
2642
2643
2644
2645
2646
2647
2648
2649
2650
  # Check if there is UTF-8 in a commit log when a mail header has explicitly
  # declined it, i.e defined some charset where it is missing.
  		if ($in_header_lines &&
  		    $rawline =~ /^Content-Type:.+charset="(.+)".*$/ &&
  		    $1 !~ /utf-8/i) {
  			$non_utf8_charset = 1;
  		}
  
  		if ($in_commit_log && $non_utf8_charset && $realfile =~ /^$/ &&
15662b3e8   Joe Perches   checkpatch: add a...
2651
  		    $rawline =~ /$NON_ASCII_UTF8/) {
fa64205df   Pasi Savanainen   checkpatch: check...
2652
  			WARN("UTF8_BEFORE_PATCH",
15662b3e8   Joe Perches   checkpatch: add a...
2653
2654
2655
  			    "8-bit UTF-8 used in possible commit log
  " . $herecurr);
  		}
66b47b4a9   Kees Cook   checkpatch: look ...
2656
  # Check for various typo / spelling mistakes
66d7a382c   Joe Perches   checkpatch: add s...
2657
2658
  		if (defined($misspellings) &&
  		    ($in_commit_log || $line =~ /^(?:\+|Subject:)/i)) {
ebfd7d623   Joe Perches   checkpatch: add o...
2659
  			while ($rawline =~ /(?:^|[^a-z@])($misspellings)(?:\b|$|[^a-z@])/gi) {
66b47b4a9   Kees Cook   checkpatch: look ...
2660
2661
2662
2663
2664
2665
2666
2667
2668
2669
2670
2671
2672
2673
  				my $typo = $1;
  				my $typo_fix = $spelling_fix{lc($typo)};
  				$typo_fix = ucfirst($typo_fix) if ($typo =~ /^[A-Z]/);
  				$typo_fix = uc($typo_fix) if ($typo =~ /^[A-Z]+$/);
  				my $msg_type = \&WARN;
  				$msg_type = \&CHK if ($file);
  				if (&{$msg_type}("TYPO_SPELLING",
  						 "'$typo' may be misspelled - perhaps '$typo_fix'?
  " . $herecurr) &&
  				    $fix) {
  					$fixed[$fixlinenr] =~ s/(^|[^A-Za-z@])($typo)($|[^A-Za-z@])/$1$typo_fix$3/;
  				}
  			}
  		}
306708547   Andy Whitcroft   checkpatch: ensur...
2674
2675
  # ignore non-hunk lines and lines being removed
  		next if (!$hunk_line || $line =~ /^-/);
0a920b5b6   Andy Whitcroft   add a trivial pat...
2676

0a920b5b6   Andy Whitcroft   add a trivial pat...
2677
  #trailing whitespace
9c0ca6f9a   Andy Whitcroft   update checkpatch...
2678
  		if ($line =~ /^\+.*\015/) {
c2fdda0df   Andy Whitcroft   update checkpatch...
2679
2680
2681
  			my $herevet = "$here
  " . cat_vet($rawline) . "
  ";
d5e616fc1   Joe Perches   checkpatch: add a...
2682
2683
2684
2685
  			if (ERROR("DOS_LINE_ENDINGS",
  				  "DOS line endings
  " . $herevet) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
2686
  				$fixed[$fixlinenr] =~ s/[\s\015]+$//;
d5e616fc1   Joe Perches   checkpatch: add a...
2687
  			}
c2fdda0df   Andy Whitcroft   update checkpatch...
2688
2689
2690
2691
  		} elsif ($rawline =~ /^\+.*\S\s+$/ || $rawline =~ /^\+\s+$/) {
  			my $herevet = "$here
  " . cat_vet($rawline) . "
  ";
3705ce5bc   Joe Perches   checkpatch: creat...
2692
2693
2694
2695
  			if (ERROR("TRAILING_WHITESPACE",
  				  "trailing whitespace
  " . $herevet) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
2696
  				$fixed[$fixlinenr] =~ s/\s+$//;
3705ce5bc   Joe Perches   checkpatch: creat...
2697
  			}
d2c0a2351   Andy Whitcroft   checkpatch: sugge...
2698
  			$rpt_cleaners = 1;
0a920b5b6   Andy Whitcroft   add a trivial pat...
2699
  		}
5368df20f   Andy Whitcroft   checkpatch: check...
2700

4783f894d   Josh Triplett   checkpatch.pl: ch...
2701
  # Check for FSF mailing addresses.
109d8cb20   Alexander Duyck   checkpatch: only ...
2702
  		if ($rawline =~ /\bwrite to the Free/i ||
3e2232f2d   Joe Perches   checkpatch: updat...
2703
2704
  		    $rawline =~ /\b59\s+Temple\s+Pl/i ||
  		    $rawline =~ /\b51\s+Franklin\s+St/i) {
4783f894d   Josh Triplett   checkpatch.pl: ch...
2705
2706
2707
2708
2709
2710
  			my $herevet = "$here
  " . cat_vet($rawline) . "
  ";
  			my $msg_type = \&ERROR;
  			$msg_type = \&CHK if ($file);
  			&{$msg_type}("FSF_MAILING_ADDRESS",
3e2232f2d   Joe Perches   checkpatch: updat...
2711
2712
  				     "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
  " . $herevet)
4783f894d   Josh Triplett   checkpatch.pl: ch...
2713
  		}
3354957a4   Andi Kleen   checkpatch: add c...
2714
  # check for Kconfig help text having a real description
9fe287d79   Andy Whitcroft   checkpatch: ensur...
2715
2716
  # Only applies when adding the entry originally, after that we do not have
  # sufficient context to determine whether it is indeed long enough.
3354957a4   Andi Kleen   checkpatch: add c...
2717
  		if ($realfile =~ /Kconfig/ &&
8d73e0e7d   Joe Perches   checkpatch: quiet...
2718
  		    $line =~ /^\+\s*config\s+/) {
3354957a4   Andi Kleen   checkpatch: add c...
2719
  			my $length = 0;
9fe287d79   Andy Whitcroft   checkpatch: ensur...
2720
2721
2722
  			my $cnt = $realcnt;
  			my $ln = $linenr + 1;
  			my $f;
a13858033   Andy Whitcroft   checkpatch: only ...
2723
  			my $is_start = 0;
9fe287d79   Andy Whitcroft   checkpatch: ensur...
2724
  			my $is_end = 0;
a13858033   Andy Whitcroft   checkpatch: only ...
2725
  			for (; $cnt > 0 && defined $lines[$ln - 1]; $ln++) {
9fe287d79   Andy Whitcroft   checkpatch: ensur...
2726
2727
2728
  				$f = $lines[$ln - 1];
  				$cnt-- if ($lines[$ln - 1] !~ /^-/);
  				$is_end = $lines[$ln - 1] =~ /^\+/;
9fe287d79   Andy Whitcroft   checkpatch: ensur...
2729
2730
  
  				next if ($f =~ /^-/);
8d73e0e7d   Joe Perches   checkpatch: quiet...
2731
  				last if (!$file && $f =~ /^\@\@/);
a13858033   Andy Whitcroft   checkpatch: only ...
2732

8d73e0e7d   Joe Perches   checkpatch: quiet...
2733
  				if ($lines[$ln - 1] =~ /^\+\s*(?:bool|tristate)\s*\"/) {
a13858033   Andy Whitcroft   checkpatch: only ...
2734
  					$is_start = 1;
8d73e0e7d   Joe Perches   checkpatch: quiet...
2735
  				} elsif ($lines[$ln - 1] =~ /^\+\s*(?:---)?help(?:---)?$/) {
a13858033   Andy Whitcroft   checkpatch: only ...
2736
2737
  					$length = -1;
  				}
9fe287d79   Andy Whitcroft   checkpatch: ensur...
2738
  				$f =~ s/^.//;
3354957a4   Andi Kleen   checkpatch: add c...
2739
2740
2741
  				$f =~ s/#.*//;
  				$f =~ s/^\s+//;
  				next if ($f =~ /^$/);
9fe287d79   Andy Whitcroft   checkpatch: ensur...
2742
2743
2744
2745
  				if ($f =~ /^\s*config\s/) {
  					$is_end = 1;
  					last;
  				}
3354957a4   Andi Kleen   checkpatch: add c...
2746
2747
  				$length++;
  			}
56193274e   Vadim Bendebury   checkpatch: allow...
2748
2749
2750
2751
2752
  			if ($is_start && $is_end && $length < $min_conf_desc_length) {
  				WARN("CONFIG_DESCRIPTION",
  				     "please write a paragraph that describes the config symbol fully
  " . $herecurr);
  			}
a13858033   Andy Whitcroft   checkpatch: only ...
2753
2754
  			#print "is_start<$is_start> is_end<$is_end> length<$length>
  ";
3354957a4   Andi Kleen   checkpatch: add c...
2755
  		}
1ba8dfd17   Kees Cook   checkpatch: warn ...
2756
2757
2758
2759
2760
2761
2762
  # discourage the addition of CONFIG_EXPERIMENTAL in Kconfig.
  		if ($realfile =~ /Kconfig/ &&
  		    $line =~ /.\s*depends on\s+.*\bEXPERIMENTAL\b/) {
  			WARN("CONFIG_EXPERIMENTAL",
  			     "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580
  ");
  		}
327953e9a   Christoph Jaeger   checkpatch: add c...
2763
2764
2765
2766
2767
2768
2769
  # discourage the use of boolean for type definition attributes of Kconfig options
  		if ($realfile =~ /Kconfig/ &&
  		    $line =~ /^\+\s*\bboolean\b/) {
  			WARN("CONFIG_TYPE_BOOLEAN",
  			     "Use of boolean is deprecated, please use bool instead.
  " . $herecurr);
  		}
c68e58783   Arnaud Lacombe   script/checkpatch...
2770
2771
2772
2773
2774
2775
2776
2777
2778
2779
2780
2781
2782
2783
  		if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
  		    ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
  			my $flag = $1;
  			my $replacement = {
  				'EXTRA_AFLAGS' =>   'asflags-y',
  				'EXTRA_CFLAGS' =>   'ccflags-y',
  				'EXTRA_CPPFLAGS' => 'cppflags-y',
  				'EXTRA_LDFLAGS' =>  'ldflags-y',
  			};
  
  			WARN("DEPRECATED_VARIABLE",
  			     "Use of $flag is deprecated, please use \`$replacement->{$flag} instead.
  " . $herecurr) if ($replacement->{$flag});
  		}
bff5da433   Rob Herring   checkpatch: add D...
2784
  # check for DT compatible documentation
7dd05b38e   Florian Vaussard   checkpatch: check...
2785
2786
2787
  		if (defined $root &&
  			(($realfile =~ /\.dtsi?$/ && $line =~ /^\+\s*compatible\s*=\s*\"/) ||
  			 ($realfile =~ /\.[ch]$/ && $line =~ /^\+.*\.compatible\s*=\s*\"/))) {
bff5da433   Rob Herring   checkpatch: add D...
2788
  			my @compats = $rawline =~ /\"([a-zA-Z0-9\-\,\.\+_]+)\"/g;
cc93319b5   Florian Vaussard   checkpatch: impro...
2789
2790
  			my $dt_path = $root . "/Documentation/devicetree/bindings/";
  			my $vp_file = $dt_path . "vendor-prefixes.txt";
bff5da433   Rob Herring   checkpatch: add D...
2791
2792
  			foreach my $compat (@compats) {
  				my $compat2 = $compat;
185d566bc   Rob Herring   checkpatch: fix w...
2793
2794
2795
2796
  				$compat2 =~ s/\,[a-zA-Z0-9]*\-/\,<\.\*>\-/;
  				my $compat3 = $compat;
  				$compat3 =~ s/\,([a-z]*)[0-9]*\-/\,$1<\.\*>\-/;
  				`grep -Erq "$compat|$compat2|$compat3" $dt_path`;
bff5da433   Rob Herring   checkpatch: add D...
2797
2798
2799
2800
2801
  				if ( $? >> 8 ) {
  					WARN("UNDOCUMENTED_DT_STRING",
  					     "DT compatible string \"$compat\" appears un-documented -- check $dt_path
  " . $herecurr);
  				}
4fbf32a69   Florian Vaussard   checkpatch: fix s...
2802
2803
  				next if $compat !~ /^([a-zA-Z0-9\-]+)\,/;
  				my $vendor = $1;
cc93319b5   Florian Vaussard   checkpatch: impro...
2804
  				`grep -Eq "^$vendor\\b" $vp_file`;
bff5da433   Rob Herring   checkpatch: add D...
2805
2806
  				if ( $? >> 8 ) {
  					WARN("UNDOCUMENTED_DT_STRING",
cc93319b5   Florian Vaussard   checkpatch: impro...
2807
2808
  					     "DT compatible string vendor \"$vendor\" appears un-documented -- check $vp_file
  " . $herecurr);
bff5da433   Rob Herring   checkpatch: add D...
2809
2810
2811
  				}
  			}
  		}
5368df20f   Andy Whitcroft   checkpatch: check...
2812
  # check we are in a valid source file if not then ignore this hunk
de4c924c2   Geert Uytterhoeven   checkpatch: enabl...
2813
  		next if ($realfile !~ /\.(h|c|s|S|pl|sh|dtsi|dts)$/);
5368df20f   Andy Whitcroft   checkpatch: check...
2814

47e0c88b3   Joe Perches   checkpatch: categ...
2815
2816
2817
2818
2819
2820
2821
2822
2823
2824
2825
2826
2827
2828
  # line length limit (with some exclusions)
  #
  # There are a few types of lines that may extend beyond $max_line_length:
  #	logging functions like pr_info that end in a string
  #	lines with a single string
  #	#defines that are a single string
  #
  # There are 3 different line length message types:
  # LONG_LINE_COMMENT	a comment starts before but extends beyond $max_linelength
  # LONG_LINE_STRING	a string starts before but extends beyond $max_line_length
  # LONG_LINE		all other lines longer than $max_line_length
  #
  # if LONG_LINE is ignored, the other 2 types are also ignored
  #
b4749e96a   Joe Perches   checkpatch: fix l...
2829
  		if ($line =~ /^\+/ && $length > $max_line_length) {
47e0c88b3   Joe Perches   checkpatch: categ...
2830
2831
2832
2833
2834
2835
2836
2837
2838
2839
2840
2841
2842
2843
2844
  			my $msg_type = "LONG_LINE";
  
  			# Check the allowed long line types first
  
  			# logging functions that end in a string that starts
  			# before $max_line_length
  			if ($line =~ /^\+\s*$logFunctions\s*\(\s*(?:(?:KERN_\S+\s*|[^"]*))?($String\s*(?:|,|\)\s*;)\s*)$/ &&
  			    length(expand_tabs(substr($line, 1, length($line) - length($1) - 1))) <= $max_line_length) {
  				$msg_type = "";
  
  			# lines with only strings (w/ possible termination)
  			# #defines with only strings
  			} elsif ($line =~ /^\+\s*$String\s*(?:\s*|,|\)\s*;)\s*$/ ||
  				 $line =~ /^\+\s*#\s*define\s+\w+\s+$String$/) {
  				$msg_type = "";
d560a5f8a   Joe Perches   checkpatch: skip ...
2845
2846
2847
  			# EFI_GUID is another special case
  			} elsif ($line =~ /^\+.*\bEFI_GUID\s*\(/) {
  				$msg_type = "";
47e0c88b3   Joe Perches   checkpatch: categ...
2848
2849
2850
2851
2852
2853
2854
2855
2856
2857
2858
2859
2860
2861
2862
2863
2864
2865
2866
  			# Otherwise set the alternate message types
  
  			# a comment starts before $max_line_length
  			} elsif ($line =~ /($;[\s$;]*)$/ &&
  				 length(expand_tabs(substr($line, 1, length($line) - length($1) - 1))) <= $max_line_length) {
  				$msg_type = "LONG_LINE_COMMENT"
  
  			# a quoted string starts before $max_line_length
  			} elsif ($sline =~ /\s*($String(?:\s*(?:\\|,\s*|\)\s*;\s*))?)$/ &&
  				 length(expand_tabs(substr($line, 1, length($line) - length($1) - 1))) <= $max_line_length) {
  				$msg_type = "LONG_LINE_STRING"
  			}
  
  			if ($msg_type ne "" &&
  			    (show_type("LONG_LINE") || show_type($msg_type))) {
  				WARN($msg_type,
  				     "line over $max_line_length characters
  " . $herecurr);
  			}
0a920b5b6   Andy Whitcroft   add a trivial pat...
2867
  		}
8905a67c6   Andy Whitcroft   update checkpatch...
2868
2869
  # check for adding lines without a newline.
  		if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
2870
2871
2872
  			WARN("MISSING_EOF_NEWLINE",
  			     "adding a line without newline at end of file
  " . $herecurr);
8905a67c6   Andy Whitcroft   update checkpatch...
2873
  		}
42e41c54d   Mike Frysinger   checkpatch: add s...
2874
2875
2876
2877
2878
2879
  # Blackfin: use hi/lo macros
  		if ($realfile =~ m@arch/blackfin/.*\.S$@) {
  			if ($line =~ /\.[lL][[:space:]]*=.*&[[:space:]]*0x[fF][fF][fF][fF]/) {
  				my $herevet = "$here
  " . cat_vet($line) . "
  ";
000d1cc18   Joe Perches   checkpatch.pl: ad...
2880
2881
2882
  				ERROR("LO_MACRO",
  				      "use the LO() macro, not (... & 0xFFFF)
  " . $herevet);
42e41c54d   Mike Frysinger   checkpatch: add s...
2883
2884
2885
2886
2887
  			}
  			if ($line =~ /\.[hH][[:space:]]*=.*>>[[:space:]]*16/) {
  				my $herevet = "$here
  " . cat_vet($line) . "
  ";
000d1cc18   Joe Perches   checkpatch.pl: ad...
2888
2889
2890
  				ERROR("HI_MACRO",
  				      "use the HI() macro, not (... >> 16)
  " . $herevet);
42e41c54d   Mike Frysinger   checkpatch: add s...
2891
2892
  			}
  		}
b9ea10d69   Andy Whitcroft   checkpatch: perfo...
2893
  # check we are in a valid source file C or perl if not then ignore this hunk
de4c924c2   Geert Uytterhoeven   checkpatch: enabl...
2894
  		next if ($realfile !~ /\.(h|c|pl|dtsi|dts)$/);
0a920b5b6   Andy Whitcroft   add a trivial pat...
2895
2896
2897
  
  # at the beginning of a line any tabs must come first and anything
  # more than 8 must use tabs.
c2fdda0df   Andy Whitcroft   update checkpatch...
2898
2899
2900
2901
2902
  		if ($rawline =~ /^\+\s* \t\s*\S/ ||
  		    $rawline =~ /^\+\s*        \s*/) {
  			my $herevet = "$here
  " . cat_vet($rawline) . "
  ";
d2c0a2351   Andy Whitcroft   checkpatch: sugge...
2903
  			$rpt_cleaners = 1;
3705ce5bc   Joe Perches   checkpatch: creat...
2904
2905
2906
2907
  			if (ERROR("CODE_INDENT",
  				  "code indent should use tabs where possible
  " . $herevet) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
2908
  				$fixed[$fixlinenr] =~ s/^\+([ \t]+)/"\+" . tabify($1)/e;
3705ce5bc   Joe Perches   checkpatch: creat...
2909
  			}
0a920b5b6   Andy Whitcroft   add a trivial pat...
2910
  		}
08e443656   Alberto Panizzo   checkpatch.pl: wa...
2911
2912
2913
2914
2915
  # check for space before tabs.
  		if ($rawline =~ /^\+/ && $rawline =~ / \t/) {
  			my $herevet = "$here
  " . cat_vet($rawline) . "
  ";
3705ce5bc   Joe Perches   checkpatch: creat...
2916
2917
2918
2919
  			if (WARN("SPACE_BEFORE_TAB",
  				"please, no space before tabs
  " . $herevet) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
2920
  				while ($fixed[$fixlinenr] =~
d2207ccbc   Joe Perches   checkpatch: remov...
2921
  					   s/(^\+.*) {8,8}\t/$1\t\t/) {}
194f66fc9   Joe Perches   checkpatch: add a...
2922
  				while ($fixed[$fixlinenr] =~
c76f4cb3d   Joe Perches   checkpatch: impro...
2923
  					   s/(^\+.*) +\t/$1\t/) {}
3705ce5bc   Joe Perches   checkpatch: creat...
2924
  			}
08e443656   Alberto Panizzo   checkpatch.pl: wa...
2925
  		}
d1fe9c099   Joe Perches   checkpatch: add s...
2926
2927
2928
2929
2930
2931
  # check for && or || at the start of a line
  		if ($rawline =~ /^\+\s*(&&|\|\|)/) {
  			CHK("LOGICAL_CONTINUATIONS",
  			    "Logical continuations should be on the previous line
  " . $hereprev);
  		}
a91e8994f   Joe Perches   checkpatch: add t...
2932
2933
2934
2935
2936
2937
2938
2939
2940
2941
2942
2943
2944
  # check indentation starts on a tab stop
  		if ($^V && $^V ge 5.10.0 &&
  		    $sline =~ /^\+\t+( +)(?:$c90_Keywords\b|\{\s*$|\}\s*(?:else\b|while\b|\s*$))/) {
  			my $indent = length($1);
  			if ($indent % 8) {
  				if (WARN("TABSTOP",
  					 "Statements should start on a tabstop
  " . $herecurr) &&
  				    $fix) {
  					$fixed[$fixlinenr] =~ s@(^\+\t+) +@$1 . "\t" x ($indent/8)@e;
  				}
  			}
  		}
d1fe9c099   Joe Perches   checkpatch: add s...
2945
2946
  # check multi-line statement indentation matches previous line
  		if ($^V && $^V ge 5.10.0 &&
91cb5195f   Joe Perches   checkpatch: expan...
2947
  		    $prevline =~ /^\+([ \t]*)((?:$c90_Keywords(?:\s+if)\s*)|(?:$Declare\s*)?(?:$Ident|\(\s*\*\s*$Ident\s*\))\s*|$Ident\s*=\s*$Ident\s*)\(.*(\&\&|\|\||,)\s*$/) {
d1fe9c099   Joe Perches   checkpatch: add s...
2948
2949
2950
2951
2952
2953
  			$prevline =~ /^\+(\t*)(.*)$/;
  			my $oldindent = $1;
  			my $rest = $2;
  
  			my $pos = pos_last_openparen($rest);
  			if ($pos >= 0) {
b34a26f31   Joe Perches   checkpatch: Updat...
2954
2955
  				$line =~ /^(\+| )([ \t]*)/;
  				my $newindent = $2;
d1fe9c099   Joe Perches   checkpatch: add s...
2956
2957
2958
2959
2960
2961
2962
2963
  
  				my $goodtabindent = $oldindent .
  					"\t" x ($pos / 8) .
  					" "  x ($pos % 8);
  				my $goodspaceindent = $oldindent . " "  x $pos;
  
  				if ($newindent ne $goodtabindent &&
  				    $newindent ne $goodspaceindent) {
3705ce5bc   Joe Perches   checkpatch: creat...
2964
2965
2966
2967
2968
  
  					if (CHK("PARENTHESIS_ALIGNMENT",
  						"Alignment should match open parenthesis
  " . $hereprev) &&
  					    $fix && $line =~ /^\+/) {
194f66fc9   Joe Perches   checkpatch: add a...
2969
  						$fixed[$fixlinenr] =~
3705ce5bc   Joe Perches   checkpatch: creat...
2970
2971
  						    s/^\+[ \t]*/\+$goodtabindent/;
  					}
d1fe9c099   Joe Perches   checkpatch: add s...
2972
2973
2974
  				}
  			}
  		}
6ab3a9701   Joe Perches   checkpatch: impro...
2975
2976
2977
2978
2979
2980
2981
2982
2983
  # check for space after cast like "(int) foo" or "(struct foo) bar"
  # avoid checking a few false positives:
  #   "sizeof(<type>)" or "__alignof__(<type>)"
  #   function pointer declarations like "(*foo)(int) = bar;"
  #   structure definitions like "(struct foo) { 0 };"
  #   multiline macros that define functions
  #   known attributes or the __attribute__ keyword
  		if ($line =~ /^\+(.*)\(\s*$Type\s*\)([ \t]++)((?![={]|\\$|$Attribute|__attribute__))/ &&
  		    (!defined($1) || $1 !~ /\b(?:sizeof|__alignof__)\s*$/)) {
3705ce5bc   Joe Perches   checkpatch: creat...
2984
  			if (CHK("SPACING",
f27c95db1   Joe Perches   checkpatch: impro...
2985
2986
  				"No space is necessary after a cast
  " . $herecurr) &&
3705ce5bc   Joe Perches   checkpatch: creat...
2987
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
2988
  				$fixed[$fixlinenr] =~
f27c95db1   Joe Perches   checkpatch: impro...
2989
  				    s/(\(\s*$Type\s*\))[ \t]+/$1/;
3705ce5bc   Joe Perches   checkpatch: creat...
2990
  			}
aad4f6149   Joe Perches   checkpatch: add -...
2991
  		}
86406b1cb   Joe Perches   checkpatch: alway...
2992
2993
  # Block comment styles
  # Networking with an initial /*
058806007   Joe Perches   checkpatch: check...
2994
  		if ($realfile =~ m@^(drivers/net/|net/)@ &&
fdb4bcd61   Joe Perches   checkpatch: impro...
2995
  		    $prevrawline =~ /^\+[ \t]*\/\*[ \t]*$/ &&
85ad978c6   Joe Perches   checkpatch: ignor...
2996
2997
  		    $rawline =~ /^\+[ \t]*\*/ &&
  		    $realline > 2) {
058806007   Joe Perches   checkpatch: check...
2998
2999
3000
3001
  			WARN("NETWORKING_BLOCK_COMMENT_STYLE",
  			     "networking block comments don't use an empty /* line, use /* Comment...
  " . $hereprev);
  		}
86406b1cb   Joe Perches   checkpatch: alway...
3002
3003
3004
  # Block comments use * on subsequent lines
  		if ($prevline =~ /$;[ \t]*$/ &&			#ends in comment
  		    $prevrawline =~ /^\+.*?\/\*/ &&		#starting /*
a605e32eb   Joe Perches   checkpatch: warn ...
3005
  		    $prevrawline !~ /\*\/[ \t]*$/ &&		#no trailing */
61135e966   Joe Perches   checkpatch: fix n...
3006
  		    $rawline =~ /^\+/ &&			#line is new
a605e32eb   Joe Perches   checkpatch: warn ...
3007
  		    $rawline !~ /^\+[ \t]*\*/) {		#no leading *
86406b1cb   Joe Perches   checkpatch: alway...
3008
3009
3010
  			WARN("BLOCK_COMMENT_STYLE",
  			     "Block comments use * on subsequent lines
  " . $hereprev);
a605e32eb   Joe Perches   checkpatch: warn ...
3011
  		}
86406b1cb   Joe Perches   checkpatch: alway...
3012
3013
  # Block comments use */ on trailing lines
  		if ($rawline !~ m@^\+[ \t]*\*/[ \t]*$@ &&	#trailing */
c24f9f195   Joe Perches   checkpatch: impro...
3014
3015
3016
  		    $rawline !~ m@^\+.*/\*.*\*/[ \t]*$@ &&	#inline /*...*/
  		    $rawline !~ m@^\+.*\*{2,}/[ \t]*$@ &&	#trailing **/
  		    $rawline =~ m@^\+[ \t]*.+\*\/[ \t]*$@) {	#non blank */
86406b1cb   Joe Perches   checkpatch: alway...
3017
3018
3019
  			WARN("BLOCK_COMMENT_STYLE",
  			     "Block comments use a trailing */ on a separate line
  " . $herecurr);
058806007   Joe Perches   checkpatch: check...
3020
  		}
08eb9b801   Joe Perches   checkpatch: test ...
3021
3022
  # Block comment * alignment
  		if ($prevline =~ /$;[ \t]*$/ &&			#ends in comment
af207524a   Joe Perches   checkpatch: impro...
3023
3024
3025
  		    $line =~ /^\+[ \t]*$;/ &&			#leading comment
  		    $rawline =~ /^\+[ \t]*\*/ &&		#leading *
  		    (($prevrawline =~ /^\+.*?\/\*/ &&		#leading /*
08eb9b801   Joe Perches   checkpatch: test ...
3026
  		      $prevrawline !~ /\*\/[ \t]*$/) ||		#no trailing */
af207524a   Joe Perches   checkpatch: impro...
3027
3028
  		     $prevrawline =~ /^\+[ \t]*\*/)) {		#leading *
  			my $oldindent;
08eb9b801   Joe Perches   checkpatch: test ...
3029
  			$prevrawline =~ m@^\+([ \t]*/?)\*@;
af207524a   Joe Perches   checkpatch: impro...
3030
3031
3032
3033
3034
3035
  			if (defined($1)) {
  				$oldindent = expand_tabs($1);
  			} else {
  				$prevrawline =~ m@^\+(.*/?)\*@;
  				$oldindent = expand_tabs($1);
  			}
08eb9b801   Joe Perches   checkpatch: test ...
3036
3037
  			$rawline =~ m@^\+([ \t]*)\*@;
  			my $newindent = $1;
08eb9b801   Joe Perches   checkpatch: test ...
3038
  			$newindent = expand_tabs($newindent);
af207524a   Joe Perches   checkpatch: impro...
3039
  			if (length($oldindent) ne length($newindent)) {
08eb9b801   Joe Perches   checkpatch: test ...
3040
3041
3042
3043
3044
  				WARN("BLOCK_COMMENT_STYLE",
  				     "Block comments should align the * on each line
  " . $hereprev);
  			}
  		}
7f6191914   Joe Perches   checkpatch: add t...
3045
3046
3047
3048
3049
3050
3051
3052
3053
3054
3055
3056
  # check for missing blank lines after struct/union declarations
  # with exceptions for various attributes and macros
  		if ($prevline =~ /^[\+ ]};?\s*$/ &&
  		    $line =~ /^\+/ &&
  		    !($line =~ /^\+\s*$/ ||
  		      $line =~ /^\+\s*EXPORT_SYMBOL/ ||
  		      $line =~ /^\+\s*MODULE_/i ||
  		      $line =~ /^\+\s*\#\s*(?:end|elif|else)/ ||
  		      $line =~ /^\+[a-z_]*init/ ||
  		      $line =~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ ||
  		      $line =~ /^\+\s*DECLARE/ ||
  		      $line =~ /^\+\s*__setup/)) {
d752fcc88   Joe Perches   checkpatch: add a...
3057
3058
3059
3060
  			if (CHK("LINE_SPACING",
  				"Please use a blank line after function/struct/union/enum declarations
  " . $hereprev) &&
  			    $fix) {
f2d7e4d43   Joe Perches   checkpatch: add f...
3061
  				fix_insert_line($fixlinenr, "\+");
d752fcc88   Joe Perches   checkpatch: add a...
3062
  			}
7f6191914   Joe Perches   checkpatch: add t...
3063
  		}
365dd4eaa   Joe Perches   checkpatch: add a...
3064
3065
3066
3067
  # check for multiple consecutive blank lines
  		if ($prevline =~ /^[\+ ]\s*$/ &&
  		    $line =~ /^\+\s*$/ &&
  		    $last_blank_line != ($linenr - 1)) {
d752fcc88   Joe Perches   checkpatch: add a...
3068
3069
3070
3071
  			if (CHK("LINE_SPACING",
  				"Please don't use multiple blank lines
  " . $hereprev) &&
  			    $fix) {
f2d7e4d43   Joe Perches   checkpatch: add f...
3072
  				fix_delete_line($fixlinenr, $rawline);
d752fcc88   Joe Perches   checkpatch: add a...
3073
  			}
365dd4eaa   Joe Perches   checkpatch: add a...
3074
3075
  			$last_blank_line = $linenr;
  		}
3b617e3b8   Joe Perches   checkpatch: net a...
3076
  # check for missing blank lines after declarations
3f7bac031   Joe Perches   checkpatch: alway...
3077
3078
3079
  		if ($sline =~ /^\+\s+\S/ &&			#Not at char 1
  			# actual declarations
  		    ($prevline =~ /^\+\s+$Declare\s*$Ident\s*[=,;:\[]/ ||
5a4e1fd37   Joe Perches   checkpatch: fix f...
3080
3081
  			# function pointer declarations
  		     $prevline =~ /^\+\s+$Declare\s*\(\s*\*\s*$Ident\s*\)\s*[=,;:\[\(]/ ||
3f7bac031   Joe Perches   checkpatch: alway...
3082
3083
3084
3085
3086
3087
3088
3089
3090
3091
3092
3093
  			# foo bar; where foo is some local typedef or #define
  		     $prevline =~ /^\+\s+$Ident(?:\s+|\s*\*\s*)$Ident\s*[=,;\[]/ ||
  			# known declaration macros
  		     $prevline =~ /^\+\s+$declaration_macros/) &&
  			# for "else if" which can look like "$Ident $Ident"
  		    !($prevline =~ /^\+\s+$c90_Keywords\b/ ||
  			# other possible extensions of declaration lines
  		      $prevline =~ /(?:$Compare|$Assignment|$Operators)\s*$/ ||
  			# not starting a section or a macro "\" extended line
  		      $prevline =~ /(?:\{\s*|\\)$/) &&
  			# looks like a declaration
  		    !($sline =~ /^\+\s+$Declare\s*$Ident\s*[=,;:\[]/ ||
5a4e1fd37   Joe Perches   checkpatch: fix f...
3094
3095
  			# function pointer declarations
  		      $sline =~ /^\+\s+$Declare\s*\(\s*\*\s*$Ident\s*\)\s*[=,;:\[\(]/ ||
3f7bac031   Joe Perches   checkpatch: alway...
3096
3097
3098
3099
3100
  			# foo bar; where foo is some local typedef or #define
  		      $sline =~ /^\+\s+$Ident(?:\s+|\s*\*\s*)$Ident\s*[=,;\[]/ ||
  			# known declaration macros
  		      $sline =~ /^\+\s+$declaration_macros/ ||
  			# start of struct or union or enum
3b617e3b8   Joe Perches   checkpatch: net a...
3101
  		      $sline =~ /^\+\s+(?:union|struct|enum|typedef)\b/ ||
3f7bac031   Joe Perches   checkpatch: alway...
3102
3103
3104
3105
3106
3107
3108
3109
  			# start or end of block or continuation of declaration
  		      $sline =~ /^\+\s+(?:$|[\{\}\.\#\"\?\:\(\[])/ ||
  			# bitfield continuation
  		      $sline =~ /^\+\s+$Ident\s*:\s*\d+\s*[,;]/ ||
  			# other possible extensions of declaration lines
  		      $sline =~ /^\+\s+\(?\s*(?:$Compare|$Assignment|$Operators)/) &&
  			# indentation of previous and current line are the same
  		    (($prevline =~ /\+(\s+)\S/) && $sline =~ /^\+$1\S/)) {
d752fcc88   Joe Perches   checkpatch: add a...
3110
3111
3112
3113
  			if (WARN("LINE_SPACING",
  				 "Missing a blank line after declarations
  " . $hereprev) &&
  			    $fix) {
f2d7e4d43   Joe Perches   checkpatch: add f...
3114
  				fix_insert_line($fixlinenr, "\+");
d752fcc88   Joe Perches   checkpatch: add a...
3115
  			}
3b617e3b8   Joe Perches   checkpatch: net a...
3116
  		}
5f7ddae61   Raffaele Recalcati   checkpatch: fix h...
3117
  # check for spaces at the beginning of a line.
6b4c5bebc   Andy Whitcroft   checkpatch: fix r...
3118
3119
3120
3121
  # Exceptions:
  #  1) within comments
  #  2) indented preprocessor commands
  #  3) hanging labels
3705ce5bc   Joe Perches   checkpatch: creat...
3122
  		if ($rawline =~ /^\+ / && $line !~ /^\+ *(?:$;|#|$Ident:)/)  {
5f7ddae61   Raffaele Recalcati   checkpatch: fix h...
3123
3124
3125
  			my $herevet = "$here
  " . cat_vet($rawline) . "
  ";
3705ce5bc   Joe Perches   checkpatch: creat...
3126
3127
3128
3129
  			if (WARN("LEADING_SPACE",
  				 "please, no spaces at the start of a line
  " . $herevet) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
3130
  				$fixed[$fixlinenr] =~ s/^\+([ \t]+)/"\+" . tabify($1)/e;
3705ce5bc   Joe Perches   checkpatch: creat...
3131
  			}
5f7ddae61   Raffaele Recalcati   checkpatch: fix h...
3132
  		}
b9ea10d69   Andy Whitcroft   checkpatch: perfo...
3133
3134
  # check we are in a valid C source file if not then ignore this hunk
  		next if ($realfile !~ /\.(h|c)$/);
032a4c0f9   Joe Perches   checkpatch: warn ...
3135
  # check indentation of any line with a bare else
840080a08   Joe Perches   checkpatch: add e...
3136
  # (but not if it is a multiple line "if (foo) return bar; else return baz;")
032a4c0f9   Joe Perches   checkpatch: warn ...
3137
3138
3139
  # if the previous line is a break or return and is indented 1 tab more...
  		if ($sline =~ /^\+([\t]+)(?:}[ \t]*)?else(?:[ \t]*{)?\s*$/) {
  			my $tabs = length($1) + 1;
840080a08   Joe Perches   checkpatch: add e...
3140
3141
3142
3143
  			if ($prevline =~ /^\+\t{$tabs,$tabs}break\b/ ||
  			    ($prevline =~ /^\+\t{$tabs,$tabs}return\b/ &&
  			     defined $lines[$linenr] &&
  			     $lines[$linenr] !~ /^[ \+]\t{$tabs,$tabs}return/)) {
032a4c0f9   Joe Perches   checkpatch: warn ...
3144
3145
3146
3147
3148
  				WARN("UNNECESSARY_ELSE",
  				     "else is not generally useful after a break or return
  " . $hereprev);
  			}
  		}
c00df19a5   Joe Perches   checkpatch: warn ...
3149
3150
3151
3152
3153
3154
3155
3156
3157
3158
  # check indentation of a line with a break;
  # if the previous line is a goto or return and is indented the same # of tabs
  		if ($sline =~ /^\+([\t]+)break\s*;\s*$/) {
  			my $tabs = $1;
  			if ($prevline =~ /^\+$tabs(?:goto|return)\b/) {
  				WARN("UNNECESSARY_BREAK",
  				     "break is not useful after a goto or return
  " . $hereprev);
  			}
  		}
1ba8dfd17   Kees Cook   checkpatch: warn ...
3159
3160
3161
3162
3163
3164
  # discourage the addition of CONFIG_EXPERIMENTAL in #if(def).
  		if ($line =~ /^\+\s*\#\s*if.*\bCONFIG_EXPERIMENTAL\b/) {
  			WARN("CONFIG_EXPERIMENTAL",
  			     "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580
  ");
  		}
c2fdda0df   Andy Whitcroft   update checkpatch...
3165
  # check for RCS/CVS revision markers
cf655043d   Andy Whitcroft   update checkpatch...
3166
  		if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
3167
3168
3169
  			WARN("CVS_KEYWORD",
  			     "CVS style keyword markers, these will _not_ be updated
  ". $herecurr);
c2fdda0df   Andy Whitcroft   update checkpatch...
3170
  		}
22f2a2ef9   Andy Whitcroft   update checkpatch...
3171

42e41c54d   Mike Frysinger   checkpatch: add s...
3172
3173
3174
3175
3176
  # Blackfin: don't use __builtin_bfin_[cs]sync
  		if ($line =~ /__builtin_bfin_csync/) {
  			my $herevet = "$here
  " . cat_vet($line) . "
  ";
000d1cc18   Joe Perches   checkpatch.pl: ad...
3177
3178
3179
  			ERROR("CSYNC",
  			      "use the CSYNC() macro in asm/blackfin.h
  " . $herevet);
42e41c54d   Mike Frysinger   checkpatch: add s...
3180
3181
3182
3183
3184
  		}
  		if ($line =~ /__builtin_bfin_ssync/) {
  			my $herevet = "$here
  " . cat_vet($line) . "
  ";
000d1cc18   Joe Perches   checkpatch.pl: ad...
3185
3186
3187
  			ERROR("SSYNC",
  			      "use the SSYNC() macro in asm/blackfin.h
  " . $herevet);
42e41c54d   Mike Frysinger   checkpatch: add s...
3188
  		}
56e77d709   Joe Perches   checkpatch: warn ...
3189
3190
3191
3192
3193
3194
  # check for old HOTPLUG __dev<foo> section markings
  		if ($line =~ /\b(__dev(init|exit)(data|const|))\b/) {
  			WARN("HOTPLUG_SECTION",
  			     "Using $1 is unnecessary
  " . $herecurr);
  		}
9c0ca6f9a   Andy Whitcroft   update checkpatch...
3195
  # Check for potential 'bare' types
2b474a1a5   Andy Whitcroft   checkpatch: fix f...
3196
3197
  		my ($stat, $cond, $line_nr_next, $remain_next, $off_next,
  		    $realline_next);
3e469cdc0   Andy Whitcroft   checkpatch: optim...
3198
3199
3200
  #print "LINE<$line>
  ";
  		if ($linenr >= $suppress_statement &&
1b5539b1f   Joe Perches   checkpatch: reduc...
3201
  		    $realcnt && $sline =~ /.\s*\S/) {
170d3a226   Andy Whitcroft   checkpatch: handl...
3202
  			($stat, $cond, $line_nr_next, $remain_next, $off_next) =
f5fe35dd9   Andy Whitcroft   checkpatch: condi...
3203
  				ctx_statement_block($linenr, $realcnt, 0);
171ae1a49   Andy Whitcroft   update checkpatch...
3204
3205
3206
3207
3208
3209
  			$stat =~ s/
  ./
   /g;
  			$cond =~ s/
  ./
   /g;
3e469cdc0   Andy Whitcroft   checkpatch: optim...
3210
3211
3212
3213
3214
3215
3216
3217
3218
3219
3220
  #print "linenr<$linenr> <$stat>
  ";
  			# If this statement has no statement boundaries within
  			# it there is no point in retrying a statement scan
  			# until we hit end of it.
  			my $frag = $stat; $frag =~ s/;+\s*$//;
  			if ($frag !~ /(?:{|;)/) {
  #print "skip<$line_nr_next>
  ";
  				$suppress_statement = $line_nr_next;
  			}
f74bd1942   Andy Whitcroft   checkpatch: corre...
3221

2b474a1a5   Andy Whitcroft   checkpatch: fix f...
3222
3223
3224
3225
3226
3227
3228
  			# Find the real next line.
  			$realline_next = $line_nr_next;
  			if (defined $realline_next &&
  			    (!defined $lines[$realline_next - 1] ||
  			     substr($lines[$realline_next - 1], $off_next) =~ /^\s*$/)) {
  				$realline_next++;
  			}
171ae1a49   Andy Whitcroft   update checkpatch...
3229
3230
  			my $s = $stat;
  			$s =~ s/{.*$//s;
cf655043d   Andy Whitcroft   update checkpatch...
3231

c2fdda0df   Andy Whitcroft   update checkpatch...
3232
  			# Ignore goto labels.
171ae1a49   Andy Whitcroft   update checkpatch...
3233
  			if ($s =~ /$Ident:\*$/s) {
c2fdda0df   Andy Whitcroft   update checkpatch...
3234
3235
  
  			# Ignore functions being called
171ae1a49   Andy Whitcroft   update checkpatch...
3236
  			} elsif ($s =~ /^.\s*$Ident\s*\(/s) {
c2fdda0df   Andy Whitcroft   update checkpatch...
3237

463f28648   Andy Whitcroft   checkpatch: possi...
3238
  			} elsif ($s =~ /^.\s*else\b/s) {
c45dcabd2   Andy Whitcroft   update checkpatch...
3239
  			# declarations always start with types
d25065865   Andy Whitcroft   checkpatch: possi...
3240
  			} elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+?)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))(?:\s*$Modifier)?\s*(?:;|=|,|\()/s) {
c45dcabd2   Andy Whitcroft   update checkpatch...
3241
3242
3243
  				my $type = $1;
  				$type =~ s/\s+/ /g;
  				possible($type, "A:" . $s);
8905a67c6   Andy Whitcroft   update checkpatch...
3244
  			# definitions in global scope can only start with types
a6a840628   Andy Whitcroft   checkpatch: label...
3245
  			} elsif ($s =~ /^.(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?($Ident)\b\s*(?!:)/s) {
c45dcabd2   Andy Whitcroft   update checkpatch...
3246
  				possible($1, "B:" . $s);
c2fdda0df   Andy Whitcroft   update checkpatch...
3247
  			}
8905a67c6   Andy Whitcroft   update checkpatch...
3248
3249
  
  			# any (foo ... *) is a pointer cast, and foo is a type
65863862b   Andy Whitcroft   checkpatch: dissa...
3250
  			while ($s =~ /\(($Ident)(?:\s+$Sparse)*[\s\*]+\s*\)/sg) {
c45dcabd2   Andy Whitcroft   update checkpatch...
3251
  				possible($1, "C:" . $s);
8905a67c6   Andy Whitcroft   update checkpatch...
3252
3253
3254
3255
3256
  			}
  
  			# Check for any sort of function declaration.
  			# int foo(something bar, other baz);
  			# void (*store_gdt)(x86_descr_ptr *);
171ae1a49   Andy Whitcroft   update checkpatch...
3257
  			if ($prev_values eq 'E' && $s =~ /^(.(?:typedef\s*)?(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(?:\b$Ident|\(\*\s*$Ident\))\s*)\(/s) {
8905a67c6   Andy Whitcroft   update checkpatch...
3258
  				my ($name_len) = length($1);
8905a67c6   Andy Whitcroft   update checkpatch...
3259

cf655043d   Andy Whitcroft   update checkpatch...
3260
  				my $ctx = $s;
773647a09   Andy Whitcroft   update checkpatch...
3261
  				substr($ctx, 0, $name_len + 1, '');
8905a67c6   Andy Whitcroft   update checkpatch...
3262
  				$ctx =~ s/\)[^\)]*$//;
cf655043d   Andy Whitcroft   update checkpatch...
3263

8905a67c6   Andy Whitcroft   update checkpatch...
3264
  				for my $arg (split(/\s*,\s*/, $ctx)) {
c45dcabd2   Andy Whitcroft   update checkpatch...
3265
  					if ($arg =~ /^(?:const\s+)?($Ident)(?:\s+$Sparse)*\s*\**\s*(:?\b$Ident)?$/s || $arg =~ /^($Ident)$/s) {
8905a67c6   Andy Whitcroft   update checkpatch...
3266

c45dcabd2   Andy Whitcroft   update checkpatch...
3267
  						possible($1, "D:" . $s);
8905a67c6   Andy Whitcroft   update checkpatch...
3268
3269
  					}
  				}
9c0ca6f9a   Andy Whitcroft   update checkpatch...
3270
  			}
8905a67c6   Andy Whitcroft   update checkpatch...
3271

9c0ca6f9a   Andy Whitcroft   update checkpatch...
3272
  		}
653d4876b   Andy Whitcroft   update checkpatch...
3273
3274
3275
  #
  # Checks which may be anchored in the context.
  #
00df344fd   Andy Whitcroft   update checkpatch...
3276

653d4876b   Andy Whitcroft   update checkpatch...
3277
3278
  # Check for switch () and associated case and default
  # statements should be at the same indent.
00df344fd   Andy Whitcroft   update checkpatch...
3279
3280
3281
3282
3283
3284
3285
3286
3287
3288
3289
3290
3291
3292
3293
3294
3295
3296
  		if ($line=~/\bswitch\s*\(.*\)/) {
  			my $err = '';
  			my $sep = '';
  			my @ctx = ctx_block_outer($linenr, $realcnt);
  			shift(@ctx);
  			for my $ctx (@ctx) {
  				my ($clen, $cindent) = line_stats($ctx);
  				if ($ctx =~ /^\+\s*(case\s+|default:)/ &&
  							$indent != $cindent) {
  					$err .= "$sep$ctx
  ";
  					$sep = '';
  				} else {
  					$sep = "[...]
  ";
  				}
  			}
  			if ($err ne '') {
000d1cc18   Joe Perches   checkpatch.pl: ad...
3297
3298
3299
  				ERROR("SWITCH_CASE_INDENT_LEVEL",
  				      "switch and case should be at the same indent
  $hereline$err");
de7d4f0e1   Andy Whitcroft   update checkpatch...
3300
3301
3302
3303
3304
  			}
  		}
  
  # if/while/etc brace do not go on next line, unless defining a do while loop,
  # or if that brace on the next line is for something else
0fe3dc2bc   Joe Perches   checkpatch: add f...
3305
  		if ($line =~ /(.*)\b((?:if|while|for|switch|(?:[a-z_]+|)for_each[a-z_]+)\s*\(|do\b|else\b)/ && $line !~ /^.\s*\#/) {
773647a09   Andy Whitcroft   update checkpatch...
3306
  			my $pre_ctx = "$1$2";
9c0ca6f9a   Andy Whitcroft   update checkpatch...
3307
  			my ($level, @ctx) = ctx_statement_level($linenr, $realcnt, 0);
8eef05dd3   Joe Perches   checkpatch: Warn ...
3308
3309
3310
3311
3312
3313
  
  			if ($line =~ /^\+\t{6,}/) {
  				WARN("DEEP_INDENTATION",
  				     "Too many leading tabs - consider code refactoring
  " . $herecurr);
  			}
de7d4f0e1   Andy Whitcroft   update checkpatch...
3314
3315
3316
  			my $ctx_cnt = $realcnt - $#ctx - 1;
  			my $ctx = join("
  ", @ctx);
548596d52   Andy Whitcroft   checkpatch: trail...
3317
3318
  			my $ctx_ln = $linenr;
  			my $ctx_skip = $realcnt;
773647a09   Andy Whitcroft   update checkpatch...
3319

548596d52   Andy Whitcroft   checkpatch: trail...
3320
3321
3322
3323
3324
3325
  			while ($ctx_skip > $ctx_cnt || ($ctx_skip == $ctx_cnt &&
  					defined $lines[$ctx_ln - 1] &&
  					$lines[$ctx_ln - 1] =~ /^-/)) {
  				##print "SKIP<$ctx_skip> CNT<$ctx_cnt>
  ";
  				$ctx_skip-- if (!defined $lines[$ctx_ln - 1] || $lines[$ctx_ln - 1] !~ /^-/);
de7d4f0e1   Andy Whitcroft   update checkpatch...
3326
  				$ctx_ln++;
de7d4f0e1   Andy Whitcroft   update checkpatch...
3327
  			}
548596d52   Andy Whitcroft   checkpatch: trail...
3328

53210168f   Andy Whitcroft   checkpatch: tough...
3329
3330
3331
3332
3333
3334
3335
  			#print "realcnt<$realcnt> ctx_cnt<$ctx_cnt>
  ";
  			#print "pre<$pre_ctx>
  line<$line>
  ctx<$ctx>
  next<$lines[$ctx_ln - 1]>
  ";
de7d4f0e1   Andy Whitcroft   update checkpatch...
3336

d752fcc88   Joe Perches   checkpatch: add a...
3337
  			if ($ctx !~ /{\s*/ && defined($lines[$ctx_ln - 1]) && $lines[$ctx_ln - 1] =~ /^\+\s*{/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
3338
3339
3340
  				ERROR("OPEN_BRACE",
  				      "that open brace { should be on the previous line
  " .
01464f30a   Andy Whitcroft   checkpatch: state...
3341
3342
3343
3344
  					"$here
  $ctx
  $rawlines[$ctx_ln - 1]
  ");
00df344fd   Andy Whitcroft   update checkpatch...
3345
  			}
773647a09   Andy Whitcroft   update checkpatch...
3346
3347
3348
3349
  			if ($level == 0 && $pre_ctx !~ /}\s*while\s*\($/ &&
  			    $ctx =~ /\)\s*\;\s*$/ &&
  			    defined $lines[$ctx_ln - 1])
  			{
9c0ca6f9a   Andy Whitcroft   update checkpatch...
3350
3351
  				my ($nlength, $nindent) = line_stats($lines[$ctx_ln - 1]);
  				if ($nindent > $indent) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
3352
3353
3354
  					WARN("TRAILING_SEMICOLON",
  					     "trailing semicolon indicates no statements, indent implies otherwise
  " .
01464f30a   Andy Whitcroft   checkpatch: state...
3355
3356
3357
3358
  						"$here
  $ctx
  $rawlines[$ctx_ln - 1]
  ");
9c0ca6f9a   Andy Whitcroft   update checkpatch...
3359
3360
  				}
  			}
00df344fd   Andy Whitcroft   update checkpatch...
3361
  		}
4d001e4d8   Andy Whitcroft   checkpatch: repor...
3362
  # Check relative indent for conditionals and blocks.
0fe3dc2bc   Joe Perches   checkpatch: add f...
3363
  		if ($line =~ /\b(?:(?:if|while|for|(?:[a-z_]+|)for_each[a-z_]+)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) {
3e469cdc0   Andy Whitcroft   checkpatch: optim...
3364
3365
3366
  			($stat, $cond, $line_nr_next, $remain_next, $off_next) =
  				ctx_statement_block($linenr, $realcnt, 0)
  					if (!defined $stat);
4d001e4d8   Andy Whitcroft   checkpatch: repor...
3367
3368
3369
  			my ($s, $c) = ($stat, $cond);
  
  			substr($s, 0, length($c), '');
9f5af480f   Joe Perches   checkpatch: impro...
3370
3371
3372
  			# remove inline comments
  			$s =~ s/$;/ /g;
  			$c =~ s/$;/ /g;
4d001e4d8   Andy Whitcroft   checkpatch: repor...
3373
3374
  
  			# Find out how long the conditional actually is.
6f779c18c   Andy Whitcroft   checkpatch: suspe...
3375
3376
3377
  			my @newlines = ($c =~ /
  /gs);
  			my $cond_lines = 1 + $#newlines;
4d001e4d8   Andy Whitcroft   checkpatch: repor...
3378

9f5af480f   Joe Perches   checkpatch: impro...
3379
3380
3381
3382
3383
3384
3385
3386
3387
3388
3389
3390
3391
3392
  			# Make sure we remove the line prefixes as we have
  			# none on the first line, and are going to readd them
  			# where necessary.
  			$s =~ s/
  ./
  /gs;
  			while ($s =~ /
  \s+\\
  /) {
  				$cond_lines += $s =~ s/
  \s+\\
  /
  /g;
  			}
4d001e4d8   Andy Whitcroft   checkpatch: repor...
3393
3394
3395
3396
3397
3398
3399
3400
3401
3402
3403
3404
  			# We want to check the first line inside the block
  			# starting at the end of the conditional, so remove:
  			#  1) any blank line termination
  			#  2) any opening brace { on end of the line
  			#  3) any do (...) {
  			my $continuation = 0;
  			my $check = 0;
  			$s =~ s/^.*\bdo\b//;
  			$s =~ s/^\s*{//;
  			if ($s =~ s/^\s*\\//) {
  				$continuation = 1;
  			}
9bd49efe4   Andy Whitcroft   checkpatch: suspe...
3405
3406
  			if ($s =~ s/^\s*?
  //) {
4d001e4d8   Andy Whitcroft   checkpatch: repor...
3407
3408
3409
3410
3411
3412
3413
3414
3415
3416
  				$check = 1;
  				$cond_lines++;
  			}
  
  			# Also ignore a loop construct at the end of a
  			# preprocessor statement.
  			if (($prevline =~ /^.\s*#\s*define\s/ ||
  			    $prevline =~ /\\\s*$/) && $continuation == 0) {
  				$check = 0;
  			}
9bd49efe4   Andy Whitcroft   checkpatch: suspe...
3417
  			my $cond_ptr = -1;
740504c61   Andy Whitcroft   checkpatch: suspe...
3418
  			$continuation = 0;
9bd49efe4   Andy Whitcroft   checkpatch: suspe...
3419
3420
  			while ($cond_ptr != $cond_lines) {
  				$cond_ptr = $cond_lines;
f16fa28f7   Andy Whitcroft   checkpatch: suspe...
3421
3422
3423
3424
3425
  				# If we see an #else/#elif then the code
  				# is not linear.
  				if ($s =~ /^\s*\#\s*(?:else|elif)/) {
  					$check = 0;
  				}
9bd49efe4   Andy Whitcroft   checkpatch: suspe...
3426
3427
3428
3429
  				# Ignore:
  				#  1) blank lines, they should be at 0,
  				#  2) preprocessor lines, and
  				#  3) labels.
740504c61   Andy Whitcroft   checkpatch: suspe...
3430
3431
3432
  				if ($continuation ||
  				    $s =~ /^\s*?
  / ||
9bd49efe4   Andy Whitcroft   checkpatch: suspe...
3433
3434
  				    $s =~ /^\s*#\s*?/ ||
  				    $s =~ /^\s*$Ident\s*:/) {
740504c61   Andy Whitcroft   checkpatch: suspe...
3435
3436
  					$continuation = ($s =~ /^.*?\\
  /) ? 1 : 0;
30dad6ebe   Andy Whitcroft   checkpatch: inden...
3437
3438
3439
3440
  					if ($s =~ s/^.*?
  //) {
  						$cond_lines++;
  					}
9bd49efe4   Andy Whitcroft   checkpatch: suspe...
3441
  				}
4d001e4d8   Andy Whitcroft   checkpatch: repor...
3442
3443
3444
3445
3446
3447
3448
3449
3450
3451
3452
3453
3454
3455
3456
  			}
  
  			my (undef, $sindent) = line_stats("+" . $s);
  			my $stat_real = raw_line($linenr, $cond_lines);
  
  			# Check if either of these lines are modified, else
  			# this is not this patch's fault.
  			if (!defined($stat_real) ||
  			    $stat !~ /^\+/ && $stat_real !~ /^\+/) {
  				$check = 0;
  			}
  			if (defined($stat_real) && $cond_lines > 1) {
  				$stat_real = "[...]
  $stat_real";
  			}
9bd49efe4   Andy Whitcroft   checkpatch: suspe...
3457
3458
  			#print "line<$line> prevline<$prevline> indent<$indent> sindent<$sindent> check<$check> continuation<$continuation> s<$s> cond_lines<$cond_lines> stat_real<$stat_real> stat<$stat>
  ";
4d001e4d8   Andy Whitcroft   checkpatch: repor...
3459

9f5af480f   Joe Perches   checkpatch: impro...
3460
3461
3462
3463
  			if ($check && $s ne '' &&
  			    (($sindent % 8) != 0 ||
  			     ($sindent < $indent) ||
  			     ($sindent > $indent + 8))) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
3464
3465
3466
3467
  				WARN("SUSPECT_CODE_INDENT",
  				     "suspect code indent for conditional statements ($indent, $sindent)
  " . $herecurr . "$stat_real
  ");
4d001e4d8   Andy Whitcroft   checkpatch: repor...
3468
3469
  			}
  		}
6c72ffaab   Andy Whitcroft   update checkpatch...
3470
3471
  		# Track the 'values' across context and added lines.
  		my $opline = $line; $opline =~ s/^./ /;
1f65f947a   Andy Whitcroft   checkpatch: add c...
3472
3473
3474
  		my ($curr_values, $curr_vars) =
  				annotate_values($opline . "
  ", $prev_values);
6c72ffaab   Andy Whitcroft   update checkpatch...
3475
  		$curr_values = $prev_values . $curr_values;
c2fdda0df   Andy Whitcroft   update checkpatch...
3476
3477
  		if ($dbg_values) {
  			my $outline = $opline; $outline =~ s/\t/ /g;
cf655043d   Andy Whitcroft   update checkpatch...
3478
3479
3480
3481
  			print "$linenr > .$outline
  ";
  			print "$linenr > $curr_values
  ";
1f65f947a   Andy Whitcroft   checkpatch: add c...
3482
3483
  			print "$linenr >  $curr_vars
  ";
c2fdda0df   Andy Whitcroft   update checkpatch...
3484
  		}
6c72ffaab   Andy Whitcroft   update checkpatch...
3485
  		$prev_values = substr($curr_values, -1);
00df344fd   Andy Whitcroft   update checkpatch...
3486
  #ignore lines not being added
3705ce5bc   Joe Perches   checkpatch: creat...
3487
  		next if ($line =~ /^[^\+]/);
00df344fd   Andy Whitcroft   update checkpatch...
3488

a1ce18e4f   Joe Perches   checkpatch: warn ...
3489
  # check for declarations of signed or unsigned without int
c84471157   Joe Perches   checkpatch: impro...
3490
  		while ($line =~ m{\b($Declare)\s*(?!char\b|short\b|int\b|long\b)\s*($Ident)?\s*[=,;\[\)\(]}g) {
a1ce18e4f   Joe Perches   checkpatch: warn ...
3491
3492
  			my $type = $1;
  			my $var = $2;
207a8e846   Joe Perches   checkpatch: impro...
3493
3494
  			$var = "" if (!defined $var);
  			if ($type =~ /^(?:(?:$Storage|$Inline|$Attribute)\s+)*((?:un)?signed)((?:\s*\*)*)\s*$/) {
a1ce18e4f   Joe Perches   checkpatch: warn ...
3495
3496
3497
3498
3499
3500
3501
3502
3503
3504
  				my $sign = $1;
  				my $pointer = $2;
  
  				$pointer = "" if (!defined $pointer);
  
  				if (WARN("UNSPECIFIED_INT",
  					 "Prefer '" . trim($sign) . " int" . rtrim($pointer) . "' to bare use of '$sign" . rtrim($pointer) . "'
  " . $herecurr) &&
  				    $fix) {
  					my $decl = trim($sign) . " int ";
207a8e846   Joe Perches   checkpatch: impro...
3505
3506
3507
3508
3509
  					my $comp_pointer = $pointer;
  					$comp_pointer =~ s/\s//g;
  					$decl .= $comp_pointer;
  					$decl = rtrim($decl) if ($var eq "");
  					$fixed[$fixlinenr] =~ s@\b$sign\s*\Q$pointer\E\s*$var\b@$decl$var@;
a1ce18e4f   Joe Perches   checkpatch: warn ...
3510
3511
3512
  				}
  			}
  		}
653d4876b   Andy Whitcroft   update checkpatch...
3513
  # TEST: allow direct testing of the type matcher.
7429c6903   Andy Whitcroft   checkpatch: impro...
3514
3515
  		if ($dbg_type) {
  			if ($line =~ /^.\s*$Declare\s*$/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
3516
3517
3518
  				ERROR("TEST_TYPE",
  				      "TEST: is type
  " . $herecurr);
7429c6903   Andy Whitcroft   checkpatch: impro...
3519
  			} elsif ($dbg_type > 1 && $line =~ /^.+($Declare)/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
3520
3521
3522
  				ERROR("TEST_NOT_TYPE",
  				      "TEST: is not type ($1 is)
  ". $herecurr);
7429c6903   Andy Whitcroft   checkpatch: impro...
3523
  			}
653d4876b   Andy Whitcroft   update checkpatch...
3524
3525
  			next;
  		}
a1ef277e2   Andy Whitcroft   checkpatch: add t...
3526
3527
  # TEST: allow direct testing of the attribute matcher.
  		if ($dbg_attr) {
9360b0e50   Andy Whitcroft   checkpatch: exten...
3528
  			if ($line =~ /^.\s*$Modifier\s*$/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
3529
3530
3531
  				ERROR("TEST_ATTR",
  				      "TEST: is attr
  " . $herecurr);
9360b0e50   Andy Whitcroft   checkpatch: exten...
3532
  			} elsif ($dbg_attr > 1 && $line =~ /^.+($Modifier)/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
3533
3534
3535
  				ERROR("TEST_NOT_ATTR",
  				      "TEST: is not attr ($1 is)
  ". $herecurr);
a1ef277e2   Andy Whitcroft   checkpatch: add t...
3536
3537
3538
  			}
  			next;
  		}
653d4876b   Andy Whitcroft   update checkpatch...
3539

f0a594c1c   Andy Whitcroft   update checkpatch...
3540
  # check for initialisation to aggregates open brace on the next line
99423c206   Andy Whitcroft   checkpatch: fix _...
3541
3542
  		if ($line =~ /^.\s*{/ &&
  		    $prevline =~ /(?:^|[^=])=\s*$/) {
d752fcc88   Joe Perches   checkpatch: add a...
3543
3544
3545
  			if (ERROR("OPEN_BRACE",
  				  "that open brace { should be on the previous line
  " . $hereprev) &&
f2d7e4d43   Joe Perches   checkpatch: add f...
3546
3547
3548
  			    $fix && $prevline =~ /^\+/ && $line =~ /^\+/) {
  				fix_delete_line($fixlinenr - 1, $prevrawline);
  				fix_delete_line($fixlinenr, $rawline);
d752fcc88   Joe Perches   checkpatch: add a...
3549
3550
  				my $fixedline = $prevrawline;
  				$fixedline =~ s/\s*=\s*$/ = {/;
f2d7e4d43   Joe Perches   checkpatch: add f...
3551
  				fix_insert_line($fixlinenr, $fixedline);
d752fcc88   Joe Perches   checkpatch: add a...
3552
3553
  				$fixedline = $line;
  				$fixedline =~ s/^(.\s*){\s*/$1/;
f2d7e4d43   Joe Perches   checkpatch: add f...
3554
  				fix_insert_line($fixlinenr, $fixedline);
d752fcc88   Joe Perches   checkpatch: add a...
3555
  			}
f0a594c1c   Andy Whitcroft   update checkpatch...
3556
  		}
653d4876b   Andy Whitcroft   update checkpatch...
3557
3558
3559
3560
3561
  #
  # Checks which are anchored on the added line.
  #
  
  # check for malformed paths in #include statements (uses RAW line)
c45dcabd2   Andy Whitcroft   update checkpatch...
3562
  		if ($rawline =~ m{^.\s*\#\s*include\s+[<"](.*)[">]}) {
653d4876b   Andy Whitcroft   update checkpatch...
3563
3564
  			my $path = $1;
  			if ($path =~ m{//}) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
3565
  				ERROR("MALFORMED_INCLUDE",
495e9d846   Joe Perches   checkpatch: warn ...
3566
3567
3568
3569
3570
3571
3572
  				      "malformed #include filename
  " . $herecurr);
  			}
  			if ($path =~ "^uapi/" && $realfile =~ m@\binclude/uapi/@) {
  				ERROR("UAPI_INCLUDE",
  				      "No #include in ...include/uapi/... should use a uapi/ path prefix
  " . $herecurr);
653d4876b   Andy Whitcroft   update checkpatch...
3573
  			}
653d4876b   Andy Whitcroft   update checkpatch...
3574
  		}
00df344fd   Andy Whitcroft   update checkpatch...
3575

0a920b5b6   Andy Whitcroft   add a trivial pat...
3576
  # no C99 // comments
00df344fd   Andy Whitcroft   update checkpatch...
3577
  		if ($line =~ m{//}) {
3705ce5bc   Joe Perches   checkpatch: creat...
3578
3579
3580
3581
  			if (ERROR("C99_COMMENTS",
  				  "do not use C99 // comments
  " . $herecurr) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
3582
  				my $line = $fixed[$fixlinenr];
3705ce5bc   Joe Perches   checkpatch: creat...
3583
3584
  				if ($line =~ /\/\/(.*)$/) {
  					my $comment = trim($1);
194f66fc9   Joe Perches   checkpatch: add a...
3585
  					$fixed[$fixlinenr] =~ s@\/\/(.*)$@/\* $comment \*/@;
3705ce5bc   Joe Perches   checkpatch: creat...
3586
3587
  				}
  			}
0a920b5b6   Andy Whitcroft   add a trivial pat...
3588
  		}
00df344fd   Andy Whitcroft   update checkpatch...
3589
  		# Remove C99 comments.
0a920b5b6   Andy Whitcroft   add a trivial pat...
3590
  		$line =~ s@//.*@@;
6c72ffaab   Andy Whitcroft   update checkpatch...
3591
  		$opline =~ s@//.*@@;
0a920b5b6   Andy Whitcroft   add a trivial pat...
3592

2b474a1a5   Andy Whitcroft   checkpatch: fix f...
3593
3594
3595
3596
3597
3598
3599
3600
3601
  # EXPORT_SYMBOL should immediately follow the thing it is exporting, consider
  # the whole statement.
  #print "APW <$lines[$realline_next - 1]>
  ";
  		if (defined $realline_next &&
  		    exists $lines[$realline_next - 1] &&
  		    !defined $suppress_export{$realline_next} &&
  		    ($lines[$realline_next - 1] =~ /EXPORT_SYMBOL.*\((.*)\)/ ||
  		     $lines[$realline_next - 1] =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
3cbf62df3   Andy Whitcroft   checkpatch: handl...
3602
3603
3604
3605
  			# Handle definitions which produce identifiers with
  			# a prefix:
  			#   XXX(foo);
  			#   EXPORT_SYMBOL(something_foo);
653d4876b   Andy Whitcroft   update checkpatch...
3606
  			my $name = $1;
87a538771   Andy Whitcroft   checkpatch: fix E...
3607
3608
  			if ($stat =~ /^(?:.\s*}\s*
  )?.([A-Z_]+)\s*\(\s*($Ident)/ &&
3cbf62df3   Andy Whitcroft   checkpatch: handl...
3609
3610
3611
3612
3613
3614
  			    $name =~ /^${Ident}_$2/) {
  #print "FOO C name<$name>
  ";
  				$suppress_export{$realline_next} = 1;
  
  			} elsif ($stat !~ /(?:
2b474a1a5   Andy Whitcroft   checkpatch: fix f...
3615
3616
  				
  .}\s*$|
480120586   Andy Whitcroft   checkpatch: DEFIN...
3617
3618
3619
  				^.DEFINE_$Ident\(\Q$name\E\)|
  				^.DECLARE_$Ident\(\Q$name\E\)|
  				^.LIST_HEAD\(\Q$name\E\)|
2b474a1a5   Andy Whitcroft   checkpatch: fix f...
3620
3621
  				^.(?:$Storage\s+)?$Type\s*\(\s*\*\s*\Q$name\E\s*\)\s*\(|
  				\b\Q$name\E(?:\s+$Attribute)*\s*(?:;|=|\[|\()
480120586   Andy Whitcroft   checkpatch: DEFIN...
3622
  			    )/x) {
2b474a1a5   Andy Whitcroft   checkpatch: fix f...
3623
3624
3625
3626
3627
  #print "FOO A<$lines[$realline_next - 1]> stat<$stat> name<$name>
  ";
  				$suppress_export{$realline_next} = 2;
  			} else {
  				$suppress_export{$realline_next} = 1;
0a920b5b6   Andy Whitcroft   add a trivial pat...
3628
3629
  			}
  		}
2b474a1a5   Andy Whitcroft   checkpatch: fix f...
3630
3631
3632
3633
3634
3635
3636
3637
3638
3639
  		if (!defined $suppress_export{$linenr} &&
  		    $prevline =~ /^.\s*$/ &&
  		    ($line =~ /EXPORT_SYMBOL.*\((.*)\)/ ||
  		     $line =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
  #print "FOO B <$lines[$linenr - 1]>
  ";
  			$suppress_export{$linenr} = 2;
  		}
  		if (defined $suppress_export{$linenr} &&
  		    $suppress_export{$linenr} == 2) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
3640
3641
3642
  			WARN("EXPORT_SYMBOL",
  			     "EXPORT_SYMBOL(foo); should immediately follow its function/variable
  " . $herecurr);
2b474a1a5   Andy Whitcroft   checkpatch: fix f...
3643
  		}
0a920b5b6   Andy Whitcroft   add a trivial pat...
3644

5150bda43   Joe Eloff   checkpatch: chang...
3645
  # check for global initialisers.
6d32f7a39   Joe Perches   checkpatch: impro...
3646
  		if ($line =~ /^\+$Type\s*$Ident(?:\s+$Modifier)*\s*=\s*($zero_initializer)\s*;/) {
d5e616fc1   Joe Perches   checkpatch: add a...
3647
  			if (ERROR("GLOBAL_INITIALISERS",
6d32f7a39   Joe Perches   checkpatch: impro...
3648
3649
  				  "do not initialise globals to $1
  " . $herecurr) &&
d5e616fc1   Joe Perches   checkpatch: add a...
3650
  			    $fix) {
6d32f7a39   Joe Perches   checkpatch: impro...
3651
  				$fixed[$fixlinenr] =~ s/(^.$Type\s*$Ident(?:\s+$Modifier)*)\s*=\s*$zero_initializer\s*;/$1;/;
d5e616fc1   Joe Perches   checkpatch: add a...
3652
  			}
f0a594c1c   Andy Whitcroft   update checkpatch...
3653
  		}
653d4876b   Andy Whitcroft   update checkpatch...
3654
  # check for static initialisers.
6d32f7a39   Joe Perches   checkpatch: impro...
3655
  		if ($line =~ /^\+.*\bstatic\s.*=\s*($zero_initializer)\s*;/) {
d5e616fc1   Joe Perches   checkpatch: add a...
3656
  			if (ERROR("INITIALISED_STATIC",
6d32f7a39   Joe Perches   checkpatch: impro...
3657
3658
  				  "do not initialise statics to $1
  " .
d5e616fc1   Joe Perches   checkpatch: add a...
3659
3660
  				      $herecurr) &&
  			    $fix) {
6d32f7a39   Joe Perches   checkpatch: impro...
3661
  				$fixed[$fixlinenr] =~ s/(\bstatic\s.*?)\s*=\s*$zero_initializer\s*;/$1;/;
d5e616fc1   Joe Perches   checkpatch: add a...
3662
  			}
0a920b5b6   Andy Whitcroft   add a trivial pat...
3663
  		}
1813087db   Joe Perches   checkpatch: add t...
3664
3665
3666
3667
3668
3669
3670
  # check for misordered declarations of char/short/int/long with signed/unsigned
  		while ($sline =~ m{(\b$TypeMisordered\b)}g) {
  			my $tmp = trim($1);
  			WARN("MISORDERED_TYPE",
  			     "type '$tmp' should be specified in [[un]signed] [short|int|long|long long] order
  " . $herecurr);
  		}
cb710eca6   Joe Perches   scripts/checkpatc...
3671
3672
  # check for static const char * arrays.
  		if ($line =~ /\bstatic\s+const\s+char\s*\*\s*(\w+)\s*\[\s*\]\s*=\s*/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
3673
3674
3675
  			WARN("STATIC_CONST_CHAR_ARRAY",
  			     "static const char * array should probably be static const char * const
  " .
cb710eca6   Joe Perches   scripts/checkpatc...
3676
3677
3678
3679
3680
  				$herecurr);
                 }
  
  # check for static char foo[] = "bar" declarations.
  		if ($line =~ /\bstatic\s+char\s+(\w+)\s*\[\s*\]\s*=\s*"/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
3681
3682
3683
  			WARN("STATIC_CONST_CHAR_ARRAY",
  			     "static char array declaration should probably be static const char
  " .
cb710eca6   Joe Perches   scripts/checkpatc...
3684
3685
  				$herecurr);
                 }
ab7e23f34   Joe Perches   checkpatch: add t...
3686
3687
3688
3689
3690
3691
3692
3693
3694
3695
3696
3697
3698
  # check for const <foo> const where <foo> is not a pointer or array type
  		if ($sline =~ /\bconst\s+($BasicType)\s+const\b/) {
  			my $found = $1;
  			if ($sline =~ /\bconst\s+\Q$found\E\s+const\b\s*\*/) {
  				WARN("CONST_CONST",
  				     "'const $found const *' should probably be 'const $found * const'
  " . $herecurr);
  			} elsif ($sline !~ /\bconst\s+\Q$found\E\s+const\s+\w+\s*\[/) {
  				WARN("CONST_CONST",
  				     "'const $found const' should probably be 'const $found'
  " . $herecurr);
  			}
  		}
9b0fa60d9   Joe Perches   checkpatch: add t...
3699
3700
3701
3702
3703
3704
3705
  # check for non-global char *foo[] = {"bar", ...} declarations.
  		if ($line =~ /^.\s+(?:static\s+|const\s+)?char\s+\*\s*\w+\s*\[\s*\]\s*=\s*\{/) {
  			WARN("STATIC_CONST_CHAR_ARRAY",
  			     "char * array declaration might be better as static const
  " .
  				$herecurr);
                 }
b598b6706   Joe Perches   checkpatch: add '...
3706
3707
3708
3709
3710
3711
3712
3713
3714
3715
3716
3717
3718
  # check for sizeof(foo)/sizeof(foo[0]) that could be ARRAY_SIZE(foo)
  		if ($line =~ m@\bsizeof\s*\(\s*($Lval)\s*\)@) {
  			my $array = $1;
  			if ($line =~ m@\b(sizeof\s*\(\s*\Q$array\E\s*\)\s*/\s*sizeof\s*\(\s*\Q$array\E\s*\[\s*0\s*\]\s*\))@) {
  				my $array_div = $1;
  				if (WARN("ARRAY_SIZE",
  					 "Prefer ARRAY_SIZE($array)
  " . $herecurr) &&
  				    $fix) {
  					$fixed[$fixlinenr] =~ s/\Q$array_div\E/ARRAY_SIZE($array)/;
  				}
  			}
  		}
b36190c5f   Joe Perches   checkpatch.pl: ch...
3719
3720
3721
3722
3723
3724
  # check for function declarations without arguments like "int foo()"
  		if ($line =~ /(\b$Type\s+$Ident)\s*\(\s*\)/) {
  			if (ERROR("FUNCTION_WITHOUT_ARGS",
  				  "Bad function definition - $1() should probably be $1(void)
  " . $herecurr) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
3725
  				$fixed[$fixlinenr] =~ s/(\b($Type)\s+($Ident))\s*\(\s*\)/$2 $3(void)/;
b36190c5f   Joe Perches   checkpatch.pl: ch...
3726
3727
  			}
  		}
653d4876b   Andy Whitcroft   update checkpatch...
3728
3729
3730
  # check for new typedefs, only function parameters and sparse annotations
  # make sense.
  		if ($line =~ /\btypedef\s/ &&
8054576dc   Andy Whitcroft   checkpatch: loose...
3731
  		    $line !~ /\btypedef\s+$Type\s*\(\s*\*?$Ident\s*\)\s*\(/ &&
c45dcabd2   Andy Whitcroft   update checkpatch...
3732
  		    $line !~ /\btypedef\s+$Type\s+$Ident\s*\(/ &&
8ed22cad9   Andy Whitcroft   checkpatch: pull ...
3733
  		    $line !~ /\b$typeTypedefs\b/ &&
653d4876b   Andy Whitcroft   update checkpatch...
3734
  		    $line !~ /\b__bitwise(?:__|)\b/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
3735
3736
3737
  			WARN("NEW_TYPEDEFS",
  			     "do not add new typedefs
  " . $herecurr);
0a920b5b6   Andy Whitcroft   add a trivial pat...
3738
3739
3740
  		}
  
  # * goes on variable not on type
65863862b   Andy Whitcroft   checkpatch: dissa...
3741
  		# (char*[ const])
bfcb2cc79   Andy Whitcroft   checkpatch: catch...
3742
3743
3744
  		while ($line =~ m{(\($NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)\))}g) {
  			#print "AA<$1>
  ";
3705ce5bc   Joe Perches   checkpatch: creat...
3745
  			my ($ident, $from, $to) = ($1, $2, $2);
65863862b   Andy Whitcroft   checkpatch: dissa...
3746
3747
3748
3749
3750
3751
  
  			# Should start with a space.
  			$to =~ s/^(\S)/ $1/;
  			# Should not end with a space.
  			$to =~ s/\s+$//;
  			# '*'s should not have spaces between.
f9a0b3d17   Andy Whitcroft   checkpatch: type/...
3752
  			while ($to =~ s/\*\s+\*/\*\*/) {
65863862b   Andy Whitcroft   checkpatch: dissa...
3753
  			}
d8aaf1214   Andy Whitcroft   update checkpatch...
3754

3705ce5bc   Joe Perches   checkpatch: creat...
3755
3756
  ##			print "1: from<$from> to<$to> ident<$ident>
  ";
65863862b   Andy Whitcroft   checkpatch: dissa...
3757
  			if ($from ne $to) {
3705ce5bc   Joe Perches   checkpatch: creat...
3758
3759
3760
3761
3762
3763
3764
  				if (ERROR("POINTER_LOCATION",
  					  "\"(foo$from)\" should be \"(foo$to)\"
  " .  $herecurr) &&
  				    $fix) {
  					my $sub_from = $ident;
  					my $sub_to = $ident;
  					$sub_to =~ s/\Q$from\E/$to/;
194f66fc9   Joe Perches   checkpatch: add a...
3765
  					$fixed[$fixlinenr] =~
3705ce5bc   Joe Perches   checkpatch: creat...
3766
3767
  					    s@\Q$sub_from\E@$sub_to@;
  				}
65863862b   Andy Whitcroft   checkpatch: dissa...
3768
  			}
bfcb2cc79   Andy Whitcroft   checkpatch: catch...
3769
3770
3771
3772
  		}
  		while ($line =~ m{(\b$NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)($Ident))}g) {
  			#print "BB<$1>
  ";
3705ce5bc   Joe Perches   checkpatch: creat...
3773
  			my ($match, $from, $to, $ident) = ($1, $2, $2, $3);
65863862b   Andy Whitcroft   checkpatch: dissa...
3774
3775
3776
3777
3778
3779
  
  			# Should start with a space.
  			$to =~ s/^(\S)/ $1/;
  			# Should not end with a space.
  			$to =~ s/\s+$//;
  			# '*'s should not have spaces between.
f9a0b3d17   Andy Whitcroft   checkpatch: type/...
3780
  			while ($to =~ s/\*\s+\*/\*\*/) {
65863862b   Andy Whitcroft   checkpatch: dissa...
3781
3782
3783
  			}
  			# Modifiers should have spaces.
  			$to =~ s/(\b$Modifier$)/$1 /;
d8aaf1214   Andy Whitcroft   update checkpatch...
3784

3705ce5bc   Joe Perches   checkpatch: creat...
3785
3786
  ##			print "2: from<$from> to<$to> ident<$ident>
  ";
667026e7b   Andy Whitcroft   checkpatch: a mod...
3787
  			if ($from ne $to && $ident !~ /^$Modifier$/) {
3705ce5bc   Joe Perches   checkpatch: creat...
3788
3789
3790
3791
3792
3793
3794
3795
  				if (ERROR("POINTER_LOCATION",
  					  "\"foo${from}bar\" should be \"foo${to}bar\"
  " .  $herecurr) &&
  				    $fix) {
  
  					my $sub_from = $match;
  					my $sub_to = $match;
  					$sub_to =~ s/\Q$from\E/$to/;
194f66fc9   Joe Perches   checkpatch: add a...
3796
  					$fixed[$fixlinenr] =~
3705ce5bc   Joe Perches   checkpatch: creat...
3797
3798
  					    s@\Q$sub_from\E@$sub_to@;
  				}
65863862b   Andy Whitcroft   checkpatch: dissa...
3799
  			}
0a920b5b6   Andy Whitcroft   add a trivial pat...
3800
  		}
9d3e3c705   Joe Perches   checkpatch: add w...
3801
3802
3803
3804
3805
3806
3807
3808
  # avoid BUG() or BUG_ON()
  		if ($line =~ /\b(?:BUG|BUG_ON)\b/) {
  			my $msg_type = \&WARN;
  			$msg_type = \&CHK if ($file);
  			&{$msg_type}("AVOID_BUG",
  				     "Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
  " . $herecurr);
  		}
0a920b5b6   Andy Whitcroft   add a trivial pat...
3809

9d3e3c705   Joe Perches   checkpatch: add w...
3810
  # avoid LINUX_VERSION_CODE
8905a67c6   Andy Whitcroft   update checkpatch...
3811
  		if ($line =~ /\bLINUX_VERSION_CODE\b/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
3812
3813
3814
  			WARN("LINUX_VERSION_CODE",
  			     "LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged
  " . $herecurr);
8905a67c6   Andy Whitcroft   update checkpatch...
3815
  		}
17441227f   Joe Perches   checkpatch: add w...
3816
3817
  # check for uses of printk_ratelimit
  		if ($line =~ /\bprintk_ratelimit\s*\(/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
3818
  			WARN("PRINTK_RATELIMITED",
101ee6802   Joe Perches   checkpatch: neate...
3819
3820
  			     "Prefer printk_ratelimited or pr_<level>_ratelimited to printk_ratelimit
  " . $herecurr);
17441227f   Joe Perches   checkpatch: add w...
3821
  		}
00df344fd   Andy Whitcroft   update checkpatch...
3822
3823
3824
  # printk should use KERN_* levels.  Note that follow on printk's on the
  # same line do not need a level, so we use the current block context
  # to try and find and validate the current printk.  In summary the current
25985edce   Lucas De Marchi   Fix common misspe...
3825
  # printk includes all preceding printk's which have no newline on the end.
00df344fd   Andy Whitcroft   update checkpatch...
3826
  # we assume the first bad printk is the one to report.
f0a594c1c   Andy Whitcroft   update checkpatch...
3827
  		if ($line =~ /\bprintk\((?!KERN_)\s*"/) {
00df344fd   Andy Whitcroft   update checkpatch...
3828
3829
3830
3831
  			my $ok = 0;
  			for (my $ln = $linenr - 1; $ln >= $first_line; $ln--) {
  				#print "CHECK<$lines[$ln - 1]
  ";
25985edce   Lucas De Marchi   Fix common misspe...
3832
  				# we have a preceding printk if it ends
00df344fd   Andy Whitcroft   update checkpatch...
3833
3834
3835
3836
3837
3838
3839
3840
3841
3842
3843
  				# with "
  " ignore it, else it is to blame
  				if ($lines[$ln - 1] =~ m{\bprintk\(}) {
  					if ($rawlines[$ln - 1] !~ m{\
  "}) {
  						$ok = 1;
  					}
  					last;
  				}
  			}
  			if ($ok == 0) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
3844
3845
3846
  				WARN("PRINTK_WITHOUT_KERN_LEVEL",
  				     "printk() should include KERN_ facility level
  " . $herecurr);
00df344fd   Andy Whitcroft   update checkpatch...
3847
  			}
0a920b5b6   Andy Whitcroft   add a trivial pat...
3848
  		}
243f3803c   Joe Perches   checkpatch: sugge...
3849
3850
3851
3852
  		if ($line =~ /\bprintk\s*\(\s*KERN_([A-Z]+)/) {
  			my $orig = $1;
  			my $level = lc($orig);
  			$level = "warn" if ($level eq "warning");
8f26b8376   Joe Perches   checkpatch: updat...
3853
3854
  			my $level2 = $level;
  			$level2 = "dbg" if ($level eq "debug");
243f3803c   Joe Perches   checkpatch: sugge...
3855
  			WARN("PREFER_PR_LEVEL",
daa8b0592   Yogesh Chaudhari   checkpatch.pl: mo...
3856
3857
  			     "Prefer [subsystem eg: netdev]_$level2([subsystem]dev, ... then dev_$level2(dev, ... then pr_$level(...  to printk(KERN_$orig ...
  " . $herecurr);
243f3803c   Joe Perches   checkpatch: sugge...
3858
3859
3860
  		}
  
  		if ($line =~ /\bpr_warning\s*\(/) {
d5e616fc1   Joe Perches   checkpatch: add a...
3861
3862
3863
3864
  			if (WARN("PREFER_PR_LEVEL",
  				 "Prefer pr_warn(... to pr_warning(...
  " . $herecurr) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
3865
  				$fixed[$fixlinenr] =~
d5e616fc1   Joe Perches   checkpatch: add a...
3866
3867
  				    s/\bpr_warning\b/pr_warn/;
  			}
243f3803c   Joe Perches   checkpatch: sugge...
3868
  		}
dc1393130   Joe Perches   checkpatch: prefe...
3869
3870
3871
3872
3873
3874
3875
3876
3877
  		if ($line =~ /\bdev_printk\s*\(\s*KERN_([A-Z]+)/) {
  			my $orig = $1;
  			my $level = lc($orig);
  			$level = "warn" if ($level eq "warning");
  			$level = "dbg" if ($level eq "debug");
  			WARN("PREFER_DEV_LEVEL",
  			     "Prefer dev_$level(... to dev_printk(KERN_$orig, ...
  " . $herecurr);
  		}
91c9afaf9   Andy Lutomirski   checkpatch.pl: ne...
3878
3879
3880
3881
3882
3883
3884
3885
  # ENOSYS means "bad syscall nr" and nothing else.  This will have a small
  # number of false positives, but assembly files are not checked, so at
  # least the arch entry code will not trigger this warning.
  		if ($line =~ /\bENOSYS\b/) {
  			WARN("ENOSYS",
  			     "ENOSYS means 'invalid syscall nr' and nothing else
  " . $herecurr);
  		}
653d4876b   Andy Whitcroft   update checkpatch...
3886
3887
  # function brace can't be on same line, except for #defines of do while,
  # or if closed on same line
8d1824780   Joe Perches   checkpatch: add -...
3888
  		if (($line=~/$Type\s*$Ident\(.*\).*\s*{/) and
4e5d56bdf   Eddie Kovsky   checkpatch: fix l...
3889
  		    !($line=~/\#\s*define.*do\s\{/) and !($line=~/}/)) {
8d1824780   Joe Perches   checkpatch: add -...
3890
3891
3892
3893
3894
3895
3896
3897
3898
3899
3900
3901
3902
3903
3904
  			if (ERROR("OPEN_BRACE",
  				  "open brace '{' following function declarations go on the next line
  " . $herecurr) &&
  			    $fix) {
  				fix_delete_line($fixlinenr, $rawline);
  				my $fixed_line = $rawline;
  				$fixed_line =~ /(^..*$Type\s*$Ident\(.*\)\s*){(.*)$/;
  				my $line1 = $1;
  				my $line2 = $2;
  				fix_insert_line($fixlinenr, ltrim($line1));
  				fix_insert_line($fixlinenr, "\+{");
  				if ($line2 !~ /^\s*$/) {
  					fix_insert_line($fixlinenr, "\+\t" . trim($line2));
  				}
  			}
0a920b5b6   Andy Whitcroft   add a trivial pat...
3905
  		}
653d4876b   Andy Whitcroft   update checkpatch...
3906

8905a67c6   Andy Whitcroft   update checkpatch...
3907
3908
3909
  # open braces for enum, union and struct go on the same line.
  		if ($line =~ /^.\s*{/ &&
  		    $prevline =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?\s*$/) {
8d1824780   Joe Perches   checkpatch: add -...
3910
3911
3912
3913
3914
3915
3916
3917
3918
3919
3920
3921
3922
3923
  			if (ERROR("OPEN_BRACE",
  				  "open brace '{' following $1 go on the same line
  " . $hereprev) &&
  			    $fix && $prevline =~ /^\+/ && $line =~ /^\+/) {
  				fix_delete_line($fixlinenr - 1, $prevrawline);
  				fix_delete_line($fixlinenr, $rawline);
  				my $fixedline = rtrim($prevrawline) . " {";
  				fix_insert_line($fixlinenr, $fixedline);
  				$fixedline = $rawline;
  				$fixedline =~ s/^(.\s*){\s*/$1\t/;
  				if ($fixedline !~ /^\+\s*$/) {
  					fix_insert_line($fixlinenr, $fixedline);
  				}
  			}
8905a67c6   Andy Whitcroft   update checkpatch...
3924
  		}
0c73b4eb7   Andy Whitcroft   checkpatch: simpl...
3925
  # missing space after union, struct or enum definition
3705ce5bc   Joe Perches   checkpatch: creat...
3926
3927
3928
3929
3930
  		if ($line =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident){1,2}[=\{]/) {
  			if (WARN("SPACING",
  				 "missing space after $1 definition
  " . $herecurr) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
3931
  				$fixed[$fixlinenr] =~
3705ce5bc   Joe Perches   checkpatch: creat...
3932
3933
  				    s/^(.\s*(?:typedef\s+)?(?:enum|union|struct)(?:\s+$Ident){1,2})([=\{])/$1 $2/;
  			}
0c73b4eb7   Andy Whitcroft   checkpatch: simpl...
3934
  		}
31070b5d4   Joe Perches   checkpatch: add t...
3935
3936
3937
  # Function pointer declarations
  # check spacing between type, funcptr, and args
  # canonical declaration is "type (*funcptr)(args...)"
91f72e9c6   Joe Perches   checkpatch: don't...
3938
  		if ($line =~ /^.\s*($Declare)\((\s*)\*(\s*)($Ident)(\s*)\)(\s*)\(/) {
31070b5d4   Joe Perches   checkpatch: add t...
3939
3940
3941
3942
3943
3944
  			my $declare = $1;
  			my $pre_pointer_space = $2;
  			my $post_pointer_space = $3;
  			my $funcname = $4;
  			my $post_funcname_space = $5;
  			my $pre_args_space = $6;
91f72e9c6   Joe Perches   checkpatch: don't...
3945
3946
3947
3948
3949
3950
3951
3952
3953
  # the $Declare variable will capture all spaces after the type
  # so check it for a missing trailing missing space but pointer return types
  # don't need a space so don't warn for those.
  			my $post_declare_space = "";
  			if ($declare =~ /(\s+)$/) {
  				$post_declare_space = $1;
  				$declare = rtrim($declare);
  			}
  			if ($declare !~ /\*$/ && $post_declare_space =~ /^$/) {
31070b5d4   Joe Perches   checkpatch: add t...
3954
3955
3956
  				WARN("SPACING",
  				     "missing space after return type
  " . $herecurr);
91f72e9c6   Joe Perches   checkpatch: don't...
3957
  				$post_declare_space = " ";
31070b5d4   Joe Perches   checkpatch: add t...
3958
3959
3960
  			}
  
  # unnecessary space "type  (*funcptr)(args...)"
91f72e9c6   Joe Perches   checkpatch: don't...
3961
3962
3963
3964
3965
3966
3967
3968
3969
3970
  # This test is not currently implemented because these declarations are
  # equivalent to
  #	int  foo(int bar, ...)
  # and this is form shouldn't/doesn't generate a checkpatch warning.
  #
  #			elsif ($declare =~ /\s{2,}$/) {
  #				WARN("SPACING",
  #				     "Multiple spaces after return type
  " . $herecurr);
  #			}
31070b5d4   Joe Perches   checkpatch: add t...
3971
3972
3973
3974
3975
3976
3977
3978
3979
3980
3981
3982
3983
3984
3985
3986
3987
3988
3989
3990
3991
3992
3993
3994
3995
3996
3997
3998
3999
4000
4001
4002
4003
4004
  
  # unnecessary space "type ( *funcptr)(args...)"
  			if (defined $pre_pointer_space &&
  			    $pre_pointer_space =~ /^\s/) {
  				WARN("SPACING",
  				     "Unnecessary space after function pointer open parenthesis
  " . $herecurr);
  			}
  
  # unnecessary space "type (* funcptr)(args...)"
  			if (defined $post_pointer_space &&
  			    $post_pointer_space =~ /^\s/) {
  				WARN("SPACING",
  				     "Unnecessary space before function pointer name
  " . $herecurr);
  			}
  
  # unnecessary space "type (*funcptr )(args...)"
  			if (defined $post_funcname_space &&
  			    $post_funcname_space =~ /^\s/) {
  				WARN("SPACING",
  				     "Unnecessary space after function pointer name
  " . $herecurr);
  			}
  
  # unnecessary space "type (*funcptr) (args...)"
  			if (defined $pre_args_space &&
  			    $pre_args_space =~ /^\s/) {
  				WARN("SPACING",
  				     "Unnecessary space before function pointer arguments
  " . $herecurr);
  			}
  
  			if (show_type("SPACING") && $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
4005
  				$fixed[$fixlinenr] =~
91f72e9c6   Joe Perches   checkpatch: don't...
4006
  				    s/^(.\s*)$Declare\s*\(\s*\*\s*$Ident\s*\)\s*\(/$1 . $declare . $post_declare_space . '(*' . $funcname . ')('/ex;
31070b5d4   Joe Perches   checkpatch: add t...
4007
4008
  			}
  		}
8d31cfcec   Andy Whitcroft   checkpatch: check...
4009
4010
  # check for spacing round square brackets; allowed:
  #  1. with a type on the left -- int [] a;
fe2a7dbc8   Andy Whitcroft   checkpatch: squar...
4011
4012
  #  2. at the beginning of a line for slice initialisers -- [0...10] = 5,
  #  3. inside a curly brace -- = { [0...10] = 5 }
8d31cfcec   Andy Whitcroft   checkpatch: check...
4013
4014
4015
  		while ($line =~ /(.*?\s)\[/g) {
  			my ($where, $prefix) = ($-[1], $1);
  			if ($prefix !~ /$Type\s+$/ &&
fe2a7dbc8   Andy Whitcroft   checkpatch: squar...
4016
  			    ($where != 0 || $prefix !~ /^.\s+$/) &&
daebc534a   Andy Whitcroft   checkpatch: catch...
4017
  			    $prefix !~ /[{,]\s+$/) {
3705ce5bc   Joe Perches   checkpatch: creat...
4018
4019
4020
4021
  				if (ERROR("BRACKET_SPACE",
  					  "space prohibited before open square bracket '['
  " . $herecurr) &&
  				    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
4022
  				    $fixed[$fixlinenr] =~
3705ce5bc   Joe Perches   checkpatch: creat...
4023
4024
  					s/^(\+.*?)\s+\[/$1\[/;
  				}
8d31cfcec   Andy Whitcroft   checkpatch: check...
4025
4026
  			}
  		}
f0a594c1c   Andy Whitcroft   update checkpatch...
4027
  # check for spaces between functions and their parentheses.
6c72ffaab   Andy Whitcroft   update checkpatch...
4028
  		while ($line =~ /($Ident)\s+\(/g) {
c2fdda0df   Andy Whitcroft   update checkpatch...
4029
  			my $name = $1;
773647a09   Andy Whitcroft   update checkpatch...
4030
4031
  			my $ctx_before = substr($line, 0, $-[1]);
  			my $ctx = "$ctx_before$name";
c2fdda0df   Andy Whitcroft   update checkpatch...
4032
4033
  
  			# Ignore those directives where spaces _are_ permitted.
773647a09   Andy Whitcroft   update checkpatch...
4034
4035
4036
4037
4038
4039
  			if ($name =~ /^(?:
  				if|for|while|switch|return|case|
  				volatile|__volatile__|
  				__attribute__|format|__extension__|
  				asm|__asm__)$/x)
  			{
c2fdda0df   Andy Whitcroft   update checkpatch...
4040
4041
4042
  			# cpp #define statements have non-optional spaces, ie
  			# if there is a space between the name and the open
  			# parenthesis it is simply not a parameter group.
c45dcabd2   Andy Whitcroft   update checkpatch...
4043
  			} elsif ($ctx_before =~ /^.\s*\#\s*define\s*$/) {
773647a09   Andy Whitcroft   update checkpatch...
4044
4045
  
  			# cpp #elif statement condition may start with a (
c45dcabd2   Andy Whitcroft   update checkpatch...
4046
  			} elsif ($ctx =~ /^.\s*\#\s*elif\s*$/) {
c2fdda0df   Andy Whitcroft   update checkpatch...
4047
4048
4049
  
  			# If this whole things ends with a type its most
  			# likely a typedef for a function.
773647a09   Andy Whitcroft   update checkpatch...
4050
  			} elsif ($ctx =~ /$Type$/) {
c2fdda0df   Andy Whitcroft   update checkpatch...
4051
4052
  
  			} else {
3705ce5bc   Joe Perches   checkpatch: creat...
4053
4054
4055
4056
  				if (WARN("SPACING",
  					 "space prohibited between function name and open parenthesis '('
  " . $herecurr) &&
  					     $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
4057
  					$fixed[$fixlinenr] =~
3705ce5bc   Joe Perches   checkpatch: creat...
4058
4059
  					    s/\b$name\s+\(/$name\(/;
  				}
6c72ffaab   Andy Whitcroft   update checkpatch...
4060
  			}
f0a594c1c   Andy Whitcroft   update checkpatch...
4061
  		}
9a4cad4e2   Eric Nelson   checkpatch: check...
4062

653d4876b   Andy Whitcroft   update checkpatch...
4063
  # Check operator spacing.
0a920b5b6   Andy Whitcroft   add a trivial pat...
4064
  		if (!($line=~/\#\s*include/)) {
3705ce5bc   Joe Perches   checkpatch: creat...
4065
4066
  			my $fixed_line = "";
  			my $line_fixed = 0;
9c0ca6f9a   Andy Whitcroft   update checkpatch...
4067
4068
4069
4070
  			my $ops = qr{
  				<<=|>>=|<=|>=|==|!=|
  				\+=|-=|\*=|\/=|%=|\^=|\|=|&=|
  				=>|->|<<|>>|<|>|=|!|~|
1f65f947a   Andy Whitcroft   checkpatch: add c...
4071
  				&&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%|
847316231   Joe Perches   checkpatch: repor...
4072
  				\?:|\?|:
9c0ca6f9a   Andy Whitcroft   update checkpatch...
4073
  			}x;
cf655043d   Andy Whitcroft   update checkpatch...
4074
  			my @elements = split(/($ops|;)/, $opline);
3705ce5bc   Joe Perches   checkpatch: creat...
4075
4076
4077
4078
4079
4080
4081
4082
4083
  
  ##			print("element count: <" . $#elements . ">
  ");
  ##			foreach my $el (@elements) {
  ##				print("el: <$el>
  ");
  ##			}
  
  			my @fix_elements = ();
00df344fd   Andy Whitcroft   update checkpatch...
4084
  			my $off = 0;
6c72ffaab   Andy Whitcroft   update checkpatch...
4085

3705ce5bc   Joe Perches   checkpatch: creat...
4086
4087
4088
4089
4090
4091
  			foreach my $el (@elements) {
  				push(@fix_elements, substr($rawline, $off, length($el)));
  				$off += length($el);
  			}
  
  			$off = 0;
6c72ffaab   Andy Whitcroft   update checkpatch...
4092
  			my $blank = copy_spacing($opline);
b34c648bb   Joe Perches   checkpatch: bette...
4093
  			my $last_after = -1;
6c72ffaab   Andy Whitcroft   update checkpatch...
4094

0a920b5b6   Andy Whitcroft   add a trivial pat...
4095
  			for (my $n = 0; $n < $#elements; $n += 2) {
3705ce5bc   Joe Perches   checkpatch: creat...
4096
4097
4098
4099
4100
  
  				my $good = $fix_elements[$n] . $fix_elements[$n + 1];
  
  ##				print("n: <$n> good: <$good>
  ");
4a0df2ef4   Andy Whitcroft   update checkpatch...
4101
  				$off += length($elements[$n]);
25985edce   Lucas De Marchi   Fix common misspe...
4102
  				# Pick up the preceding and succeeding characters.
773647a09   Andy Whitcroft   update checkpatch...
4103
4104
4105
4106
4107
4108
  				my $ca = substr($opline, 0, $off);
  				my $cc = '';
  				if (length($opline) >= ($off + length($elements[$n + 1]))) {
  					$cc = substr($opline, $off + length($elements[$n + 1]));
  				}
  				my $cb = "$ca$;$cc";
4a0df2ef4   Andy Whitcroft   update checkpatch...
4109
4110
4111
  				my $a = '';
  				$a = 'V' if ($elements[$n] ne '');
  				$a = 'W' if ($elements[$n] =~ /\s$/);
cf655043d   Andy Whitcroft   update checkpatch...
4112
  				$a = 'C' if ($elements[$n] =~ /$;$/);
4a0df2ef4   Andy Whitcroft   update checkpatch...
4113
4114
  				$a = 'B' if ($elements[$n] =~ /(\[|\()$/);
  				$a = 'O' if ($elements[$n] eq '');
773647a09   Andy Whitcroft   update checkpatch...
4115
  				$a = 'E' if ($ca =~ /^\s*$/);
4a0df2ef4   Andy Whitcroft   update checkpatch...
4116

0a920b5b6   Andy Whitcroft   add a trivial pat...
4117
  				my $op = $elements[$n + 1];
4a0df2ef4   Andy Whitcroft   update checkpatch...
4118
4119
  
  				my $c = '';
0a920b5b6   Andy Whitcroft   add a trivial pat...
4120
  				if (defined $elements[$n + 2]) {
4a0df2ef4   Andy Whitcroft   update checkpatch...
4121
4122
  					$c = 'V' if ($elements[$n + 2] ne '');
  					$c = 'W' if ($elements[$n + 2] =~ /^\s/);
cf655043d   Andy Whitcroft   update checkpatch...
4123
  					$c = 'C' if ($elements[$n + 2] =~ /^$;/);
4a0df2ef4   Andy Whitcroft   update checkpatch...
4124
4125
  					$c = 'B' if ($elements[$n + 2] =~ /^(\)|\]|;)/);
  					$c = 'O' if ($elements[$n + 2] eq '');
8b1b33786   Andy Whitcroft   checkpatch: fix c...
4126
  					$c = 'E' if ($elements[$n + 2] =~ /^\s*\\$/);
4a0df2ef4   Andy Whitcroft   update checkpatch...
4127
4128
  				} else {
  					$c = 'E';
0a920b5b6   Andy Whitcroft   add a trivial pat...
4129
  				}
4a0df2ef4   Andy Whitcroft   update checkpatch...
4130
4131
4132
  				my $ctx = "${a}x${c}";
  
  				my $at = "(ctx:$ctx)";
6c72ffaab   Andy Whitcroft   update checkpatch...
4133
  				my $ptr = substr($blank, 0, $off) . "^";
de7d4f0e1   Andy Whitcroft   update checkpatch...
4134
4135
  				my $hereptr = "$hereline$ptr
  ";
0a920b5b6   Andy Whitcroft   add a trivial pat...
4136

74048ed81   Andy Whitcroft   checkpatch: varia...
4137
  				# Pull out the value of this operator.
6c72ffaab   Andy Whitcroft   update checkpatch...
4138
  				my $op_type = substr($curr_values, $off + 1, 1);
0a920b5b6   Andy Whitcroft   add a trivial pat...
4139

1f65f947a   Andy Whitcroft   checkpatch: add c...
4140
4141
  				# Get the full operator variant.
  				my $opv = $op . substr($curr_vars, $off, 1);
13214adf7   Andy Whitcroft   update checkpatch...
4142
4143
  				# Ignore operators passed as parameters.
  				if ($op_type ne 'V' &&
d7fe8065a   Sam Bobroff   checkpatch: impro...
4144
  				    $ca =~ /\s$/ && $cc =~ /^\s*[,\)]/) {
13214adf7   Andy Whitcroft   update checkpatch...
4145

cf655043d   Andy Whitcroft   update checkpatch...
4146
4147
  #				# Ignore comments
  #				} elsif ($op =~ /^$;+$/) {
13214adf7   Andy Whitcroft   update checkpatch...
4148

d8aaf1214   Andy Whitcroft   update checkpatch...
4149
  				# ; should have either the end of line or a space or \ after it
13214adf7   Andy Whitcroft   update checkpatch...
4150
  				} elsif ($op eq ';') {
cf655043d   Andy Whitcroft   update checkpatch...
4151
4152
  					if ($ctx !~ /.x[WEBC]/ &&
  					    $cc !~ /^\\/ && $cc !~ /^;/) {
3705ce5bc   Joe Perches   checkpatch: creat...
4153
4154
4155
  						if (ERROR("SPACING",
  							  "space required after that '$op' $at
  " . $hereptr)) {
b34c648bb   Joe Perches   checkpatch: bette...
4156
  							$good = $fix_elements[$n] . trim($fix_elements[$n + 1]) . " ";
3705ce5bc   Joe Perches   checkpatch: creat...
4157
4158
  							$line_fixed = 1;
  						}
d8aaf1214   Andy Whitcroft   update checkpatch...
4159
4160
4161
4162
  					}
  
  				# // is a comment
  				} elsif ($op eq '//') {
0a920b5b6   Andy Whitcroft   add a trivial pat...
4163

b00e48148   Joe Perches   checkpatch: don't...
4164
4165
4166
  				#   :   when part of a bitfield
  				} elsif ($opv eq ':B') {
  					# skip the bitfield test for now
1f65f947a   Andy Whitcroft   checkpatch: add c...
4167
4168
  				# No spaces for:
  				#   ->
b00e48148   Joe Perches   checkpatch: don't...
4169
  				} elsif ($op eq '->') {
4a0df2ef4   Andy Whitcroft   update checkpatch...
4170
  					if ($ctx =~ /Wx.|.xW/) {
3705ce5bc   Joe Perches   checkpatch: creat...
4171
4172
4173
  						if (ERROR("SPACING",
  							  "spaces prohibited around that '$op' $at
  " . $hereptr)) {
b34c648bb   Joe Perches   checkpatch: bette...
4174
  							$good = rtrim($fix_elements[$n]) . trim($fix_elements[$n + 1]);
3705ce5bc   Joe Perches   checkpatch: creat...
4175
4176
4177
  							if (defined $fix_elements[$n + 2]) {
  								$fix_elements[$n + 2] =~ s/^\s+//;
  							}
b34c648bb   Joe Perches   checkpatch: bette...
4178
  							$line_fixed = 1;
3705ce5bc   Joe Perches   checkpatch: creat...
4179
  						}
0a920b5b6   Andy Whitcroft   add a trivial pat...
4180
  					}
2381097b6   Joe Perches   checkpatch: add a...
4181
  				# , must not have a space before and must have a space on the right.
0a920b5b6   Andy Whitcroft   add a trivial pat...
4182
  				} elsif ($op eq ',') {
2381097b6   Joe Perches   checkpatch: add a...
4183
4184
4185
4186
4187
4188
4189
4190
4191
4192
  					my $rtrim_before = 0;
  					my $space_after = 0;
  					if ($ctx =~ /Wx./) {
  						if (ERROR("SPACING",
  							  "space prohibited before that '$op' $at
  " . $hereptr)) {
  							$line_fixed = 1;
  							$rtrim_before = 1;
  						}
  					}
cf655043d   Andy Whitcroft   update checkpatch...
4193
  					if ($ctx !~ /.x[WEC]/ && $cc !~ /^}/) {
3705ce5bc   Joe Perches   checkpatch: creat...
4194
4195
4196
  						if (ERROR("SPACING",
  							  "space required after that '$op' $at
  " . $hereptr)) {
3705ce5bc   Joe Perches   checkpatch: creat...
4197
  							$line_fixed = 1;
b34c648bb   Joe Perches   checkpatch: bette...
4198
  							$last_after = $n;
2381097b6   Joe Perches   checkpatch: add a...
4199
4200
4201
4202
4203
4204
4205
4206
4207
4208
4209
  							$space_after = 1;
  						}
  					}
  					if ($rtrim_before || $space_after) {
  						if ($rtrim_before) {
  							$good = rtrim($fix_elements[$n]) . trim($fix_elements[$n + 1]);
  						} else {
  							$good = $fix_elements[$n] . trim($fix_elements[$n + 1]);
  						}
  						if ($space_after) {
  							$good .= " ";
3705ce5bc   Joe Perches   checkpatch: creat...
4210
  						}
0a920b5b6   Andy Whitcroft   add a trivial pat...
4211
  					}
9c0ca6f9a   Andy Whitcroft   update checkpatch...
4212
  				# '*' as part of a type definition -- reported already.
74048ed81   Andy Whitcroft   checkpatch: varia...
4213
  				} elsif ($opv eq '*_') {
9c0ca6f9a   Andy Whitcroft   update checkpatch...
4214
4215
4216
4217
4218
4219
4220
  					#warn "'*' is part of type
  ";
  
  				# unary operators should have a space before and
  				# none after.  May be left adjacent to another
  				# unary operator, or a cast
  				} elsif ($op eq '!' || $op eq '~' ||
74048ed81   Andy Whitcroft   checkpatch: varia...
4221
  					 $opv eq '*U' || $opv eq '-U' ||
0d413866c   Andy Whitcroft   checkpatch: value...
4222
  					 $opv eq '&U' || $opv eq '&&U') {
cf655043d   Andy Whitcroft   update checkpatch...
4223
  					if ($ctx !~ /[WEBC]x./ && $ca !~ /(?:\)|!|~|\*|-|\&|\||\+\+|\-\-|\{)$/) {
3705ce5bc   Joe Perches   checkpatch: creat...
4224
4225
4226
  						if (ERROR("SPACING",
  							  "space required before that '$op' $at
  " . $hereptr)) {
b34c648bb   Joe Perches   checkpatch: bette...
4227
4228
4229
4230
  							if ($n != $last_after + 2) {
  								$good = $fix_elements[$n] . " " . ltrim($fix_elements[$n + 1]);
  								$line_fixed = 1;
  							}
3705ce5bc   Joe Perches   checkpatch: creat...
4231
  						}
0a920b5b6   Andy Whitcroft   add a trivial pat...
4232
  					}
a3340b357   Andy Whitcroft   checkpatch: point...
4233
  					if ($op eq '*' && $cc =~/\s*$Modifier\b/) {
171ae1a49   Andy Whitcroft   update checkpatch...
4234
4235
4236
  						# A unary '*' may be const
  
  					} elsif ($ctx =~ /.xW/) {
3705ce5bc   Joe Perches   checkpatch: creat...
4237
4238
4239
  						if (ERROR("SPACING",
  							  "space prohibited after that '$op' $at
  " . $hereptr)) {
b34c648bb   Joe Perches   checkpatch: bette...
4240
  							$good = $fix_elements[$n] . rtrim($fix_elements[$n + 1]);
3705ce5bc   Joe Perches   checkpatch: creat...
4241
4242
4243
  							if (defined $fix_elements[$n + 2]) {
  								$fix_elements[$n + 2] =~ s/^\s+//;
  							}
b34c648bb   Joe Perches   checkpatch: bette...
4244
  							$line_fixed = 1;
3705ce5bc   Joe Perches   checkpatch: creat...
4245
  						}
0a920b5b6   Andy Whitcroft   add a trivial pat...
4246
4247
4248
4249
  					}
  
  				# unary ++ and unary -- are allowed no space on one side.
  				} elsif ($op eq '++' or $op eq '--') {
773647a09   Andy Whitcroft   update checkpatch...
4250
  					if ($ctx !~ /[WEOBC]x[^W]/ && $ctx !~ /[^W]x[WOBEC]/) {
3705ce5bc   Joe Perches   checkpatch: creat...
4251
4252
4253
  						if (ERROR("SPACING",
  							  "space required one side of that '$op' $at
  " . $hereptr)) {
b34c648bb   Joe Perches   checkpatch: bette...
4254
  							$good = $fix_elements[$n] . trim($fix_elements[$n + 1]) . " ";
3705ce5bc   Joe Perches   checkpatch: creat...
4255
4256
  							$line_fixed = 1;
  						}
773647a09   Andy Whitcroft   update checkpatch...
4257
4258
4259
  					}
  					if ($ctx =~ /Wx[BE]/ ||
  					    ($ctx =~ /Wx./ && $cc =~ /^;/)) {
3705ce5bc   Joe Perches   checkpatch: creat...
4260
4261
4262
  						if (ERROR("SPACING",
  							  "space prohibited before that '$op' $at
  " . $hereptr)) {
b34c648bb   Joe Perches   checkpatch: bette...
4263
  							$good = rtrim($fix_elements[$n]) . trim($fix_elements[$n + 1]);
3705ce5bc   Joe Perches   checkpatch: creat...
4264
4265
  							$line_fixed = 1;
  						}
0a920b5b6   Andy Whitcroft   add a trivial pat...
4266
  					}
773647a09   Andy Whitcroft   update checkpatch...
4267
  					if ($ctx =~ /ExW/) {
3705ce5bc   Joe Perches   checkpatch: creat...
4268
4269
4270
  						if (ERROR("SPACING",
  							  "space prohibited after that '$op' $at
  " . $hereptr)) {
b34c648bb   Joe Perches   checkpatch: bette...
4271
  							$good = $fix_elements[$n] . trim($fix_elements[$n + 1]);
3705ce5bc   Joe Perches   checkpatch: creat...
4272
4273
4274
  							if (defined $fix_elements[$n + 2]) {
  								$fix_elements[$n + 2] =~ s/^\s+//;
  							}
b34c648bb   Joe Perches   checkpatch: bette...
4275
  							$line_fixed = 1;
3705ce5bc   Joe Perches   checkpatch: creat...
4276
  						}
653d4876b   Andy Whitcroft   update checkpatch...
4277
  					}
0a920b5b6   Andy Whitcroft   add a trivial pat...
4278

0a920b5b6   Andy Whitcroft   add a trivial pat...
4279
  				# << and >> may either have or not have spaces both sides
9c0ca6f9a   Andy Whitcroft   update checkpatch...
4280
4281
4282
  				} elsif ($op eq '<<' or $op eq '>>' or
  					 $op eq '&' or $op eq '^' or $op eq '|' or
  					 $op eq '+' or $op eq '-' or
c2fdda0df   Andy Whitcroft   update checkpatch...
4283
4284
  					 $op eq '*' or $op eq '/' or
  					 $op eq '%')
0a920b5b6   Andy Whitcroft   add a trivial pat...
4285
  				{
d2e025f36   Joe Perches   checkpatch: add -...
4286
4287
4288
4289
4290
4291
4292
4293
4294
4295
4296
4297
4298
4299
4300
4301
4302
4303
  					if ($check) {
  						if (defined $fix_elements[$n + 2] && $ctx !~ /[EW]x[EW]/) {
  							if (CHK("SPACING",
  								"spaces preferred around that '$op' $at
  " . $hereptr)) {
  								$good = rtrim($fix_elements[$n]) . " " . trim($fix_elements[$n + 1]) . " ";
  								$fix_elements[$n + 2] =~ s/^\s+//;
  								$line_fixed = 1;
  							}
  						} elsif (!defined $fix_elements[$n + 2] && $ctx !~ /Wx[OE]/) {
  							if (CHK("SPACING",
  								"space preferred before that '$op' $at
  " . $hereptr)) {
  								$good = rtrim($fix_elements[$n]) . " " . trim($fix_elements[$n + 1]);
  								$line_fixed = 1;
  							}
  						}
  					} elsif ($ctx =~ /Wx[^WCE]|[^WCE]xW/) {
3705ce5bc   Joe Perches   checkpatch: creat...
4304
4305
4306
  						if (ERROR("SPACING",
  							  "need consistent spacing around '$op' $at
  " . $hereptr)) {
b34c648bb   Joe Perches   checkpatch: bette...
4307
4308
4309
4310
  							$good = rtrim($fix_elements[$n]) . " " . trim($fix_elements[$n + 1]) . " ";
  							if (defined $fix_elements[$n + 2]) {
  								$fix_elements[$n + 2] =~ s/^\s+//;
  							}
3705ce5bc   Joe Perches   checkpatch: creat...
4311
4312
  							$line_fixed = 1;
  						}
0a920b5b6   Andy Whitcroft   add a trivial pat...
4313
  					}
1f65f947a   Andy Whitcroft   checkpatch: add c...
4314
4315
4316
4317
  				# A colon needs no spaces before when it is
  				# terminating a case value or a label.
  				} elsif ($opv eq ':C' || $opv eq ':L') {
  					if ($ctx =~ /Wx./) {
3705ce5bc   Joe Perches   checkpatch: creat...
4318
4319
4320
  						if (ERROR("SPACING",
  							  "space prohibited before that '$op' $at
  " . $hereptr)) {
b34c648bb   Joe Perches   checkpatch: bette...
4321
  							$good = rtrim($fix_elements[$n]) . trim($fix_elements[$n + 1]);
3705ce5bc   Joe Perches   checkpatch: creat...
4322
4323
  							$line_fixed = 1;
  						}
1f65f947a   Andy Whitcroft   checkpatch: add c...
4324
  					}
0a920b5b6   Andy Whitcroft   add a trivial pat...
4325
  				# All the others need spaces both sides.
cf655043d   Andy Whitcroft   update checkpatch...
4326
  				} elsif ($ctx !~ /[EWC]x[CWE]/) {
1f65f947a   Andy Whitcroft   checkpatch: add c...
4327
  					my $ok = 0;
22f2a2ef9   Andy Whitcroft   update checkpatch...
4328
  					# Ignore email addresses <foo@bar>
1f65f947a   Andy Whitcroft   checkpatch: add c...
4329
4330
4331
4332
4333
4334
4335
  					if (($op eq '<' &&
  					     $cc =~ /^\S+\@\S+>/) ||
  					    ($op eq '>' &&
  					     $ca =~ /<\S+\@\S+$/))
  					{
  					    	$ok = 1;
  					}
e0df7e1fa   Joe Perches   checkpatch: avoid...
4336
4337
4338
4339
4340
4341
4342
  					# for asm volatile statements
  					# ignore a colon with another
  					# colon immediately before or after
  					if (($op eq ':') &&
  					    ($ca =~ /:$/ || $cc =~ /^:/)) {
  						$ok = 1;
  					}
847316231   Joe Perches   checkpatch: repor...
4343
  					# messages are ERROR, but ?: are CHK
1f65f947a   Andy Whitcroft   checkpatch: add c...
4344
  					if ($ok == 0) {
847316231   Joe Perches   checkpatch: repor...
4345
4346
4347
4348
4349
4350
  						my $msg_type = \&ERROR;
  						$msg_type = \&CHK if (($op eq '?:' || $op eq '?' || $op eq ':') && $ctx =~ /VxV/);
  
  						if (&{$msg_type}("SPACING",
  								 "spaces required around that '$op' $at
  " . $hereptr)) {
b34c648bb   Joe Perches   checkpatch: bette...
4351
4352
4353
4354
  							$good = rtrim($fix_elements[$n]) . " " . trim($fix_elements[$n + 1]) . " ";
  							if (defined $fix_elements[$n + 2]) {
  								$fix_elements[$n + 2] =~ s/^\s+//;
  							}
3705ce5bc   Joe Perches   checkpatch: creat...
4355
4356
  							$line_fixed = 1;
  						}
22f2a2ef9   Andy Whitcroft   update checkpatch...
4357
  					}
0a920b5b6   Andy Whitcroft   add a trivial pat...
4358
  				}
4a0df2ef4   Andy Whitcroft   update checkpatch...
4359
  				$off += length($elements[$n + 1]);
3705ce5bc   Joe Perches   checkpatch: creat...
4360
4361
4362
4363
4364
4365
4366
4367
4368
  
  ##				print("n: <$n> GOOD: <$good>
  ");
  
  				$fixed_line = $fixed_line . $good;
  			}
  
  			if (($#elements % 2) == 0) {
  				$fixed_line = $fixed_line . $fix_elements[$#elements];
0a920b5b6   Andy Whitcroft   add a trivial pat...
4369
  			}
3705ce5bc   Joe Perches   checkpatch: creat...
4370

194f66fc9   Joe Perches   checkpatch: add a...
4371
4372
  			if ($fix && $line_fixed && $fixed_line ne $fixed[$fixlinenr]) {
  				$fixed[$fixlinenr] = $fixed_line;
3705ce5bc   Joe Perches   checkpatch: creat...
4373
  			}
0a920b5b6   Andy Whitcroft   add a trivial pat...
4374
  		}
786b63262   Joe Perches   checkpatch: move ...
4375
  # check for whitespace before a non-naked semicolon
d2e248e7b   Joe Perches   checkpatch: warn ...
4376
  		if ($line =~ /^\+.*\S\s+;\s*$/) {
786b63262   Joe Perches   checkpatch: move ...
4377
4378
4379
4380
  			if (WARN("SPACING",
  				 "space prohibited before semicolon
  " . $herecurr) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
4381
  				1 while $fixed[$fixlinenr] =~
786b63262   Joe Perches   checkpatch: move ...
4382
4383
4384
  				    s/^(\+.*\S)\s+;/$1;/;
  			}
  		}
f0a594c1c   Andy Whitcroft   update checkpatch...
4385
4386
  # check for multiple assignments
  		if ($line =~ /^.\s*$Lval\s*=\s*$Lval\s*=(?!=)/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
4387
4388
4389
  			CHK("MULTIPLE_ASSIGNMENTS",
  			    "multiple assignments should be avoided
  " . $herecurr);
f0a594c1c   Andy Whitcroft   update checkpatch...
4390
  		}
22f2a2ef9   Andy Whitcroft   update checkpatch...
4391
4392
4393
4394
4395
4396
4397
4398
4399
4400
4401
  ## # check for multiple declarations, allowing for a function declaration
  ## # continuation.
  ## 		if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ &&
  ## 		    $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
  ##
  ## 			# Remove any bracketed sections to ensure we do not
  ## 			# falsly report the parameters of functions.
  ## 			my $ln = $line;
  ## 			while ($ln =~ s/\([^\(\)]*\)//g) {
  ## 			}
  ## 			if ($ln =~ /,/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
4402
4403
4404
  ## 				WARN("MULTIPLE_DECLARATION",
  ##				     "declaring multiple variables together should be avoided
  " . $herecurr);
22f2a2ef9   Andy Whitcroft   update checkpatch...
4405
4406
  ## 			}
  ## 		}
f0a594c1c   Andy Whitcroft   update checkpatch...
4407

0a920b5b6   Andy Whitcroft   add a trivial pat...
4408
  #need space before brace following if, while, etc
6b8c69e43   Geyslan G. Bem   checkpatch: fix a...
4409
  		if (($line =~ /\(.*\)\{/ && $line !~ /\($Type\)\{/) ||
4e5d56bdf   Eddie Kovsky   checkpatch: fix l...
4410
  		    $line =~ /do\{/) {
3705ce5bc   Joe Perches   checkpatch: creat...
4411
4412
4413
4414
  			if (ERROR("SPACING",
  				  "space required before the open brace '{'
  " . $herecurr) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
4415
  				$fixed[$fixlinenr] =~ s/^(\+.*(?:do|\))){/$1 {/;
3705ce5bc   Joe Perches   checkpatch: creat...
4416
  			}
de7d4f0e1   Andy Whitcroft   update checkpatch...
4417
  		}
c4a62ef91   Joe Perches   checkpatch: add a...
4418
4419
4420
4421
4422
4423
4424
4425
  ## # check for blank lines before declarations
  ##		if ($line =~ /^.\t+$Type\s+$Ident(?:\s*=.*)?;/ &&
  ##		    $prevrawline =~ /^.\s*$/) {
  ##			WARN("SPACING",
  ##			     "No blank lines before declarations
  " . $hereprev);
  ##		}
  ##
de7d4f0e1   Andy Whitcroft   update checkpatch...
4426
4427
4428
  # closing brace should have a space following it when it has anything
  # on the line
  		if ($line =~ /}(?!(?:,|;|\)))\S/) {
d5e616fc1   Joe Perches   checkpatch: add a...
4429
4430
4431
4432
  			if (ERROR("SPACING",
  				  "space required after that close brace '}'
  " . $herecurr) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
4433
  				$fixed[$fixlinenr] =~
d5e616fc1   Joe Perches   checkpatch: add a...
4434
4435
  				    s/}((?!(?:,|;|\)))\S)/} $1/;
  			}
0a920b5b6   Andy Whitcroft   add a trivial pat...
4436
  		}
22f2a2ef9   Andy Whitcroft   update checkpatch...
4437
4438
  # check spacing on square brackets
  		if ($line =~ /\[\s/ && $line !~ /\[\s*$/) {
3705ce5bc   Joe Perches   checkpatch: creat...
4439
4440
4441
4442
  			if (ERROR("SPACING",
  				  "space prohibited after that open square bracket '['
  " . $herecurr) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
4443
  				$fixed[$fixlinenr] =~
3705ce5bc   Joe Perches   checkpatch: creat...
4444
4445
  				    s/\[\s+/\[/;
  			}
22f2a2ef9   Andy Whitcroft   update checkpatch...
4446
4447
  		}
  		if ($line =~ /\s\]/) {
3705ce5bc   Joe Perches   checkpatch: creat...
4448
4449
4450
4451
  			if (ERROR("SPACING",
  				  "space prohibited before that close square bracket ']'
  " . $herecurr) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
4452
  				$fixed[$fixlinenr] =~
3705ce5bc   Joe Perches   checkpatch: creat...
4453
4454
  				    s/\s+\]/\]/;
  			}
22f2a2ef9   Andy Whitcroft   update checkpatch...
4455
  		}
c45dcabd2   Andy Whitcroft   update checkpatch...
4456
  # check spacing on parentheses
9c0ca6f9a   Andy Whitcroft   update checkpatch...
4457
4458
  		if ($line =~ /\(\s/ && $line !~ /\(\s*(?:\\)?$/ &&
  		    $line !~ /for\s*\(\s+;/) {
3705ce5bc   Joe Perches   checkpatch: creat...
4459
4460
4461
4462
  			if (ERROR("SPACING",
  				  "space prohibited after that open parenthesis '('
  " . $herecurr) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
4463
  				$fixed[$fixlinenr] =~
3705ce5bc   Joe Perches   checkpatch: creat...
4464
4465
  				    s/\(\s+/\(/;
  			}
22f2a2ef9   Andy Whitcroft   update checkpatch...
4466
  		}
13214adf7   Andy Whitcroft   update checkpatch...
4467
  		if ($line =~ /(\s+)\)/ && $line !~ /^.\s*\)/ &&
c45dcabd2   Andy Whitcroft   update checkpatch...
4468
4469
  		    $line !~ /for\s*\(.*;\s+\)/ &&
  		    $line !~ /:\s+\)/) {
3705ce5bc   Joe Perches   checkpatch: creat...
4470
4471
4472
4473
  			if (ERROR("SPACING",
  				  "space prohibited before that close parenthesis ')'
  " . $herecurr) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
4474
  				$fixed[$fixlinenr] =~
3705ce5bc   Joe Perches   checkpatch: creat...
4475
4476
  				    s/\s+\)/\)/;
  			}
22f2a2ef9   Andy Whitcroft   update checkpatch...
4477
  		}
e2826fd07   Joe Perches   checkpatch: warn ...
4478
4479
4480
4481
  # check unnecessary parentheses around addressof/dereference single $Lvals
  # ie: &(foo->bar) should be &foo->bar and *(foo->bar) should be *foo->bar
  
  		while ($line =~ /(?:[^&]&\s*|\*)\(\s*($Ident\s*(?:$Member\s*)+)\s*\)/g) {
ea4acbb11   Joe Perches   checkpatch: Add -...
4482
4483
4484
4485
4486
4487
4488
4489
4490
4491
4492
4493
4494
4495
4496
4497
4498
4499
4500
4501
4502
4503
4504
  			my $var = $1;
  			if (CHK("UNNECESSARY_PARENTHESES",
  				"Unnecessary parentheses around $var
  " . $herecurr) &&
  			    $fix) {
  				$fixed[$fixlinenr] =~ s/\(\s*\Q$var\E\s*\)/$var/;
  			}
  		}
  
  # check for unnecessary parentheses around function pointer uses
  # ie: (foo->bar)(); should be foo->bar();
  # but not "if (foo->bar) (" to avoid some false positives
  		if ($line =~ /(\bif\s*|)(\(\s*$Ident\s*(?:$Member\s*)+\))[ \t]*\(/ && $1 !~ /^if/) {
  			my $var = $2;
  			if (CHK("UNNECESSARY_PARENTHESES",
  				"Unnecessary parentheses around function pointer $var
  " . $herecurr) &&
  			    $fix) {
  				my $var2 = deparenthesize($var);
  				$var2 =~ s/\s//g;
  				$fixed[$fixlinenr] =~ s/\Q$var\E/$var2/;
  			}
  		}
e2826fd07   Joe Perches   checkpatch: warn ...
4505

0a920b5b6   Andy Whitcroft   add a trivial pat...
4506
  #goto labels aren't indented, allow a single space however
4a0df2ef4   Andy Whitcroft   update checkpatch...
4507
  		if ($line=~/^.\s+[A-Za-z\d_]+:(?![0-9]+)/ and
0a920b5b6   Andy Whitcroft   add a trivial pat...
4508
  		   !($line=~/^. [A-Za-z\d_]+:/) and !($line=~/^.\s+default:/)) {
3705ce5bc   Joe Perches   checkpatch: creat...
4509
4510
4511
4512
  			if (WARN("INDENTED_LABEL",
  				 "labels should not be indented
  " . $herecurr) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
4513
  				$fixed[$fixlinenr] =~
3705ce5bc   Joe Perches   checkpatch: creat...
4514
4515
  				    s/^(.)\s+/$1/;
  			}
0a920b5b6   Andy Whitcroft   add a trivial pat...
4516
  		}
5b9553abf   Joe Perches   checkpatch: make ...
4517
  # return is not a function
507e51418   Joe Perches   checkpatch: impro...
4518
  		if (defined($stat) && $stat =~ /^.\s*return(\s*)\(/s) {
c45dcabd2   Andy Whitcroft   update checkpatch...
4519
  			my $spacing = $1;
507e51418   Joe Perches   checkpatch: impro...
4520
  			if ($^V && $^V ge 5.10.0 &&
5b9553abf   Joe Perches   checkpatch: make ...
4521
4522
4523
4524
4525
4526
4527
4528
  			    $stat =~ /^.\s*return\s*($balanced_parens)\s*;\s*$/) {
  				my $value = $1;
  				$value = deparenthesize($value);
  				if ($value =~ m/^\s*$FuncArg\s*(?:\?|$)/) {
  					ERROR("RETURN_PARENTHESES",
  					      "return is not a function, parentheses are not required
  " . $herecurr);
  				}
c45dcabd2   Andy Whitcroft   update checkpatch...
4529
  			} elsif ($spacing !~ /\s+/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
4530
4531
4532
  				ERROR("SPACING",
  				      "space required before the open parenthesis '('
  " . $herecurr);
c45dcabd2   Andy Whitcroft   update checkpatch...
4533
4534
  			}
  		}
507e51418   Joe Perches   checkpatch: impro...
4535

b43ae21bd   Joe Perches   checkpatch: reduc...
4536
4537
4538
4539
4540
4541
4542
4543
  # unnecessary return in a void function
  # at end-of-function, with the previous line a single leading tab, then return;
  # and the line before that not a goto label target like "out:"
  		if ($sline =~ /^[ \+]}\s*$/ &&
  		    $prevline =~ /^\+\treturn\s*;\s*$/ &&
  		    $linenr >= 3 &&
  		    $lines[$linenr - 3] =~ /^[ +]/ &&
  		    $lines[$linenr - 3] !~ /^[ +]\s*$Ident\s*:/) {
9819cf252   Joe Perches   checkpatch: warn ...
4544
  			WARN("RETURN_VOID",
b43ae21bd   Joe Perches   checkpatch: reduc...
4545
4546
4547
  			     "void function return statements are not generally useful
  " . $hereprev);
                 }
9819cf252   Joe Perches   checkpatch: warn ...
4548

189248d8f   Joe Perches   checkpatch: check...
4549
4550
4551
4552
4553
4554
4555
4556
4557
4558
4559
4560
4561
4562
  # if statements using unnecessary parentheses - ie: if ((foo == bar))
  		if ($^V && $^V ge 5.10.0 &&
  		    $line =~ /\bif\s*((?:\(\s*){2,})/) {
  			my $openparens = $1;
  			my $count = $openparens =~ tr@\(@\(@;
  			my $msg = "";
  			if ($line =~ /\bif\s*(?:\(\s*){$count,$count}$LvalOrFunc\s*($Compare)\s*$LvalOrFunc(?:\s*\)){$count,$count}/) {
  				my $comp = $4;	#Not $1 because of $LvalOrFunc
  				$msg = " - maybe == should be = ?" if ($comp eq "==");
  				WARN("UNNECESSARY_PARENTHESES",
  				     "Unnecessary parentheses$msg
  " . $herecurr);
  			}
  		}
c5595fa2f   Joe Perches   checkpatch: add c...
4563
4564
4565
4566
4567
4568
4569
4570
4571
4572
4573
  # comparisons with a constant or upper case identifier on the left
  #	avoid cases like "foo + BAR < baz"
  #	only fix matches surrounded by parentheses to avoid incorrect
  #	conversions like "FOO < baz() + 5" being "misfixed" to "baz() > FOO + 5"
  		if ($^V && $^V ge 5.10.0 &&
  		    $line =~ /^\+(.*)\b($Constant|[A-Z_][A-Z0-9_]*)\s*($Compare)\s*($LvalOrFunc)/) {
  			my $lead = $1;
  			my $const = $2;
  			my $comp = $3;
  			my $to = $4;
  			my $newcomp = $comp;
f39e1769b   Joe Perches   checkpatch: impro...
4574
  			if ($lead !~ /(?:$Operators|\.)\s*$/ &&
c5595fa2f   Joe Perches   checkpatch: add c...
4575
4576
4577
4578
4579
4580
4581
4582
4583
4584
4585
4586
4587
4588
4589
4590
4591
  			    $to !~ /^(?:Constant|[A-Z_][A-Z0-9_]*)$/ &&
  			    WARN("CONSTANT_COMPARISON",
  				 "Comparisons should place the constant on the right side of the test
  " . $herecurr) &&
  			    $fix) {
  				if ($comp eq "<") {
  					$newcomp = ">";
  				} elsif ($comp eq "<=") {
  					$newcomp = ">=";
  				} elsif ($comp eq ">") {
  					$newcomp = "<";
  				} elsif ($comp eq ">=") {
  					$newcomp = "<=";
  				}
  				$fixed[$fixlinenr] =~ s/\(\s*\Q$const\E\s*$Compare\s*\Q$to\E\s*\)/($to $newcomp $const)/;
  			}
  		}
f34e4a4f9   Joe Perches   checkpatch: impro...
4592
4593
  # Return of what appears to be an errno should normally be negative
  		if ($sline =~ /\breturn(?:\s*\(+\s*|\s+)(E[A-Z]+)(?:\s*\)+\s*|\s*)[;:,]/) {
53a3c4487   Andy Whitcroft   checkpatch: retur...
4594
4595
  			my $name = $1;
  			if ($name ne 'EOF' && $name ne 'ERROR') {
000d1cc18   Joe Perches   checkpatch.pl: ad...
4596
  				WARN("USE_NEGATIVE_ERRNO",
f34e4a4f9   Joe Perches   checkpatch: impro...
4597
4598
  				     "return of an errno should typically be negative (ie: return -$1)
  " . $herecurr);
53a3c4487   Andy Whitcroft   checkpatch: retur...
4599
4600
  			}
  		}
c45dcabd2   Andy Whitcroft   update checkpatch...
4601

0a920b5b6   Andy Whitcroft   add a trivial pat...
4602
  # Need a space before open parenthesis after if, while etc
3705ce5bc   Joe Perches   checkpatch: creat...
4603
4604
4605
4606
4607
  		if ($line =~ /\b(if|while|for|switch)\(/) {
  			if (ERROR("SPACING",
  				  "space required before the open parenthesis '('
  " . $herecurr) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
4608
  				$fixed[$fixlinenr] =~
3705ce5bc   Joe Perches   checkpatch: creat...
4609
4610
  				    s/\b(if|while|for|switch)\(/$1 \(/;
  			}
0a920b5b6   Andy Whitcroft   add a trivial pat...
4611
  		}
f5fe35dd9   Andy Whitcroft   checkpatch: condi...
4612
4613
  # Check for illegal assignment in if conditional -- and check for trailing
  # statements after the conditional.
170d3a226   Andy Whitcroft   checkpatch: handl...
4614
  		if ($line =~ /do\s*(?!{)/) {
3e469cdc0   Andy Whitcroft   checkpatch: optim...
4615
4616
4617
  			($stat, $cond, $line_nr_next, $remain_next, $off_next) =
  				ctx_statement_block($linenr, $realcnt, 0)
  					if (!defined $stat);
170d3a226   Andy Whitcroft   checkpatch: handl...
4618
4619
4620
4621
4622
4623
4624
4625
4626
4627
4628
4629
4630
4631
4632
4633
4634
4635
4636
4637
4638
4639
  			my ($stat_next) = ctx_statement_block($line_nr_next,
  						$remain_next, $off_next);
  			$stat_next =~ s/
  ./
   /g;
  			##print "stat<$stat> stat_next<$stat_next>
  ";
  
  			if ($stat_next =~ /^\s*while\b/) {
  				# If the statement carries leading newlines,
  				# then count those as offsets.
  				my ($whitespace) =
  					($stat_next =~ /^((?:\s*
  [+-])*\s*)/s);
  				my $offset =
  					statement_rawlines($whitespace) - 1;
  
  				$suppress_whiletrailers{$line_nr_next +
  								$offset} = 1;
  			}
  		}
  		if (!defined $suppress_whiletrailers{$linenr} &&
c11230f44   Joe Perches   checkpatch: fix "...
4640
  		    defined($stat) && defined($cond) &&
170d3a226   Andy Whitcroft   checkpatch: handl...
4641
  		    $line =~ /\b(?:if|while|for)\s*\(/ && $line !~ /^.\s*#/) {
171ae1a49   Andy Whitcroft   update checkpatch...
4642
  			my ($s, $c) = ($stat, $cond);
8905a67c6   Andy Whitcroft   update checkpatch...
4643

b53c8e104   Andy Whitcroft   checkpatch: ensur...
4644
  			if ($c =~ /\bif\s*\(.*[^<>!=]=[^=].*/s) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
4645
4646
4647
  				ERROR("ASSIGN_IN_IF",
  				      "do not use assignment in if condition
  " . $herecurr);
8905a67c6   Andy Whitcroft   update checkpatch...
4648
4649
4650
4651
  			}
  
  			# Find out what is on the end of the line after the
  			# conditional.
773647a09   Andy Whitcroft   update checkpatch...
4652
  			substr($s, 0, length($c), '');
8905a67c6   Andy Whitcroft   update checkpatch...
4653
4654
  			$s =~ s/
  .*//g;
13214adf7   Andy Whitcroft   update checkpatch...
4655
  			$s =~ s/$;//g; 	# Remove any comments
53210168f   Andy Whitcroft   checkpatch: tough...
4656
4657
  			if (length($c) && $s !~ /^\s*{?\s*\\*\s*$/ &&
  			    $c !~ /}\s*while\s*/)
773647a09   Andy Whitcroft   update checkpatch...
4658
  			{
bb44ad39c   Andy Whitcroft   checkpatch: trail...
4659
4660
4661
4662
  				# Find out how long the conditional actually is.
  				my @newlines = ($c =~ /
  /gs);
  				my $cond_lines = 1 + $#newlines;
42bdf74c9   Hidetoshi Seto   checkpatch: trivi...
4663
  				my $stat_real = '';
bb44ad39c   Andy Whitcroft   checkpatch: trail...
4664

42bdf74c9   Hidetoshi Seto   checkpatch: trivi...
4665
4666
4667
  				$stat_real = raw_line($linenr, $cond_lines)
  							. "
  " if ($cond_lines);
bb44ad39c   Andy Whitcroft   checkpatch: trail...
4668
4669
4670
4671
  				if (defined($stat_real) && $cond_lines > 1) {
  					$stat_real = "[...]
  $stat_real";
  				}
000d1cc18   Joe Perches   checkpatch.pl: ad...
4672
4673
4674
  				ERROR("TRAILING_STATEMENTS",
  				      "trailing statements should be on next line
  " . $herecurr . $stat_real);
8905a67c6   Andy Whitcroft   update checkpatch...
4675
4676
  			}
  		}
13214adf7   Andy Whitcroft   update checkpatch...
4677
4678
4679
4680
4681
4682
4683
4684
4685
4686
4687
4688
  # Check for bitwise tests written as boolean
  		if ($line =~ /
  			(?:
  				(?:\[|\(|\&\&|\|\|)
  				\s*0[xX][0-9]+\s*
  				(?:\&\&|\|\|)
  			|
  				(?:\&\&|\|\|)
  				\s*0[xX][0-9]+\s*
  				(?:\&\&|\|\||\)|\])
  			)/x)
  		{
000d1cc18   Joe Perches   checkpatch.pl: ad...
4689
4690
4691
  			WARN("HEXADECIMAL_BOOLEAN_TEST",
  			     "boolean test with hexadecimal, perhaps just 1 \& or \|?
  " . $herecurr);
13214adf7   Andy Whitcroft   update checkpatch...
4692
  		}
8905a67c6   Andy Whitcroft   update checkpatch...
4693
  # if and else should not have general statements after it
13214adf7   Andy Whitcroft   update checkpatch...
4694
4695
4696
4697
  		if ($line =~ /^.\s*(?:}\s*)?else\b(.*)/) {
  			my $s = $1;
  			$s =~ s/$;//g; 	# Remove any comments
  			if ($s !~ /^\s*(?:\sif|(?:{|)\s*\\?\s*$)/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
4698
4699
4700
  				ERROR("TRAILING_STATEMENTS",
  				      "trailing statements should be on next line
  " . $herecurr);
13214adf7   Andy Whitcroft   update checkpatch...
4701
  			}
0a920b5b6   Andy Whitcroft   add a trivial pat...
4702
  		}
396677823   Andy Whitcroft   checkpatch: if sh...
4703
4704
  # if should not continue a brace
  		if ($line =~ /}\s*if\b/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
4705
  			ERROR("TRAILING_STATEMENTS",
048b123fa   Rasmus Villemoes   checkpatch.pl: al...
4706
4707
  			      "trailing statements should be on next line (or did you mean 'else if'?)
  " .
396677823   Andy Whitcroft   checkpatch: if sh...
4708
4709
  				$herecurr);
  		}
a1080bf80   Andy Whitcroft   checkpatch: case/...
4710
4711
4712
  # case and default should not have general statements after them
  		if ($line =~ /^.\s*(?:case\s*.*|default\s*):/g &&
  		    $line !~ /\G(?:
3fef12d6c   Andy Whitcroft   checkpatch: allow...
4713
  			(?:\s*$;*)(?:\s*{)?(?:\s*$;*)(?:\s*\\)?\s*$|
a1080bf80   Andy Whitcroft   checkpatch: case/...
4714
4715
4716
  			\s*return\s+
  		    )/xg)
  		{
000d1cc18   Joe Perches   checkpatch.pl: ad...
4717
4718
4719
  			ERROR("TRAILING_STATEMENTS",
  			      "trailing statements should be on next line
  " . $herecurr);
a1080bf80   Andy Whitcroft   checkpatch: case/...
4720
  		}
0a920b5b6   Andy Whitcroft   add a trivial pat...
4721
4722
4723
  
  		# Check for }<nl>else {, these must be at the same
  		# indent level to be relevant to each other.
8b8856f4b   Joe Perches   checkpatch: fix b...
4724
4725
4726
4727
4728
4729
4730
4731
4732
4733
4734
4735
4736
4737
4738
4739
4740
  		if ($prevline=~/}\s*$/ and $line=~/^.\s*else\s*/ &&
  		    $previndent == $indent) {
  			if (ERROR("ELSE_AFTER_BRACE",
  				  "else should follow close brace '}'
  " . $hereprev) &&
  			    $fix && $prevline =~ /^\+/ && $line =~ /^\+/) {
  				fix_delete_line($fixlinenr - 1, $prevrawline);
  				fix_delete_line($fixlinenr, $rawline);
  				my $fixedline = $prevrawline;
  				$fixedline =~ s/}\s*$//;
  				if ($fixedline !~ /^\+\s*$/) {
  					fix_insert_line($fixlinenr, $fixedline);
  				}
  				$fixedline = $rawline;
  				$fixedline =~ s/^(.\s*)else/$1} else/;
  				fix_insert_line($fixlinenr, $fixedline);
  			}
0a920b5b6   Andy Whitcroft   add a trivial pat...
4741
  		}
8b8856f4b   Joe Perches   checkpatch: fix b...
4742
4743
  		if ($prevline=~/}\s*$/ and $line=~/^.\s*while\s*/ &&
  		    $previndent == $indent) {
c2fdda0df   Andy Whitcroft   update checkpatch...
4744
4745
4746
4747
  			my ($s, $c) = ctx_statement_block($linenr, $realcnt, 0);
  
  			# Find out what is on the end of the line after the
  			# conditional.
773647a09   Andy Whitcroft   update checkpatch...
4748
  			substr($s, 0, length($c), '');
c2fdda0df   Andy Whitcroft   update checkpatch...
4749
4750
4751
4752
  			$s =~ s/
  .*//g;
  
  			if ($s =~ /^\s*;/) {
8b8856f4b   Joe Perches   checkpatch: fix b...
4753
4754
4755
4756
4757
4758
4759
4760
4761
4762
4763
4764
4765
  				if (ERROR("WHILE_AFTER_BRACE",
  					  "while should follow close brace '}'
  " . $hereprev) &&
  				    $fix && $prevline =~ /^\+/ && $line =~ /^\+/) {
  					fix_delete_line($fixlinenr - 1, $prevrawline);
  					fix_delete_line($fixlinenr, $rawline);
  					my $fixedline = $prevrawline;
  					my $trailing = $rawline;
  					$trailing =~ s/^\+//;
  					$trailing = trim($trailing);
  					$fixedline =~ s/}\s*$/} $trailing/;
  					fix_insert_line($fixlinenr, $fixedline);
  				}
c2fdda0df   Andy Whitcroft   update checkpatch...
4766
4767
  			}
  		}
95e2c6023   Joe Perches   checkpatch: warn ...
4768
  #Specific variable tests
323c1260b   Joe Perches   checkpatch: warn ...
4769
4770
  		while ($line =~ m{($Constant|$Lval)}g) {
  			my $var = $1;
95e2c6023   Joe Perches   checkpatch: warn ...
4771
4772
4773
  
  #gcc binary extension
  			if ($var =~ /^$Binary$/) {
d5e616fc1   Joe Perches   checkpatch: add a...
4774
4775
4776
4777
4778
  				if (WARN("GCC_BINARY_CONSTANT",
  					 "Avoid gcc v4.3+ binary constant extension: <$var>
  " . $herecurr) &&
  				    $fix) {
  					my $hexval = sprintf("0x%x", oct($var));
194f66fc9   Joe Perches   checkpatch: add a...
4779
  					$fixed[$fixlinenr] =~
d5e616fc1   Joe Perches   checkpatch: add a...
4780
4781
  					    s/\b$var\b/$hexval/;
  				}
95e2c6023   Joe Perches   checkpatch: warn ...
4782
4783
4784
  			}
  
  #CamelCase
807bd26c4   Joe Perches   checkpatch: remov...
4785
  			if ($var !~ /^$Constant$/ &&
be79794bc   Joe Perches   checkpatch: chang...
4786
  			    $var =~ /[A-Z][a-z]|[a-z][A-Z]/ &&
22735ce85   Joe Perches   checkpatch: ignor...
4787
  #Ignore Page<foo> variants
807bd26c4   Joe Perches   checkpatch: remov...
4788
  			    $var !~ /^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ &&
22735ce85   Joe Perches   checkpatch: ignor...
4789
  #Ignore SI style variants like nS, mV and dB (ie: max_uV, regulator_min_uA_show)
f51235764   Julius Werner   checkpatch: allow...
4790
4791
4792
  			    $var !~ /^(?:[a-z_]*?)_?[a-z][A-Z](?:_[a-z_]+)?$/ &&
  #Ignore some three character SI units explicitly, like MiB and KHz
  			    $var !~ /^(?:[a-z_]*?)_?(?:[KMGT]iB|[KMGT]?Hz)(?:_[a-z_]+)?$/) {
7e781f67d   Joe Perches   checkpatch: check...
4793
4794
4795
  				while ($var =~ m{($Ident)}g) {
  					my $word = $1;
  					next if ($word !~ /[A-Z][a-z]|[a-z][A-Z]/);
d8b077101   Joe Perches   checkpatch: exten...
4796
4797
4798
4799
4800
4801
4802
  					if ($check) {
  						seed_camelcase_includes();
  						if (!$file && !$camelcase_file_seeded) {
  							seed_camelcase_file($realfile);
  							$camelcase_file_seeded = 1;
  						}
  					}
7e781f67d   Joe Perches   checkpatch: check...
4803
4804
4805
4806
4807
4808
  					if (!defined $camelcase{$word}) {
  						$camelcase{$word} = 1;
  						CHK("CAMELCASE",
  						    "Avoid CamelCase: <$word>
  " . $herecurr);
  					}
3445686af   Joe Perches   checkpatch: ignor...
4809
  				}
323c1260b   Joe Perches   checkpatch: warn ...
4810
4811
  			}
  		}
0a920b5b6   Andy Whitcroft   add a trivial pat...
4812
4813
  
  #no spaces allowed after \ in define
d5e616fc1   Joe Perches   checkpatch: add a...
4814
4815
4816
4817
4818
  		if ($line =~ /\#\s*define.*\\\s+$/) {
  			if (WARN("WHITESPACE_AFTER_LINE_CONTINUATION",
  				 "Whitespace after \\ makes next lines useless
  " . $herecurr) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
4819
  				$fixed[$fixlinenr] =~ s/\s+$//;
d5e616fc1   Joe Perches   checkpatch: add a...
4820
  			}
0a920b5b6   Andy Whitcroft   add a trivial pat...
4821
  		}
0e212e0a7   Fabian Frederick   checkpatch: don't...
4822
4823
  # warn if <asm/foo.h> is #included and <linux/foo.h> is available and includes
  # itself <asm/foo.h> (uses RAW line)
c45dcabd2   Andy Whitcroft   update checkpatch...
4824
  		if ($tree && $rawline =~ m{^.\s*\#\s*include\s*\<asm\/(.*)\.h\>}) {
e09dec483   Andy Whitcroft   checkpatch: reduc...
4825
4826
4827
4828
  			my $file = "$1.h";
  			my $checkfile = "include/linux/$file";
  			if (-f "$root/$checkfile" &&
  			    $realfile ne $checkfile &&
7840a94cd   Wolfram Sang   checkpatch: refac...
4829
  			    $1 !~ /$allowed_asm_includes/)
c45dcabd2   Andy Whitcroft   update checkpatch...
4830
  			{
0e212e0a7   Fabian Frederick   checkpatch: don't...
4831
4832
4833
4834
4835
4836
4837
4838
4839
4840
4841
  				my $asminclude = `grep -Ec "#include\\s+<asm/$file>" $root/$checkfile`;
  				if ($asminclude > 0) {
  					if ($realfile =~ m{^arch/}) {
  						CHK("ARCH_INCLUDE_LINUX",
  						    "Consider using #include <linux/$file> instead of <asm/$file>
  " . $herecurr);
  					} else {
  						WARN("INCLUDE_LINUX",
  						     "Use #include <linux/$file> instead of <asm/$file>
  " . $herecurr);
  					}
e09dec483   Andy Whitcroft   checkpatch: reduc...
4842
  				}
0a920b5b6   Andy Whitcroft   add a trivial pat...
4843
4844
  			}
  		}
653d4876b   Andy Whitcroft   update checkpatch...
4845
4846
  # multi-statement macros should be enclosed in a do while loop, grab the
  # first statement and ensure its the whole macro if its not enclosed
cf655043d   Andy Whitcroft   update checkpatch...
4847
  # in a known good container
b8f96a31f   Andy Whitcroft   checkpatch: macro...
4848
4849
  		if ($realfile !~ m@/vmlinux.lds.h$@ &&
  		    $line =~ /^.\s*\#\s*define\s*$Ident(\()?/) {
d8aaf1214   Andy Whitcroft   update checkpatch...
4850
4851
  			my $ln = $linenr;
  			my $cnt = $realcnt;
c45dcabd2   Andy Whitcroft   update checkpatch...
4852
4853
  			my ($off, $dstat, $dcond, $rest);
  			my $ctx = '';
08a2843e7   Joe Perches   checkpatch: warn ...
4854
4855
  			my $has_flow_statement = 0;
  			my $has_arg_concat = 0;
c45dcabd2   Andy Whitcroft   update checkpatch...
4856
  			($dstat, $dcond, $ln, $cnt, $off) =
f74bd1942   Andy Whitcroft   checkpatch: corre...
4857
4858
  				ctx_statement_block($linenr, $realcnt, 0);
  			$ctx = $dstat;
c45dcabd2   Andy Whitcroft   update checkpatch...
4859
4860
  			#print "dstat<$dstat> dcond<$dcond> cnt<$cnt> off<$off>
  ";
a3bb97a7a   Andy Whitcroft   checkpatch: macro...
4861
4862
  			#print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "
  ";
c45dcabd2   Andy Whitcroft   update checkpatch...
4863

08a2843e7   Joe Perches   checkpatch: warn ...
4864
  			$has_flow_statement = 1 if ($ctx =~ /\b(goto|return)\b/);
62e15a6da   Joe Perches   checkpatch: impro...
4865
  			$has_arg_concat = 1 if ($ctx =~ /\#\#/ && $ctx !~ /\#\#\s*(?:__VA_ARGS__|args)\b/);
08a2843e7   Joe Perches   checkpatch: warn ...
4866

f59b64bff   Joe Perches   checkpatch: add -...
4867
4868
4869
4870
4871
4872
4873
4874
4875
4876
  			$dstat =~ s/^.\s*\#\s*define\s+$Ident(\([^\)]*\))?\s*//;
  			my $define_args = $1;
  			my $define_stmt = $dstat;
  			my @def_args = ();
  
  			if (defined $define_args && $define_args ne "") {
  				$define_args = substr($define_args, 1, length($define_args) - 2);
  				$define_args =~ s/\s*//g;
  				@def_args = split(",", $define_args);
  			}
292f1a9b3   Andy Whitcroft   checkpatch: compl...
4877
  			$dstat =~ s/$;//g;
c45dcabd2   Andy Whitcroft   update checkpatch...
4878
4879
4880
4881
  			$dstat =~ s/\\
  .//g;
  			$dstat =~ s/^\s*//s;
  			$dstat =~ s/\s*$//s;
de7d4f0e1   Andy Whitcroft   update checkpatch...
4882

c45dcabd2   Andy Whitcroft   update checkpatch...
4883
  			# Flatten any parentheses and braces
bf30d6ede   Andy Whitcroft   checkpatch: compl...
4884
4885
  			while ($dstat =~ s/\([^\(\)]*\)/1/ ||
  			       $dstat =~ s/\{[^\{\}]*\}/1/ ||
6b10df425   Vladimir Zapolskiy   checkpatch: fix a...
4886
  			       $dstat =~ s/.\[[^\[\]]*\]/1/)
bf30d6ede   Andy Whitcroft   checkpatch: compl...
4887
  			{
de7d4f0e1   Andy Whitcroft   update checkpatch...
4888
  			}
d8aaf1214   Andy Whitcroft   update checkpatch...
4889

e45bab8eb   Andy Whitcroft   checkpatch: handl...
4890
  			# Flatten any obvious string concatentation.
33acb54a4   Joe Perches   checkpatch: use $...
4891
4892
  			while ($dstat =~ s/($String)\s*$Ident/$1/ ||
  			       $dstat =~ s/$Ident\s*($String)/$1/)
e45bab8eb   Andy Whitcroft   checkpatch: handl...
4893
4894
  			{
  			}
42e152931   Joe Perches   checkpatch: exclu...
4895
4896
  			# Make asm volatile uses seem like a generic function
  			$dstat =~ s/\b_*asm_*\s+_*volatile_*\b/asm_volatile/g;
c45dcabd2   Andy Whitcroft   update checkpatch...
4897
4898
4899
  			my $exceptions = qr{
  				$Declare|
  				module_param_named|
a0a0a7a94   Kees Cook   checkpatch: fix n...
4900
  				MODULE_PARM_DESC|
c45dcabd2   Andy Whitcroft   update checkpatch...
4901
4902
  				DECLARE_PER_CPU|
  				DEFINE_PER_CPU|
383099fd6   Andy Whitcroft   checkpatch: struc...
4903
  				__typeof__\(|
22fd2d3e4   Stefani Seibold   checkpatch.pl: ad...
4904
4905
  				union|
  				struct|
ea71a0a01   Andy Whitcroft   checkpatch: forma...
4906
  				\.$Ident\s*=\s*|
6b10df425   Vladimir Zapolskiy   checkpatch: fix a...
4907
4908
  				^\"|\"$|
  				^\[
c45dcabd2   Andy Whitcroft   update checkpatch...
4909
  			}x;
5eaa20b98   Andy Whitcroft   checkpatch: clean...
4910
4911
  			#print "REST<$rest> dstat<$dstat> ctx<$ctx>
  ";
f59b64bff   Joe Perches   checkpatch: add -...
4912
4913
4914
4915
4916
4917
4918
4919
4920
4921
4922
  
  			$ctx =~ s/
  *$//;
  			my $herectx = $here . "
  ";
  			my $stmt_cnt = statement_rawlines($ctx);
  
  			for (my $n = 0; $n < $stmt_cnt; $n++) {
  				$herectx .= raw_line($linenr, $n) . "
  ";
  			}
f74bd1942   Andy Whitcroft   checkpatch: corre...
4923
4924
4925
  			if ($dstat ne '' &&
  			    $dstat !~ /^(?:$Ident|-?$Constant),$/ &&			# 10, // foo(),
  			    $dstat !~ /^(?:$Ident|-?$Constant);$/ &&			# foo();
3cc4b1c3f   Joe Perches   checkpatch: reduc...
4926
  			    $dstat !~ /^[!~-]?(?:$Lval|$Constant)$/ &&		# 10 // foo() // !foo // ~foo // -foo // foo->bar // foo.bar->baz
356fd3981   Joe Perches   checkpatch: fix c...
4927
  			    $dstat !~ /^'X'$/ && $dstat !~ /^'XX'$/ &&			# character constants
f74bd1942   Andy Whitcroft   checkpatch: corre...
4928
4929
  			    $dstat !~ /$exceptions/ &&
  			    $dstat !~ /^\.$Ident\s*=/ &&				# .foo =
e942e2c3f   Joe Perches   checkpatch: fix s...
4930
  			    $dstat !~ /^(?:\#\s*$Ident|\#\s*$Constant)\s*$/ &&		# stringification #foo
72f115f94   Andy Whitcroft   checkpatch: compl...
4931
  			    $dstat !~ /^do\s*$Constant\s*while\s*$Constant;?$/ &&	# do {...} while (...); // do {...} while (...)
f74bd1942   Andy Whitcroft   checkpatch: corre...
4932
4933
4934
  			    $dstat !~ /^for\s*$Constant$/ &&				# for (...)
  			    $dstat !~ /^for\s*$Constant\s+(?:$Ident|-?$Constant)$/ &&	# for (...) bar()
  			    $dstat !~ /^do\s*{/ &&					# do {...
4e5d56bdf   Eddie Kovsky   checkpatch: fix l...
4935
  			    $dstat !~ /^\(\{/ &&						# ({...
f95a7e6a4   Joe Perches   checkpatch: ignor...
4936
  			    $ctx !~ /^.\s*#\s*define\s+TRACE_(?:SYSTEM|INCLUDE_FILE|INCLUDE_PATH)\b/)
f74bd1942   Andy Whitcroft   checkpatch: corre...
4937
  			{
c45dcabd2   Andy Whitcroft   update checkpatch...
4938

f74bd1942   Andy Whitcroft   checkpatch: corre...
4939
4940
4941
4942
4943
  				if ($dstat =~ /;/) {
  					ERROR("MULTISTATEMENT_MACRO_USE_DO_WHILE",
  					      "Macros with multiple statements should be enclosed in a do - while loop
  " . "$herectx");
  				} else {
000d1cc18   Joe Perches   checkpatch.pl: ad...
4944
  					ERROR("COMPLEX_MACRO",
388982b55   Andrew Morton   checkpatch: fix s...
4945
4946
  					      "Macros with complex values should be enclosed in parentheses
  " . "$herectx");
d8aaf1214   Andy Whitcroft   update checkpatch...
4947
  				}
f59b64bff   Joe Perches   checkpatch: add -...
4948
4949
  
  			}
5207649b7   Joe Perches   checkpatch: impro...
4950
4951
4952
4953
4954
4955
4956
4957
4958
4959
4960
4961
4962
4963
4964
4965
4966
4967
  
  			# Make $define_stmt single line, comment-free, etc
  			my @stmt_array = split('
  ', $define_stmt);
  			my $first = 1;
  			$define_stmt = "";
  			foreach my $l (@stmt_array) {
  				$l =~ s/\\$//;
  				if ($first) {
  					$define_stmt = $l;
  					$first = 0;
  				} elsif ($l =~ /^[\+ ]/) {
  					$define_stmt .= substr($l, 1);
  				}
  			}
  			$define_stmt =~ s/$;//g;
  			$define_stmt =~ s/\s+/ /g;
  			$define_stmt = trim($define_stmt);
f59b64bff   Joe Perches   checkpatch: add -...
4968
4969
4970
  # check if any macro arguments are reused (ignore '...' and 'type')
  			foreach my $arg (@def_args) {
  			        next if ($arg =~ /\.\.\./);
9192d41a3   Joe Perches   checkpatch: add -...
4971
  			        next if ($arg =~ /^type$/i);
f59b64bff   Joe Perches   checkpatch: add -...
4972
4973
  				my $tmp = $define_stmt;
  				$tmp =~ s/\b(typeof|__typeof__|__builtin\w+|typecheck\s*\(\s*$Type\s*,|\#+)\s*\(*\s*$arg\s*\)*\b//g;
5207649b7   Joe Perches   checkpatch: impro...
4974
  				$tmp =~ s/\#+\s*$arg\b//g;
f59b64bff   Joe Perches   checkpatch: add -...
4975
4976
4977
4978
4979
4980
  				$tmp =~ s/\b$arg\s*\#\#//g;
  				my $use_cnt = $tmp =~ s/\b$arg\b//g;
  				if ($use_cnt > 1) {
  					CHK("MACRO_ARG_REUSE",
  					    "Macro argument reuse '$arg' - possible side-effects?
  " . "$herectx");
9192d41a3   Joe Perches   checkpatch: add -...
4981
4982
4983
4984
4985
4986
4987
4988
  				    }
  # check if any macro arguments may have other precedence issues
  				if ($define_stmt =~ m/($Operators)?\s*\b$arg\b\s*($Operators)?/m &&
  				    ((defined($1) && $1 ne ',') ||
  				     (defined($2) && $2 ne ','))) {
  					CHK("MACRO_ARG_PRECEDENCE",
  					    "Macro argument '$arg' may be better as '($arg)' to avoid precedence issues
  " . "$herectx");
f59b64bff   Joe Perches   checkpatch: add -...
4989
  				}
653d4876b   Andy Whitcroft   update checkpatch...
4990
  			}
5023d3472   Joe Perches   checkpatch: warn ...
4991

08a2843e7   Joe Perches   checkpatch: warn ...
4992
4993
4994
4995
4996
4997
4998
4999
5000
5001
5002
5003
5004
5005
5006
  # check for macros with flow control, but without ## concatenation
  # ## concatenation is commonly a macro that defines a function so ignore those
  			if ($has_flow_statement && !$has_arg_concat) {
  				my $herectx = $here . "
  ";
  				my $cnt = statement_rawlines($ctx);
  
  				for (my $n = 0; $n < $cnt; $n++) {
  					$herectx .= raw_line($linenr, $n) . "
  ";
  				}
  				WARN("MACRO_WITH_FLOW_CONTROL",
  				     "Macros with flow control statements should be avoided
  " . "$herectx");
  			}
481eb486a   Joe Perches   checkpatch: exten...
5007
  # check for line continuations outside of #defines, preprocessor #, and asm
5023d3472   Joe Perches   checkpatch: warn ...
5008
5009
5010
  
  		} else {
  			if ($prevline !~ /^..*\\$/ &&
481eb486a   Joe Perches   checkpatch: exten...
5011
5012
  			    $line !~ /^\+\s*\#.*\\$/ &&		# preprocessor
  			    $line !~ /^\+.*\b(__asm__|asm)\b.*\\$/ &&	# asm
5023d3472   Joe Perches   checkpatch: warn ...
5013
5014
5015
5016
5017
  			    $line =~ /^\+.*\\$/) {
  				WARN("LINE_CONTINUATIONS",
  				     "Avoid unnecessary line continuations
  " . $herecurr);
  			}
0a920b5b6   Andy Whitcroft   add a trivial pat...
5018
  		}
b13edf7ff   Joe Perches   checkpatch: add c...
5019
5020
5021
5022
5023
5024
5025
5026
5027
5028
5029
5030
5031
5032
5033
5034
  # do {} while (0) macro tests:
  # single-statement macros do not need to be enclosed in do while (0) loop,
  # macro should not end with a semicolon
  		if ($^V && $^V ge 5.10.0 &&
  		    $realfile !~ m@/vmlinux.lds.h$@ &&
  		    $line =~ /^.\s*\#\s*define\s+$Ident(\()?/) {
  			my $ln = $linenr;
  			my $cnt = $realcnt;
  			my ($off, $dstat, $dcond, $rest);
  			my $ctx = '';
  			($dstat, $dcond, $ln, $cnt, $off) =
  				ctx_statement_block($linenr, $realcnt, 0);
  			$ctx = $dstat;
  
  			$dstat =~ s/\\
  .//g;
1b36b201c   Joe Perches   checkpatch: Allow...
5035
  			$dstat =~ s/$;/ /g;
b13edf7ff   Joe Perches   checkpatch: add c...
5036
5037
5038
5039
5040
5041
5042
5043
5044
5045
5046
5047
5048
5049
5050
  
  			if ($dstat =~ /^\+\s*#\s*define\s+$Ident\s*${balanced_parens}\s*do\s*{(.*)\s*}\s*while\s*\(\s*0\s*\)\s*([;\s]*)\s*$/) {
  				my $stmts = $2;
  				my $semis = $3;
  
  				$ctx =~ s/
  *$//;
  				my $cnt = statement_rawlines($ctx);
  				my $herectx = $here . "
  ";
  
  				for (my $n = 0; $n < $cnt; $n++) {
  					$herectx .= raw_line($linenr, $n) . "
  ";
  				}
ac8e97f8a   Joe Perches   checkpatch: add c...
5051
5052
  				if (($stmts =~ tr/;/;/) == 1 &&
  				    $stmts !~ /^\s*(if|while|for|switch)\b/) {
b13edf7ff   Joe Perches   checkpatch: add c...
5053
5054
5055
5056
5057
5058
5059
5060
5061
  					WARN("SINGLE_STATEMENT_DO_WHILE_MACRO",
  					     "Single statement macros should not use a do {} while (0) loop
  " . "$herectx");
  				}
  				if (defined $semis && $semis ne "") {
  					WARN("DO_WHILE_MACRO_WITH_TRAILING_SEMICOLON",
  					     "do {} while (0) macros should not be semicolon terminated
  " . "$herectx");
  				}
f5ef95b12   Joe Perches   checkpatch: warn ...
5062
5063
5064
5065
5066
5067
5068
5069
5070
5071
5072
5073
5074
5075
5076
  			} elsif ($dstat =~ /^\+\s*#\s*define\s+$Ident.*;\s*$/) {
  				$ctx =~ s/
  *$//;
  				my $cnt = statement_rawlines($ctx);
  				my $herectx = $here . "
  ";
  
  				for (my $n = 0; $n < $cnt; $n++) {
  					$herectx .= raw_line($linenr, $n) . "
  ";
  				}
  
  				WARN("TRAILING_SEMICOLON",
  				     "macros should not use a trailing semicolon
  " . "$herectx");
b13edf7ff   Joe Perches   checkpatch: add c...
5077
5078
  			}
  		}
080ba9296   Mike Frysinger   checkpatch: try t...
5079
5080
5081
5082
5083
5084
  # make sure symbols are always wrapped with VMLINUX_SYMBOL() ...
  # all assignments may have only one of the following with an assignment:
  #	.
  #	ALIGN(...)
  #	VMLINUX_SYMBOL(...)
  		if ($realfile eq 'vmlinux.lds.h' && $line =~ /(?:(?:^|\s)$Ident\s*=|=\s*$Ident(?:\s|$))/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
5085
5086
5087
  			WARN("MISSING_VMLINUX_SYMBOL",
  			     "vmlinux.lds.h needs VMLINUX_SYMBOL() around C-visible symbols
  " . $herecurr);
080ba9296   Mike Frysinger   checkpatch: try t...
5088
  		}
f0a594c1c   Andy Whitcroft   update checkpatch...
5089
  # check for redundant bracing round if etc
13214adf7   Andy Whitcroft   update checkpatch...
5090
5091
  		if ($line =~ /(^.*)\bif\b/ && $1 !~ /else\s*$/) {
  			my ($level, $endln, @chunks) =
cf655043d   Andy Whitcroft   update checkpatch...
5092
  				ctx_statement_full($linenr, $realcnt, 1);
13214adf7   Andy Whitcroft   update checkpatch...
5093
5094
  			#print "chunks<$#chunks> linenr<$linenr> endln<$endln> level<$level>
  ";
cf655043d   Andy Whitcroft   update checkpatch...
5095
5096
5097
  			#print "APW: <<$chunks[1][0]>><<$chunks[1][1]>>
  ";
  			if ($#chunks > 0 && $level == 0) {
aad4f6149   Joe Perches   checkpatch: add -...
5098
5099
  				my @allowed = ();
  				my $allow = 0;
13214adf7   Andy Whitcroft   update checkpatch...
5100
  				my $seen = 0;
773647a09   Andy Whitcroft   update checkpatch...
5101
5102
  				my $herectx = $here . "
  ";
cf655043d   Andy Whitcroft   update checkpatch...
5103
  				my $ln = $linenr - 1;
13214adf7   Andy Whitcroft   update checkpatch...
5104
5105
  				for my $chunk (@chunks) {
  					my ($cond, $block) = @{$chunk};
773647a09   Andy Whitcroft   update checkpatch...
5106
5107
5108
5109
  					# If the condition carries leading newlines, then count those as offsets.
  					my ($whitespace) = ($cond =~ /^((?:\s*
  [+-])*\s*)/s);
  					my $offset = statement_rawlines($whitespace) - 1;
aad4f6149   Joe Perches   checkpatch: add -...
5110
  					$allowed[$allow] = 0;
773647a09   Andy Whitcroft   update checkpatch...
5111
5112
5113
5114
5115
5116
5117
5118
5119
  					#print "COND<$cond> whitespace<$whitespace> offset<$offset>
  ";
  
  					# We have looked at and allowed this specific line.
  					$suppress_ifbraces{$ln + $offset} = 1;
  
  					$herectx .= "$rawlines[$ln + $offset]
  [...]
  ";
cf655043d   Andy Whitcroft   update checkpatch...
5120
  					$ln += statement_rawlines($block) - 1;
773647a09   Andy Whitcroft   update checkpatch...
5121
  					substr($block, 0, length($cond), '');
13214adf7   Andy Whitcroft   update checkpatch...
5122
5123
  
  					$seen++ if ($block =~ /^\s*{/);
aad4f6149   Joe Perches   checkpatch: add -...
5124
5125
  					#print "cond<$cond> block<$block> allowed<$allowed[$allow]>
  ";
cf655043d   Andy Whitcroft   update checkpatch...
5126
5127
5128
  					if (statement_lines($cond) > 1) {
  						#print "APW: ALLOWED: cond<$cond>
  ";
aad4f6149   Joe Perches   checkpatch: add -...
5129
  						$allowed[$allow] = 1;
13214adf7   Andy Whitcroft   update checkpatch...
5130
5131
  					}
  					if ($block =~/\b(?:if|for|while)\b/) {
cf655043d   Andy Whitcroft   update checkpatch...
5132
5133
  						#print "APW: ALLOWED: block<$block>
  ";
aad4f6149   Joe Perches   checkpatch: add -...
5134
  						$allowed[$allow] = 1;
13214adf7   Andy Whitcroft   update checkpatch...
5135
  					}
cf655043d   Andy Whitcroft   update checkpatch...
5136
5137
5138
  					if (statement_block_size($block) > 1) {
  						#print "APW: ALLOWED: lines block<$block>
  ";
aad4f6149   Joe Perches   checkpatch: add -...
5139
  						$allowed[$allow] = 1;
13214adf7   Andy Whitcroft   update checkpatch...
5140
  					}
aad4f6149   Joe Perches   checkpatch: add -...
5141
  					$allow++;
13214adf7   Andy Whitcroft   update checkpatch...
5142
  				}
aad4f6149   Joe Perches   checkpatch: add -...
5143
5144
5145
5146
5147
5148
5149
5150
5151
5152
5153
5154
5155
5156
5157
  				if ($seen) {
  					my $sum_allowed = 0;
  					foreach (@allowed) {
  						$sum_allowed += $_;
  					}
  					if ($sum_allowed == 0) {
  						WARN("BRACES",
  						     "braces {} are not necessary for any arm of this statement
  " . $herectx);
  					} elsif ($sum_allowed != $allow &&
  						 $seen != $allow) {
  						CHK("BRACES",
  						    "braces {} should be used on all arms of this statement
  " . $herectx);
  					}
13214adf7   Andy Whitcroft   update checkpatch...
5158
5159
5160
  				}
  			}
  		}
773647a09   Andy Whitcroft   update checkpatch...
5161
  		if (!defined $suppress_ifbraces{$linenr - 1} &&
13214adf7   Andy Whitcroft   update checkpatch...
5162
  					$line =~ /\b(if|while|for|else)\b/) {
cf655043d   Andy Whitcroft   update checkpatch...
5163
5164
5165
5166
5167
5168
5169
5170
  			my $allowed = 0;
  
  			# Check the pre-context.
  			if (substr($line, 0, $-[0]) =~ /(\}\s*)$/) {
  				#print "APW: ALLOWED: pre<$1>
  ";
  				$allowed = 1;
  			}
773647a09   Andy Whitcroft   update checkpatch...
5171
5172
5173
  
  			my ($level, $endln, @chunks) =
  				ctx_statement_full($linenr, $realcnt, $-[0]);
cf655043d   Andy Whitcroft   update checkpatch...
5174
5175
  			# Check the condition.
  			my ($cond, $block) = @{$chunks[0]};
773647a09   Andy Whitcroft   update checkpatch...
5176
5177
  			#print "CHECKING<$linenr> cond<$cond> block<$block>
  ";
cf655043d   Andy Whitcroft   update checkpatch...
5178
  			if (defined $cond) {
773647a09   Andy Whitcroft   update checkpatch...
5179
  				substr($block, 0, length($cond), '');
cf655043d   Andy Whitcroft   update checkpatch...
5180
5181
5182
5183
5184
5185
5186
5187
5188
5189
5190
5191
5192
5193
5194
5195
5196
5197
5198
5199
  			}
  			if (statement_lines($cond) > 1) {
  				#print "APW: ALLOWED: cond<$cond>
  ";
  				$allowed = 1;
  			}
  			if ($block =~/\b(?:if|for|while)\b/) {
  				#print "APW: ALLOWED: block<$block>
  ";
  				$allowed = 1;
  			}
  			if (statement_block_size($block) > 1) {
  				#print "APW: ALLOWED: lines block<$block>
  ";
  				$allowed = 1;
  			}
  			# Check the post-context.
  			if (defined $chunks[1]) {
  				my ($cond, $block) = @{$chunks[1]};
  				if (defined $cond) {
773647a09   Andy Whitcroft   update checkpatch...
5200
  					substr($block, 0, length($cond), '');
cf655043d   Andy Whitcroft   update checkpatch...
5201
5202
5203
5204
5205
5206
5207
5208
  				}
  				if ($block =~ /^\s*\{/) {
  					#print "APW: ALLOWED: chunk-1 block<$block>
  ";
  					$allowed = 1;
  				}
  			}
  			if ($level == 0 && $block =~ /^\s*\{/ && !$allowed) {
699324871   Justin P. Mattock   treewide: remove ...
5209
5210
  				my $herectx = $here . "
  ";
f055663c5   Andy Whitcroft   checkpatch: repor...
5211
  				my $cnt = statement_rawlines($block);
cf655043d   Andy Whitcroft   update checkpatch...
5212

f055663c5   Andy Whitcroft   checkpatch: repor...
5213
  				for (my $n = 0; $n < $cnt; $n++) {
699324871   Justin P. Mattock   treewide: remove ...
5214
5215
  					$herectx .= raw_line($linenr, $n) . "
  ";
f0a594c1c   Andy Whitcroft   update checkpatch...
5216
  				}
cf655043d   Andy Whitcroft   update checkpatch...
5217

000d1cc18   Joe Perches   checkpatch.pl: ad...
5218
5219
5220
  				WARN("BRACES",
  				     "braces {} are not necessary for single statement blocks
  " . $herectx);
f0a594c1c   Andy Whitcroft   update checkpatch...
5221
5222
  			}
  		}
0979ae664   Joe Perches   checkpatch: Add -...
5223
  # check for unnecessary blank lines around braces
77b9a53a6   Joe Perches   checkpatch: don't...
5224
  		if (($line =~ /^.\s*}\s*$/ && $prevrawline =~ /^.\s*$/)) {
f8e58219d   Joe Perches   checkpatch: add a...
5225
5226
5227
5228
5229
5230
  			if (CHK("BRACES",
  				"Blank lines aren't necessary before a close brace '}'
  " . $hereprev) &&
  			    $fix && $prevrawline =~ /^\+/) {
  				fix_delete_line($fixlinenr - 1, $prevrawline);
  			}
0979ae664   Joe Perches   checkpatch: Add -...
5231
  		}
77b9a53a6   Joe Perches   checkpatch: don't...
5232
  		if (($rawline =~ /^.\s*$/ && $prevline =~ /^..*{\s*$/)) {
f8e58219d   Joe Perches   checkpatch: add a...
5233
5234
5235
5236
5237
5238
  			if (CHK("BRACES",
  				"Blank lines aren't necessary after an open brace '{'
  " . $hereprev) &&
  			    $fix) {
  				fix_delete_line($fixlinenr, $rawline);
  			}
0979ae664   Joe Perches   checkpatch: Add -...
5239
  		}
4a0df2ef4   Andy Whitcroft   update checkpatch...
5240
  # no volatiles please
6c72ffaab   Andy Whitcroft   update checkpatch...
5241
5242
  		my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b};
  		if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
5243
5244
5245
  			WARN("VOLATILE",
  			     "Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
  " . $herecurr);
4a0df2ef4   Andy Whitcroft   update checkpatch...
5246
  		}
5e4f6ba5e   Joe Perches   checkpatch: add a...
5247
5248
5249
5250
  # Check for user-visible strings broken across lines, which breaks the ability
  # to grep for the string.  Make exceptions when the previous string ends in a
  # newline (multiple lines in one string constant) or '\t', '\r', ';', or '{'
  # (common in inline assembly) or is a octal \123 or hexadecimal \xaf value
33acb54a4   Joe Perches   checkpatch: use $...
5251
  		if ($line =~ /^\+\s*$String/ &&
5e4f6ba5e   Joe Perches   checkpatch: add a...
5252
5253
5254
5255
5256
5257
5258
5259
5260
5261
5262
5263
5264
5265
5266
5267
5268
5269
5270
5271
5272
5273
5274
5275
5276
5277
5278
5279
5280
5281
5282
5283
5284
5285
5286
5287
5288
5289
5290
5291
5292
5293
5294
5295
5296
5297
5298
5299
5300
  		    $prevline =~ /"\s*$/ &&
  		    $prevrawline !~ /(?:\\(?:[ntr]|[0-7]{1,3}|x[0-9a-fA-F]{1,2})|;\s*|\{\s*)"\s*$/) {
  			if (WARN("SPLIT_STRING",
  				 "quoted string split across lines
  " . $hereprev) &&
  				     $fix &&
  				     $prevrawline =~ /^\+.*"\s*$/ &&
  				     $last_coalesced_string_linenr != $linenr - 1) {
  				my $extracted_string = get_quoted_string($line, $rawline);
  				my $comma_close = "";
  				if ($rawline =~ /\Q$extracted_string\E(\s*\)\s*;\s*$|\s*,\s*)/) {
  					$comma_close = $1;
  				}
  
  				fix_delete_line($fixlinenr - 1, $prevrawline);
  				fix_delete_line($fixlinenr, $rawline);
  				my $fixedline = $prevrawline;
  				$fixedline =~ s/"\s*$//;
  				$fixedline .= substr($extracted_string, 1) . trim($comma_close);
  				fix_insert_line($fixlinenr - 1, $fixedline);
  				$fixedline = $rawline;
  				$fixedline =~ s/\Q$extracted_string\E\Q$comma_close\E//;
  				if ($fixedline !~ /\+\s*$/) {
  					fix_insert_line($fixlinenr, $fixedline);
  				}
  				$last_coalesced_string_linenr = $linenr;
  			}
  		}
  
  # check for missing a space in a string concatenation
  		if ($prevrawline =~ /[^\\]\w"$/ && $rawline =~ /^\+[\t ]+"\w/) {
  			WARN('MISSING_SPACE',
  			     "break quoted strings at a space character
  " . $hereprev);
  		}
  
  # check for spaces before a quoted newline
  		if ($rawline =~ /^.*\".*\s\
  /) {
  			if (WARN("QUOTED_WHITESPACE_BEFORE_NEWLINE",
  				 "unnecessary whitespace before a quoted newline
  " . $herecurr) &&
  			    $fix) {
  				$fixed[$fixlinenr] =~ s/^(\+.*\".*)\s+\
  /$1\
  /;
  			}
  
  		}
f17dba4fc   Joe Perches   checkpatch: add -...
5301
  # concatenated string without spaces between elements
33acb54a4   Joe Perches   checkpatch: use $...
5302
  		if ($line =~ /$String[A-Z_]/ || $line =~ /[A-Za-z0-9_]$String/) {
f17dba4fc   Joe Perches   checkpatch: add -...
5303
5304
5305
5306
  			CHK("CONCATENATED_STRING",
  			    "Concatenated strings should use spaces between elements
  " . $herecurr);
  		}
90ad30e5b   Joe Perches   checkpatch: add t...
5307
  # uncoalesced string fragments
33acb54a4   Joe Perches   checkpatch: use $...
5308
  		if ($line =~ /$String\s*"/) {
90ad30e5b   Joe Perches   checkpatch: add t...
5309
5310
5311
5312
  			WARN("STRING_FRAGMENTS",
  			     "Consecutive strings are generally better as a single string
  " . $herecurr);
  		}
6e3007574   Joe Perches   checkpatch: emit ...
5313
  # check for %L{u,d,i} and 0x%[udi] in strings
5e4f6ba5e   Joe Perches   checkpatch: add a...
5314
5315
5316
5317
  		my $string;
  		while ($line =~ /(?:^|")([X\t]*)(?:"|$)/g) {
  			$string = substr($rawline, $-[1], $+[1] - $-[1]);
  			$string =~ s/%%/__/g;
6e3007574   Joe Perches   checkpatch: emit ...
5318
  			if ($string =~ /(?<!%)%[\*\d\.\$]*L[udi]/) {
5e4f6ba5e   Joe Perches   checkpatch: add a...
5319
5320
5321
5322
5323
  				WARN("PRINTF_L",
  				     "\%Ld/%Lu are not-standard C, use %lld/%llu
  " . $herecurr);
  				last;
  			}
6e3007574   Joe Perches   checkpatch: emit ...
5324
5325
5326
5327
5328
  			if ($string =~ /0x%[\*\d\.\$\Llzth]*[udi]/) {
  				ERROR("PRINTF_0xDECIMAL",
  				      "Prefixing 0x with decimal output is defective
  " . $herecurr);
  			}
5e4f6ba5e   Joe Perches   checkpatch: add a...
5329
5330
5331
5332
5333
5334
5335
5336
  		}
  
  # check for line continuations in quoted strings with odd counts of "
  		if ($rawline =~ /\\$/ && $rawline =~ tr/"/"/ % 2) {
  			WARN("LINE_CONTINUATIONS",
  			     "Avoid line continuations in quoted strings
  " . $herecurr);
  		}
00df344fd   Andy Whitcroft   update checkpatch...
5337
  # warn about #if 0
c45dcabd2   Andy Whitcroft   update checkpatch...
5338
  		if ($line =~ /^.\s*\#\s*if\s+0\b/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
5339
5340
5341
  			CHK("REDUNDANT_CODE",
  			    "if this code is redundant consider removing it
  " .
de7d4f0e1   Andy Whitcroft   update checkpatch...
5342
  				$herecurr);
4a0df2ef4   Andy Whitcroft   update checkpatch...
5343
  		}
03df4b51f   Andy Whitcroft   checkpatch: conso...
5344
5345
  # check for needless "if (<foo>) fn(<foo>)" uses
  		if ($prevline =~ /\bif\s*\(\s*($Lval)\s*\)/) {
100425dee   Joe Perches   checkpatch: add s...
5346
5347
5348
5349
5350
5351
5352
5353
5354
5355
5356
5357
5358
5359
5360
5361
5362
5363
5364
5365
5366
5367
5368
5369
5370
5371
5372
5373
5374
  			my $tested = quotemeta($1);
  			my $expr = '\s*\(\s*' . $tested . '\s*\)\s*;';
  			if ($line =~ /\b(kfree|usb_free_urb|debugfs_remove(?:_recursive)?|(?:kmem_cache|mempool|dma_pool)_destroy)$expr/) {
  				my $func = $1;
  				if (WARN('NEEDLESS_IF',
  					 "$func(NULL) is safe and this check is probably not required
  " . $hereprev) &&
  				    $fix) {
  					my $do_fix = 1;
  					my $leading_tabs = "";
  					my $new_leading_tabs = "";
  					if ($lines[$linenr - 2] =~ /^\+(\t*)if\s*\(\s*$tested\s*\)\s*$/) {
  						$leading_tabs = $1;
  					} else {
  						$do_fix = 0;
  					}
  					if ($lines[$linenr - 1] =~ /^\+(\t+)$func\s*\(\s*$tested\s*\)\s*;\s*$/) {
  						$new_leading_tabs = $1;
  						if (length($leading_tabs) + 1 ne length($new_leading_tabs)) {
  							$do_fix = 0;
  						}
  					} else {
  						$do_fix = 0;
  					}
  					if ($do_fix) {
  						fix_delete_line($fixlinenr - 1, $prevrawline);
  						$fixed[$fixlinenr] =~ s/^\+$new_leading_tabs/\+$leading_tabs/;
  					}
  				}
4c432a8f0   Greg Kroah-Hartman   checkpatch: usb_f...
5375
5376
  			}
  		}
f0a594c1c   Andy Whitcroft   update checkpatch...
5377

ebfdc4096   Joe Perches   checkpatch: attem...
5378
5379
5380
5381
5382
5383
5384
5385
5386
5387
5388
5389
5390
5391
5392
5393
5394
5395
5396
5397
5398
5399
5400
5401
  # check for unnecessary "Out of Memory" messages
  		if ($line =~ /^\+.*\b$logFunctions\s*\(/ &&
  		    $prevline =~ /^[ \+]\s*if\s*\(\s*(\!\s*|NULL\s*==\s*)?($Lval)(\s*==\s*NULL\s*)?\s*\)/ &&
  		    (defined $1 || defined $3) &&
  		    $linenr > 3) {
  			my $testval = $2;
  			my $testline = $lines[$linenr - 3];
  
  			my ($s, $c) = ctx_statement_block($linenr - 3, $realcnt, 0);
  #			print("line: <$line>
  prevline: <$prevline>
  s: <$s>
  c: <$c>
  
  
  ");
  
  			if ($c =~ /(?:^|
  )[ \+]\s*(?:$Type\s*)?\Q$testval\E\s*=\s*(?:\([^\)]*\)\s*)?\s*(?:devm_)?(?:[kv][czm]alloc(?:_node|_array)?\b|kstrdup|(?:dev_)?alloc_skb)/) {
  				WARN("OOM_MESSAGE",
  				     "Possible unnecessary 'out of memory' message
  " . $hereprev);
  			}
  		}
f78d98f6c   Joe Perches   checkpatch: warn ...
5402
  # check for logging functions with KERN_<LEVEL>
dcaf11236   Paolo Bonzini   checkpatch: fix U...
5403
  		if ($line !~ /printk(?:_ratelimited|_once)?\s*\(/ &&
f78d98f6c   Joe Perches   checkpatch: warn ...
5404
5405
5406
5407
5408
5409
5410
5411
5412
  		    $line =~ /\b$logFunctions\s*\(.*\b(KERN_[A-Z]+)\b/) {
  			my $level = $1;
  			if (WARN("UNNECESSARY_KERN_LEVEL",
  				 "Possible unnecessary $level
  " . $herecurr) &&
  			    $fix) {
  				$fixed[$fixlinenr] =~ s/\s*$level\s*//;
  			}
  		}
abb08a538   Joe Perches   checkpatch: try t...
5413
5414
5415
5416
5417
5418
5419
5420
  # check for mask then right shift without a parentheses
  		if ($^V && $^V ge 5.10.0 &&
  		    $line =~ /$LvalOrFunc\s*\&\s*($LvalOrFunc)\s*>>/ &&
  		    $4 !~ /^\&/) { # $LvalOrFunc may be &foo, ignore if so
  			WARN("MASK_THEN_SHIFT",
  			     "Possible precedence defect with mask then right shift - may need parentheses
  " . $herecurr);
  		}
b75ac618d   Joe Perches   checkpatch: add -...
5421
5422
5423
5424
5425
5426
5427
5428
5429
5430
5431
5432
5433
5434
  # check for pointer comparisons to NULL
  		if ($^V && $^V ge 5.10.0) {
  			while ($line =~ /\b$LvalOrFunc\s*(==|\!=)\s*NULL\b/g) {
  				my $val = $1;
  				my $equal = "!";
  				$equal = "" if ($4 eq "!=");
  				if (CHK("COMPARISON_TO_NULL",
  					"Comparison to NULL could be written \"${equal}${val}\"
  " . $herecurr) &&
  					    $fix) {
  					$fixed[$fixlinenr] =~ s/\b\Q$val\E\s*(?:==|\!=)\s*NULL\b/$equal$val/;
  				}
  			}
  		}
8716de383   Joe Perches   checkpatch: add t...
5435
5436
5437
5438
5439
5440
5441
5442
5443
5444
5445
5446
5447
5448
5449
  # check for bad placement of section $InitAttribute (e.g.: __initdata)
  		if ($line =~ /(\b$InitAttribute\b)/) {
  			my $attr = $1;
  			if ($line =~ /^\+\s*static\s+(?:const\s+)?(?:$attr\s+)?($NonptrTypeWithAttr)\s+(?:$attr\s+)?($Ident(?:\[[^]]*\])?)\s*[=;]/) {
  				my $ptr = $1;
  				my $var = $2;
  				if ((($ptr =~ /\b(union|struct)\s+$attr\b/ &&
  				      ERROR("MISPLACED_INIT",
  					    "$attr should be placed after $var
  " . $herecurr)) ||
  				     ($ptr !~ /\b(union|struct)\s+$attr\b/ &&
  				      WARN("MISPLACED_INIT",
  					   "$attr should be placed after $var
  " . $herecurr))) &&
  				    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
5450
  					$fixed[$fixlinenr] =~ s/(\bstatic\s+(?:const\s+)?)(?:$attr\s+)?($NonptrTypeWithAttr)\s+(?:$attr\s+)?($Ident(?:\[[^]]*\])?)\s*([=;])\s*/"$1" . trim(string_find_replace($2, "\\s*$attr\\s*", " ")) . " " . trim(string_find_replace($3, "\\s*$attr\\s*", "")) . " $attr" . ("$4" eq ";" ? ";" : " = ")/e;
8716de383   Joe Perches   checkpatch: add t...
5451
5452
5453
  				}
  			}
  		}
e970b8846   Joe Perches   checkpatch: add r...
5454
5455
5456
5457
5458
5459
5460
5461
5462
5463
  # check for $InitAttributeData (ie: __initdata) with const
  		if ($line =~ /\bconst\b/ && $line =~ /($InitAttributeData)/) {
  			my $attr = $1;
  			$attr =~ /($InitAttributePrefix)(.*)/;
  			my $attr_prefix = $1;
  			my $attr_type = $2;
  			if (ERROR("INIT_ATTRIBUTE",
  				  "Use of const init definition must use ${attr_prefix}initconst
  " . $herecurr) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
5464
  				$fixed[$fixlinenr] =~
e970b8846   Joe Perches   checkpatch: add r...
5465
5466
5467
5468
5469
5470
5471
5472
5473
5474
5475
  				    s/$InitAttributeData/${attr_prefix}initconst/;
  			}
  		}
  
  # check for $InitAttributeConst (ie: __initconst) without const
  		if ($line !~ /\bconst\b/ && $line =~ /($InitAttributeConst)/) {
  			my $attr = $1;
  			if (ERROR("INIT_ATTRIBUTE",
  				  "Use of $attr requires a separate use of const
  " . $herecurr) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
5476
  				my $lead = $fixed[$fixlinenr] =~
e970b8846   Joe Perches   checkpatch: add r...
5477
5478
5479
5480
  				    /(^\+\s*(?:static\s+))/;
  				$lead = rtrim($1);
  				$lead = "$lead " if ($lead !~ /^\+$/);
  				$lead = "${lead}const ";
194f66fc9   Joe Perches   checkpatch: add a...
5481
  				$fixed[$fixlinenr] =~ s/(^\+\s*(?:static\s+))/$lead/;
e970b8846   Joe Perches   checkpatch: add r...
5482
5483
  			}
  		}
c17893c74   Joe Perches   checkpatch: add a...
5484
5485
5486
5487
5488
5489
5490
5491
5492
5493
  # check for __read_mostly with const non-pointer (should just be const)
  		if ($line =~ /\b__read_mostly\b/ &&
  		    $line =~ /($Type)\s*$Ident/ && $1 !~ /\*\s*$/ && $1 =~ /\bconst\b/) {
  			if (ERROR("CONST_READ_MOSTLY",
  				  "Invalid use of __read_mostly with const type
  " . $herecurr) &&
  			    $fix) {
  				$fixed[$fixlinenr] =~ s/\s+__read_mostly\b//;
  			}
  		}
fbdb8138c   Joe Perches   checkpatch: warn ...
5494
5495
5496
5497
5498
5499
5500
5501
5502
5503
  # don't use __constant_<foo> functions outside of include/uapi/
  		if ($realfile !~ m@^include/uapi/@ &&
  		    $line =~ /(__constant_(?:htons|ntohs|[bl]e(?:16|32|64)_to_cpu|cpu_to_[bl]e(?:16|32|64)))\s*\(/) {
  			my $constant_func = $1;
  			my $func = $constant_func;
  			$func =~ s/^__constant_//;
  			if (WARN("CONSTANT_CONVERSION",
  				 "$constant_func should be $func
  " . $herecurr) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
5504
  				$fixed[$fixlinenr] =~ s/\b$constant_func\b/$func/g;
fbdb8138c   Joe Perches   checkpatch: warn ...
5505
5506
  			}
  		}
1a15a2508   Patrick Pannuto   checkpatch: prefe...
5507
  # prefer usleep_range over udelay
37581c28e   Bruce Allan   checkpatch: fix U...
5508
  		if ($line =~ /\budelay\s*\(\s*(\d+)\s*\)/) {
43c1d77c3   Joe Perches   checkpatch: add t...
5509
  			my $delay = $1;
1a15a2508   Patrick Pannuto   checkpatch: prefe...
5510
  			# ignore udelay's < 10, however
43c1d77c3   Joe Perches   checkpatch: add t...
5511
  			if (! ($delay < 10) ) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
5512
  				CHK("USLEEP_RANGE",
43c1d77c3   Joe Perches   checkpatch: add t...
5513
5514
5515
5516
5517
5518
5519
  				    "usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt
  " . $herecurr);
  			}
  			if ($delay > 2000) {
  				WARN("LONG_UDELAY",
  				     "long udelay - prefer mdelay; see arch/arm/include/asm/delay.h
  " . $herecurr);
1a15a2508   Patrick Pannuto   checkpatch: prefe...
5520
5521
  			}
  		}
09ef87255   Patrick Pannuto   checkpatch: warn ...
5522
5523
5524
  # warn about unexpectedly long msleep's
  		if ($line =~ /\bmsleep\s*\((\d+)\);/) {
  			if ($1 < 20) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
5525
  				WARN("MSLEEP",
43c1d77c3   Joe Perches   checkpatch: add t...
5526
5527
  				     "msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt
  " . $herecurr);
09ef87255   Patrick Pannuto   checkpatch: warn ...
5528
5529
  			}
  		}
36ec19390   Joe Perches   checkpatch: warn ...
5530
5531
5532
5533
5534
5535
  # check for comparisons of jiffies
  		if ($line =~ /\bjiffies\s*$Compare|$Compare\s*jiffies\b/) {
  			WARN("JIFFIES_COMPARISON",
  			     "Comparing jiffies is almost always wrong; prefer time_after, time_before and friends
  " . $herecurr);
  		}
9d7a34a51   Joe Perches   checkpatch: warn ...
5536
5537
5538
5539
5540
5541
  # check for comparisons of get_jiffies_64()
  		if ($line =~ /\bget_jiffies_64\s*\(\s*\)\s*$Compare|$Compare\s*get_jiffies_64\s*\(\s*\)/) {
  			WARN("JIFFIES_COMPARISON",
  			     "Comparing get_jiffies_64() is almost always wrong; prefer time_after64, time_before64 and friends
  " . $herecurr);
  		}
00df344fd   Andy Whitcroft   update checkpatch...
5542
  # warn about #ifdefs in C files
c45dcabd2   Andy Whitcroft   update checkpatch...
5543
  #		if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) {
00df344fd   Andy Whitcroft   update checkpatch...
5544
5545
5546
5547
5548
  #			print "#ifdef in C files should be avoided
  ";
  #			print "$herecurr";
  #			$clean = 0;
  #		}
22f2a2ef9   Andy Whitcroft   update checkpatch...
5549
  # warn about spacing in #ifdefs
c45dcabd2   Andy Whitcroft   update checkpatch...
5550
  		if ($line =~ /^.\s*\#\s*(ifdef|ifndef|elif)\s\s+/) {
3705ce5bc   Joe Perches   checkpatch: creat...
5551
5552
5553
5554
  			if (ERROR("SPACING",
  				  "exactly one space required after that #$1
  " . $herecurr) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
5555
  				$fixed[$fixlinenr] =~
3705ce5bc   Joe Perches   checkpatch: creat...
5556
5557
  				    s/^(.\s*\#\s*(ifdef|ifndef|elif))\s{2,}/$1 /;
  			}
22f2a2ef9   Andy Whitcroft   update checkpatch...
5558
  		}
4a0df2ef4   Andy Whitcroft   update checkpatch...
5559
  # check for spinlock_t definitions without a comment.
171ae1a49   Andy Whitcroft   update checkpatch...
5560
5561
  		if ($line =~ /^.\s*(struct\s+mutex|spinlock_t)\s+\S+;/ ||
  		    $line =~ /^.\s*(DEFINE_MUTEX)\s*\(/) {
4a0df2ef4   Andy Whitcroft   update checkpatch...
5562
5563
  			my $which = $1;
  			if (!ctx_has_comment($first_line, $linenr)) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
5564
5565
5566
  				CHK("UNCOMMENTED_DEFINITION",
  				    "$1 definition without comment
  " . $herecurr);
4a0df2ef4   Andy Whitcroft   update checkpatch...
5567
5568
5569
  			}
  		}
  # check for memory barriers without a comment.
402c2553a   Michael S. Tsirkin   checkpatch.pl: ad...
5570
5571
5572
5573
5574
5575
5576
5577
5578
5579
5580
5581
5582
5583
5584
5585
5586
  
  		my $barriers = qr{
  			mb|
  			rmb|
  			wmb|
  			read_barrier_depends
  		}x;
  		my $barrier_stems = qr{
  			mb__before_atomic|
  			mb__after_atomic|
  			store_release|
  			load_acquire|
  			store_mb|
  			(?:$barriers)
  		}x;
  		my $all_barriers = qr{
  			(?:$barriers)|
43e361f23   Michael S. Tsirkin   checkpatch: add v...
5587
5588
  			smp_(?:$barrier_stems)|
  			virt_(?:$barrier_stems)
402c2553a   Michael S. Tsirkin   checkpatch.pl: ad...
5589
5590
5591
  		}x;
  
  		if ($line =~ /\b(?:$all_barriers)\s*\(/) {
4a0df2ef4   Andy Whitcroft   update checkpatch...
5592
  			if (!ctx_has_comment($first_line, $linenr)) {
c1fd7bb99   Joe Perches   checkpatch: make ...
5593
5594
5595
  				WARN("MEMORY_BARRIER",
  				     "memory barrier without comment
  " . $herecurr);
4a0df2ef4   Andy Whitcroft   update checkpatch...
5596
5597
  			}
  		}
3ad81779a   Paul E. McKenney   scripts: Make che...
5598

f4073b0f6   Michael S. Tsirkin   checkpatch: check...
5599
5600
5601
5602
5603
5604
5605
5606
5607
5608
  		my $underscore_smp_barriers = qr{__smp_(?:$barrier_stems)}x;
  
  		if ($realfile !~ m@^include/asm-generic/@ &&
  		    $realfile !~ m@/barrier\.h$@ &&
  		    $line =~ m/\b(?:$underscore_smp_barriers)\s*\(/ &&
  		    $line !~ m/^.\s*\#\s*define\s+(?:$underscore_smp_barriers)\s*\(/) {
  			WARN("MEMORY_BARRIER",
  			     "__smp memory barriers shouldn't be used outside barrier.h and asm-generic
  " . $herecurr);
  		}
cb426e99f   Joe Perches   checkpatch: check...
5609
5610
5611
5612
5613
5614
5615
5616
  # check for waitqueue_active without a comment.
  		if ($line =~ /\bwaitqueue_active\s*\(/) {
  			if (!ctx_has_comment($first_line, $linenr)) {
  				WARN("WAITQUEUE_ACTIVE",
  				     "waitqueue_active without comment
  " . $herecurr);
  			}
  		}
3ad81779a   Paul E. McKenney   scripts: Make che...
5617
5618
5619
5620
5621
5622
5623
5624
5625
5626
5627
5628
5629
5630
5631
5632
5633
5634
  
  # Check for expedited grace periods that interrupt non-idle non-nohz
  # online CPUs.  These expedited can therefore degrade real-time response
  # if used carelessly, and should be avoided where not absolutely
  # needed.  It is always OK to use synchronize_rcu_expedited() and
  # synchronize_sched_expedited() at boot time (before real-time applications
  # start) and in error situations where real-time response is compromised in
  # any case.  Note that synchronize_srcu_expedited() does -not- interrupt
  # other CPUs, so don't warn on uses of synchronize_srcu_expedited().
  # Of course, nothing comes for free, and srcu_read_lock() and
  # srcu_read_unlock() do contain full memory barriers in payment for
  # synchronize_srcu_expedited() non-interruption properties.
  		if ($line =~ /\b(synchronize_rcu_expedited|synchronize_sched_expedited)\(/) {
  			WARN("EXPEDITED_RCU_GRACE_PERIOD",
  			     "expedited RCU grace periods should be avoided where they can degrade real-time response
  " . $herecurr);
  
  		}
4a0df2ef4   Andy Whitcroft   update checkpatch...
5635
  # check of hardware specific defines
c45dcabd2   Andy Whitcroft   update checkpatch...
5636
  		if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
5637
5638
5639
  			CHK("ARCH_DEFINES",
  			    "architecture specific defines should be avoided
  " .  $herecurr);
0a920b5b6   Andy Whitcroft   add a trivial pat...
5640
  		}
653d4876b   Andy Whitcroft   update checkpatch...
5641

d4977c78e   Tobias Klauser   checkpatch: warn ...
5642
5643
  # Check that the storage class is at the beginning of a declaration
  		if ($line =~ /\b$Storage\b/ && $line !~ /^.\s*$Storage\b/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
5644
5645
5646
  			WARN("STORAGE_CLASS",
  			     "storage class should be at the beginning of the declaration
  " . $herecurr)
d4977c78e   Tobias Klauser   checkpatch: warn ...
5647
  		}
de7d4f0e1   Andy Whitcroft   update checkpatch...
5648
5649
  # check the location of the inline attribute, that it is between
  # storage class and type.
9c0ca6f9a   Andy Whitcroft   update checkpatch...
5650
5651
  		if ($line =~ /\b$Type\s+$Inline\b/ ||
  		    $line =~ /\b$Inline\s+$Storage\b/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
5652
5653
5654
  			ERROR("INLINE_LOCATION",
  			      "inline keyword should sit between storage class and type
  " . $herecurr);
de7d4f0e1   Andy Whitcroft   update checkpatch...
5655
  		}
8905a67c6   Andy Whitcroft   update checkpatch...
5656
  # Check for __inline__ and __inline, prefer inline
2b7ab4539   Joe Perches   checkpatch: don't...
5657
5658
  		if ($realfile !~ m@\binclude/uapi/@ &&
  		    $line =~ /\b(__inline__|__inline)\b/) {
d5e616fc1   Joe Perches   checkpatch: add a...
5659
5660
5661
5662
  			if (WARN("INLINE",
  				 "plain inline is preferred over $1
  " . $herecurr) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
5663
  				$fixed[$fixlinenr] =~ s/\b(__inline__|__inline)\b/inline/;
d5e616fc1   Joe Perches   checkpatch: add a...
5664
5665
  
  			}
8905a67c6   Andy Whitcroft   update checkpatch...
5666
  		}
3d130fd03   Joe Perches   checkpatch.pl: ad...
5667
  # Check for __attribute__ packed, prefer __packed
2b7ab4539   Joe Perches   checkpatch: don't...
5668
5669
  		if ($realfile !~ m@\binclude/uapi/@ &&
  		    $line =~ /\b__attribute__\s*\(\s*\(.*\bpacked\b/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
5670
5671
5672
  			WARN("PREFER_PACKED",
  			     "__packed is preferred over __attribute__((packed))
  " . $herecurr);
3d130fd03   Joe Perches   checkpatch.pl: ad...
5673
  		}
39b7e2878   Joe Perches   checkpatch: add a...
5674
  # Check for __attribute__ aligned, prefer __aligned
2b7ab4539   Joe Perches   checkpatch: don't...
5675
5676
  		if ($realfile !~ m@\binclude/uapi/@ &&
  		    $line =~ /\b__attribute__\s*\(\s*\(.*aligned/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
5677
5678
5679
  			WARN("PREFER_ALIGNED",
  			     "__aligned(size) is preferred over __attribute__((aligned(size)))
  " . $herecurr);
39b7e2878   Joe Perches   checkpatch: add a...
5680
  		}
5f14d3bd8   Joe Perches   checkpatch: prefe...
5681
  # Check for __attribute__ format(printf, prefer __printf
2b7ab4539   Joe Perches   checkpatch: don't...
5682
5683
  		if ($realfile !~ m@\binclude/uapi/@ &&
  		    $line =~ /\b__attribute__\s*\(\s*\(\s*format\s*\(\s*printf/) {
d5e616fc1   Joe Perches   checkpatch: add a...
5684
5685
5686
5687
  			if (WARN("PREFER_PRINTF",
  				 "__printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check)))
  " . $herecurr) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
5688
  				$fixed[$fixlinenr] =~ s/\b__attribute__\s*\(\s*\(\s*format\s*\(\s*printf\s*,\s*(.*)\)\s*\)\s*\)/"__printf(" . trim($1) . ")"/ex;
d5e616fc1   Joe Perches   checkpatch: add a...
5689
5690
  
  			}
5f14d3bd8   Joe Perches   checkpatch: prefe...
5691
  		}
6061d949d   Joe Perches   include/ and chec...
5692
  # Check for __attribute__ format(scanf, prefer __scanf
2b7ab4539   Joe Perches   checkpatch: don't...
5693
5694
  		if ($realfile !~ m@\binclude/uapi/@ &&
  		    $line =~ /\b__attribute__\s*\(\s*\(\s*format\s*\(\s*scanf\b/) {
d5e616fc1   Joe Perches   checkpatch: add a...
5695
5696
5697
5698
  			if (WARN("PREFER_SCANF",
  				 "__scanf(string-index, first-to-check) is preferred over __attribute__((format(scanf, string-index, first-to-check)))
  " . $herecurr) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
5699
  				$fixed[$fixlinenr] =~ s/\b__attribute__\s*\(\s*\(\s*format\s*\(\s*scanf\s*,\s*(.*)\)\s*\)\s*\)/"__scanf(" . trim($1) . ")"/ex;
d5e616fc1   Joe Perches   checkpatch: add a...
5700
  			}
6061d949d   Joe Perches   include/ and chec...
5701
  		}
619a908aa   Joe Perches   checkpatch: add e...
5702
5703
5704
5705
5706
5707
5708
5709
5710
  # Check for __attribute__ weak, or __weak declarations (may have link issues)
  		if ($^V && $^V ge 5.10.0 &&
  		    $line =~ /(?:$Declare|$DeclareMisordered)\s*$Ident\s*$balanced_parens\s*(?:$Attribute)?\s*;/ &&
  		    ($line =~ /\b__attribute__\s*\(\s*\(.*\bweak\b/ ||
  		     $line =~ /\b__weak\b/)) {
  			ERROR("WEAK_DECLARATION",
  			      "Using weak declarations can have unintended link defects
  " . $herecurr);
  		}
e6176fa47   Joe Perches   checkpatch: add -...
5711
5712
5713
5714
5715
5716
5717
5718
5719
5720
5721
5722
5723
5724
5725
5726
5727
5728
  # check for c99 types like uint8_t used outside of uapi/
  		if ($realfile !~ m@\binclude/uapi/@ &&
  		    $line =~ /\b($Declare)\s*$Ident\s*[=;,\[]/) {
  			my $type = $1;
  			if ($type =~ /\b($typeC99Typedefs)\b/) {
  				$type = $1;
  				my $kernel_type = 'u';
  				$kernel_type = 's' if ($type =~ /^_*[si]/);
  				$type =~ /(\d+)/;
  				$kernel_type .= $1;
  				if (CHK("PREFER_KERNEL_TYPES",
  					"Prefer kernel type '$kernel_type' over '$type'
  " . $herecurr) &&
  				    $fix) {
  					$fixed[$fixlinenr] =~ s/\b$type\b/$kernel_type/;
  				}
  			}
  		}
938224b5e   Joe Perches   checkpatch: warn ...
5729
5730
5731
5732
5733
5734
5735
5736
5737
5738
5739
5740
5741
5742
5743
5744
5745
5746
5747
5748
  # check for cast of C90 native int or longer types constants
  		if ($line =~ /(\(\s*$C90_int_types\s*\)\s*)($Constant)\b/) {
  			my $cast = $1;
  			my $const = $2;
  			if (WARN("TYPECAST_INT_CONSTANT",
  				 "Unnecessary typecast of c90 int constant
  " . $herecurr) &&
  			    $fix) {
  				my $suffix = "";
  				my $newconst = $const;
  				$newconst =~ s/${Int_type}$//;
  				$suffix .= 'U' if ($cast =~ /\bunsigned\b/);
  				if ($cast =~ /\blong\s+long\b/) {
  					$suffix .= 'LL';
  				} elsif ($cast =~ /\blong\b/) {
  					$suffix .= 'L';
  				}
  				$fixed[$fixlinenr] =~ s/\Q$cast\E$const\b/$newconst$suffix/;
  			}
  		}
8f53a9b80   Joe Perches   scripts/checkpatc...
5749
5750
  # check for sizeof(&)
  		if ($line =~ /\bsizeof\s*\(\s*\&/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
5751
5752
5753
  			WARN("SIZEOF_ADDRESS",
  			     "sizeof(& should be avoided
  " . $herecurr);
8f53a9b80   Joe Perches   scripts/checkpatc...
5754
  		}
66c80b607   Joe Perches   checkpatch: Add a...
5755
5756
  # check for sizeof without parenthesis
  		if ($line =~ /\bsizeof\s+((?:\*\s*|)$Lval|$Type(?:\s+$Lval|))/) {
d5e616fc1   Joe Perches   checkpatch: add a...
5757
5758
5759
5760
  			if (WARN("SIZEOF_PARENTHESIS",
  				 "sizeof $1 should be sizeof($1)
  " . $herecurr) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
5761
  				$fixed[$fixlinenr] =~ s/\bsizeof\s+((?:\*\s*|)$Lval|$Type(?:\s+$Lval|))/"sizeof(" . trim($1) . ")"/ex;
d5e616fc1   Joe Perches   checkpatch: add a...
5762
  			}
66c80b607   Joe Perches   checkpatch: Add a...
5763
  		}
88982fea5   Joe Perches   checkpatch: warn ...
5764
5765
5766
5767
5768
5769
  # check for struct spinlock declarations
  		if ($line =~ /^.\s*\bstruct\s+spinlock\s+\w+\s*;/) {
  			WARN("USE_SPINLOCK_T",
  			     "struct spinlock should be spinlock_t
  " . $herecurr);
  		}
a6962d727   Joe Perches   checkpatch: Prefe...
5770
  # check for seq_printf uses that could be seq_puts
066687279   Joe Perches   checkpatch: updat...
5771
  		if ($sline =~ /\bseq_printf\s*\(.*"\s*\)\s*;\s*$/) {
a6962d727   Joe Perches   checkpatch: Prefe...
5772
  			my $fmt = get_quoted_string($line, $rawline);
caac1d5fd   Heba Aamer   checkpatch: impro...
5773
5774
  			$fmt =~ s/%%//g;
  			if ($fmt !~ /%/) {
d5e616fc1   Joe Perches   checkpatch: add a...
5775
5776
5777
5778
  				if (WARN("PREFER_SEQ_PUTS",
  					 "Prefer seq_puts to seq_printf
  " . $herecurr) &&
  				    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
5779
  					$fixed[$fixlinenr] =~ s/\bseq_printf\b/seq_puts/;
d5e616fc1   Joe Perches   checkpatch: add a...
5780
  				}
a6962d727   Joe Perches   checkpatch: Prefe...
5781
5782
  			}
  		}
554e165cf   Andy Whitcroft   checkpatch: check...
5783
  # Check for misused memsets
d1fe9c099   Joe Perches   checkpatch: add s...
5784
5785
  		if ($^V && $^V ge 5.10.0 &&
  		    defined $stat &&
9e20a8535   Mateusz Kulikowski   checkpatch: fix p...
5786
  		    $stat =~ /^\+(?:.*?)\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*$FuncArg\s*\)/) {
d7c76ba7e   Joe Perches   checkpatch: impro...
5787
5788
  
  			my $ms_addr = $2;
d1fe9c099   Joe Perches   checkpatch: add s...
5789
5790
  			my $ms_val = $7;
  			my $ms_size = $12;
554e165cf   Andy Whitcroft   checkpatch: check...
5791

554e165cf   Andy Whitcroft   checkpatch: check...
5792
5793
  			if ($ms_size =~ /^(0x|)0$/i) {
  				ERROR("MEMSET",
d7c76ba7e   Joe Perches   checkpatch: impro...
5794
5795
5796
5797
  				      "memset to 0's uses 0 as the 2nd argument, not the 3rd
  " . "$here
  $stat
  ");
554e165cf   Andy Whitcroft   checkpatch: check...
5798
5799
  			} elsif ($ms_size =~ /^(0x|)1$/i) {
  				WARN("MEMSET",
d7c76ba7e   Joe Perches   checkpatch: impro...
5800
5801
5802
5803
5804
5805
  				     "single byte memset is suspicious. Swapped 2nd/3rd argument?
  " . "$here
  $stat
  ");
  			}
  		}
98a9bba51   Joe Perches   checkpatch: prefe...
5806
  # Check for memcpy(foo, bar, ETH_ALEN) that could be ether_addr_copy(foo, bar)
f333195d4   Joe Perches   checkpatch: don't...
5807
5808
5809
5810
5811
5812
5813
5814
5815
5816
5817
5818
  #		if ($^V && $^V ge 5.10.0 &&
  #		    defined $stat &&
  #		    $stat =~ /^\+(?:.*?)\bmemcpy\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/) {
  #			if (WARN("PREFER_ETHER_ADDR_COPY",
  #				 "Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)
  " . "$here
  $stat
  ") &&
  #			    $fix) {
  #				$fixed[$fixlinenr] =~ s/\bmemcpy\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/ether_addr_copy($2, $7)/;
  #			}
  #		}
98a9bba51   Joe Perches   checkpatch: prefe...
5819

b6117d175   Mateusz Kulikowski   checkpatch: sugge...
5820
  # Check for memcmp(foo, bar, ETH_ALEN) that could be ether_addr_equal*(foo, bar)
f333195d4   Joe Perches   checkpatch: don't...
5821
5822
5823
5824
5825
5826
5827
5828
5829
  #		if ($^V && $^V ge 5.10.0 &&
  #		    defined $stat &&
  #		    $stat =~ /^\+(?:.*?)\bmemcmp\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/) {
  #			WARN("PREFER_ETHER_ADDR_EQUAL",
  #			     "Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()
  " . "$here
  $stat
  ")
  #		}
b6117d175   Mateusz Kulikowski   checkpatch: sugge...
5830

8617cd09b   Mateusz Kulikowski   checkpatch: sugge...
5831
5832
  # check for memset(foo, 0x0, ETH_ALEN) that could be eth_zero_addr
  # check for memset(foo, 0xFF, ETH_ALEN) that could be eth_broadcast_addr
f333195d4   Joe Perches   checkpatch: don't...
5833
5834
5835
5836
5837
5838
5839
5840
5841
5842
5843
5844
5845
5846
5847
5848
5849
5850
5851
5852
5853
5854
5855
5856
5857
5858
  #		if ($^V && $^V ge 5.10.0 &&
  #		    defined $stat &&
  #		    $stat =~ /^\+(?:.*?)\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/) {
  #
  #			my $ms_val = $7;
  #
  #			if ($ms_val =~ /^(?:0x|)0+$/i) {
  #				if (WARN("PREFER_ETH_ZERO_ADDR",
  #					 "Prefer eth_zero_addr over memset()
  " . "$here
  $stat
  ") &&
  #				    $fix) {
  #					$fixed[$fixlinenr] =~ s/\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*,\s*ETH_ALEN\s*\)/eth_zero_addr($2)/;
  #				}
  #			} elsif ($ms_val =~ /^(?:0xff|255)$/i) {
  #				if (WARN("PREFER_ETH_BROADCAST_ADDR",
  #					 "Prefer eth_broadcast_addr() over memset()
  " . "$here
  $stat
  ") &&
  #				    $fix) {
  #					$fixed[$fixlinenr] =~ s/\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*,\s*ETH_ALEN\s*\)/eth_broadcast_addr($2)/;
  #				}
  #			}
  #		}
8617cd09b   Mateusz Kulikowski   checkpatch: sugge...
5859

d7c76ba7e   Joe Perches   checkpatch: impro...
5860
  # typecasts on min/max could be min_t/max_t
d1fe9c099   Joe Perches   checkpatch: add s...
5861
5862
  		if ($^V && $^V ge 5.10.0 &&
  		    defined $stat &&
d7c76ba7e   Joe Perches   checkpatch: impro...
5863
  		    $stat =~ /^\+(?:.*?)\b(min|max)\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\)/) {
d1fe9c099   Joe Perches   checkpatch: add s...
5864
  			if (defined $2 || defined $7) {
d7c76ba7e   Joe Perches   checkpatch: impro...
5865
5866
5867
  				my $call = $1;
  				my $cast1 = deparenthesize($2);
  				my $arg1 = $3;
d1fe9c099   Joe Perches   checkpatch: add s...
5868
5869
  				my $cast2 = deparenthesize($7);
  				my $arg2 = $8;
d7c76ba7e   Joe Perches   checkpatch: impro...
5870
  				my $cast;
d1fe9c099   Joe Perches   checkpatch: add s...
5871
  				if ($cast1 ne "" && $cast2 ne "" && $cast1 ne $cast2) {
d7c76ba7e   Joe Perches   checkpatch: impro...
5872
5873
5874
5875
5876
5877
5878
5879
5880
5881
5882
  					$cast = "$cast1 or $cast2";
  				} elsif ($cast1 ne "") {
  					$cast = $cast1;
  				} else {
  					$cast = $cast2;
  				}
  				WARN("MINMAX",
  				     "$call() should probably be ${call}_t($cast, $arg1, $arg2)
  " . "$here
  $stat
  ");
554e165cf   Andy Whitcroft   checkpatch: check...
5883
5884
  			}
  		}
4a273195a   Joe Perches   checkpatch: check...
5885
5886
5887
5888
5889
5890
5891
5892
5893
5894
5895
5896
5897
5898
5899
5900
5901
5902
5903
5904
5905
  # check usleep_range arguments
  		if ($^V && $^V ge 5.10.0 &&
  		    defined $stat &&
  		    $stat =~ /^\+(?:.*?)\busleep_range\s*\(\s*($FuncArg)\s*,\s*($FuncArg)\s*\)/) {
  			my $min = $1;
  			my $max = $7;
  			if ($min eq $max) {
  				WARN("USLEEP_RANGE",
  				     "usleep_range should not use min == max args; see Documentation/timers/timers-howto.txt
  " . "$here
  $stat
  ");
  			} elsif ($min =~ /^\d+$/ && $max =~ /^\d+$/ &&
  				 $min > $max) {
  				WARN("USLEEP_RANGE",
  				     "usleep_range args reversed, use min then max; see Documentation/timers/timers-howto.txt
  " . "$here
  $stat
  ");
  			}
  		}
823b794ce   Joe Perches   checkpatch: add c...
5906
5907
5908
  # check for naked sscanf
  		if ($^V && $^V ge 5.10.0 &&
  		    defined $stat &&
6c8bd7076   Joe Perches   checkpatch: avoid...
5909
  		    $line =~ /\bsscanf\b/ &&
823b794ce   Joe Perches   checkpatch: add c...
5910
5911
5912
5913
5914
5915
5916
5917
5918
5919
5920
5921
5922
5923
5924
5925
5926
  		    ($stat !~ /$Ident\s*=\s*sscanf\s*$balanced_parens/ &&
  		     $stat !~ /\bsscanf\s*$balanced_parens\s*(?:$Compare)/ &&
  		     $stat !~ /(?:$Compare)\s*\bsscanf\s*$balanced_parens/)) {
  			my $lc = $stat =~ tr@
  @@;
  			$lc = $lc + $linenr;
  			my $stat_real = raw_line($linenr, 0);
  		        for (my $count = $linenr + 1; $count <= $lc; $count++) {
  				$stat_real = $stat_real . "
  " . raw_line($count, 0);
  			}
  			WARN("NAKED_SSCANF",
  			     "unchecked sscanf return value
  " . "$here
  $stat_real
  ");
  		}
afc819ab0   Joe Perches   checkpatch: prefe...
5927
5928
5929
5930
5931
5932
5933
5934
5935
5936
5937
5938
5939
5940
5941
5942
5943
5944
5945
5946
5947
5948
5949
5950
5951
  # check for simple sscanf that should be kstrto<foo>
  		if ($^V && $^V ge 5.10.0 &&
  		    defined $stat &&
  		    $line =~ /\bsscanf\b/) {
  			my $lc = $stat =~ tr@
  @@;
  			$lc = $lc + $linenr;
  			my $stat_real = raw_line($linenr, 0);
  		        for (my $count = $linenr + 1; $count <= $lc; $count++) {
  				$stat_real = $stat_real . "
  " . raw_line($count, 0);
  			}
  			if ($stat_real =~ /\bsscanf\b\s*\(\s*$FuncArg\s*,\s*("[^"]+")/) {
  				my $format = $6;
  				my $count = $format =~ tr@%@%@;
  				if ($count == 1 &&
  				    $format =~ /^"\%(?i:ll[udxi]|[udxi]ll|ll|[hl]h?[udxi]|[udxi][hl]h?|[hl]h?|[udxi])"$/) {
  					WARN("SSCANF_TO_KSTRTO",
  					     "Prefer kstrto<type> to single variable sscanf
  " . "$here
  $stat_real
  ");
  				}
  			}
  		}
70dc8a483   Joe Perches   checkpatch: warn ...
5952
5953
5954
  # check for new externs in .h files.
  		if ($realfile =~ /\.h$/ &&
  		    $line =~ /^\+\s*(extern\s+)$Type\s*$Ident\s*\(/s) {
d1d85780d   Joe Perches   checkpatch: make ...
5955
5956
5957
  			if (CHK("AVOID_EXTERNS",
  				"extern prototypes should be avoided in .h files
  " . $herecurr) &&
70dc8a483   Joe Perches   checkpatch: warn ...
5958
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
5959
  				$fixed[$fixlinenr] =~ s/(.*)\bextern\b\s*(.*)/$1$2/;
70dc8a483   Joe Perches   checkpatch: warn ...
5960
5961
  			}
  		}
de7d4f0e1   Andy Whitcroft   update checkpatch...
5962
  # check for new externs in .c files.
171ae1a49   Andy Whitcroft   update checkpatch...
5963
  		if ($realfile =~ /\.c$/ && defined $stat &&
c45dcabd2   Andy Whitcroft   update checkpatch...
5964
  		    $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s)
171ae1a49   Andy Whitcroft   update checkpatch...
5965
  		{
c45dcabd2   Andy Whitcroft   update checkpatch...
5966
5967
  			my $function_name = $1;
  			my $paren_space = $2;
171ae1a49   Andy Whitcroft   update checkpatch...
5968
5969
5970
5971
5972
  
  			my $s = $stat;
  			if (defined $cond) {
  				substr($s, 0, length($cond), '');
  			}
c45dcabd2   Andy Whitcroft   update checkpatch...
5973
5974
5975
  			if ($s =~ /^\s*;/ &&
  			    $function_name ne 'uninitialized_var')
  			{
000d1cc18   Joe Perches   checkpatch.pl: ad...
5976
5977
5978
  				WARN("AVOID_EXTERNS",
  				     "externs should be avoided in .c files
  " .  $herecurr);
171ae1a49   Andy Whitcroft   update checkpatch...
5979
5980
5981
5982
  			}
  
  			if ($paren_space =~ /
  /) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
5983
5984
5985
  				WARN("FUNCTION_ARGUMENTS",
  				     "arguments for function declarations should follow identifier
  " . $herecurr);
171ae1a49   Andy Whitcroft   update checkpatch...
5986
  			}
9c9ba34ee   Andy Whitcroft   update checkpatch...
5987
5988
5989
5990
  
  		} elsif ($realfile =~ /\.c$/ && defined $stat &&
  		    $stat =~ /^.\s*extern\s+/)
  		{
000d1cc18   Joe Perches   checkpatch.pl: ad...
5991
5992
5993
  			WARN("AVOID_EXTERNS",
  			     "externs should be avoided in .c files
  " .  $herecurr);
de7d4f0e1   Andy Whitcroft   update checkpatch...
5994
  		}
ca0d8929e   Joe Perches   checkpatch: add w...
5995
5996
5997
5998
5999
6000
6001
6002
6003
6004
6005
6006
6007
  		if ($realfile =~ /\.[ch]$/ && defined $stat &&
  		    $stat =~ /^.\s*(?:extern\s+)?$Type\s*$Ident\s*\(\s*([^{]+)\s*\)\s*;/s &&
  		    $1 ne "void") {
  			my $args = trim($1);
  			while ($args =~ m/\s*($Type\s*(?:$Ident|\(\s*\*\s*$Ident?\s*\)\s*$balanced_parens)?)/g) {
  				my $arg = trim($1);
  				if ($arg =~ /^$Type$/ && $arg !~ /enum\s+$Ident$/) {
  					WARN("FUNCTION_ARGUMENTS",
  					     "function definition argument '$arg' should also have an identifier name
  " . $herecurr);
  				}
  			}
  		}
de7d4f0e1   Andy Whitcroft   update checkpatch...
6008
6009
6010
6011
6012
  # checks for new __setup's
  		if ($rawline =~ /\b__setup\("([^"]*)"/) {
  			my $name = $1;
  
  			if (!grep(/$name/, @setup_docs)) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
6013
6014
6015
  				CHK("UNDOCUMENTED_SETUP",
  				    "__setup appears un-documented -- check Documentation/kernel-parameters.txt
  " . $herecurr);
de7d4f0e1   Andy Whitcroft   update checkpatch...
6016
  			}
653d4876b   Andy Whitcroft   update checkpatch...
6017
  		}
9c0ca6f9a   Andy Whitcroft   update checkpatch...
6018
6019
  
  # check for pointless casting of kmalloc return
caf2a54f1   Joe Perches   scripts/checkpatc...
6020
  		if ($line =~ /\*\s*\)\s*[kv][czm]alloc(_node){0,1}\b/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
6021
6022
6023
  			WARN("UNNECESSARY_CASTS",
  			     "unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html
  " . $herecurr);
9c0ca6f9a   Andy Whitcroft   update checkpatch...
6024
  		}
13214adf7   Andy Whitcroft   update checkpatch...
6025

a640d25ce   Joe Perches   checkpatch: add -...
6026
6027
6028
6029
6030
6031
6032
6033
  # alloc style
  # p = alloc(sizeof(struct foo), ...) should be p = alloc(sizeof(*p), ...)
  		if ($^V && $^V ge 5.10.0 &&
  		    $line =~ /\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*([kv][mz]alloc(?:_node)?)\s*\(\s*(sizeof\s*\(\s*struct\s+$Lval\s*\))/) {
  			CHK("ALLOC_SIZEOF_STRUCT",
  			    "Prefer $3(sizeof(*$1)...) over $3($4...)
  " . $herecurr);
  		}
60a55369a   Joe Perches   checkpatch: add w...
6034
6035
  # check for k[mz]alloc with multiplies that could be kmalloc_array/kcalloc
  		if ($^V && $^V ge 5.10.0 &&
e367455a9   Joe Perches   checkpatch: emit ...
6036
  		    $line =~ /\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*(k[mz]alloc)\s*\(\s*($FuncArg)\s*\*\s*($FuncArg)\s*,/) {
60a55369a   Joe Perches   checkpatch: add w...
6037
6038
6039
6040
6041
  			my $oldfunc = $3;
  			my $a1 = $4;
  			my $a2 = $10;
  			my $newfunc = "kmalloc_array";
  			$newfunc = "kcalloc" if ($oldfunc eq "kzalloc");
e367455a9   Joe Perches   checkpatch: emit ...
6042
6043
6044
6045
6046
6047
6048
6049
  			my $r1 = $a1;
  			my $r2 = $a2;
  			if ($a1 =~ /^sizeof\s*\S/) {
  				$r1 = $a2;
  				$r2 = $a1;
  			}
  			if ($r1 !~ /^sizeof\b/ && $r2 =~ /^sizeof\s*\S/ &&
  			    !($r1 =~ /^$Constant$/ || $r1 =~ /^[A-Z_][A-Z0-9_]*$/)) {
60a55369a   Joe Perches   checkpatch: add w...
6050
6051
6052
6053
  				if (WARN("ALLOC_WITH_MULTIPLY",
  					 "Prefer $newfunc over $oldfunc with multiply
  " . $herecurr) &&
  				    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
6054
  					$fixed[$fixlinenr] =~ s/\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*(k[mz]alloc)\s*\(\s*($FuncArg)\s*\*\s*($FuncArg)/$1 . ' = ' . "$newfunc(" . trim($r1) . ', ' . trim($r2)/e;
60a55369a   Joe Perches   checkpatch: add w...
6055
6056
6057
6058
  
  				}
  			}
  		}
972fdea2e   Joe Perches   checkpatch: add c...
6059
6060
6061
6062
6063
6064
6065
  # check for krealloc arg reuse
  		if ($^V && $^V ge 5.10.0 &&
  		    $line =~ /\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*krealloc\s*\(\s*\1\s*,/) {
  			WARN("KREALLOC_ARG_REUSE",
  			     "Reusing the krealloc arg is almost always a bug
  " . $herecurr);
  		}
5ce59ae0b   Joe Perches   checkpatch: Add c...
6066
6067
6068
6069
6070
6071
  # check for alloc argument mismatch
  		if ($line =~ /\b(kcalloc|kmalloc_array)\s*\(\s*sizeof\b/) {
  			WARN("ALLOC_ARRAY_ARGS",
  			     "$1 uses number as first arg, sizeof is generally wrong
  " . $herecurr);
  		}
caf2a54f1   Joe Perches   scripts/checkpatc...
6072
6073
  # check for multiple semicolons
  		if ($line =~ /;\s*;\s*$/) {
d5e616fc1   Joe Perches   checkpatch: add a...
6074
6075
6076
6077
  			if (WARN("ONE_SEMICOLON",
  				 "Statements terminations use 1 semicolon
  " . $herecurr) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
6078
  				$fixed[$fixlinenr] =~ s/(\s*;\s*){2,}$/;/g;
d5e616fc1   Joe Perches   checkpatch: add a...
6079
  			}
d1e2ad07e   Joe Perches   checkpatch: add -...
6080
  		}
cec3aaa56   Tomas Winkler   checkpatch: don't...
6081
6082
6083
  # check for #defines like: 1 << <digit> that could be BIT(digit), it is not exported to uapi
  		if ($realfile !~ m@^include/uapi/@ &&
  		    $line =~ /#\s*define\s+\w+\s+\(?\s*1\s*([ulUL]*)\s*\<\<\s*(?:\d+|$Ident)\s*\)?/) {
0ab901918   Joe Perches   checkpatch: add -...
6084
6085
6086
6087
6088
6089
6090
6091
6092
  			my $ull = "";
  			$ull = "_ULL" if (defined($1) && $1 =~ /ll/i);
  			if (CHK("BIT_MACRO",
  				"Prefer using the BIT$ull macro
  " . $herecurr) &&
  			    $fix) {
  				$fixed[$fixlinenr] =~ s/\(?\s*1\s*[ulUL]*\s*<<\s*(\d+|$Ident)\s*\)?/BIT${ull}($1)/;
  			}
  		}
2d6327459   Joe Perches   checkpatch: add P...
6093
6094
6095
6096
6097
6098
6099
6100
6101
6102
  # check for #if defined CONFIG_<FOO> || defined CONFIG_<FOO>_MODULE
  		if ($line =~ /^\+\s*#\s*if\s+defined(?:\s*\(?\s*|\s+)(CONFIG_[A-Z_]+)\s*\)?\s*\|\|\s*defined(?:\s*\(?\s*|\s+)\1_MODULE\s*\)?\s*$/) {
  			my $config = $1;
  			if (WARN("PREFER_IS_ENABLED",
  				 "Prefer IS_ENABLED(<FOO>) to CONFIG_<FOO> || CONFIG_<FOO>_MODULE
  " . $herecurr) &&
  			    $fix) {
  				$fixed[$fixlinenr] = "\+#if IS_ENABLED($config)";
  			}
  		}
e81f239b4   Joe Perches   checkpatch: fix f...
6103
  # check for case / default statements not preceded by break/fallthrough/switch
c34c09a84   Joe Perches   checkpatch: attem...
6104
6105
6106
6107
6108
  		if ($line =~ /^.\s*(?:case\s+(?:$Ident|$Constant)\s*|default):/) {
  			my $has_break = 0;
  			my $has_statement = 0;
  			my $count = 0;
  			my $prevline = $linenr;
e81f239b4   Joe Perches   checkpatch: fix f...
6109
  			while ($prevline > 1 && ($file || $count < 3) && !$has_break) {
c34c09a84   Joe Perches   checkpatch: attem...
6110
6111
6112
6113
6114
6115
6116
6117
6118
6119
6120
6121
6122
6123
6124
6125
6126
6127
  				$prevline--;
  				my $rline = $rawlines[$prevline - 1];
  				my $fline = $lines[$prevline - 1];
  				last if ($fline =~ /^\@\@/);
  				next if ($fline =~ /^\-/);
  				next if ($fline =~ /^.(?:\s*(?:case\s+(?:$Ident|$Constant)[\s$;]*|default):[\s$;]*)*$/);
  				$has_break = 1 if ($rline =~ /fall[\s_-]*(through|thru)/i);
  				next if ($fline =~ /^.[\s$;]*$/);
  				$has_statement = 1;
  				$count++;
  				$has_break = 1 if ($fline =~ /\bswitch\b|\b(?:break\s*;[\s$;]*$|return\b|goto\b|continue\b)/);
  			}
  			if (!$has_break && $has_statement) {
  				WARN("MISSING_BREAK",
  				     "Possible switch case/default not preceeded by break or fallthrough comment
  " . $herecurr);
  			}
  		}
d1e2ad07e   Joe Perches   checkpatch: add -...
6128
6129
6130
6131
6132
6133
6134
6135
6136
6137
6138
6139
6140
6141
6142
  # check for switch/default statements without a break;
  		if ($^V && $^V ge 5.10.0 &&
  		    defined $stat &&
  		    $stat =~ /^\+[$;\s]*(?:case[$;\s]+\w+[$;\s]*:[$;\s]*|)*[$;\s]*\bdefault[$;\s]*:[$;\s]*;/g) {
  			my $ctx = '';
  			my $herectx = $here . "
  ";
  			my $cnt = statement_rawlines($stat);
  			for (my $n = 0; $n < $cnt; $n++) {
  				$herectx .= raw_line($linenr, $n) . "
  ";
  			}
  			WARN("DEFAULT_NO_BREAK",
  			     "switch default: should use break
  " . $herectx);
caf2a54f1   Joe Perches   scripts/checkpatc...
6143
  		}
13214adf7   Andy Whitcroft   update checkpatch...
6144
  # check for gcc specific __FUNCTION__
d5e616fc1   Joe Perches   checkpatch: add a...
6145
6146
6147
6148
6149
  		if ($line =~ /\b__FUNCTION__\b/) {
  			if (WARN("USE_FUNC",
  				 "__func__ should be used instead of gcc specific __FUNCTION__
  "  . $herecurr) &&
  			    $fix) {
194f66fc9   Joe Perches   checkpatch: add a...
6150
  				$fixed[$fixlinenr] =~ s/\b__FUNCTION__\b/__func__/g;
d5e616fc1   Joe Perches   checkpatch: add a...
6151
  			}
13214adf7   Andy Whitcroft   update checkpatch...
6152
  		}
773647a09   Andy Whitcroft   update checkpatch...
6153

62ec818f5   Joe Perches   checkpatch: emit ...
6154
6155
6156
6157
6158
6159
  # check for uses of __DATE__, __TIME__, __TIMESTAMP__
  		while ($line =~ /\b(__(?:DATE|TIME|TIMESTAMP)__)\b/g) {
  			ERROR("DATE_TIME",
  			      "Use of the '$1' macro makes the build non-deterministic
  " . $herecurr);
  		}
2c92488ab   Joe Perches   checkpatch: warn ...
6160
6161
6162
6163
6164
6165
  # check for use of yield()
  		if ($line =~ /\byield\s*\(\s*\)/) {
  			WARN("YIELD",
  			     "Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)
  "  . $herecurr);
  		}
179f8f40f   Joe Perches   checkpatch: add a...
6166
6167
6168
6169
6170
6171
6172
6173
6174
6175
6176
6177
6178
6179
6180
6181
6182
6183
6184
6185
6186
6187
6188
6189
6190
6191
6192
6193
  # check for comparisons against true and false
  		if ($line =~ /\+\s*(.*?)\b(true|false|$Lval)\s*(==|\!=)\s*(true|false|$Lval)\b(.*)$/i) {
  			my $lead = $1;
  			my $arg = $2;
  			my $test = $3;
  			my $otype = $4;
  			my $trail = $5;
  			my $op = "!";
  
  			($arg, $otype) = ($otype, $arg) if ($arg =~ /^(?:true|false)$/i);
  
  			my $type = lc($otype);
  			if ($type =~ /^(?:true|false)$/) {
  				if (("$test" eq "==" && "$type" eq "true") ||
  				    ("$test" eq "!=" && "$type" eq "false")) {
  					$op = "";
  				}
  
  				CHK("BOOL_COMPARISON",
  				    "Using comparison to $otype is error prone
  " . $herecurr);
  
  ## maybe suggesting a correct construct would better
  ##				    "Using comparison to $otype is error prone.  Perhaps use '${lead}${op}${arg}${trail}'
  " . $herecurr);
  
  			}
  		}
4882720b2   Thomas Gleixner   semaphore: Remove...
6194
6195
  # check for semaphores initialized locked
  		if ($line =~ /^.\s*sema_init.+,\W?0\W?\)/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
6196
6197
6198
  			WARN("CONSIDER_COMPLETION",
  			     "consider using a completion
  " . $herecurr);
773647a09   Andy Whitcroft   update checkpatch...
6199
  		}
6712d8585   Joe Perches   checkpatch: white...
6200

67d0a0754   Joe Perches   kernel.h/checkpat...
6201
6202
  # recommend kstrto* over simple_strto* and strict_strto*
  		if ($line =~ /\b((simple|strict)_(strto(l|ll|ul|ull)))\s*\(/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
6203
  			WARN("CONSIDER_KSTRTO",
67d0a0754   Joe Perches   kernel.h/checkpat...
6204
6205
  			     "$1 is obsolete, use k$3 instead
  " . $herecurr);
773647a09   Andy Whitcroft   update checkpatch...
6206
  		}
6712d8585   Joe Perches   checkpatch: white...
6207

ae3ccc467   Fabian Frederick   scripts/checkpatc...
6208
  # check for __initcall(), use device_initcall() explicitly or more appropriate function please
f3db6639f   Michael Ellerman   checkpatch: add a...
6209
  		if ($line =~ /^.\s*__initcall\s*\(/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
6210
  			WARN("USE_DEVICE_INITCALL",
ae3ccc467   Fabian Frederick   scripts/checkpatc...
6211
6212
  			     "please use device_initcall() or more appropriate function instead of __initcall() (see include/linux/init.h)
  " . $herecurr);
f3db6639f   Michael Ellerman   checkpatch: add a...
6213
  		}
6712d8585   Joe Perches   checkpatch: white...
6214

0f3c5aab5   Joe Perches   checkpatch: add o...
6215
  # check for various structs that are normally const (ops, kgdb, device_tree)
6903ffb22   Andy Whitcroft   checkpatch: struc...
6216
  		if ($line !~ /\bconst\b/ &&
0f3c5aab5   Joe Perches   checkpatch: add o...
6217
  		    $line =~ /\bstruct\s+($const_structs)\b/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
6218
6219
6220
  			WARN("CONST_STRUCT",
  			     "struct $1 should normally be const
  " .
6903ffb22   Andy Whitcroft   checkpatch: struc...
6221
  				$herecurr);
2b6db5cb6   Andy Whitcroft   checkpatch: struc...
6222
  		}
773647a09   Andy Whitcroft   update checkpatch...
6223
6224
6225
6226
  
  # use of NR_CPUS is usually wrong
  # ignore definitions of NR_CPUS and usage to define arrays as likely right
  		if ($line =~ /\bNR_CPUS\b/ &&
c45dcabd2   Andy Whitcroft   update checkpatch...
6227
6228
  		    $line !~ /^.\s*\s*#\s*if\b.*\bNR_CPUS\b/ &&
  		    $line !~ /^.\s*\s*#\s*define\b.*\bNR_CPUS\b/ &&
171ae1a49   Andy Whitcroft   update checkpatch...
6229
6230
6231
  		    $line !~ /^.\s*$Declare\s.*\[[^\]]*NR_CPUS[^\]]*\]/ &&
  		    $line !~ /\[[^\]]*\.\.\.[^\]]*NR_CPUS[^\]]*\]/ &&
  		    $line !~ /\[[^\]]*NR_CPUS[^\]]*\.\.\.[^\]]*\]/)
773647a09   Andy Whitcroft   update checkpatch...
6232
  		{
000d1cc18   Joe Perches   checkpatch.pl: ad...
6233
6234
6235
  			WARN("NR_CPUS",
  			     "usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc
  " . $herecurr);
773647a09   Andy Whitcroft   update checkpatch...
6236
  		}
9c9ba34ee   Andy Whitcroft   update checkpatch...
6237

52ea85061   Joe Perches   checkpatch: add t...
6238
6239
6240
6241
6242
6243
  # Use of __ARCH_HAS_<FOO> or ARCH_HAVE_<BAR> is wrong.
  		if ($line =~ /\+\s*#\s*define\s+((?:__)?ARCH_(?:HAS|HAVE)\w*)\b/) {
  			ERROR("DEFINE_ARCH_HAS",
  			      "#define of '$1' is wrong - use Kconfig variables or standard guards instead
  " . $herecurr);
  		}
acd9362c2   Joe Perches   checkpatch: add l...
6244
6245
6246
6247
6248
6249
6250
  # likely/unlikely comparisons similar to "(likely(foo) > 0)"
  		if ($^V && $^V ge 5.10.0 &&
  		    $line =~ /\b((?:un)?likely)\s*\(\s*$FuncArg\s*\)\s*$Compare/) {
  			WARN("LIKELY_MISUSE",
  			     "Using $1 should generally have parentheses around the comparison
  " . $herecurr);
  		}
691d77b6b   Andy Whitcroft   checkpatch: add c...
6251
6252
6253
  # whine mightly about in_atomic
  		if ($line =~ /\bin_atomic\s*\(/) {
  			if ($realfile =~ m@^drivers/@) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
6254
6255
6256
  				ERROR("IN_ATOMIC",
  				      "do not use in_atomic in drivers
  " . $herecurr);
f4a877367   Andy Whitcroft   checkpatch: make ...
6257
  			} elsif ($realfile !~ m@^kernel/@) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
6258
6259
6260
  				WARN("IN_ATOMIC",
  				     "use of in_atomic() is incorrect outside core kernel code
  " . $herecurr);
691d77b6b   Andy Whitcroft   checkpatch: add c...
6261
6262
  			}
  		}
1704f47b5   Peter Zijlstra   lockdep: Add nova...
6263

481aea5c5   Joe Perches   checkpatch: whine...
6264
6265
6266
6267
6268
6269
6270
6271
6272
6273
6274
6275
6276
6277
6278
6279
6280
6281
6282
6283
6284
6285
6286
  # whine about ACCESS_ONCE
  		if ($^V && $^V ge 5.10.0 &&
  		    $line =~ /\bACCESS_ONCE\s*$balanced_parens\s*(=(?!=))?\s*($FuncArg)?/) {
  			my $par = $1;
  			my $eq = $2;
  			my $fun = $3;
  			$par =~ s/^\(\s*(.*)\s*\)$/$1/;
  			if (defined($eq)) {
  				if (WARN("PREFER_WRITE_ONCE",
  					 "Prefer WRITE_ONCE(<FOO>, <BAR>) over ACCESS_ONCE(<FOO>) = <BAR>
  " . $herecurr) &&
  				    $fix) {
  					$fixed[$fixlinenr] =~ s/\bACCESS_ONCE\s*\(\s*\Q$par\E\s*\)\s*$eq\s*\Q$fun\E/WRITE_ONCE($par, $fun)/;
  				}
  			} else {
  				if (WARN("PREFER_READ_ONCE",
  					 "Prefer READ_ONCE(<FOO>) over ACCESS_ONCE(<FOO>)
  " . $herecurr) &&
  				    $fix) {
  					$fixed[$fixlinenr] =~ s/\bACCESS_ONCE\s*\(\s*\Q$par\E\s*\)/READ_ONCE($par)/;
  				}
  			}
  		}
1704f47b5   Peter Zijlstra   lockdep: Add nova...
6287
6288
6289
6290
6291
6292
  # check for lockdep_set_novalidate_class
  		if ($line =~ /^.\s*lockdep_set_novalidate_class\s*\(/ ||
  		    $line =~ /__lockdep_no_validate__\s*\)/ ) {
  			if ($realfile !~ m@^kernel/lockdep@ &&
  			    $realfile !~ m@^include/linux/lockdep@ &&
  			    $realfile !~ m@^drivers/base/core@) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
6293
6294
6295
  				ERROR("LOCKDEP",
  				      "lockdep_no_validate class is reserved for device->mutex.
  " . $herecurr);
1704f47b5   Peter Zijlstra   lockdep: Add nova...
6296
6297
  			}
  		}
88f8831c0   Dave Jones   checkpatch: check...
6298

b392c64f5   Joe Perches   checkpatch: match...
6299
6300
  		if ($line =~ /debugfs_create_\w+.*\b$mode_perms_world_writable\b/ ||
  		    $line =~ /DEVICE_ATTR.*\b$mode_perms_world_writable\b/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
6301
6302
6303
  			WARN("EXPORTED_WORLD_WRITABLE",
  			     "Exporting world writable files is usually an error. Consider more restrictive permissions.
  " . $herecurr);
88f8831c0   Dave Jones   checkpatch: check...
6304
  		}
2435880fe   Joe Perches   checkpatch: add c...
6305

515a235ef   Joe Perches   checkpatch: impro...
6306
6307
6308
  # Mode permission misuses where it seems decimal should be octal
  # This uses a shortcut match to avoid unnecessary uses of a slow foreach loop
  		if ($^V && $^V ge 5.10.0 &&
459cf0ae5   Joe Perches   checkpatch: impro...
6309
  		    defined $stat &&
515a235ef   Joe Perches   checkpatch: impro...
6310
6311
6312
6313
  		    $line =~ /$mode_perms_search/) {
  			foreach my $entry (@mode_permission_funcs) {
  				my $func = $entry->[0];
  				my $arg_pos = $entry->[1];
459cf0ae5   Joe Perches   checkpatch: impro...
6314
6315
6316
6317
6318
6319
6320
6321
  				my $lc = $stat =~ tr@
  @@;
  				$lc = $lc + $linenr;
  				my $stat_real = raw_line($linenr, 0);
  				for (my $count = $linenr + 1; $count <= $lc; $count++) {
  					$stat_real = $stat_real . "
  " . raw_line($count, 0);
  				}
515a235ef   Joe Perches   checkpatch: impro...
6322
6323
6324
6325
6326
  				my $skip_args = "";
  				if ($arg_pos > 1) {
  					$arg_pos--;
  					$skip_args = "(?:\\s*$FuncArg\\s*,\\s*){$arg_pos,$arg_pos}";
  				}
f90774e1f   Joe Perches   checkpatch: look ...
6327
  				my $test = "\\b$func\\s*\\(${skip_args}($FuncArg(?:\\|\\s*$FuncArg)*)\\s*[,\\)]";
459cf0ae5   Joe Perches   checkpatch: impro...
6328
  				if ($stat =~ /$test/) {
515a235ef   Joe Perches   checkpatch: impro...
6329
6330
  					my $val = $1;
  					$val = $6 if ($skip_args ne "");
f90774e1f   Joe Perches   checkpatch: look ...
6331
6332
  					if (($val =~ /^$Int$/ && $val !~ /^$Octal$/) ||
  					    ($val =~ /^$Octal$/ && length($val) ne 4)) {
515a235ef   Joe Perches   checkpatch: impro...
6333
  						ERROR("NON_OCTAL_PERMISSIONS",
459cf0ae5   Joe Perches   checkpatch: impro...
6334
6335
6336
  						      "Use 4 digit octal (0777) not decimal permissions
  " . "$here
  " . $stat_real);
f90774e1f   Joe Perches   checkpatch: look ...
6337
6338
  					}
  					if ($val =~ /^$Octal$/ && (oct($val) & 02)) {
c0a5c8985   Joe Perches   checkpatch: impro...
6339
  						ERROR("EXPORTED_WORLD_WRITABLE",
459cf0ae5   Joe Perches   checkpatch: impro...
6340
6341
6342
  						      "Exporting writable files is usually an error. Consider more restrictive permissions.
  " . "$here
  " . $stat_real);
f90774e1f   Joe Perches   checkpatch: look ...
6343
  					}
2435880fe   Joe Perches   checkpatch: add c...
6344
6345
6346
  				}
  			}
  		}
5a6d20ce1   Bjorn Andersson   checkpatch: valid...
6347

459cf0ae5   Joe Perches   checkpatch: impro...
6348
6349
6350
6351
6352
6353
6354
6355
6356
6357
6358
6359
6360
6361
6362
6363
6364
6365
6366
6367
6368
6369
6370
6371
6372
6373
6374
6375
  # check for uses of S_<PERMS> that could be octal for readability
  		if ($line =~ /\b$mode_perms_string_search\b/) {
  			my $val = "";
  			my $oval = "";
  			my $to = 0;
  			my $curpos = 0;
  			my $lastpos = 0;
  			while ($line =~ /\b(($mode_perms_string_search)\b(?:\s*\|\s*)?\s*)/g) {
  				$curpos = pos($line);
  				my $match = $2;
  				my $omatch = $1;
  				last if ($lastpos > 0 && ($curpos - length($omatch) != $lastpos));
  				$lastpos = $curpos;
  				$to |= $mode_permission_string_types{$match};
  				$val .= '\s*\|\s*' if ($val ne "");
  				$val .= $match;
  				$oval .= $omatch;
  			}
  			$oval =~ s/^\s*\|\s*//;
  			$oval =~ s/\s*\|\s*$//;
  			my $octal = sprintf("%04o", $to);
  			if (WARN("SYMBOLIC_PERMS",
  				 "Symbolic permissions '$oval' are not preferred. Consider using octal permissions '$octal'.
  " . $herecurr) &&
  			    $fix) {
  				$fixed[$fixlinenr] =~ s/$val/$octal/;
  			}
  		}
5a6d20ce1   Bjorn Andersson   checkpatch: valid...
6376
6377
6378
6379
6380
6381
6382
6383
6384
6385
6386
6387
6388
6389
6390
6391
6392
6393
  # validate content of MODULE_LICENSE against list from include/linux/module.h
  		if ($line =~ /\bMODULE_LICENSE\s*\(\s*($String)\s*\)/) {
  			my $extracted_string = get_quoted_string($line, $rawline);
  			my $valid_licenses = qr{
  						GPL|
  						GPL\ v2|
  						GPL\ and\ additional\ rights|
  						Dual\ BSD/GPL|
  						Dual\ MIT/GPL|
  						Dual\ MPL/GPL|
  						Proprietary
  					}x;
  			if ($extracted_string !~ /^"(?:$valid_licenses)"$/x) {
  				WARN("MODULE_LICENSE",
  				     "unknown module license " . $extracted_string . "
  " . $herecurr);
  			}
  		}
13214adf7   Andy Whitcroft   update checkpatch...
6394
6395
6396
6397
6398
6399
  	}
  
  	# If we have no input at all, then there is nothing to report on
  	# so just keep quiet.
  	if ($#rawlines == -1) {
  		exit(0);
0a920b5b6   Andy Whitcroft   add a trivial pat...
6400
  	}
8905a67c6   Andy Whitcroft   update checkpatch...
6401
6402
6403
6404
6405
6406
6407
6408
6409
6410
6411
  	# In mailback mode only produce a report in the negative, for
  	# things that appear to be patches.
  	if ($mailback && ($clean == 1 || !$is_patch)) {
  		exit(0);
  	}
  
  	# This is not a patch, and we are are in 'no-patch' mode so
  	# just keep quiet.
  	if (!$chk_patch && !$is_patch) {
  		exit(0);
  	}
06330fc40   Joe Perches   checkpatch: avoid...
6412
  	if (!$is_patch && $file !~ /cover-letter\.patch$/) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
6413
6414
6415
  		ERROR("NOT_UNIFIED_DIFF",
  		      "Does not appear to be a unified-diff format patch
  ");
0a920b5b6   Andy Whitcroft   add a trivial pat...
6416
  	}
ed43c4e58   Allen Hubbe   checkpatch: check...
6417
  	if ($is_patch && $has_commit_log && $chk_signoff && $signoff == 0) {
000d1cc18   Joe Perches   checkpatch.pl: ad...
6418
6419
6420
  		ERROR("MISSING_SIGN_OFF",
  		      "Missing Signed-off-by: line(s)
  ");
0a920b5b6   Andy Whitcroft   add a trivial pat...
6421
  	}
8905a67c6   Andy Whitcroft   update checkpatch...
6422
  	print report_dump();
13214adf7   Andy Whitcroft   update checkpatch...
6423
6424
  	if ($summary && !($clean == 1 && $quiet == 1)) {
  		print "$filename " if ($summary_file);
8905a67c6   Andy Whitcroft   update checkpatch...
6425
6426
6427
6428
  		print "total: $cnt_error errors, $cnt_warn warnings, " .
  			(($check)? "$cnt_chk checks, " : "") .
  			"$cnt_lines lines checked
  ";
f0a594c1c   Andy Whitcroft   update checkpatch...
6429
  	}
8905a67c6   Andy Whitcroft   update checkpatch...
6430

d2c0a2351   Andy Whitcroft   checkpatch: sugge...
6431
  	if ($quiet == 0) {
ef2121963   Joe Perches   checkpatch: adver...
6432
6433
6434
6435
6436
6437
6438
6439
  		# If there were any defects found and not already fixing them
  		if (!$clean and !$fix) {
  			print << "EOM"
  
  NOTE: For some of the reported defects, checkpatch may be able to
        mechanically convert to the typical style using --fix or --fix-inplace.
  EOM
  		}
d2c0a2351   Andy Whitcroft   checkpatch: sugge...
6440
6441
6442
  		# If there were whitespace errors which cleanpatch can fix
  		# then suggest that.
  		if ($rpt_cleaners) {
b0781216e   Mike Frysinger   scripts/checkpatc...
6443
  			$rpt_cleaners = 0;
d8469f162   Joe Perches   checkpatch: impro...
6444
6445
6446
6447
6448
  			print << "EOM"
  
  NOTE: Whitespace errors detected.
        You may wish to use scripts/cleanpatch or scripts/cleanfile
  EOM
d2c0a2351   Andy Whitcroft   checkpatch: sugge...
6449
6450
  		}
  	}
d752fcc88   Joe Perches   checkpatch: add a...
6451
6452
6453
  	if ($clean == 0 && $fix &&
  	    ("@rawlines" ne "@fixed" ||
  	     $#fixed_inserted >= 0 || $#fixed_deleted >= 0)) {
9624b8d65   Joe Perches   checkpatch: add a...
6454
6455
  		my $newfile = $filename;
  		$newfile .= ".EXPERIMENTAL-checkpatch-fixes" if (!$fix_inplace);
3705ce5bc   Joe Perches   checkpatch: creat...
6456
6457
  		my $linecount = 0;
  		my $f;
d752fcc88   Joe Perches   checkpatch: add a...
6458
  		@fixed = fix_inserted_deleted_lines(\@fixed, \@fixed_inserted, \@fixed_deleted);
3705ce5bc   Joe Perches   checkpatch: creat...
6459
6460
6461
6462
6463
6464
6465
6466
  		open($f, '>', $newfile)
  		    or die "$P: Can't open $newfile for write
  ";
  		foreach my $fixed_line (@fixed) {
  			$linecount++;
  			if ($file) {
  				if ($linecount > 3) {
  					$fixed_line =~ s/^\+//;
d752fcc88   Joe Perches   checkpatch: add a...
6467
6468
  					print $f $fixed_line . "
  ";
3705ce5bc   Joe Perches   checkpatch: creat...
6469
6470
6471
6472
6473
6474
6475
6476
6477
6478
  				}
  			} else {
  				print $f $fixed_line . "
  ";
  			}
  		}
  		close($f);
  
  		if (!$quiet) {
  			print << "EOM";
d8469f162   Joe Perches   checkpatch: impro...
6479

3705ce5bc   Joe Perches   checkpatch: creat...
6480
6481
6482
6483
6484
6485
6486
  Wrote EXPERIMENTAL --fix correction(s) to '$newfile'
  
  Do _NOT_ trust the results written to this file.
  Do _NOT_ submit these changes without inspecting them for correctness.
  
  This EXPERIMENTAL file is simply a convenience to help rewrite patches.
  No warranties, expressed or implied...
3705ce5bc   Joe Perches   checkpatch: creat...
6487
6488
6489
  EOM
  		}
  	}
d8469f162   Joe Perches   checkpatch: impro...
6490
6491
6492
6493
6494
6495
6496
6497
6498
6499
  	if ($quiet == 0) {
  		print "
  ";
  		if ($clean == 1) {
  			print "$vname has no obvious style problems and is ready for submission.
  ";
  		} else {
  			print "$vname has style problems, please review.
  ";
  		}
0a920b5b6   Andy Whitcroft   add a trivial pat...
6500
6501
6502
  	}
  	return $clean;
  }