28 Jan, 2008
3 commits
-
The redundant i2c client list maintained by i2c-core is going away
soon, so drivers should stop using it now. Instead, they can use the
standard iterator provided by the device driver model
(device_for_each_child).Signed-off-by: Jean Delvare
Cc: David Brownell
Cc: Michael Hunold -
Use more standard prototypes for i2c_use_client() and
i2c_release_client(). The former now returns a pointer to the client,
and the latter no longer returns anything. This matches what all other
subsystems do.Signed-off-by: Jean Delvare
Cc: David Brownell -
Don't implement our own reference counting mechanism for i2c clients
when the driver model already has one.Signed-off-by: Jean Delvare
Cc: David Brownell
26 Jan, 2008
37 commits
-
isapnp_fmi_probe() is only called by fmi_init(), which is __init,
so isapnp_fmi_probe() can also be __init.media/radio/radio-sf16fmi.c:
WARNING: vmlinux.o(.text+0x994e19): Section mismatch: reference to .init.data: (between 'isapnp_fmi_probe' and 'vidioc_s_tuner')
WARNING: vmlinux.o(.text+0x994e22): Section mismatch: reference to .init.data: (between 'isapnp_fmi_probe' and 'vidioc_s_tuner')
WARNING: vmlinux.o(.text+0x994e3a): Section mismatch: reference to .init.data:id_table (between 'isapnp_fmi_probe' and 'vidioc_s_tuner')Signed-off-by: Randy Dunlap
Acked-by: Sam Ravnborg
Signed-off-by: Mauro Carvalho Chehab -
This patch moves the subsystem ID and subsystem vendor ID check from probing
function to the PCI generic function by describing subsystem IDs in
pci_device_id table. This enables to add new PCI IDs to a device driver pci_ids
table at runtime by new_id file in sysfs pci driver tree.Signed-off-by: Akinobu Mita
Signed-off-by: Manu Abraham
Signed-off-by: Mauro Carvalho Chehab -
Make a local function static
Signed-off-by: Patrick Boettcher
Signed-off-by: Mauro Carvalho Chehab -
Tuning problem for 7Mhz channels fixes
Signed-off-by: Patrick Boettcher
Signed-off-by: Mauro Carvalho Chehab -
Removing two bugs to improve sensitivity for DiB7070 and Dib7000P with MT2266.
Signed-off-by: Patrick Boettcher
Signed-off-by: Mauro Carvalho Chehab -
Here is a patch for Hauppage Nova-T-Stick and Nova-T-500 users. It
sets the MT2060 IF1 frequency according to the calibration values
stored in the EEPROM.It is supposed to enhance the signal quality, but, hey, there is no
guarantee. Feedbacks would be much appreciated, to know whether it
deserves being applied.Signed-off-by: Olivier DANET
Signed-off-by: Patrick Boettcher
Signed-off-by: Mauro Carvalho Chehab -
There was a mistake in the way how to start the streaming in the dib0700. This patch fixes that.
Signed-off-by: Patrick Boettcher
Signed-off-by: Mauro Carvalho Chehab -
The attached patch solves all my vdr tuning problems on a dib7000p
nova-t stick as far as I could check within the last weekend.It disables streaming while tuning, like that the number of faulty TS
packets is reduced.Signed-off-by: Soeren Moch
Signed-off-by: Patrick Boettcher
Signed-off-by: Mauro Carvalho Chehab -
Here's a roll-up which provides support for both this and the myTV.t.
Signed-off-by: Darren Salt
Signed-off-by: Patrick Boettcher
Signed-off-by: Mauro Carvalho Chehab -
Add support for WinTV Nova-T-CE driver
Signed-off-by: Tim Taubert
Signed-off-by: Patrick Boettcher
Signed-off-by: Mauro Carvalho Chehab -
This patch fix autoserach in the Hauppauge NOVA-T 500.
Signed-off-by: Jose Alberto Reguero
Signed-off-by: Patrick Boettcher
Signed-off-by: Mauro Carvalho Chehab -
Adding support for ASUS My Cinema U3000 Mini DVBT Tuner
Signed-off-by: Daniel Gimpelevich
Signed-off-by: Patrick Boettcher
Signed-off-by: Mauro Carvalho Chehab -
Added Artec T14BR support
Signed-off-by: Yousef Lamlum
Signed-off-by: Patrick Boettcher
Signed-off-by: Mauro Carvalho Chehab -
xc5000: Fix OOPS caused by missing firmware.
Signed-off-by: Chaogui Zhang
Acked-by: Steven Toth
Signed-off-by: Mauro Carvalho Chehab -
- avoid poss. locking when doing copy_to_user which may sleep
- RDS is automatically activated on read now
- code cleaned of unnecessary rds_commands
- USB Vendor/Product ID for ADS/Tech FM Radio Receiver verified
(thanks to Guillaume RAMOUSSE)Signed-off-by: Tobias Lorenz
Signed-off-by: Mauro Carvalho Chehab -
- code reordered to avoid function prototypes
- switch/case defaults are now more user-friendly
- unified comment style
- applied all checkpatch.pl v1.12 suggestions
except the warning about the too long lines with bit comments
- renamed FMRADIO to RADIO to cut line length (checkpatch.pl)Signed-off-by: Tobias Lorenz
Signed-off-by: Mauro Carvalho Chehab -
has_tuner flag doesn't make much sense, since tuner_type=TUNER_ABSENT
means the same thing.Having two ways to say that a tuner is not present is
not nice, since it may lead to bad setups. In fact, with the previous
code, if a device were using has_tuner=0, but the user forces a tuner,
with modprobe option tuner=type, the modprobe option won't work.Also, tveeprom returns TUNER_ABSENT, when tuner is unknown or absent.
So, with the previous logic, in this case, the driver should set
has_tuner=0, or has_tuner=1 otherwise.Instead of adding several additional tests and setups, better just to
remove .has_tuner.Signed-off-by: Mauro Carvalho Chehab
-
Previous patches assume the tuner was on a different gpio. This patch
corrects this.Signed-off-by: Steven Toth
Signed-off-by: Chaogui Zhang
Signed-off-by: Mauro Carvalho Chehab -
IR corrections for the Pinnacle 800i
Signed-off-by: Steven Toth
Signed-off-by: Chaogui Zhang
Signed-off-by: Mauro Carvalho Chehab -
We already know that the XC5000 tuner can only be located at
i2c address 0x61, 0x62, 0x63 or 0x64We shouldn't display this warning if the XC5000 tuner is present.
Signed-off-by: Michael Krufky
Signed-off-by: Mauro Carvalho Chehab -
Change TDA9887 to tda9887.
TDA8290 shall reflect the actual hardware present in its name,
ie:tda8295+18271
tda8290+8275aSigned-off-by: Michael Krufky
Signed-off-by: Mauro Carvalho Chehab -
Marcos Melero (marcosmelero at gmail.com) reported he could make
his dvb-t usb stick work with the af9005 driver by changing the device
ids (10b9:6000).The stick is branded "Ansonic" (one of the brands of a spanish chain of
supermarkets) with no other identification of the model.
Since neither Marcos nor me know the OEM for the stick, in the attached
patch I used Ansonic for the ids/description.Signed-off-by: Luca Olivetti
Signed-off-by: Mauro Carvalho Chehab -
Call analog_ops.standby during tda18271_set_params, to put the tda8295
in tri-state when tuning digital channels. Otherwise the tda8295 will
interfere with the signal coming from the tda18271 into the digital
demodulator.Signed-off-by: Michael Krufky
Signed-off-by: Mauro Carvalho Chehab -
state is already NULL.
Reviewed-by: Trent Piepho
Signed-off-by: Mauro Carvalho Chehab -
Signed-off-by: Michael Krufky
Signed-off-by: Mauro Carvalho Chehab -
Correctly set the atatch structures, enable IR, configure the
xc5000 tuner includes.Signed-off-by: Steven Toth
Signed-off-by: Mauro Carvalho Chehab -
xc5000: Small amount of cleanup and commenting, just for clarification.
Signed-off-by: Steven Toth
Signed-off-by: Mauro Carvalho Chehab -
From Zhang: This patch fixes support for the HVR1500Q which was broken
when the xc5000 analog patch was added.Patch committed as-is, cleanups to follows .... Steve
Signed-off-by: Chaogui Zhang
Signed-off-by: Steven Toth
Signed-off-by: Mauro Carvalho Chehab -
From Zhang: This patch continues the support for the Pinnacle HD 800i.
Patch committed as-is, cleanups to follow ... Steve
Signed-off-by: Chaogui Zhang
Signed-off-by: Steven Toth
Signed-off-by: Mauro Carvalho Chehab -
From Zhang: This an updated patch that adds analog support for
the xc5000 tuner driver. it was tested on a Pinnacle PCTV HD 800i
card (patches to follow).Patch commited as-is, cleanup to follow ... Steve.
Signed-off-by: Chaogui Zhang
Signed-off-by: Steven Toth
Signed-off-by: Mauro Carvalho Chehab -
Parallel support was not working with the s5h1409 and the Pinnacle HD800i.
This patch fixes the demodulator driver and ensures that all existing
s5h1409 based products configure the demodulator correctly.Signed-off-by: Steven Toth
Signed-off-by: Mauro Carvalho Chehab -
The backports weren't tested, but compile fine.
Signed-off-by: Mauro Carvalho Chehab
-
this patch adds a new driver for the Silicon Labs Si470x FM Radio Receiver. It
should also work for the identical ADS/Tech FM Radio Receiver (formerly
Instant FM Music) as soon as I find out the USB Vendor and Product ID.The driver is inspired by several other USB and radio drivers, but mainly from
the D-Link DSB-R100 USB radio (dsbr100.c).The USB stick currently has an Si4701 FM RDS radio receiver. But the other
Si470x devices are pin and register compatible, so that in the future the
driver can easily be patched to support these too. Therefore I named the
driver radio-si470x and the configuration option usb-si470x.The driver itself just provides the control function over the radio. For
getting audio back, the device support the USB audio class, which is
implemented in the already existing driver.I tested the driver in the last days, until it now satisfies all my
functionality and robustness requirements. The application I used for testing
was kradio.Signed-off-by: Tobias Lorenz
Signed-off-by: Mauro Carvalho Chehab -
Signed-off-by: Zoltan Devai
Signed-off-by: Mauro Carvalho Chehab -
The file drivers/media/video/videodev.c defines both video_device_alloc and
video_device_release. These are essentially just kzmalloc and kfree,
respectively, but it seems better to use video_device_release, as done in
the other media files, rather than kfree, in case the implementation some
day changes.The problem was found using the following semantic match.
(http://www.emn.fr/x-info/coccinelle/)//
@@
type T,T1,T2;
identifier E;
statement S;
expression x1,x2,x3;
int ret;
@@T E;
...
* E = video_device_alloc(...);
if (E == NULL) S
... when != video_device_release(...,(T1)E,...)
when != if (E != NULL) { ... video_device_release(...,(T1)E,...); ...}
when != x1 = (T1)E
when != E = x3;
when any
if (...) {
... when != video_device_release(...,(T2)E,...)
when != if (E != NULL) { ... video_device_release(...,(T2)E,...); ...}
when != x2 = (T2)E
(
* return;
|
* return ret;
)
}
//Signed-off-by: Julia Lawall
Signed-off-by: Mauro Carvalho Chehab -
Video_device_alloc returns the result of a kzalloc. In this case, the
value is stored in a local variable which is not copied elsewhere before
the point of the error return (video_register_device does not save its
first argument anywhere if it returns a negative value). Thus, a
video_device_release it needed before the error return.The problem was found using the following semantic match.
(http://www.emn.fr/x-info/coccinelle/)//
@@
type T,T1,T2;
identifier E;
statement S;
expression x1,x2,x3;
int ret;
@@T E;
...
* E = video_device_alloc(...);
if (E == NULL) S
... when != video_device_release(...,(T1)E,...)
when != if (E != NULL) { ... video_device_release(...,(T1)E,...); ...}
when != x1 = (T1)E
when != E = x3;
when any
if (...) {
... when != video_device_release(...,(T2)E,...)
when != if (E != NULL) { ... video_device_release(...,(T2)E,...); ...}
when != x2 = (T2)E
(
* return;
|
* return ret;
)
}
//Signed-off-by: Julia Lawall
Signed-off-by: Andrew Morton
CC: Oliver Endriss
CC: Michael Hunold
Signed-off-by: Mauro Carvalho Chehab -
This module option variable is only handled within the file tda18271-fe.c -
Declare this variable as static.
Signed-off-by: Michael Krufky
Signed-off-by: Mauro Carvalho Chehab
