Eric Lee / smarc-fsl-linux-kernel

08 Sep, 2016

1 commit

02 Sep, 2016

1 commit

  • 6769e988b   ALSA: constify snd_pcm_ops structures ... Browse Code »

    Check for snd_pcm_ops structures that are only stored in the ops field of a
    snd_soc_platform_driver structure or passed as the third argument to
    snd_pcm_set_ops. The corresponding field or parameter is declared const,
    so snd_pcm_ops structures that have this property can be declared as const
    also.

    The semantic patch that makes this change is as follows:
    (http://coccinelle.lip6.fr/)

    //
    @r disable optional_qualifier@
    identifier i;
    position p;
    @@
    static struct snd_pcm_ops i@p = { ... };

    @ok1@
    identifier r.i;
    struct snd_soc_platform_driver e;
    position p;
    @@
    e.ops = &i@p;

    @ok2@
    identifier r.i;
    expression e1, e2;
    position p;
    @@
    snd_pcm_set_ops(e1, e2, &i@p)

    @bad@
    position p != {r.p,ok1.p,ok2.p};
    identifier r.i;
    struct snd_pcm_ops e;
    @@
    e@i@p

    @depends on !bad disable optional_qualifier@
    identifier r.i;
    @@
    static
    +const
    struct snd_pcm_ops i = { ... };
    //

    Signed-off-by: Julia Lawall
    Signed-off-by: Takashi Iwai

    Julia Lawall
     

30 Nov, 2015

1 commit

29 May, 2015

1 commit

16 Apr, 2015

1 commit

  • 412b979cc   ALSA: remove deprecated use of pci api ... Browse Code »

    Replace occurences of the pci api by appropriate call to the dma api.

    A simplified version of the semantic patch that finds this problem is as
    follows: (http://coccinelle.lip6.fr)

    @deprecated@
    idexpression id;
    position p;
    @@

    (
    pci_dma_supported@p ( id, ...)
    |
    pci_alloc_consistent@p ( id, ...)
    )

    @bad1@
    idexpression id;
    position deprecated.p;
    @@
    ...when != &id->dev
    when != pci_get_drvdata ( id )
    when != pci_enable_device ( id )
    (
    pci_dma_supported@p ( id, ...)
    |
    pci_alloc_consistent@p ( id, ...)
    )

    @depends on !bad1@
    idexpression id;
    expression direction;
    position deprecated.p;
    @@

    (
    - pci_dma_supported@p ( id,
    + dma_supported ( &id->dev,
    ...
    + , GFP_ATOMIC
    )
    |
    - pci_alloc_consistent@p ( id,
    + dma_alloc_coherent ( &id->dev,
    ...
    + , GFP_ATOMIC
    )
    )

    Signed-off-by: Quentin Lambert
    Signed-off-by: Takashi Iwai

    Quentin Lambert
     

18 Mar, 2015

6 commits

29 Jan, 2015

2 commits

28 Jan, 2015

1 commit

12 Jan, 2015

1 commit

11 Jan, 2015

1 commit

09 Jan, 2015

2 commits

  • 889425035   ALSA: ice1724: Simplify PM callbacks ... Browse Code »

    This is a similar cleanup like the commit [3db084fd0af5: ALSA: fm801:
    PCI core handles power state for us].

    Since pci_set_power_state(), pci_save_state() and pci_restore_state()
    are already done in the PCI core side, so we don't need to it doubly.

    Also, pci_enable_device(), pci_disable_device() and pci_set_master()
    calls in PM callbacks are superfluous nowadays, too, so get rid of
    them as well.

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     
  • b60dc62f5   ALSA: ice1712: Simplify PM callbacks ... Browse Code »

    This is a similar cleanup like the commit [3db084fd0af5: ALSA: fm801:
    PCI core handles power state for us].

    Since pci_set_power_state(), pci_save_state() and pci_restore_state()
    are already done in the PCI core side, so we don't need to it doubly.

    Also, pci_enable_device(), pci_disable_device() and pci_set_master()
    calls in PM callbacks are superfluous nowadays, too, so get rid of
    them as well.

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     

02 Jan, 2015

1 commit

  • 08a4c10b5   ALSA: ice1712: Remove always NULL parameters ... Browse Code »

    The various PCM allocation functions in this driver take a pointer to a
    pointer of a PCM where if this parameter is provided the newly allocated PCM
    is stored. All callers pass NULL though, so remove the parameter. This makes
    the code a bit cleaner and shorter.

    Signed-off-by: Lars-Peter Clausen
    Signed-off-by: Takashi Iwai

    Lars-Peter Clausen
     

26 Dec, 2014

1 commit

17 Nov, 2014

1 commit

14 Nov, 2014

3 commits

  • b8eca77e5   ALSA: ice1712: consider error value ... Browse Code »

    earlier we were ignoring the return value of snd_ak4114_create and
    always returning 0.
    now we are returning the actual status. revo_init is calling this
    function, and revo_init is checking the return value.

    Signed-off-by: Sudip Mukherjee
    Signed-off-by: Takashi Iwai

    Sudip Mukherjee
     
  • b393df014   ALSA: ice1712: remove unused variable ... Browse Code »

    buf_size was initialized with snd_pcm_lib_buffer_bytes,
    but never used. and so it is safe to be deleted.

    Signed-off-by: Sudip Mukherjee
    Signed-off-by: Takashi Iwai

    Sudip Mukherjee
     
  • 387417b56   ALSA: ice1712: remove unneeded return statement ... Browse Code »

    the functions:
    snd_ice1712_akm4xxx_build_controls
    snd_ice1712_build_pro_mixer
    snd_ctl_add
    snd_ak4114_build
    prodigy192_ak4114_init
    snd_ak4113_build
    are all returning either 0 or a negetive error value.
    so we can easily remove the check for a negative value and return
    the value instead.

    Signed-off-by: Sudip Mukherjee
    Signed-off-by: Takashi Iwai

    Sudip Mukherjee
     

21 Oct, 2014

2 commits

27 Aug, 2014

1 commit

13 Aug, 2014

1 commit

  • 9baa3c34a   PCI: Remove DEFINE_PCI_DEVICE_TABLE macro use ... Browse Code »

    We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to
    meet kernel coding style guidelines. This issue was reported by checkpatch.

    A simplified version of the semantic patch that makes this change is as
    follows (http://coccinelle.lip6.fr/):

    //

    @@
    identifier i;
    declarer name DEFINE_PCI_DEVICE_TABLE;
    initializer z;
    @@

    - DEFINE_PCI_DEVICE_TABLE(i)
    + const struct pci_device_id i[]
    = z;

    //

    [bhelgaas: add semantic patch]
    Signed-off-by: Benoit Taine
    Signed-off-by: Bjorn Helgaas

    Benoit Taine
     

04 Jul, 2014

1 commit

08 Apr, 2014

1 commit

  • 4f8e94009   ALSA: ice1712: Fix boundary checks in PCM pointer ops ... Browse Code »

    PCM pointer callbacks in ice1712 driver check the buffer size boundary
    wrongly between bytes and frames. This leads to PCM core warnings
    like:
    snd_pcm_update_hw_ptr0: 105 callbacks suppressed
    ALSA pcm_lib.c:352 BUG: pcmC3D0c:0, pos = 5461, buffer size = 5461, period size = 2730

    This patch fixes these checks to be placed after the proper unit
    conversions.

    Cc:
    Signed-off-by: Takashi Iwai

    Takashi Iwai
     

04 Apr, 2014

2 commits

03 Apr, 2014

1 commit

31 Mar, 2014

2 commits

26 Feb, 2014

1 commit

12 Feb, 2014

1 commit

07 Nov, 2013

1 commit

29 Oct, 2013

2 commits