Eric Lee / smarc-fsl-linux-kernel

25 Mar, 2008

1 commit

  • 2875fb65f   mtd: memory corruption in block2mtd.c ... Browse Code »

    The block2mtd driver (drivers/mtd/devices/block2mtd.c) will kfree an on-stack
    pointer when handling an invalid argument line (e.g.
    block2mtd=/dev/loop0,xxx).

    The kfree was added some time ago when "name" was dynamically allocated.

    Signed-off-by: Ingo van Lil
    Acked-by: Joern Engel
    Cc: David Woodhouse
    Cc:
    Cc: Andrew Morton
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ingo van Lil
     

08 Feb, 2008

1 commit

  • a8e98d6d5   Merge git://git.infradead.org/mtd-2.6 ... Browse Code »

    * git://git.infradead.org/mtd-2.6: (120 commits)
    [MTD] Fix mtdoops.c compilation
    [MTD] [NOR] fix startup lock when using multiple nor flash chips
    [MTD] [DOC200x] eccbuf is statically defined and always evaluate to true
    [MTD] Fix maps/physmap.c compilation with CONFIG_PM
    [MTD] onenand: Add panic_write function to the onenand driver
    [MTD] mtdoops: Use the panic_write function when present
    [MTD] Add mtd panic_write function pointer
    [MTD] [NAND] Freescale enhanced Local Bus Controller FCM NAND support.
    [MTD] physmap.c: Add support for multiple resources
    [MTD] [NAND] Fix misparenthesization introduced by commit 78b65179...
    [MTD] [NAND] Fix Blackfin NFC ECC calculating bug with page size 512 bytes
    [MTD] [NAND] Remove wrong operation in PM function of the BF54x NFC driver
    [MTD] [NAND] Remove unused variable in plat_nand_remove
    [MTD] Unlocking all Intel flash that is locked on power up.
    [MTD] [NAND] at91_nand: Make mtdparts option can override board info
    [MTD] mtdoops: Various minor cleanups
    [MTD] mtdoops: Ensure sequential write to the buffer
    [MTD] mtdoops: Perform write operations in a workqueue
    [MTD] mtdoops: Add further error return code checking
    [MTD] [NOR] Test devtype, not definition in flash_probe(), drivers/mtd/devices/lart.c
    ...

    Linus Torvalds
     

07 Feb, 2008

2 commits

03 Feb, 2008

2 commits

28 Nov, 2007

1 commit

  • cccb45d4b   [MTD] mtd_dataflash: Incorrect compare-after-write check ... Browse Code »

    After writing to a Dataflash page, the built-in compare operation is
    used to check that the page was successfully written. A logic bug in
    checking the results of the comparison currently causes the compare to
    never fail.

    This bug was originally in the legacy at91_dataflash.c driver.

    Signed-off-by: Andrew Victor
    Acked-by: David Brownell
    Signed-off-by: David Woodhouse

    Andrew Victor
     

04 Aug, 2007

1 commit

  • 471f717a4   Revert "[MTD] Driver for AT26Fxxx dataflash devices" ... Browse Code »

    This reverts commit 340ea370c2ce89d1c15fbf785460f2f74314ce58.

    It's not needed given the other m25p80 patch (which now handles
    at26 "dataflash" as well as most other standard SPI flash chips),
    and requires a controller driver that won't be merged upstream
    (supplanted by drivers/spi/atmel_spi.c) ... the submitter of
    that at91_dataflash26.c driver concurred.

    Requested by David Brownell
    Signed-off-by: David Woodhouse

    David Woodhouse
     

01 Aug, 2007

2 commits

11 Jul, 2007

3 commits

29 Jun, 2007

6 commits

01 Jun, 2007

1 commit

  • 632155e65   potential parse error in ifdef ... Browse Code »

    I have made a tool to parse the kernel that does not pre-process the
    source. That means that my parser tries to parse all the code, including
    code in the #else branch or code that is not often compiled because the
    driver is not very used (or not used at all). So, my parser sometimes
    reports parse error not originally detected by gcc. Here is my (first)
    patch.

    [akpm@linux-foundation.org: fix amd8111e.c]
    Signed-off-by: Yoann Padioleau
    Acked-by: Matthew Wilcox
    Acked-by: Wim Van Sebroeck
    Acked-by: David Woodhouse
    Acked-by: Jeff Garzik
    Acked-by: James Bottomley
    Cc: Russell King
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Yoann Padioleau
     

10 May, 2007

1 commit

  • ba7cc09c9   Merge git://git.infradead.org/mtd-2.6 ... Browse Code »

    * git://git.infradead.org/mtd-2.6: (21 commits)
    [MTD] [CHIPS] Remove MTD_OBSOLETE_CHIPS (jedec, amd_flash, sharp)
    [MTD] Delete allegedly obsolete "bank_size" field of mtd_info.
    [MTD] Remove unnecessary user space check from mtd.h.
    [MTD] [MAPS] Remove flash maps for no longer supported 405LP boards
    [MTD] [MAPS] Fix missing printk() parameter in physmap_of.c MTD driver
    [MTD] [NAND] platform NAND driver: add driver
    [MTD] [NAND] platform NAND driver: update header
    [JFFS2] Simplify and clean up jffs2_add_tn_to_tree() some more.
    [JFFS2] Remove another bogus optimisation in jffs2_add_tn_to_tree()
    [JFFS2] Remove broken insert_point optimisation in jffs2_add_tn_to_tree()
    [JFFS2] Remember to calculate overlap on nodes which replace older nodes
    [JFFS2] Don't advance c->wbuf_ofs to next eraseblock after wbuf flush
    [MTD] [NAND] at91_nand.c: CMDLINE_PARTS support
    [MTD] [NAND] Tidy up handling of page number in nand_block_bad()
    [MTD] block2mtd_paramline[] mustn't be __initdata
    [MTD] [NAND] Support multiple chips in CAFÉ driver
    [MTD] [NAND] Rename cafe.c to cafe_nand.c and remove the multi-obj magic
    [MTD] [NAND] Use rslib for CAFÉ ECC
    [RSLIB] Support non-canonical GF representations
    [JFFS2] Remove dead file histo_mips.h
    ...

    Linus Torvalds
     

08 May, 2007

1 commit

  • 6fe6900e1   mm: make read_cache_page synchronous ... Browse Code »

    Ensure pages are uptodate after returning from read_cache_page, which allows
    us to cut out most of the filesystem-internal PageUptodate calls.

    I didn't have a great look down the call chains, but this appears to fixes 7
    possible use-before uptodate in hfs, 2 in hfsplus, 1 in jfs, a few in
    ecryptfs, 1 in jffs2, and a possible cleared data overwritten with readpage in
    block2mtd. All depending on whether the filler is async and/or can return
    with a !uptodate page.

    Signed-off-by: Nick Piggin
    Cc: Hugh Dickins
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Nick Piggin
     

07 May, 2007

1 commit

  • 15700770e   Merge git://git.kernel.org/pub/scm/linux/kernel/git/sam/kbuild ... Browse Code »

    * git://git.kernel.org/pub/scm/linux/kernel/git/sam/kbuild: (38 commits)
    kconfig: fix mconf segmentation fault
    kbuild: enable use of code from a different dir
    kconfig: error out if recursive dependencies are found
    kbuild: scripts/basic/fixdep segfault on pathological string-o-death
    kconfig: correct minor typo in Kconfig warning message.
    kconfig: fix path to modules.txt in Kconfig help
    usr/Kconfig: fix typo
    kernel-doc: alphabetically-sorted entries in index.html of 'htmldocs'
    kbuild: be more explicit on missing .config file
    kbuild: clarify the creation of the LOCALVERSION_AUTO string.
    kbuild: propagate errors from find in scripts/gen_initramfs_list.sh
    kconfig: refer to qt3 if we cannot find qt libraries
    kbuild: handle compressed cpio initramfs-es
    kbuild: ignore section mismatch warning for references from .paravirtprobe to .init.text
    kbuild: remove stale comment in modpost.c
    kbuild/mkuboot.sh: allow spaces in CROSS_COMPILE
    kbuild: fix make mrproper for Documentation/DocBook/man
    kbuild: remove kconfig binaries during make mrproper
    kconfig/menuconfig: do not hardcode '.config'
    kbuild: override build timestamp & version
    ...

    Linus Torvalds
     

03 May, 2007

2 commits

  • 6473d160b   PCI: Cleanup the includes of <linux/pci.h> ... Browse Code »

    I noticed that many source files include while they do
    not appear to need it. Here is an attempt to clean it all up.

    In order to find all possibly affected files, I searched for all
    files including but without any other occurence of "pci"
    or "PCI". I removed the include statement from all of these, then I
    compiled an allmodconfig kernel on both i386 and x86_64 and fixed the
    false positives manually.

    My tests covered 66% of the affected files, so there could be false
    positives remaining. Untested files are:

    arch/alpha/kernel/err_common.c
    arch/alpha/kernel/err_ev6.c
    arch/alpha/kernel/err_ev7.c
    arch/ia64/sn/kernel/huberror.c
    arch/ia64/sn/kernel/xpnet.c
    arch/m68knommu/kernel/dma.c
    arch/mips/lib/iomap.c
    arch/powerpc/platforms/pseries/ras.c
    arch/ppc/8260_io/enet.c
    arch/ppc/8260_io/fcc_enet.c
    arch/ppc/8xx_io/enet.c
    arch/ppc/syslib/ppc4xx_sgdma.c
    arch/sh64/mach-cayman/iomap.c
    arch/xtensa/kernel/xtensa_ksyms.c
    arch/xtensa/platform-iss/setup.c
    drivers/i2c/busses/i2c-at91.c
    drivers/i2c/busses/i2c-mpc.c
    drivers/media/video/saa711x.c
    drivers/misc/hdpuftrs/hdpu_cpustate.c
    drivers/misc/hdpuftrs/hdpu_nexus.c
    drivers/net/au1000_eth.c
    drivers/net/fec_8xx/fec_main.c
    drivers/net/fec_8xx/fec_mii.c
    drivers/net/fs_enet/fs_enet-main.c
    drivers/net/fs_enet/mac-fcc.c
    drivers/net/fs_enet/mac-fec.c
    drivers/net/fs_enet/mac-scc.c
    drivers/net/fs_enet/mii-bitbang.c
    drivers/net/fs_enet/mii-fec.c
    drivers/net/ibm_emac/ibm_emac_core.c
    drivers/net/lasi_82596.c
    drivers/parisc/hppb.c
    drivers/sbus/sbus.c
    drivers/video/g364fb.c
    drivers/video/platinumfb.c
    drivers/video/stifb.c
    drivers/video/valkyriefb.c
    include/asm-arm/arch-ixp4xx/dma.h
    sound/oss/au1550_ac97.c

    I would welcome test reports for these files. I am fine with removing
    the untested files from the patch if the general opinion is that these
    changes aren't safe. The tested part would still be nice to have.

    Note that this patch depends on another header fixup patch I submitted
    to LKML yesterday:
    [PATCH] scatterlist.h needs types.h
    http://lkml.org/lkml/2007/3/01/141

    Signed-off-by: Jean Delvare
    Cc: Badari Pulavarty
    Signed-off-by: Greg Kroah-Hartman

    Jean Delvare
     
  • 39f5fb303   kconfig: fix path to modules.txt in Kconfig help ... Browse Code »

    Documentation/modules.txt doesn't exist, but
    Documentation/kbuild/modules.txt does.

    Signed-off-by: Alexander E. Patrakov
    Signed-off-by: Sam Ravnborg

    Alexander E. Patrakov
     

02 May, 2007

1 commit

20 Apr, 2007

1 commit

  • ec98c681a   Use menuconfig objects: MTD ... Browse Code »

    Use menuconfigs instead of menus, so the whole menu can be disabled at once
    instead of going through all options.

    Signed-off-by: Jan Engelhardt
    Signed-off-by: Andrew Morton
    Signed-off-by: David Woodhouse

    Jan Engelhardt
     

18 Apr, 2007

1 commit

  • 340ea370c   [MTD] Driver for AT26Fxxx dataflash devices ... Browse Code »

    Add support for AT26Fxxx dataflash devices. These devices have a quite different
    commandset than the AT45xxx chips, which are handled by at91_dataflash.c, so a
    combined driver turned out to be more ugly than useful.

    Tested only on AT26F004.

    Signed-off-by: Hans-Jürgen Koch
    Signed-off-by: Thomas Gleixner
    Signed-off-by: David Woodhouse

    Hans-Jürgen Koch
     

21 Feb, 2007

3 commits

  • 21d31f1f7   [PATCH] [MTD] block2mtd: remove readahead code ... Browse Code »

    Over the years there was a slow trickle of complaints against the readahead
    code. Most of them concerned performance, Peter Zijlstra stumbled over it
    when working unrelated changes and I believe there was an actual bug report.
    Oh, Andrew Morton also complained about duplicating code from mm/readahead.c.

    It is just not worth it. On flash media like usb sticks, readahead will
    make things go slow - very slow. On spinning disks, readahead may be a
    win, but this is definitely not the place to add it.

    Signed-off-by: Jörn Engel

    Joern Engel
     
  • 8870530a4   [PATCH] [MTD] block2mtd: remove warning ... Browse Code »

    drivers/mtd/devices/block2mtd.c:311:9: warning: symbol 'dev' shadows an earlier one
    drivers/mtd/devices/block2mtd.c:294:23: originally declared here

    Signed-off-by: Jörn Engel

    Joern Engel
     
  • 0ffb74ccc   [PATCH] [MTD] block2mtd: remove casts ... Browse Code »

    Remove two casts - they were not only pointless, but outright harmful.

    Spotted by Felix Fietkau

    Signed-off-by: Jörn Engel

    Joern Engel
     

20 Feb, 2007

1 commit

  • 493536176   Merge git://git.infradead.org/mtd-2.6 ... Browse Code »

    * git://git.infradead.org/mtd-2.6: (49 commits)
    [MTD] [NAND] S3C2412 fix hw ecc
    [MTD] [NAND] Work around false compiler warning in CAFÉ driver
    [JFFS2] printk warning fixes
    [MTD] [MAPS] ichxrom warning fix
    [MTD] [MAPS] amd76xrom warning fix
    [MTD] [MAPS] esb2rom warning fixes
    [MTD] [MAPS] ck804xrom warning fix
    [MTD] [MAPS] netsc520 warning fix
    [MTD] [MAPS] sc520cdp warning fix
    [MTD] [ONENAND] onenand_base warning fix
    [MTD] [NAND] eXcite nand flash driver
    [MTD] Improve heuristic for detecting wrong-endian RedBoot partition table
    [MTD] Fix RedBoot partition parsing regression harder.
    [MTD] [NAND] S3C2410: Hardware ECC correction code
    [JFFS2] Use MTD_OOB_AUTO to automatically place cleanmarker on NAND
    [MTD] Clarify OOB-operation interface comments
    [MTD] remove unused ecctype,eccsize fields from struct mtd_info
    [MTD] [NOR] Intel: remove ugly PROGREGION macros
    [MTD] [NOR] STAA: use writesize instead off eccsize to represent ECC block
    [MTD] OneNAND: Invalidate bufferRAM after erase
    ...

    Linus Torvalds
     

15 Feb, 2007

1 commit

  • cd354f1ae   [PATCH] remove many unneeded #includes of sched.h ... Browse Code »

    After Al Viro (finally) succeeded in removing the sched.h #include in module.h
    recently, it makes sense again to remove other superfluous sched.h includes.
    There are quite a lot of files which include it but don't actually need
    anything defined in there. Presumably these includes were once needed for
    macros that used to live in sched.h, but moved to other header files in the
    course of cleaning it up.

    To ease the pain, this time I did not fiddle with any header files and only
    removed #includes from .c-files, which tend to cause less trouble.

    Compile tested against 2.6.20-rc2 and 2.6.20-rc2-mm2 (with offsets) on alpha,
    arm, i386, ia64, mips, powerpc, and x86_64 with allnoconfig, defconfig,
    allmodconfig, and allyesconfig as well as a few randconfigs on x86_64 and all
    configs in arch/arm/configs on arm. I also checked that no new warnings were
    introduced by the patch (actually, some warnings are removed that were emitted
    by unnecessarily included header files).

    Signed-off-by: Tim Schmielau
    Acked-by: Russell King
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tim Schmielau
     

12 Feb, 2007

1 commit

09 Feb, 2007

1 commit

  • 64f607105   [MTD] remove unused ecctype,eccsize fields from struct mtd_info ... Browse Code »

    Remove unused and broken mtd->ecctype and mtd->eccsize fields
    from struct mtd_info. Do not remove them from userspace API
    data structures (don't want to breake userspace) but mark them
    as obsolete by a comment. Any userspace program which uses them
    should be half-broken anyway, so this is more about saving
    data structure size.

    Signed-off-by: Artem Bityutskiy
    Signed-off-by: David Woodhouse

    Artem Bityutskiy
     

18 Jan, 2007

1 commit

31 Dec, 2006

2 commits

14 Dec, 2006

1 commit

  • 5cbded585   [PATCH] getting rid of all casts of k[cmz]alloc() calls ... Browse Code »

    Run this:

    #!/bin/sh
    for f in $(grep -Erl "\([^\)]*\) *k[cmz]alloc" *) ; do
    echo "De-casting $f..."
    perl -pi -e "s/ ?= ?\([^\)]*\) *(k[cmz]alloc) *\(/ = \1\(/" $f
    done

    And then go through and reinstate those cases where code is casting pointers
    to non-pointers.

    And then drop a few hunks which conflicted with outstanding work.

    Cc: Russell King , Ian Molton
    Cc: Mikael Starvik
    Cc: Yoshinori Sato
    Cc: Roman Zippel
    Cc: Geert Uytterhoeven
    Cc: Ralf Baechle
    Cc: Paul Mackerras
    Cc: Kyle McMartin
    Cc: Benjamin Herrenschmidt
    Cc: Martin Schwidefsky
    Cc: "David S. Miller"
    Cc: Jeff Dike
    Cc: Greg KH
    Cc: Jens Axboe
    Cc: Paul Fulghum
    Cc: Alan Cox
    Cc: Karsten Keil
    Cc: Mauro Carvalho Chehab
    Cc: Jeff Garzik
    Cc: James Bottomley
    Cc: Ian Kent
    Cc: Steven French
    Cc: David Woodhouse
    Cc: Neil Brown
    Cc: Jaroslav Kysela
    Cc: Takashi Iwai
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Robert P. J. Day
     

08 Dec, 2006

1 commit