31 Mar, 2011

1 commit


15 Mar, 2011

1 commit


03 Feb, 2011

1 commit


25 Jan, 2011

1 commit


22 Jan, 2011

1 commit


21 Jan, 2011

1 commit

  • The original code called input_free_device(rmi4_data->input_dev) after
    input_unregister_device(rmi4_data->input_dev) and that's a double free.
    This is described in the comments to input_unregister_device().

    The normal way to handle this is to make input_register_device() the
    last function in the probe which can fail. That way you can avoid the
    call to input_unregister_device() entirely.

    Signed-off-by: Dan Carpenter
    Signed-off-by: Greg Kroah-Hartman

    Dan Carpenter
     

17 Nov, 2010

1 commit

  • The synaptics_i2c_rmi4 driver uses input_*() interfaces,
    so it should depend on INPUT to fix its build errors:

    ERROR: "input_event" [drivers/staging/ste_rmi4/synaptics_i2c_rmi4.ko] undefined!
    ERROR: "input_free_device" [drivers/staging/ste_rmi4/synaptics_i2c_rmi4.ko] undefined!
    ERROR: "input_register_device" [drivers/staging/ste_rmi4/synaptics_i2c_rmi4.ko] undefined!
    ERROR: "input_set_abs_params" [drivers/staging/ste_rmi4/synaptics_i2c_rmi4.ko] undefined!
    ERROR: "input_allocate_device" [drivers/staging/ste_rmi4/synaptics_i2c_rmi4.ko] undefined!
    ERROR: "input_unregister_device" [drivers/staging/ste_rmi4/synaptics_i2c_rmi4.ko] undefined!

    Signed-off-by: Randy Dunlap
    Cc: naveen.gaddipati@stericsson.com, js.ha@stericsson.com
    Signed-off-by: Greg Kroah-Hartman

    Randy Dunlap
     

10 Nov, 2010

1 commit