09 Nov, 2015
6 commits
-
resource_size_t may be 32-bit wide on some architectures, which causes
this warning when building the NTB code:drivers/ntb/ntb_transport.c: In function 'ntb_transport_link_work':
drivers/ntb/ntb_transport.c:828:46: warning: right shift count >= width of type [-Wshift-count-overflow]The warning is harmless but can be avoided by using the upper_32_bits()
macro.Signed-off-by: Arnd Bergmann
Fixes: e26a5843f7f5 ("NTB: Split ntb_hw_intel and ntb_transport drivers")
Signed-off-by: Jon Mason -
There is no need for the upstream and downstream addresses to be different
for the NTB configs. Go to using a single set of address. It is still
possible to configure them differently using module parameter override
however.Signed-off-by: Dave Jiang
Acked and Tested-by: Allen Hubbe
Signed-off-by: Jon Mason -
Order of operations issue with the QP Num and MW count, which would
result in the receive buffer pointer being invalid if there are more
than 1 MW. Corrected with parenthesis to enforce the proper order of
operations.Reported-by: John I. Kading
Signed-off-by: Jon Mason -
These variables were not used anywhere. So remove them.
Signed-off-by: Sudip Mukherjee
Signed-off-by: Jon Mason -
We were accessing nt->mw_vec after freeing it. Fix the error path so
that we free nt->mw_vec after we have finished using it.Signed-off-by: Sudip Mukherjee
Signed-off-by: Jon Mason -
smatch detected an issue in the function ntb_transport_max_size() where
we could be dereferencing a dma channel pointer when it is NULL.Reported-by: Dan Carpenter
Signed-off-by: Dave Jiang
Signed-off-by: Jon Mason
08 Sep, 2015
8 commits
-
The range check must exclude the upper bound.
Signed-off-by: Allen Hubbe
Signed-off-by: Jon Mason -
Check that b2b_mw_idx is in range of the number of memory windows when
initializing the device. The workaround is considered to be in effect
only if the device b2b_idx is exactly UINT_MAX, instead of any index
past the last memory window.Only print B2B MW workaround information in debugfs if the workaround is
in effect.Signed-off-by: Allen Hubbe
Signed-off-by: Jon Mason -
Allocate two DMA channels, one for TX operation and one for RX
operation, instead of having one DMA channel for everything. This
provides slightly better performance, and also will make error handling
cleaner later on.Signed-off-by: Dave Jiang
Signed-off-by: Jon Mason -
The dma_sync_wait can hurt the performance of workloads mixed with both
large and small frames. Large frames will be copied using the dma
engine. Small frames will be copied by the cpu. The dma_sync_wait
prevents the cpu and dma engine copying in parallel.In the period where the cpu is copying, the dma engine is stopped. The
dma engine is not doing any useful work to copy large frames during that
time, and the additional time to restart the dma engine for the next
large frame. This will decrease the throughput for the portion of a
workload with large frames.In the period where the dma engine is copying, the cpu is held up
waiting for dma to complete. The small frames processing will be
delayed until the dma is complete. The RX frames are completed
in-order, and the processing of small frames takes very little time, so
dma_sync_wait may have an insignificant impact on the respose time of
frames. The more significant impact is to the system, because the delay
in dma_sync_wait is implemented as busy non-blocking wait. This can
prevent the delayed core from doing any useful work, even if it could be
processing work for other drivers, unrelated to transport RX processing.After applying the earlier patch to fix out-of-order RX acknoledgement,
the dma_sync_wait is no longer necessary. Remove it, so that cpu memcpy
will proceed immediately for small frames, in parallel with ongoing dma
for large frames. Do not hold up the cpu from doing work while dma is
in progress. The prior fix will continue to ensure in-order completion
of the RX frames to the upper layer, and in-order delivery of the RX
acknoledgement.Signed-off-by: Allen Hubbe
Signed-off-by: Jon Mason -
Make QP stats info more readable for debugging purposes. Also add an
entry to indicate whether DMA is being used.Signed-off-by: Dave Jiang
Signed-off-by: Jon Mason -
The list should be added from the bottom and not the top in order to
ensure the transport is provided in the same order to clients as ntb
devices are discovered.Signed-off-by: Dave Jiang
Signed-off-by: Jon Mason -
Adding PCI Device IDs for B2B (back to back), RP (root port, primary),
and TB (transparent bridge, secondary) devices.Signed-off-by: Dave Jiang
Signed-off-by: Jon Mason -
Right now if we push the NTB really hard, we start dropping packets due
to not able to process the packets fast enough. We need to st:qop the
upper layer from flooding us when that happens.A timer is necessary in order to restart the queue once the resource has
been processed on the receive side. Due to the way NTB is setup, the
resources on the tx side are tied to the processing of the rx side and
there's no async way to know when the rx side has released those
resources.Signed-off-by: Dave Jiang
Signed-off-by: Jon Mason
10 Aug, 2015
7 commits
-
Avoid any chance of format string expansion when calling dev_set_name.
Signed-off-by: Kees Cook
Signed-off-by: Jon Mason -
Remove early dereference of a pointer that is checked later in the code.
Reported-by: Dan Carpenter
Signed-off-by: Allen Hubbe
Signed-off-by: Jon Mason -
A plain 32 bit integer will overflow for values over 4GiB.
Change the plain integer size to the appropriate size type in
ntb_set_mw. Change the type of the size parameter and two local
variables used for size.Even if there is no overflow, a size of zero is invalid here.
Reported-by: Juyoung Jung
Signed-off-by: Allen Hubbe
Signed-off-by: Jon Mason -
Schedule to receive on QP link up, to make sure that the doorbell is
properly cleared for interrupts.Signed-off-by: Allen Hubbe
Signed-off-by: Jon Mason -
When the remote side is not up, we do not have all the context for the
transport, and that causes NULL ptr access. Have the debugfs reads check
to see if transport is up before we make access.Signed-off-by: Dave Jiang
Signed-off-by: Jon Mason -
Currently the debugfs does not have files for all NTB transport queue
pairs. When there are multiple NTBs present in a system, the QP names
of the last transport clobber the names of previously added transport
QPs. Only the last added QPs can be observed via debugfs.Create a directory per NTB transport to associate the QPs with that
transport. Name the directory the same as the PCI device.Signed-off-by: Dave Jiang
Signed-off-by: Jon Mason -
It was possible for a synchronous update of the RX index in the error
case to get ahead of the asynchronous RX index update in the normal
case. Change the RX processing to preserve an RX completion order.There were two error cases. First, if a buffer is not present to
receive data, there would be no queue entry to preserve the RX
completion order. Instead of dropping the RX frame, leave the RX frame
in the ring. Schedule RX processing when RX entries are enqueued, in
case there are RX frames waiting in the ring to be received.Second, if a buffer is too small to receive data, drop the frame in the
ring, mark the RX entry as done, and indicate the error in the RX entry
length. Check for a negative length in the receive callback in
ntb_netdev, and count occurrences as rx_length_errors.Signed-off-by: Allen Hubbe
Signed-off-by: Jon Mason
05 Jul, 2015
19 commits
-
When split BAR is enabled, the driver needs to dump out the split BAR
registers rather than the original 64bit BAR registers.Signed-off-by: Dave Jiang
Signed-off-by: Jon Mason -
The unsafe doorbell and scratchpad access should display reason when
WARN is called. Otherwise we get a stack dump without any explanation.Signed-off-by: Dave Jiang
Signed-off-by: Jon Mason -
Printouts driver name and version to indicate what is being loaded.
Signed-off-by: Dave Jiang
Signed-off-by: Jon Mason -
Benchmarking showed a significant performance increase with the MTU size
to 64k instead of 16k. Change the driver default to 64k.Signed-off-by: Dave Jiang
Signed-off-by: Jon Mason -
Instead of using the platform code names, use the correct platform names
to identify the respective Intel NTB hardware.Signed-off-by: Dave Jiang
Signed-off-by: Jon Mason -
Disable DMA usage by default, since the CPU provides much better
performance with write combining. Provide a module parameter to enable
DMA usage when offloading the memcpy is preferred.Signed-off-by: Dave Jiang
Signed-off-by: Allen Hubbe
Signed-off-by: Jon Mason -
Changing the memory window BAR mappings to write combining significantly
boosts the performance. We will also use memcpy that uses non-temporal
store, which showed performance improvement when doing non-cached
memcpys.Signed-off-by: Dave Jiang
Signed-off-by: Jon Mason -
Allocate memory for the NUMA node of the NTB device.
Signed-off-by: Allen Hubbe
Signed-off-by: Jon Mason -
Allocate memory and request the DMA channel for the same NUMA node as
the NTB device.Signed-off-by: Allen Hubbe
Signed-off-by: Jon Mason -
When the ntb transport is connecting and waiting for the peer, the debug
console receives lots of debug level messages about the remote qp link
status being down. Rate limit those messages.Signed-off-by: Allen Hubbe
Signed-off-by: Jon Mason -
This is a simple debugging driver that enables the doorbell and
scratch pad registers to be read and written from the debugfs. This
tool enables more complicated debugging to be scripted from user space.
This driver may be used to test that your ntb hardware and drivers are
functioning at a basic level.Signed-off-by: Allen Hubbe
Signed-off-by: Jon Mason -
This is a simple ping pong driver that exercises the scratch pads and
doorbells of the ntb hardware. This driver may be used to test that
your ntb hardware and drivers are functioning at a basic level.Signed-off-by: Allen Hubbe
Signed-off-by: Jon Mason -
Add module parameters for the addresses to be used in B2B topology.
Signed-off-by: Allen Hubbe
Signed-off-by: Jon Mason -
Reset the link stats when the link goes down. In particular, the TX and
RX index and count must be reset, or else the TX side will be sending
packets to the RX side where the RX side is not expecting them. Reset
all the stats, to be consistent.Signed-off-by: Allen Hubbe
Signed-off-by: Jon Mason -
On link down, don't advance RX index to the next entry. The next entry
should never be valid after receiving the link down flag.Signed-off-by: Allen Hubbe
Signed-off-by: Jon Mason -
The same message "qp %d: Link Down\n" was printed at two locations in
ntb_transport. Change the messages so they are distinct.Signed-off-by: Allen Hubbe
Signed-off-by: Jon Mason -
Set errata flags for the specific device IDs to which they apply,
instead of the whole Xeon hardware class.Signed-off-by: Dave Jiang
Signed-off-by: Jon Mason -
Link training should be enabled in the driver probe for root port mode.
We should not have to wait for transport to be loaded for this to
happen. Otherwise the ntb device will not show up on the transparent
bridge side of the link.Signed-off-by: Dave Jiang
Signed-off-by: Jon Mason -
The transport was writing and then reading the peer scratch pad,
essentially reading what it just wrote instead of exchanging any
information with the peer. The transport expects the peer values to be
the same as the local values, so this issue was not obvious.Signed-off-by: Dave Jiang
Signed-off-by: Jon Mason