06 Jul, 2010

1 commit


14 May, 2010

1 commit

  • This patch removes from drivers/net/ all the unnecessary
    return; statements that precede the last closing brace of
    void functions.

    It does not remove the returns that are immediately
    preceded by a label as gcc doesn't like that.

    It also does not remove null void functions with return.

    Done via:
    $ grep -rP --include=*.[ch] -l "return;\n}" net/ | \
    xargs perl -i -e 'local $/ ; while (<>) { s/\n[ \t\n]+return;\n}/\n}/g; print; }'

    with some cleanups by hand.

    Compile tested x86 allmodconfig only.

    Signed-off-by: Joe Perches
    Signed-off-by: David S. Miller

    Joe Perches
     

17 Mar, 2010

1 commit

  • This patch fixes following warning introduced by commit
    12bac0d9f4dbf3445a0319beee848d15fa32775e ("proc: warn on non-existing
    proc entries"):

    WARNING: at /work/mips-linux/make/linux/fs/proc/generic.c:316 __xlate_proc_name+0xe0/0xe8()
    name 'RBHMA4X00/RTL8019'

    Signed-off-by: Atsushi Nemoto
    Signed-off-by: David S. Miller

    Atsushi Nemoto
     

09 Jul, 2009

1 commit

  • Commit 5fd29d6ccbc98884569d6f3105aeca70858b3e0f ("printk: clean up
    handling of log-levels and newlines") changed printk semantics. printk
    lines with multiple KERN_ prefixes are no longer emitted as
    before the patch.

    is now included in the output on each additional use.

    Remove all uses of multiple KERN_s in formats.

    Signed-off-by: Joe Perches
    Signed-off-by: Linus Torvalds

    Joe Perches
     

26 Dec, 2008

1 commit


26 Nov, 2008

1 commit


28 Oct, 2008

1 commit

  • This converts pretty much everything to print_mac. There were
    a few things that had conflicts which I have just dropped for
    now, no harm done.

    I've built an allyesconfig with this and looked at the files
    that weren't built very carefully, but it's a huge patch.

    Signed-off-by: Johannes Berg
    Signed-off-by: David S. Miller

    Johannes Berg
     

25 Sep, 2008

2 commits

  • Removing the module would cause a kernel oops as platform_driver_probe
    failed to detect a device and unregistered the platform driver on module
    init, and cleanup_module would unregister the already unregistered driver.
    The suspend and resume functions weren't being called.

    platform_driver support was added earlier, but without any
    platform_device_register* calls I don't think it was being used. Now all
    devices are registered using platform_device_register_simple and pointers
    are kept to unregister the ones that the probe failed for or unregister
    all devices on module shutdown. init_module no longer calls ne_init to
    reduce confusion (and multiple unregister paths that caused the rmmod
    oops). With the devices now registered they are added to the platform
    driver and get suspend and resume events.

    netif_device_detach(dev) was added before unregister_netdev(dev) when
    removing the region as occationally I would see a race condition where the
    device was still being used in unregister_netdev.

    Signed-off-by: David Fries
    Cc: Atsushi Nemoto
    Cc: Paul Gortmaker
    Cc: Alan Cox
    Cc: Jeff Garzik
    Signed-off-by: Andrew Morton
    Signed-off-by: Jeff Garzik

    David Fries
     
  • A call to pnp_stop_dev and pnp_start_dev now shuts down and
    initializes plug and play devices for suspend and resume.

    Signed-off-by: David Fries
    Cc: Atsushi Nemoto
    Cc: Paul Gortmaker
    Cc: Alan Cox
    Cc: Jeff Garzik
    Signed-off-by: Jeff Garzik

    David Fries
     

14 Aug, 2008

1 commit


31 Jul, 2008

1 commit

  • Trying to build with CONFIG_NE2000=m fails with:

    scripts/mod/modpost -o /tmp/tmp/linux-2.6.27-rc1/Module.symvers -S -s
    ERROR: "NS8390_init" [drivers/net/ne.ko] undefined!

    This is because the split of 8390 into pausing and non-pausing
    versions was incompletely propagated to ne.c. This fixes it.

    Signed-off-by: Mikael Pettersson
    Signed-off-by: Jeff Garzik

    Mikael Pettersson
     

23 Jul, 2008

1 commit

  • various drivers were using the wrong APIs:

    drivers/built-in.o: In function `hp_probe1':
    hp.c:(.init.text+0xa280): undefined reference to `NS8390_init'

    fixed via:

    cd drivers/net/; sed -i 's/NS8390_/NS8390p_/g' \
    $(grep -l NS8390_ $(grep 8390p.o Makefile | cut -d' ' -f3 | \
    sed 's/.o$/.c/g'))

    Signed-off-by: Ingo Molnar
    Signed-off-by: Jeff Garzik

    Ingo Molnar
     

04 Jul, 2008

1 commit

  • Only a few ISA controllers need the pausing version of the 8390 core
    while PCMCIA, later ISA and PCI do not. More importantly the ISA delays
    can break non ISA boxes so we must use a different build of 8390.c for
    the two sets of controllers.

    No changes since last time as all the points of concerns raised proved to
    be invalid

    Signed-off-by: Alan Cox
    Signed-off-by: Randy Dunlap
    Signed-off-by: Andrew Morton
    Signed-off-by: Jeff Garzik

    Alan Cox
     

11 Oct, 2007

3 commits


08 May, 2007

4 commits


05 Dec, 2006

1 commit


14 Sep, 2006

1 commit


12 Jun, 2006

1 commit

  • On Sat, 10 Jun 2006 14:11:42 +0200 (MEST) Mikael Pettersson wrote:

    > While compiling 2.6.17-rc6 for a 486 with an NE2000 ISA ethernet card, I got:
    >
    > WARNING: drivers/net/ne.o - Section mismatch: reference to .init.data:isapnp_clone_list from .text between 'init_module' (at offset 0x158) and 'ne_block_input'
    > WARNING: drivers/net/ne.o - Section mismatch: reference to .init.data:isapnp_clone_list from .text between 'init_module' (at offset 0x176) and 'ne_block_input'
    > WARNING: drivers/net/ne.o - Section mismatch: reference to .init.data:isapnp_clone_list from .text between 'init_module' (at offset 0x183) and 'ne_block_input'
    > WARNING: drivers/net/ne.o - Section mismatch: reference to .init.data:isapnp_clone_list from .text between 'init_module' (at offset 0x1ea) and 'ne_block_input'
    > WARNING: drivers/net/ne.o - Section mismatch: reference to .init.data:isapnp_clone_list from .text between 'init_module' (at offset 0x251) and 'ne_block_input'
    > WARNING: drivers/net/ne.o - Section mismatch: reference to .init.text: from .text between 'init_module' (at offset 0x266) and 'ne_block_input'
    > WARNING: drivers/net/ne.o - Section mismatch: reference to .init.text: from .text between 'init_module' (at offset 0x29b) and 'ne_block_input'
    >
    > Not sure how serious this is; the driver seems to work fine later on.

    Doesn't look serious. init_module() is not __init, but it calls
    some __init functions and touches some __initdata.

    BTW, I would be happy to see some consistent results from modpost
    section checking. I don't see all of these warnings (I see only 1)
    when using gcc 3.3.6. What gcc version are you using?
    Does that matter? (not directed at anyone in particular)

    Patch below fixes it for me. Please test/report.

    Signed-off-by: Jeff Garzik

    Randy.Dunlap
     

09 May, 2006

1 commit

  • Ensure that 8-bit mode is selected for the on-board Realtek RTL8019AS chip
    on Toshiba RBHMA4x00, get rid of the duplicate #ifdef's when setting
    ei_status.word16.
    The chip's datasheet says that the PSTOP register shouldn't exceed 0x60 in
    8-bit mode -- ensure this too.

    Signed-off-by: Sergei Shtylyov
    Signed-off-by: Stephen Hemminger

    Sergei Shtylyov
     

21 Apr, 2006

1 commit


17 Jan, 2006

1 commit


09 Jan, 2006

1 commit

  • These warnings are emitted if non-modular network drivers are built.
    Fixes just move cleanup_card() definitions into #ifdef MODULE region.

    /.1/usr/srcdevel/kernel/linux-2.6.15-rc7.src/drivers/net/wd.c:131: warning: 'cleanup_card' defined but not used
    /.1/usr/srcdevel/kernel/linux-2.6.15-rc7.src/drivers/net/3c503.c:152: warning: 'cleanup_card' defined but not used
    /.1/usr/srcdevel/kernel/linux-2.6.15-rc7.src/drivers/net/ne.c:216: warning: 'cleanup_card' defined but not used
    /.1/usr/srcdevel/kernel/linux-2.6.15-rc7.src/drivers/net/hp.c:106: warning: 'cleanup_card' defined but not used
    /.1/usr/srcdevel/kernel/linux-2.6.15-rc7.src/drivers/net/hp-plus.c:142: warning: 'cleanup_card' defined but not used
    /.1/usr/srcdevel/kernel/linux-2.6.15-rc7.src/drivers/net/smc-ultra.c:172: warning: 'cleanup_card' defined but not used
    /.1/usr/srcdevel/kernel/linux-2.6.15-rc7.src/drivers/net/e2100.c:144: warning: 'cleanup_card' defined but not used
    /.1/usr/srcdevel/kernel/linux-2.6.15-rc7.src/drivers/net/es3210.c:159: warning: 'cleanup_card' defined but not used
    /.1/usr/srcdevel/kernel/linux-2.6.15-rc7.src/drivers/net/lne390.c:149: warning: 'cleanup_card' defined but not used
    /.1/usr/srcdevel/kernel/linux-2.6.15-rc7.src/drivers/net/lance.c:313: warning: 'cleanup_card' defined but not used
    /.1/usr/srcdevel/kernel/linux-2.6.15-rc7.src/drivers/net/ac3200.c:127: warning: 'cleanup_card' defined but not used

    Signed-off-by: Andrew Morton
    Signed-off-by: Jeff Garzik

    Denis Vlasenko
     

19 Oct, 2005

1 commit


28 Jul, 2005

1 commit


13 May, 2005

1 commit


17 Apr, 2005

1 commit

  • Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds