10 Jul, 2014
26 commits
-
Get rid of the repeating &dev->dev constructs and prevent introducing
new ones.Signed-off-by: Andre Heider
Signed-off-by: Greg Kroah-Hartman -
The request for an IRQ handler must be done after whole configuration. This
was not the case for this driver which request the IRQ in the middle of
the configuration. Sometimes, it happens that something is not completely
configured, we recieve an interrupt thus we stumble into troubles in the
IRQ handler.Signed-off-by: Federico Vaga
Acked-by: Samuel Iglesias Gonsalvez
Signed-off-by: Greg Kroah-Hartman -
In some conditions (echo or particular sequence of special
characters), on buffer push, the tty layer calls the write operation
while we are holding the spinlock. This means deadlock within the same
process on kernels version < 3.12. It seems not a problem on recent
kernel, but the patch still valid as locking optimization.The protected variables by the spinlock are: xmit_buf, nb_bytes,
pointer_read and pointer_write. So, this patch reduces the locked area
in the IRQ handler only to these variables. Most of the code inside the
locked area in the IRQ handler is not protected elsewhere; it means
that it is not protected at all.Signed-off-by: Federico Vaga
Acked-by: Samuel Iglesias Gonsalvez
Signed-off-by: Greg Kroah-Hartman -
This function should be returning an ERR_PTR() on failure instead of
NULL. Also there is a use after free bug if regmap_init() fails because
we free "func" and then dereference doing the return.Signed-off-by: Dan Carpenter
Acked-by: Pawel Moll
Signed-off-by: Greg Kroah-Hartman -
Return -ENOMEM instead of success if ioremap() fails.
Signed-off-by: Dan Carpenter
Reviewed-by: Jingoo Han
Signed-off-by: Greg Kroah-Hartman -
This makes sure a format string cannot accidentally leak into a device name.
Signed-off-by: Kees Cook
Signed-off-by: Greg Kroah-Hartman -
Both systems need non-standard parameters for fan multiplier
and maximum fan speed.Signed-off-by: Guenter Roeck
Cc: Andreas Mohr
Signed-off-by: Greg Kroah-Hartman -
Some Dell laptops support fan speeds of {0, 1, 2, 3} instead of {0, 1, 2}.
Add a define for it.Signed-off-by: Guenter Roeck
Cc: Andreas Mohr
Signed-off-by: Greg Kroah-Hartman -
Newer Dell systems provide more granular fan speed selection.
Add support for it.Signed-off-by: Guenter Roeck
Cc: Andreas Mohr
Signed-off-by: Greg Kroah-Hartman -
Labels are known to be wrong for several Dell laptops.
For example, a single fan may be shown as right fan when in reality
it sits on the left side of the chassis. Drop all labels to avoid
such inaccuracies. Users can select labels in the sensors configuration
file instead if desired.Signed-off-by: Guenter Roeck
Cc: Andreas Mohr
Signed-off-by: Greg Kroah-Hartman -
The CA91CX42_DCTL_VDW_M define is cut and pasted twice so we can delete
the second instance.Signed-off-by: Dan Carpenter
Signed-off-by: Greg Kroah-Hartman -
commit dabd14684bc2 "PCMCIA: sa1111: remove duplicated initializers"
incorrectly moved some code into the pcmcia_jornada720_init, causing
a few build errors, and for unknown reasons, the driver lacks
an inclusion of , so we get the build errors, and more:sa1111_jornada720.c: In function 'pcmcia_jornada720_init':
sa1111_jornada720.c:101:3: error: implicit declaration of function 'IOMEM' [-Werror=implicit-function-declaration]
GRER |= 0x00000002;
^
sa1111_jornada720.c:104:3: warning: passing argument 1 of 'sa1111_set_io_dir' from incompatible pointer type [enabled by default]
sa1111_set_io_dir(dev, pin, 0, 0);
^This patch uses the SA1111_DEV() to convert the dev pointer to the
correct type before passing it and adds the missing include.Signed-off-by: Arnd Bergmann
Cc: Russell King
Cc: Kristoffer Ericson
Cc: linux-pcmcia@lists.infradead.org
Signed-off-by: Greg Kroah-Hartman -
The lubbock platform uses the sa1111 companion chip with a pxa250
CPU, which means it requires both the PCMCIA_SA1111 and the
PCMCIA_PXA2XX code to be built into the kernel. Unfortunately,
the Makefile and Kconfig don't agree on how this is accomplished,
leading to a situation where you get this link error when building
a lubbock kernel with PCMCIA_SA1111 enabled but PCMCIA_PXA2XX
disabled:ERROR: "pxa2xx_configure_sockets" [drivers/pcmcia/sa1111_cs.ko] undefined!
ERROR: "pxa2xx_drv_pcmcia_ops" [drivers/pcmcia/sa1111_cs.ko] undefined!
ERROR: "pxa2xx_drv_pcmcia_add_one" [drivers/pcmcia/sa1111_cs.ko] undefined!This patch changes the Kconfig code to disallow that particular
configuration.Signed-off-by: Arnd Bergmann
Signed-off-by: Greg Kroah-Hartman -
When building a iPAQ H3100-only kernel with PCMCIA enabled,
we get this build error:ERROR: "pcmcia_h3600_init" [drivers/pcmcia/sa1100_cs.ko] undefined!
The defconfig normally works fine because it enables both H3100
and H3600 support. This patch fixes the Makefile to build the
driver if at least one of the two machines are selected.Signed-off-by: Arnd Bergmann
Signed-off-by: Greg Kroah-Hartman -
All its callers depends on the return value of -ENOBUFS to reallocate a
bigger buffer and retry the receiving. So there's no need to call
pr_err() here since it was not a real issue, otherwise syslog will be
flooded by this false warning.Cc: Haiyang Zhang
Signed-off-by: Jason Wang
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Greg Kroah-Hartman -
hv_fcopy_daemon fails to overwrite a file if the target file already
exits.Add O_TRUNC flag on opening.
Signed-off-by: Yue Zhang
Signed-off-by: Greg Kroah-Hartman -
This starts to address
https://bugzilla.kernel.org/show_bug.cgi?id=10770Signed-off-by: Terry Chia
Signed-off-by: Greg Kroah-Hartman -
replace IS_ERR/PTR_ERR
Cc: Grant Likely
Cc: Rob Herring
Cc: Greg Kroah-Hartman
Signed-off-by: Fabian Frederick
Signed-off-by: Greg Kroah-Hartman -
Add WPT second mei interface.
Signed-off-by: Alexander Usyskin
Signed-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
Add sysfs attributes Documentation entries
for /sys/class/meiSigned-off-by: Tomas Winkler
Signed-off-by: Alexander Usyskin
Signed-off-by: Greg Kroah-Hartman -
We need to support more then one mei interface
hence the simple misc devices is not longer an optionIn order not break the user space a device with pci function 0
need to be linked to /dev/meiSigned-off-by: Alexander Usyskin
Signed-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
GenWQE used to call pci_enable_msi_block to allocate a desired number
of MSI's. If that was not possible pci_enable_msi_block returned with a
smaller number which might be possible to allocate. GenWQE then called
pci_enable_msi_block with that number.Since commit a30d0108b
"GenWQE: Use pci_enable_msi_exact() instead of pci_enable_msi_block()"
pci_enable_msi_exact is used which fails if the desired number of MSI's
was not possible to allocate. Change GenWQE to use pci_enable_msi_range
to restore the old behavior.Signed-off-by: Sebastian Ott
Reviewed-by: Alexander Gordeev
Signed-off-by: Greg Kroah-Hartman -
Increase genwqe driver version number.
Signed-off-by: Kleber Sacilotto de Souza
Acked-by: Frank Haverkamp
Signed-off-by: Greg Kroah-Hartman -
Currently, in the event of a fatal hardware error, the driver tries a
recovery procedure that calls pci_reset_function() to reset the card.
This is not sufficient in some cases, needing a fundamental reset to
bring the card back.This patch implements a call to the platform fundamental reset procedure
on the error recovery path if GENWQE_PLATFORM_ERROR_RECOVERY is enabled.
This is implemented by default only on PPC64, since this can cause
problems on other archs, e.g. zSeries, where the platform has its own
recovery procedures, leading to a potencial race conditition. For these
cases, the recovery is kept as it was before.Signed-off-by: Kleber Sacilotto de Souza
Acked-by: Frank Haverkamp
Signed-off-by: Greg Kroah-Hartman -
This patch implements the callbacks and functions necessary to have EEH
recovery support.It adds a config option to enable or disable explicit calls to trigger
platform specific mechanisms on error recovery paths. This option is
enabled by default only on PPC64 systems and can be overritten via
debugfs. If this option is enabled, on the error recovery path the
driver will call pci_channel_offline() to check for error condition and
issue non-raw MMIO reads to trigger early EEH detection in case of
hardware failures. This is necessary since the driver MMIO helper
funtions use raw accessors.Signed-off-by: Kleber Sacilotto de Souza
Acked-by: Frank Haverkamp
Signed-off-by: Greg Kroah-Hartman -
This patch adds an interface on sysfs for userspace to request a card
bitstream reload. It sets the appropriate register and try to perform a
fundamental reset on the PCIe slot for the card to reload the bitstream
from the chosen partition.Signed-off-by: Kleber Sacilotto de Souza
Acked-by: Frank Haverkamp
Signed-off-by: Greg Kroah-Hartman
08 Jul, 2014
1 commit
-
nhi->rx_rings does not have type as struct tb_ring *, as it is a
double pointer so the elements of the array should have pointer type,
not structure type.The Coccinelle semantic patch that makes this change is as follows:
//
@disable sizeof_type_expr@
type T;
T **x;
@@x =
//Signed-off-by: Himangi Saraogi
Acked-by: Julia Lawall
Cc: Andreas Noever
Signed-off-by: Greg Kroah-Hartman
24 Jun, 2014
1 commit
-
commit 94859308a21b "w1: new w1_ds2406 driver" added a new driver
that uses the crc16 library, but didn't ensure that the core is
there. This adds the necessary Kconfig statements, just like we
have it for other w1 drivers.Reported-by: kbuild test robot
Signed-off-by: Arnd Bergmann
Acked-by: Scott Alfter
Cc: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman
22 Jun, 2014
1 commit
-
We use __crc32c_le in ctl.c. So make sure that the dependency is there.
Reported-by: kbuild test robot
Signed-off-by: Andreas Noever
Signed-off-by: Greg Kroah-Hartman
21 Jun, 2014
11 commits
-
tb_eeprom_get_drom_offset is local to this file.
Signed-off-by: Andreas Noever
Signed-off-by: Greg Kroah-Hartman -
Force enum tb_drom_entry_type to unsigned to fix the following error:
drivers/thunderbolt/eeprom.c:202:39: error: dubious one-bit signed bitfield
Signed-off-by: Andreas Noever
Signed-off-by: Greg Kroah-Hartman -
tb_find_cap in cap.c takes an enum tb_cap and not an u32. Fix the
declaration in tb.h.Signed-off-by: Andreas Noever
Signed-off-by: Greg Kroah-Hartman -
Thunderbolt packets are big endian. Cast pkg->buffer to __be32* when
accessing the checksum.Reported-by: kbuild test robot
Signed-off-by: Andreas Noever
Signed-off-by: Greg Kroah-Hartman -
The result of "sizeof(struct tb_drom_entry_port)" is a size_t, which
is not necessarily the same as 'long', so we should use the appropriate
%z format string instead of %l.Signed-off-by: Arnd Bergmann
Acked-by: Andreas Noever
Signed-off-by: Greg Kroah-Hartman -
The thunderbolt drivers cannot be built if CONFIG_PCI is disabled,
better add an explicit Kconfig dependency.
The "default no" line is redundant and can be removed at the same
time.Signed-off-by: Arnd Bergmann
Acked-by: Andreas Noever
Signed-off-by: Greg Kroah-Hartman -
'nhi_ids' is local to this file.
Signed-off-by: Sachin Kamat
Acked-by: Andreas Noever
Signed-off-by: Greg Kroah-Hartman -
'descriptors' is a pointer. Use NULL isntead of 0.
Signed-off-by: Sachin Kamat
Acked-by: Andreas Noever
Signed-off-by: Greg Kroah-Hartman -
The function returns a pointer. Hence return NULL instead of 0.
Signed-off-by: Sachin Kamat
Acked-by: Andreas Noever
Signed-off-by: Greg Kroah-Hartman -
The function returns a pointer. Hence return NULL instead of 0.
Signed-off-by: Sachin Kamat
Acked-by: Andreas Noever
Signed-off-by: Greg Kroah-Hartman -
Fixes the below error:
drivers/thunderbolt/switch.c:347:2: error: implicit declaration of function ‘kzalloc’ [-Werror=implicit-function-declaration]
drivers/thunderbolt/switch.c:381:2: error: implicit declaration of function ‘kcalloc’ [-Werror=implicit-function-declaration]Signed-off-by: Sachin Kamat
Acked-by: Andreas Noever
Signed-off-by: Greg Kroah-Hartman
