Eric Lee / smarc-fsl-linux-kernel

22 Jun, 2010

1 commit

  • ade2d3db2   NET: MIPSsim: Fix modpost warning. ... Browse Code »

    $ make CONFIG_DEBUG_SECTION_MISMATCH=y
    [...]
    WARNING: drivers/net/built-in.o(.data+0x0): Section mismatch in reference from the variable mipsnet_driver to the function .init.text:mipsnet_probe()
    The variable mipsnet_driver references
    the function __init mipsnet_probe()
    If the reference is valid then annotate the
    variable with __init* or __refdata (see linux/init.h) or name the variable:
    *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
    [...]

    Fixed by making mipsnet_probe __devinit.

    Signed-off-by: Ralf Baechle

    drivers/net/mipsnet.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)
    Signed-off-by: David S. Miller

    Ralf Baechle
     

19 Nov, 2009

1 commit

  • a0607fd3a   drivers/net: request_irq - Remove unnecessary leading & from second arg ... Browse Code »

    Not as fancy as coccinelle. Checkpatch errors ignored.
    Compile tested allyesconfig x86, not all files compiled.

    grep -rPl --include=*.[ch] "\brequest_irq\s*\([^,\)]+,\s*\&" drivers/net | while read file ; do \
    perl -i -e 'local $/; while (<>) { s@(\brequest_irq\s*\([^,\)]+,\s*)\&@\1@g ; print ; }' $file ;\
    done

    Signed-off-by: Joe Perches
    Signed-off-by: David S. Miller

    Joe Perches
     

06 Jul, 2009

1 commit

16 Apr, 2009

1 commit

25 Mar, 2009

1 commit

  • 7a192ec33   platform driver: fix incorrect use of 'platform_bus_type' with 'struct device_driver' ... Browse Code »

    This patch fixes the bug reported in
    http://bugzilla.kernel.org/show_bug.cgi?id=11681.

    "Lots of device drivers register a 'struct device_driver' with
    the '.bus' member set to '&platform_bus_type'. This is wrong,
    since the platform_bus functions expect the 'struct device_driver'
    to be wrapped up in a 'struct platform_driver' which provides
    some additional callbacks (like suspend_late, resume_early).
    The effect may be that platform_suspend_late() uses bogus data
    outside the device_driver struct as a pointer pointer to the
    device driver's suspend_late() function or other hard to
    reproduce failures."(Lothar Wassmann)

    Signed-off-by: Ming Lei
    Acked-by: Henrique de Moraes Holschuh
    Acked-by: David Brownell
    Signed-off-by: Greg Kroah-Hartman

    Ming Lei
     

25 Sep, 2008

1 commit

03 Feb, 2008

1 commit

  • c800c5c9d   Fix/Rewrite of the mipsnet driver] ... Browse Code »

    This is Thiemo's patch.

    ----- Forwarded message from Thiemo Seufer -----

    From: Thiemo Seufer
    Date: Sat, 17 Nov 2007 22:29:13 +0000
    To: netdev@vger.kernel.org
    Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
    Subject: [PATCH, REPOST] Fix/Rewrite of the mipsnet driver
    Content-Type: text/plain; charset=us-ascii

    Hello All,

    currently the mipsnet driver fails after transmitting a number of
    packages because SKBs are allocated but never freed. I fixed that
    and coudn't refrain from removing the most egregious warts.

    - mipsnet.h folded into mipsnet.c, as it doesn't provide any
    useful external interface.
    - Free SKB after transmission.
    - Call free_irq in mipsnet_close, to balance the request_irq in
    mipsnet_open.
    - Removed duplicate read of rxDataCount.
    - Some identifiers are now less verbose.
    - Removed dead and/or unnecessarily complex code.
    - Code formatting fixes.

    Tested on Qemu's mipssim emulation, with this patch it can boot a
    Debian NFSroot.

    Thiemo

    Signed-off-by: Thiemo Seufer
    Signed-off-by: Jeff Garzik
    Signed-off-by: David S. Miller

    Ralf Baechle
     

24 Oct, 2007

1 commit

16 Oct, 2007

1 commit

11 Oct, 2007

2 commits

  • 09f75cd7b   [NET] drivers/net: statistics cleanup #1 -- save memory and shrink code ... Browse Code »

    We now have struct net_device_stats embedded in struct net_device,
    and the default ->get_stats() hook does the obvious thing for us.

    Run through drivers/net/* and remove the driver-local storage of
    statistics, and driver-local ->get_stats() hook where applicable.

    This was just the low-hanging fruit in drivers/net; plenty more drivers
    remain to be updated.

    [ Resolved conflicts with napi_struct changes and fix sunqe build
    regression... -DaveM ]

    Signed-off-by: Jeff Garzik
    Signed-off-by: David S. Miller

    Jeff Garzik
     
  • bf1e9a080   Clean up duplicate includes in drivers/net/ ... Browse Code »

    This patch cleans up duplicate includes in
    drivers/net/

    Signed-off-by: Jesper Juhl
    Acked-by: "John W. Linville"
    Signed-off-by: Andrew Morton
    Signed-off-by: Jeff Garzik

    Jesper Juhl
     

21 Jun, 2007

1 commit

28 Apr, 2007

1 commit

26 Apr, 2007

1 commit

15 Feb, 2007

1 commit

  • cd354f1ae   [PATCH] remove many unneeded #includes of sched.h ... Browse Code »

    After Al Viro (finally) succeeded in removing the sched.h #include in module.h
    recently, it makes sense again to remove other superfluous sched.h includes.
    There are quite a lot of files which include it but don't actually need
    anything defined in there. Presumably these includes were once needed for
    macros that used to live in sched.h, but moved to other header files in the
    course of cleaning it up.

    To ease the pain, this time I did not fiddle with any header files and only
    removed #includes from .c-files, which tend to cause less trouble.

    Compile tested against 2.6.20-rc2 and 2.6.20-rc2-mm2 (with offsets) on alpha,
    arm, i386, ia64, mips, powerpc, and x86_64 with allnoconfig, defconfig,
    allmodconfig, and allyesconfig as well as a few randconfigs on x86_64 and all
    configs in arch/arm/configs on arm. I also checked that no new warnings were
    introduced by the patch (actually, some warnings are removed that were emitted
    by unnecessarily included header files).

    Signed-off-by: Tim Schmielau
    Acked-by: Russell King
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tim Schmielau
     

05 Oct, 2006

1 commit

  • 7d12e780e   IRQ: Maintain regs pointer globally rather than passing to IRQ handlers ... Browse Code »

    Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

03 Jul, 2006

1 commit

30 Oct, 2005

1 commit

19 Oct, 2005

1 commit