02 May, 2016
1 commit
-
This commit enables the active pullup (APU bit) by default for
the DS2482 1-Wire master.>From the DS2482 datasheet:
"The APU bit controls whether an active pullup (controlled slew-rate
transistor) or a passive pullup (Rwpu resistor) will be used to drive
a 1-Wire line from low to high. When APU = 0, active pullup is disabled
(resistor mode). Active Pullup should always be selected unless there is
only a single slave on the 1-Wire line."According to the module author, Ben Gardner:
"It doesn't look like active pullup would cause any hurt if there
is only a single slave."
And my tests with multiple and single slaves on 1-Wire bus
confirms that.This active pullup can be manually disabled using the introduced
module parameter:
active_pullup = 0Signed-off-by: Greg Kroah-Hartman
09 Feb, 2016
1 commit
-
hdq_usecount was set to zero after a successful read, so
omap_hdq_put could not properly free resources which leads
e.g. to increasing usecounts in lsmod outputSigned-off-by: Andreas Kemnade
Acked-by: Evgeniy Polyakov
Reviewed-by: Vignesh R
Signed-off-by: Greg Kroah-Hartman
18 Oct, 2015
1 commit
-
Let's stop using legacy platform driver hooks for power management and
switch to using the standard dev_pm_ops-based hooks.Also, instead of guarding PM methods with #ifdef CONFIG_PM annotate them
as __maybe_unused as it provides better compile coverage.Signed-off-by: Dmitry Torokhov
Signed-off-by: Greg Kroah-Hartman
05 Oct, 2015
1 commit
-
This patches makes following changes to omap_hdq driver
- Enable 1-wire mode.
- Implement w1_triplet callback to facilitate search rom
procedure and auto detection of 1-wire slaves.
- Proper enabling and disabling of interrupt.
- Cleanups (formatting and return value checks).HDQ mode remains unchanged.
Signed-off-by: Vignesh R
Cc: Rob Herring
Cc: Pawel Moll
Cc: Mark Rutland
Cc: Ian Campbell
Cc: Kumar Gala
Acked-by: Evgeniy Polyakov
Cc: Jonathan Corbet
CC: Tony Lindgren
Cc: Vignesh R
Cc: NeilBrown
Cc: Fabian Frederick
Signed-off-by: Andrew Morton
Signed-off-by: Greg Kroah-Hartman
02 Sep, 2015
1 commit
-
Pull trivial tree updates from Jiri Kosina:
"The usual stuff from trivial tree for 4.3 (kerneldoc updates, printk()
fixes, Documentation and MAINTAINERS updates)"* 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (28 commits)
MAINTAINERS: update my e-mail address
mod_devicetable: add space before */
scsi: a100u2w: trivial typo in printk
i2c: Fix typo in i2c-bfin-twi.c
treewide: fix typos in comment blocks
Doc: fix trivial typo in SubmittingPatches
proportions: Spelling s/consitent/consistent/
dm: Spelling s/consitent/consistent/
aic7xxx: Fix typo in error message
pcmcia: Fix typo in locking documentation
scsi/arcmsr: Fix typos in error log
drm/nouveau/gr: Fix typo in nv10.c
[SCSI] Fix printk typos in drivers/scsi
staging: comedi: Grammar s/Enable support a/Enable support for a/
Btrfs: Spelling s/consitent/consistent/
README: GTK+ is a acronym
ASoC: omap: Fix typo in config option description
mm: tlb.c: Fix error message
ntfs: super.c: Fix error log
fix typo in Documentation/SubmittingPatches
...
07 Aug, 2015
1 commit
-
This patch fix spelling typo in matrox_w1.c
Signed-off-by: Masanari Iida
Acked-by: Evgeniy Polyakov
Signed-off-by: Jiri Kosina
06 Aug, 2015
2 commits
-
Use module_pci_driver for drivers whose init and exit functions
only register and unregister, respectively.A simplified version of the Coccinelle semantic patch that performs
this transformation is as follows:@a@
identifier f, x;
@@
-static f(...) { return pci_register_driver(&x); }@b depends on a@
identifier e, a.x;
@@
-static e(...) { pci_unregister_driver(&x); }@c depends on a && b@
identifier a.f;
declarer name module_init;
@@
-module_init(f);@d depends on a && b && c@
identifier b.e, a.x;
declarer name module_exit;
declarer name module_pci_driver;
@@
-module_exit(e);
+module_pci_driver(x);Signed-off-by: Vaishali Thakkar
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman -
i2c_driver does not need to set an owner because i2c_register_driver()
will set it.Signed-off-by: Krzysztof Kozlowski
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman
01 Jun, 2015
1 commit
-
Add i2c alias to enable autoloading of the module for device specified
in device-tree.Signed-off-by: Ludek Hlavacek
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman
25 Mar, 2015
1 commit
-
of_device_id is always used as const.
(See driver.of_match_table and open firmware functions)Signed-off-by: Fabian Frederick
Signed-off-by: Greg Kroah-Hartman
15 Dec, 2014
2 commits
-
Pull char/misc driver updates from Greg KH:
"Here's the big char/misc driver update for 3.19-rc1Lots of little things all over the place in different drivers, and a
new subsystem, "coresight" has been added. Full details are in the
shortlog"* tag 'char-misc-3.19-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc: (73 commits)
parport: parport_pc, do not remove parent devices early
spmi: Remove shutdown/suspend/resume kernel-doc
carma-fpga-program: drop videobuf dependency
carma-fpga: drop videobuf dependency
carma-fpga-program.c: fix compile errors
i8k: Fix temperature bug handling in i8k_get_temp()
cxl: Name interrupts in /proc/interrupt
CXL: Return error to PSL if IRQ demultiplexing fails & print clearer warning
coresight-replicator: remove .owner field for driver
coresight: fixed comments in coresight.h
coresight: fix typo in comment in coresight-priv.h
coresight: bindings for coresight drivers
coresight: Adding ABI documentation
w1: support auto-load of w1_bq27000 module.
w1: avoid potential u16 overflow
cn: verify msg->len before making callback
mei: export fw status registers through sysfs
mei: read and print all six FW status registers
mei: txe: add cherrytrail device id
mei: kill cached host and me csr values
... -
Pull driver core update from Greg KH:
"Here's the set of driver core patches for 3.19-rc1.They are dominated by the removal of the .owner field in platform
drivers. They touch a lot of files, but they are "simple" changes,
just removing a line in a structure.Other than that, a few minor driver core and debugfs changes. There
are some ath9k patches coming in through this tree that have been
acked by the wireless maintainers as they relied on the debugfs
changes.Everything has been in linux-next for a while"
* tag 'driver-core-3.19-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core: (324 commits)
Revert "ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries"
fs: debugfs: add forward declaration for struct device type
firmware class: Deletion of an unnecessary check before the function call "vunmap"
firmware loader: fix hung task warning dump
devcoredump: provide a one-way disable function
device: Add dev__once variants
ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries
ath: use seq_file api for ath9k debugfs files
debugfs: add helper function to create device related seq_file
drivers/base: cacheinfo: remove noisy error boot message
Revert "core: platform: add warning if driver has no owner"
drivers: base: support cpu cache information interface to userspace via sysfs
drivers: base: add cpu_device_create to support per-cpu devices
topology: replace custom attribute macros with standard DEVICE_ATTR*
cpumask: factor out show_cpumap into separate helper function
driver core: Fix unbalanced device reference in drivers_probe
driver core: fix race with userland in device_add()
sysfs/kernfs: make read requests on pre-alloc files use the buffer.
sysfs/kernfs: allow attributes to request write buffer be pre-allocated.
fs: sysfs: return EGBIG on write if offset is larger than file size
...
11 Nov, 2014
1 commit
-
This driver has no 'compatible' string and so is not found when
using device-tree.Add one with value to match
hdqw1w: 1w@480b2000 {
device in omap3.dtsi.Signed-off-by: NeilBrown
Acked-by: Evgeniy Polyakov
Signed-off-by: Tony Lindgren
08 Nov, 2014
1 commit
-
Adjust the bulk message timeout to the other ones (1000ms). Otherwise the
following dmesg errors can be seen on a Raspberry Pi:
[ 31.492386] Failed to read 1-wire data from 0x81: err=-110.
[ 31.504168] 0x81: count=-110, status:
[ 31.613404] Failed to read 1-wire data from 0x81: err=-110.
[ 31.621915] 0x81: count=-110, status:
[ 43.260968] Failed to read 1-wire data from 0x81: err=-110.
[ 43.270998] 0x81: count=-110, status:
[ 43.379959] Failed to read 1-wire data from 0x81: err=-110.
[ 43.388854] 0x81: count=-110, status:Signed-off-by: Alexander Stein
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman
20 Oct, 2014
1 commit
-
A platform_driver does not need to set an owner, it will be populated by the
driver core.Signed-off-by: Wolfram Sang
20 Jun, 2014
5 commits
-
This patch replaces all calls to the "printk" function within the "masters"
subdirectory by calls to the appropriate "pr_*" function thus addressing
the following warning generated by the checkpatch script:WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ...
then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...Signed-off-by: Fjodor Schelichow
Signed-off-by: Roman Sommer
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman -
According to the i.MX reference manual, the read/write bit operations
takes from 60 us to 120 us.
This patch optimizes mxc_w1_ds2_touch_bit() function to use proper
value for such delay. Nevertheless, a small margin for the timeout has
been added for the case if clock frequency is inaccurate.Signed-off-by: Alexander Shiyan
Signed-off-by: Greg Kroah-Hartman -
This patch adds a software reset for 1-Wire module at driver startup.
Signed-off-by: Alexander Shiyan
Signed-off-by: Greg Kroah-Hartman -
According to the i.MX reference manual, the reset procedure and
"presence" pulse takes 511 and 512 us, respectively. Measurement for
i.MX27 is about 1100 us. There is no need to wait Reset+Presence
more than this time.
This patch optimizes mxc_w1_ds2_reset_bus() function to use proper
value for delay after w1 bus reset. Nevertheless, a small margin for
the timeout has been added for the case if clock frequency is inaccurate.Signed-off-by: Alexander Shiyan
Signed-off-by: Greg Kroah-Hartman -
W1 reset_bus() should return zero if slave device is present.
This patch fix this issue.Signed-off-by: Alexander Shiyan
Signed-off-by: Greg Kroah-Hartman
01 Mar, 2014
4 commits
-
This helps increasing build testing coverage.
To do this, __raw_{read,write}b() functions was be replaced with
simple {read,write}b() variants.Signed-off-by: Alexander Shiyan
Signed-off-by: Greg Kroah-Hartman -
- Remove old and currently wrong address of the FSF from license
parts of the code.
- Remove unused #include and sort remaining headers alphabetically.
- Remove unised definitions.
- Add definitions for bit-fields.
- Add missing module owner field.Signed-off-by: Alexander Shiyan
Signed-off-by: Greg Kroah-Hartman -
This patch fix mxc_w1_ds2_reset_bus() return value.
According to i.MX reference manual, "presence status" reflected
in the bit 6 of control register.Signed-off-by: Alexander Shiyan
Signed-off-by: Greg Kroah-Hartman -
Configuration for masters and slaves is included only if W1 symbol
enabled, so no reason to check it once more.Signed-off-by: Alexander Shiyan
Signed-off-by: Greg Kroah-Hartman
16 Feb, 2014
1 commit
-
of_get_gpio() might return -EPROBE_DEFER meaning that the driver
providing the gpio isn't ready yet. If that happens for the first gpio
the resulting kernel output without this patch is:w1-gpio somename: Failed to parse DT
platform somename: Driver w1-gpio requests probe deferralThe first message is misleading and so is suppressed with this patch.
Further if determining the gpio to switch the external pullup yields
-EPROBE_DEFER this error should be passed back to the caller instead of
just continuing without pullup.Signed-off-by: Uwe Kleine-König
Signed-off-by: Greg Kroah-Hartman
09 Feb, 2014
1 commit
-
This reverts ds1wm.c from commit d3a8a9dbb903c73a7ec2deae4c9b7d74b6834f4c.
Of the three files changed ds1wm.c ds2490.c and w1_netlink.c, it turns out
ds1wm.c was locking bus_mutex, but inside the loop and I missed it.
Reverting ds1wm.c to the previous version.Reported-by: Dan Carpenter
Signed-off-by: David Fries
Signed-off-by: Greg Kroah-Hartman
08 Feb, 2014
4 commits
-
The bus_mutex needs to be taken to serialize access to a specific bus.
netlink wasn't updated when bus_mutex was added and was calling
without that lock held, and not all of the masters were holding the
bus_mutex in a search. This was causing the ds2490 hardware to stop
responding when both netlink and /sys slaves were executing bus
commands at the same time.Signed-off-by: David Fries
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman -
The hardware search was failing without the COMM_RST flag. Enabled
the flag and rewrote the function to handle more than one buffer of
results and to continuing where the search left off. Remove hardware
search note from the limitations now that it works. The "w1: ds2490
USB setup fixes" change went from 23.16 seconds to about 3 seconds,
this takes the time for the search down to .307346 seconds.Signed-off-by: David Fries
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman -
Calling usb_reset_configuration after usb_set_interface resets the
interface that was just selected, so call reset first.
Using alternative 3 greatly speeds the one wire search.
alt 0 or 1, 10ms int, 23.16 seconds
alt 2 or 3, 1ms int, 2.99 to 3.05 secondsUse usb_interrupt_msg not usb_bulk_msg as it is an interrupt pipe
(bulk worked, it was just technically the wrong call).Signed-off-by: David Fries
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman -
Use a #define for the usb vendor request type, clear the status
byte and use that instead of a magic offset in checking if idle.Signed-off-by: David Fries
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman
24 Jan, 2014
1 commit
-
Strong pullup is emulated by driving pin logic high after write command
when using tri-state push-pull GPIO.Signed-off-by: Evgeny Boger
Cc: Greg KH
Acked-by: David Fries
Acked-by: Evgeniy Polyakov
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
09 Dec, 2013
3 commits
-
Signed-off-by: Alexander Shiyan
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman -
Base frequency should be as close as possible to 1 MHz. This patch
adds warnings when clock is unreliable, according to i.MX datasheet.Signed-off-by: Alexander Shiyan
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman -
Private field "clkdiv" is not used outside "probe", so there are
no reason to keep it in driver.Signed-off-by: Alexander Shiyan
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman
15 Nov, 2013
1 commit
-
Use the wrapper function for retrieving the platform data instead of
accessing dev->platform_data directly. This is a cosmetic change to make
the code simpler and enhance the readability.Signed-off-by: Jingoo Han
Acked-by: Evgeniy Polyakov
Cc: Greg KH
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
13 Nov, 2013
1 commit
-
Use the wrapper function for retrieving the platform data instead of
accessing dev->platform_data directly. This is a cosmetic change to make
the code simpler and enhance the readability.Signed-off-by: Jingoo Han
Acked-by: Evgeniy Polyakov
Cc: Greg KH
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
30 Oct, 2013
2 commits
-
Signed-off-by: Markus Pargmann
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman -
The first DT gpio is necessary for this driver, but errors returned for
of_get_gpio are ignored.This patch adds a return value check for the first of_get_gpio.
Signed-off-by: Markus Pargmann
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman
17 Oct, 2013
2 commits
-
This patch proposes to remove the use of the IRQF_DISABLED flag
It's a NOOP since 2.6.35 and it will be removed one day.
Signed-off-by: Michael Opdenacker
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman -
This patch proposes to remove the use of the IRQF_DISABLED flag
It's a NOOP since 2.6.35 and it will be removed one day.
Signed-off-by: Michael Opdenacker
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman
