18 Jun, 2008
9 commits
-
Signed-off-by: Chas Williams
Signed-off-by: David S. Miller -
This fixes the most obvious 64-bit problems, but it is still very very
broken in other aspects.Signed-off-by: Alan Cox
Signed-off-by: Chas Williams
Signed-off-by: David S. Miller -
From: Mitchell Blank Jr
Signed-off-by: Chas Williams
Signed-off-by: David S. Miller -
Signed-off-by: Chas Williams
Signed-off-by: David S. Miller -
Signed-off-by: Jorge Boncompte [DTI2]
Signed-off-by: Chas Williams
Signed-off-by: David S. Miller -
Fix bridge netfilter code so that it uses CONFIG_IPV6 as needed:
net/built-in.o: In function `ebt_filter_ip6':
ebt_ip6.c:(.text+0x87c37): undefined reference to `ipv6_skip_exthdr'
net/built-in.o: In function `ebt_log_packet':
ebt_log.c:(.text+0x88dee): undefined reference to `ipv6_skip_exthdr'
make[1]: *** [.tmp_vmlinux1] Error 1Signed-off-by: Randy Dunlap
Signed-off-by: David S. Miller -
Normally, the bridge just chooses the smallest mac address as the
bridge id and mac address of bridge device. But if the administrator
has explictly set the interface address then don't change it.Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
Any frame addressed to link-local addresses should be processed by local
receive path. The earlier code would process them only if STP was enabled.
Since there are other frames like LACP for bonding, we should always
process them.Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
After the sctp_remaddr_proc_init failed, the proper rollback is
not the sctp_remaddr_proc_exit, but the sctp_assocs_proc_exit.Signed-off-by: Pavel Emelyanov
Acked-by: Vlad Yasevich
Signed-off-by: David S. Miller
17 Jun, 2008
31 commits
-
In nr_release(), one code path calls sock_orphan() which
will NULL out sk->sk_socket already.In the other case, handling states other than NR_STATE_{0,1,2,3},
seems to not be possible other than due to bugs. Even for an
uninitialized nr->state value, that would be zero or NR_STATE_0.
It might be wise to stick a WARN_ON() here.Signed-off-by: David S. Miller
-
It doesn't grab the sk_callback_lock, it doesn't NULL out
the sk->sk_sleep waitqueue pointer, etc.Signed-off-by: David S. Miller
-
It doesn't grab the sk_callback_lock, it doesn't NULL out
the sk->sk_sleep waitqueue pointer, etc.Signed-off-by: David S. Miller
-
This is the x25 variant of changeset
9375cb8a1232d2a15fe34bec4d3474872e02faec
("ax25: Use sock_graft() and remove bogus sk_socket and sk_sleep init.")Signed-off-by: David S. Miller
-
This is the rose variant of changeset
9375cb8a1232d2a15fe34bec4d3474872e02faec
("ax25: Use sock_graft() and remove bogus sk_socket and sk_sleep init.")Signed-off-by: David S. Miller
-
This is the netrom variant of changeset
9375cb8a1232d2a15fe34bec4d3474872e02faec
("ax25: Use sock_graft() and remove bogus sk_socket and sk_sleep init.")Signed-off-by: David S. Miller
-
The way that listening sockets work in ax25 is that the packet input
code path creates new socks via ax25_make_new() and attaches them
to the incoming SKB. This SKB gets queued up into the listening
socket's receive queue.When accept()'d the sock gets hooked up to the real parent socket.
Alternatively, if the listening socket is closed and released, any
unborn socks stuff up in the receive queue get released.So during this time period these sockets are unreachable in any
other way, so no wakeup events nor references to their ->sk_socket
and ->sk_sleep members can occur. And even if they do, all such
paths have to make NULL checks.So do not deceptively initialize them in ax25_make_new() to the
values in the listening socket. Leave them at NULL.Finally, use sock_graft() in ax25_accept().
Signed-off-by: David S. Miller
-
Signed-off-by: David S. Miller
-
Signed-off-by: David S. Miller
-
Just expand the wait sequence. And as a nice side-effect
the timeout is respected now.Signed-off-by: David S. Miller
-
Signed-off-by: David S. Miller
-
Conflicts:
drivers/net/wireless/rt2x00/Kconfig
drivers/net/wireless/rt2x00/rt2x00usb.c
net/sctp/protocol.c -
Signed-off-by: Chas Williams
Signed-off-by: David S. Miller -
From: "Robert T. Johnson"
Signed-off-by: Chas Williams -
From: Eric Kinzie
Signed-off-by: Chas Williams
Signed-off-by: David S. Miller -
Signed-off-by: Chas Williams
Signed-off-by: David S. Miller -
This causes the suni driver to oops if you try to use sonetdiag to get
the statistics. Also add the corresponding phy->stop call to fix another
oops if you try to remove the module.Signed-off-by: Jorge Boncompte [DTI2]
Signed-off-by: Chas Williams
Signed-off-by: David S. Miller -
Signed-off-by: Jorge Boncompte [DTI2]
Signed-off-by: Chas Williams
Signed-off-by: David S. Miller -
It happens that if a packet arrives in a VC between the call to open it on
the hardware and the call to change the backend to br2684, br2684_regvcc
processes the packet and oopses dereferencing skb->dev because it is
NULL before the call to br2684_push().Signed-off-by: Jorge Boncompte [DTI2]
Signed-off-by: Chas Williams -
There are many possible ways to add this "salt", thus I made this
patch to be the last in the series to change it if required.Currently I propose to use the struct net pointer itself as this
salt, but since this pointer is most often cache-line aligned, shift
this right to eliminate the bits, that are most often zeroed.After this, simply add this mix to prepared hashfn-s.
For CONFIG_NET_NS=n case this salt is 0 and no changes in hashfn
appear.Signed-off-by: Pavel Emelyanov
Signed-off-by: David S. Miller -
Same as for inet_hashfn, prepare its ipv6 incarnation.
Signed-off-by: Pavel Emelyanov
Signed-off-by: David S. Miller -
Although this hash takes addresses into account, the ehash chains
can also be too long when, for instance, communications via lo occur.
So, prepare the inet_hashfn to take struct net into account.Signed-off-by: Pavel Emelyanov
Signed-off-by: David S. Miller -
Listening-on-one-port sockets in many namespaces produce long
chains in the listening_hash-es, so prepare the inet_lhashfn to
take struct net into account.Signed-off-by: Pavel Emelyanov
Signed-off-by: David S. Miller -
Binding to some port in many namespaces may create too long
chains in bhash-es, so prepare the hashfn to take struct net
into account.Signed-off-by: Pavel Emelyanov
Signed-off-by: David S. Miller -
Every caller already has this one. The new argument is currently
unused, but this will be fixed shortly.Signed-off-by: Pavel Emelyanov
Signed-off-by: David S. Miller -
They both calculate the hash chain, but currently do not have
a struct net pointer, so pass one there via additional argument,
all the more so their callers already have such.Signed-off-by: Pavel Emelyanov
Signed-off-by: David S. Miller -
Currently the chain to store a UDP socket is calculated with
simple (x & (UDP_HTABLE_SIZE - 1)). But taking net into account
would make this calculation a bit more complex, so moving it into
a function would help.Signed-off-by: Pavel Emelyanov
Signed-off-by: David S. Miller -
1) Remove ICMP_MIN_LENGTH, as it is unused.
2) Remove unneeded tcp_v4_send_check() declaration.
Signed-off-by: Rami Rosen
Signed-off-by: David S. Miller -
I just noticed "cat /proc/net/raw" was buggy, missing '\n' separators.
I believe this was introduced by commit 8cd850efa4948d57a2ed836911cfd1ab299e89c6
([RAW]: Cleanup IPv4 raw_seq_show.)This trivial patch restores correct behavior, and applies to current
Linus tree (should also be applied to stable tree as well.)Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller -
Selected device feature bits can be propagated to VLAN devices, so we
can make use of TX checksum offload and TSO on VLAN-tagged packets.
However, if the physical device does not do VLAN tag insertion or
generic checksum offload then the test for TX checksum offload in
dev_queue_xmit() will see a protocol of htons(ETH_P_8021Q) and yield
false.This splits the checksum offload test into two functions:
- can_checksum_protocol() tests a given protocol against a feature bitmask
- dev_can_checksum() first tests the skb protocol against the device
features; if that fails and the protocol is htons(ETH_P_8021Q) then
it tests the encapsulated protocol against the effective device
features for VLANsSigned-off-by: Ben Hutchings
Acked-by: Patrick McHardy
Signed-off-by: David S. Miller -
Right now, any time we set a primary transport we set
the changeover_active flag. As a result, we invoke SFR-CACC
even when there has been no changeover events.Only set changeover_active, when there is a true changeover
event, i.e. we had a primary path and we are changing to
another transport.Signed-off-by: Vlad Yasevich
Signed-off-by: David S. Miller
