02 Feb, 2011
1 commit
-
This error is reported by cppcheck:
drivers/net/vxge/vxge-config.c:3693: warning: Mutual exclusion over || always evaluates to true. Did you intend to use && instead?It looks like cppcheck is correct, so fix this. No test was run.
Cc: Ramkrishna Vepa
Cc: Sivakumar Subramani
Cc: Sreenivasa Honnur
Cc: Jon Mason
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Stefan Weil
Acked-by: Ram Vepa
Signed-off-by: David S. Miller
15 Jan, 2011
1 commit
-
* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6: (47 commits)
GRETH: resolve SMP issues and other problems
GRETH: handle frame error interrupts
GRETH: avoid writing bad speed/duplex when setting transfer mode
GRETH: fixed skb buffer memory leak on frame errors
GRETH: GBit transmit descriptor handling optimization
GRETH: fix opening/closing
GRETH: added raw AMBA vendor/device number to match against.
cassini: Fix build bustage on x86.
e1000e: consistent use of Rx/Tx vs. RX/TX/rx/tx in comments/logs
e1000e: update Copyright for 2011
e1000: Avoid unhandled IRQ
r8169: keep firmware in memory.
netdev: tilepro: Use is_unicast_ether_addr helper
etherdevice.h: Add is_unicast_ether_addr function
ks8695net: Use default implementation of ethtool_ops::get_link
ks8695net: Disable non-working ethtool operations
USB CDC NCM: Don't deref NULL in cdc_ncm_rx_fixup() and don't use uninitialized variable.
vxge: Remember to release firmware after upgrading firmware
netdev: bfin_mac: Remove is_multicast_ether_addr use in netdev_for_each_mc_addr
ipsec: update MAX_AH_AUTH_LEN to support sha512
...
14 Jan, 2011
2 commits
-
Regardless of whether the firmware update being performed by
vxge_fw_upgrade() is a success or not we must still remember to always
release_firmware() before returning.Signed-off-by: Jesper Juhl
Acked-by: Ram Vepa
Signed-off-by: David S. Miller -
* 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (43 commits)
Documentation/trace/events.txt: Remove obsolete sched_signal_send.
writeback: fix global_dirty_limits comment runtime -> real-time
ppc: fix comment typo singal -> signal
drivers: fix comment typo diable -> disable.
m68k: fix comment typo diable -> disable.
wireless: comment typo fix diable -> disable.
media: comment typo fix diable -> disable.
remove doc for obsolete dynamic-printk kernel-parameter
remove extraneous 'is' from Documentation/iostats.txt
Fix spelling milisec -> ms in snd_ps3 module parameter description
Fix spelling mistakes in comments
Revert conflicting V4L changes
i7core_edac: fix typos in comments
mm/rmap.c: fix comment
sound, ca0106: Fix assignment to 'channel'.
hrtimer: fix a typo in comment
init/Kconfig: fix typo
anon_inodes: fix wrong function name in comment
fix comment typos concerning "consistent"
poll: fix a typo in comment
...Fix up trivial conflicts in:
- drivers/net/wireless/iwlwifi/iwl-core.c (moved to iwl-legacy.c)
- fs/ext4/ext4.hAlso fix missed 'diabled' typo in drivers/net/bnx2x/bnx2x.h while at it.
29 Dec, 2010
1 commit
-
This is just a cleanup to make the static checkers happy. We don't need
to check "own" twice.Signed-off-by: Dan Carpenter
Acked-by: Ram Vepa
Signed-off-by: David S. Miller
20 Dec, 2010
1 commit
-
Commit 6e07ebd84 (drivers/net: remove unnecessary
flush_scheduled_work() calls) incorrectly removed the flush call
without replacing it with the appropriate work specific operation.
Fix it by flushing vdev->reset_task explicitly.Pointed out by Jon Mason.
Signed-off-by: Tejun Heo
Cc: Jon Mason
Acked-by: Jon Mason
Signed-off-by: David S. Miller
12 Dec, 2010
1 commit
-
janz-ican3, sh_eth, skge and vxge don't use workqueue at all and there
is no reason to flush the system_wq. Drop flush_scheduled_work()
calls and references to workqueue.Signed-off-by: Tejun Heo
Cc: "David S. Miller"
Cc: Wolfgang Grandegger
Cc: Stephen Hemminger
Cc: Ramkrishna Vepa
Cc: Sivakumar Subramani
Cc: Sreenivasa Honnur
Cc: Jon Mason
Cc: netdev@vger.kernel.org
11 Dec, 2010
7 commits
-
Update vxge driver version to 2.5.1
Signed-off-by: Jon Mason
Signed-off-by: Ram Vepa
Signed-off-by: David S. Miller -
Configure the workload clock register and TIM register for independent
interrupt moderation based on the individual vpath utilization instead
of common link utilization. This greatly improves latency.Signed-off-by: Jon Mason
Signed-off-by: Ram Vepa
Signed-off-by: David S. Miller -
When hot-unplugging a vxge adapter while running, the driver's remove
routine prints warning and then stalls the calling thread. This is due
to vxge_remove calling vxge_device_unregister to unregister the netdev
before calling flush_scheduled_work clear any pending work. Swapping
the order of these two functions resolves the issue.Signed-off-by: Jon Mason
Signed-off-by: Ram Vepa
Signed-off-by: David S. Miller -
Use a workqueue to handle the device reset during a transmit timeout, as
there can be a deadlock during bringup. Also, set the netif carrier off
before the watchdog reset is started to prevent the timeout from
reoccurring while still processing the first.Signed-off-by: Jon Mason
Signed-off-by: Ram Vepa
Signed-off-by: David S. Miller -
Only BAR0 is ever accessed, thus making the calls to pci_request_regions
overkill. Change calls of pci_request_regions to pci_request_region to
reduce the size of the mapped area.Signed-off-by: Jon Mason
Signed-off-by: Ram Vepa
Signed-off-by: David S. Miller -
Calling pci_disable_sriov when unloading a SR-IOV physical function
driver from a host when a guest is using a virtual function from that
device can cause a host crash or VM crash. The crash is caused by the
virtual config space no longer being present when PF is removed (due to
the pci_disable_sriov). This can be avoided by not calling
pci_disable_sriov to disable the PCI space when shutting down the PF.
Each function in the X3100 operates independently and in this case will
operate properly in the absence of the PF.Also, added improved logic in the detection of SR-IOV initialization.
Signed-off-by: Jon Mason
Signed-off-by: Ram Vepa
Signed-off-by: David S. Miller -
Move function locations to remove the need for internal declarations and
other misc clean-ups.Signed-off-by: Jon Mason
Signed-off-by: Arpit Patel
Signed-off-by: David S. Miller
07 Dec, 2010
1 commit
-
NETIF_F_HW_CSUM is a superset of NETIF_F_IP_CSUM+NETIF_F_IPV6_CSUM, but
some drivers miss the difference. Fix this and also fix UFO dependency
on checksumming offload as it makes the same mistake in assumptions.Signed-off-by: Michał Mirosław
Acked-by: Jon Mason
Signed-off-by: David S. Miller
02 Dec, 2010
3 commits
-
Update vxge driver version
Signed-off-by: Jon Mason
Signed-off-by: David S. Miller -
Use strncpy instead of memcpy when working on strings
Signed-off-by: Jon Mason
Signed-off-by: David S. Miller -
Remove printks for ring blocks, fifo blocks, and rx doorbell mode as
they clutter the dmesg output during modprobe and provide no useful
information.Signed-off-by: Jon Mason
Signed-off-by: David S. Miller
29 Nov, 2010
1 commit
-
Signed-off-by: Joe Perches
Signed-off-by: David S. Miller
28 Nov, 2010
1 commit
-
Use vzalloc() and vzalloc_node() in net drivers
Signed-off-by: Eric Dumazet
Acked-by: Jon Mason
Signed-off-by: David S. Miller
18 Nov, 2010
2 commits
-
Signed-off-by: Joe Perches
Acked-by: Jon Mason
Signed-off-by: David S. Miller -
Signed-off-by: Joe Perches
Acked-by: Jon Mason
Signed-off-by: David S. Miller
12 Nov, 2010
11 commits
-
Update vxge driver version
Signed-off-by: Jon Mason
Signed-off-by: Ram Vepa
Signed-off-by: David S. Miller -
Correct issues found by running sparse on the vxge driver, as well as
other miscellaneous cleanups.Signed-off-by: Jon Mason
Signed-off-by: David S. Miller -
The values used to determined if the adapter is running in single or
multi-function mode were previously modified to the values necessary
when making the VXGE_HW_FW_API_GET_FUNC_MODE firmware call. However,
the firmware call was not modified. This had the driver printing out on
probe that the adapter was in multi-function mode when in single
function mode and vice versa.Signed-off-by: Jon Mason
Signed-off-by: Ram Vepa
Signed-off-by: David S. Miller -
Detect if the adapter is Titan or Titan1A, and tune the driver for this
hardware. Also, remove unnecessary function __vxge_hw_device_id_get.Signed-off-by: Jon Mason
Signed-off-by: Ram Vepa
Signed-off-by: David S. Miller -
Propagate the return code of the call to vxge_hw_vpath_fw_api and
__vxge_hw_vpath_pci_func_mode_get. This enables the proper handling of
error conditions when querying the function mode of the device during
probe.Signed-off-by: Jon Mason
Signed-off-by: Ram Vepa
Signed-off-by: David S. Miller -
Add support for enable/disabling hardware timestamping on receive
packets via ioctl call. When enabled, the hardware timestamp replaces
the FCS in the payload.Signed-off-by: Jon Mason
Signed-off-by: Ram Vepa
Signed-off-by: David S. Miller -
Add the ability in the vxge driver to flash firmware via ethtool.
Updated to include comments from Ben Hutchings.
Signed-off-by: Jon Mason
Signed-off-by: Ram Vepa
Signed-off-by: David S. Miller -
It is possible for multiple callers to access the firmware interface for
the same vpath simultaneously, resulting in uncertain output. Add locks
to serialize access. Also, make functions only accessed locally static,
thus requiring some movement of code blocks.Signed-off-by: Jon Mason
Signed-off-by: Ram Vepa
Signed-off-by: David S. Miller -
Remove all of the unnecessary debug printk indirection and temporary
variables for vxge_debug_ll and vxge_assert.Signed-off-by: Jon Mason
Signed-off-by: Ram Vepa
Signed-off-by: David S. Miller -
Wait for the receive traffic to become idle before attempting to close
or reset the adapter. To enable the processing of packets while Receive
Idle, move the clearing of __VXGE_STATE_CARD_UP bit in vxge_close to
after it. Also, modify the return value of the ISR when the adapter is
down to IRQ_HANDLED. Otherwise there are unhandled interrupts for the
device.Signed-off-by: Jon Mason
Signed-off-by: Ram Vepa
Signed-off-by: David S. Miller -
Enable RSS hashing and add ability to pass up the adapter calculated rx
hash up the network stack (if feature is available). Add the ability to
enable/disable feature via ethtool, which requires that the adapter is
not running at the time. Other miscellaneous cleanups and fixes
required to get RSS working.Signed-off-by: Jon Mason
Signed-off-by: Ram Vepa
Signed-off-by: David S. Miller
02 Nov, 2010
1 commit
-
"gadget", "through", "command", "maintain", "maintain", "controller", "address",
"between", "initiali[zs]e", "instead", "function", "select", "already",
"equal", "access", "management", "hierarchy", "registration", "interest",
"relative", "memory", "offset", "already",Signed-off-by: Uwe Kleine-König
Signed-off-by: Jiri Kosina
25 Oct, 2010
1 commit
-
Use results of make namespacecheck to make functions local and
remove code that is not used.Also rename initialize_ethtool_ops to vxge_initialize_ethtool_ops.
Compile tested only.
Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller
21 Oct, 2010
2 commits
-
Many (but not all) drivers check to see whether there is a vlan
group configured before using a tag stored in the skb. There's
not much point in this check since it just throws away data that
should only be present in the expected circumstances. However,
it will soon be legal and expected to get a vlan tag when no
vlan group is configured, so remove this check from all drivers
to avoid dropping the tags.Signed-off-by: Jesse Gross
Signed-off-by: David S. Miller -
VLAN_GROUP_ARRAY_LEN is simply the number of possible vlan VIDs.
Since vlan groups will soon be more of an implementation detail
for vlan devices, rename the constant to be descriptive of its
actual purpose.Signed-off-by: Jesse Gross
Signed-off-by: David S. Miller
03 Sep, 2010
1 commit
-
fresh skbs have ip_summed set to CHECKSUM_NONE (0)
We can avoid setting again skb->ip_summed to CHECKSUM_NONE in drivers.
Introduce skb_checksum_none_assert() helper so that we keep this
assertion documented in driver sources.Change most occurrences of :
skb->ip_summed = CHECKSUM_NONE;
by :
skb_checksum_none_assert(skb);
Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller
19 Aug, 2010
1 commit
-
vxge_get_stats() is racy, since it clears a block of memory (net_stats)
possibly still used by other cpus.We can update this driver to full 64bit stats, since ndo_get_stats64()
provides a private block to store results, and driver maintains 64bit
counters already.We also remove net_stats field from struct vxge_sw_stats
Signed-off-by: Eric Dumazet
Acked-by: Jon Mason
Signed-off-by: David S. Miller
18 Aug, 2010
1 commit
-
These changes may be slightly safer in some instances.
There are other kzalloc calls with a multiply, but those
calls are typically "small fixed #" * sizeof(some pointer)"
and those are not converted.Signed-off-by: Joe Perches
Acked-by: Gertjan van Wingerde
Acked-by: Luciano Coelho
Signed-off-by: David S. Miller