21 May, 2019
1 commit
-
Add SPDX license identifiers to all Make/Kconfig files which:
- Have no license information of any form
These files fall under the project license, GPL v2 only. The resulting SPDX
license identifier is:GPL-2.0-only
Signed-off-by: Thomas Gleixner
Signed-off-by: Greg Kroah-Hartman
15 May, 2019
1 commit
-
To facilitate additional options to get_user_pages_fast() change the
singular write parameter to be gup_flags.This patch does not change any functionality. New functionality will
follow in subsequent patches.Some of the get_user_pages_fast() call sites were unchanged because they
already passed FOLL_WRITE or 0 for the write parameter.NOTE: It was suggested to change the ordering of the get_user_pages_fast()
arguments to ensure that callers were converted. This breaks the current
GUP call site convention of having the returned pages be the final
parameter. So the suggestion was rejected.Link: http://lkml.kernel.org/r/20190328084422.29911-4-ira.weiny@intel.com
Link: http://lkml.kernel.org/r/20190317183438.2057-4-ira.weiny@intel.com
Signed-off-by: Ira Weiny
Reviewed-by: Mike Marshall
Cc: Aneesh Kumar K.V
Cc: Benjamin Herrenschmidt
Cc: Borislav Petkov
Cc: Dan Williams
Cc: "David S. Miller"
Cc: Heiko Carstens
Cc: Ingo Molnar
Cc: James Hogan
Cc: Jason Gunthorpe
Cc: John Hubbard
Cc: "Kirill A. Shutemov"
Cc: Martin Schwidefsky
Cc: Michal Hocko
Cc: Paul Mackerras
Cc: Peter Zijlstra
Cc: Ralf Baechle
Cc: Rich Felker
Cc: Thomas Gleixner
Cc: Yoshinori Sato
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
22 Jan, 2019
1 commit
-
prefer 'help' over '---help---' for new help texts
Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman
04 Jan, 2019
1 commit
-
Nobody has actually used the type (VERIFY_READ vs VERIFY_WRITE) argument
of the user address range verification function since we got rid of the
old racy i386-only code to walk page tables by hand.It existed because the original 80386 would not honor the write protect
bit when in kernel mode, so you had to do COW by hand before doing any
user access. But we haven't supported that in a long time, and these
days the 'type' argument is a purely historical artifact.A discussion about extending 'user_access_begin()' to do the range
checking resulted this patch, because there is no way we're going to
move the old VERIFY_xyz interface to that model. And it's best done at
the end of the merge window when I've done most of my merges, so let's
just get this done once and for all.This patch was mostly done with a sed-script, with manual fix-ups for
the cases that weren't of the trivial 'access_ok(VERIFY_xyz' form.There were a couple of notable cases:
- csky still had the old "verify_area()" name as an alias.
- the iter_iov code had magical hardcoded knowledge of the actual
values of VERIFY_{READ,WRITE} (not that they mattered, since nothing
really used it)- microblaze used the type argument for a debug printout
but other than those oddities this should be a total no-op patch.
I tried to fix up all architectures, did fairly extensive grepping for
access_ok() uses, and the changes are trivial, but I may have missed
something. Any missed conversion should be trivially fixable, though.Signed-off-by: Linus Torvalds
16 Oct, 2018
6 commits
-
checkpacth: Missing a blank line after declarations
Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman -
This casting is not required.
Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman -
Undo effects of misc_register if driver's init fails after
misc_register.Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman -
This is the last patch in the series of patches to move file-scope
variables into the driver state. This change will help to introduce
another version of the pipe driver (with different state) for the
older host interface or having several instances of this device.Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman -
This is a series of patches to move mutable file-scope variables
into the driver state. This change will help to introduce another
version of the pipe driver (with different state) for the older
host interface or having several instances of this device.Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman -
…e into the driver state
This is a series of patches to move mutable file-scope variables
into the driver state. This change will help to introduce another
version of the pipe driver (with different state) for the older
host interface or having several instances of this device.Signed-off-by: Roman Kiryanov <rkir@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
26 Sep, 2018
6 commits
-
Fixes the following sparse warning:
drivers/platform/goldfish/goldfish_pipe.c:214:26: warning:
symbol 'goldfish_pipe_dev' was not declared. Should it be static?Signed-off-by: Wei Yongjun
Signed-off-by: Greg Kroah-Hartman -
No symbols were used from this header.
Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman -
goldfish_pipe_command is defines just after declaration and
nothing refers to goldfish_pipe before it is defined.Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman -
The blank line is not required there.
Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman -
… to the same variable
Move the "pages" buffer into "struct goldfish_pipe". Since we are
locking the mutex on the pipe in transfer_max_buffers, other threads
willnot be able to write into it, but other pipe instances could be
served because they have its own buffer.Signed-off-by: Roman Kiryanov <rkir@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> -
The boilerplate license is not necessary when the SPDX line is
present.Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman
14 Sep, 2018
20 commits
-
checkpatch: Comparison to NULL could be written "!x"
Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman -
checkpatch: Logical continuations should be on the previous line
Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman -
checkpatch: Alignment should match open parenthesis.
Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman -
checkpatch: Lines should not end with a '(' or '['
Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman -
Add "pipe" to the pipe related function names.
Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman -
Casting to (void) is no-op.
Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman -
checkpatch: Avoid CamelCase
Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman -
checkpatch: Blank lines aren't necessary before a close brace '}'
Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman -
Casting to u32 is not required here.
Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman -
Two function calls look cleaner because the function introduces
takes case of all bit shifting and casting.Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman -
The variable was not very useful.
Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman -
To improve readability and to be consistent with other
struct members.Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman -
dev_ is preferred if struct device is available.
Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman -
There is no reason to have an array of 1.
Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman -
Since the driver provides no workaround prevent in cases if structs do
no fit into a memory page, it is better to fail complation to find about
the issue earlt instead of returning errors at runtime.Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman -
Provide an explanation why GFP_ATOMIC is needed to prevent changing it to
other values.Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman -
These are several enums that must kept in sync with the host side.
This change explicitly separates them into a dedicated header file.Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman -
checkpatch: Function's opening brace has to be at the
beginning of the next line.Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman -
goldfish_pipe is distributed under GPL v2.
Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman -
Some comment lines are longer than 80 symbols.
Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman
02 Aug, 2018
1 commit
-
Not used by goldfish.
Signed-off-by: Roman Kiryanov
Signed-off-by: Greg Kroah-Hartman
07 Jul, 2018
1 commit
-
At over 4000 #includes, is the 9th most
#included header file in the Linux kernel. It does not need
, so drop that header and explicitly add
to source files that need it.4146 #include
After this patch, there are 225 files that use ,
for a reduction of around 3900 times that
does not have to be read & parsed.225 #include
This patch was build-tested on 20 different arch-es.
It also makes these drivers SubmitChecklist#1 compliant.
Signed-off-by: Randy Dunlap
Reported-by: kbuild test robot # drivers/media/platform/vimc/
Reported-by: kbuild test robot # drivers/pinctrl/pinctrl-u300.c
Signed-off-by: Greg Kroah-Hartman
03 Jul, 2018
1 commit
-
Tasklet goldfish_interrupt_tasklet is local to the source and
does not need to be in global scope, so make it static.Cleans up sparse warning:
symbol 'goldfish_interrupt_tasklet' was not declared. Should it be static?Signed-off-by: Colin Ian King
Signed-off-by: Greg Kroah-Hartman
12 Feb, 2018
1 commit
-
This is the mindless scripted replacement of kernel use of POLL*
variables as described by Al, done by this script:for V in IN OUT PRI ERR RDNORM RDBAND WRNORM WRBAND HUP RDHUP NVAL MSG; do
L=`git grep -l -w POLL$V | grep -v '^t' | grep -v /um/ | grep -v '^sa' | grep -v '/poll.h$'|grep -v '^D'`
for f in $L; do sed -i "-es/^\([^\"]*\)\(\\)/\\1E\\2/" $f; done
donewith de-mangling cleanups yet to come.
NOTE! On almost all architectures, the EPOLL* constants have the same
values as the POLL* constants do. But they keyword here is "almost".
For various bad reasons they aren't the same, and epoll() doesn't
actually work quite correctly in some cases due to this on Sparc et al.The next patch from Al will sort out the final differences, and we
should be all done.Scripted-by: Al Viro
Signed-off-by: Linus Torvalds