21 May, 2019
1 commit
-
Add SPDX license identifiers to all Make/Kconfig files which:
- Have no license information of any form
These files fall under the project license, GPL v2 only. The resulting SPDX
license identifier is:GPL-2.0-only
Signed-off-by: Thomas Gleixner
Signed-off-by: Greg Kroah-Hartman
02 May, 2019
31 commits
-
For improving code readability it helps to have a blank line between
function so add when missing.Checkpatch complains:
CHECK: Please use a blank line after function/struct/union/enum
declarationsSigned-off-by: Vinod Koul
Signed-off-by: Greg Kroah-Hartman -
Found few more typos in the code, fix them
CHECK: 'and and' may be misspelled - perhaps 'and'?
CHECK: 'smaple' may be misspelled - perhaps 'sample'?Signed-off-by: Vinod Koul
Signed-off-by: Greg Kroah-Hartman -
Modify the code to avoid multiple assignments by assigning to variable
after error checks in soundwire bus.CHECK: multiple assignments should be avoided
Signed-off-by: Vinod Koul
Signed-off-by: Greg Kroah-Hartman -
Found few more issues reported checkpatch on code alignment so fix those
as well in the intel module.Signed-off-by: Vinod Koul
Signed-off-by: Greg Kroah-Hartman -
Found few more issues reported checkpatch on code alignment so fix those
as well in the soundwire core.Signed-off-by: Vinod Koul
Signed-off-by: Greg Kroah-Hartman -
Linux code style doesn't expect empty lines after braces and
gives warning:CHECK: Blank lines aren't necessary after an open brace '{'
Remove the empty line in intel module
Signed-off-by: Vinod Koul
Signed-off-by: Greg Kroah-Hartman -
Linux code style doesn't expect empty lines after braces and
gives warning:CHECK: Blank lines aren't necessary after an open brace '{'
Remove the empty line in cadence lib
Signed-off-by: Vinod Koul
Signed-off-by: Greg Kroah-Hartman -
Linux code style doesn't expect empty lines before or after braces and
gives warning:CHECK: Blank lines aren't necessary after an open brace '{'
CHECK: Blank lines aren't necessary before a close brace '}'Fix these instances in soundwire core
Signed-off-by: Vinod Koul
Signed-off-by: Greg Kroah-Hartman -
Move to help format instead of --help-- as that is not recommended and
this makes file consistent with other instanceSigned-off-by: Vinod Koul
Signed-off-by: Greg Kroah-Hartman -
For some reason the newlines are not used everywhere. Fix as needed.
Reported-by: Joe Perches
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Greg Kroah-Hartman -
Extra newline does not improve readability.
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Greg Kroah-Hartman -
No need for explicit test against true
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Greg Kroah-Hartman -
While not strictly necessary, balanced parentheses help with code
readability.Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Greg Kroah-Hartman -
Use Linux style
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Greg Kroah-Hartman -
No need for explicit test against true
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Greg Kroah-Hartman -
Extra parentheses required here
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Greg Kroah-Hartman -
Use Linux style
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Greg Kroah-Hartman -
Use Linux style
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Greg Kroah-Hartman -
Use Linux style
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Greg Kroah-Hartman -
Use Linux style
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Greg Kroah-Hartman -
No need for explicit test against true
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Greg Kroah-Hartman -
Use Linux style. In some cases parenthesis alignment is modified to
keep the code readable.Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Greg Kroah-Hartman -
Use Linux style
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Greg Kroah-Hartman -
tools complain here and the location of the newline does not improve
readability.Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Greg Kroah-Hartman -
no need for an explicit test against false
reported by CoccinelleReviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Greg Kroah-Hartman -
and make the code more readable
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Greg Kroah-Hartman -
spelling mistakes
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Greg Kroah-Hartman -
Use Linux style
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Greg Kroah-Hartman -
use Linux style
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Greg Kroah-Hartman -
No C++ comments in .h files
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Greg Kroah-Hartman -
Move to the regular help format, --help-- is no longer recommended.
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Greg Kroah-Hartman
14 Apr, 2019
4 commits
-
These two files are implicitly relying on an instance of including
module.h from .Ideally, header files under include/linux shouldn't be adding
includes of other headers, in anticipation of their consumers,
but just the headers needed for the header itself to pass
parsing with CPP.The module.h is particularly bad in this sense, as it itself does
include a whole bunch of other headers, due to the complexity of
module support.Here, we make those includes explicit, in order to allow a future
removal of module.h from linux/acpi.h without causing build breakage.Cc: Vinod Koul
Cc: Sanyog Kale
Cc: Pierre-Louis Bossart
Signed-off-by: Paul Gortmaker
Signed-off-by: Vinod Koul -
no need to reset return value.
Detected with cppcheck:
[drivers/soundwire/stream.c:332]: (style) Variable 'ret' is assigned a
value that is never used.Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Takashi Iwai
Signed-off-by: Vinod Koul -
No need for explicit initialization of page and ssp fields, they are
already zeroed with a memset.Detected with cppcheck:
[drivers/soundwire/bus.c:309]: (style) Variable 'msg->page' is
reassigned a value before the old one has been used.Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Takashi Iwai
Signed-off-by: Vinod Koul -
the number of elements and size are inverted, fix.
This probably only worked because the number of properties is
hard-coded to 1.Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Takashi Iwai
Signed-off-by: Vinod Koul
12 Nov, 2018
1 commit
-
The snd_soc_dai_ops structures are only stored in the ops field of a
snd_soc_dai_driver structure, so make the snd_soc_dai_ops structures
const as well.Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
Signed-off-by: Vinod Koul
27 Aug, 2018
3 commits
-
Signed-off-by: Shreyas NC
Acked-by: Pierre-Louis Bossart
Signed-off-by: Vinod Koul -
In case of error, we can dereference uninitialized 'adev'
drivers/soundwire/intel_init.c:154 sdw_intel_acpi_cb()
error: uninitialized symbol 'adev'.Fix that by not using adev for warn print and make it pr_err.
Reported-by: Dan Carpenter
Acked-by: Pierre-Louis Bossart
Signed-off-by: Vinod Koul -
To support multi link on Intel platforms, we need to update
SDW SHIM registers.So, add pre/post bank switch ops for the same in Intel driver.
Signed-off-by: Sanyog Kale
Signed-off-by: Shreyas NC
Acked-by: Pierre-Louis Bossart
Signed-off-by: Vinod Koul
