28 Jul, 2017
1 commit
-
commit 740c433ec35187b45abe08bb6c45a321a791be8e upstream.
If vesafb is enabled in the config then /dev/fb0 is created by vesa
and this sm750 driver gets fb1, fb2. But we need to be fb0 and fb1 to
effectively work with xorg.
So if it has been alloted fb1, then try to remove the other fb0.In the previous send, why #ifdef is used was asked.
https://lkml.org/lkml/2017/6/25/57Answered at: https://lkml.org/lkml/2017/6/25/69
Also pasting here for reference.'Did a quick research into "why".
The patch d8801e4df91e ("x86/PCI: Set IORESOURCE_ROM_SHADOW only for the
default VGA device") has started setting IORESOURCE_ROM_SHADOW in flags
for a default VGA device and that is being done only for x86.
And so, we will need that #ifdef to check IORESOURCE_ROM_SHADOW as that
needs to be checked only for a x86 and not for other arch.'Signed-off-by: Teddy Wang
Signed-off-by: Sudip Mukherjee
Signed-off-by: Greg Kroah-Hartman
07 Nov, 2016
1 commit
-
Early commit 30ca5cb63c56965 ("staging: sm750fb: change definition of
PANEL_PLANE_TL fields") and 27b047bbe1ee9c0 ("staging: sm750fb: change
definition of PANEL_PLANE_BR fields") modify the register bit fields
definitions. But the modifications are wrong, because the bit mask of
"bit field 10:0" is not 0xeff, but 0x7ff. The wrong definition bugs
makes display very strange.Signed-off-by: Huacai Chen
Cc: stable # 4.6+
Signed-off-by: Greg Kroah-Hartman
02 Oct, 2016
2 commits
-
Replace local implementation of rounded division (roundedDiv macro) with
the in-kernel implementation (DIV_ROUND_CLOSEST macro) in ddk750_chip.cSigned-off-by: Moshe Green
Signed-off-by: Greg Kroah-Hartman -
Fix 2 checkpatch errors:
-Block comments use * on subsequent lines,
-Block comments use a trailing */ on a separate line
to conform to block commenting style.Signed-off-by: Elizabeth Ferdman
Signed-off-by: Greg Kroah-Hartman
27 Sep, 2016
1 commit
-
Rename CamelCased function getChipType to sm750_get_chip_type
(prefex with sm750 in order to make the context of
the function clear).This issue was found by checkpatch.pl
Signed-off-by: Moshe Green
Signed-off-by: Greg Kroah-Hartman
22 Sep, 2016
2 commits
-
Remove unnecessary parentheses from right side of an assignment. Issue
detected by the following Coccinelle semantic patch:@r@
identifier x;
expression e1, e2;
@@- x = (e1 << e2);
+ x = e1 << e2;Signed-off-by: Rehas Sachdeva
Acked-by: Julia Lawall
Signed-off-by: Greg Kroah-Hartman -
Replaces left shift operation (1 << d) by BIT(x) macro.
Signed-off-by: Rehas Sachdeva
Signed-off-by: Greg Kroah-Hartman
20 Sep, 2016
1 commit
-
Adds spaces on either side of a '|'. Issue found by checkpatch.
Signed-off-by: Rehas Sachdeva
Signed-off-by: Greg Kroah-Hartman
16 Sep, 2016
5 commits
-
It is preferred to use 'u32' instead of 'uint32_t' for unsigned int. Issue
detected by checkpatch.Signed-off-by: Rehas Sachdeva
Signed-off-by: Greg Kroah-Hartman -
Changes the explicit comparison to NULL from 'x != NULL' to 'x'. Issue detected
by checkpatch.Signed-off-by: Rehas Sachdeva
Signed-off-by: Greg Kroah-Hartman -
Fix the following warning types:
- line length
- block comment line * prefix
- trailing */ on a separate line
found by the checkpatch.pl tool in multiple block comments.Fix a single spelling error in a comment.
Signed-off-by: Moshe Green
Signed-off-by: Greg Kroah-Hartman -
Fix multiple line length warnings found by the checkpatch.pl tool
in ddk750_chip.c.Signed-off-by: Moshe Green
Signed-off-by: Greg Kroah-Hartman -
Remove unnecessary blank line.
This patch is detected by checkpatch.pl script .
CHECK: Blank lines aren't necessary before a close brace '}'Signed-off-by: Sandhya Bankar
Signed-off-by: Greg Kroah-Hartman
12 Sep, 2016
1 commit
-
Commit 6fba39cf32a3 ("staging: sm750fb: use BIT macro for
PANEL_DISPLAY_CTRL single-bit fields") accidentally changed the
CLOCK_PHASE logic from '|=' to '=' which clears all the previously set
bits.Fixes: 6fba39cf32a3 ("staging: sm750fb: use BIT macro for PANEL_DISPLAY_CTRL single-bit fields")
Signed-off-by: Phil Turnbull
Signed-off-by: Greg Kroah-Hartman
22 Aug, 2016
9 commits
-
This patch fixes the checkpatch.pl warning:
WARNING: Block comments use * on subsequent lines
Signed-off-by: Edward Lipinsky
Signed-off-by: Greg Kroah-Hartman -
Split lines over 80 characters and separated assignments.
Signed-off-by: Stefan Wolz
Signed-off-by: Christian Halder
Signed-off-by: Sebastian Handwerker
Signed-off-by: Greg Kroah-Hartman -
Fixed multiline comments to meet style standards,
fixed typos and split comment lines over 80 characters.Signed-off-by: Stefan Wolz
Signed-off-by: Christian Halder
Signed-off-by: Sebastian Handwerker
Signed-off-by: Greg Kroah-Hartman -
Deleted unnecessary newlines and added whitespaces around operators.
Signed-off-by: Stefan Wolz
Signed-off-by: Christian Halder
Signed-off-by: Sebastian Handwerker
Signed-off-by: Greg Kroah-Hartman -
Fixed alignment in multiline declarations.
Signed-off-by: Stefan Wolz
Signed-off-by: Christian Halder
Signed-off-by: Sebastian Handwerker
Signed-off-by: Greg Kroah-Hartman -
WARNING: Block comments use * on subsequent lines
WARNING: Block comments use a trailing */ on a separate line
WARNING: Block comments use * on subsequent lines
WARNING: Block comments use a trailing */ on a separate lineSigned-off-by: yeongjun Kim
Signed-off-by: Greg Kroah-Hartman -
This is a patch to the ddk750_chip.c file that fixes up two block
comment coding style warnings found by the checkpatch.pl toolSigned-off-by: Moshe Green
Signed-off-by: Greg Kroah-Hartman -
This is a patch to the ddk750_chip.c file that fixes up a line length
warning found by the checkpatch.pl toolSigned-off-by: Moshe Green
Signed-off-by: Greg Kroah-Hartman -
This is a patch to the ddk750_chip.c file that fixes up a
line length warning found by the checkpatch.pl tool.Signed-off-by: Moshe Green
Signed-off-by: Greg Kroah-Hartman
30 Mar, 2016
1 commit
-
max_d is not initialized and should be set to the largest D
value of 6.Signed-off-by: Colin Ian King
Signed-off-by: Greg Kroah-Hartman
12 Mar, 2016
8 commits
-
The functions dviGetDeviceID and dviGetVendorID are not used anywhere in
the kernel so remove them. Also, remove their function prototypes.
Grepped to find occurences.Signed-off-by: Bhumika Goyal
Signed-off-by: Greg Kroah-Hartman -
Remove leading and trailing whitespace.
Signed-off-by: Sandhya Bankar
Signed-off-by: Greg Kroah-Hartman -
Replace pr_err() calls with respective dev_err() counterpart.
Change is safe since pdev is not NULL, this was identified by hand.
Semantic patch used to detect and apply the transformation:@r exists@
identifier f,s,i;
position p;
@@f(...,struct s *i,...) {
}@s@
identifier r.s, dev;
@@struct s {
...
struct device dev;
...
};@t@
identifier r.i, s.dev;
expression fmt;
position r.p;
@@- pr_err@p(
+ dev_err(&i->dev,
fmt, ...);Signed-off-by: Eva Rachel Retuya
Signed-off-by: Greg Kroah-Hartman -
The macro PEEK32 is used nowhere in the file. Hence,removed.
Signed-off-by: Bhaktipriya Shridhar
Signed-off-by: Greg Kroah-Hartman -
Devm_ functions allocate memory that is released when a driver
detaches.
Replace pci_enable_device with the managed pcim_enable_device
and remove corresponding pci_disable_device from probe and
suspend functions of a pci_dev.Also, an unnecessary label has been removed by replacing it
with a direct return statement.Signed-off-by: Amitoj Kaur Chawla
Signed-off-by: Greg Kroah-Hartman -
Devm_ functions allocate memory that is released when a driver
detaches.
Replace kzalloc with devm_kzalloc and remove corresponding
kfrees from probe and remove functions of a pci_dev.Also, an unnecessary label has been removed by replacing it
with a direct return statement.Signed-off-by: Amitoj Kaur Chawla
Signed-off-by: Greg Kroah-Hartman -
Unnecessary pci_set_drvdata() has been removed since the driver
core clears the driver data to NULL after device release or on
probe failure. There is no need to manually clear the device
driver data to NULL.The Coccinelle semantic patch used to make this change is as follows:
//
@@
struct pci_dev *pci;
@@
- pci_set_drvdata(pci, NULL);
//Signed-off-by: Amitoj Kaur Chawla
Signed-off-by: Greg Kroah-Hartman -
Remove unnecessary parentheses from return arguments.
The Coccinelle semantic patch that makes this change is as follows:
//
@@
identifier i;
constant c;
@@return
- (
\(i\|-i\|i(...)\|c\)
- )
;
//Signed-off-by: Amitoj Kaur Chawla
Signed-off-by: Greg Kroah-Hartman
23 Feb, 2016
1 commit
-
Remove duplicate include files. Found using includecheck.
Signed-off-by: Amitoj Kaur Chawla
Signed-off-by: Greg Kroah-Hartman
21 Feb, 2016
5 commits
-
This header only contains unused FIELD_*() macros and friends and may be
removedSigned-off-by: Mike Rapoport
Signed-off-by: Greg Kroah-Hartman -
The MHz() and roundedDiv macros are used only by ddk750_chip.c, so move
their definition there.Signed-off-by: Mike Rapoport
Signed-off-by: Greg Kroah-Hartman -
already has 'abs', use it instead of custom absDiff
Signed-off-by: Mike Rapoport
Signed-off-by: Greg Kroah-Hartman -
Use stratigh-forward of multi-bit register fields
Signed-off-by: Mike Rapoport
Signed-off-by: Greg Kroah-Hartman -
Replace complex definition of single-bit fields with BIT() macro for the
registers that are not currently referenced by the driver.Signed-off-by: Mike Rapoport
Signed-off-by: Greg Kroah-Hartman
16 Feb, 2016
2 commits
-
Use stratight-forward definition of CRT_FB_ADDRESS register fields
and use open-coded implementation for register manipulationSigned-off-by: Mike Rapoport
Signed-off-by: Greg Kroah-Hartman -
Use stratight-forward definition of CRT_FB_WIDTH register fields
and use open-coded implementation for register manipulationSigned-off-by: Mike Rapoport
Signed-off-by: Greg Kroah-Hartman