Eric Lee / smarc-fsl-linux-kernel

18 Oct, 2017

1 commit

  • bbab59d6c   ALSA: caiaq: Fix stray URB at probe error path ... Browse Code »

    commit 99fee508245825765ff60155fed43f970ff83a8f upstream.

    caiaq driver doesn't kill the URB properly at its error path during
    the probe, which may lead to a use-after-free error later. This patch
    addresses it.

    Reported-by: Johan Hovold
    Reviewed-by: Johan Hovold
    Signed-off-by: Takashi Iwai
    Signed-off-by: Greg Kroah-Hartman

    Takashi Iwai
     

12 Aug, 2016

1 commit

05 Jan, 2015

1 commit

  • 49cdd5b64   ALSA: snd-usb-caiaq: fix stream count check ... Browse Code »

    Commit 897c329bc ("ALSA: usb: caiaq: check for cdev->n_streams > 1")
    introduced a safety check to protect against bogus data provided by
    devices. However, the n_streams variable is already divided by
    CHANNELS_PER_STREAM, so the correct check is 'n_streams > 0'.

    Fix this to un-break support for stereo devices.

    Signed-off-by: Daniel Mack
    Cc: stable@kernel.org [v3.18+]
    Signed-off-by: Takashi Iwai

    Daniel Mack
     

07 Oct, 2014

1 commit

22 Sep, 2014

1 commit

12 Feb, 2014

1 commit

30 Sep, 2013

1 commit

21 Jun, 2013

3 commits

30 Apr, 2013

1 commit

  • 4ca231b2e   ALSA: usb-audio: caiaq: fix endianness bug in snd_usb_caiaq_maschine_dispatch ... Browse Code »

    Current code does this:

    be16_to_cpu(buf[i * 2] << 8 | buf[(i * 2) + 1])

    Which is effectively (neglecting the index):

    be16_to_cpu(be16_to_cpu(*((u16 *) buf)))

    This means the int16 in the buffer is not converted at all.

    Daniel Mack confirmed that the driver works on little endian
    CPUs, leading to the conclusion that the device-side structure
    is actually little endian.
    This changes the code to use le16_to_cpu().

    Caught by sparse.

    Acked-by: Daniel Mack
    Signed-off-by: Eldad Zack
    Signed-off-by: Takashi Iwai

    Eldad Zack
     

29 Apr, 2013

1 commit

  • c75c5ab57   ALSA: USB: adjust for changed 3.8 USB API ... Browse Code »

    The recent changes in the USB API ("implement new semantics for
    URB_ISO_ASAP") made the former meaning of the URB_ISO_ASAP flag the
    default, and changed this flag to mean that URBs can be delayed.
    This is not the behaviour wanted by any of the audio drivers because
    it leads to discontinuous playback with very small period sizes.
    Therefore, our URBs need to be submitted without this flag.

    Reported-by: Joe Rayhawk
    Cc: # 3.8 only
    Signed-off-by: Clemens Ladisch
    Signed-off-by: Takashi Iwai

    Clemens Ladisch
     

07 Mar, 2013

1 commit

  • 2dad94021   ALSA: snd-usb-caiaq: fix smatch warnings ... Browse Code »

    Fix three smatch warnings recently introduced:

    sound/usb/caiaq/device.c:166 usb_ep1_command_reply_dispatch() warn:
    variable dereferenced before check 'cdev' (see line 163)
    sound/usb/caiaq/device.c:517 snd_disconnect() warn: variable
    dereferenced before check 'card' (see line 514)
    sound/usb/caiaq/input.c:510 snd_usb_caiaq_ep4_reply_dispatch() warn:
    variable dereferenced before check 'cdev' (see line 506)

    Signed-off-by: Daniel Mack
    Reported-by: Dan Carpenter
    Signed-off-by: Takashi Iwai

    Daniel Mack
     

04 Mar, 2013

2 commits

29 Jan, 2013

1 commit

07 Dec, 2012

1 commit

27 Jun, 2012

1 commit

  • da185443c   ALSA: snd-usb-caiaq: initialize card pointer ... Browse Code »

    Fixes the following warning:

    CC [M] sound/usb/caiaq/device.o
    sound/usb/caiaq/device.c: In function ‘snd_probe’:
    sound/usb/caiaq/device.c:500:16: warning: ‘card’ may be used
    uninitialized in this function [-Wmaybe-uninitialized]

    Signed-off-by: Daniel Mack
    Signed-off-by: Takashi Iwai

    Daniel Mack
     

22 Feb, 2012

1 commit

  • cb74eb15a   ALSA: snd-usb-caiaq: Fix the return of XRUN ... Browse Code »

    Commit 3702b08 added a lock, but did not account for the case of
    SNDRV_PCM_POS_XRUN, which would get immediately overwritten.

    This could be bundled into one if-else-if statement, but the goto
    helps to clarify the 'exceptional' case.

    Thanks to Andreas Pape for spotting this.

    Signed-off-by: Mark Hills
    Acked-by: Daniel Mack
    Signed-off-by: Takashi Iwai

    Mark Hills
     

13 Jan, 2012

1 commit

  • a429638ca   Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound ... Browse Code »

    * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound: (526 commits)
    ASoC: twl6040 - Add method to query optimum PDM_DL1 gain
    ALSA: hda - Fix the lost power-setup of seconary pins after PM resume
    ALSA: usb-audio: add Yamaha MOX6/MOX8 support
    ALSA: virtuoso: add S/PDIF input support for all Xonars
    ALSA: ice1724 - Support for ooAoo SQ210a
    ALSA: ice1724 - Allow card info based on model only
    ALSA: ice1724 - Create capture pcm only for ADC-enabled configurations
    ALSA: hdspm - Provide unique driver id based on card serial
    ASoC: Dynamically allocate the rtd device for a non-empty release()
    ASoC: Fix recursive dependency due to select ATMEL_SSC in SND_ATMEL_SOC_SSC
    ALSA: hda - Fix the detection of "Loopback Mixing" control for VIA codecs
    ALSA: hda - Return the error from get_wcaps_type() for invalid NIDs
    ALSA: hda - Use auto-parser for HP laptops with cx20459 codec
    ALSA: asihpi - Fix potential Oops in snd_asihpi_cmode_info()
    ALSA: hdsp - Fix potential Oops in snd_hdsp_info_pref_sync_ref()
    ALSA: hda/cirrus - support for iMac12,2 model
    ASoC: cx20442: add bias control over a platform provided regulator
    ALSA: usb-audio - Avoid flood of frame-active debug messages
    ALSA: snd-usb-us122l: Delete calls to preempt_disable
    mfd: Put WM8994 into cache only mode when suspending
    ...

    Fix up trivial conflicts in:
    - arch/arm/mach-s3c64xx/mach-crag6410.c:
    renamed speyside_wm8962 to tobermory, added littlemill right
    next to it
    - drivers/base/regmap/{regcache.c,regmap.c}:
    duplicate diff that had already come in with other changes in
    the regmap tree

    Linus Torvalds
     

19 Dec, 2011

1 commit

  • a67ff6a54   ALSA: module_param: make bool parameters really bool ... Browse Code »

    module_param(bool) used to counter-intuitively take an int. In
    fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
    trick.

    It's time to remove the int/unsigned int option. For this version
    it'll simply give a warning, but it'll break next kernel version.

    Signed-off-by: Rusty Russell
    Signed-off-by: Takashi Iwai

    Rusty Russell
     

19 Nov, 2011

1 commit

  • 424f0750e   USB: convert sound/* to use module_usb_driver() ... Browse Code »

    This converts the drivers in sound/* to use the
    module_usb_driver() macro which makes the code smaller and a bit
    simpler.

    Added bonus is that it removes some unneeded kernel log messages about
    drivers loading and/or unloading.

    Cc: Jaroslav Kysela
    Cc: Takashi Iwai
    Cc: Daniel Mack
    Cc: Clemens Ladisch
    Cc: Torsten Schenk
    Cc: Paul Gortmaker
    Cc: Karsten Wiese
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

13 Oct, 2011

2 commits

  • e653510a2   ALSA: snd-usb-caiaq: Add support for Maschine ... Browse Code »

    This adds partial support for the Maschine controller by Native Instruments.
    Supported now are the 1x1 MIDI interface and the 41 buttons, 11 endless
    rotary encoders, and 16 pressure-sensitive drum pads. Still to work on are the
    dimmable LEDs and the two monochrome screens.

    Signed-off-by: William Light
    Signed-off-by: Takashi Iwai

    William Light
     
  • 3d37fbe44   ALSA: snd-usb-caiaq: Fix NULL dereference in input.c ... Browse Code »

    There was a case where a newly-registered input device could be opened before
    a necessary variable in the device structure was set. When code tried to use
    the variable in the URB reply callback, it would cause an Oops.

    This fix sets the aforementioned variable before calling input_register_device.

    Signed-off-by: William Light
    Signed-off-by: Takashi Iwai

    William Light
     

15 Aug, 2011

1 commit

  • da6094ea7   ALSA: snd_usb_caiaq: track submitted output urbs ... Browse Code »
    1

    The snd_usb_caiaq driver currently assumes that output urbs are serviced
    in time and doesn't track when and whether they are given back by the
    USB core. That usually works fine, but due to temporary limitations of
    the XHCI stack, we faced that urbs were submitted more than once with
    this approach.

    As it's no good practice to fire and forget urbs anyway, this patch
    introduces a proper bit mask to track which requests have been submitted
    and given back.

    That alone however doesn't make the driver work in case the host
    controller is broken and doesn't give back urbs at all, and the output
    stream will stop once all pre-allocated output urbs are consumed. But
    it does prevent crashes of the controller stack in such cases.

    See http://bugzilla.kernel.org/show_bug.cgi?id=40702 for more details.

    Signed-off-by: Daniel Mack
    Reported-and-tested-by: Matej Laitl
    Cc: Sarah Sharp
    Cc: stable@kernel.org
    Signed-off-by: Takashi Iwai

    Daniel Mack
     

11 Aug, 2011

1 commit

  • 15439bde3   ALSA: snd-usb-caiaq: Correct offset fields of outbound iso_frame_desc ... Browse Code »
    1

    This fixes faulty outbount packets in case the inbound packets
    received from the hardware are fragmented and contain bogus input
    iso frames. The bug has been there for ages, but for some strange
    reasons, it was only triggered by newer machines in 64bit mode.

    Signed-off-by: Daniel Mack
    Reported-and-tested-by: William Light
    Reported-by: Pedro Ribeiro
    Cc: stable@kernel.org
    Signed-off-by: Takashi Iwai

    Daniel Mack
     

06 Aug, 2011

1 commit

11 Mar, 2011

1 commit

15 Feb, 2011

2 commits

10 Sep, 2010

2 commits

30 May, 2010

4 commits

26 May, 2010

1 commit

16 Apr, 2010

1 commit

30 Mar, 2010

2 commits

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     
  • 7b7b90422   ALSA: usb - update gfp/slab.h includes ... Browse Code »

    Implicit slab.h inclusion via percpu.h is about to go away. Make sure
    gfp.h or slab.h is included as necessary.

    Signed-off-by: Tejun Heo
    Signed-off-by: Takashi Iwai

    Tejun Heo