02 Nov, 2010

1 commit

  • "gadget", "through", "command", "maintain", "maintain", "controller", "address",
    "between", "initiali[zs]e", "instead", "function", "select", "already",
    "equal", "access", "management", "hierarchy", "registration", "interest",
    "relative", "memory", "offset", "already",

    Signed-off-by: Uwe Kleine-König
    Signed-off-by: Jiri Kosina

    Uwe Kleine-König
     

08 May, 2010

1 commit


23 Apr, 2010

1 commit

  • The hardware volume handling code in essence just detects key presses, and
    then does some hardcoded modification of the master volume based on which key
    is pressed.

    Clearly the right thing to do here is just report these keypresses to
    userspace and let userspace decide what to with them.

    This patch adds a Kconfig option which when enabled reports the volume
    buttons as keypresses using an input device. When enabled this option
    also gets rid of the ugly direct ac97 writes from the tasklet, the ac97lock
    and the need for using a tasklet in general.

    Signed-off-by: Hans de Goede
    Signed-off-by: Takashi Iwai

    Hans de Goede
     

09 Feb, 2010

1 commit


07 Apr, 2009

1 commit


12 Jan, 2009

1 commit


18 Dec, 2008

1 commit


13 Aug, 2008

1 commit


24 Apr, 2008

4 commits

  • free_irq() calls synchronize_irq() for you, so there is no need for
    drivers to manually do the same thing (again). Thus, calls where
    sync-irq immediately precedes free-irq can be simplified.

    However, during this audit several bugs were noticed, where free-irq is
    preceded by a "irq >= 0" check... but the sync-irq call is not covered
    by the same check.

    So, where sync-irq could not be eliminated completely, the missing check
    was added.

    Signed-off-by: Jeff Garzik
    Signed-off-by: Takashi Iwai

    Jeff Garzik
     
  • WARNING: braces {} are not necessary for single statement blocks
    #40: FILE: sound/pci/es1968.c:1831:
    + if (diff > 1) {
    + __maestro_write(chip, IDR0_DATA_PORT, cp1);
    + }

    total: 0 errors, 1 warnings, 35 lines checked

    ./patches/es1968-fix-jitter-on-some-maestro-cards.patch has style problems, please review. If any of these errors
    are false positives report them to the maintainer, see
    CHECKPATCH in MAINTAINERS.

    Please run checkpatch prior to sending patches

    Cc: Andreas Mueller
    Tested-by: Rene Herman
    Signed-off-by: Andrew Morton
    Signed-off-by: Takashi Iwai

    Andrew Morton
     
  • This patch suppresses jitter on several Maestro cards in stereo mode (ALSA of
    course).

    The patch is also incorporated in the *BSD drivers where I "ported" it from.

    Without this patch most of the stereo audio gets out of sync and really
    distorted (oss-emulation with mplayer at 48000khz worked somehow).

    Signed-off-by: Andrew Morton
    Signed-off-by: Takashi Iwai

    Andreas Mueller
     
  • id is used when initializing the mixer elements, use elem_id here
    instead.
    sound/pci/es1968.c:1963:25: warning: symbol 'id' shadows an earlier one
    sound/pci/es1968.c:129:13: originally declared here

    Signed-off-by: Harvey Harrison
    Signed-off-by: Takashi Iwai

    Harvey Harrison
     

09 Apr, 2008

1 commit

  • snd_es1968_ac97_read() calls snd_es1968_ac97_wait() first outside a locked
    area, and later, while holding a lock.

    snd_es1968_ac97_wait() has a polling loop with a cond_resched() inside it..
    which sleeps, so the second call is invalid.

    This patch adds a version of the wait function that just pure polls. While
    this is not very elegant in principle, it's very likely the easiest thing to
    do here, we already checked if the chip was ready (while yielding) just
    before, so it is very unlikely to take a long time here.

    [akpm@linux-foundation.org: coding-style fixes]
    Signed-off-by: Arjan van de Ven
    Cc: Jaroslav Kysela
    Cc: Takashi Iwai
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Arjan van de Ven
     

01 Feb, 2008

1 commit

  • This header file exists only for some hacks to adapt alsa-driver
    tree. It's useless for building in the kernel. Let's move a few
    lines in it to sound/core.h and remove it.
    With this patch, sound/driver.h isn't removed but has just a single
    compile warning to include it. This should be really killed in
    future.

    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Takashi Iwai
     

16 Oct, 2007

1 commit


11 May, 2007

1 commit

  • Looks like the buffer size for the stereo capture has to be a
    power of two. Now added a constraint to buffer bytes.
    Also removed unnecessary #if 0 lines.

    Signed-off-by: Rene Herman
    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Rene Herman
     

20 Dec, 2006

2 commits


22 Oct, 2006

1 commit

  • - Check the return value of pci_enable_device() and request_irq()
    in the suspend. If any error occurs there, disable the device
    using snd_card_disconnect().
    - Call pci_set_power_state() properly with pci_choose_state().
    - Fix the order to call pci_set_power_state().
    - Removed obsolete house-made PM codes in some drivers.

    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Takashi Iwai
     

05 Oct, 2006

1 commit

  • Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

23 Sep, 2006

1 commit


13 Jul, 2006

1 commit


03 Jul, 2006

1 commit


23 Jun, 2006

2 commits


28 Apr, 2006

2 commits


29 Mar, 2006

1 commit


22 Mar, 2006

2 commits


15 Jan, 2006

1 commit


03 Jan, 2006

3 commits


11 Nov, 2005

1 commit


04 Nov, 2005

2 commits


12 Sep, 2005

3 commits

  • AD1889 driver,ALS4000 driver,ATIIXP driver,ATIIXP-modem driver
    AZT3328 driver,BT87x driver,CMIPCI driver,CS4281 driver
    ENS1370/1+ driver,ES1938 driver,ES1968 driver,FM801 driver
    Intel8x0 driver,Intel8x0-modem driver,Maestro3 driver,RME32 driver
    RME96 driver,SonicVibes driver,VIA82xx driver,VIA82xx-modem driver
    ALI5451 driver,au88x0 driver,CS46xx driver,EMU10K1/EMU10K2 driver
    HDA Intel driver,ICE1712 driver,ICE1724 driver,KORG1212 driver
    MIXART driver,NM256 driver,RME HDSP driver,RME9652 driver
    Trident driver,Digigram VX222 driver,YMFPCI driver
    Set the module owner field in each driver's struct pci_driver to get
    the driver symlink in the sysfs device directory.

    Signed-off-by: Clemens Ladisch

    Clemens Ladisch
     
  • AD1889 driver,ATIIXP driver,ATIIXP-modem driver,AZT3328 driver
    BT87x driver,CMIPCI driver,CS4281 driver,ENS1370/1+ driver
    ES1938 driver,ES1968 driver,FM801 driver,Intel8x0 driver
    Intel8x0-modem driver,Maestro3 driver,SonicVibes driver,VIA82xx driver
    VIA82xx-modem driver,AC97 Codec,AK4531 codec,au88x0 driver
    CA0106 driver,CS46xx driver,EMU10K1/EMU10K2 driver,HDA Codec driver
    HDA generic driver,HDA Intel driver,ICE1712 driver,ICE1724 driver
    KORG1212 driver,MIXART driver,NM256 driver,Trident driver,YMFPCI driver
    Replace kcalloc(1,..) with kzalloc().

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     
  • CS46xx driver,EMU10K1/EMU10K2 driver,PCM Midlevel,Trident driver
    YMFPCI driver,BT87x driver,CMIPCI driver,CS4281 driver
    ENS1370/1+ driver,ES1938 driver,ES1968 driver,Intel8x0 driver
    Intel8x0-modem driver,Maestro3 driver,RME32 driver,RME96 driver
    SonicVibes driver,VIA82xx driver,ALI5451 driver,ICE1712 driver
    ICE1724 driver,NM256 driver,RME HDSP driver,RME9652 driver
    Remove superfluous PCI ID definitions.

    Signed-off-by: Takashi Iwai

    Takashi Iwai