19 May, 2012

1 commit

• 96facd23e   smb347-charger: Include missing <linux/err.h> ... Browse Code »

  Without the include we get build errors like:

  drivers/power/smb347-charger.c: In function 'smb347_probe':
  drivers/power/smb347-charger.c:1039:2: error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration]
  drivers/power/smb347-charger.c:1040:3: error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration]

  Reported-by: Stephen Rothwell
  Signed-off-by: Mika Westerberg
  Signed-off-by: Anton Vorontsov

  Mika Westerberg

  2012-05-19 08:15:48 +0800  

06 May, 2012

1 commit

• fcc015cda   smb347-charger: Clean up battery attributes ... Browse Code »

  CURRENT_NOW and VOLTAGE_NOW should be instantaneous readings
  from power supply(ex: battery).

  smb347 charger driver reports charge voltage for VOLTAGE_NOW
  and charge current for CURRENT_NOW attributes which are not
  instantaneous readings.

  This patch removes the battery VOLTAGE_NOW and CURRENT_NOW
  properties from the driver and also removes hw_to_current()
  which is not required anymore.

  Signed-off-by: Ramakrishna Pallala
  Acked-by: Mika Westerberg
  Signed-off-by: Anton Vorontsov

  Ramakrishna Pallala

  2012-05-06 19:46:18 +0800  

05 May, 2012

5 commits

• 34298d40e   smb347-charger: Convert to regmap API ... Browse Code »

  The smb347-charger driver does a lot of read-modify-write to the device
  registers. Instead of open-coding everything we can take advantage of
  regmap API which provides nice functions to do this kind of things.

  In addition there is no need for custom debugfs file for dumping
  registers as this is already provided by the regmap API.

  Signed-off-by: Mika Westerberg
  Signed-off-by: Anton Vorontsov

  Mika Westerberg

  2012-05-05 20:48:17 +0800  
• d72bade76   smb347-charger: Move IRQ enabling to the end of probe ... Browse Code »

  There is a potential problem if we call smb347_irq_enable() from
  smb347_irq_init() because smb347_irq_enable() makes the device registers
  read-only once it returns and smb347_irq_init() expects them to still be
  read-write. Currently no harm happens because it is the last call we make
  in smb347_irq_init().

  Anyway a better place for enabling IRQs is at the end of probe function
  and this is also symmetric to call smb347_irq_disable() which is done at
  the beginning of remove function.

  Signed-off-by: Mika Westerberg
  Signed-off-by: Anton Vorontsov

  Mika Westerberg

  2012-05-05 20:35:47 +0800  
• 055d7f0f2   smb347-charger: Rename few functions to match better what they are doing ... Browse Code »

  The naming used in the driver for some functions is not very clear what
  the functions are really doing. To make this a bit easier to understand
  we rename few functions which were badly named.

  Signed-off-by: Mika Westerberg
  Signed-off-by: Anton Vorontsov

  Mika Westerberg

  2012-05-05 20:35:22 +0800  
• b75ef1d80   smb347-charger: Convert to use module_i2c_driver() ... Browse Code »

  This reduces the amount of boilerplate code in the driver and
  makes it a bit simpler.

  Signed-off-by: Mika Westerberg
  Signed-off-by: Anton Vorontsov

  Mika Westerberg

  2012-05-05 20:34:56 +0800  
• e6fe3597f   smb347_charger: Cleanup power supply registration code in probe ... Browse Code »

  This patch checks if the usb or mains charging is enabled by the
  platform before registering with the power supply class.

  Signed-off-by: Ramakrishna Pallala
  Signed-off-by: Anton Vorontsov

  Ramakrishna Pallala

  2012-05-05 20:29:00 +0800  

27 Mar, 2012

1 commit

• ed1a230f9   Add I2C driver for Summit Microelectronics SMB347 Battery Charger. ... Browse Code »

  Driver support for the Summit I²C battery charger. This is used in some
  Intel devices.

  Signed-off-by: Bruce E. Robertson
  Signed-off-by: Alan Cox
  Signed-off-by: Anton Vorontsov

  Bruce E. Robertson

  2012-03-27 00:41:01 +0800