27 Jan, 2015
1 commit
-
Convert a call to init_timer and accompanying intializations of
the timer's data and function fields to a call to setup_timer.A simplified version of the semantic match that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)//
@@
expression t,f,d;
@@-init_timer(&t);
+setup_timer(&t,f,d);
-t.function = f;
-t.data = d;
//Signed-off-by: Julia Lawall
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab
12 Dec, 2014
1 commit
-
Pull media updates from Mauro Carvalho Chehab:
- Two new dvb frontend drivers: mn88472 and mn88473
- A new driver for some PCIe DVBSky cards
- A new remote controller driver: meson-ir
- One LIRC staging driver got rewritten and promoted to mainstream:
igorplugusb
- A new tuner driver (m88rs6000t)
- The old omap2 media driver got removed from staging. This driver
uses an old DMA API and it is likely broken on recent kernels.
Nobody cared enough to fix it
- Media bus format moved to a separate header, as DRM will also use the
definitions there
- mem2mem_testdev were renamed to vim2m, in order to use the same
naming convention taken by the other virtual test driver (vivid)
- Added a new driver for coda SoC (coda-jpeg)
- The cx88 driver got converted to use videobuf2 core
- Make DMABUF export buffer to work with DMA Scatter/Gather and Vmalloc
cores
- Lots of other fixes, improvements and cleanups on the drivers.* tag 'media/v3.19-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media: (384 commits)
[media] mn88473: One function call less in mn88473_init() after error
[media] mn88473: Remove uneeded check before release_firmware()
[media] lirc_zilog: Deletion of unnecessary checks before vfree()
[media] MAINTAINERS: Add myself as img-ir maintainer
[media] img-ir: Don't set driver's module owner
[media] img-ir: Depend on METAG or MIPS or COMPILE_TEST
[media] img-ir/hw: Drop [un]register_decoder declarations
[media] img-ir/hw: Fix potential deadlock stopping timer
[media] img-ir/hw: Always read data to clear buffer
[media] redrat3: ensure dma is setup properly
[media] ddbridge: remove unneeded check before dvb_unregister_device()
[media] si2157: One function call less in si2157_init() after error
[media] tuners: remove uneeded checks before release_firmware()
[media] arm: omap2: rx51-peripherals: fix build warning
[media] stv090x: add an extra protetion against buffer overflow
[media] stv090x: Remove an unreachable code
[media] stv090x: Some whitespace cleanups
[media] em28xx: checkpatch cleanup: whitespaces/new lines cleanups
[media] si2168: add support for firmware files in new format
[media] si2168: debug printout for firmware version
...
25 Nov, 2014
1 commit
-
GIT_AUTHOR_DATE=1416486805
The functions pvr2_hdw_destroy(), rc_unregister_device() and vfree() perform
also input parameter validation. Thus the test around the call is not needed.This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
Signed-off-by: Mauro Carvalho Chehab
22 Nov, 2014
1 commit
-
length is the size of the buffer, not the payload. That's set using
vb2_set_plane_payload().Signed-off-by: Dean Anderson
Cc: # for v3.15 and up
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab
11 Nov, 2014
1 commit
-
qlock spinlock controls access to buf_list and sequence.
qlock spinlock should not be locked during a copy to video buffers, an
operation that may sleep.Signed-off-by: Dean Anderson
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab
03 Sep, 2014
1 commit
-
drivers/media/usb/s2255/s2255drv.c:2248:20: warning: cast to restricted __le16
At the USB structs there are two different idProduct:
usb_device_id::idProduct - already on CPU endiannes
usb_device::descriptor.idProduct - with is LE16In this specific case, the driver checks for the one at usb_device_id
struct, with already have CPU endianness. So, no conversion is required.Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab
05 Jul, 2014
1 commit
-
Since all the drivers that use `struct v4l2_fh' use the core
priority checking, the setting of the flag in the drivers can
be removed.Signed-off-by: Ramakrishnan Muthukrishnan
Reviewed-by: Hans Verkuil
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab
23 May, 2014
2 commits
-
smatch says:
drivers/media/usb/s2255/s2255drv.c:2246 s2255_probe() warn:
possible memory leak of 'dev'Signed-off-by: Daeseok Youn
Acked-by: Sakari Ailus
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Function del_timer() does not guarantee that timer was really deleted.
If the timer handler is beeing executed at the moment, the function
does nothing. So, we have a race between del_timer() and kfree(), and
it's possible to use already freed memory in the handler.Signed-off-by: Kirill Tkhai
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab
23 Apr, 2014
1 commit
-
The vb2 core ignores any return code from the stop_streaming op.
And there really isn't anything it can do anyway in case of an error.
So change the return type to void and update any drivers that implement it.The int return gave drivers the idea that this operation could actually
fail, but that's really not the case.The pwc amd sdr-msi3101 drivers both had this construction:
if (mutex_lock_interruptible(&s->v4l2_lock))
return -ERESTARTSYS;This has been updated to just call mutex_lock(). The stop_streaming op
expects this to really stop streaming and I very much doubt this will
work reliably if stop_streaming just returns without really stopping the
DMA.Signed-off-by: Hans Verkuil
Acked-by: Pawel Osciak
Acked-by: Sakari Ailus
Signed-off-by: Mauro Carvalho Chehab
25 Mar, 2014
1 commit
-
commit 340a30c514 "s2255drv: upgrade to videobuf2" changed the API
used by the s2255 driver, but did not modify the Kconfig statement,
which can lead to build errors when no other driver already uses
VIDEOBUF2_VMALLOC. This patch does the necessary Kconfig change.Signed-off-by: Arnd Bergmann
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab
11 Mar, 2014
1 commit
-
Fixes memory leak introduced by
commit 47d8c881c304642a68d398b87d9e8846e643c81a.Signed-off-by: Dean Anderson
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab
06 Mar, 2014
1 commit
-
The timestamp_type field used to contain only the timestamp type. Soon it
will be used for timestamp source flags as well. Rename the field
accordingly.[m.chehab@samsung.com: do the change also to drivers/staging/media and at s2255]
Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab
01 Mar, 2014
8 commits
-
Upgrade to videobuf2 libraries.
No errors reported with "v4l2-compliance -s".Signed-off-by: Dean Anderson
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Removal of unnecessary parameters from s2255_fh.
Signed-off-by: Dean Anderson
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Start acquisition return code was not being checked. Return error
if start acquisition fails.Signed-off-by: Dean Anderson
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Driver was allocating a kernel buffer each time it was sending a command.
It is better to allocate this buffer once at startup.Signed-off-by: Dean Anderson
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Removing duplicate fmt from buffer structure.
Signed-off-by: Dean Anderson
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Buffer setup should check if minimum number of buffers is used.
Signed-off-by: Dean Anderson
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Renaming s2255_channel and all instances of channel to vc (video channel).
Signed-off-by: Dean Anderson
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Removal of unused and unnecessary s2255dma_queue structure.
Signed-off-by: Dean Anderson
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab
04 Feb, 2014
1 commit
-
Fixes all style warnings from scripts/checkpatch -f
Signed-off-by: Dean Anderson
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab
02 Aug, 2013
1 commit
-
Removes unnecessary query of buffer state. The code already checks if stream is active or not.
Signed-off-by: Dean Anderson
Signed-off-by: Mauro Carvalho Chehab
24 Mar, 2013
1 commit
-
This ioctl is defined as IOW, so pass the argument by value instead of by
reference. I could have chosen to add const instead, but this is 1) easier
to handle in drivers and 2) consistent with the s_std subdev operation.Signed-off-by: Hans Verkuil
Acked-by: Laurent Pinchart
Acked-by: Jonathan Corbet
Acked-by: Guennadi Liakhovetski
Acked-by: Lad, Prabhakar
Signed-off-by: Mauro Carvalho Chehab
06 Mar, 2013
11 commits
-
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
The planar YUV422P is quite unusual and few if any applications support it.
Instead choose the common YUYV format as the default.Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
All fields after 'type' are already zeroed by the core framework.
Clearing the full struct also clears 'type', which causes a wrong
type value to be returned.Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Just set the field value based on the chosen format. It's either INTERLACED
or TOP.Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Set priv field of struct v4l2_pix_format to 0 and fill in colorspace.
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Instead of comparing against STD_NTSC and STD_PAL compare against 60 and
50 Hz formats. That's what you really want.
When the standard is changed, make sure the width and height of the format
are also updated to reflect the current standard.
Also replace the deprecated current_norm by the g_std ioctl.Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
The use of the V4L2_CID_JPEG_COMPRESSION_QUALITY control is recommended over
the G/S_JPEGCOMP ioctls.Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab
21 Dec, 2012
1 commit
-
Convert drivers using wall clock time (CLOCK_REALTIME) to timestamp from the
monotonic timer (CLOCK_MONOTONIC).Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab
28 Oct, 2012
1 commit
-
drivers/media/usb/s2255/s2255drv.c:1654:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
Signed-off-by: Mauro Carvalho Chehab
26 Sep, 2012
1 commit
-
Write-only ioctls should have a const argument in the ioctl op.
Do this conversion for vidioc_s_jpegcomp.
Adding const for write-only ioctls was decided during the 2012 Media Workshop.Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab
16 Aug, 2012
2 commits
-
….c}: Remove potential NULL dereferences
If the NULL test is necessary, the initialization involving a dereference of
the tested value should be moved after the NULL test.The sematic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@- T i = E->fld;
+ T i;
... when != E
when != i
if (E == NULL) S
+ i = E->fld;
// </smpl>Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> -
Move the 3 remaining usb drivers to their proper space.
Signed-off-by: Mauro Carvalho Chehab