30 Jun, 2015
1 commit
-
The only caller that cares about its return value can just
as easily pick it from nd->root_seq itself. We used to just
calculate it and return to caller, but these days we are
storing it in nd->root_seq in all cases.Signed-off-by: Al Viro
15 May, 2015
22 commits
-
Signed-off-by: Al Viro
-
these guys are always declared next to each other; might as well put
the former (pointer to previous instance) into the latter and simplify
the calling conventions for {set,restore}_nameidata()Signed-off-by: Al Viro
-
Signed-off-by: Al Viro
-
Signed-off-by: Al Viro
-
now that struct filename is stashed in nameidata we have no need to
pass it inSigned-off-by: Al Viro
-
fewer arguments to pass around...
Signed-off-by: Al Viro
-
they are always called next to each other; moreover,
terminate_walk() is more symmetrical that way.Signed-off-by: Al Viro
-
a) make it reject ERR_PTR() for name
b) make it putname(name) on all other failure exits
c) make it return name on successagain, simplifies the callers
Signed-off-by: Al Viro
-
a) make it reject ERR_PTR() for name
b) make it putname(name) upon return in all other cases.seriously simplifies the callers...
Signed-off-by: Al Viro
-
Signed-off-by: Al Viro
-
makes for much easier life in callers
Signed-off-by: Al Viro
-
pass root instead; non-NULL => copy to nd.root and
set LOOKUP_ROOT in flagsSigned-off-by: Al Viro
-
Signed-off-by: Al Viro
-
Signed-off-by: Al Viro
-
Signed-off-by: Al Viro
-
Otherwise we are risking a hard error where nonlazy restart would be the right
thing to do; it's a very narrow race with mount --move and most of the time it
ends up being completely harmless, but it's possible to construct a case when
we'll get a bogus hard error instead of falling back to non-lazy walk...For one thing, when crossing _into_ overmount of parent we need to check for
mount_lock bumps when we get NULL from __lookup_mnt() as well.For another, and less exotically, we need to make sure that the data fetched
in follow_up_rcu() had been consistent. ->mnt_mountpoint is pinned for as
long as it is a mountpoint, but we need to check mount_lock after fetching
to verify that.Signed-off-by: Al Viro
-
now that we have ->root_seq, legitimize_path(&nd->root, nd->root_seq)
will do just fine...Signed-off-by: Al Viro
-
Signed-off-by: Al Viro
-
Signed-off-by: Al Viro
-
touch_atime is not RCU-safe, and so cannot be called on an RCU walk.
However, in situations where RCU-walk makes a difference, the symlink
will likely to accessed much more often than it is useful to update
the atime.So split out the test of "Does the atime actually need to be updated"
into atime_needs_update(), and have get_link() unlazy if it finds that
it will need to do that update.Signed-off-by: NeilBrown
Signed-off-by: Al Viro -
Signed-off-by: Al Viro
-
We are almost done - primitives for leaving RCU mode are aware of nd->stack
now, a new primitive for going to non-RCU mode when we have a symlink on hands
added.The thing we are heavily relying upon is that *any* unlazy failure will be
shortly followed by terminate_walk(), with no access to nameidata in between.
So it's enough to leave the things in a state terminate_walk() would cope with.Signed-off-by: Al Viro
11 May, 2015
17 commits
-
we'll need them for unlazy_walk()
Signed-off-by: Al Viro
-
We *can't* call that audit garbage in RCU mode - it's doing a weird
mix of allocations (GFP_NOFS, immediately followed by GFP_KERNEL)
and I'm not touching that... thing again.So if this security sclero^Whardening feature gets triggered when
we are in RCU mode, tough - we'll fail with -ECHILD and have
everything restarted in non-RCU mode. Only to hit the same test
and fail, this time with EACCES and with (oh, rapture) an audit spew
produced.Signed-off-by: Al Viro
-
very simple - just make path_put() conditional on !RCU.
Note that right now it doesn't get called in RCU mode -
we leave it before getting anything into stack.Signed-off-by: Al Viro
-
only one instance looks at that argument at all; that sole
exception wants inode rather than dentry.Signed-off-by: Al Viro
-
inode_follow_link now takes an inode and rcu flag as well as the
dentry.inode is used in preference to d_backing_inode(dentry), particularly
in RCU-walk mode.selinux_inode_follow_link() gets dentry_has_perm() and
inode_has_perm() open-coded into it so that it can call
avc_has_perm_flags() in way that is safe if LOOKUP_RCU is set.Calling avc_has_perm_flags() with rcu_read_lock() held means
that when avc_has_perm_noaudit calls avc_compute_av(), the attempt
to rcu_read_unlock() before calling security_compute_av() will not
actually drop the RCU read-lock.However as security_compute_av() is completely in a read_lock()ed
region, it should be safe with the RCU read-lock held.Signed-off-by: NeilBrown
Signed-off-by: Al Viro -
no need to refetch (and once we move unlazy out of there, recheck ->d_seq).
Signed-off-by: Al Viro
-
Make use of d_backing_inode() in pathwalk to gain access to an
inode or dentry that's on a lower layer.Signed-off-by: David Howells
-
Signed-off-by: Al Viro
-
Signed-off-by: Al Viro
-
Signed-off-by: Al Viro
-
Signed-off-by: Al Viro
-
Lift it from link_path_walk(), trailing_symlink(), lookup_last(),
mountpoint_last(), complete_walk() and do_last(). A _lot_ of
those suckers merge.Signed-off-by: Al Viro
-
Make trailing_symlink() return the pathname to traverse or ERR_PTR(-E...).
A subtle point is that for "magic" symlinks it returns "" now - that
leads to link_path_walk("", nd), which is immediately returning 0 and
we are back to the treatment of the last component, at whereever the
damn thing has left us.Reduces the stack footprint - link_path_walk() called on more shallow
stack now.Signed-off-by: Al Viro
-
* lift link_path_walk() into callers; moving it down into path_init()
had been a mistake. Stack footprint, among other things...
* do _not_ call path_cleanup() after path_init() failure; on all failure
exits out of it we have nothing for path_cleanup() to do
* have path_init() return pathname or ERR_PTR(-E...)Signed-off-by: Al Viro
-
we can do fdput() under rcu_read_lock() just fine; all we need to take
care of is fetching nd->inode value first.Signed-off-by: Al Viro
-
new functions: filename_parentat() and path_parentat() resp.
Signed-off-by: Al Viro
-
Signed-off-by: Al Viro
