03 Aug, 2018

6 commits

  • For a sake of code simplification, remove the init and the exit
    entries that do nothing.

    Notes for readers: actually it's OK to remove *both* init and exit,
    but not OK to remove the exit entry. By removing only the exit while
    keeping init, the module becomes permanently loaded; i.e. you cannot
    unload it any longer!

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     
  • Trivial spelling mistake fix in debug message

    Signed-off-by: Colin Ian King
    Signed-off-by: Takashi Iwai

    Colin Ian King
     
  • In preparation to enabling -Wimplicit-fallthrough, mark switch cases
    where we are expecting to fall through.

    Addresses-Coverity-ID: 115075 ("Missing break in switch")
    Signed-off-by: Gustavo A. R. Silva
    Signed-off-by: Takashi Iwai

    Gustavo A. R. Silva
     
  • In preparation to enabling -Wimplicit-fallthrough, mark switch cases
    where we are expecting to fall through.

    Addresses-Coverity-ID: 402016 ("Missing break in switch")
    Addresses-Coverity-ID: 1056542 ("Missing break in switch")
    Addresses-Coverity-ID: 1339579 ("Missing break in switch")
    Addresses-Coverity-ID: 1369526 ("Missing break in switch")
    Addresses-Coverity-ID: 1369529 ("Missing break in switch")
    Signed-off-by: Gustavo A. R. Silva
    Signed-off-by: Takashi Iwai

    Gustavo A. R. Silva
     
  • In preparation to enabling -Wimplicit-fallthrough, mark switch cases
    where we are expecting to fall through.

    Addresses-Coverity-ID: 1165394 ("Missing break in switch")
    Addresses-Coverity-ID: 1167851 ("Missing break in switch")
    Addresses-Coverity-ID: 402015 ("Missing break in switch")
    Signed-off-by: Gustavo A. R. Silva
    Signed-off-by: Takashi Iwai

    Gustavo A. R. Silva
     
  • In preparation to enabling -Wimplicit-fallthrough, mark switch cases
    where we are expecting to fall through.

    Addresses-Coverity-ID: 1468367 ("Missing break in switch")
    Addresses-Coverity-ID: 115037 ("Missing break in switch")
    Addresses-Coverity-ID: 115038 ("Missing break in switch")
    Signed-off-by: Gustavo A. R. Silva
    Signed-off-by: Takashi Iwai

    Gustavo A. R. Silva
     

02 Aug, 2018

1 commit

  • There was a typo of COPY_USER in the dead code (that is disabled
    as default).

    Fixes: 4b83eff81c81 ("ALSA: sb: Convert to the new PCM ops")
    Signed-off-by: Takashi Iwai

    Takashi Iwai
     

27 Jul, 2018

5 commits

  • The data types defined in SB CSP driver code are all in little-endian,
    hence the proper type like __le32 should be used.

    Spotted by sparse, a warning like:
    sound/isa/sb/sb16_csp.c:330:14: warning: cast to restricted __le32

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     
  • The PCM format type is with __bitwise, and it can't be converted from
    integer implicitly. Instead of an ugly cast, declare the function
    argument of snd_sb_csp_autoload() with the proper snd_pcm_format_t
    type.

    This fixes the sparse warnings like:
    sound/isa/sb/sb16_csp.c:743:22: warning: restricted snd_pcm_format_t degrades to integer

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     
  • The PCM format type in snd_pcm_format_t can't be treated as integer
    implicitly since it's with __bitwise. We have already a helper
    function to get the bit index of the given type, and use it in each
    place instead.

    This fixes sparse warnings like:
    sound/isa/sb/sb16_main.c:61:44: warning: restricted snd_pcm_format_t degrades to integer

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     
  • The PCM format type is with __bitwise, and it can't be converted from
    integer implicitly. Instead of an ugly cast, declare the function
    argument of snd_wss_get_format() with the proper snd_pcm_format_t
    type.

    This fixes the sparse warnings like:
    sound/isa/wss/wss_lib.c:551:14: warning: restricted snd_pcm_format_t degrades to integer

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     
  • The PCM format type is with __bitwise, and it can't be converted from
    integer implicitly. Instead of an ugly cast, declare the function
    argument of snd_ad1816a_get_format() with the proper snd_pcm_format_t
    type.

    This fixes the sparse warning like:
    sound/isa/ad1816a/ad1816a_lib.c:93:14: warning: restricted snd_pcm_format_t degrades to integer

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     

26 Jul, 2018

3 commits


17 Jul, 2018

1 commit


16 Jul, 2018

3 commits


26 Jun, 2018

1 commit


08 Jun, 2018

1 commit

  • Pull media updates from Mauro Carvalho Chehab:

    - remove of atomisp driver from staging, as nobody would have time to
    dedicate huge efforts to fix all the problems there. Also, we have a
    feeling that the driver may not even run the way it is.

    - move Zoran driver to staging, in order to be either fixed to use VB2
    and the proper media kAPIs or to be removed

    - remove videobuf-dvb driver, with is unused for a while

    - some V4L2 documentation fixes/improvements

    - new sensor drivers: imx258 and ov7251

    - a new driver was added to allow using I2C transparent drivers

    - several improvements at the ddbridge driver

    - several improvements at the ISDB pt1 driver, making it more coherent
    with the DVB framework

    - added a new platform driver for MIPI CSI-2 RX: cadence

    - now, all media drivers can be compiled on x86 with COMPILE_TEST

    - almost all media drivers now build on non-x86 architectures with
    COMPILE_TEST

    - lots of other random stuff: cleanups, support for new board models,
    bug fixes, etc

    * tag 'media/v4.18-2' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media: (464 commits)
    media: omap2: fix compile-testing with FB_OMAP2=m
    media: media/radio/Kconfig: add back RADIO_ISA
    media: v4l2-ioctl.c: fix missing unlock in __video_do_ioctl()
    media: pxa_camera: ignore -ENOIOCTLCMD from v4l2_subdev_call for s_power
    media: arch: sh: migor: Fix TW9910 PDN gpio
    media: staging: tegra-vde: Reset VDE regardless of memory client resetting failure
    media: marvel-ccic: mmp: select VIDEOBUF2_VMALLOC/DMA_CONTIG
    media: marvel-ccic: allow ccic and mmp drivers to coexist
    media: uvcvideo: Prevent setting unavailable flags
    media: ddbridge: conditionally enable fast TS for stv0910-equipped bridges
    media: dvb-frontends/stv0910: make TS speed configurable
    media: ddbridge/mci: add identifiers to function definition arguments
    media: ddbridge/mci: protect against out-of-bounds array access in stop()
    media: rc: ensure input/lirc device can be opened after register
    media: rc: nuvoton: Keep device enabled during reg init
    media: rc: nuvoton: Keep track of users on CIR enable/disable
    media: rc: nuvoton: Tweak the interrupt enabling dance
    media: uvcvideo: Support realtek's UVC 1.5 device
    media: uvcvideo: Fix driver reference counting
    media: gspca_zc3xx: Enable short exposure times for OV7648
    ...

    Linus Torvalds
     

28 May, 2018

1 commit

  • Convert the S_ symbolic permissions to their octal equivalents as
    using octal and not symbolic permissions is preferred by many as more
    readable.

    see: https://lkml.org/lkml/2016/8/2/1945

    Done with automated conversion via:
    $ ./scripts/checkpatch.pl -f --types=SYMBOLIC_PERMS --fix-inplace

    Miscellanea:

    o Wrapped one multi-line call to a single line

    Signed-off-by: Joe Perches
    Acked-by: Vinod Koul
    Signed-off-by: Takashi Iwai

    Joe Perches
     

02 May, 2018

1 commit


23 Apr, 2018

1 commit


20 Apr, 2018

2 commits

  • Drivers that depend on ISAPNP currently can't be built with
    COMPILE_TEST. However, looking at isapnp.h, there are already
    stubs there to allow drivers to include it even when isa
    PNP is not supported.

    So, remove such dependencies when COMPILE_TEST.

    Acked-by: Takashi Iwai
    Signed-off-by: Mauro Carvalho Chehab

    Mauro Carvalho Chehab
     
  • All sound drivers that don't depend on PNP can be safelly
    build with COMPILE_TEST, as ISA provides function stubs to
    be used for such purposes.

    As a side effect, with this change, the radio-miropcm20
    can now be built outside i386 with COMPILE_TEST.

    It should be noticed that ISAPNP currently depends on ISA.
    So, on drivers that depend on it, we need to add an
    explicit dependency on ISA, at least until another patch
    removes it.

    Acked-by: Takashi Iwai
    Signed-off-by: Mauro Carvalho Chehab

    Mauro Carvalho Chehab
     

29 Nov, 2017

1 commit


13 Nov, 2017

1 commit

  • …e/sound into for-linus

    ASoC: Updates for v4.15

    The biggest thing this release has been the conversion of the AC98 bus
    to the driver model, that's been a long time coming so thanks to Robert
    Jarzmik for his dedication there. Due to there being some AC97 MFD
    there's a few fairly large changes in input and the MFD layer, mainly to
    the wm97xx driver.

    There's also some drivers/drm changes to support the new AMD Stoney
    platform, these are shared with the DRM subsystem and should be being
    merged via both.

    Within the subsystem the overwhelming bulk of the changes is in the
    Intel drivers which continue to need lots of cleanups and fixes, this
    release they've also gained support for their open source firmware.
    There's also some large changs in the core as Morimoto-san continues to
    mirror operations into the component level in preparation for conversion
    of drivers to that.

    - The AC97 bus has finally caught up with the driver model thanks to
    some dedicated and persistent work from Robert Jarzmik.
    - Continued work from Morimoto-san on moving us towards being able to
    use components for everything.
    - Lots of cleanups for the Intel platform code, including support for
    their open source audio firmware.
    - Support for scaling MCLK with sample rate in simple-card.
    - Support for AMD Stoney platform.

    Takashi Iwai
     

02 Nov, 2017

1 commit

  • Many source files in the tree are missing licensing information, which
    makes it harder for compliance tools to determine the correct license.

    By default all files without license information are under the default
    license of the kernel, which is GPL version 2.

    Update the files which contain no license information with the 'GPL-2.0'
    SPDX license identifier. The SPDX identifier is a legally binding
    shorthand, which can be used instead of the full boiler plate text.

    This patch is based on work done by Thomas Gleixner and Kate Stewart and
    Philippe Ombredanne.

    How this work was done:

    Patches were generated and checked against linux-4.14-rc6 for a subset of
    the use cases:
    - file had no licensing information it it.
    - file was a */uapi/* one with no licensing information in it,
    - file was a */uapi/* one with existing licensing information,

    Further patches will be generated in subsequent months to fix up cases
    where non-standard license headers were used, and references to license
    had to be inferred by heuristics based on keywords.

    The analysis to determine which SPDX License Identifier to be applied to
    a file was done in a spreadsheet of side by side results from of the
    output of two independent scanners (ScanCode & Windriver) producing SPDX
    tag:value files created by Philippe Ombredanne. Philippe prepared the
    base worksheet, and did an initial spot review of a few 1000 files.

    The 4.13 kernel was the starting point of the analysis with 60,537 files
    assessed. Kate Stewart did a file by file comparison of the scanner
    results in the spreadsheet to determine which SPDX license identifier(s)
    to be applied to the file. She confirmed any determination that was not
    immediately clear with lawyers working with the Linux Foundation.

    Criteria used to select files for SPDX license identifier tagging was:
    - Files considered eligible had to be source code files.
    - Make and config files were included as candidates if they contained >5
    lines of source
    - File already had some variant of a license header in it (even if
    Reviewed-by: Philippe Ombredanne
    Reviewed-by: Thomas Gleixner
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

25 Oct, 2017

3 commits

  • Currently the SB8 MIDI code sets up the timer object at each time
    before scheduling it at trigger callback, but basically this is
    superfluous once after set up. Also, the code misses the
    del_timer_sync() call that may leave a race condition for
    use-after-free.

    This patch addresses these issues, moving timer_setup() to
    snd_sb8dsp_midi(), and adding the del_timer_sync() call at
    snd_sb8dsp_midi_output_trigger() to make sure.

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     
  • In preparation for unconditionally passing the struct timer_list pointer to
    all timer callbacks, switch to using the new timer_setup() and from_timer()
    to pass the timer pointer explicitly.

    [Re-use the existing chip->midi_substream_output instead of assigning
    a new field to struct snd_sb -- tiwai]

    Signed-off-by: Kees Cook
    Signed-off-by: Takashi Iwai

    Kees Cook
     
  • In preparation for unconditionally passing the struct timer_list pointer to
    all timer callbacks, switch to using the new timer_setup() and from_timer()
    to pass the timer pointer explicitly.

    Signed-off-by: Kees Cook
    Signed-off-by: Takashi Iwai

    Kees Cook
     

17 Aug, 2017

8 commits