19 Nov, 2013

16 commits

  • The problem is that when a thread overrides its default ":%pid" comm, we
    forget to tag the thread comm as overriden. Hence, this overriden comm
    is not inherited on future forks. Fix it.

    Signed-off-by: Frederic Weisbecker
    Tested-by: David Ahern
    Acked-by: Namhyung Kim
    Cc: David Ahern
    Cc: Ingo Molnar
    Cc: Namhyung Kim
    Link: http://lkml.kernel.org/r/20131116010207.GA18855@localhost.localdomain
    Signed-off-by: Arnaldo Carvalho de Melo

    Frederic Weisbecker
     
  • Once we'd freed m->buf, m->count should become zero - we have no valid
    contents reachable via m->buf.

    Reported-by: Charley (Hao Chuan) Chu
    Signed-off-by: Al Viro
    Signed-off-by: Linus Torvalds

    Al Viro
     
  • Pull watchdog changes from Wim Van Sebroeck:
    - addition of MOXA ART watchdog driver (moxart_wdt)
    - addition of CSR SiRFprimaII and SiRFatlasVI watchdog driver
    (sirfsoc_wdt)
    - addition of ralink watchdog driver (rt2880_wdt)
    - various fixes and cleanups (__user annotation, ioctl return codes,
    removal of redundant of_match_ptr, removal of unnecessary
    amba_set_drvdata(), use allocated buffer for usb_control_msg, ...)
    - removal of MODULE_ALIAS_MISCDEV statements
    - watchdog related DT bindings
    - first set of improvements on the w83627hf_wdt driver

    * git://www.linux-watchdog.org/linux-watchdog: (26 commits)
    watchdog: w83627hf: Use helper functions to access superio registers
    watchdog: w83627hf: Enable watchdog device only if not already enabled
    watchdog: w83627hf: Enable watchdog only once
    watchdog: w83627hf: Convert to watchdog infrastructure
    watchdog: omap_wdt: raw read and write endian fix
    watchdog: sirf: don't depend on dummy value of CLOCK_TICK_RATE
    watchdog: pcwd_usb: overflow in usb_pcwd_send_command()
    watchdog: rt2880_wdt: fix return value check in rt288x_wdt_probe()
    watchdog: watchdog_core: Fix a trivial typo
    watchdog: dw: Enable OF support for DW watchdog timer
    watchdog: Get rid of MODULE_ALIAS_MISCDEV statements
    watchdog: ts72xx_wdt: Propagate return value from timeout_to_regval
    watchdog: pcwd_usb: Use allocated buffer for usb_control_msg
    watchdog: sp805_wdt: Remove unnecessary amba_set_drvdata()
    watchdog: sirf: add watchdog driver of CSR SiRFprimaII and SiRFatlasVI
    watchdog: Remove redundant of_match_ptr
    watchdog: ts72xx_wdt: cleanup return codes in ioctl
    documentation/devicetree: Move DT bindings from gpio to watchdog
    watchdog: add ralink watchdog driver
    watchdog: Add MOXA ART watchdog driver
    ...

    Linus Torvalds
     
  • Pull i2c changes from Wolfram Sang:
    - new drivers for exynos5, bcm kona, and st micro
    - bigger overhauls for drivers mxs and rcar
    - typical driver bugfixes, cleanups, improvements
    - got rid of the superfluous 'driver' member in i2c_client struct This
    touches a few drivers in other subsystems. All acked.

    * 'i2c/for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux: (38 commits)
    i2c: bcm-kona: fix error return code in bcm_kona_i2c_probe()
    i2c: i2c-eg20t: do not print error message in syslog if no ACK received
    i2c: bcm-kona: Introduce Broadcom I2C Driver
    i2c: cbus-gpio: Fix device tree binding
    i2c: wmt: add missing clk_disable_unprepare() on error
    i2c: designware: add new ACPI IDs
    i2c: i801: Add Device IDs for Intel Wildcat Point-LP PCH
    i2c: exynos5: Remove incorrect clk_disable_unprepare
    i2c: i2c-st: Add ST I2C controller
    i2c: exynos5: add High Speed I2C controller driver
    i2c: rcar: fixup rcar type naming
    i2c: scmi: remove some bogus NULL checks
    i2c: sh_mobile & rcar: Enable the driver on all ARM platforms
    i2c: sh_mobile: Convert to clk_prepare/unprepare
    i2c: mux: gpio: use reg value for i2c_add_mux_adapter
    i2c: mux: gpio: use gpio_set_value_cansleep()
    i2c: Include linux/of.h header
    i2c: mxs: Fix PIO mode on i.MX23
    i2c: mxs: Rework the PIO mode operation
    i2c: mxs: distinguish i.MX23 and i.MX28 based I2C controller
    ...

    Linus Torvalds
     
  • Pull infiniband/rdma updates from Roland Dreier:
    - Re-enable flow steering verbs with new improved userspace ABI
    - Fixes for slow connection due to GID lookup scalability
    - IPoIB fixes
    - Many fixes to HW drivers including mlx4, mlx5, ocrdma and qib
    - Further improvements to SRP error handling
    - Add new transport type for Cisco usNIC

    * tag 'rdma-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband: (66 commits)
    IB/core: Re-enable create_flow/destroy_flow uverbs
    IB/core: extended command: an improved infrastructure for uverbs commands
    IB/core: Remove ib_uverbs_flow_spec structure from userspace
    IB/core: Use a common header for uverbs flow_specs
    IB/core: Make uverbs flow structure use names like verbs ones
    IB/core: Rename 'flow' structs to match other uverbs structs
    IB/core: clarify overflow/underflow checks on ib_create/destroy_flow
    IB/ucma: Convert use of typedef ctl_table to struct ctl_table
    IB/cm: Convert to using idr_alloc_cyclic()
    IB/mlx5: Fix page shift in create CQ for userspace
    IB/mlx4: Fix device max capabilities check
    IB/mlx5: Fix list_del of empty list
    IB/mlx5: Remove dead code
    IB/core: Encorce MR access rights rules on kernel consumers
    IB/mlx4: Fix endless loop in resize CQ
    RDMA/cma: Remove unused argument and minor dead code
    RDMA/ucma: Discard events for IDs not yet claimed by user space
    IB/core: Add Cisco usNIC rdma node and transport types
    RDMA/nes: Remove self-assignment from nes_query_qp()
    IB/srp: Report receive errors correctly
    ...

    Linus Torvalds
     
  • Pull battery updates from Anton Vorontsov:
    "Highlights:
    - A new driver for TI BQ24735 Battery Chargers, courtesy of NVidia.
    - Device tree bindings for TWL4030 chips.
    - Random fixes and cleanups"

    * tag 'for-v3.13' of git://git.infradead.org/battery-2.6:
    pm2301-charger: Remove unneeded NULL checks
    twl4030_charger: Add devicetree support
    power_supply: Fix documentation for TEMP_*ALERT* properties
    max17042_battery: Support regmap to access device's registers
    max17042_battery: Use SIMPLE_DEV_PM_OPS
    charger-manager : Replace kzalloc to devm_kzalloc and remove uneccessary code
    bq2415x_charger: Fix max battery regulation voltage
    tps65090-charger: Use "IS_ENABLED(CONFIG_OF)" for DT code
    tps65090-charger: Drop devm_free_irq of devm_ allocated irq
    power_supply: Add support for bq24735 charger
    pm2301-charger: Staticize pm2xxx_charger_die_therm_mngt
    pm2301-charger: Check return value of regulator_enable
    ab8500-charger: Remove redundant break
    ab8500-charger: Check return value of regulator_enable
    isp1704_charger: Fix driver to work with changes introduced in v3.5

    Linus Torvalds
     
  • …/kernel/git/mchehab/linux-media

    Pull media build fixes from Mauro Carvalho Chehab:
    "A series of patches that fix compilation on non-x86 archs.

    While most of them are just build fixes, there are some fixes for real
    bugs, as there are a number of drivers using dynamic stack allocation.
    A few of those might be considered a security risk, if the i2c-dev
    module is loaded, as someone could be sending very long I2C data that
    could potentially overflow the Kernel stack. Ok, as using /dev/i2c-*
    devnodes usually requires root on usual distros, and exploiting it
    would require a DVB board or USB stick, the risk is not high"

    * 'topic/kbuild-fixes-for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media: (28 commits)
    [media] platform drivers: Fix build on frv arch
    [media] lirc_zilog: Don't use dynamic static allocation
    [media] mxl111sf: Don't use dynamic static allocation
    [media] af9035: Don't use dynamic static allocation
    [media] af9015: Don't use dynamic static allocation
    [media] dw2102: Don't use dynamic static allocation
    [media] dibusb-common: Don't use dynamic static allocation
    [media] cxusb: Don't use dynamic static allocation
    [media] v4l2-async: Don't use dynamic static allocation
    [media] cimax2: Don't use dynamic static allocation
    [media] tuner-xc2028: Don't use dynamic static allocation
    [media] tuners: Don't use dynamic static allocation
    [media] av7110_hw: Don't use dynamic static allocation
    [media] stv090x: Don't use dynamic static allocation
    [media] stv0367: Don't use dynamic static allocation
    [media] stb0899_drv: Don't use dynamic static allocation
    [media] dvb-frontends: Don't use dynamic static allocation
    [media] dvb-frontends: Don't use dynamic static allocation
    [media] s5h1420: Don't use dynamic static allocation
    [media] uvc/lirc_serial: Fix some warnings on parisc arch
    ...

    Linus Torvalds
     
  • Pull media updates from Mauro Carvalho Chehab:
    "This series include:
    - a new Remote Controller driver for ST SoC with the corresponding DT
    bindings
    - a new frontend (cx24117)
    - a new I2C camera flash driver (lm3560)
    - a new mem2mem driver for TI SoC (ti-vpe)
    - support for Raphael r828d added to r820t driver
    - some improvements on buffer allocation at VB2 core
    - usual driver fixes and improvements

    PS this time, we have a smaller number of patches. While it is hard
    to pinpoint to the reasons, I believe that it is mainly due to:

    1) there are several patch series ready, but depending on DT review.
    I decided to grant some extra time for DT maintainers to look on
    it, as they're expecting to have more time with the changes agreed
    during ARM mini-summit and KS. If they can't review in time for
    3.14, I'll review myself and apply for the next merge window.

    2) I suspect that having both LinuxCon EU and LinuxCon NA happening
    during the same merge window affected the development
    productivity, as several core media developers participated on
    both events"

    * 'v4l_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media: (151 commits)
    [media] media: st-rc: Add ST remote control driver
    [media] gpio-ir-recv: Include linux/of.h header
    [media] tvp7002: Include linux/of.h header
    [media] tvp514x: Include linux/of.h header
    [media] ths8200: Include linux/of.h header
    [media] adv7343: Include linux/of.h header
    [media] v4l: Fix typo in v4l2_subdev_get_try_crop()
    [media] media: i2c: add driver for dual LED Flash, lm3560
    [media] rtl28xxu: add 15f4:0131 Astrometa DVB-T2
    [media] rtl28xxu: add RTL2832P + R828D support
    [media] rtl2832: add new tuner R828D
    [media] r820t: add support for R828D
    [media] media/i2c: ths8200: fix build failure with gcc 4.5.4
    [media] Add support for KWorld UB435-Q V2
    [media] staging/media: fix msi3101 build errors
    [media] ddbridge: Remove casting the return value which is a void pointer
    [media] ngene: Remove casting the return value which is a void pointer
    [media] dm1105: remove unneeded not-null test
    [media] sh_mobile_ceu_camera: remove deprecated IRQF_DISABLED
    [media] media: rcar_vin: Add preliminary r8a7790 support
    ...

    Linus Torvalds
     
  • Pull EDAC driver updates from Mauro Carvalho Chehab:
    - sb_edac: add support for Ivy Bridge support
    - cell_edac: add a missing of_node_put() call

    * 'linux_next' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-edac:
    cell_edac: fix missing of_node_put
    sb_edac: add support for Ivy Bridge
    sb_edac: avoid decoding the same error multiple times
    sb_edac: rename mci_bind_devs()
    sb_edac: enable multiple PCI id tables to be used
    sb_edac: rework sad_pkg
    sb_edac: allow different interleave lists
    sb_edac: allow different dram_rule arrays
    sb_edac: isolate TOHM retrieval
    sb_edac: rename pci_br
    sb_edac: isolate TOLM retrieval
    sb_edac: make RANK_CFG_A value part of sbridge_info

    Linus Torvalds
     
  • Pull EDAC updates from Borislav Petkov:
    "Following up on last week's discussion, here's my part of the EDAC
    pile, highlights in the signed tag.

    The last two patches have a date from just now because I've just
    applied them to the tree after Johannes sent them to me earlier. I
    decided to forward them now because they're trivial.

    There's a third one for MPC85xx which adds PCIe error interrupt
    support but since it is not so trivial and hasn't seen any linux-next
    time, I'm deferring it to 3.14

    EDAC update highlights:
    - Support for Calxeda ECX-2000 memory controller, from Robert Richter
    - Misc Calxeda Highbank drivers and EDAC core cleanups, from Rob
    Herring and Robert Richter
    - New maintainer for Freescale's MPC85xx EDAC driver: Johannes
    Thumshirn"

    * tag 'edac_for_3.13' of git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp:
    edac/85xx: Remove mpc85xx_pci_err_remove
    EDAC: Add edac-mpc85xx driver to MAINTAINERS
    edac, highbank: Moving error injection to sysfs for edac
    edac, highbank: Add MAINTAINERS entry
    edac: Unify reporting of device info for device, mc and pci
    edac, highbank: Improve and unify naming
    edac, highbank: Add Calxeda ECX-2000 support
    ARM: dts: calxeda: move memory-controller node out of ecx-common.dtsi
    edac, highbank: Fix interrupt setup of mem and l2 controller

    Linus Torvalds
     
  • Pull MMC updates from Chris Ball:
    "MMC highlights for 3.13:

    Core:
    - Improve runtime PM support, remove mmc_{suspend,resume}_host().
    - Add MMC_CAP_RUNTIME_RESUME, for delaying MMC resume until we're
    outside of the resume sequence (in runtime_resume) to decrease
    system resume time.

    Drivers:
    - dw_mmc: Support HS200 mode.
    - sdhci-eshdc-imx: Support SD3.0 SDR clock tuning, DDR on IMX6.
    - sdhci-pci: Add support for Intel Clovertrail and Merrifield"

    * tag 'mmc-updates-for-3.13-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc: (108 commits)
    mmc: wbsd: Silence compiler warning
    mmc: core: Silence compiler warning in __mmc_switch
    mmc: sh_mmcif: Convert to clk_prepare|unprepare
    mmc: sh_mmcif: Convert to PM macros when defining dev_pm_ops
    mmc: dw_mmc: exynos: Revert the sdr_timing assignment
    mmc: sdhci: Avoid needless loop while handling SDIO interrupts in sdhci_irq
    mmc: core: Add MMC_CAP_RUNTIME_RESUME to resume at runtime_resume
    mmc: core: Improve runtime PM support during suspend/resume for sd/mmc
    mmc: core: Remove redundant mmc_power_up|off at runtime callbacks
    mmc: Don't force card to active state when entering suspend/shutdown
    MIPS: db1235: Don't use MMC_CLKGATE
    mmc: core: Remove deprecated mmc_suspend|resume_host APIs
    mmc: mmci: Move away from using deprecated APIs
    mmc: via-sdmmc: Move away from using deprecated APIs
    mmc: tmio: Move away from using deprecated APIs
    mmc: sh_mmcif: Move away from using deprecated APIs
    mmc: sdricoh_cs: Move away from using deprecated APIs
    mmc: rtsx: Remove redundant suspend and resume callbacks
    mmc: wbsd: Move away from using deprecated APIs
    mmc: pxamci: Remove redundant suspend and resume callbacks
    ...

    Linus Torvalds
     
  • Use helper functions named similar to other drivers to access
    superio registers.

    Request memory region only when needed, and use request_muxed_region().
    This lets other devices (hwmon, gpio) use the same region.

    Signed-off-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Guenter Roeck
     
  • There is no need to enable the watchdog device if it is already enabled.
    Also, when enabling the watchdog device, only set the watchdog device
    enable bit and do not touch other bits; depending on the chip type,
    those bits may enable other functionality.

    Signed-off-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Guenter Roeck
     
  • It is unnecessary to enable the logical device and WDT0 each time
    the watchdog is accessed. Do it only once during initialization.

    Signed-off-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Guenter Roeck
     
  • Signed-off-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Guenter Roeck
     
  • Fix to return a negative error code from the bus speed parse
    error handling case instead of 0.

    Signed-off-by: Wei Yongjun
    Reviewed-by: Tim Kryger
    Signed-off-by: Wolfram Sang

    Wei Yongjun
     

18 Nov, 2013

24 commits

  • This reverts commit 69f0554ec261fd686ac7fa1c598cc9eb27b83a80.

    This patch breaks randconfig on at least the x86-64 architecture, and
    most likely on others. There is work underway to support uncompressed
    kernels in a generic way, but it looks like it will amount to
    rewriting the support from scratch; see the LKML thread in the Link:
    for info.

    Therefore, revert this change and wait for the fix.

    Reported-by: Pavel Roskin
    Cc: Christian Ruppert
    Cc: Andrew Morton
    Link: http://lkml.kernel.org/r/20131113113418.167b8ffd@IRBT4585
    Signed-off-by: H. Peter Anvin
    Signed-off-by: Linus Torvalds

    H. Peter Anvin
     
  • Remove mpc85xx_pci_err_remove(...) which is obsolete, this removes the
    compiler warning which can be seen when building the driver either
    statically or as a module.

    Signed-off-by: Johannes Thumshirn
    Link: https://lkml.kernel.org/r/20131112161901.GA15637@jtlinux
    Signed-off-by: Johannes Thumshirn
    Signed-off-by: Borislav Petkov

    Johannes Thumshirn
     
  • Add drivers/edac/mpc85xx_edac.[ch] to MAINTAINERS file and me as
    maintainer.

    Signed-off-by: Johannes Thumshirn
    Link: https://lkml.kernel.org/r/20131112161901.GA15637@jtlinux
    Cc: Doug Thompson
    Cc: Dave Jiang
    Signed-off-by: Borislav Petkov

    Johannes Thumshirn
     
  • All OMAP IP blocks expect LE data, but CPU may operate in BE mode.
    Need to use endian neutral functions to read/write h/w registers.
    I.e instead of __raw_read[lw] and __raw_write[lw] functions code
    need to use read[lw]_relaxed and write[lw]_relaxed functions.
    If the first simply reads/writes register, the second will byteswap
    it if host operates in BE mode.

    Changes are trivial sed like replacement of __raw_xxx functions
    with xxx_relaxed variant.

    Signed-off-by: Victor Kamensky
    Signed-off-by: Taras Kondratiuk
    Acked-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Victor Kamensky
     
  • As CSR SiRF is converted to multi platform CLOCK_TICK_RATE is a dummy
    value that seems to match the right value is used.
    (arch/arm/mach-prima2/include/mach/timex.h which defined CLOCK_TICK_RATE
    to 1000000 was removed in commit cf82e0e (ARM: sirf: enable
    multiplatform support); marco used the same file.)

    To not depend on that dummy value use a local #define instead.

    Signed-off-by: Uwe Kleine-König
    Signed-off-by: Wim Van Sebroeck

    Uwe Kleine-König
     
  • We changed "buf" from being an array of 6 chars to being a pointer this
    sizeof(buf) needs to be updated as well.

    Fixes: 2ddb8089a7e5 ('watchdog: pcwd_usb: Use allocated buffer for usb_control_msg')
    Signed-off-by: Dan Carpenter
    Reviewed-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Dan Carpenter
     
  • In case of error, the function devm_request_and_ioremap() returns NULL
    pointer not ERR_PTR(). Fix it by using devm_ioremap_resource() instead
    of devm_request_and_ioremap().

    Signed-off-by: Wei Yongjun
    Signed-off-by: Wim Van Sebroeck

    Wei Yongjun
     
  • Fixed a trivial typo.

    Signed-off-by: Sachin Kamat
    Reviewed-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Sachin Kamat
     
  • Add device tree support to the DW watchdog timer.

    Signed-off-by: Dinh Nguyen
    Acked-by: Jamie Iles
    Acked-by: Mark Rutland
    Reviewed-by: Pavel Machek
    Reviewed-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck
    Cc: Viresh Kumar
    Cc: Rob Herring
    Cc: Pawel Moll
    Cc: Stephen Warren
    Cc: Ian Campbell
    Cc: devicetree@vger.kernel.org
    Cc: linux-watchdog@vger.kernel.org

    Dinh Nguyen
     
  • I just can't find any value in MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR)
    and MODULE_ALIAS_MISCDEV(TEMP_MINOR) statements.

    Either the device is enumerated and the driver already has a module
    alias (e.g. PCI, USB etc.) that will get the right driver loaded
    automatically.

    Or the device is not enumerated and loading its driver will lead to
    more or less intrusive hardware poking. Such hardware poking should be
    limited to a bare minimum, so the user should really decide which
    drivers should be tried and in what order. Trying them all in
    arbitrary order can't do any good.

    On top of that, loading that many drivers at once bloats the kernel
    log. Also many drivers will stay loaded afterward, bloating the output
    of "lsmod" and wasting memory. Some modules (cs5535_mfgpt which gets
    loaded as a dependency) can't even be unloaded!

    If defining char-major-10-130 is needed then it should happen in
    user-space.

    Signed-off-by: Jean Delvare
    Acked-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck
    Cc: Stephen Warren
    Cc: Mike Frysinger
    Cc: Wan ZongShun
    Cc: Ben Dooks
    Cc: Kukjin Kim
    Cc: Zwane Mwaikambo
    Cc: Jim Cromie

    Jean Delvare
     
  • timeout_to_regval() returns a valid error code. Might as well use it.

    Signed-off-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Guenter Roeck
     
  • usb_control_msg() must use a dma-capable buffer.

    This fixes the following error reported by smatch:

    drivers/watchdog/pcwd_usb.c:257 usb_pcwd_send_command() error: doing dma on the
    stack (buf)

    Signed-off-by: Guenter Roeck
    Acked-by: Greg Kroah-Hartman
    Signed-off-by: Wim Van Sebroeck

    Guenter Roeck
     
  • Driver core clears the driver data to NULL after device_release
    or on probe failure, so just remove it from here.

    Driver core change:
    "device-core: Ensure drvdata = NULL when no driver is bound"
    (sha1: 0998d0631001288a5974afc0b2a5f568bcdecb4d)

    Signed-off-by: Michal Simek
    Reviewed-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Michal Simek
     
  • On CSR SiRFprimaII and SiRFatlasVI, the 6th timer can act as a watchdog
    timer when the Watchdog mode is enabled.

    watchdog occur when TIMER watchdog counter matches the value software
    pre-set, when this event occurs, the effect is the same as the system
    software reset.

    Signed-off-by: Xianglong Du
    Signed-off-by: Barry Song
    Cc: Romain Izard
    Reviewed-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Xianglong Du
     
  • of_match_ptr() is a macro used to avoid undefined reference error if
    CONFIG_OF is used to selectively compile in or out the
    data structure. It is defined as follows:

    #ifdef CONFIG_OF
    #define of_match_ptr(ptr) ptr
    #else
    #define of_match_ptr(ptr) NULL
    #endif

    In the case of this series, none of the drivers use CONFIG_OF macro to
    compile out the data structure (i.e., the data structure is always
    defined).
    Hence the use of of_match_ptr() does not make any sense. Thus removing
    it to make the code look simpler for readability.

    Signed-off-by: Sachin Kamat
    Acked-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Sachin Kamat
     
  • There seems to be some confusion here which functions return positive
    numbers and which return negative error codes.

    copy_to_user() returns the number of bytes remaining to be copied but we
    want to return -EFAULT.

    The rest is just clean up. get_user() actually returns zero on success
    and -EFAULT on error so we can preserve the error code. The
    timeout_to_regval() function returns -EINVAL on failure, but we can
    propogate that back instead of hardcoding -EINVAL ourselves.

    Signed-off-by: Dan Carpenter
    Reviewed-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck
    --

    Dan Carpenter
     
  • I accidently put the devicetree bindings for the MEN A21 watchdog driver in
    Documentation/devicetree/bindings/gpio instead of
    Documentation/devicetree/bindings/watchdog, this patch addresses this error.

    Signed-off-by: Johannes Thumshirn
    Acked-by: Stephen Warren
    Reviewed-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck
    Cc: Rob Herring
    Cc: Pawel Moll
    Cc: Mark Rutland
    Cc: Ian Campbell
    Cc: Rob Landley

    Johannes Thumshirn
     
  • Add a driver for the watchdog timer found on Ralink SoC

    Signed-off-by: John Crispin
    Signed-off-by: Gabor Juhos
    Reviewed-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck
    Cc: linux-watchdog@vger.kernel.org
    Cc: linux-mips@linux-mips.org
    Cc: devicetree-discuss@lists.ozlabs.org

    John Crispin
     
  • This patch adds a watchdog driver for the main hardware watchdog timer
    found on MOXA ART SoCs.

    The MOXA ART SoC provides one writable timer register, restarting
    the hardware once it reaches zero. The register is auto decremented
    every APB clock cycle.

    Signed-off-by: Jonas Jensen
    Reviewed-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Jonas Jensen
     
  • Added __user annotation to fix the following sparse warnings.
    Also, it makes 'kempld_prescaler' static because it is used
    only in this file.

    drivers/watchdog/kempld_wdt.c:70:11: warning: symbol 'kempld_prescaler' was not declared. Should it be static?
    drivers/watchdog/kempld_wdt.c:364:23: warning: incorrect type in initializer (different address spaces)
    drivers/watchdog/kempld_wdt.c:364:23: expected int const [noderef] *register __p
    drivers/watchdog/kempld_wdt.c:364:23: got int *

    Signed-off-by: Jingoo Han
    Reviewed-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Jingoo Han
     
  • Added __user annotation to fix the following sparse warnings.

    drivers/watchdog/dw_wdt.c:206:38: warning: incorrect type in argument 1 (different address spaces)
    drivers/watchdog/dw_wdt.c:206:38: expected void [noderef] *to
    drivers/watchdog/dw_wdt.c:206:38: got struct watchdog_info *
    drivers/watchdog/dw_wdt.c:211:24: warning: incorrect type in initializer (different address spaces)
    drivers/watchdog/dw_wdt.c:211:24: expected int const [noderef] *register __p
    drivers/watchdog/dw_wdt.c:211:24: got int *

    Signed-off-by: Jingoo Han
    Acked-by: Jamie Iles
    Reviewed-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Jingoo Han
     
  • Use the wrapper function for retrieving the platform data instead of
    accessing dev->platform_data directly.

    Signed-off-by: Jingoo Han
    Reviewed-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Jingoo Han
     
  • Enable auto loading by udev when imx2_wdt is compiled as a module.

    Signed-off-by: Niels de Vos
    Acked-by: Shawn Guo
    Reviewed-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Niels de Vos
     
  • This is necessary to make the driver work with platforms using the
    common clock framework.

    Signed-off-by: Heiko Stuebner
    Reviewed-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Heiko Stübner