Eric Lee / smarc-fsl-linux-kernel

12 Feb, 2013

1 commit

  • 78110bb8d   staging: Remove unnecessary OOM messages ... Browse Code »

    alloc failures already get standardized OOM
    messages and a dump_stack.

    For the affected mallocs around these OOM messages:

    Converted kzallocs with multiplies to kcalloc.
    Converted kmallocs with multiplies to kmalloc_array.
    Converted a kmalloc/strlen/strncpy to kstrdup.
    Moved a spin_lock below a removed OOM message and
    removed a now unnecessary spin_unlock.
    Neatened alignment and whitespace.

    Signed-off-by: Joe Perches
    Signed-off-by: Greg Kroah-Hartman

    Joe Perches
     

05 Sep, 2012

1 commit

16 Aug, 2012

2 commits

10 Jul, 2012

1 commit

  • 485b34c2d   staging: Fixes some checkpatch warnings in asus_oled/asus_oled.c ... Browse Code »

    This fixes the following warnings:

    1: Changes a printk(KERN_ERR) call to a pr_err call in line 785
    2: Changes a printk(KERN_ERR) call to a pr_err call in line 791
    3: Changes a printk(KERN_ERR) call to a pr_err call in line 798
    4: Reduces line length below 80 at line 785 (Not intended)
    5: Reduces line length below 80 at line 798 (Not intended)

    Signed-off-by: Cruz Julian Bishop
    Signed-off-by: Greg Kroah-Hartman

    Cruz Julian Bishop
     

21 Apr, 2012

1 commit

  • fc433dea4   USB: asus_oled.c: remove err() usage ... Browse Code »

    err() was a very old USB-specific macro that I thought had
    gone away. This patch removes it from being used in the
    driver and uses dev_err() instead.

    CC: Jakub Schmidtke
    CC: Pekka Paalanen
    CC: Peter Huewe
    CC: "Ken O'Brien"
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

31 Mar, 2012

1 commit

  • 970e24864   Documentation: remove references to /etc/modprobe.conf ... Browse Code »

    Usage of /etc/modprobe.conf file was deprecated by module-init-tools and
    is no longer parsed by new kmod tool. References to this file are
    replaced in Documentation, comments and Kconfig according to the
    context.

    There are also some references to the old /etc/modules.conf from 2.4
    kernels that are being removed.

    Signed-off-by: Lucas De Marchi
    Acked-by: Takashi Iwai
    Acked-by: Mauro Carvalho Chehab
    Signed-off-by: Randy Dunlap
    Signed-off-by: Linus Torvalds

    Lucas De Marchi
     

01 Mar, 2012

1 commit

09 Feb, 2012

2 commits

  • 3589e7459   Staging: asus_oled: fix NULL-ptr crash on unloading ... Browse Code »
    1

    Asus_oled triggers the following bug on module unloading:

    usbcore: deregistering interface driver asus-oled
    BUG: unable to handle kernel NULL pointer dereference at 0000000000000038
    IP: [] sysfs_delete_link+0x30/0x66

    Call Trace:
    [] device_remove_class_symlinks+0x6b/0x70
    [] device_del+0x9f/0x1ab
    [] device_unregister+0x11/0x1e
    [] asus_oled_disconnect+0x4f/0x9e [asus_oled]
    [] usb_unbind_interface+0x54/0x103
    [] __device_release_driver+0xa2/0xeb
    [] driver_detach+0x87/0xad
    [] bus_remove_driver+0x91/0xc1
    [] driver_unregister+0x66/0x6e
    [] usb_deregister+0xbb/0xc4
    [] asus_oled_exit+0x2f/0x31 [asus_oled]
    [] sys_delete_module+0x1b8/0x21b
    [] ? do_munmap+0x2ef/0x313
    [] system_call_fastpath+0x16/0x1b

    This is due to an incorrect destruction sequence in asus_oled_exit().

    Fix the order, fixes the bug. Tested on an Asus G50V laptop only.

    Cc: Jakub Schmidtke
    Signed-off-by: Pekka Paalanen
    Cc: stable
    Signed-off-by: Greg Kroah-Hartman

    Pekka Paalanen
     
  • 635032cb3   Staging: asus_oled: fix image processing ... Browse Code »
    1

    Programming an image was broken, because odev->buf_offs was not advanced
    for val == 0 in append_values(). This regression was introduced in:

    commit 1ff12a4aa354bed093a0240d5e6347b1e27601bc
    Author: Kevin A. Granade
    Date: Sat Sep 5 01:03:39 2009 -0500

    Staging: asus_oled: Cleaned up checkpatch issues.

    Fix the image processing by special-casing val == 0.

    I have tested this change on an Asus G50V laptop only.

    Cc: Jakub Schmidtke
    Cc: Kevin A. Granade
    Signed-off-by: Pekka Paalanen
    Cc: stable
    Signed-off-by: Greg Kroah-Hartman

    Pekka Paalanen
     

27 Nov, 2011

1 commit

08 Dec, 2010

1 commit

19 Nov, 2010

1 commit

17 Nov, 2010

1 commit

10 Nov, 2010

1 commit

18 Oct, 2010

1 commit

  • 631dd1a88   Update broken web addresses in the kernel. ... Browse Code »

    The patch below updates broken web addresses in the kernel

    Signed-off-by: Justin P. Mattock
    Cc: Maciej W. Rozycki
    Cc: Geert Uytterhoeven
    Cc: Finn Thain
    Cc: Randy Dunlap
    Cc: Matt Turner
    Cc: Dimitry Torokhov
    Cc: Mike Frysinger
    Acked-by: Ben Pfaff
    Acked-by: Hans J. Koch
    Reviewed-by: Finn Thain
    Signed-off-by: Jiri Kosina

    Justin P. Mattock
     

12 May, 2010

1 commit

08 Mar, 2010

2 commits

  • 0933e2d98   driver core: Convert some drivers to CLASS_ATTR_STRING ... Browse Code »

    Convert some drivers who export a single string as class attribute
    to the new class_attr_string functions. This removes redundant
    code all over.

    Signed-off-by: Andi Kleen
    Signed-off-by: Greg Kroah-Hartman

    Andi Kleen
     
  • 28812fe11   driver-core: Add attribute argument to class_attribute show/store ... Browse Code »

    Passing the attribute to the low level IO functions allows all kinds
    of cleanups, by sharing low level IO code without requiring
    an own function for every piece of data.

    Also drivers can extend the attributes with own data fields
    and use that in the low level function.

    This makes the class attributes the same as sysdev_class attributes
    and plain attributes.

    This will allow further cleanups in drivers.

    Full tree sweep converting all users.

    Signed-off-by: Andi Kleen
    Signed-off-by: Greg Kroah-Hartman

    Andi Kleen
     

04 Mar, 2010

3 commits

  • a457732b8   staging: make USB device id constant ... Browse Code »

    The id_table field of the struct usb_device_id is constant in
    so it is worth to make the initialization data also constant.

    The semantic match that finds this kind of pattern is as follows:
    (http://coccinelle.lip6.fr/)

    //
    @r@
    disable decl_init,const_decl_init;
    identifier I1, I2, x;
    @@
    struct I1 {
    ...
    const struct I2 *x;
    ...
    };
    @s@
    identifier r.I1, y;
    identifier r.x, E;
    @@
    struct I1 y = {
    .x = E,
    };
    @c@
    identifier r.I2;
    identifier s.E;
    @@
    const struct I2 E[] = ... ;
    @depends on !c@
    identifier r.I2;
    identifier s.E;
    @@
    + const
    struct I2 E[] = ...;
    //

    Signed-off-by: Németh Márton
    Cc: Julia Lawall
    Cc: cocci@diku.dk
    Signed-off-by: Greg Kroah-Hartman

    Németh Márton
     
  • 0df28be06   Staging: asus_oled: Add NULL test for kmalloc ... Browse Code »

    This patch adds a NULL test to check wether kmalloc was successful or
    not.

    Signed-off-by: Peter Huewe
    Signed-off-by: Greg Kroah-Hartman

    Peter Huewe
     
  • e89230ec9   Staging: asus_oled: Add defines for asus vendor_id and device_id to be consistent with hid-ids.h ... Browse Code »

    This almost trivial patch replaces the hardcoded values for the vendor and
    device ids with defines, as they are used in drivers/hid/hid-ids.h

    For me this seems to be more consistent, however as drivers/hid/hid-ids.h
    is not within the default include directory I had to redefine the defines here
    (maybe move the hid-ids.h to include/linux ?)

    Signed-off-by: Peter Huewe
    Signed-off-by: Greg Kroah-Hartman

    Peter Huewe
     

21 Jan, 2010

1 commit

  • 20633bf01   Staging: asus_oled: fix oops in 2.6.32.2 ... Browse Code »

    After updating to 2.6.32 kernel, I started experiencing Oopses caused by
    the asus_oled module. After quick investigation, I wrapped this simple
    patch which fixes an Oops in by asus_oled module on 2.6.32.2 kernel,
    caused by incorrect usage of strict_strtoul function call within
    set_enabled and set_disabled functions. This can be triggered by simple
    running the userspace client for asus_old (e.g., 'asusoled -e' or
    'asusoled -d').

    Signed-off-by: Eugeni Dodonov
    Cc: stable
    Signed-off-by: Greg Kroah-Hartman

    Eugeni Dodonov
     

16 Sep, 2009

1 commit

20 Jun, 2009

1 commit

04 Apr, 2009

5 commits

07 Jan, 2009

2 commits