27 Aug, 2018

2 commits

  • Pull IDA updates from Matthew Wilcox:
    "A better IDA API:

    id = ida_alloc(ida, GFP_xxx);
    ida_free(ida, id);

    rather than the cumbersome ida_simple_get(), ida_simple_remove().

    The new IDA API is similar to ida_simple_get() but better named. The
    internal restructuring of the IDA code removes the bitmap
    preallocation nonsense.

    I hope the net -200 lines of code is convincing"

    * 'ida-4.19' of git://git.infradead.org/users/willy/linux-dax: (29 commits)
    ida: Change ida_get_new_above to return the id
    ida: Remove old API
    test_ida: check_ida_destroy and check_ida_alloc
    test_ida: Convert check_ida_conv to new API
    test_ida: Move ida_check_max
    test_ida: Move ida_check_leaf
    idr-test: Convert ida_check_nomem to new API
    ida: Start new test_ida module
    target/iscsi: Allocate session IDs from an IDA
    iscsi target: fix session creation failure handling
    drm/vmwgfx: Convert to new IDA API
    dmaengine: Convert to new IDA API
    ppc: Convert vas ID allocation to new IDA API
    media: Convert entity ID allocation to new IDA API
    ppc: Convert mmu context allocation to new IDA API
    Convert net_namespace to new IDA API
    cb710: Convert to new IDA API
    rsxx: Convert to new IDA API
    osd: Convert to new IDA API
    sd: Convert to new IDA API
    ...

    Linus Torvalds
     
  • Pull perf updates from Thomas Gleixner:
    "Kernel:
    - Improve kallsyms coverage
    - Add x86 entry trampolines to kcore
    - Fix ARM SPE handling
    - Correct PPC event post processing

    Tools:
    - Make the build system more robust
    - Small fixes and enhancements all over the place
    - Update kernel ABI header copies
    - Preparatory work for converting libtraceevnt to a shared library
    - License cleanups"

    * 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip: (100 commits)
    tools arch: Update arch/x86/lib/memcpy_64.S copy used in 'perf bench mem memcpy'
    tools arch x86: Update tools's copy of cpufeatures.h
    perf python: Fix pyrf_evlist__read_on_cpu() interface
    perf mmap: Store real cpu number in 'struct perf_mmap'
    perf tools: Remove ext from struct kmod_path
    perf tools: Add gzip_is_compressed function
    perf tools: Add lzma_is_compressed function
    perf tools: Add is_compressed callback to compressions array
    perf tools: Move the temp file processing into decompress_kmodule
    perf tools: Use compression id in decompress_kmodule()
    perf tools: Store compression id into struct dso
    perf tools: Add compression id into 'struct kmod_path'
    perf tools: Make is_supported_compression() static
    perf tools: Make decompress_to_file() function static
    perf tools: Get rid of dso__needs_decompress() call in __open_dso()
    perf tools: Get rid of dso__needs_decompress() call in symbol__disassemble()
    perf tools: Get rid of dso__needs_decompress() call in read_object_code()
    tools lib traceevent: Change to SPDX License format
    perf llvm: Allow passing options to llc in addition to clang
    perf parser: Improve error message for PMU address filters
    ...

    Linus Torvalds
     

26 Aug, 2018

1 commit

  • Pull libnvdimm updates from Dave Jiang:
    "Collection of misc libnvdimm patches for 4.19 submission:

    - Adding support to read locked nvdimm capacity.

    - Change test code to make DSM failure code injection an override.

    - Add support for calculate maximum contiguous area for namespace.

    - Add support for queueing a short ARS when there is on going ARS for
    nvdimm.

    - Allow NULL to be passed in to ->direct_access() for kaddr and pfn
    params.

    - Improve smart injection support for nvdimm emulation testing.

    - Fix test code that supports for emulating controller temperature.

    - Fix hang on error before devm_memremap_pages()

    - Fix a bug that causes user memory corruption when data returned to
    user for ars_status.

    - Maintainer updates for Ross Zwisler emails and adding Jan Kara to
    fsdax"

    * tag 'libnvdimm-for-4.19_misc' of gitolite.kernel.org:pub/scm/linux/kernel/git/nvdimm/nvdimm:
    libnvdimm: fix ars_status output length calculation
    device-dax: avoid hang on error before devm_memremap_pages()
    tools/testing/nvdimm: improve emulation of smart injection
    filesystem-dax: Do not request kaddr and pfn when not required
    md/dm-writecache: Don't request pointer dummy_addr when not required
    dax/super: Do not request a pointer kaddr when not required
    tools/testing/nvdimm: kaddr and pfn can be NULL to ->direct_access()
    s390, dcssblk: kaddr and pfn can be NULL to ->direct_access()
    libnvdimm, pmem: kaddr and pfn can be NULL to ->direct_access()
    acpi/nfit: queue issuing of ars when an uc error notification comes in
    libnvdimm: Export max available extent
    libnvdimm: Use max contiguous area for namespace size
    MAINTAINERS: Add Jan Kara for filesystem DAX
    MAINTAINERS: update Ross Zwisler's email address
    tools/testing/nvdimm: Fix support for emulating controller temperature
    tools/testing/nvdimm: Make DSM failure code injection an override
    acpi, nfit: Prefer _DSM over _LSR for namespace label reads
    libnvdimm: Introduce locked DIMM capacity support

    Linus Torvalds
     

24 Aug, 2018

1 commit

  • Almost all files in the kernel are either plain text or UTF-8 encoded. A
    couple however are ISO_8859-1, usually just a few characters in a C
    comments, for historic reasons.

    This converts them all to UTF-8 for consistency.

    Link: http://lkml.kernel.org/r/20180724111600.4158975-1-arnd@arndb.de
    Signed-off-by: Arnd Bergmann
    Acked-by: Simon Horman [IPVS portion]
    Acked-by: Jonathan Cameron [IIO]
    Acked-by: Michael Ellerman [powerpc]
    Acked-by: Rob Herring
    Cc: Joe Perches
    Cc: Arnd Bergmann
    Cc: Samuel Ortiz
    Cc: "David S. Miller"
    Cc: Rob Herring
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Arnd Bergmann
     

23 Aug, 2018

4 commits

  • Pull second set of KVM updates from Paolo Bonzini:
    "ARM:
    - Support for Group0 interrupts in guests
    - Cache management optimizations for ARMv8.4 systems
    - Userspace interface for RAS
    - Fault path optimization
    - Emulated physical timer fixes
    - Random cleanups

    x86:
    - fixes for L1TF
    - a new test case
    - non-support for SGX (inject the right exception in the guest)
    - fix lockdep false positive"

    * tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm: (49 commits)
    KVM: VMX: fixes for vmentry_l1d_flush module parameter
    kvm: selftest: add dirty logging test
    kvm: selftest: pass in extra memory when create vm
    kvm: selftest: include the tools headers
    kvm: selftest: unify the guest port macros
    tools: introduce test_and_clear_bit
    KVM: x86: SVM: Call x86_spec_ctrl_set_guest/host() with interrupts disabled
    KVM: vmx: Inject #UD for SGX ENCLS instruction in guest
    KVM: vmx: Add defines for SGX ENCLS exiting
    x86/kvm/vmx: Fix coding style in vmx_setup_l1d_flush()
    x86: kvm: avoid unused variable warning
    KVM: Documentation: rename the capability of KVM_CAP_ARM_SET_SERROR_ESR
    KVM: arm/arm64: Skip updating PTE entry if no change
    KVM: arm/arm64: Skip updating PMD entry if no change
    KVM: arm: Use true and false for boolean values
    KVM: arm/arm64: vgic: Do not use spin_lock_irqsave/restore with irq disabled
    KVM: arm/arm64: vgic: Move DEBUG_SPINLOCK_BUG_ON to vgic.h
    KVM: arm: vgic-v3: Add support for ICC_SGI0R and ICC_ASGI1R accesses
    KVM: arm64: vgic-v3: Add support for ICC_SGI0R_EL1 and ICC_ASGI1R_EL1 accesses
    KVM: arm/arm64: vgic-v3: Add core support for Group0 SGIs
    ...

    Linus Torvalds
     
  • Same story: I have WIP patch to make it faster, so better have a test
    as well.

    Link: http://lkml.kernel.org/r/20180627195209.GC18113@avx2
    Signed-off-by: Alexey Dobriyan
    Cc: Shuah Khan
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alexey Dobriyan
     
  • There are plans to change how /proc/self result is calculated,
    for that a test is necessary.

    Use direct system call because of this whole getpid caching story.

    Link: http://lkml.kernel.org/r/20180627195103.GB18113@avx2
    Signed-off-by: Alexey Dobriyan
    Cc: Shuah Khan
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alexey Dobriyan
     
  • As with many other projects, we use some shmalloc allocator. At some
    point we need to make a part of allocated pages back private to process.
    And it should be populated straight away. Check that (MAP_PRIVATE |
    MAP_POPULATE) actually copies the private page.

    [akpm@linux-foundation.org: change message, per review discussion]
    Link: http://lkml.kernel.org/r/20180801233636.29354-1-dima@arista.com
    Signed-off-by: Dmitry Safonov
    Reviewed-by: Andrew Morton
    Cc: Dmitry Safonov
    Cc: Hua Zhong
    Cc: Shuah Khan
    Cc: Stuart Ritchie
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Dmitry Safonov
     

22 Aug, 2018

13 commits


21 Aug, 2018

2 commits

  • …l/git/shuah/linux-kselftest

    Pull Kselftest update from Shuah Khan:

    - add cgroup core selftests

    - fix compile warnings in android ion test

    - fix to bugs in exclude and skip paths in vDSO test

    - remove obsolete config options

    - add missing .gitignore file

    * tag 'linux-kselftest-4.19-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest:
    selftests/ftrace: Fix kprobe string testcase to not probe notrace function
    selftests: mount: remove no longer needed config option
    selftests: cgroup: add gitignore file
    Add cgroup core selftests
    selftests: vDSO - fix to return KSFT_SKIP when test couldn't be run
    selftests: vDSO - fix to exclude x86 test on non-x86 platforms
    selftests/android: initialize heap_type to avoid compiling warning

    Linus Torvalds
     
  • Pull tracing updates from Steven Rostedt:

    - Restructure of lockdep and latency tracers

    This is the biggest change. Joel Fernandes restructured the hooks
    from irqs and preemption disabling and enabling. He got rid of a lot
    of the preprocessor #ifdef mess that they caused.

    He turned both lockdep and the latency tracers to use trace events
    inserted in the preempt/irqs disabling paths. But unfortunately,
    these started to cause issues in corner cases. Thus, parts of the
    code was reverted back to where lockdep and the latency tracers just
    get called directly (without using the trace events). But because the
    original change cleaned up the code very nicely we kept that, as well
    as the trace events for preempt and irqs disabling, but they are
    limited to not being called in NMIs.

    - Have trace events use SRCU for "rcu idle" calls. This was required
    for the preempt/irqs off trace events. But it also had to not allow
    them to be called in NMI context. Waiting till Paul makes an NMI safe
    SRCU API.

    - New notrace SRCU API to allow trace events to use SRCU.

    - Addition of mcount-nop option support

    - SPDX headers replacing GPL templates.

    - Various other fixes and clean ups.

    - Some fixes are marked for stable, but were not fully tested before
    the merge window opened.

    * tag 'trace-v4.19' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace: (44 commits)
    tracing: Fix SPDX format headers to use C++ style comments
    tracing: Add SPDX License format tags to tracing files
    tracing: Add SPDX License format to bpf_trace.c
    blktrace: Add SPDX License format header
    s390/ftrace: Add -mfentry and -mnop-mcount support
    tracing: Add -mcount-nop option support
    tracing: Avoid calling cc-option -mrecord-mcount for every Makefile
    tracing: Handle CC_FLAGS_FTRACE more accurately
    Uprobe: Additional argument arch_uprobe to uprobe_write_opcode()
    Uprobes: Simplify uprobe_register() body
    tracepoints: Free early tracepoints after RCU is initialized
    uprobes: Use synchronize_rcu() not synchronize_sched()
    tracing: Fix synchronizing to event changes with tracepoint_synchronize_unregister()
    ftrace: Remove unused pointer ftrace_swapper_pid
    tracing: More reverting of "tracing: Centralize preemptirq tracepoints and unify their usage"
    tracing/irqsoff: Handle preempt_count for different configs
    tracing: Partial revert of "tracing: Centralize preemptirq tracepoints and unify their usage"
    tracing: irqsoff: Account for additional preempt_disable
    trace: Use rcu_dereference_raw for hooks from trace-event subsystem
    tracing/kprobes: Fix within_notrace_func() to check only notrace functions
    ...

    Linus Torvalds
     

20 Aug, 2018

17 commits

  • To bring in the change made in this cset:

    Fixes: a7bea8308933 ("x86/asm/64: Use 32-bit XOR to zero registers")

    CC /tmp/build/perf/bench/mem-memcpy-x86-64-asm.o
    LD /tmp/build/perf/bench/perf-in.o
    LD /tmp/build/perf/perf-in.o
    LINK /tmp/build/perf/perf

    Silencing this perf build warning:

    Warning: Kernel ABI header at 'tools/arch/x86/lib/memcpy_64.S' differs from latest version at 'arch/x86/lib/memcpy_64.S'
    diff -u tools/arch/x86/lib/memcpy_64.S arch/x86/lib/memcpy_64.S

    Cc: Adrian Hunter
    Cc: David Ahern
    Cc: Jan Beulich
    Cc: Jiri Olsa
    Cc: Namhyung Kim
    Cc: Wang Nan
    Link: https://lkml.kernel.org/n/tip-sad22dudoz71qr3tsnlqtkia@git.kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Arnaldo Carvalho de Melo
     
  • To get the changes in the following csets:

    301d328a6f8b ("x86/cpufeatures: Add EPT_AD feature bit")
    706d51681d63 ("x86/speculation: Support Enhanced IBRS on future CPUs")

    No tools were affected, copy it to silence this perf tool build warning:

    Warning: Kernel ABI header at 'tools/arch/x86/include/asm/cpufeatures.h' differs from latest version at 'arch/x86/include/asm/cpufeatures.h'
    diff -u tools/arch/x86/include/asm/cpufeatures.h arch/x86/include/asm/cpufeatures.h

    Cc: Adrian Hunter
    Cc: David Ahern
    Cc: Jiri Olsa
    Cc: Namhyung Kim
    Cc: Peter Feiner
    Cc: Sai Praneeth
    Cc: Thomas Gleixner
    Cc: Wang Nan
    Link: https://lkml.kernel.org/n/tip-bvs8wgd5wp4lz9f0xf1iug5r@git.kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Arnaldo Carvalho de Melo
     
  • Jaroslav reported errors from valgrind over perf python script:

    # echo 0 > /sys/devices/system/cpu/cpu4/online
    # valgrind ./test.py
    ==7524== Memcheck, a memory error detector
    ...
    ==7524== Command: ./test.py
    ==7524==
    pid 7526 exited
    ==7524== Invalid read of size 8
    ==7524== at 0xCC2C2B3: perf_mmap__read_forward (evlist.c:780)
    ==7524== by 0xCC2A681: pyrf_evlist__read_on_cpu (python.c:959)
    ...
    ==7524== Address 0x65c4868 is 16 bytes after a block of size 459,36..
    ==7524== at 0x4C2B955: calloc (vg_replace_malloc.c:711)
    ==7524== by 0xCC2F484: zalloc (util.h:35)
    ==7524== by 0xCC2F484: perf_evlist__alloc_mmap (evlist.c:978)
    ...

    The reason for this is in the python interface, that allows a script to
    pass arbitrary cpu number, which is then used to access struct
    perf_evlist::mmap array. That's obviously wrong and works only when if
    all cpus are available and fails if some cpu is missing, like in the
    example above.

    This patch makes pyrf_evlist__read_on_cpu() search the evlist's maps
    array for the proper map to access.

    It's linear search at the moment. Based on the way how is the
    read_on_cpu used, I don't think we need to be fast in here. But we
    could add some hash in the middle to make it fast/er.

    We don't allow python interface to set write_backward event attribute,
    so it's safe to check only evlist's mmaps.

    Reported-by: Jaroslav Škarvada
    Signed-off-by: Jiri Olsa
    Cc: Alexander Shishkin
    Cc: David Ahern
    Cc: Joe Mario
    Cc: Namhyung Kim
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/20180817114556.28000-3-jolsa@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     
  • Store the real cpu number in 'struct perf_mmap', which will be used by
    python interface that allows user to read a particular memory map for
    given cpu.

    Signed-off-by: Jiri Olsa
    Cc: Alexander Shishkin
    Cc: David Ahern
    Cc: Jaroslav Škarvada
    Cc: Joe Mario
    Cc: Namhyung Kim
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/20180817114556.28000-2-jolsa@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     
  • Having comp carrying the compression ID, we no longer need return the
    extension. Removing it and updating the automated test.

    Signed-off-by: Jiri Olsa
    Cc: Alexander Shishkin
    Cc: David Ahern
    Cc: Michael Petlan
    Cc: Namhyung Kim
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/20180817094813.15086-14-jolsa@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     
  • Add implementation of the is_compressed callback for gzip.

    Signed-off-by: Jiri Olsa
    Cc: Alexander Shishkin
    Cc: David Ahern
    Cc: Michael Petlan
    Cc: Namhyung Kim
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/20180817094813.15086-13-jolsa@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     
  • Add implementation of the is_compressed callback for lzma.

    Signed-off-by: Jiri Olsa
    Cc: Alexander Shishkin
    Cc: David Ahern
    Cc: Michael Petlan
    Cc: Namhyung Kim
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/20180817094813.15086-12-jolsa@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     
  • Add is_compressed callback to the compressions array, that returns 0 if
    the file is compressed or != 0 if not.

    The new callback is used to recognize the situation when we have a
    'compressed' object, like:

    /lib/modules/.../drivers/net/ethernet/intel/igb/igb.ko.xz

    but we need to read its debug data from debuginfo files, which might not
    be compressed, like:

    /root/.debug/.build-id/d6/...c4b301f/debug

    So even for a 'compressed' object we read debug data from a plain
    uncompressed object. To keep this transparent, we detect this in
    decompress_kmodule() and return the file descriptor to the uncompressed
    file.

    Signed-off-by: Jiri Olsa
    Cc: Alexander Shishkin
    Cc: David Ahern
    Cc: Michael Petlan
    Cc: Namhyung Kim
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/20180817094813.15086-11-jolsa@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     
  • We will add a compression check in the following patch and it makes it
    easier if the file processing is done in a single place. It also makes
    the current code simpler.

    The decompress_kmodule function now returns the fd of the uncompressed
    file and the file name in the pathname arg, if it's provided.

    Signed-off-by: Jiri Olsa
    Cc: Alexander Shishkin
    Cc: David Ahern
    Cc: Michael Petlan
    Cc: Namhyung Kim
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/20180817094813.15086-10-jolsa@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     
  • Once we parsed out the compression ID, we dont need to iterate all
    available compressions and we can call it directly.

    Signed-off-by: Jiri Olsa
    Cc: Alexander Shishkin
    Cc: David Ahern
    Cc: Michael Petlan
    Cc: Namhyung Kim
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/20180817094813.15086-9-jolsa@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     
  • Add comp to 'struct dso' to hold the compression index. It will be used
    in the following patches.

    Signed-off-by: Jiri Olsa
    Cc: Alexander Shishkin
    Cc: David Ahern
    Cc: Michael Petlan
    Cc: Namhyung Kim
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/20180817094813.15086-8-jolsa@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     
  • Store a decompression ID in 'struct kmod_path', so it can be later
    stored in 'struct dso'.

    Switch 'struct kmod_path's 'comp' from 'bool' to 'int' to return the
    compressions array index. Add 0 index item into compressions array, so
    that the comp usage stays as it was: 0 - no compression, != 0
    compression index.

    Update the kmod_path tests.

    Committer notes:

    Use a designated initializer + terminating comma, e.g. { .fmt = NULL, }, to fix
    the build in several distros:

    centos:6: util/dso.c:201: error: missing initializer
    centos:6: util/dso.c:201: error: (near initialization for 'compressions[0].decompress')
    debian:9: util/dso.c:201:24: error: missing field 'decompress' initializer [-Werror,-Wmissing-field-initializers]
    fedora:25: util/dso.c:201:24: error: missing field 'decompress' initializer [-Werror,-Wmissing-field-initializers]
    fedora:26: util/dso.c:201:24: error: missing field 'decompress' initializer [-Werror,-Wmissing-field-initializers]
    fedora:27: util/dso.c:201:24: error: missing field 'decompress' initializer [-Werror,-Wmissing-field-initializers]
    oraclelinux:6: util/dso.c:201: error: missing initializer
    oraclelinux:6: util/dso.c:201: error: (near initialization for 'compressions[0].decompress')
    ubuntu:12.04.5: util/dso.c:201:2: error: missing initializer [-Werror=missing-field-initializers]
    ubuntu:12.04.5: util/dso.c:201:2: error: (near initialization for 'compressions[0].decompress') [-Werror=missing-field-initializers]
    ubuntu:16.04: util/dso.c:201:24: error: missing field 'decompress' initializer [-Werror,-Wmissing-field-initializers]
    ubuntu:16.10: util/dso.c:201:24: error: missing field 'decompress' initializer [-Werror,-Wmissing-field-initializers]
    ubuntu:16.10: util/dso.c:201:24: error: missing field 'decompress' initializer [-Werror,-Wmissing-field-initializers]
    ubuntu:17.10: util/dso.c:201:24: error: missing field 'decompress' initializer [-Werror,-Wmissing-field-initializers]

    Signed-off-by: Jiri Olsa
    Cc: Alexander Shishkin
    Cc: David Ahern
    Cc: Michael Petlan
    Cc: Namhyung Kim
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/20180817094813.15086-7-jolsa@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     
  • There's no outside user of it.

    Signed-off-by: Jiri Olsa
    Cc: Alexander Shishkin
    Cc: David Ahern
    Cc: Michael Petlan
    Cc: Namhyung Kim
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/20180817094813.15086-6-jolsa@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     
  • There's no outside user of it.

    Signed-off-by: Jiri Olsa
    Cc: Alexander Shishkin
    Cc: David Ahern
    Cc: Michael Petlan
    Cc: Namhyung Kim
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/20180817094813.15086-5-jolsa@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     
  • There's no need to call dso__needs_decompress() twice in the function.

    Signed-off-by: Jiri Olsa
    Cc: Alexander Shishkin
    Cc: David Ahern
    Cc: Michael Petlan
    Cc: Namhyung Kim
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/20180817094813.15086-4-jolsa@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     
  • There's no need to call dso__needs_decompress() twice in the function.

    Signed-off-by: Jiri Olsa
    Cc: Alexander Shishkin
    Cc: David Ahern
    Cc: Michael Petlan
    Cc: Namhyung Kim
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/20180817094813.15086-3-jolsa@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     
  • There's no need to call dso__needs_decompress() twice in the function.

    Signed-off-by: Jiri Olsa
    Cc: Alexander Shishkin
    Cc: David Ahern
    Cc: Michael Petlan
    Cc: Namhyung Kim
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/20180817094813.15086-2-jolsa@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa