18 Feb, 2019

1 commit


13 Feb, 2019

1 commit

  • Fix the following warning by adding a missing break:

    drivers/gpio/gpio-eic-sprd.c: In function ‘sprd_eic_irq_set_type’:
    drivers/gpio/gpio-eic-sprd.c:403:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
    switch (flow_type) {
    ^~~~~~
    drivers/gpio/gpio-eic-sprd.c:435:2: note: here
    default:
    ^~~~~~~

    This patch is part of the ongoing efforts to enable
    -Wimplicit-fallthrough.

    Signed-off-by: Gustavo A. R. Silva
    Reviewed-by: Baolin Wang
    Signed-off-by: Linus Walleij

    Gustavo A. R. Silva
     

24 Jan, 2019

2 commits

  • When setting async EIC as IRQ_TYPE_EDGE_BOTH type, we missed to set the
    SPRD_EIC_ASYNC_INTMODE register to 0, which means detecting edge signals.

    Thus this patch fixes the issue.

    Fixes: 25518e024e3a ("gpio: Add Spreadtrum EIC driver support")
    Cc:
    Signed-off-by: Neo Hou
    Signed-off-by: Baolin Wang
    Signed-off-by: Bartosz Golaszewski

    Neo Hou
     
  • Since differnt type EICs have its own data register to read, thus fix the
    incorrect data register.

    Fixes: 25518e024e3a ("gpio: Add Spreadtrum EIC driver support")
    Cc:
    Signed-off-by: Neo Hou
    Signed-off-by: Baolin Wang
    Signed-off-by: Bartosz Golaszewski

    Neo Hou
     

16 May, 2018

1 commit

  • The Spreadtrum debounce EIC and latch EIC can not support edge trigger,
    but most GPIO users (like gpio-key driver) only use the edge trigger,
    thus the EIC driver need add some support to emulate the edge trigger
    to satisfy this requirement.

    Signed-off-by: Baolin Wang
    Signed-off-by: Linus Walleij

    Baolin Wang
     

27 Mar, 2018

1 commit

  • The Spreadtrum digital-chip EIC controller has 4 sub-modules: debounce EIC,
    latch EIC, async EIC and sync EIC, and each sub-module can has multiple
    banks and each bank contains 8 EICs.

    Each EIC can only be used as input mode, and has the capability to trigger
    interrupts when detecting input signals.

    Signed-off-by: Baolin Wang
    Reviewed-by: Andy Shevchenko
    Signed-off-by: Linus Walleij

    Baolin Wang