19 Feb, 2019
1 commit
-
Use SENSOR[_DEVICE]_ATTR[_2]_{RO,RW,WO} to simplify the source code,
to improve readability, and to reduce the chance of inconsistencies.Also replace any remaining S_ in the driver with octal values.
The conversion was done automatically with coccinelle. The semantic patches
and the scripts used to generate this commit log are available at
https://github.com/groeck/coccinelle-patches/hwmon/.This patch does not introduce functional changes. It was verified by
compiling the old and new files and comparing text and data sizes.Signed-off-by: Guenter Roeck
17 Dec, 2018
1 commit
-
Conversion was done done using the coccinelle script at
https://github.com/groeck/coccinelle-patches/raw/master/hwmon/sensor-devattr-w6.cocciSigned-off-by: Guenter Roeck
03 Jan, 2017
1 commit
-
Use DEVICE_ATTR_RW for read/write attributes. This simplifies the source
code, improves readbility, and reduces the chance of inconsistencies.The conversion was done automatically using coccinelle. It was validated
by compiling both the old and the new source code and comparing its text,
data, and bss size.Signed-off-by: Julia Lawall
[groeck: Updated description]
Signed-off-by: Guenter Roeck
09 Sep, 2016
2 commits
-
The fan can be stopped by writing "3" to pwm1_enable in sysfs.
Add devicetree property for early initialization of the fan controller
to prevent overheating, for example when resetting the board while the
fan was completely turned off.Also improve error reporting, I2C failures were ignored while writing
new values.Signed-off-by: Mike Looijmans
Signed-off-by: Guenter Roeck -
Parse devicetree parameters for voltage and prescaler setting. This allows
using multiple max6550 devices with varying settings, and also makes it
possible to instantiate and configure the device using devicetree.Signed-off-by: Mike Looijmans
Signed-off-by: Guenter Roeck
04 Mar, 2014
4 commits
-
This makes the code a bit easier to read.
Reviewed-by: Jean Delvare
Signed-off-by: Guenter Roeck -
The core code already generates an error message.
Reviewed-by: Jean Delvare
Signed-off-by: Guenter Roeck -
Simplify code, reduce code size, and attach sensor attributes
to hwmon device.Reviewed-by: Jean Delvare
Acked-by: Lee Jones
Signed-off-by: Guenter Roeck -
Cleanup only; no functional change.
Reviewed-by: Jean Delvare
Signed-off-by: Guenter Roeck
19 Oct, 2013
1 commit
-
Signed-off-by: LABBE Corentin
Signed-off-by: Guenter Roeck
26 Jan, 2013
1 commit
-
SENSORS_LIMIT and the generic clamp_val have the same functionality,
and clamp_val is more efficient.This patch reduces text size by 9052 bytes and bss size by 11624 bytes
for x86_64 builds.Signed-off-by: Guenter Roeck
Acked-by: George Joseph
Acked-by: Jean Delvare
22 Jul, 2012
1 commit
-
Convert to use devm_ functions to reduce code size and simplify the code.
Cc: Hans J. Koch
Signed-off-by: Guenter Roeck
Acked-by: Hans J. Koch
19 Mar, 2012
3 commits
-
This patch converts the drivers in drivers/hwmon/* to use the
module_i2c_driver() macro which makes the code smaller and a bit simpler.Signed-off-by: Axel Lin
Cc: Corentin Labbe
Cc: Dirk Eibach
Cc: "Mark M. Hoffman"
Cc: Steve Glendinning
Cc: Riku Voipio
Cc: Guillaume Ligneul
Cc: David George
Cc: "Hans J. Koch"
Cc: Marc Hulsman
Cc: Rudolf Marek
Signed-off-by: Guenter Roeck -
Cc: Hans J. Koch
Acked-by: Hans J. Koch
Signed-off-by: Guenter Roeck -
Fixed:
ERROR: do not use assignment in if condition
ERROR: open brace '{' following struct go on the same line
ERROR: spaces required around that '||' (ctx:VxV)
ERROR: switch and case should be at the same indent
WARNING: simple_strtoul is obsolete, use kstrtoul insteadCc: Hans J. Koch
Acked-by: Hans J. Koch
Signed-off-by: Guenter Roeck
04 Jan, 2012
1 commit
-
Signed-off-by: Al Viro
26 May, 2011
2 commits
-
The MAX6650 has only one fan input.
Signed-off-by: Jean Delvare
Acked-by: "Hans J. Koch"
Acked-by: Guenter Roeck -
MAX6650 device detection is unreliable, we got reports of false
positives. We now have many ways to let users instantiate the devices
explicitly, so unreliable detection should be dropped.Signed-off-by: Jean Delvare
Acked-by: "Hans J. Koch"
Acked-by: Guenter Roeck
16 Nov, 2010
1 commit
-
My old mail address doesn't exist anymore. This changes all occurrences
to my new address.Signed-off-by: Hans J. Koch
Signed-off-by: Jean Delvare
15 Dec, 2009
3 commits
-
This macro simply declares an enum, so drivers might as well declare
it themselves.Signed-off-by: Jean Delvare
Tested-by: Wolfram Sang -
Struct i2c_client_address_data only contains one field at this point,
which makes its usefulness questionable. Get rid of it and pass simple
address lists around instead.Signed-off-by: Jean Delvare
Tested-by: Wolfram Sang -
The "kind" parameter always has value -1, and nobody is using it any
longer, so we can remove it.Signed-off-by: Jean Delvare
Tested-by: Wolfram Sang
10 Dec, 2009
1 commit
-
As kind is now hard-coded to -1, there is room for code clean-ups.
Signed-off-by: Jean Delvare
Acked-by: Corentin Labbe
Cc: "Mark M. Hoffman"
Cc: Juerg Haefliger
Cc: Riku Voipio
Acked-by: "Hans J. Koch"
Cc: Rudolf Marek
11 Jul, 2009
1 commit
-
Add omitted update_lock to one switch/case in set_div.
Signed-off-by: Jiri Slaby
Acked-by: Hans J. Koch
Signed-off-by: Jean Delvare
16 Jun, 2009
1 commit
-
Export the alarm flags provided by the MAX6650/MAX6651 fan-speed regulator
and monitor chips via sysfs.Signed-off-by: Christian Engelmayer
Acked-by: Hans de Goede
Signed-off-by: Jean Delvare
17 Jul, 2008
1 commit
-
The new-style max6650 driver implements the optional detect() callback
to cover the use cases of the legacy driver.Signed-off-by: Jean Delvare
Cc: Hans J. Koch
19 Feb, 2008
1 commit
-
Signed-off-by: Mark M. Hoffman
10 Oct, 2007
1 commit
-
Convert from class_device to device for hwmon_device_register/unregister
Signed-off-by: Tony Jones
Signed-off-by: Greg Kroah-Hartman
Signed-off-by: Kay Sievers
Signed-off-by: Mark M. Hoffman
08 May, 2007
1 commit
-
This driver supports the Maxim MAX6650 and MAX6651 fan speed
monitoring and control chips.Signed-off-by: Hans J. Koch
Signed-off-by: Jean Delvare
