20 Feb, 2019
4 commits
-
Add support for additional reset causes and the proper compatibility
string for sam9x60 SoC. The restart function is the same as the samx7.Signed-off-by: Nicolas Ferre
Reviewed-by: Alexandre Belloni
Signed-off-by: Sebastian Reichel -
The work which is scheduled on a POR boot is potentially left
pending or running until after the device module is removed,
which could result in a use-after-free.Fix by registering a cancel/sync callback, which gets executed as
part of standard resource unwinding.This issue was detected with the help of Coccinelle.
Signed-off-by: Sven Van Asbroeck
Reviewed-by: Hans de Goede
Signed-off-by: Sebastian Reichel -
Add a field for "voltage_max_design_uv" to present fully charged
battery voltage.Signed-off-by: Artur Rojek
Signed-off-by: Sebastian Reichel -
The flags were just read by bq27xxx_battery_update(),
no need to read them again.Signed-off-by: Arthur Demchenkov
Reviewed-by: Andrew F. Davis
Signed-off-by: Sebastian Reichel
13 Feb, 2019
1 commit
-
In remove(), use cancel_delayed_work_sync() to cancel the
delayed work. Otherwise there's a chance that this work
will continue to run until after the device has been removed.While we're here, fix the deallocation order in remove(),
to correspond to the inverse of the probe() allocation
order. This guarantees that any remaining work can run
to completion with all driver structures still intact.This issue was detected with the help of Coccinelle.
Signed-off-by: Sven Van Asbroeck
Signed-off-by: Sebastian Reichel
24 Jan, 2019
4 commits
-
Use firmware-provided limits for POWER_SUPPLY_*_MAX properties instead
of chip max values. This will reflect the battery limits as those are
the important ones.Signed-off-by: Michał Mirosław
Signed-off-by: Sebastian Reichel -
We found sometimes we can not get the saving capacity to initialize the
battery capacity, the reason is the user area registers are put on power
always-on region, so we need delay some time to wait until values are
updated successfully.Moreover we also should clear the USER_AREA_CLEAR register after setting
the USER_AREA_SET register, otherwise we can not save the values in the
USER_AREA_SET register.Signed-off-by: Yuanjiang Yu
Signed-off-by: Baolin Wang
Signed-off-by: Sebastian Reichel -
We should multiply the calibrated current data (cur_1000ma_adc) when
converting current capacity (mAh) to coulomb counter, which can get
an accurate coulomb counter from the fuel gauge controller.Signed-off-by: Baolin Wang
Signed-off-by: Sebastian Reichel -
Add POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE property to get charge
voltage sampling by ADC controller, which is used to validate if the
charge voltage is in normal range or not in charger manager.Signed-off-by: Baolin Wang
Signed-off-by: Sebastian Reichel
22 Jan, 2019
1 commit
-
To comply with tests we need to support more power supply properties:
POWER_SUPPLY_PROP_VOLTAGE_NOW
POWER_SUPPLY_PROP_TEMP
POWER_SUPPLY_PROP_CHARGE_COUNTER
POWER_SUPPLY_PROP_CURRENT_NOW
POWER_SUPPLY_PROP_CURRENT_AVG
POWER_SUPPLY_PROP_CHARGE_FULL
POWER_SUPPLY_PROP_CYCLE_COUNT
POWER_SUPPLY_PROP_VOLTAGE_MAX
POWER_SUPPLY_PROP_CURRENT_MAXSigned-off-by: Roman Kiryanov
Signed-off-by: Sebastian Reichel
21 Jan, 2019
11 commits
-
Fix few trivial language typos.
Signed-off-by: Krzysztof Kozlowski
Signed-off-by: Sebastian Reichel -
The driver doesn't generate uevents on charger connect/disconnect.
This leads to UPower not detecting when AC is on or off... and that is
bad.Reported by Arthur D. on github (
https://github.com/maemo-leste/bugtracker/issues/206 ), thanks to
Merlijn Wajer for suggesting a fix.Cc: stable@kernel.org
Signed-off-by: Pavel Machek
Acked-by: Tony Lindgren
Signed-off-by: Sebastian Reichel -
We include of.h twice. It's unnecessary,so
just remove them.Signed-off-by: Yangtao Li
Signed-off-by: Sebastian Reichel -
If twl4030_bci_read() fails, the read data in "s" is incorrect,
which is however used in the following execution. The fix checks
the return value of twl4030_bci_read() and returns an error code
upstream upon the failure of twl4030_bci_read().Signed-off-by: Kangjie Lu
Signed-off-by: Sebastian Reichel -
Tabs are preferred.
Signed-off-by: Roman Kiryanov
Signed-off-by: Sebastian Reichel -
Align two values as other values below.
Signed-off-by: Roman Kiryanov
Signed-off-by: Sebastian Reichel -
The battery_data static variable was not used.
Signed-off-by: Roman Kiryanov
Signed-off-by: Sebastian Reichel -
There was a line longer than 80 characters.
Signed-off-by: Roman Kiryanov
Signed-off-by: Sebastian Reichel -
There was a checkpatch complain:
"Missing or malformed SPDX-License-Identifier tag".
Signed-off-by: Roman Kiryanov
Signed-off-by: Sebastian Reichel -
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by: Yangtao Li
Signed-off-by: Sebastian Reichel -
This migrates isp1704 driver from old GPIO API to new descriptor
based GPIO API and drops useless platform data as a side-effect.Migration is simple, since all mainline users are DT based and
DT API does not change. Out of tree users of the platform data
need to migrate to gpiod_lookup_table as described here:Documentation/driver-api/gpio/board.rst
Reviewed-by: Linus Walleij
Acked-by: Pavel Machek
Signed-off-by: Sebastian Reichel
29 Dec, 2018
2 commits
-
Pull power supply and reset updates from Sebastian Reichel:
- New core support:
- battery internal resistance
- battery OCV capacity lookup table
- support for custom sysfs attributes- Convert all drivers to use power-supply core support for custom sysfs
attributes- bq24190-charger: bq24196 support
- axp20x-charger: AXP813 support
- sc27xx-battery: new fuel gauge driver
- gpio-poweroff: support for specific active and inactive delays
- Misc fixes
* tag 'for-v4.21' of git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply: (53 commits)
power: supply: bq25890: fix BAT_COMP field definition
power: supply: gpio-charger: Do not use deprecated POWER_SUPPLY_TYPE_USB_*
power: supply: ds2781: switch to devm_power_supply_register
power: supply: ds2780: switch to devm_power_supply_register
power: supply: ds2781: fix race-condition in bin attribute registration
power: supply: ds2780: fix race-condition in bin attribute registration
power: supply: pcf50633: fix race-condition in sysfs registration
power: supply: charger-manager: fix race-condition in sysfs registration
power: supply: charger-manager: simplify generation of sysfs attribute group name
power: supply: bq24257: fix race-condition in sysfs registration
power: supply: bq24190_charger: fix race-condition in sysfs registration
power: supply: lp8788: fix race-condition in sysfs registration
power: supply: ds2781: fix race-condition in sysfs registration
power: supply: ds2780: fix race-condition in sysfs registration
power: supply: bq2415x: fix race-condition in sysfs registration
power: supply: core: add support for custom sysfs attributes
power: supply: sc27xx: Save last battery capacity
power: reset: at91-poweroff: move shdwc related data to one structure
power: supply: sc27xx: Add suspend/resume interfaces
power: supply: sc27xx: Add fuel gauge low voltage alarm
... -
Pull Devicetree updates from Rob Herring:
"The biggest highlight here is the start of using json-schema for DT
bindings. Being able to validate bindings has been discussed for years
with little progress.- Initial support for DT bindings using json-schema language. This is
the start of converting DT bindings from free-form text to a
structured format.- Reworking of initrd address initialization. This moves to using the
phys address instead of virt addr in the DT parsing code. This
rework was motivated by CONFIG_DEV_BLK_INITRD causing unnecessary
rebuilding of lots of files.- Fix stale phandle entries in phandle cache
- DT overlay validation improvements. This exposed several memory
leak bugs which have been fixed.- Use node name and device_type helper functions in DT code
- Last remaining conversions to using %pOFn printk specifier instead
of device_node.name directly- Create new common RTC binding doc and move all trivial RTC devices
out of trivial-devices.txt.- New bindings for Freescale MAG3110 magnetometer, Cadence Sierra
PHY, and Xen shared memory- Update dtc to upstream version v1.4.7-57-gf267e674d145"
* tag 'devicetree-for-4.21' of git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux: (68 commits)
of: __of_detach_node() - remove node from phandle cache
of: of_node_get()/of_node_put() nodes held in phandle cache
gpio-omap.txt: add reg and interrupts properties
dt-bindings: mrvl,intc: fix a trivial typo
dt-bindings: iio: magnetometer: add dt-bindings for freescale mag3110
dt-bindings: Convert trivial-devices.txt to json-schema
dt-bindings: arm: mrvl: amend Browstone compatible string
dt-bindings: arm: Convert Tegra board/soc bindings to json-schema
dt-bindings: arm: Convert ZTE board/soc bindings to json-schema
dt-bindings: arm: Add missing Xilinx boards
dt-bindings: arm: Convert Xilinx board/soc bindings to json-schema
dt-bindings: arm: Convert VIA board/soc bindings to json-schema
dt-bindings: arm: Convert ST STi board/soc bindings to json-schema
dt-bindings: arm: Convert SPEAr board/soc bindings to json-schema
dt-bindings: arm: Convert CSR SiRF board/soc bindings to json-schema
dt-bindings: arm: Convert QCom board/soc bindings to json-schema
dt-bindings: arm: Convert TI nspire board/soc bindings to json-schema
dt-bindings: arm: Convert TI davinci board/soc bindings to json-schema
dt-bindings: arm: Convert Calxeda board/soc bindings to json-schema
dt-bindings: arm: Convert Altera board/soc bindings to json-schema
...
18 Dec, 2018
1 commit
-
According to datasheet, BAT_COMP field spans bits 5-7. The rest of the
code seems to assume this already.Fixes: 4aeae9cb0dad ("power_supply: Add support for TI BQ25890 charger chip")
Signed-off-by: Michał Mirosław
Signed-off-by: Sebastian Reichel
13 Dec, 2018
15 commits
-
Signed-off-by: Sebastian Reichel
-
Simplify/Cleanup the driver by switching to devm_power_supply_register
and dropping the driver's remove function.Signed-off-by: Sebastian Reichel
-
Simplify/Cleanup the driver by switching to devm_power_supply_register
and dropping the driver's remove function.Signed-off-by: Sebastian Reichel
-
This is a follow-up patch to the previous one, which fixed a
race-condition during registration of the attribute group.
This fixes the same issue for the binary attributes by adding
them to the properly registered group. As a side effect the
code is further cleaned up.Signed-off-by: Sebastian Reichel
-
This is a follow-up patch to the previous one, which fixed a
race-condition during registration of the attribute group.
This fixes the same issue for the binary attributes by adding
them to the properly registered group. As a side effect the
code is further cleaned up.Signed-off-by: Sebastian Reichel
-
This registers custom sysfs properties using the native functionality
of the power-supply framework, which cleans up the code a bit and
fixes a race-condition. Before this patch the sysfs attributes were
not properly registered to udev.Signed-off-by: Sebastian Reichel
-
This registers custom sysfs properties using the native functionality
of the power-supply framework, which cleans up the code a bit and
fixes a race-condition. Before this patch the sysfs attributes were
not properly registered to udev.Signed-off-by: Sebastian Reichel
-
This is a simple cleanup and there should be no functional changes.
Signed-off-by: Sebastian Reichel
-
This registers custom sysfs properties using the native functionality
of the power-supply framework, which cleans up the code a bit and
fixes a race-condition. Before this patch the sysfs attributes were
not properly registered to udev.Signed-off-by: Sebastian Reichel
-
This registers custom sysfs properties using the native functionality
of the power-supply framework, which cleans up the code a bit and
fixes a race-condition. Before this patch the sysfs attributes were
not properly registered to udev.Signed-off-by: Sebastian Reichel
-
This registers custom sysfs properties using the native functionality
of the power-supply framework, which cleans up the code a bit and
fixes a race-condition. Before this patch the sysfs attributes were
not properly registered to udev.Signed-off-by: Sebastian Reichel
-
This registers custom sysfs properties using the native functionality
of the power-supply framework, which cleans up the code a bit and
fixes a race-condition. Before this patch the sysfs attributes were
not properly registered to udev.Signed-off-by: Sebastian Reichel
-
This registers custom sysfs properties using the native functionality
of the power-supply framework, which cleans up the code a bit and
fixes a race-condition. Before this patch the sysfs attributes were
not properly registered to udev.Signed-off-by: Sebastian Reichel
-
This registers custom sysfs properties using the native functionality
of the power-supply framework, which cleans up the code a bit and
fixes a race-condition. Before this patch the sysfs attributes were
not properly registered to udev.Signed-off-by: Sebastian Reichel
-
Add functionality to setup device specific sysfs attributes
in a race condition free mannerSigned-off-by: Sebastian Reichel
12 Dec, 2018
1 commit
-
Fix up licensing to be inline with Linux conventions.
Signed-off-by: Nishanth Menon
Acked-by: Kevin Hilman
Signed-off-by: Rafael J. Wysocki
