19 Oct, 2013
17 commits
-
Signed-off-by: Guenter Roeck
-
Signed-off-by: LABBE Corentin
Signed-off-by: Guenter Roeck -
'of_match_ptr' is defined in linux/of.h. Include it explicitly.
Signed-off-by: Sachin Kamat
Signed-off-by: Guenter Roeck -
Driver core sets driver data to NULL upon failure or remove.
Signed-off-by: Sachin Kamat
Cc: Kaiwan N Billimoria
Signed-off-by: Guenter Roeck -
Driver core sets driver data to NULL upon failure or remove.
Signed-off-by: Sachin Kamat
Cc: Marc Pignat
Acked-by: Marc Pignat
Signed-off-by: Guenter Roeck -
drivers/hwmon/jc42.c:521:1-3: WARNING: PTR_RET can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: coccinelle/api/ptr_ret.cocci
CC: Guenter Roeck
Signed-off-by: Fengguang Wu
Signed-off-by: Guenter Roeck -
drivers/hwmon/ltc4261.c:243:1-3: WARNING: PTR_RET can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: coccinelle/api/ptr_ret.cocci
CC: Guenter Roeck
Signed-off-by: Fengguang Wu
Signed-off-by: Guenter Roeck -
drivers/hwmon/lm95234.c:704:1-3: WARNING: PTR_RET can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: coccinelle/api/ptr_ret.cocci
CC: Guenter Roeck
Signed-off-by: Fengguang Wu
Signed-off-by: Guenter Roeck -
drivers/hwmon/max6697.c:649:1-3: WARNING: PTR_RET can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: coccinelle/api/ptr_ret.cocci
CC: Guenter Roeck
Signed-off-by: Fengguang Wu
Signed-off-by: Guenter Roeck -
drivers/hwmon/max6642.c:299:1-3: WARNING: PTR_RET can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: coccinelle/api/ptr_ret.cocci
CC: Guenter Roeck
Signed-off-by: Fengguang Wu
Signed-off-by: Guenter Roeck -
drivers/hwmon/ds1621.c:381:1-3: WARNING: PTR_RET can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: coccinelle/api/ptr_ret.cocci
CC: Guenter Roeck
Signed-off-by: Fengguang Wu
Signed-off-by: Guenter Roeck -
drivers/hwmon/nct6775.c:3866:1-3: WARNING: PTR_RET can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: coccinelle/api/ptr_ret.cocci
CC: Guenter Roeck
Signed-off-by: Fengguang Wu
Signed-off-by: Guenter Roeck -
Signed-off-by: Guenter Roeck
-
Also use new macro ATTRIBUTE_GROUPS to declare attribute groups.
Signed-off-by: Guenter Roeck
-
Also use new macro ATTRIBUTE_GROUPS to declare attribute groups.
Signed-off-by: Guenter Roeck
-
Also use new macro ATTRIBUTE_GROUPS to declare attribute groups.
Signed-off-by: Guenter Roeck
-
Signed-off-by: Guenter Roeck
14 Oct, 2013
23 commits
-
Also introduce dev variable in probe function to simplify access
to client->dev, and use new macro ATTRIBUTE_GROUPS to declare
attribute groups.Signed-off-by: Guenter Roeck
-
Modify code to use is_visible to determine if an attribute should be created
or not, then use devm_hwmon_device_register_with_groups to create the hwmon
device and all attributes in one operation.Signed-off-by: Guenter Roeck
-
Signed-off-by: Guenter Roeck
-
Also introduce new variable dev pointing to client->dev in the probe
function, and use new macro ATTRIBUTE_GROUPS to declare attribute groups.Signed-off-by: Guenter Roeck
-
Also rename new_client variable to client and introduce
new variable dev pointing to client->dev in the probe function,
and use new macro ATTRIBUTE_GROUPS to declare attribute groups.Signed-off-by: Guenter Roeck
-
Also use new macro __ATTRIBUTE_GROUPS to declare attribute groups.
Signed-off-by: Guenter Roeck
-
Signed-off-by: Guenter Roeck
-
Drivers using the new hwmon_device_register_with_groups API often have a
remove function which consists solely of a call hwmon_device_unregister().Provide support for devm_hwmon_device_register_with_groups and
devm_hwmon_device_unregister to allow this repeated code to be removed
and help eliminate error handling code.Signed-off-by: Guenter Roeck
-
Signed-off-by: Guenter Roeck
-
Signed-off-by: Guenter Roeck
-
Signed-off-by: Guenter Roeck
-
Signed-off-by: Guenter Roeck
-
Signed-off-by: Guenter Roeck
-
hwmon_device_register_with_groups() lets callers register a hwmon device
together with all sysfs attributes in a single call.When using hwmon_device_register_with_groups(), hwmon attributes are attached
to the hwmon device directly and no longer with its parent device.Signed-off-by: Guenter Roeck
-
Leftover from commit 33cd66e3 (hwmon: (f71882fg) Convert to use
devm_ functions).Signed-off-by: Guenter Roeck
-
The f75375s driver crashes the kernel if it detects an an internal
implementation error. While the detected conditions suggest that
there is a bug in the code, the condition is not fatal.
Replace BUG() with WARN().Cc: Riku Voipio
Signed-off-by: Guenter Roeck -
vid_to_reg() returns -1 if it encounters an error. Return -EINVAL instead.
Its only caller, atxp1_storevcore(), doesn't use the return code but
returns -1 instead, which is wrong anyway as it means -EPERM.
Use the return value from vid_to_reg() instead to report the error.Signed-off-by: Guenter Roeck
Reviewed-by: Jean Delvare -
acpi_bus_register_driver() returns a valid error code. Use it.
Signed-off-by: Guenter Roeck
-
acpi_power_meter crashes the kernel if it detects an unexpected event
or an internal implementation error. While the detected conditions
suggest that there is a bug in the code, the condition is not fatal.
Replace BUG() with WARN().Signed-off-by: Guenter Roeck
-
get_fan_speed_index() returns -EINVAL in case of errors, only to have it
ignored and replaced with -ENODEV. Make it return -ENODEV and use it.Signed-off-by: Guenter Roeck
-
find_trange_value() returns -ENODEV in case of errors, only to have it
ignored and replaced with -EINVAL. Make it return -EINVAL and use it.Signed-off-by: Guenter Roeck
Reviewed-by: Jean Delvare -
pmbus code currently crashes the kernel if it detects an internal
implementation error. While the detected condition suggests that there
is a bug in the code, it is hardly fatal. Therefore, it should not
trigger a crash. Replace BUG() with WARN().Signed-off-by: Guenter Roeck
-
smatch complains about
mc13783_adc_probe() error: snprintf() chops off the last chars of
'id->name': 20 +vs 10Use PLATFORM_NAME_SIZE instead of '10' as size when declaring
the name variable.Signed-off-by: Guenter Roeck