29 May, 2015

1 commit


28 Jan, 2015

1 commit


11 Jan, 2015

1 commit


09 Jan, 2015

1 commit

  • This is a similar cleanup like the commit [3db084fd0af5: ALSA: fm801:
    PCI core handles power state for us].

    Since pci_set_power_state(), pci_save_state() and pci_restore_state()
    are already done in the PCI core side, so we don't need to it doubly.

    Also, pci_enable_device(), pci_disable_device() and pci_set_master()
    calls in PM callbacks are superfluous nowadays, too, so get rid of
    them as well.

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     

04 Jan, 2015

1 commit


02 Jan, 2015

1 commit

  • The various PCM and MIDI allocation functions in this driver take a pointer
    to a pointer of a PCM/MIDI object where if this parameter is provided the
    newly allocated object is stored. All callers pass NULL though, so remove
    the parameter. This makes the code a bit shorter and cleaner.

    Signed-off-by: Lars-Peter Clausen
    Signed-off-by: Takashi Iwai

    Lars-Peter Clausen
     

13 Aug, 2014

1 commit

  • We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to
    meet kernel coding style guidelines. This issue was reported by checkpatch.

    A simplified version of the semantic patch that makes this change is as
    follows (http://coccinelle.lip6.fr/):

    //

    @@
    identifier i;
    declarer name DEFINE_PCI_DEVICE_TABLE;
    initializer z;
    @@

    - DEFINE_PCI_DEVICE_TABLE(i)
    + const struct pci_device_id i[]
    = z;

    //

    [bhelgaas: add semantic patch]
    Signed-off-by: Benoit Taine
    Signed-off-by: Bjorn Helgaas

    Benoit Taine
     

26 Feb, 2014

1 commit


12 Feb, 2014

1 commit


22 Jan, 2014

1 commit


20 Nov, 2013

1 commit

  • ... and load from the external firmware files.

    The firmware binary blobs in cs46xx driver have been in a gray zone
    regarding the license. It's most likely should be OK, but still
    unclear. And, the size isn't that small, too.

    Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=10750
    Signed-off-by: Takashi Iwai

    Takashi Iwai
     

29 May, 2013

1 commit

  • As drvdata is cleared to NULL at probe failure or at removal by the
    driver core, we don't have to call pci_set_drvdata(pci, NULL) any
    longer in each driver.

    The only remaining pci_set_drvdata(NULL) is in azx_firmware_cb() in
    hda_intel.c. Since this function itself releases the card instance,
    we need to clear drvdata here as well, so that it won't be released
    doubly in the remove callback.

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     

07 Dec, 2012

1 commit

  • CONFIG_HOTPLUG is going away as an option. As result the __dev*
    markings will be going away.

    Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst,
    and __devexit.

    Signed-off-by: Bill Pemberton
    Signed-off-by: Takashi Iwai

    Bill Pemberton
     

21 Aug, 2012

1 commit


15 Aug, 2012

1 commit


10 Aug, 2012

1 commit


03 Jul, 2012

2 commits


24 Apr, 2012

1 commit


19 Dec, 2011

1 commit

  • module_param(bool) used to counter-intuitively take an int. In
    fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
    trick.

    It's time to remove the int/unsigned int option. For this version
    it'll simply give a warning, but it'll break next kernel version.

    Signed-off-by: Rusty Russell
    Signed-off-by: Takashi Iwai

    Rusty Russell
     

01 Nov, 2011

2 commits


10 Jun, 2011

2 commits

  • The name argument of request_irq() appears in /proc/interrupts, and
    it's quite ugly when the name entry contains a space or special letters.
    In general, it's simpler and more readable when the module name appears
    there, so let's replace all entries with KBUILD_MODNAME.

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     
  • The convention for pci_driver.name entry in kernel drivers seem to be
    the module name or equivalent ones. But, so far, almost all PCI sound
    drivers use more verbose name like "ABC Xyz (12)", and these are fairly
    confusing when appearing as a file name.

    This patch converts the all pci_driver.name entries in sound/pci/* to
    use KBUILD_MODNAME for more unified appearance.

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     

01 Nov, 2010

1 commit

  • When reading through sound/pci/cs46xx/dsp_spos.c I noticed a couple of
    things in cs46xx_dsp_spos_create().

    It seems to me that we don't always free the various memory buffers we
    allocate and we also do some work (structure member assignment) early,
    that is completely pointless if some of the memory allocations fail and
    we end up just aborting the whole thing.

    I don't have hardware to test, so the patch below is compile tested only,
    but it makes the following changes:

    - Make sure we always free all allocated memory on failures.
    - Don't do pointless work assigning to structure members before we know
    all memory allocations, that may abort progress, have completed
    successfully.
    - Remove some trailing whitespace.

    Signed-off-by: Jesper Juhl
    Tested-by: Ondrej Zary
    Signed-off-by: Takashi Iwai

    Jesper Juhl
     

13 Apr, 2010

2 commits


18 Feb, 2010

2 commits


09 Feb, 2010

1 commit


26 Jan, 2010

1 commit


22 Dec, 2009

1 commit


04 Dec, 2009

1 commit

  • That is "success", "unknown", "through", "performance", "[re|un]mapping"
    , "access", "default", "reasonable", "[con]currently", "temperature"
    , "channel", "[un]used", "application", "example","hierarchy", "therefore"
    , "[over|under]flow", "contiguous", "threshold", "enough" and others.

    Signed-off-by: André Goddard Rosa
    Signed-off-by: Jiri Kosina

    André Goddard Rosa
     

08 Sep, 2009

1 commit

  • Fix minimum period size for cs46xx cards. This fixes a problem in the
    case where neither a period size nor a buffer size is passed to ALSA;
    this is the case in Audacious, OpenAL, and others.

    Signed-off-by: Sophie Hamilton
    Cc:
    Signed-off-by: Takashi Iwai

    Sophie Hamilton
     

25 Jun, 2009

1 commit


24 Mar, 2009

1 commit


05 Feb, 2009

1 commit


12 Jan, 2009

1 commit


01 Dec, 2008

1 commit


10 Oct, 2008

1 commit

  • This patch adds PCI IDs for:
    * TerraTec DMX XFire 1024
    * Hercules Gamesurround Fortissimo II
    * Hercules Gamesurround Fortissimo III 7.1
    All those cards were supported as generic CS46xx device,
    so they will work as before. I'm pretty sure that first two
    cards work, as they have same hardware design as reference
    card. Not sure about Fortissimo III, but this won't break it
    if it worked.

    Tested on TerraTec DMX XFire 1024.

    Signed-off-by: Vedran Miletic
    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Vedran Miletic