17 Feb, 2015
3 commits
-
This commit removes code duplication between
snd_hdspm_{capture,playback}_ops. No semantic changes intended, this is
purely cosmetic.Signed-off-by: Adrian Knoth
Signed-off-by: Takashi Iwai -
This commit removes code duplication between
snd_hdspm_{capture,playback}_release. No semantic changes intended, this
is purely cosmetic.Signed-off-by: Adrian Knoth
Signed-off-by: Takashi Iwai -
This commit removes code duplication between
snd_hdspm_{capture,playback}_open. No semantic changes intended, this is
purely cosmetic.Signed-off-by: Adrian Knoth
Signed-off-by: Takashi Iwai
14 Feb, 2015
1 commit
-
RME RayDAT and AIO use a fixed buffer size of 16384 samples. With period
sizes of 32-4096, this translates to 4-512 periods.The older RME cards have a variable buffer size but require exactly two
periods.This patch enforces nperiods=2 on those cards.
Signed-off-by: Adrian Knoth
Cc: # 2.6.39+
Signed-off-by: Takashi Iwai
28 Jan, 2015
1 commit
-
Nowadays it's recommended. Replace all in a shot.
Signed-off-by: Takashi Iwai
19 Jan, 2015
2 commits
-
No functional change, refactoring with the standard helpers.
Signed-off-by: Takashi Iwai
-
No functional change, refactoring with the standard helpers.
Signed-off-by: Takashi Iwai
04 Jan, 2015
1 commit
-
The iounmap() function performs also input parameter validation.
Thus the test around the call is not needed.This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
Signed-off-by: Takashi Iwai
17 Nov, 2014
1 commit
-
The release_firmware() function tests whether its argument is NULL and then
return immediately. Thus the test around the call is not needed.This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
Signed-off-by: Takashi Iwai
11 Nov, 2014
1 commit
-
They are no real kerneldoc comments, so drop such markers.
Signed-off-by: Takashi Iwai
29 Oct, 2014
1 commit
-
removed the unused variables. These variables were only being
assigned some value, but the values were never being used.it has been build tested after removing the variables.
Signed-off-by: Sudip Mukherjee
Signed-off-by: Takashi Iwai
21 Oct, 2014
3 commits
-
... and reduce the open codes. Also add missing const to text arrays.
Signed-off-by: Takashi Iwai
-
... and reduce the open codes.
Signed-off-by: Takashi Iwai
-
... and reduce the open codes. Also add missing const to text arrays.
Signed-off-by: Takashi Iwai
13 Aug, 2014
1 commit
-
We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to
meet kernel coding style guidelines. This issue was reported by checkpatch.A simplified version of the semantic patch that makes this change is as
follows (http://coccinelle.lip6.fr/)://
@@
identifier i;
declarer name DEFINE_PCI_DEVICE_TABLE;
initializer z;
@@- DEFINE_PCI_DEVICE_TABLE(i)
+ const struct pci_device_id i[]
= z;//
[bhelgaas: add semantic patch]
Signed-off-by: Benoit Taine
Signed-off-by: Bjorn Helgaas
26 Feb, 2014
3 commits
-
Convert with dev_err() and co from snd_printk(), etc.
Signed-off-by: Takashi Iwai
-
Convert with dev_err() and co from snd_printk(), etc.
Signed-off-by: Takashi Iwai
-
Convert with dev_err() and co from snd_printk(), etc.
Signed-off-by: Takashi Iwai
12 Feb, 2014
1 commit
-
Also remove superfluous snd_card_set_dev() calls.
Signed-off-by: Takashi Iwai
09 Jan, 2014
1 commit
-
Nowadays we have CMA for obtaining the contiguous memory pages
efficiently. Let's kill the old kludge for reserving the memory pages
for large buffers. It was rarely useful (only for preserving pages
among module reloading or a little help by an early boot scripting),
used only by a couple of drivers, and yet it gives too much ugliness
than its benefit.Signed-off-by: Takashi Iwai
05 Jan, 2014
1 commit
-
The lack of comma leads to the wrong channel for an SPDIF channel.
Unfortunately this wasn't caught by compiler because it's still a
valid expression.Reported-by: Alexander Aristov
Cc:
Signed-off-by: Takashi Iwai
29 Oct, 2013
1 commit
-
We tend to make stupid mistakes with strncpy(). Let's take a safer
one, strlcpy().Signed-off-by: Takashi Iwai
25 Oct, 2013
1 commit
-
ASoC: Updates for v3.13
- Further work on the dmaengine helpers, including support for
configuring the parameters for DMA by reading the capabilities of the
DMA controller which removes some guesswork and magic numbers fromm
drivers.
- A refresh of the documentation.
- Conversions of many drivers to direct regmap API usage in order to
allow the ASoC level register I/O code to be removed, this will
hopefully be completed by v3.14.
- Support for using async register I/O in DAPM, reducing the time taken
to implement power transitions on systems that support it.
16 Oct, 2013
1 commit
-
In GCC the sizeof(hdsp_version) is 8 because there is a 2 byte hole at
the end of the struct after ->firmware_rev.Signed-off-by: Dan Carpenter
Signed-off-by: Takashi Iwai
13 Sep, 2013
1 commit
-
'break' after return statement is not necessary.
Signed-off-by: Sachin Kamat
Signed-off-by: Takashi Iwai
20 Aug, 2013
2 commits
-
This patch doesn't change functionality, it only improves readability
and fixes a copy&paste error in a comment.Signed-off-by: Adrian Knoth
Signed-off-by: Takashi Iwai -
Use enum hdspm_ltc_format's fps_30 (corresponds to 4) instead of 30,
Other case branches return 1, 2 or 3 respectively, so 30 obviously is
wrong.Since SNDRV_HDSPM_IOCTL_GET_LTC had never been working due to a
copy&paste error in hdspm.h, this change doesn't break userspace.Signed-off-by: Adrian Knoth
Signed-off-by: Takashi Iwai
15 Jul, 2013
1 commit
-
sound/pci/rme9652/hdspm.c:1110:2-3: Unneeded semicolon
Generated by: coccinelle/misc/semicolon.cocci
Reported-by: Fengguang Wu
Signed-off-by: Takashi Iwai
05 Jul, 2013
12 commits
-
Signed-off-by: Martin Dausel
Signed-off-by: Adrian Knoth
Signed-off-by: Takashi Iwai -
Also use snd_ctl_enum_info() to fill the autosync text fields on AES32
and MADI cards (only users of snd_hdspm_info_autosync_ref).Signed-off-by: Adrian Knoth
Signed-off-by: Takashi Iwai -
Also use snd_ctl_enum_info() to fill the autosync enumerated controls.
Signed-off-by: Adrian Knoth
Signed-off-by: Takashi Iwai -
Use snd_ctl_enum_info() to fill most of the enumerated controls. More
non-trivial occurrences will follow in separate commits.Signed-off-by: Adrian Knoth
Signed-off-by: Takashi Iwai -
This patch finally enables TCO support on RME AES(32) cards.
Signed-off-by: Adrian Knoth
Signed-off-by: Takashi Iwai -
This patch adds a new ALSA control to read the external sample rate from
userspace on RME AES(32) cards.Signed-off-by: Adrian Knoth
Signed-off-by: Takashi Iwai -
This patch refactors the code to query the external sample rate and its
translation into the corresponding enum into a helper function to
prevent future code duplication.A later commit will make use of this new helper function.
Signed-off-by: Adrian Knoth
Signed-off-by: Takashi Iwai -
Also report TCO status and Sync-In via /proc/ on AES(32) cards.
Signed-off-by: Adrian Knoth
Signed-off-by: Takashi Iwai -
This patch enables the user to select "TCO" and "Sync In" as a preferred
sync reference on RME AES(32) cards.Signed-off-by: Adrian Knoth
Signed-off-by: Takashi Iwai -
This patch adds support to read the TCO sample rate in
hdspm_external_sample_rate() on RME AES(32) cards.Signed-off-by: Adrian Knoth
Signed-off-by: Takashi Iwai -
As mentioned in the comment, the AES32 cards must not set the format
bit, since it is used to indicate the preferred sync setting instead.We hence simply skip the corresponding part in the hw_params function.
Signed-off-by: Adrian Knoth
Signed-off-by: Takashi Iwai -
This patch adds AES32 specific code to hdspm_get_tco_sample_rate to
query the TCO sample rate.Signed-off-by: Adrian Knoth
Signed-off-by: Takashi Iwai
