18 Oct, 2008
1 commit
-
Signed-off-by: Manish Katiyar
Signed-off-by: "Theodore Ts'o"
17 Oct, 2008
4 commits
-
If the HUGE_FILE feature flag is not set, don't allow the creation of
large files, instead of automatically enabling the feature flag.
Recent versions of mke2fs will set the HUGE_FILE flag automatically
anyway for ext4 filesystems.Signed-off-by: "Theodore Ts'o"
-
The multiblock allocator needs to be able to release blocks (and issue
a blkdev discard request) when the transaction which freed those
blocks is committed. Previously this was done via a polling mechanism
when blocks are allocated or freed. A much better way of doing things
is to create a jbd2 callback function and attaching the list of blocks
to be freed directly to the transaction structure.Signed-off-by: "Theodore Ts'o"
-
These mount options don't actually do anything any more, so remove
them.Signed-off-by: "Theodore Ts'o"
-
There are some newlines missing in ext4_check_descriptors, which
cause the printk level to be printed out when the next printk call
is made:[ 778.847265] EXT4-fs: ext4_check_descriptors: Block bitmap for group 0
not in group (block 1509949442)!EXT4-fs: group descriptors corrupted!
[ 802.646630] EXT4-fs: ext4_check_descriptors: Inode bitmap for group 0
not in group (block 9043971)!EXT4-fs: group descriptors corrupted!Signed-off-by: Eric Sesterhenn
Signed-off-by: "Theodore Ts'o"
16 Oct, 2008
3 commits
-
The range_cyclic writeback mode uses the address_space writeback_index
as the start index for writeback. With delayed allocation we were
updating writeback_index wrongly resulting in highly fragmented file.
This patch reduces the number of extents reduced from 4000 to 27 for a
3GB file.Signed-off-by: Aneesh Kumar K.V
Signed-off-by: Theodore Ts'o -
Let the block device know when unused blocks can be discarded, using
the new sb_issue_discard() interface.Signed-off-by: "Theodore Ts'o"
-
With this patch we track the block freed during a transaction using
red-black tree. We also make sure contiguous blocks freed are collected
in one node in the tree.Signed-off-by: Aneesh Kumar K.V
Signed-off-by: Theodore Ts'o
14 Oct, 2008
3 commits
-
This enables us to drop the range_cont writeback mode
use from ext4_da_writepages.Signed-off-by: Aneesh Kumar K.V
-
We should use kmem_cache_free to free memory allocated
via kmem_cache_allocSigned-off-by: Aneesh Kumar K.V
Signed-off-by: Theodore Ts'o -
This is a much better version of a previous patch to make the parser
tables constant. Rather than changing the typedef, we put the "const" in
all the various places where its required, allowing the __initconst
exception for nfsroot which was the cause of the previous trouble.This was posted for review some time ago and I believe its been in -mm
since then.Signed-off-by: Steven Whitehouse
Cc: Alexander Viro
Signed-off-by: Linus Torvalds
13 Oct, 2008
1 commit
-
fs/ext4/super.c: In function 'ext4_fill_super':
fs/ext4/super.c:2226: error: 'ext4_ui_proc_fops' undeclared (first use
in this function)
fs/ext4/super.c:2226: error: (Each undeclared identifier is reported
only once
fs/ext4/super.c:2226: error: for each function it appears in.)Signed-off-by: Alexander Beregalov
Signed-off-by: Theodore Ts'o
11 Oct, 2008
5 commits
-
We need to make sure we don't reuse the data blocks released
during the transaction untill the transaction commits. We force
this mode only for ordered and journalled mode. Writeback mode
already don't provided data consistency.Signed-off-by: Aneesh Kumar K.V
Signed-off-by: Theodore Ts'o -
During filesystem recovery we may be doing a truncate
which expects some of the mballoc data structures to
be initialized. So do ext4_mb_init before recovery.Signed-off-by: Aneesh Kumar K.V
Signed-off-by: Theodore Ts'o -
If the journal doesn't abort when it gets an IO error in file data
blocks, the file data corruption will spread silently. Because
most of applications and commands do buffered writes without fsync(),
they don't notice the IO error. It's scary for mission critical
systems. On the other hand, if the journal aborts whenever it gets
an IO error in file data blocks, the system will easily become
inoperable. So this patch introduces a filesystem option to
determine whether it aborts the journal or just call printk() when
it gets an IO error in file data.If you mount an ext4 fs with data_err=abort option, it aborts on file
data write error. If you mount it with data_err=ignore, it doesn't
abort, just call printk(). data_err=ignore is the default.Here is the corresponding patch of the ext3 version:
http://kerneltrap.org/mailarchive/linux-kernel/2008/9/9/3239374Signed-off-by: Hidehiro Kawai
Signed-off-by: Theodore Ts'o -
If the journal has aborted due to a checkpointing failure, we
have to keep the contents of the journal space. Otherwise, the
filesystem will lose uncheckpointed metadata completely and
become inconsistent. To avoid this, we need to keep needs_recovery
flag if checkpoint has failed.With this patch, ext4_put_super() detects a checkpointing failure
from the return value of journal_destroy(), then it invokes
ext4_abort() to make the filesystem read only and keep
needs_recovery flag. Errors from jbd2_journal_flush() are also
handled by this patch in some places.Signed-off-by: Hidehiro Kawai
Signed-off-by: Theodore Ts'o -
The ext4 filesystem is getting stable enough that it's time to drop
the "dev" prefix. Also remove the requirement for the TEST_FILESYS
flag.Signed-off-by: "Theodore Ts'o"
10 Oct, 2008
3 commits
-
This fixes a bug which caused on-line resizing of filesystems with a
1k blocksize to fail. The root cause of this bug was the fact that if
an uninitalized bitmap block gets read in by userspace (which
e2fsprogs does try to avoid, but can happen when the blocksize is less
than the pagesize and an adjacent blocks is read into memory)
ext4_read_block_bitmap() was erroneously depending on the buffer
uptodate flag to decide whether it needed to initialize the bitmap
block in memory --- i.e., to set the standard set of blocks in use by
a block group (superblock, bitmaps, inode table, etc.). Essentially,
ext4_read_block_bitmap() assumed it was the only routine that might
try to read a block containing a block bitmap, which is simply not
true.To fix this, ext4_read_block_bitmap() and ext4_read_inode_bitmap()
must always initialize uninitialized bitmap blocks. Once a block or
inode is allocated out of that bitmap, it will be marked as
initialized in the block group descriptor, so in general this won't
result any extra unnecessary work.Signed-off-by: Frederic Bohe
Signed-off-by: "Theodore Ts'o" -
Signed-off-by: "Theodore Ts'o"
-
With modern hard drives, reading 64k takes roughly the same time as
reading a 4k block. So request readahead for adjacent inode table
blocks to reduce the time it takes when iterating over directories
(especially when doing this in htree sort order) in a cold cache case.
With this patch, the time it takes to run "git status" on a kernel
tree after flushing the caches via "echo 3 > /proc/sys/vm/drop_caches"
is reduced by 21%.Signed-off-by: "Theodore Ts'o"
09 Oct, 2008
3 commits
-
ext4_xattr_set_handle() eventually ends up calling
ext4_mark_inode_dirty() which tries to expand the inode by shifting
the EAs. This leads to the xattr_sem being downed again and leading
to a deadlock.This patch makes sure that if ext4_xattr_set_handle() is in the
call-chain, ext4_mark_inode_dirty() will not expand the inode.Signed-off-by: Kalpak Shah
Signed-off-by: "Theodore Ts'o" -
This patch hooks the ext3 to ext4 migrate interface to
EXT4_IOC_SETFLAGS ioctl. The userspace interface is via chattr +e. We
only allow setting extent flags. Clearing extent flag (migrating from
ext4 to ext3) is not supported.Signed-off-by: Aneesh Kumar K.V
Signed-off-by: "Theodore Ts'o" -
Note: some people thinks this represents a security bug, since it
might make the system go away while it is printing a large number of
console messages, especially if a serial console is involved. Hence,
it has been assigned CVE-2008-3528, but it requires that the attacker
either has physical access to your machine to insert a USB disk with a
corrupted filesystem image (at which point why not just hit the power
button), or is otherwise able to convince the system administrator to
mount an arbitrary filesystem image (at which point why not just
include a setuid shell or world-writable hard disk device file or some
such). Me, I think they're just being silly. --tytsoSigned-off-by: Eric Sandeen
Signed-off-by: "Theodore Ts'o"
Cc: linux-ext4@vger.kernel.org
Cc: Eugene Teo
07 Oct, 2008
3 commits
-
While reading code I noticed that ext4_put_super() dirties the
superblock bh twice. It is always done in ext4_commit_super()
too. Remove the redundant dirty operation.
Should be a nop semantically.Signed-off-by: Andi Kleen
-
ext4_ext_walk_space() was reinstated to be used for iterating over file
extents with a callback; it is used by the ext4 fiemap implementation.Signed-off-by: Eric Sandeen
Signed-off-by: "Theodore Ts'o"
Cc: linux-ext4@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org -
This fixes some very common warnings reported by kerneloops.org
Signed-off-by: "Theodore Ts'o"
06 Oct, 2008
1 commit
-
This debugging markers are designed to debug problems such as the
random filesystem latency problems reported by Arjan.Signed-off-by: "Theodore Ts'o"
24 Sep, 2008
1 commit
-
Previously mballoc created a separate set of functions for each proc
file. This combines the tunables into a single set of functions which
gets used for all of the per-superblock proc files, saving
approximately 2k of compiled object code.Signed-off-by: "Theodore Ts'o"
23 Sep, 2008
2 commits
-
...and into the core setup/teardown code in fs/ext4/super.c so that
other parts of ext4 can define tuning parameters.Signed-off-by: "Theodore Ts'o"
-
This is a port of a patch from Linus which fixes a 200+ byte stack
usage problem in ext4_get_parent().It's more efficient to pass down only the actual parts of the dentry
that matter: the parent inode and the name, instead of allocating a
struct dentry on the stack.Signed-off-by: Linus Torvalds
Signed-off-by: "Theodore Ts'o"
17 Sep, 2008
1 commit
-
Calculate the journal device name once and stash it away in the
journal_s structure. This avoids needing to call bdevname()
everywhere and reduces stack usage by not needing to allocate an
on-stack buffer. In addition, we eliminate the '/' that can appear in
device names (e.g. "cciss/c0d0p9" --- see kernel bugzilla #11321) that
can cause problems when creating proc directory names, and include the
inode number to support ocfs2 which creates multiple journals with
different inode numbers.Signed-off-by: "Theodore Ts'o"
14 Sep, 2008
6 commits
-
lg_prealloc_list seems to cry out for a per-cpu data structure; on a large
smp system I think this should be better. I've lightly tested this change
on a 4-cpu system.Signed-off-by: Eric Sandeen
Acked-by: Aneesh Kumar K.V
Signed-off-by: "Theodore Ts'o" -
Pick an ioctl number for EXT4_IOC_MIGRATE that won't conflict with
other ext4 ioctl's. Since there haven't been any major userspace
users of this ioctl, we can afford to change this now, to avoid
potential problems later.Also, reorder the ioctl numbers in ext4.h to avoid this sort of
mistake in the future.Signed-off-by: "Theodore Ts'o"
-
The migrate ioctl writes to the filsystem, so we need to elevate the
write count.Signed-off-by: Aneesh Kumar K.V
Signed-off-by: "Theodore Ts'o" -
ext4 creates per-suberblock directory in /proc/ext4/ . Name used as
basis is taken from bdevname, which, surprise, can contain slash.However, proc while allowing to use proc_create("a/b", parent) form of
PDE creation, assumes that parent/a was already created.bdevname in question is 'cciss/c0d0p9', directory is not created and all
this stuff goes directly into /proc (which is real bug).Warning comes when _second_ partition is mounted.
http://bugzilla.kernel.org/show_bug.cgi?id=11321
Signed-off-by: Alexey Dobriyan
Signed-off-by: "Theodore Ts'o" -
With delayed allocation we use i_data_sem to update i_disksize. We need
to update i_disksize only if the new size specified is greater than the
current value and we need to make sure we don't race with other
i_disksize update. With delayed allocation we will switch to the
write_begin function for non-delayed allocation if we are low on free
blocks. This means the write_begin function for non-delayed allocation
also needs to use the same locking.We also need to check and update i_disksize even if the new size is less
that inode.i_size because of delayed allocation.Signed-off-by: Aneesh Kumar K.V
Signed-off-by: "Theodore Ts'o" -
For blocksize < pagesize we need to remove blocks that got allocated in
block_write_begin() if we fail with ENOSPC for later blocks.
block_write_begin() internally does this if it allocated pages locally.
This makes sure we don't have blocks outside inode.i_size during ENOSPC.Signed-off-by: Aneesh Kumar K.V
Signed-off-by: "Theodore Ts'o"
09 Sep, 2008
1 commit
-
When we truncate files, the meta-data blocks released are not reused
untill we commit the truncate transaction. That means delayed get_block
request will return ENOSPC even if we have free blocks left. Force a
journal commit and retry block allocation if we get ENOSPC with free
blocks left.Signed-off-by: Aneesh Kumar K.V
Signed-off-by: Mingming Cao
Signed-off-by: "Theodore Ts'o"
08 Sep, 2008
2 commits
-
If there group descriptors are corrupted we need unlock the block
group lock before returning from the function; else we will oops when
freeing a spinlock which is still being held.Signed-off-by: Li Zefan
Signed-off-by: "Theodore Ts'o" -
This fixes a bug which prevented the newly created inodes after a
resize from being used on filesystems with flex_bg.Signed-off-by: Frederic Bohe
Signed-off-by: "Theodore Ts'o"
