06 Feb, 2009
1 commit
-
Oprofile's ring-buffer use was not considered.
Signed-off-by: Ingo Molnar
18 Jan, 2009
1 commit
-
Impact: fix crash
In case of losing samples struct op_entry could have been used
uninitialized causing e.g. a wrong preemption count or NULL pointer
access. This patch fixes this.Signed-off-by: Robert Richter
Signed-off-by: Ingo Molnar
08 Jan, 2009
11 commits
-
This patch creates the new functions
oprofile_write_reserve()
oprofile_add_data()
oprofile_write_commit()and makes them part of the oprofile api.
Signed-off-by: Robert Richter
-
The ifdefs can be removed since the code is no longer ibs specific and
can be used for other purposes as well. IBS specific code is only in
op_model_amd.c.Signed-off-by: Robert Richter
-
The new ring buffer implementation allows the storage of samples with
different size. This patch implements the usage of the new sample
format to store ibs samples in the cpu buffer. Until now, writing to
the cpu buffer could lead to incomplete sampling sequences since IBS
samples were transfered in multiple samples. Due to a full buffer,
data could be lost at any time. This can't happen any more since the
complete data is reserved in advance and then stored in a single
sample.Signed-off-by: Robert Richter
-
This function can be used to attach data to a sample. It returns the
remaining free buffer size that has been reserved with
op_cpu_buffer_write_reserve().Signed-off-by: Robert Richter
-
Special events such as task or context switches are marked with an
escape code in the cpu buffer followed by an event code or a task
identifier. There is one escape code per event. To make escape
sequences also available for data samples the internal cpu buffer
format must be changed. The current implementation does not allow the
extension of event codes since this would lead to collisions with the
task identifiers. To avoid this, this patch introduces an event mask
that allows the storage of multiple events with one escape code. Now,
task identifiers are stored in the data section of the sample. The
implementation also allows the usage of custom data in a sample. As a
side effect the new code is much more readable and easier to
understand.Signed-off-by: Robert Richter
-
This implements the support of samples with attached data.
Signed-off-by: Robert Richter
-
This function prepares the cpu buffer to write a sample.
Struct op_entry is used during operations on the ring buffer while
struct op_sample contains the data that is stored in the ring
buffer. Struct entry can be uninitialized. The function reserves a
data array that is specified by size. Use op_cpu_buffer_write_commit()
after preparing the sample. In case of errors a null pointer is
returned, otherwise the pointer to the sample.Signed-off-by: Robert Richter
-
Rename the fucntion to op_add_sample() since there is a collision with
another one with the same name in buffer_sync.c.Signed-off-by: Robert Richter
-
This code is broken since a TRACE_BEGIN_CODE is never sent to the
daemon. The data becomes corrupt since the backtrace is interpreted as
ibs sample.Signed-off-by: Robert Richter
-
Signed-off-by: Robert Richter
-
Signed-off-by: Robert Richter
30 Dec, 2008
4 commits
-
Signed-off-by: Robert Richter
-
This patch removes the unused return parameter in
oprofile_begin_trace(). Also, oprofile_begin_trace() and
oprofile_end_trace() are inline now.Signed-off-by: Robert Richter
-
This patch adds the inline function __oprofile_add_ext_sample() to
cpu_buffer.c and thus reduces overhead when calling
oprofile_add_sample().Signed-off-by: Robert Richter
-
Reordering code to keep alloc/free functions together.
Signed-off-by: Robert Richter
29 Dec, 2008
2 commits
-
This patch moves ring buffer inline functions to cpu_buffer.c.
Cc: Andrew Morton
Signed-off-by: Robert Richter -
This patch renames cpu buffer functions to something more oprofile
specific names. Functions will be moved to the global name space.Cc: Andrew Morton
Signed-off-by: Robert Richter
17 Dec, 2008
1 commit
-
This patch renames kernel-wide identifiers to something more oprofile
specific names.Cc: Andrew Morton
Signed-off-by: Robert Richter
11 Dec, 2008
2 commits
-
The number of lost samples could be greater than the number of
received samples. This patches fixes this. The implementation
introduces return values for add_sample() and add_code().Signed-off-by: Robert Richter
-
This function is no longer available after the port to the new ring
buffer. Its removal can lead to incomplete sampling sequences since
IBS samples and backtraces are transfered in multiple samples. Due to
a full buffer, samples could be lost any time. The userspace daemon
has to live with such incomplete sampling sequences as long as the
data within one sample is consistent.This will be fixed by changing the internal buffer data there all data
of one IBS sample or a backtrace is packed in a single ring buffer
entry. This is possible since the new ring buffer supports variable
data size.Signed-off-by: Robert Richter
10 Dec, 2008
6 commits
-
This patch replaces the current oprofile cpu buffer implementation
with the ring buffer provided by the tracing framework. The motivation
here is to leave the pain of implementing ring buffers to others. Oh,
no, there are more advantages. Main reason is the support of different
sample sizes that could be stored in the buffer. Use cases for this
are IBS and Cell spu profiling. Using the new ring buffer ensures
valid and complete samples and allows copying the cpu buffer stateless
without knowing its content. Second it will use generic kernel API and
also reduce code size. And hopefully, there are less bugs.Since the new tracing ring buffer implementation uses spin locks to
protect the buffer during read/write access, it is difficult to use
the buffer in an NMI handler. In this case, writing to the buffer by
the NMI handler (x86) could occur also during critical sections when
reading the buffer. To avoid this, there are 2 buffers for independent
read and write access. Read access is in process context only, write
access only in the NMI handler. If the read buffer runs empty, both
buffers are swapped atomically. There is potentially a small window
during swapping where the buffers are disabled and samples could be
lost.Using 2 buffers is a little bit overhead, but the solution is clear
and does not require changes in the ring buffer implementation. It can
be changed to a single buffer solution when the ring buffer access is
implemented as non-locking atomic code.The new buffer requires more size to store the same amount of samples
because each sample includes an u32 header. Also, there is more code
to execute for buffer access. Nonetheless, the buffer implementation
is proven in the ftrace environment and worth to use also in oprofile.Patches that changes the internal IBS buffer usage will follow.
Cc: Steven Rostedt
Signed-off-by: Robert Richter -
This is in preparation for changes in the cpu buffer implementation.
Signed-off-by: Robert Richter
-
This is in preparation for changes in the cpu buffer implementation.
Signed-off-by: Robert Richter
-
This is in preparation for changes in the cpu buffer implementation.
Signed-off-by: Robert Richter
-
Signed-off-by: Robert Richter
-
This fixes the coding style of some comments.
Signed-off-by: Robert Richter
24 Oct, 2008
1 commit
-
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile: (21 commits)
OProfile: Fix buffer synchronization for IBS
oprofile: hotplug cpu fix
oprofile: fixing whitespaces in arch/x86/oprofile/*
oprofile: fixing whitespaces in arch/x86/oprofile/*
oprofile: fixing whitespaces in drivers/oprofile/*
x86/oprofile: add the logic for enabling additional IBS bits
x86/oprofile: reordering functions in nmi_int.c
x86/oprofile: removing unused function parameter in add_ibs_begin()
oprofile: more whitespace fixes
oprofile: whitespace fixes
OProfile: Rename IBS sysfs dir into "ibs_op"
OProfile: Rework string handling in setup_ibs_files()
OProfile: Rework oprofile_add_ibs_sample() function
oprofile: discover counters for op ppro too
oprofile: Implement Intel architectural perfmon support
oprofile: Don't report Nehalem as core_2
oprofile: drop const in num counters field
Revert "Oprofile Multiplexing Patch"
x86, oprofile: BUG: using smp_processor_id() in preemptible code
x86/oprofile: fix on_each_cpu build error
...Manually fixed trivial conflicts in
drivers/oprofile/{cpu_buffer.c,event_buffer.h}
21 Oct, 2008
1 commit
-
The issue is the SPU code is not holding the kernel mutex lock while
adding samples to the kernel buffer.This patch creates per SPU buffers to hold the data. Data
is added to the buffers from in interrupt context. The data
is periodically pushed to the kernel buffer via a new Oprofile
function oprofile_put_buff(). The oprofile_put_buff() function
is called via a work queue enabling the funtion to acquire the
mutex lock.The existing user controls for adjusting the per CPU buffer
size is used to control the size of the per SPU buffers.
Similarly, overflows of the SPU buffers are reported by
incrementing the per CPU buffer stats. This eliminates the
need to have architecture specific controls for the per SPU
buffers which is not acceptable to the OProfile user tool
maintainer.The export of the oprofile add_event_entry() is removed as it
is no longer needed given this patch.Note, this patch has not addressed the issue of indexing arrays
by the spu number. This still needs to be fixed as the spu
numbering is not guarenteed to be 0 to max_num_spus-1.Signed-off-by: Carl Love
Signed-off-by: Maynard Johnson
Signed-off-by: Arnd Bergmann
Acked-by: Acked-by: Robert Richter
Signed-off-by: Benjamin Herrenschmidt
17 Oct, 2008
1 commit
-
This patch addresses problems when hotplugging cpus while
profiling. Instead of allocating only online cpus, all possible cpu
buffers are allocated, which allows cpus to be onlined during
operation. If a cpu is offlined before profiling is shutdown
wq_sync_buffer checks for this condition then cancels this work and
does not sync this buffer.Signed-off-by: Chris J Arges
Signed-off-by: Robert Richter
16 Oct, 2008
3 commits
-
Signed-off-by: Robert Richter
-
Signed-off-by: Robert Richter
-
Code looks much more cleaner now.
Signed-off-by: Robert Richter
13 Oct, 2008
1 commit
-
Conflicts:
arch/x86/kernel/apic_32.c
arch/x86/oprofile/nmi_int.c
include/linux/pci_ids.h
30 Sep, 2008
1 commit
-
Conflicts:
arch/x86/oprofile/nmi_int.cSigned-off-by: Ingo Molnar
26 Aug, 2008
1 commit
-
If an error occurs on opcontrol start, the event and per cpu buffers
are released. If later opcontrol shutdown is called then the free
function will be called again to free buffers that no longer
exist. This results in a kernel oops. The following changes
prevent the call to delete buffers that don't exist.Signed-off-by: Carl Love
Signed-off-by: Arnd Bergmann
Acked-by: Robert Richter
Signed-off-by: Paul Mackerras
26 Jul, 2008
3 commits
-
Signed-off-by: Robert Richter
Cc: oprofile-list
Cc: Robert Richter
Cc: Barry Kasindorf
Signed-off-by: Ingo Molnar -
Signed-off-by: Robert Richter
Cc: oprofile-list
Cc: Robert Richter
Cc: Barry Kasindorf
Signed-off-by: Ingo Molnar -
This patchset supports the new profiling hardware available in the
latest AMD CPUs in the oProfile driver.Signed-off-by: Barry Kasindorf
Signed-off-by: Robert Richter
Cc: oprofile-list
Signed-off-by: Ingo Molnar
