19 Apr, 2013
3 commits
-
Signed-off-by: Mark Brown
-
Don't silently ignore errors, report them.
Signed-off-by: Mark Brown
-
The multiplatform conversion in commit 788437 (spi: s3c64xx: move to
generic dmaengine API) tested for the use of the Samsung-specific DMA
API with SAMSUNG_DMADEV when in fact S3C_DMA should be used. This
renderd DMA based transfers non-functional on platforms not using
dmaengine.Signed-off-by: Mark Brown
18 Apr, 2013
1 commit
-
Fix to return a negative error code from the error handling
case instead of 0, as returned elsewhere in this function.Signed-off-by: Wei Yongjun
Signed-off-by: Mark Brown
16 Apr, 2013
3 commits
-
With device core now able to setup the default pin configuration,
the pin configuration code based on the deprecated Samsung specific
gpio bindings is removed.Signed-off-by: Thomas Abraham
Signed-off-by: Doug Anderson
Acked-by: Linus Walleij
Reviewed-by: Doug Anderson
Tested-by: Doug Anderson
Signed-off-by: Grant Likely -
I've taken a full time position with Linaro and so I'll be using my
Linaro email address from this point on. It has also been many years
since I've touched any of the Xilinx related code so mark those items as
unmaintained.In addition, Mark Brown is taking the lead on SPI maintainership now, so
I've reversed the order of our names for that entry.Signed-off-by: Grant Likely
Cc: Mark Brown
Cc: Linus Walleij
Cc: Rob Herring -
Selecting CONFIG_DMADEVICES is optional, and we must
be able to continue even without DMA. Otherwise things
like omap4430sdp nfsroot will fail if DMA is not
selected.Note that the driver already supports PIO mode, but
we fail to fall back to PIO if requesting DMA channels
fails.Signed-off-by: Tony Lindgren
Signed-off-by: Mark Brown
12 Apr, 2013
1 commit
-
The spi-s3c64xx uses a Samsung proprietary interface for
talking to the DMA engine, which does not work with
multiplatform kernels.This version of the patch leaves the old code in place,
behind an #ifdef. This can be removed in the future,
after the s3c64xx platform start supporting the regular
dmaengine interface. An earlier version of this patch was
tested successfully on exynos5250 by Padma Venkat.The conversion was rather mechanical, since the samsung
interface is just a shallow wrapper around the dmaengine
interface.Signed-off-by: Arnd Bergmann
10 Apr, 2013
3 commits
-
spi_bitbang_setup() deasserts the chip select line to initialise
the device. The chip select GPIO line is obtained from
spi_gpio->cs_gpios[] private data.
Currently, devices that are not registered under devicetree
environment will call into spi_bitbang_setup() with stale
cs_gpios[].This patch ensures spi_gpio->cs_gpios[] is always initialised prior
to calling spi_bitbang_setup().Reviewed-by: Daniel Mack
Signed-off-by: Josef Ahmad
Signed-off-by: Mark Brown -
There is no need to disable transmitter/receiver after each loop
iteration and re-enable it for next loop iteration. Enable the
transmitter/receiver before xfer loop starts and disable it when
the whole transfer is done.Signed-off-by: Anatolij Gustschin
Signed-off-by: Mark Brown -
Currently the driver only uses one internal chip select.
Add support for gpio chip selects configured by cs-gpios
DT binding.Signed-off-by: Anatolij Gustschin
Signed-off-by: Mark Brown
08 Apr, 2013
3 commits
-
speed_hz is a write only member, so we can safely remove it and its
generation. Also fixes the missing clk_put after getting the periph
clock.Signed-off-by: Jonas Gorski
Signed-off-by: Mark Brown -
Neither tegra20_spi_cdata nor tegra30_spi_cdata are used outside this
file so they can, and should, be static.Signed-off-by: Wei Yongjun
Reviewed-by: Thierry Reding
Signed-off-by: Mark Brown -
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.Signed-off-by: Sachin Kamat
Acked-by: Eric Miao
Signed-off-by: Mark Brown
07 Apr, 2013
12 commits
-
Add SPI driver for NVIDIA's Tegra114 SPI controller. This controller
is different than the older SoCs SPI controller in internal design as
well as register interface.This driver supports the:
- non DMA based transfer for smaller transfer i.e. less than FIFO depth.
- APB DMA based transfer for larger transfer i.e. more than FIFO depth.
- Clock gating through runtime PM callbacks.
- registration through DT only.Signed-off-by: Laxman Dewangan
Reviewed-by: Stephen Warren
Signed-off-by: Grant Likely -
The platform data header is no longer used. Delete it.
Signed-off-by: Stephen Warren
Signed-off-by: Grant Likely -
Tegra only supports, and always enables, device tree. Remove all ifdefs
and runtime checks for DT support from the driver. Platform data is
therefore no longer required. Rework the driver to parse the device tree
directly into struct tegra_slink_data.Signed-off-by: Stephen Warren
Signed-off-by: Grant Likely -
Tegra only supports, and always enables, device tree. Remove all ifdefs
and runtime checks for DT support from the driver. Platform data is
therefore no longer required. Rework the driver to parse the device tree
directly into struct tegra_sflash_data.Signed-off-by: Stephen Warren
Signed-off-by: Grant Likely -
There is no code to set spi->controller_data, and hence the HW CS logic
can never trigger. Remove the unused code.Signed-off-by: Stephen Warren
Signed-off-by: Grant Likely -
This relies upon of_spi_register_master to find out which gpios to use.
Acked-by: Anton Vorontsov
Signed-off-by: Andreas Larsson
Signed-off-by: Grant Likely -
This adds support for the mostly register-compatible SPICTRL cores from the
GRLIB VHDL IP core library from Aeroflex Gaisler. They are normally running on
SPARC. A different entry in of_fsl_spi_match matches this core and indicates a
different hardware type that is used to set up different function pointers and
special cases.The GRLIB core operates in cpu mode. The number of bits per word might be
limited. There might be native chipselects selected via a slave select
register. These differences to the FSL type cores, if present, are indicated by
a capabilities register. Other register and function differences exists but are
not relevant to the driver.Acked-by: Anton Vorontsov
Signed-off-by: Andreas Larsson
Signed-off-by: Grant Likely -
Acked-by: Anton Vorontsov
Signed-off-by: Andreas Larsson
Signed-off-by: Grant Likely -
For being able to distinguishing between the regular type of cores and others
with different entries in of_fsl_spi_match.Acked-by: Anton Vorontsov
Signed-off-by: Andreas Larsson
Signed-off-by: Grant Likely -
Acked-by: Anton Vorontsov
Signed-off-by: Andreas Larsson
Signed-off-by: Grant Likely -
This is needed for a device in SPI_CS_HIGH mode that otherwise could start out
active for the first transaction.Acked-by: Anton Vorontsov
Signed-off-by: Andreas Larsson
Signed-off-by: Grant Likely -
This makes the spi-fsl-spi driver usable in CPU mode outside of an FSL_SOC and
even an powerpc environment by moving CPM mode functionality to a separate file
that is only compiled and linked in an FSL_SOC environment and adding some
ifdefs to hide types and functions or provide alternatives.For devicetree probing a "clock-frequency" property is used for clock frequency
instead of calls to FSL_SOC-specific functions.Acked-by: Anton Vorontsov
Signed-off-by: Andreas Larsson
Signed-off-by: Grant Likely
04 Apr, 2013
2 commits
-
Fix to return a negative error code from the error handling
case instead of 0, as returned elsewhere in this function.Signed-off-by: Wei Yongjun
Signed-off-by: Mark Brown -
This reverts commit faa98f7ea6c720beec8a800c9ac6975f760467e2 which was
applied in error due to discussion ending up in the wrong thread.
01 Apr, 2013
12 commits
-
Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following
build warning when CONFIG_PM_SLEEP is not selected. This is because
sleep PM callbacks defined by SET_SYSTEM_SLEEP_PM_OPS are only used
when the CONFIG_PM_SLEEP is enabled.drivers/spi/spi-s3c64xx.c:1362:12: warning: 's3c64xx_spi_suspend' defined but not used [-Wunused-function]
drivers/spi/spi-s3c64xx.c:1381:12: warning: 's3c64xx_spi_resume' defined but not used [-Wunused-function]Signed-off-by: Jingoo Han
Signed-off-by: Mark Brown -
The status of transfer is stored in controller data structure
so that it can be used not only by atmel_spi_msg_done() function.
This will be useful for upcoming dmaengine enabled driver.Signed-off-by: Nicolas Ferre
Signed-off-by: Wenyou Yang
Signed-off-by: Mark Brown -
Signed-off-by: Nicolas Ferre
Signed-off-by: Wenyou Yang
Signed-off-by: Mark Brown -
Signed-off-by: Wenyou Yang
Acked-by: Nicolas Ferre
Signed-off-by: Mark Brown -
The "has_dma_support" needed for future use with dmaengine driver.
[Fixed some unneded ternery operators -- broonie]
Signed-off-by: Wenyou Yang
Acked-by: Nicolas Ferre
Signed-off-by: Mark Brown -
Spi starts transfer using dma with DMA_CTRL_ACK which is not require
becasue spi driver does not use completed dma_desc after transfer
done and so it does not ack the dma descriptor. Removing the
DMA_CTRL_ACK flag to avoid memory leak in dma driver.Signed-off-by: Laxman Dewangan
Signed-off-by: Mark Brown -
Replaced calls to IS_ERR and PTR_ERR with PTR_RET function.
Patch found using coccinelle.Signed-off-by: Alexandru Gheorghiu
Signed-off-by: Mark Brown -
Replaced calls to IS_ERR and PTR_ERR with PTR_RET function.
Patch found using coccinelle.Signed-off-by: Alexandru Gheorghiu
Signed-off-by: Mark Brown -
Some SPI slave devices require asserted chip select signal across
multiple transfer segments of an SPI message. Currently the driver
always de-asserts the internal SS signal for every single transfer
segment of the message and ignores the 'cs_change' flag of the
transfer description. Disable the internal chip select (SS) only
if this is needed and indicated by the 'cs_change' flag.Without this change, each partial transfer of a surrounding
multi-part SPI transaction might erroneously change the SS
signal, which might prevent slaves from answering the request
that was sent in a previous transfer segment because the
transaction could be considered aborted (SS was de-asserted
before reading the response).Reported-by: Gerhard Sittig
Signed-off-by: Anatolij Gustschin
Signed-off-by: Mark Brown
Cc: stable@vger.kernel.org -
The variable bits_per_word is initialized but never used
otherwise, so remove the unused variable.Signed-off-by: Wei Yongjun
Acked-By: Laxman Dewangan
Signed-off-by: Mark Brown -
This eliminates having an #ifdef returning NULL for the case
when OF is disabled.Signed-off-by: Sachin Kamat
Signed-off-by: Mark Brown
