07 Sep, 2011
4 commits
-
In tegra_i2c_fill_tx_fifo, once we have finished pushing all the bytes
to the I2C hardware controller, the interrupt might happen before we
have updated i2c_dev->msg_buf_remaining at the end of the function.
Then, in tegra_i2c_isr, we will call again tegra_i2c_fill_tx_fifo
triggering weird behaviour. This has been shown to happen under real
conditions.Signed-off-by: Doug Anderson
Tested-by: Vincent Palatin
Acked-by: Rhyland Klein
Acked-by: Stephen Warren
Signed-off-by: Stephen Warren
Signed-off-by: Ben Dooks -
Signed-off-by: Mike Rapoport
Signed-off-by: Stephen Warren
Signed-off-by: Ben Dooks -
This patch was intended to be part of 7ca2d1a105a239e300b937e9c41a10a4bd08f569
"i2c: Tegra: Add DeviceTree support". However, an early version of that patch,
which was missing a chunk, was applied to next-i2c. This change is that
missing chunk.Signed-off-by: John Bonesio
Signed-off-by: Stephen Warren
Signed-off-by: Ben Dooks -
Signed-off-by: Axel Lin
Acked-by: Sebastian Andrzej Siewior
Signed-off-by: Ben Dooks
25 Aug, 2011
1 commit
-
There was a missing struct item in the kerneldoc, add it and fix
another pretty-printing formatting issue with a missing space.Signed-off-by: Linus Walleij
Signed-off-by: Ben Dooks
24 Aug, 2011
2 commits
-
This reverts commit adf6e07922255937c8bfeea777d19502b4c9a2be.
Remove system PM methods which can race with runtime PM methods.
Also, as of v3.1, the PM domain level code for OMAP handles device
power state transistions automatically for devices, so drivers no
longer need to specifically call the bus/pm_domain methods themselves.Signed-off-by: Kevin Hilman
Signed-off-by: Ben Dooks -
If there is a signal pending and wait_for_completion_interruptible_timeout
exited because of the -ERESTARTSYS error we are unable to send any more
i2c messages.So, deprecate this _interruptible_ variant call.
Signed-off-by: Srinidhi Kasagar
Signed-off-by: Linus Walleij
Signed-off-by: Ben Dooks
27 Jul, 2011
3 commits
-
issue-1
In case combined transfer mode fails halfway, the processing must be stopped halfway.
However currently, the processing is continued.
This patch breaks the processing.issue-2
Currently, pch_i2c_xfer returns read/write size at that time.
However pch_i2c_xfer must return the number of messages to be read/written.
This patch modifies correctly.Signed-off-by: Tomoya MORINAGA
Signed-off-by: Ben Dooks -
Currently, Combined R/W transfer mode is not supported.
This patch enables Combined R/W transfer mode.Signed-off-by: Tomoya MORINAGA
Signed-off-by: Ben Dooks -
This patch modifies the tegra i2c driver so that it can be initiailized
using the device tree along with the devices connected to the i2c bus.Signed-off-by: John Bonesio
Acked-by: Grant Likely
Acked-by: OIof Johansson
Signed-off-by: Ben Dooks
26 Jul, 2011
1 commit
-
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (43 commits)
fs: Merge split strings
treewide: fix potentially dangerous trailing ';' in #defined values/expressions
uwb: Fix misspelling of neighbourhood in comment
net, netfilter: Remove redundant goto in ebt_ulog_packet
trivial: don't touch files that are removed in the staging tree
lib/vsprintf: replace link to Draft by final RFC number
doc: Kconfig: `to be' -> `be'
doc: Kconfig: Typo: square -> squared
doc: Konfig: Documentation/power/{pm => apm-acpi}.txt
drivers/net: static should be at beginning of declaration
drivers/media: static should be at beginning of declaration
drivers/i2c: static should be at beginning of declaration
XTENSA: static should be at beginning of declaration
SH: static should be at beginning of declaration
MIPS: static should be at beginning of declaration
ARM: static should be at beginning of declaration
rcu: treewide: Do not use rcu_read_lock_held when calling rcu_dereference_check
Update my e-mail address
PCIe ASPM: forcedly -> forcibly
gma500: push through device driver tree
...Fix up trivial conflicts:
- arch/arm/mach-ep93xx/dma-m2p.c (deleted)
- drivers/gpio/gpio-ep93xx.c (renamed and context nearby)
- drivers/net/r8169.c (just context changes)
25 Jul, 2011
2 commits
-
Currently, if an i2c bus driver supports both static and dynamic bus
ids, it needs to choose between calling i2c_add_numbered_adapter() and
i2c_add_adapter(). This patch makes i2c_add_numbered_adapter()
redirect to i2c_add_adapter() if the requested bus id is -1.Signed-off-by: Grant Likely
Signed-off-by: Jean Delvare -
This is a fix-style patch for i2c-ali1535 (issues reported by
checkpatch.pl.)Signed-off-by: LABBE Corentin
Signed-off-by: Jean Delvare
11 Jul, 2011
3 commits
-
Signed-off-by: Michael Witten
Signed-off-by: Jiri Kosina -
Sync with Linus' tree to be able to apply pending patches that
are based on newer code already present upstream. -
Make sure that the 'static' keywork is at the beginning of declaration
for drivers/i2c/busses/i2c-omap.cThis gets rid of warnings like
warning: ‘static’ is not at beginning of declaration
when building with -Wold-style-declaration (and/or -Wextra which also
enables it).Signed-off-by: Jesper Juhl
Signed-off-by: Jiri Kosina
08 Jul, 2011
1 commit
-
* 'for-30-rc5/all-i2c' of git://git.fluff.org/bjdooks/linux:
i2c-bfin-twi: abort transfer is MEM bit is reset unexpectedly
i2c-s3c2410: Remove useless break code
i2c-s3c2410: Fix typo 'i2s' -> 'i2c'
i2c: tegra: Assign unused slave address
29 Jun, 2011
2 commits
-
pca954x power-on default is channel 0 connected. If multiple pca954x
muxes are connected to the same physical I2C bus, the parent bus will
see channel 0 devices behind both muxes by default. This is bad.Scenario:
-- pca954x @ 0x70 -- ch 0 (I2C-bus-101) -- EEPROM @ 0x50
|
I2C-bus-1 ---
|
-- pca954x @ 0x71 -- ch 0 (I2C-bus-111) -- EEPROM @ 0x501. Load I2C bus driver: creates I2C-bus-1
2. Load pca954x driver: creates virtual I2C-bus-101 and I2C-bus-111
3. Load eeprom driver
4. Try to read EEPROM @ 0x50 on I2C-bus-101. The transaction will also bleed
onto I2C-bus-111 because pca954x @ 0x71 channel 0 is connected by default.Fix: Initialize pca954x to disconnected state in pca954x_probe()
Signed-off-by: Petri Gynther
Signed-off-by: Jean Delvare
Cc: stable@kernel.org -
* Print all error and information messages even when debugging is
disabled.
* Don't use adapter device to log messages before it is ready.Signed-off-by: Jean Delvare
Cc: stable@kernel.org
28 Jun, 2011
5 commits
-
…' and 'for-30-rc4/i2c-tegra' into for-30-rc5/all-i2c
-
Sometimes, the first I2C transmit interrupt is not serviced in time (like
when higher priority interrupts take too long). Since the RESTART bit is
not set before the next I2C clock, when the TWI handler is finally called,
the I2C session is aborted (MEM bit is reset) and both SMITSERV and MCOMP
int status bits are set.So when this happens, abort the transfer.
Reported-by: Isabelle Leonardi
Signed-off-by: Sonic Zhang
Signed-off-by: Mike Frysinger
Signed-off-by: Ben Dooks -
Signed-off-by: Jonghwan Choi
Signed-off-by: Kukjin Kim
Signed-off-by: Ben Dooks -
Signed-off-by: Huisung Kang
Signed-off-by: Kukjin Kim
Signed-off-by: Ben Dooks -
On Tegra, we should always use the "new" I2C slave controller, to avoid
issues with the old controller. This was implemented in commit 65a1a0a
"i2c: tegra: Enable new slave mode."There is currently no driver for the Tegra I2C slave controller upstream.
Additionally, the controller cannot be completely disabled. Instead, we
need to:a) Set I2C_SL_CNFG_NACK to make the controller automatically NACK any
incoming transactions.b) The controller's definition of NACK isn't identical to the I2C
protocol's definition. Specifically, it will perform a standard NACK, but
*also* continue to hold the clock line low in expectation of receiving
more data. This can hang the bus, or at least cause transaction timeouts,
if something starts a transaction that matches the controller's slave
address. Since the default address is 0x00, the general call address,
this does occur in practice.To avoid this, we explicitly program a slave address that is reserved for
future expansion. For current boards, this guarantees the address will
never be used. If a future board ever needs to use this address, we can
add platform data to determine a board-specific safe address. 0xfc is
picked by this patch.This patch is based on a change previously posted by: Wei Ni
http://www.spinics.net/lists/linux-i2c/msg05437.html
In turned based on internal changes by: Bharat NihalaniA semantically equivalent change has been contained in the various
ChromeOS kernels for a while.I tested this change on top of 3.0-rc2 on Harmony, and interacted with
the WM8903 I2C-based audio codec.Signed-off-by: Stephen Warren
Signed-off-by: Ben Dooks
24 Jun, 2011
1 commit
-
Just tyops.
Signed-off-by: Joe Perches
Signed-off-by: Jiri Kosina
27 May, 2011
1 commit
-
With the addition of a device platform mfd_cell pointer, MFD drivers
can go back to passing platform data back to their sub drivers.
This allows for an mfd_cell->mfd_data removal and thus keep the
sub drivers MFD agnostic. This is mostly needed for non MFD aware
sub drivers.Acked-by: Richard Röjfors
Signed-off-by: Samuel Ortiz
25 May, 2011
14 commits
-
* 'for-linus/2640/i2c' of git://git.fluff.org/bjdooks/linux: (21 commits)
mach-ux500: set proper I2C platform data from MOP500s
i2c-nomadik: break out single messsage transmission
i2c-nomadik: reset the hw after status check
i2c-nomadik: remove the unnecessary delay
i2c-nomadik: change the TX and RX threshold
i2c-nomadik: add code to retry on timeout failure
i2c-nomadik: use pm_runtime API
i2c-nomadik: print abort cause only on abort tag
i2c-nomadik: correct adapter timeout initialization
i2c-nomadik: remove the redundant error message
i2c-nomadik: corrrect returned error numbers
i2c-nomadik: fix speed enumerator
i2c-nomadik: make i2c timeout specific per i2c bus
i2c-nomadik: add regulator support
i2c: i2c-sh_mobile bus speed platform data V2
i2c: i2c-sh_mobile clock string removal
i2c-eg20t: Support new device ML7223 IOH
i2c: tegra: Add de-bounce cycles.
i2c: tegra: fix repeated start handling
i2c: tegra: recover from spurious interrupt storm
... -
…a' and 'for-2639/i2c-nomadik2' into for-linus/2640/i2c
-
Reduce code size in the message transfer function by factoring out
a single-message transfer function.Signed-off-by: Linus Walleij
Signed-off-by: Ben Dooks -
In case of I2C timeout, reset the HW only after the HW status
is read, otherwise the staus will be lost.Signed-off-by: Virupax Sadashivpetimath
Reviewed-by: Jonas Aberg
Reviewed-by: Srinidhi Kasagar
Signed-off-by: Linus Walleij
Signed-off-by: Ben Dooks -
The delay in the driver seems to be not needed, so remove it.
Signed-off-by: Virupax Sadashivpetimath
Reviewed-by: Markus Grape
Tested-by: Per Persson
Tested-by: Chethan Krishna N
Reviewed-by: Srinidhi Kasagar
Signed-off-by: Linus Walleij
Signed-off-by: Ben Dooks -
1) Increase RX FIFO threshold so that there is a reduction in
the number of interrupts handled to complete a transaction.2) Fill TX FIFO in the write function.
Signed-off-by: Virupax Sadashivpetimath
Reviewed-by: Jonas Aberg
Signed-off-by: Linus Walleij
Signed-off-by: Ben Dooks -
It is seen that i2c-nomadik controller randomly stops generating the
interrupts leading to a i2c timeout. As a workaround to this problem,
add retries to the on going transfer on failure.Signed-off-by: Virupax Sadashivpetimath
Reviewed-by: Jonas ABERG
Signed-off-by: Linus Walleij
Signed-off-by: Ben Dooks -
Use the pm_runtime API for pins control.
Signed-off-by: Rabin Vincent
Reviewed-by: Srinidhi Kasagar
Reviewed-by: Jonas Aberg
[deleted some surplus runtime PM code]
Signed-off-by: Linus Walleij
Signed-off-by: Ben Dooks -
Modify the code to:
1)Print the cause of i2c failure only if the status is set to ABORT.
2)Print slave address on send/receive fail, will help in which slave
failed.Signed-off-by: Virupax Sadashivpetimath
Reviewed-by: Jonas Aberg
Signed-off-by: Linus Walleij
Signed-off-by: Ben Dooks -
Correct the incorrect initialization of adapter timeout not to be
in milliseconds, as it needs to be done in jiffies.Signed-off-by: Virupax Sadashivpetimath
Reviewed-by: Srinidhi Kasagar
Signed-off-by: Linus Walleij
Signed-off-by: Ben Dooks -
The abort cause string itself is an error, so remove the redundant
explicit error message.Signed-off-by: Srinidhi Kasagar
Reviewed-by: Jonas Aberg
Signed-off-by: Linus Walleij
Signed-off-by: Ben Dooks -
The code was returning bad error numbers or just -1 in some cases.
Signed-off-by: Virupax Sadashivpetimath
Reviewed-by: Srinidhi Kasagar
Signed-off-by: Linus Walleij
Signed-off-by: Ben Dooks -
Add option to have different i2c timeout delay for different i2c buses
specified in platform data. Default to the old value unless specified.Signed-off-by: Virupax Sadashivpetimath
Reviewed-by: Srinidhi Kasagar
Signed-off-by: Linus Walleij
Signed-off-by: Ben Dooks -
This on-chip I2C controller needs to fetch the regulator
representing its voltage domain so that it won't be switched off.Signed-off-by: Jonas Aberg
Signed-off-by: Linus Walleij
Signed-off-by: Ben Dooks
