31 Mar, 2011
1 commit
-
Fixes generated by 'codespell' and manually reviewed.
Signed-off-by: Lucas De Marchi
25 Mar, 2011
1 commit
-
* 'v4l_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6: (442 commits)
[media] videobuf2-dma-contig: make cookie() return a pointer to dma_addr_t
[media] sh_mobile_ceu_camera: Do not call vb2's mem_ops directly
[media] V4L: soc-camera: explicitly require V4L2_BUF_TYPE_VIDEO_CAPTURE
[media] v4l: soc-camera: Store negotiated buffer settings
[media] rc: interim support for 32-bit NEC-ish scancodes
[media] mceusb: topseed 0x0011 needs gen3 init for tx to work
[media] lirc_zilog: error out if buffer read bytes != chunk size
[media] lirc: silence some compile warnings
[media] hdpvr: use same polling interval as other OS
[media] ir-kbd-i2c: pass device code w/key in hauppauge case
[media] rc/keymaps: Remove the obsolete rc-rc5-tv keymap
[media] remove the old RC_MAP_HAUPPAUGE_NEW RC map
[media] rc/keymaps: Rename Hauppauge table as rc-hauppauge
[media] rc-rc5-hauppauge-new: Fix Hauppauge Grey mapping
[media] rc-rc5-hauppauge-new: Add support for the old Black RC
[media] rc-rc5-hauppauge-new: Add the old control to the table
[media] rc-winfast: Fix the keycode tables
[media] a800: Fix a few wrong IR key assignments
[media] opera1: Use multimedia keys instead of an app-specific mapping
[media] dw2102: Use multimedia keys instead of an app-specific mapping
...Fix up trivial conflicts (remove/modify and some real conflicts) in:
arch/arm/mach-omap2/devices.c
drivers/staging/Kconfig
drivers/staging/Makefile
drivers/staging/dabusb/dabusb.c
drivers/staging/dabusb/dabusb.h
drivers/staging/easycap/easycap_ioctl.c
drivers/staging/usbvideo/usbvideo.c
drivers/staging/usbvideo/vicam.c
23 Mar, 2011
11 commits
-
The rc-hauppauge-new map is a messy thing, as it bundles 3
different remote controllers as if they were just one,
discarding the address byte. Also, some key maps are wrong.With the conversion to the new rc-core, it is likely that
most of the devices won't be working properly, as the i2c
driver and the raw decoders are now providing 16 bits for
the remote, instead of just 8.delete mode 100644 drivers/media/rc/keymaps/rc-hauppauge-new.c
Signed-off-by: Mauro Carvalho Chehab
Signed-off-by: Jarod Wilson -
There are two "hauppauge-new" keymaps, one with protocol
unknown, and the other with the protocol marked accordingly.
However, both tables are miss-named.Also, the old rc-hauppauge-new is broken, as it mixes
three different controllers as if they were just one.This patch solves half of the problem by renaming the
correct keycode table as just rc-hauppauge. This table
contains the codes for the four different types of
remote controllers found on Hauppauge cards, properly
mapped with their different addresses.create mode 100644 drivers/media/rc/keymaps/rc-hauppauge.c
delete mode 100644 drivers/media/rc/keymaps/rc-rc5-hauppauge-new.c
[Jarod: fix up RC_MAP_HAUPPAUGE defines]Signed-off-by: Mauro Carvalho Chehab
Signed-off-by: Jarod Wilson -
Signed-off-by: Mauro Carvalho Chehab
Signed-off-by: Jarod Wilson -
This driver uses an app-specific keymap for one of the tables. This
is wrong. Instead, use the standard keycodes.Signed-off-by: Mauro Carvalho Chehab
Signed-off-by: Jarod Wilson -
This driver uses an app-specific keymap for one of the tables. This
is wrong. Instead, use the standard keycodes.Signed-off-by: Mauro Carvalho Chehab
Signed-off-by: Jarod Wilson -
On a few places, KEY_MHP were used for snapshots. However, KEY_CAMERA
is used for it on all the other keyboards that have a snapshot/Picture
button.Signed-off-by: Mauro Carvalho Chehab
Signed-off-by: Jarod Wilson -
status now returns
FE_HAS_CARRIER
FE_HAS_SIGNAL
FE_HAS_VITERBISigned-off-by: Malcolm Priestley
Signed-off-by: Mauro Carvalho Chehab -
The CellsCoeffs arrays are [3][6][5] not [2][6][5].
Signed-off-by: Dan Carpenter
Cc: Igor M. Liplianin
Signed-off-by: Mauro Carvalho Chehab -
We use err to store negative error codes so it should be signed. And
if we return an error from stv0367_get_tuner_freq() that needs to be
handled properly as well. (param->frequency is a u32).Signed-off-by: Dan Carpenter
Signed-off-by: Mauro Carvalho Chehab -
Use 32 bit decoding to add support for more than one variant of remote
control.Signed-off-by: Malcolm Priestley
Signed-off-by: Mauro Carvalho Chehab -
Old versions of these boxes have the BS2F7HZ0194 tuner module on
both the LME2510 and LME2510C.Firmware dvb-usb-lme2510-s0194.fw and/or dvb-usb-lme2510c-s0194.fw
files are required.See Documentation/dvb/lmedm04.txt
Signed-off-by: Malcolm Priestley
Signed-off-by: Mauro Carvalho Chehab
22 Mar, 2011
27 commits
-
On Thu, 17 Feb 2011, Matthias Schwarzott wrote:
> On Sunday 06 February 2011, Jesper Juhl wrote:
> > If the memory allocation to 'state' succeeds but we jump to the 'error'
> > label before 'state' is assigned to fe->tuner_priv, then the call to
> > 'zl10036_release(fe)' at the 'error:' label will not free 'state', but
> > only what was previously assigned to 'tuner_priv', thus leaking the memory
> > allocated to 'state'.
> > There are may ways to fix this, including assigning the allocated memory
> > directly to 'fe->tuner_priv', but I did not go for that since the
> > additional pointer derefs are more expensive than the local variable, so I
> > just added a 'kfree(state)' call. I guess the call to 'zl10036_release'
> > might not even be needed in this case, but I wasn't sure, so I left it in.
> >
> Yeah, that call to zl10036_release can be completely eleminated.
> Another thing is: jumping to the error label only makes sense when memory was
> already allocated. So the jump in line 471 can be replaced by "return NULL",
> as the other error handling before allocation:
> if (NULL == config) {
> printk(KERN_ERR "%s: no config specified", __func__);
> goto error;
> }
>
> I suggest to improve the patch to clean the code up when changing that.
>
> But I am fine with commiting this patch also if you do not want to change it.
>Thank you for your feedback. It makes a lot of sense.
Changing it is not a problem :)
How about the updated patch below?If the memory allocation to 'state' succeeds but we jump to the 'error'
label before 'state' is assigned to fe->tuner_priv, then the call to
'zl10036_release(fe)' at the 'error:' label will not free 'state', but
only what was previously assigned to 'tuner_priv', thus leaking the memory
allocated to 'state'.
This patch fixes the leak and also does not jump to 'error:' before mem
has been allocated but instead just returns. Also some small style
cleanups.Signed-off-by: Jesper Juhl
Signed-off-by: Matthias Schwarzott
Signed-off-by: Mauro Carvalho Chehab -
Split FW download packages smarter way and bug free. Implementation is
based of Andrea Merello's example he provided for tda18218 driver.
Count remaining FW bytes down in loop instead of division and modulo
combination used earlier.Thanks to: Andrea Merello
Signed-off-by: Antti Palosaari
Cc: Andrea Merello
Signed-off-by: Mauro Carvalho Chehab -
Quick test shows that FW must be running before other checks
so make it happen earlier.Signed-off-by: Antti Palosaari
Signed-off-by: Mauro Carvalho Chehab -
Split FW download packages smarter way and bug free. Implementation is
based of Andrea Merello's example he provided for tda18218 driver.
Count remaining FW bytes down in loop instead of division and modulo
combination used earlier.Thanks-to: Andrea Merello
Signed-off-by: Antti Palosaari
Cc: Andrea Merello
Signed-off-by: Mauro Carvalho Chehab -
Map rc-terratec-slim-2 for TerraTec Cinergy T Stick RC device.
Signed-off-by: Antti Palosaari
Cc: Martin Groszhauser
Cc: TerraTux
Signed-off-by: Mauro Carvalho Chehab -
Signed-off-by: Antti Palosaari
Signed-off-by: Mauro Carvalho Chehab -
Patch from Ian Armstrong.
I've encountered a couple of problems with the current af9015 driver as
supplied with the 2.6.37 kernel, that the attached patch appears to fix. (I've
generated this patch against the current v4l-dvb git).Some key-presses are lost. A key-press is only generated upon 'valid' data
(buf[14] == (u8) ~buf[15]), but the buffer is wiped before this check.
Sometimes the 15th byte has not been set at the time of read, so the data
isn't valid & ignored. On the next poll the 15th byte has been set, but the
rest of the data was wiped previously, so the data is still invalid & the key
is lost.Weird repeat error, where an old key press is sometimes repeated in error. ie.
button sequence '1 (pause) 2 (pause) 3 (pause) 4' generates output like '1
(pause) 2 (pause) 23 (pause) 4'. The current driver zeroes the data for the
key pushed, but sometimes this data is already zero but with other bytes set
suggesting a repeat code. This results in the last key being incorrectly
repeated.This patch attempts to reduce the risk of a missed key-press & also stop the
random repeat of an old key-press when a new key is pressed.Signed-off-by: Ian Armstrong
Signed-off-by: Antti Palosaari
Signed-off-by: Mauro Carvalho Chehab -
Signed-off-by: Abylay Ospan
Signed-off-by: Mauro Carvalho Chehab -
Signed-off-by: Abylay Ospan
Signed-off-by: Mauro Carvalho Chehab -
drivers/media/dvb/frontends/stv0367.c: In function 'stv0367ter_lock_algo':
drivers/media/dvb/frontends/stv0367.c:1315:2: warning: cast from pointer to integer of different sizeUse %p to print addresses instead of 0x%x.
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Signed-off-by: Igor M. Liplianin
Signed-off-by: Mauro Carvalho Chehab -
Related to Acorp DS120 and some revisions of DVBWorld DW2102.
If you read three or more registers at one time, you get wrong value for third etc.
Actually, it didn't affect the driver as it reads registers only by one at a time.
But it needs to correct.Signed-off-by: Igor M. Liplianin
Signed-off-by: Mauro Carvalho Chehab -
Prof 7500 and TeVii s630, s660, s480 works better now
Signed-off-by: Igor M. Liplianin
Signed-off-by: Mauro Carvalho Chehab -
Prof 7500 and TeVii s630, s660, s480 works faster now
Signed-off-by: Igor M. Liplianin
Signed-off-by: Mauro Carvalho Chehab -
The card consist of PCI to USB bridge and USB DVB-S2 receiver.
Signed-off-by: Igor M. Liplianin
Signed-off-by: Mauro Carvalho Chehab -
It is taken from another tree, where it is modified.
Patch to fix thatSigned-off-by: Igor M. Liplianin
Signed-off-by: Mauro Carvalho Chehab -
Signed-off-by: Abylay Ospan
Signed-off-by: Mauro Carvalho Chehab -
Simptoms:
After zapping DVB-S2 channel searching for DVB-S tooks long time.
Now it takes less than a second.Signed-off-by: Igor M. Liplianin
Signed-off-by: Mauro Carvalho Chehab -
dib9000_mbx_send_attr() returns an int. It doesn't work to save
negative error codes in an unsigned char, so I've made "ret" an int
type.Signed-off-by: Dan Carpenter
Signed-off-by: Mauro Carvalho Chehab -
kfree(state) if fe allocation fails.
Signed-off-by: Dan Carpenter
Signed-off-by: Mauro Carvalho Chehab -
Based on staging 2.6.39.
This patch is based on Veit Berwig's work.
Signed-off-by: Lukas Fisch
Thanks-to: Veit Berwig
Signed-off-by: Mauro Carvalho Chehab -
kmalloc() can fail so check whether state->internal is NULL.
append_internal() can return NULL on allocation failures so check that.
Also if we hit the error condition later in the function then there is
a memory leak and we need to call remove_dev() to fix it.Also Oliver Endriss pointed out an additional leak that I missed in the
first version of this patch.Signed-off-by: Dan Carpenter
Acked-by: Oliver Endriss
Signed-off-by: Mauro Carvalho Chehab -
The card uses ds3000 demod from Montage.
Signed-off-by: Igor M. Liplianin
Signed-off-by: Mauro Carvalho Chehab -
Signed-off-by: Igor M. Liplianin
Signed-off-by: Mauro Carvalho Chehab -
Signed-off-by: Igor M. Liplianin
Signed-off-by: Mauro Carvalho Chehab -
All necessary parameters already stored in frontend cache.
Signed-off-by: Igor M. Liplianin
Signed-off-by: Mauro Carvalho Chehab -
Variable 'retune' does not make sense.
Loop is not needed for only one try.
Remove unnecessary dprintk's.
Remove a lot of debug messages and delays.Signed-off-by: Igor M. Liplianin
Signed-off-by: Mauro Carvalho Chehab
