29 Jan, 2018
40 commits
-
checkpatch.pl complains about the spelling of ERR_TIMOUT. Since the
error is only used in a handful of files, we rename the error to
ERR_TIMEOUT.Signed-off-by: Mario Six
Signed-off-by: Stefan Roese -
Camel-case naming should be avoided. Rename two camel-case variables,
and fix their usage accordingly.Signed-off-by: Mario Six
Signed-off-by: Stefan Roese -
Strings should not be split accross multiple lines. Where possible and
not detrimental to readability, fix the instances where this occurs.Signed-off-by: Mario Six
Signed-off-by: Stefan Roese -
According to the C standard, pointer arithmetic for pointers of type
void is undefined behavior (the assumption that they're 8-bit wide is a
GCC-specific assumption). In the interest of keeping the code
standards-compliant, and also better communicate intent, switch all
void* variables where pointer arithmetic is used to u8* variables.Signed-off-by: Mario Six
Signed-off-by: Stefan Roese -
The condition in if statements should not be used for variable
assignment. Instead, the assignment should be done in a separate step
beforehand. Fix all instances where this occurs.Signed-off-by: Mario Six
Signed-off-by: Stefan Roese -
void functions don't need an explicit return at the end.
Signed-off-by: Mario Six
Signed-off-by: Stefan Roese -
The opening brace of block statements should be attached to the
statement itself, and not be on a separate line.Signed-off-by: Mario Six
Signed-off-by: Stefan Roese -
If in a loop, the if block in a if/else statement ends in a break, the
statements in the else blockcan be extracted, since the break stops the
execution.Signed-off-by: Mario Six
Signed-off-by: Stefan Roese -
"Unkown" should be spelled "Unknown".
Signed-off-by: Mario Six
Signed-off-by: Stefan Roese -
In if/else statements, either both blocks (if and else) should have
braces or both blocks should not have braces, but mixed configurations
are discouraged. Fix all instances where this occurs.Signed-off-by: Mario Six
Signed-off-by: Stefan Roese -
"==" and "!=" bind tighter than the boolean operators, so parentheses
around them in compound logical statements are unnecessary. Fix all
instances where this occurs.Signed-off-by: Mario Six
Signed-off-by: Stefan Roese -
Comment blocks should end with a "*/" on a separate line, not with the
"*/" attached to the end of the last line of text. Fix all instances
where this occurs.Signed-off-by: Mario Six
Signed-off-by: Stefan Roese -
printf/debug statements should not include the file name as a hardcoded
string, but instead use the __func__ macro. Fix all instances where this
occurs.Signed-off-by: Mario Six
Signed-off-by: Stefan Roese -
When splitting long logical statements across multiple lines, the
logical operators should be at the end of the lines. Fix all instances
where this occurs.Signed-off-by: Mario Six
Signed-off-by: Stefan Roese -
Blocks with a single statement should not be enclosed in braces. Fix all
instances where this occurs.Signed-off-by: Mario Six
Signed-off-by: Stefan Roese -
There should be no consecutive blank lines, and no blank lines at the
end of blocks. But there should be blank lines between variable
declarations and code. Fix all instances where either occurs.Signed-off-by: Mario Six
Signed-off-by: Stefan Roese -
There should be spaces around operators, and no spaces between a cast
and the variable its being applied to. Fix all instances where this
occurs.Signed-off-by: Mario Six
Signed-off-by: Stefan Roese -
case statements should be at the same level of indent as the switch
keyword. Fix all instances where this occurs.Signed-off-by: Mario Six
Signed-off-by: Stefan Roese -
When casting to a pointer type, the asterisk should be attached to the
type name, not separated by a space. Fix all instances where this
occurs.Signed-off-by: Mario Six
Signed-off-by: Stefan Roese -
There should not be additional spaces when nesting parentheses
("( (...) )"). Fix all instances where this occurs.Signed-off-by: Mario Six
Signed-off-by: Stefan Roese -
In a pointer declaration there should not be a space between the
asterisk and the pointer name. Fix all instances where this occurs.Signed-off-by: Mario Six
Signed-off-by: Stefan Roese -
There should not be a space between a function name and a parenthesis
("func (...)"). Fix all instances where this occurs.Signed-off-by: Mario Six
Signed-off-by: Stefan Roese -
Patch queue for efi - 2018-01-28
This is the second part of patches for 2018.03-rc1, fixing
a few minor issues and adding a readme file for iSCSI booting. -
The appended README explains how U-Boot and iPXE can be used
to boot a diskless system from an iSCSI SAN.The maintainer for README.efi and README.iscsi is set.
Signed-off-by: Heinrich Schuchardt
[agraf: s/Adress/Address/]
Signed-off-by: Alexander Graf -
Now that we have %pD support in vsprintf we should avoid separate
logic for printing device paths in other places.Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
In an image is loaded from memory we do not have a device path.
Do not install NULL as device path in this case.Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
When printing '%pD' with a value of NULL we want to output
''. But this requires copying to buf. Leave this
to string16.A unit test is supplied which relies on EFI support in the sandbox.
The development for EFI support in the sandbox is currently in branch
u-boot-dm/efi-working. The branch lacks commit 6ea8b580f06b ("efi_loader:
correct DeviceNodeToText for media types"). Ater rebasing the aforementioned
branch on U-Boot v2018.01 and adding 256060e4257a2 and this patch the test
is executed successfully.Fixes: 256060e4257a2 (vsprintf.c: add EFI device path printing)
Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
When a UEFI payload just returns instead of calling the Exit() callback,
we handle that in efi_do_enter() and call Exit on its behalf, so that
the loaded_image->exit_status value is correct.We were missing that logic in StartImage(). Call it there too.
Reported-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
Provide a better description for indent_string.
Fix a typo.Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
If 'bootefi hello' or 'bootefi selftest' can be executed depends on the
configuration.If an invalid non-numeric 1st argument is passed to bootefi, e.g.
'bootefi hola', this string is converted to 0 and U-Boot jumps to
this typically invalid address.With the patch the online help is shown instead.
Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
EFI calls are usually defined as asmlinkage. That means we pass all parameters
to functions via the stack x86_32.On x86_64 however, we need to also stick to the MS ABI calling conventions,
which the EFIAPI define conveniently handles for us. Most EFI functions were
also marked with EFIAPI, except for the entry call.So this patch adjusts all entry calls to use EFIAPI instead of the manual
asmlinkage attribute.While at it, we also change the prototype of the entry point to return
efi_status_t instead of ulong, as this is the correct prototype definition.Signed-off-by: Alexander Graf
---
v1 -> v2:
- Use efi_status_t in all occurences
-
We have 2 users of the EFI headers: efi_loader and the EFI stub. Efi_loader
always expects that the bitness of the definitions it uses is identical to
the execution.The EFI stub however allows to run x86_64 U-Boot on 32bit EFI and the other
way around, so it allows for different bitness of EFI definitions and U-Boot
environment.This patch explicitly requests via Kconfig that efi_loader can only be enabled
if the bitness is identical. Because we can run efi_loader on x86_64 without
EFI stub enabled, it also ensures that this case propagates the correct ABI
constraints.Signed-off-by: Alexander Graf
-
The SOM has external pull-up resistors, so let's turn these off.
It was helping reduce some errors when running I2C1 @ 2.6MHz.Signed-off-by: Adam Ford
-
Selecting this option will reduce SPL boot time by approx. 6 ms
(e. g. with 70 bytes long banner string at 115200 baud).Signed-off-by: Anatolij Gustschin
Tested-by: Lukasz Majewski
Reviewed-by: Philipp Tomsich -
The serial drivers now depend on the pinctrl driver to determine whether
they are enabled. That means if a serial device wants to be used pre-reloc,
we also need the pinctrl device pre-reloc.Adapt the pinctrl driver as well as dts overlay accordingly.
Signed-off-by: Alexander Graf
-
On bcm2835 we need to ensure we only access serial devices that are
muxed to the serial output pins of the pin header. To achieve this
for the pl011 device, add a bcm2835 specific pl011 wrapper device
that does this check but otherwise behaves like a pl011 device.Signed-off-by: Alexander Graf
-
It seems as if I have more interest in BCM2835 support than most others,
so I'll bite the bullet and declare myself maintainer. It'd be a shame
to leave that platform orphaned.Signed-off-by: Alexander Graf
-
Setting config options using headers is deprecated. This patch converts
the BCM2835 Mini-UART to Kconfig.Signed-off-by: Alexander Graf
-
We want to use Kconfig logic to depend on whether pl01x devices
are built in, so let's convert their inclusion selection to Kconfig.This round goes to pl01x.
Signed-off-by: Alexander Graf
