Eric Lee / smarc-uboot

09 Jan, 2015

1 commit

  • b349abbfe   gpt: Fix the protective MBR partition size ... Browse Code »

    According to the UEFI Spec (Table 16, section 5.2.3 of the version 2.4 Errata
    B), the protective MBR partition record size must be set to the size of the
    disk minus one, in LBAs.

    However, the current code was setting the size as the total number of LBAs on
    the disk, resulting in an off-by-one error.

    This confused the AM335x ROM code, and will probably confuse other tools as
    well.

    Signed-off-by: Maxime Ripard

    Maxime Ripard
     

18 Dec, 2014

2 commits

27 Nov, 2014

1 commit

25 Oct, 2014

1 commit

25 Sep, 2014

1 commit

22 Jul, 2014

1 commit

24 Jun, 2014

1 commit

  • 4d907025d   sandbox: restore ability to access host fs through standard commands ... Browse Code »

    Commit 95fac6ab4589 "sandbox: Use os functions to read host device tree"
    removed the ability for get_device_and_partition() to handle the "host"
    device type, and redirect accesses to it to the host filesystem. This
    broke some unit tests that use this feature. So, revert that change. The
    code added back by this patch is slightly different to pacify checkpatch.

    However, we're then left with "host" being both:
    - A pseudo device that accesses the hosts real filesystem.
    - An emulated block device, which accesses "sectors" inside a file stored
    on the host.

    In order to resolve this discrepancy, rename the pseudo device from host
    to hostfs, and adjust the unit-tests for this change.

    The "help sb" output is modified to reflect this rename, and state where
    the host and hostfs devices should be used.

    Signed-off-by: Stephen Warren
    Tested-by: Josh Wu
    Acked-by: Simon Glass
    Tested-by: Simon Glass

    Stephen Warren
     

12 Jun, 2014

2 commits

  • ecdd57e27   disk: default to HW partition 0 if not specified ... Browse Code »

    Currently, get_device()/get_dev_hwpart() for MMC devices does not select
    an explicit HW partition unless the user explicitly requests one, i.e. by
    requesting device "mmc 0.0" rather than just "mmc 0". I think it makes
    more sense if the default is to select HW partition 0 (main data area)
    if the user didn't request a specific partition. Otherwise, the following
    happens, which feels wrong:

    Select HW partition 1 (boot0):
    mmc dev 0 1

    Attempts to access SW partition 1 on HW partition 1 (boot0), rather than
    SW partition 1 on HW partition 0 (main data area):
    ls mmc 0:1 /

    With this patch, the second command above re-selects the main data area.

    Many device types don't support HW partitions at all, so if HW partition
    0 is selected (either explicitly or as the default) and there's no
    select_hwpart function, we simply skip attempting to select a HW
    partition.

    Some MMC devices (i.e. SD cards) don't support HW partitions. However,
    this patch still works, since mmc_start_init() sets the current
    partition number to 0, and mmc_select_hwpart() succeeds if the requested
    partition is already selected.

    Signed-off-by: Stephen Warren
    Acked-by: Pantelis Antoniou

    Stephen Warren
     
  • 4a36be9bd   disk: part_dos.c: Add a PBR check when MBR checking fails ... Browse Code »

    Bug: SDCard with a messed up partition but still has a FAT signature
    intact is readable in Linux but unreadable in uboot with 'fatls'.

    Fix: When partition info checking fails, there is no checking for a
    FAT signature (DOS_PBR) which will fail 'fatls'. FAT signature checking
    is done when no valid partition is found in partition table. If FAT
    signature is found, the disk will be read as PBR and continue
    processing.

    Signed-off-by: Darwin Dingel

    Darwin Dingel
     

06 Jun, 2014

3 commits

23 May, 2014

2 commits

  • d23562843   mmc: provide a select_hwpart implementation for get_device() ... Browse Code »

    This enables specifying which eMMC HW partition to target for any U-Boot
    command that uses the generic get_partition() function to parse its
    command-line arguments.

    Acked-by: Pantelis Antoniou
    Signed-off-by: Stephen Warren

    Stephen Warren
     
  • 336b6f904   disk: support devices with HW partitions ... Browse Code »

    Some device types (e.g. eMMC) have hardware-level partitions (for eMMC,
    separate boot and user data partitions). This change allows the user to
    specify the HW partition they wish to access when passing a device ID to
    U-Boot Commands such as part, ls, load, ums, etc.

    The syntax allows an optional ".$hwpartid" to be appended to the device
    name string for those commands.

    Existing syntax, for MMC device 0, default HW partition ID, SW partition
    ID 1:

    ls mmc 0:1 /

    New syntax, for MMC device 0, HW partition ID 1 (boot0), SW partition
    ID 2:

    ls mmc 0.1:2 /

    For my purposes, this is most useful for the ums (USB mass storage
    gadget) command, but there's no reason not to allow the new syntax
    globally.

    This patch adds the core support infra-structure. The next patch will
    provide the implementation for MMC.

    Acked-by: Pantelis Antoniou
    Signed-off-by: Stephen Warren

    Stephen Warren
     

13 May, 2014

1 commit

03 Apr, 2014

2 commits

  • d718ded05   lib: uuid: code refactor for proper maintain between uuid bin and string ... Browse Code »

    Changes in lib/uuid.c to:
    - uuid_str_to_bin()
    - uuid_bin_to_str()

    New parameter is added to specify input/output string format in listed functions
    This change allows easy recognize which UUID type is or should be stored in given
    string array. Binary data of UUID and GUID is always stored in big endian, only
    string representations are different as follows.

    String byte: 0 36
    String char: xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx
    string UUID: be be be be be
    string GUID: le le le be be

    This patch also updates functions calls and declarations in a whole code.

    Signed-off-by: Przemyslaw Marczak
    Cc: Stephen Warren
    Cc: Lukasz Majewski
    Cc: trini@ti.com

    Przemyslaw Marczak
     
  • a96a0e615   part_efi: move uuid<->string conversion functions into lib/uuid.c ... Browse Code »

    This commit introduces cleanup for uuid library.
    Changes:
    - move uuidstring conversion functions into lib/uuid.c so they can be
    used by code outside part_efi.c.
    - rename uuid_string() to uuid_bin_to_str() for consistency with existing
    uuid_str_to_bin()
    - add an error return code to uuid_str_to_bin()
    - update existing code to the new library functions.

    Signed-off-by: Przemyslaw Marczak
    Cc: Stephen Warren
    Cc: Lukasz Majewski
    Cc: trini@ti.com

    Przemyslaw Marczak
     

18 Mar, 2014

1 commit

  • 95fac6ab4   sandbox: Use os functions to read host device tree ... Browse Code »
    46

    At present we use U-Boot's filesystem layer to read the sandbox device tree,
    but this is problematic since it relies on a temporary feauture added
    there. Since we plan to implement proper block layer support for sandbox,
    change this code to use the os layer functions instead. Also use the new
    fdt_create_empty_tree() instead of our own code.

    Signed-off-by: Simon Glass

    Simon Glass
     

24 Feb, 2014

1 commit

  • 61fcc7d27   part_efi: fix protective mbr struct allocation ... Browse Code »

    The calloc() call was allocating space for the sizeof the struct
    pointer rather than for the struct contents.
    Besides, since this buffer is passed to mmc for writing and some
    platforms may use cache, the legacy_mbr struct should be cache-aligned.

    Signed-off-by: Hector Palacios
    Tested-by: Lukasz Majewski

    Hector Palacios
     

20 Feb, 2014

1 commit

  • 6825a95b0   kbuild: use Linux Kernel build scripts ... Browse Code »

    Now we are ready to switch over to real Kbuild.

    This commit disables temporary scripts:
    scripts/{Makefile.build.tmp, Makefile.host.tmp}
    and enables real Kbuild scripts:
    scripts/{Makefile.build,Makefile.host,Makefile.lib}.

    This switch is triggered by the line in scripts/Kbuild.include
    -build := -f $(if $(KBUILD_SRC),$(srctree)/)scripts/Makefile.build.tmp obj
    +build := -f $(if $(KBUILD_SRC),$(srctree)/)scripts/Makefile.build obj

    We need to adjust some build scripts for U-Boot.
    But smaller amount of modification is preferable.

    Additionally, we need to fix compiler flags which are
    locally added or removed.

    In Kbuild, it is not allowed to change CFLAGS locally.
    Instead, ccflags-y, asflags-y, cppflags-y,
    CFLAGS_$(basetarget).o, CFLAGS_REMOVE_$(basetarget).o
    are prepared for that purpose.

    Signed-off-by: Masahiro Yamada
    Tested-by: Gerhard Sittig

    Masahiro Yamada
     

09 Jan, 2014

1 commit

  • f4d8de48f   sandbox: block driver using host file/device as backing store ... Browse Code »

    Provide a way to use any host file or device as a block device in U-Boot.
    This can be used to provide filesystem access within U-Boot to an ext2
    image file on the host, for example.

    The support is plumbed into the filesystem and partition interfaces.

    We don't want to print a message in the driver every time we find a missing
    device. Pass the information back to the caller where a message can be printed
    if desired.

    Signed-off-by: Henrik Nordström
    Signed-off-by: Simon Glass
    - Removed change to part.c get_device_and_partition()

    Signed-off-by: Simon Glass
    Reviewed-by: Simon Glass

    Henrik Nordström
     

01 Nov, 2013

1 commit

15 Oct, 2013

1 commit

20 Sep, 2013

1 commit

  • 6d2ee5a33   part_efi: make sure the gpt_pte is freed ... Browse Code »

    the gpt_pte wasn't being freed if it was checked against an invalid
    partition. The resulting memory leakage could make it impossible
    to repeatedly attempt to load non-existent files in a script.

    Also, downgrade the message for not finding an invalid partition
    from a printf() to a debug() so as to minimize message spam in
    perfectly normal situations.

    Signed-off-by: Mark Langsdorf

    Mark Langsdorf
     

24 Jul, 2013

1 commit

22 Jul, 2013

1 commit

  • 50ffc3b64   fs/ext4: fix log2blksz un-initialized error, by cacaulating its value from blksz ... Browse Code »

    The problem here is that uboot can't mount ext4 filesystem with
    commit "50ce4c07df1" applied. We use hard-coded "SECTOR_SIZE"(512)
    before this commit, now we introduce (block_dev_desc_t *)->log2blksz
    to replace this macro. And after we calling do_ls()->fs_set_blk_dev(),
    the variable log2blksz is not initialized, which it's not correct.

    And this patch try to solve the problem by caculating the value of
    log2blksz from variable blksz.

    Lan Yixun (dlan)
     

16 Jul, 2013

1 commit

  • 04735e9c5   Fix ext2/ext4 filesystem accesses beyond 2TiB ... Browse Code »

    With CONFIG_SYS_64BIT_LBA, lbaint_t gets defined as a 64-bit type,
    which is required to represent block numbers for storage devices that
    exceed 2TiB (the block size usually is 512B), e.g. recent hard drives

    We now use lbaint_t for partition offset to reflect the lbaint_t change,
    and access partitions beyond or crossing the 2.1TiB limit.
    This required changes to signature of ext4fs_devread(), and type of all
    variables relatives to block sector.

    ext2/ext4 fs uses logical block represented by a 32 bit value. Logical
    block is a multiple of device block sector. To avoid overflow problem
    when calling ext4fs_devread(), we need to cast the sector parameter.

    Signed-off-by: Frédéric Leroy

    Frederic Leroy
     

05 Jun, 2013

1 commit

  • 67cd4a634   disk: Fix possible out-of-bounds access in part_efi.c ... Browse Code »

    Make sure to never access beyond bounds of either EFI partition name
    or DOS partition name. This situation is happening:

    part.h: disk_partition_t->name is 32-byte long
    part_efi.h: gpt_entry->partition_name is 36-bytes long

    The loop in part_efi.c copies over 36 bytes and thus accesses beyond
    the disk_partition_t->name .

    Fix this by picking the shortest of source and destination arrays and
    make sure the destination array is cleared so the trailing bytes are
    zeroed-out and don't cause issues with string manipulation.

    Signed-off-by: Marek Vasut
    Cc: Tom Rini
    Cc: Simon Glass

    Marek Vasut
     

02 May, 2013

3 commits

  • d7ea4d4d4   disk/iso: Add Support for block sizes > 512 byte to ISO partition support ... Browse Code »

    For ISO we check the block size of the device if this is != the CD sector
    size we assume that the device has no ISO partition.

    Signed-off-by: Egbert Eich

    Egbert Eich
     
  • ae1768a72   disk/gpt: Fix GPT partition handling for blocksize != 512 ... Browse Code »

    Disks beyond 2T in size use blocksizes of 4096 bytes. However a lot of
    code in u-boot still assumes a 512 byte blocksize.
    This patch fixes the handling of GPTs.

    Signed-off-by: Egbert Eich

    Egbert Eich
     
  • 9d956e0fe   disk/part_dos: check harder for partition table ... Browse Code »

    Devices that used to have a whole disk FAT filesystem but got then
    partitioned will most likely still have a FAT or FAT32 signature
    in the first sector as this sector does not get overwritten by
    a partitioning tool (otherwise the tool would risk to kill the mbr).

    The current partition search algorithm will erronously detects such
    a device as a raw FAT device.

    Instead of looking for the FAT or FAT32 signatures immediately we
    use the same algorithm as used by the Linux kernel and first check
    for a valid boot indicator flag on each of the 4 partitions.
    If the value of this flag is invalid for the first entry we then
    do the raw partition check.
    If the flag for any higher partition is wrong we assume the device
    is neiter a MBR nor PBR device.

    Signed-off-by: Egbert Eich

    Egbert Eich
     

03 Apr, 2013

1 commit

15 Mar, 2013

1 commit

05 Mar, 2013

1 commit

14 Dec, 2012

3 commits

07 Dec, 2012

1 commit

  • 33699df12   part: check each variable for capability calculation ... Browse Code »

    In order to calculate the capability, we use the below expression to check:
    ((dev_desc->lba * dev_desc->blksz)>0L)
    If the capability is greater than 4GB (e.g. 8GB = 8 * 1024 * 104 * 1024),
    the result will overflow, the low 32bit may be zero.

    Therefore, change to check each variable to fix this potential issue.

    Signed-off-by: Jerry Huang

    Jerry Huang
     

22 Oct, 2012

1 commit