11 Nov, 2014
8 commits
-
Signed-off-by: Tom Rini
-
This patch adds support for comments in the input to mkenvimage, i.e. in
the environment source: All lines starting with a # in the firs column
will be ignored.Additionally empty lines will also be ignored.
Signed-off-by: Dominik Muth
-
In a message from Wolfgang Denk highlighting warnings from cppcheck,
the patch will address those that are correctly diagnosed. Some are
false-positives:> [fs/zfs/zfs.c:937]: (error) Memory leak: l
dmu_read() allocates "l" if successful, so error-case should not free
it.
> [fs/zfs/zfs.c:1141]: (error) Memory leak: dnbuf
dmu_read() allocates "dnbuf" if successful, so error-case should not
free it.
> [fs/zfs/zfs.c:1372]: (error) Memory leak: osp
zio_read() allocates "osp" if successful, so error-case should
not free it.
> [fs/zfs/zfs.c:1726]: (error) Memory leak: nvlist
int_zfs_fetch_nvlist() allocates "nvlist" if successful, so error-case
should not free it.Signed-off-by: Jorgen Lundman
-
cppcheck reports:
[board/esd/common/auto_update.c:458]: (error) Uninitialized variable: cnt
The variable is not really used anywhere, so remove it.
Signed-off-by: Wolfgang Denk
Cc: Matthias Fuchs
Acked-by: Matthias Fuchs -
cppcheck reports:
[arch/arm/cpu/arm926ejs/mxs/timer.c:96]: (error) Uninitialized
variable: nowSigned-off-by: Wolfgang Denk
Cc: Marek Vasut
Cc: Stefano Babic
10 Nov, 2014
6 commits
-
In case of repeated START condition, the restart has to be kicked
before clear status (MSR register). If it is kicked after clear status,
R-Car I2C may transfer data (TXD register) or receive data (RXD register)
instead of transferring slave address (MAR register).Signed-off-by: Ryo Kataoka
Signed-off-by: Nobuhiro Iwamatsu -
Some slow I2C devices like Power Monitor(ZM7304) at times
do not work well with low timeout value, so I2C bus get stuck
during read cycle with this device, changing it to 100ms from
10ms works fineA lot of other i2c drivers like mxc and i2c drivers of BOOTROM
also use relax timeouts to give sufficient ticks to work well
with slower devicesSigned-off-by: Shaveta Leekha
Signed-off-by: Poonam Aggrwal -
ppc4xx i2c master gets stuck on errors while repeated start is
active. Can be easily reproduced by "i2c md" on an unpopulated
i2c address. There is not stop condition given, scl remains
pulled low.
The only way out seems to be doing a stop manually and then a
soft reset.Signed-off-by: Dirk Eibach
Reviewed-by: Stefan Roese -
Debugging some i2c trouble I saw on my scope that repeated
start is not working properply. The 4xx even held clock pulled down
after transfers. Having a look in the driver I realized
that IIC_CNTL_RPST is set on that part of the transfer that should
begin with a repeated start. But repeated start is about not sending a
stop condition, so IIC_CNTL_RPST has to be set on the last transfer
before the repeated start happens.Signed-off-by: Dirk Eibach
Reviewed-by: Stefan Roese -
Signed-off-by: Sonic Zhang
-
Remove BFIN from the CPU macro in Makefile.
Signed-off-by: Sonic Zhang
08 Nov, 2014
26 commits
-
Fix error detected by cppcheck:
[board/matrix_vision/mvblx/sys_eeprom.c:353]: (error) Buffer is
accessed out of bounds.Signed-off-by: Wolfgang Denk
cc: Michael Jones
Acked-by: Michael Jones -
This file got corrupted by the automatic editin of commit 1a45966 "Add
GPL-2.0+ SPDX-License-Identifier to source files"; restore the
opiginal content and manually insert the SPDX ID.The bug was detected by running cppcheck, which reported:
[common/cmd_fitupd.c:8]: (error) Invalid number of character ({) when
these macros are defined: 'CONFIG_UPDATE_TFTP'.Signed-off-by: Wolfgang Denk
-
Fix error detected by cppcheck:
[drivers/net/uli526x.c:551]: (error) printf format string requires 3
parameters but only 2 are given.Signed-off-by: Wolfgang Denk
Cc: Roy Zang -
Fix error detected by cppcheck:
[board/cogent/lcd.c:237]: (error) Invalid number of character (()
when these macros are defined:
'CONFIG_SHOW_ACTIVITY;CONFIG_STATUS_LED'.Signed-off-by: Wolfgang Denk
-
There are a number of places where U-Boot intentionally and legally
accesses physical address 0x0000, for example when installing
exception vectors on systems where these are located in low memory.Add "cppcheck-suppress nullPointer" comments to silence cppcheck
where this is intentional and legal.Signed-off-by: Wolfgang Denk
-
Correct environment variable for output directory is KBUILD_OUTPUT.
Signed-off-by: Timo Ketola
-
On architectures where 'long' is 64 bit, the u-boot environment
as seen by the fw_env tools was missing 4 bytes.
This patch fixes getenvsize(), and thus also ensures that the
environment's CRC32 checksum is calculated correctly.Signed-off-by: Dominic Sacré
Cc: Wolfgang Denk
Cc: Tom Rini -
All the other files in drivers/mtd/* are not really CFI related. So lets
only include the files that are CFI specific.Signed-off-by: Stefan Roese
Cc: Heiko Schocher
Cc: Scott Wood
Cc: Masahiro Yamada
Cc: Jagan Teki
Acked-by: Jagannadha Sutradharudu Teki
Acked-by: Heiko Schocher -
This commit imports some updates in misc scripts from Linux 3.18-rc1.
[1] commit cbb4d3e6510b99522719c5ef0 by Horia Geanta
scripts/kernel-doc: handle object-like macros[2] commit 164f0d2efaaef83 by Michal Marek
kbuild: Fix handling of backslashes in *.cmd files[3] commit 270a00963cd367214e by Randy Dunlap
scripts/kernel-doc: recognize __meminit[4] commit a4954fd7724c0f55361eb5 by Masahiro Yamada
kbuild: remove obj-n and lib-n handling[5] commit 5b2389b45d1a9c12b9f by Masahiro Yamada
kbuild: simplify build, clean, modbuiltin shorthandsSigned-off-by: Horia Geanta
Signed-off-by: Michal Marek
Signed-off-by: Randy Dunlap
Signed-off-by: Masahiro Yamada -
This commit imports Kconfig updates from Linux 3.18-rc1.
'kvmconfig' and 'tinyconfig' help message have been commented out
since they are unavailable at least now; in the future perhaps
we can implement 'tinyconfig' to disable most of CONFIG_CMD_* to
create a very small U-Boot image.[1] commit 3aaefce10351 by Josh Triplett
x86, platform, kconfig: move kvmconfig functionality to a helper[2] commit 0da1d4a0b951 by Josh Triplett
x86: Add "make tinyconfig" to configure the tiniest possible kernel[3] commit c40724d3f381 by Brian Norris
kconfig: lxdialog: fix spelling[4] commit 7285996aa000 by Brian Norris
kconfig: nconfig: fix multi-byte UTF handlingSigned-off-by: Josh Triplett
Signed-off-by: Brian Norris
Signed-off-by: Masahiro Yamada -
Since Linux 3.15, relative path feature and related fixes,
cleanups have been merged to the top Makefile.The relative path feature looks stable enough, so let's import it
to U-Boot along with various cleanups.Commits imported from Linux (some need adjustment) are:
[1] commit 7e1c04779efd by Michal Marek
kbuild: Use relative path for $(objtree)[2] commit 890676c65d69 by Michal Marek
kbuild: Use relative path when building in the source tree[3] commit 9da0763bdd82 by Michal Marek
kbuild: Use relative path when building in a subdir of the source tree[4] commit c2e28dc975ea by Michal Marek
kbuild: Print the name of the build directory[5] commit 066b7ed95580 by Michal Marek
kbuild: Do not print the build directory with make -s[6] commit 3f1d9a6cec01 by Michal Marek
kbuild: make -s should be used with kernelrelease/kernelversion/image_name[7] commit 7ff525712acf by Masahiro Yamada
kbuild: fake the "Entering directory ..." message more simply[8] commit 745a254322c8 by Masahiro Yamada
kbuild: use $(Q) for sub-make target[9] commit aa55c8e2f7a3 by Masahiro Yamada
kbuild: handle C=... and M=... after entering into build directory[10] commit ab7474ea5361 by Borislav Petkov
Kbuild: Ignore GREP_OPTIONS env variableTo use relative path feature, tools/Makefile and scripts/Makefile.autoconf
must be tweaked.Signed-off-by: Michal Marek
Signed-off-by: Borislav Petkov
Signed-off-by: Masahiro Yamada -
Since Linux 3.18-rc1, Kbuild is able to handle multi-objs
dependency correctly, which also allows us futher cleanups
of some makefiles.This commit imports those commits:
[1] commit c8589d1e9e01 by Masahiro Yamada
kbuild: handle multi-objs dependency appropriately[2] commit 97e3226e6e98 by Masahiro Yamada
kbuild: handle the dependency of multi-objs hostprogs appropriately[3] commit 022af62d0190 by Masahiro Yamada
kbuild: refactor script/kconfig/Makefile[4] commit 221ecca6cafe by Masahiro Yamada
kbuild: remove redundant clean-files from scripts/kconfig/MakefileSigned-off-by: Masahiro Yamada
-
This commit imports updates of scripts/Makefile.host
from Linux 3.18-rc1.Imported commits are:
[1] commit d8d9efe22709 by Masahiro Yamada
kbuild: fix a typo in scripts/Makefile.host[2] commit edb950c17de0 by Masahiro Yamada
kbuild: fix a bug of C++ host program handling[3] commit 62e2210798ed by Masahiro Yamada
kbuild: drop shared library support from Makefile.host[4] commit 663935593915 by Masahiro Yamada
kbuild: clean up scripts/Makefile.host[5] commit 1791ff7179f6 by Masahiro Yamada
kbuild: clean-up and bug fix of scripts/Makefile.hostSigned-off-by: Masahiro Yamada
-
Now we stick to Linux Kernel's build system, so squash
"clobber" to "clean" target.Signed-off-by: Masahiro Yamada
-
run_command() returns success even if the command had a syntax error;
correct this behaviour.Signed-off-by: Rabin Vincent
Acked-by: Simon Glass <sjg@chromium.org) -
Hush segfaults if it sees a syntax error while attempting to parse a
command:$ ./u-boot -c "'"
...
syntax error
Segmentation fault (core dumped)This is due to a NULL pointer dereference of in_str->p in static_peek().
The problem is that the exit condition for the loop in
parse_stream_outer() checks for rcode not being -1, but rcode is only
ever 0 or 1.Signed-off-by: Rabin Vincent
Acked-by: Simon Glass <sjg@chromium.org) -
Attempting to run:
- an empty string
- a string with just spacesreturns different error codes, 1 for the empty string and 0
for the string with just spaces. Make both of them return
0 for consistency.Signed-off-by: Rabin Vincent
Acked-by: Simon Glass <sjg@chromium.org) -
sandbox crashes if a variable is set in the -c command, because
hush's top_vars is not allocated. Call cli_init() from sandbox
to ensure this is done before we execute the -c command.$ ./u-boot -c 'a=1'
...
Segmentation fault (core dumped)Signed-off-by: Rabin Vincent
Acked-by: Simon Glass <sjg@chromium.org) -
Attempting to run the sandbox leads to a segfault, because some dynamic
libraries (outside of u-boot) attempt to use malloc() to allocate memory
before u-boot's gd variable is initialized.Check for gd not being NULL in the SYS_MALLOC_F_LEN handling, so that
malloc() doesn't crash when called at this point.$ gdb -q --args ./u-boot
(gdb) r
Program received signal SIGSEGV, Segmentation fault.
0x0000000000412b9b in malloc (bytes=bytes@entry=37) at common/dlmalloc.c:2184
2184 if (!(gd->flags & GD_FLG_RELOC)) {
(gdb) p gd
$1 = (gd_t *) 0x0
(gdb) bt
#0 0x0000000000412b9b in malloc (bytes=bytes@entry=37) at common/dlmalloc.c:2184
#1 0x00007ffff75bf8e1 in set_binding_values (domainname=0x7ffff11f4f12 "libgpg-error", dirnamep=0x7fffffffe168, codesetp=0x0)
at bindtextdom.c:228
#2 0x00007ffff75bfb4c in set_binding_values (codesetp=0x0, dirnamep=0x7fffffffe168, domainname=) at bindtextdom.c:350
#3 __bindtextdomain (domainname=, dirname=0x7ffff11f4f00 "/usr/share/locale") at bindtextdom.c:348
#4 0x00007ffff11eca17 in ?? () from /lib/x86_64-linux-gnu/libgpg-error.so.0
#5 0x00007ffff7dea9fa in call_init (l=, argc=argc@entry=1, argv=argv@entry=0x7fffffffe208,
env=env@entry=0x7fffffffe218) at dl-init.c:78
#6 0x00007ffff7deaae3 in call_init (env=0x7fffffffe218, argv=0x7fffffffe208, argc=1, l=) at dl-init.c:36
#7 _dl_init (main_map=0x7ffff7ffe1a8, argc=1, argv=0x7fffffffe208, env=0x7fffffffe218) at dl-init.c:126
#8 0x00007ffff7ddd1ca in _dl_start_user () from /lib64/ld-linux-x86-64.so.2Signed-off-by: Rabin Vincent
Acked-by: Simon Glass -
The pmic_spi_free function isn't ever used, and as the frameworks stand
today, cannot be, so remove it. Integrate the probe function into
pmic_reg as it's not really a "probe" today. Finally, add an err label
for the common failure cases.Cc: Lukasz Majewski
Cc: Przemyslaw Marczak
Cc: Stefano Babic
Signed-off-by: Tom Rini
Acked-by: Stefano Babic -
I believe that when no DTB is around we should return 1.
This why I fixed such scenarious to not return zero anymore.
Else kernel might get NULL pointer to DTB which doesn't exists.Signed-off-by: Noam Camus
-
Signed-off-by: Anatolij Gustschin
-
Make sure to keep the MAC address programmed in the SMC911x ADDRH
and ADDRL registers. Linux can read those registers to determine
the MAC address on EEPROM-less configurations.Signed-off-by: Marek Vasut
Cc: Joe Hershberger
Cc: Tom Rini -
Sort drivers/mmc makefile, as requested by wd.
Signed-off-by: Pavel Machek
Acked-by: Chin Liang See -
Commit 0f605c1501f6 (Start the deprecation process for generic board)
added a run-time warning message. Let's be noisier for non-generic
boards to inform the dead line of the conversion.This commit intentionally outputs a warning message to stdout.
We still have many unconverted boards. If we print the message
to stderr, MAKEALL and buildman will report tons of broken boards
and really important information will be buried.Signed-off-by: Masahiro Yamada
Acked-by: Marek Vasut
Acked-by: Simon Glass
Cc: Tom Rini
